for (;;);{"error":null,"payload":{"timeline":"\u003cdiv class=\"phui-timeline-shell\" data-sigil=\"transaction anchor-container\" data-meta=\"0_31\"\u003e\u003cdiv class=\"phui-timeline-event-view phui-timeline-minor-event\"\u003e\u003cdiv class=\"phui-timeline-content\"\u003e\u003ca style=\"background-image: url(https:\/\/code.wildfiregames.com\/file\/data\/dk74raocc3wxwourpuib\/PHID-FILE-j7ay4wouyevydwpkjbz5\/profile)\" class=\"visual-only phui-timeline-image\" href=\"\/p\/elexis\/\" aria-hidden=\"true\"\u003e\u003c\/a\u003e\u003cdiv class=\"phui-timeline-wedge\" style=\"\"\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-group\"\u003e\u003ca name=\"21542\" id=\"21542\" class=\"phabricator-anchor-view\"\u003e\u003c\/a\u003e\u003cdiv class=\"phui-timeline-title phui-timeline-title-with-icon\"\u003e\u003cspan class=\"phui-timeline-icon-fill\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-pencil phui-timeline-icon\" data-meta=\"0_30\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\u003c\/span\u003e\u003ca href=\"\/p\/elexis\/\" class=\"phui-handle phui-link-person\"\u003eelexis\u003c\/a\u003e committed \u003ca href=\"\/rP19703\" class=\"phui-handle\"\u003erP19703: STUN + XMPP ICE implementation.\u003c\/a\u003e.\u003cspan class=\"phui-timeline-extra\"\u003e\u003ca href=\"#21542\" data-sigil=\"has-tooltip\" data-meta=\"0_29\"\u003eJun 1 2017, 8:33 AM\u003c\/a\u003e\u003c\/span\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-event-view phui-timeline-spacer\"\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-shell phui-timeline-green\" data-sigil=\"transaction anchor-container\" data-meta=\"0_34\"\u003e\u003cdiv class=\"phui-timeline-event-view phui-timeline-minor-event\"\u003e\u003cdiv class=\"phui-timeline-content\"\u003e\u003cdiv class=\"phui-timeline-wedge\" style=\"display: none;\"\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-group\"\u003e\u003ca name=\"21543\" id=\"21543\" class=\"phabricator-anchor-view\"\u003e\u003c\/a\u003e\u003cdiv class=\"phui-timeline-title phui-timeline-title-with-icon\"\u003e\u003cspan class=\"phui-timeline-icon-fill fill-has-color phui-timeline-icon-fill-green\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-check-circle phui-timeline-icon\" data-meta=\"0_33\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\u003c\/span\u003e\u003ca href=\"\/harbormaster\/\" class=\"phui-handle\"\u003eHarbormaster\u003c\/a\u003e completed building \u003ca href=\"\/B2077\" class=\"phui-handle\"\u003eB2077: rP19703: STUN + XMPP ICE implementation.\u003c\/a\u003e.\u003cspan class=\"phui-timeline-extra\"\u003e\u003ca href=\"#21543\" data-sigil=\"has-tooltip\" data-meta=\"0_32\"\u003eJun 1 2017, 9:22 AM\u003c\/a\u003e\u003c\/span\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-event-view phui-timeline-spacer\"\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-shell\" data-sigil=\"transaction anchor-container\" data-meta=\"0_39\"\u003e\u003cdiv class=\"phui-timeline-event-view phui-timeline-major-event\"\u003e\u003cdiv class=\"phui-timeline-content\"\u003e\u003ca style=\"background-image: url(https:\/\/code.wildfiregames.com\/file\/data\/dk74raocc3wxwourpuib\/PHID-FILE-j7ay4wouyevydwpkjbz5\/profile)\" class=\"visual-only phui-timeline-image\" href=\"\/p\/elexis\/\" aria-hidden=\"true\"\u003e\u003c\/a\u003e\u003cdiv class=\"phui-timeline-wedge\" style=\"\"\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-group\"\u003e\u003cdiv class=\"phui-timeline-inner-content\"\u003e\u003ca name=\"21585\" id=\"21585\" class=\"phabricator-anchor-view\"\u003e\u003c\/a\u003e\u003cdiv class=\"phui-timeline-title phui-timeline-title-with-icon\"\u003e\u003cspan class=\"phui-timeline-icon-fill\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-pencil phui-timeline-icon\" data-meta=\"0_36\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\u003c\/span\u003e\u003ca href=\"\/p\/elexis\/\" class=\"phui-handle phui-link-person\"\u003eelexis\u003c\/a\u003e added inline comments.\u003cspan class=\"phui-timeline-extra\"\u003e\u003ca href=\"#21585\" data-sigil=\"has-tooltip\" data-meta=\"0_35\"\u003eJun 2 2017, 3:07 PM\u003c\/a\u003e\u003c\/span\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-core-content\"\u003e\u003ctable class=\"phabricator-inline-summary-table\"\u003e\u003ctr\u003e\u003cth colspan=\"3\" class=\"inline-comment-summary-table-header\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-file-code-o darkbluetext mmr\" data-meta=\"0_37\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\/ps\/trunk\/source\/network\/StunClient.cpp\u003c\/th\u003e\u003c\/tr\u003e\n\u003ctr\u003e\u003ctd class=\"inline-line-number inline-table-dolumn\"\u003e\u003ca href=\"#inline-420\" class=\"num\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-share darkbluetext mmr\" data-meta=\"0_38\" aria-hidden=\"true\"\u003e\u003c\/span\u003e424\u003c\/a\u003e\u003c\/td\u003e\u003ctd class=\"inline-summary-content inline-table-dolumn\" colspan=\"2\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cspan class=\"transaction-comment\" data-sigil=\"transaction-comment\" data-meta=\"0_6\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cp\u003eOne optimization here would be to abort the loop if the response was already received (just not checked for yet).\u003c\/p\u003e\n\n\u003cp\u003eAs mentioned in \u003ca href=\"\/D364\" class=\"phui-tag-view phui-tag-type-object \" data-sigil=\"hovercard\" data-meta=\"0_0\"\u003e\u003cspan class=\"phui-tag-core-closed\"\u003e\u003cspan class=\"phui-tag-core phui-tag-color-object\"\u003eD364\u003c\/span\u003e\u003c\/span\u003e\u003c\/a\u003e, this should either become threaded like the NetServer, or even not-threaded but\u003cbr \/\u003e\njust getting called onTick similar to \u003ctt class=\"remarkup-monospaced\"\u003eEngine.LobbyGuiPollMessage()\u003c\/tt\u003e and then potentially send few bytes and returning (all UDP communication is non-blocking already).\u003c\/p\u003e\u003c\/div\u003e\u003c\/span\u003e\u003c\/div\u003e\u003c\/td\u003e\u003c\/tr\u003e\u003c\/table\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-event-view phui-timeline-spacer\"\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-shell\" data-sigil=\"transaction anchor-container\" data-meta=\"0_55\"\u003e\u003cdiv class=\"phui-timeline-event-view phui-timeline-major-event\"\u003e\u003cdiv class=\"phui-timeline-content\"\u003e\u003ca style=\"background-image: url(https:\/\/code.wildfiregames.com\/file\/data\/3a4gjzuc5lvk7hgxwpra\/PHID-FILE-d4ysam54joovdlhdrdmb\/5a623d-alphanumeric_lato-dark_L.png-255%2C255%2C255%2C0.4.png)\" class=\"visual-only phui-timeline-image\" href=\"\/p\/leper\/\" aria-hidden=\"true\"\u003e\u003c\/a\u003e\u003cdiv class=\"phui-timeline-wedge\" style=\"\"\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-group\"\u003e\u003cdiv class=\"phui-timeline-inner-content\"\u003e\u003ca name=\"21628\" id=\"21628\" class=\"phabricator-anchor-view\"\u003e\u003c\/a\u003e\u003cdiv class=\"phui-timeline-title phui-timeline-title-with-icon phui-timeline-title-with-menu\"\u003e\u003cspan class=\"phui-timeline-icon-fill\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-user-plus phui-timeline-icon\" data-meta=\"0_47\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\u003c\/span\u003e\u003ca href=\"\/p\/leper\/\" class=\"phui-handle handle-availability-disabled phui-link-person\"\u003e\u003cspan class=\"perfect-circle\"\u003e\u2022\u003c\/span\u003e leper\u003c\/a\u003e added a subscriber: \u003ca href=\"\/p\/leper\/\" class=\"phui-handle handle-availability-disabled phui-link-person\" data-sigil=\"hovercard\" data-meta=\"0_12\"\u003e\u003cspan class=\"perfect-circle\"\u003e\u2022\u003c\/span\u003e leper\u003c\/a\u003e.\u003cspan class=\"phui-timeline-extra\"\u003e\u003ca href=\"#21628\" data-sigil=\"has-tooltip\" data-meta=\"0_46\"\u003eJun 3 2017, 8:17 PM\u003c\/a\u003e\u003c\/span\u003e\u003c\/div\u003e\u003ca href=\"#\" class=\"phui-timeline-menu\" aria-haspopup=\"true\" aria-expanded=\"false\" data-sigil=\"phui-dropdown-menu\" data-meta=\"0_44\"\u003e\u003cspan class=\"aural-only\"\u003eComment Actions\u003c\/span\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-caret-down\" data-meta=\"0_45\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\u003c\/a\u003e\u003cdiv class=\"phui-timeline-core-content\"\u003e\u003cspan class=\"transaction-comment\" data-sigil=\"transaction-comment\" data-meta=\"0_7\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cp\u003eMostly commenting because of that vector copy, also I do truly hope that someone checked that glooxwrapper code in detail and ran the whole thing through some tools to figure out if we aren't leaking anything.\u003c\/p\u003e\u003c\/div\u003e\u003c\/span\u003e\u003ctable class=\"phabricator-inline-summary-table\"\u003e\u003ctr\u003e\u003cth colspan=\"3\" class=\"inline-comment-summary-table-header\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-file-code-o darkbluetext mmr\" data-meta=\"0_48\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\/ps\/trunk\/source\/lobby\/XmppClient.cpp\u003c\/th\u003e\u003c\/tr\u003e\n\u003ctr\u003e\u003ctd class=\"inline-line-number inline-table-dolumn\"\u003e\u003ca href=\"#inline-422\" class=\"num\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-share darkbluetext mmr\" data-meta=\"0_49\" aria-hidden=\"true\"\u003e\u003c\/span\u003e1100\u003c\/a\u003e\u003c\/td\u003e\u003ctd class=\"inline-summary-content inline-table-dolumn\" colspan=\"2\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cspan class=\"transaction-comment\" data-sigil=\"transaction-comment\" data-meta=\"0_8\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cp\u003eThis\u003c\/p\u003e\u003c\/div\u003e\u003c\/span\u003e\u003c\/div\u003e\u003c\/td\u003e\u003c\/tr\u003e\n\u003ctr\u003e\u003ctd class=\"inline-line-number inline-table-dolumn\"\u003e\u003ca href=\"#inline-423\" class=\"num\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-share darkbluetext mmr\" data-meta=\"0_50\" aria-hidden=\"true\"\u003e\u003c\/span\u003e1114\u003c\/a\u003e\u003c\/td\u003e\u003ctd class=\"inline-summary-content inline-table-dolumn\" colspan=\"2\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cspan class=\"transaction-comment\" data-sigil=\"transaction-comment\" data-meta=\"0_9\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cp\u003eand this use different style for pointer parameters.\u003c\/p\u003e\u003c\/div\u003e\u003c\/span\u003e\u003c\/div\u003e\u003c\/td\u003e\u003c\/tr\u003e\n\u003ctr\u003e\u003cth colspan=\"3\" class=\"inline-comment-summary-table-header\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-file-code-o darkbluetext mmr\" data-meta=\"0_51\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\/ps\/trunk\/source\/lobby\/glooxwrapper\/glooxwrapper.cpp\u003c\/th\u003e\u003c\/tr\u003e\n\u003ctr\u003e\u003ctd class=\"inline-line-number inline-table-dolumn\"\u003e\u003ca href=\"#inline-424\" class=\"num\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-share darkbluetext mmr\" data-meta=\"0_52\" aria-hidden=\"true\"\u003e\u003c\/span\u003e847\u003c\/a\u003e\u003c\/td\u003e\u003ctd class=\"inline-summary-content inline-table-dolumn\" colspan=\"2\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cspan class=\"transaction-comment\" data-sigil=\"transaction-comment\" data-meta=\"0_10\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cp\u003eShould this be a ref?\u003c\/p\u003e\u003c\/div\u003e\u003c\/span\u003e\u003c\/div\u003e\u003c\/td\u003e\u003c\/tr\u003e\n\u003ctr\u003e\u003cth colspan=\"3\" class=\"inline-comment-summary-table-header\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-file-code-o darkbluetext mmr\" data-meta=\"0_53\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\/ps\/trunk\/source\/network\/StunClient.cpp\u003c\/th\u003e\u003c\/tr\u003e\n\u003ctr\u003e\u003ctd class=\"inline-line-number inline-table-dolumn\"\u003e\u003ca href=\"#inline-425\" class=\"num\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-share darkbluetext mmr\" data-meta=\"0_54\" aria-hidden=\"true\"\u003e\u003c\/span\u003e109\u003c\/a\u003e\u003c\/td\u003e\u003ctd class=\"inline-summary-content inline-table-dolumn\" colspan=\"2\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cspan class=\"transaction-comment\" data-sigil=\"transaction-comment\" data-meta=\"0_11\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cp\u003econst ref?\u003c\/p\u003e\u003c\/div\u003e\u003c\/span\u003e\u003c\/div\u003e\u003c\/td\u003e\u003c\/tr\u003e\u003c\/table\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-event-view phui-timeline-spacer\"\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-shell\" data-sigil=\"transaction anchor-container\" data-meta=\"0_58\"\u003e\u003cdiv class=\"phui-timeline-event-view phui-timeline-minor-event\"\u003e\u003cdiv class=\"phui-timeline-content\"\u003e\u003ca style=\"background-image: url(https:\/\/code.wildfiregames.com\/file\/data\/dk74raocc3wxwourpuib\/PHID-FILE-j7ay4wouyevydwpkjbz5\/profile)\" class=\"visual-only phui-timeline-image\" href=\"\/p\/elexis\/\" aria-hidden=\"true\"\u003e\u003c\/a\u003e\u003cdiv class=\"phui-timeline-wedge\" style=\"\"\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-group\"\u003e\u003ca name=\"21686\" id=\"21686\" class=\"phabricator-anchor-view\"\u003e\u003c\/a\u003e\u003cdiv class=\"phui-timeline-title phui-timeline-title-with-icon\"\u003e\u003cspan class=\"phui-timeline-icon-fill\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-link phui-timeline-icon\" data-meta=\"0_57\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\u003c\/span\u003e\u003ca href=\"\/p\/elexis\/\" class=\"phui-handle phui-link-person\"\u003eelexis\u003c\/a\u003e mentioned this in \u003ca href=\"\/rP19741\" class=\"phui-handle\"\u003erP19741: Fix whitespace and three refs instead of copies in the glooxwrapper\/StunClient\u2026\u003c\/a\u003e.\u003cspan class=\"phui-timeline-extra\"\u003e\u003ca href=\"#21686\" data-sigil=\"has-tooltip\" data-meta=\"0_56\"\u003eJun 5 2017, 10:44 PM\u003c\/a\u003e\u003c\/span\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-event-view phui-timeline-spacer\"\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-shell\" data-sigil=\"transaction anchor-container\" data-meta=\"0_73\"\u003e\u003cdiv class=\"phui-timeline-event-view phui-timeline-major-event\"\u003e\u003cdiv class=\"phui-timeline-content\"\u003e\u003ca style=\"background-image: url(https:\/\/code.wildfiregames.com\/file\/data\/dk74raocc3wxwourpuib\/PHID-FILE-j7ay4wouyevydwpkjbz5\/profile)\" class=\"visual-only phui-timeline-image\" href=\"\/p\/elexis\/\" aria-hidden=\"true\"\u003e\u003c\/a\u003e\u003cdiv class=\"phui-timeline-wedge\" style=\"\"\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-group\"\u003e\u003cdiv class=\"phui-timeline-inner-content\"\u003e\u003ca name=\"21687\" id=\"21687\" class=\"phabricator-anchor-view\"\u003e\u003c\/a\u003e\u003cdiv class=\"phui-timeline-title phui-timeline-title-with-icon phui-timeline-title-with-menu\"\u003e\u003cspan class=\"phui-timeline-icon-fill\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-pencil phui-timeline-icon\" data-meta=\"0_66\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\u003c\/span\u003e\u003ca href=\"\/p\/elexis\/\" class=\"phui-handle phui-link-person\"\u003eelexis\u003c\/a\u003e marked 3 inline comments as done.\u003cspan class=\"phui-timeline-extra\"\u003e\u003ca href=\"#21687\" data-sigil=\"has-tooltip\" data-meta=\"0_65\"\u003eJun 5 2017, 10:46 PM\u003c\/a\u003e\u003c\/span\u003e\u003c\/div\u003e\u003ca href=\"#\" class=\"phui-timeline-menu\" aria-haspopup=\"true\" aria-expanded=\"false\" data-sigil=\"phui-dropdown-menu\" data-meta=\"0_63\"\u003e\u003cspan class=\"aural-only\"\u003eComment Actions\u003c\/span\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-caret-down\" data-meta=\"0_64\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\u003c\/a\u003e\u003cdiv class=\"phui-timeline-core-content\"\u003e\u003cspan class=\"transaction-comment\" data-sigil=\"transaction-comment\" data-meta=\"0_13\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cp\u003eThanks for the feedback!\u003c\/p\u003e\n\n\u003cblockquote class=\"remarkup-reply-block\"\u003e\n\u003cdiv class=\"remarkup-reply-head\"\u003eIn \u003ca href=\"\/rP19703#21627\" class=\"phui-tag-view phui-tag-type-object \" data-sigil=\"hovercard\" data-meta=\"0_1\"\u003e\u003cspan class=\"phui-tag-core phui-tag-color-object\"\u003erP19703#21627\u003c\/span\u003e\u003c\/a\u003e, \u003ca href=\"\/p\/leper\/\" class=\"phui-tag-view phui-tag-type-person \" data-sigil=\"hovercard\" data-meta=\"0_3\"\u003e\u003cspan class=\"phui-tag-core phui-tag-color-person\"\u003e\u003cspan class=\"phui-tag-dot phui-tag-color-grey\"\u003e\u003c\/span\u003e@leper\u003c\/span\u003e\u003c\/a\u003e wrote:\u003c\/div\u003e\n\u003cdiv class=\"remarkup-reply-body\"\u003e\u003cp\u003eMostly commenting because of that vector copy, also I do truly hope that someone checked that glooxwrapper code in detail\u003c\/p\u003e\u003c\/div\u003e\n\u003c\/blockquote\u003e\n\n\u003cp\u003eNot much to check for the gloox code. The only relevant change there was removing the unused ZeroADGameData gloox Plugin \u003ca href=\"https:\/\/github.com\/elexis1\/0ad\/commit\/6dc2dbb9ffbc90a67cc242b3409c17e186d470c3\" class=\"remarkup-link\" target=\"_blank\" rel=\"noreferrer\"\u003ehttps:\/\/github.com\/elexis1\/0ad\/commit\/6dc2dbb9ffbc90a67cc242b3409c17e186d470c3\u003c\/a\u003e and some early return change.\u003c\/p\u003e\n\n\u003cblockquote\u003e\u003cp\u003eand ran the whole thing through some tools to figure out if we aren't leaking anything.\u003c\/p\u003e\u003c\/blockquote\u003e\n\n\u003cp\u003eNot at the time of committing, but I paid some attention to memory leaks. None in \u003ctt class=\"remarkup-monospaced\"\u003eStunClient.cpp\u003c\/tt\u003e (easy to check), the one in glooxwrapper not as easy, but none in there afaics (as the m_Owned takes care of deleting things)\u003c\/p\u003e\n\n\u003cp\u003eRan \u003ctt class=\"remarkup-monospaced\"\u003evalgrind --tool=memcheck --leak-check=full\u003c\/tt\u003e now (really slow). Almost all leaks found by it occured in \u003ctt class=\"remarkup-monospaced\"\u003esource\/gui\/\u003c\/tt\u003e, besides one that looked like it could be solved easily:\u003c\/p\u003e\n\n\u003cdiv class=\"remarkup-code-block\" data-code-lang=\"text\" data-sigil=\"remarkup-code-block\"\u003e\u003cpre class=\"remarkup-code\"\u003e==30758== 3,696 (2,200 direct, 1,496 indirect) bytes in 11 blocks are definitely lost in loss record 5,044 of 5,159\n==30758==    at 0x4C2DB8F: malloc (in \/usr\/lib\/valgrind\/vgpreload_memcheck-amd64-linux.so)\n==30758==    by 0x679CDF8: icu_55::UMemory::operator new[](unsigned long) (in \/usr\/lib\/x86_64-linux-gnu\/libicuuc.so.55.1)\n==30758==    by 0x6400922: icu_55::OlsonTimeZone::clone() const (in \/usr\/lib\/x86_64-linux-gnu\/libicui18n.so.55.1)\n==30758==    by 0x697774: L10n::FormatMillisecondsIntoDateString(double, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool) const (L10n.cpp:389)\n==30758==    by 0x9ACDC9: JSI_L10n::FormatMillisecondsIntoDateStringLocal(ScriptInterface::CxPrivate*, double, std::__cxx11::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> > const&) (JSInterface_L10n.cpp:74)\n==30758==    by 0x9B1DB0: call<std::__cxx11::basic_string<wchar_t>(ScriptInterface::CxPrivate*, double, const std::__cxx11::basic_string<wchar_t>&), double, std::__cxx11::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> > > (NativeWrapperDefns.h:75)\n==30758==    by 0x9B1DB0: bool ScriptInterface::call<std::__cxx11::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> >, double, std::__cxx11::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> >, &JSI_L10n::FormatMillisecondsIntoDateStringLocal>(JSContext*, unsigned int, JS::Value*) (NativeWrapperDefns.h:125)\n==30758==    by 0x571832F: CallJSNative (jscntxtinlines.h:226)\n==30758==    by 0x571832F: js::Invoke(JSContext*, JS::CallArgs, js::MaybeConstruct) (Interpreter.cpp:498)\n==30758==    by 0x570D01C: Interpret(JSContext*, js::RunState&) (Interpreter.cpp:2602)\n==30758==    by 0x5717FF0: js::RunScript(JSContext*, js::RunState&) (Interpreter.cpp:448)\n==30758==    by 0x571827B: js::Invoke(JSContext*, JS::CallArgs, js::MaybeConstruct) (Interpreter.cpp:517)\n==30758==    by 0x570D01C: Interpret(JSContext*, js::RunState&) (Interpreter.cpp:2602)\n==30758==    by 0x5717FF0: js::RunScript(JSContext*, js::RunState&) (Interpreter.cpp:448)\u003c\/pre\u003e\u003c\/div\u003e\n\n\u003cp\u003eThought it's the \u003ctt class=\"remarkup-monospaced\"\u003ecalendar\u003c\/tt\u003e not being deleted, but that should occur somewhere down the line after pulling the pointer following \u003ctt class=\"remarkup-monospaced\"\u003eadoptCalendar\u003c\/tt\u003e. Adding the \u003ctt class=\"remarkup-monospaced\"\u003edelete\u003c\/tt\u003e explicitly crashes too. So don't have a nice memory leak fix to offer unfortunately.\u003c\/p\u003e\n\n\u003cp\u003eLeft something at \u003ca href=\"\/rP19741\" class=\"phui-tag-view phui-tag-type-object \" data-sigil=\"hovercard\" data-meta=\"0_2\"\u003e\u003cspan class=\"phui-tag-core phui-tag-color-object\"\u003erP19741\u003c\/span\u003e\u003c\/a\u003e for the refs and whitespace.\u003c\/p\u003e\u003c\/div\u003e\u003c\/span\u003e\u003ctable class=\"phabricator-inline-summary-table\"\u003e\u003ctr\u003e\u003cth colspan=\"3\" class=\"inline-comment-summary-table-header\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-file-code-o darkbluetext mmr\" data-meta=\"0_67\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\/ps\/trunk\/source\/lobby\/XmppClient.cpp\u003c\/th\u003e\u003c\/tr\u003e\n\u003ctr\u003e\u003ctd class=\"inline-line-number inline-table-dolumn\"\u003e\u003ca href=\"#inline-434\" class=\"num\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-share darkbluetext mmr\" data-meta=\"0_68\" aria-hidden=\"true\"\u003e\u003c\/span\u003e1114\u003c\/a\u003e\u003c\/td\u003e\u003ctd class=\"inline-summary-content inline-table-dolumn\" colspan=\"2\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cspan class=\"transaction-comment\" data-sigil=\"transaction-comment\" data-meta=\"0_14\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cp\u003eack, few others too\u003c\/p\u003e\u003c\/div\u003e\u003c\/span\u003e\u003c\/div\u003e\u003c\/td\u003e\u003c\/tr\u003e\n\u003ctr\u003e\u003cth colspan=\"3\" class=\"inline-comment-summary-table-header\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-file-code-o darkbluetext mmr\" data-meta=\"0_69\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\/ps\/trunk\/source\/lobby\/glooxwrapper\/glooxwrapper.cpp\u003c\/th\u003e\u003c\/tr\u003e\n\u003ctr\u003e\u003ctd class=\"inline-line-number inline-table-dolumn\"\u003e\u003ca href=\"#inline-432\" class=\"num\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-share darkbluetext mmr\" data-meta=\"0_70\" aria-hidden=\"true\"\u003e\u003c\/span\u003e847\u003c\/a\u003e\u003c\/td\u003e\u003ctd class=\"inline-summary-content inline-table-dolumn\" colspan=\"2\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cspan class=\"transaction-comment\" data-sigil=\"transaction-comment\" data-meta=\"0_15\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cp\u003eShould\u003c\/p\u003e\u003c\/div\u003e\u003c\/span\u003e\u003c\/div\u003e\u003c\/td\u003e\u003c\/tr\u003e\n\u003ctr\u003e\u003cth colspan=\"3\" class=\"inline-comment-summary-table-header\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-file-code-o darkbluetext mmr\" data-meta=\"0_71\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\/ps\/trunk\/source\/network\/StunClient.cpp\u003c\/th\u003e\u003c\/tr\u003e\n\u003ctr\u003e\u003ctd class=\"inline-line-number inline-table-dolumn\"\u003e\u003ca href=\"#inline-433\" class=\"num\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-share darkbluetext mmr\" data-meta=\"0_72\" aria-hidden=\"true\"\u003e\u003c\/span\u003e109\u003c\/a\u003e\u003c\/td\u003e\u003ctd class=\"inline-summary-content inline-table-dolumn\" colspan=\"2\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cspan class=\"transaction-comment\" data-sigil=\"transaction-comment\" data-meta=\"0_16\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cp\u003eOk, that's my doing.\u003c\/p\u003e\u003c\/div\u003e\u003c\/span\u003e\u003c\/div\u003e\u003c\/td\u003e\u003c\/tr\u003e\u003c\/table\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-event-view phui-timeline-spacer\"\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-shell\" data-sigil=\"transaction anchor-container\" data-meta=\"0_82\"\u003e\u003cdiv class=\"phui-timeline-event-view phui-timeline-major-event\"\u003e\u003cdiv class=\"phui-timeline-content\"\u003e\u003ca style=\"background-image: url(https:\/\/code.wildfiregames.com\/file\/data\/3a4gjzuc5lvk7hgxwpra\/PHID-FILE-d4ysam54joovdlhdrdmb\/5a623d-alphanumeric_lato-dark_L.png-255%2C255%2C255%2C0.4.png)\" class=\"visual-only phui-timeline-image\" href=\"\/p\/leper\/\" aria-hidden=\"true\"\u003e\u003c\/a\u003e\u003cdiv class=\"phui-timeline-wedge\" style=\"\"\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-group\"\u003e\u003cdiv class=\"phui-timeline-inner-content\"\u003e\u003ca name=\"21700\" id=\"21700\" class=\"phabricator-anchor-view\"\u003e\u003c\/a\u003e\u003cdiv class=\"phui-timeline-title phui-timeline-title-with-icon phui-timeline-title-with-menu\"\u003e\u003cspan class=\"phui-timeline-icon-fill\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-comment phui-timeline-icon\" data-meta=\"0_81\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\u003c\/span\u003e\u003ca href=\"\/p\/leper\/\" class=\"phui-handle handle-availability-disabled phui-link-person\"\u003e\u003cspan class=\"perfect-circle\"\u003e\u2022\u003c\/span\u003e leper\u003c\/a\u003e added a comment.\u003cspan class=\"phui-timeline-extra\"\u003e\u003ca href=\"#21700\" data-sigil=\"has-tooltip\" data-meta=\"0_80\"\u003eJun 5 2017, 11:37 PM\u003c\/a\u003e\u003c\/span\u003e\u003c\/div\u003e\u003ca href=\"#\" class=\"phui-timeline-menu\" aria-haspopup=\"true\" aria-expanded=\"false\" data-sigil=\"phui-dropdown-menu\" data-meta=\"0_78\"\u003e\u003cspan class=\"aural-only\"\u003eComment Actions\u003c\/span\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-caret-down\" data-meta=\"0_79\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\u003c\/a\u003e\u003cdiv class=\"phui-timeline-core-content\"\u003e\u003cspan class=\"transaction-comment\" data-sigil=\"transaction-comment\" data-meta=\"0_17\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cblockquote\u003e\u003cblockquote\u003e\u003cp\u003eMostly commenting because of that vector copy, also I do truly hope that someone checked that glooxwrapper code in detail\u003c\/p\u003e\u003c\/blockquote\u003e\n\n\u003cp\u003eNot much to check for the gloox code.\u003c\/p\u003e\u003c\/blockquote\u003e\n\n\u003cp\u003eglooxwrapper, and there is quite some new code (doing quite a few \u003ctt class=\"remarkup-monospaced\"\u003enew\u003c\/tt\u003e and passing them around) in there. I'll just assume that it's working correctly.\u003c\/p\u003e\u003c\/div\u003e\u003c\/span\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-event-view phui-timeline-spacer\"\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-shell\" data-sigil=\"transaction anchor-container\" data-meta=\"0_93\"\u003e\u003cdiv class=\"phui-timeline-event-view phui-timeline-major-event\"\u003e\u003cdiv class=\"phui-timeline-content\"\u003e\u003ca style=\"background-image: url(https:\/\/code.wildfiregames.com\/file\/data\/dk74raocc3wxwourpuib\/PHID-FILE-j7ay4wouyevydwpkjbz5\/profile)\" class=\"visual-only phui-timeline-image\" href=\"\/p\/elexis\/\" aria-hidden=\"true\"\u003e\u003c\/a\u003e\u003cdiv class=\"phui-timeline-wedge\" style=\"\"\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-group\"\u003e\u003cdiv class=\"phui-timeline-inner-content\"\u003e\u003ca name=\"22654\" id=\"22654\" class=\"phabricator-anchor-view\"\u003e\u003c\/a\u003e\u003cdiv class=\"phui-timeline-title phui-timeline-title-with-icon phui-timeline-title-with-menu\"\u003e\u003cspan class=\"phui-timeline-icon-fill\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-pencil phui-timeline-icon\" data-meta=\"0_90\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\u003c\/span\u003e\u003ca href=\"\/p\/elexis\/\" class=\"phui-handle phui-link-person\"\u003eelexis\u003c\/a\u003e added an auditor: \u003cspan class=\"\"\u003e\u003ca href=\"\/p\/echotangoecho\/\" class=\"phui-handle phui-link-person\" data-sigil=\"hovercard\" data-meta=\"0_18\"\u003eechotangoecho\u003c\/a\u003e\u003c\/span\u003e.\u003cspan class=\"phui-timeline-extra\"\u003e\u003ca href=\"#22654\" data-sigil=\"has-tooltip\" data-meta=\"0_89\"\u003eAug 18 2017, 4:03 PM\u003c\/a\u003e\u003c\/span\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-title phui-timeline-title-with-icon phui-timeline-title-with-menu\"\u003e\u003cspan class=\"phui-timeline-icon-fill\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-pencil phui-timeline-icon\" data-meta=\"0_91\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\u003c\/span\u003e\u003ca href=\"\/p\/elexis\/\" class=\"phui-handle phui-link-person\"\u003eelexis\u003c\/a\u003e marked 3 inline comments as done.\u003c\/div\u003e\u003cdiv class=\"phui-timeline-title phui-timeline-title-with-icon phui-timeline-title-with-menu\"\u003e\u003cspan class=\"phui-timeline-icon-fill\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-user-plus phui-timeline-icon\" data-meta=\"0_92\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\u003c\/span\u003e\u003ca href=\"\/p\/elexis\/\" class=\"phui-handle phui-link-person\"\u003eelexis\u003c\/a\u003e added a subscriber: \u003ca href=\"\/p\/echotangoecho\/\" class=\"phui-handle phui-link-person\" data-sigil=\"hovercard\" data-meta=\"0_19\"\u003eechotangoecho\u003c\/a\u003e.\u003c\/div\u003e\u003ca href=\"#\" class=\"phui-timeline-menu\" aria-haspopup=\"true\" aria-expanded=\"false\" data-sigil=\"phui-dropdown-menu\" data-meta=\"0_87\"\u003e\u003cspan class=\"aural-only\"\u003eComment Actions\u003c\/span\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-caret-down\" data-meta=\"0_88\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\u003c\/a\u003e\u003cdiv class=\"phui-timeline-core-content\"\u003e\u003cspan class=\"transaction-comment\" data-sigil=\"transaction-comment\" data-meta=\"0_20\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cp\u003e\u003ca href=\"\/p\/echotangoecho\/\" class=\"phui-tag-view phui-tag-type-person \" data-sigil=\"hovercard\" data-meta=\"0_4\"\u003e\u003cspan class=\"phui-tag-core phui-tag-color-person\"\u003e@echotangoecho\u003c\/span\u003e\u003c\/a\u003e said there are 'definitely' leaks here, so I'm using his name to put this commit in the list of open audits, so that I remember to check for this memory leak without writing a trac ticket, if that makes sense.\u003c\/p\u003e\u003c\/div\u003e\u003c\/span\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-event-view phui-timeline-spacer\"\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-shell phui-timeline-orange\" data-sigil=\"transaction anchor-container\" data-meta=\"0_96\"\u003e\u003cdiv class=\"phui-timeline-event-view phui-timeline-minor-event\"\u003e\u003cdiv class=\"phui-timeline-content\"\u003e\u003ca style=\"background-image: url(https:\/\/code.wildfiregames.com\/file\/data\/dk74raocc3wxwourpuib\/PHID-FILE-j7ay4wouyevydwpkjbz5\/profile)\" class=\"visual-only phui-timeline-image\" href=\"\/p\/elexis\/\" aria-hidden=\"true\"\u003e\u003c\/a\u003e\u003cdiv class=\"phui-timeline-wedge\" style=\"\"\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-group\"\u003e\u003ca name=\"22658\" id=\"22658\" class=\"phabricator-anchor-view\"\u003e\u003c\/a\u003e\u003cdiv class=\"phui-timeline-title phui-timeline-title-with-icon\"\u003e\u003cspan class=\"phui-timeline-icon-fill fill-has-color phui-timeline-icon-fill-orange\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-exclamation-circle phui-timeline-icon\" data-meta=\"0_95\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\u003c\/span\u003eThis commit now requires audit.\u003cspan class=\"phui-timeline-extra\"\u003e\u003ca href=\"#22658\" data-sigil=\"has-tooltip\" data-meta=\"0_94\"\u003eAug 18 2017, 4:03 PM\u003c\/a\u003e\u003c\/span\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-event-view phui-timeline-spacer\"\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-shell\" data-sigil=\"transaction anchor-container\" data-meta=\"0_111\"\u003e\u003cdiv class=\"phui-timeline-event-view phui-timeline-major-event\"\u003e\u003cdiv class=\"phui-timeline-content\"\u003e\u003ca style=\"background-image: url(https:\/\/code.wildfiregames.com\/file\/data\/37t5qllxfanrohnr35kf\/PHID-FILE-m5e4y3jot2qx6ir7veo6\/profile)\" class=\"visual-only phui-timeline-image\" href=\"\/p\/echotangoecho\/\" aria-hidden=\"true\"\u003e\u003c\/a\u003e\u003cdiv class=\"phui-timeline-wedge\" style=\"\"\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-group\"\u003e\u003cdiv class=\"phui-timeline-inner-content\"\u003e\u003ca name=\"22660\" id=\"22660\" class=\"phabricator-anchor-view\"\u003e\u003c\/a\u003e\u003cdiv class=\"phui-timeline-title phui-timeline-title-with-icon phui-timeline-title-with-menu\"\u003e\u003cspan class=\"phui-timeline-icon-fill\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-comment phui-timeline-icon\" data-meta=\"0_104\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\u003c\/span\u003e\u003ca href=\"\/p\/echotangoecho\/\" class=\"phui-handle phui-link-person\"\u003eechotangoecho\u003c\/a\u003e added a comment.\u003cspan class=\"phui-timeline-extra\"\u003e\u003ca href=\"#22660\" data-sigil=\"has-tooltip\" data-meta=\"0_103\"\u003eAug 18 2017, 4:49 PM\u003c\/a\u003e\u003c\/span\u003e\u003c\/div\u003e\u003ca href=\"#\" class=\"phui-timeline-menu\" aria-haspopup=\"true\" aria-expanded=\"false\" data-sigil=\"phui-dropdown-menu\" data-meta=\"0_101\"\u003e\u003cspan class=\"aural-only\"\u003eComment Actions\u003c\/span\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-caret-down\" data-meta=\"0_102\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\u003c\/a\u003e\u003cdiv class=\"phui-timeline-core-content\"\u003e\u003cspan class=\"transaction-comment\" data-sigil=\"transaction-comment\" data-meta=\"0_21\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cp\u003eSome things I found (maybe not exhaustive) -- Some of these might easily be converted to use smart pointers and ideally most of this code should be rewritten to use smart pointers, but that might cost too much time.\u003c\/p\u003e\u003c\/div\u003e\u003c\/span\u003e\u003ctable class=\"phabricator-inline-summary-table\"\u003e\u003ctr\u003e\u003cth colspan=\"3\" class=\"inline-comment-summary-table-header\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-file-code-o darkbluetext mmr\" data-meta=\"0_105\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\/ps\/trunk\/source\/lobby\/XmppClient.cpp\u003c\/th\u003e\u003c\/tr\u003e\n\u003ctr\u003e\u003ctd class=\"inline-line-number inline-table-dolumn\"\u003e\u003ca href=\"#inline-535\" class=\"num\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-share darkbluetext mmr\" data-meta=\"0_106\" aria-hidden=\"true\"\u003e\u003c\/span\u003e140\u003c\/a\u003e\u003c\/td\u003e\u003ctd class=\"inline-summary-content inline-table-dolumn\" colspan=\"2\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cspan class=\"transaction-comment\" data-sigil=\"transaction-comment\" data-meta=\"0_22\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cp\u003eLeaked? (no matching delete in destructor)\u003c\/p\u003e\u003c\/div\u003e\u003c\/span\u003e\u003c\/div\u003e\u003c\/td\u003e\u003c\/tr\u003e\n\u003ctr\u003e\u003cth colspan=\"3\" class=\"inline-comment-summary-table-header\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-file-code-o darkbluetext mmr\" data-meta=\"0_107\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\/ps\/trunk\/source\/lobby\/glooxwrapper\/glooxwrapper.cpp\u003c\/th\u003e\u003c\/tr\u003e\n\u003ctr\u003e\u003ctd class=\"inline-line-number inline-table-dolumn\"\u003e\u003ca href=\"#inline-534\" class=\"num\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-share darkbluetext mmr\" data-meta=\"0_108\" aria-hidden=\"true\"\u003e\u003c\/span\u003e291\u003c\/a\u003e\u003c\/td\u003e\u003ctd class=\"inline-summary-content inline-table-dolumn\" colspan=\"2\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cspan class=\"transaction-comment\" data-sigil=\"transaction-comment\" data-meta=\"0_23\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cp\u003eI think the things that are allocated here may be leaked.\u003c\/p\u003e\u003c\/div\u003e\u003c\/span\u003e\u003c\/div\u003e\u003c\/td\u003e\u003c\/tr\u003e\n\u003ctr\u003e\u003ctd class=\"inline-line-number inline-table-dolumn\"\u003e\u003ca href=\"#inline-536\" class=\"num\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-share darkbluetext mmr\" data-meta=\"0_109\" aria-hidden=\"true\"\u003e\u003c\/span\u003e800\u003c\/a\u003e\u003c\/td\u003e\u003ctd class=\"inline-summary-content inline-table-dolumn\" colspan=\"2\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cspan class=\"transaction-comment\" data-sigil=\"transaction-comment\" data-meta=\"0_24\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cp\u003eIt does not seem like this is deleted anywhere.\u003c\/p\u003e\u003c\/div\u003e\u003c\/span\u003e\u003c\/div\u003e\u003c\/td\u003e\u003c\/tr\u003e\n\u003ctr\u003e\u003ctd class=\"inline-line-number inline-table-dolumn\"\u003e\u003ca href=\"#inline-537\" class=\"num\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-share darkbluetext mmr\" data-meta=\"0_110\" aria-hidden=\"true\"\u003e\u003c\/span\u003e820\u003c\/a\u003e\u003c\/td\u003e\u003ctd class=\"inline-summary-content inline-table-dolumn\" colspan=\"2\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cspan class=\"transaction-comment\" data-sigil=\"transaction-comment\" data-meta=\"0_25\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cp\u003eLeaked?\u003c\/p\u003e\u003c\/div\u003e\u003c\/span\u003e\u003c\/div\u003e\u003c\/td\u003e\u003c\/tr\u003e\u003c\/table\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-event-view phui-timeline-spacer\"\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-shell phui-timeline-red\" data-sigil=\"transaction anchor-container\" data-meta=\"0_114\"\u003e\u003cdiv class=\"phui-timeline-event-view phui-timeline-minor-event\"\u003e\u003cdiv class=\"phui-timeline-content\"\u003e\u003ca style=\"background-image: url(https:\/\/code.wildfiregames.com\/file\/data\/37t5qllxfanrohnr35kf\/PHID-FILE-m5e4y3jot2qx6ir7veo6\/profile)\" class=\"visual-only phui-timeline-image\" href=\"\/p\/echotangoecho\/\" aria-hidden=\"true\"\u003e\u003c\/a\u003e\u003cdiv class=\"phui-timeline-wedge\" style=\"\"\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-group\"\u003e\u003ca name=\"22665\" id=\"22665\" class=\"phabricator-anchor-view\"\u003e\u003c\/a\u003e\u003cdiv class=\"phui-timeline-title phui-timeline-title-with-icon\"\u003e\u003cspan class=\"phui-timeline-icon-fill fill-has-color phui-timeline-icon-fill-red\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-times-circle-o phui-timeline-icon\" data-meta=\"0_113\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\u003c\/span\u003e\u003ca href=\"\/p\/echotangoecho\/\" class=\"phui-handle phui-link-person\"\u003eechotangoecho\u003c\/a\u003e raised a concern with this commit.\u003cspan class=\"phui-timeline-extra\"\u003e\u003ca href=\"#22665\" data-sigil=\"has-tooltip\" data-meta=\"0_112\"\u003eAug 18 2017, 4:50 PM\u003c\/a\u003e\u003c\/span\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-event-view phui-timeline-spacer\"\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-shell phui-timeline-red\" data-sigil=\"transaction anchor-container\" data-meta=\"0_117\"\u003e\u003cdiv class=\"phui-timeline-event-view phui-timeline-minor-event\"\u003e\u003cdiv class=\"phui-timeline-content\"\u003e\u003ca style=\"background-image: url(https:\/\/code.wildfiregames.com\/file\/data\/37t5qllxfanrohnr35kf\/PHID-FILE-m5e4y3jot2qx6ir7veo6\/profile)\" class=\"visual-only phui-timeline-image\" href=\"\/p\/echotangoecho\/\" aria-hidden=\"true\"\u003e\u003c\/a\u003e\u003cdiv class=\"phui-timeline-wedge\" style=\"\"\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-group\"\u003e\u003ca name=\"22666\" id=\"22666\" class=\"phabricator-anchor-view\"\u003e\u003c\/a\u003e\u003cdiv class=\"phui-timeline-title phui-timeline-title-with-icon\"\u003e\u003cspan class=\"phui-timeline-icon-fill fill-has-color phui-timeline-icon-fill-red\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-times-circle phui-timeline-icon\" data-meta=\"0_116\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\u003c\/span\u003eThis commit now has outstanding concerns.\u003cspan class=\"phui-timeline-extra\"\u003e\u003ca href=\"#22666\" data-sigil=\"has-tooltip\" data-meta=\"0_115\"\u003eAug 18 2017, 4:50 PM\u003c\/a\u003e\u003c\/span\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-event-view phui-timeline-spacer\"\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-shell phui-timeline-red\" data-sigil=\"transaction anchor-container\" data-meta=\"0_129\"\u003e\u003cdiv class=\"phui-timeline-event-view phui-timeline-major-event\"\u003e\u003cdiv class=\"phui-timeline-content\"\u003e\u003ca style=\"background-image: url(https:\/\/code.wildfiregames.com\/file\/data\/3a4gjzuc5lvk7hgxwpra\/PHID-FILE-d4ysam54joovdlhdrdmb\/5a623d-alphanumeric_lato-dark_L.png-255%2C255%2C255%2C0.4.png)\" class=\"visual-only phui-timeline-image\" href=\"\/p\/leper\/\" aria-hidden=\"true\"\u003e\u003c\/a\u003e\u003cdiv class=\"phui-timeline-wedge\" style=\"\"\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-group\"\u003e\u003cdiv class=\"phui-timeline-inner-content\"\u003e\u003ca name=\"24554\" id=\"24554\" class=\"phabricator-anchor-view\"\u003e\u003c\/a\u003e\u003cdiv class=\"phui-timeline-title phui-timeline-title-with-icon phui-timeline-title-with-menu\"\u003e\u003cspan class=\"phui-timeline-icon-fill fill-has-color phui-timeline-icon-fill-red\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-times-circle-o phui-timeline-icon\" data-meta=\"0_125\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\u003c\/span\u003e\u003ca href=\"\/p\/leper\/\" class=\"phui-handle handle-availability-disabled phui-link-person\"\u003e\u003cspan class=\"perfect-circle\"\u003e\u2022\u003c\/span\u003e leper\u003c\/a\u003e raised a concern with this commit.\u003cspan class=\"phui-timeline-extra\"\u003e\u003ca href=\"#24554\" data-sigil=\"has-tooltip\" data-meta=\"0_124\"\u003eNov 10 2017, 8:53 AM\u003c\/a\u003e\u003c\/span\u003e\u003c\/div\u003e\u003cdiv class=\"phui-timeline-title phui-timeline-title-with-icon phui-timeline-title-with-menu\"\u003e\u003cspan class=\"phui-timeline-icon-fill\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-user-plus phui-timeline-icon\" data-meta=\"0_126\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\u003c\/span\u003e\u003ca href=\"\/p\/leper\/\" class=\"phui-handle handle-availability-disabled phui-link-person\"\u003e\u003cspan class=\"perfect-circle\"\u003e\u2022\u003c\/span\u003e leper\u003c\/a\u003e added a subscriber: \u003ca href=\"\/p\/Itms\/\" class=\"phui-handle phui-link-person\" data-sigil=\"hovercard\" data-meta=\"0_26\"\u003eItms\u003c\/a\u003e.\u003c\/div\u003e\u003ca href=\"#\" class=\"phui-timeline-menu\" aria-haspopup=\"true\" aria-expanded=\"false\" data-sigil=\"phui-dropdown-menu\" data-meta=\"0_122\"\u003e\u003cspan class=\"aural-only\"\u003eComment Actions\u003c\/span\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-caret-down\" data-meta=\"0_123\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\u003c\/a\u003e\u003cdiv class=\"phui-timeline-core-content\"\u003e\u003cspan class=\"transaction-comment\" data-sigil=\"transaction-comment\" data-meta=\"0_27\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cp\u003eClang has warnings, warnings are nice. \u003ca href=\"\/p\/Itms\/\" class=\"phui-tag-view phui-tag-type-person \" data-sigil=\"hovercard\" data-meta=\"0_5\"\u003e\u003cspan class=\"phui-tag-core phui-tag-color-person\"\u003e@Itms\u003c\/span\u003e\u003c\/a\u003e clang builds for things would be nice.\u003c\/p\u003e\n\n\u003cp\u003eAlso the glooxwrapper code still seems fishy.\u003c\/p\u003e\u003c\/div\u003e\u003c\/span\u003e\u003ctable class=\"phabricator-inline-summary-table\"\u003e\u003ctr\u003e\u003cth colspan=\"3\" class=\"inline-comment-summary-table-header\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-file-code-o darkbluetext mmr\" data-meta=\"0_127\" aria-hidden=\"true\"\u003e\u003c\/span\u003e\/ps\/trunk\/source\/lobby\/glooxwrapper\/glooxwrapper.h\u003c\/th\u003e\u003c\/tr\u003e\n\u003ctr\u003e\u003ctd class=\"inline-line-number inline-table-dolumn\"\u003e\u003ca href=\"#inline-900\" class=\"num\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-share darkbluetext mmr\" data-meta=\"0_128\" aria-hidden=\"true\"\u003e\u003c\/span\u003e639\u003c\/a\u003e\u003c\/td\u003e\u003ctd class=\"inline-summary-content inline-table-dolumn\" colspan=\"2\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cspan class=\"transaction-comment\" data-sigil=\"transaction-comment\" data-meta=\"0_28\"\u003e\u003cdiv class=\"phabricator-remarkup\"\u003e\u003cp\u003eThis is unused.\u003c\/p\u003e\n\n\u003cp\u003eReported by clang \u003ctt class=\"remarkup-monospaced\"\u003ewarning: private field 'm_Owned' is not used [-Wunused-private-field]\u003c\/tt\u003e.\u003c\/p\u003e\u003c\/div\u003e\u003c\/span\u003e\u003c\/div\u003e\u003c\/td\u003e\u003c\/tr\u003e\u003c\/table\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e\u003c\/div\u003e"},"javelin_metadata":[{"hoverPHID":"PHID-DREV-5pnubyvi4x4b5k7c7hqh"},{"hoverPHID":"PHID-CMIT-2qqtipm4tkmwqqs4qmlo"},{"hoverPHID":"PHID-CMIT-6rv6fqzt5wq5t4trabvm"},{"hoverPHID":"PHID-USER-cyefun3pek5wwfhwullr"},{"hoverPHID":"PHID-USER-v7nwllj3xghsaaqkuc2o"},{"hoverPHID":"PHID-USER-xsfq6qxdhu2ax334sym5"},{"phid":"PHID-XACT-CMIT-v6tznkpr4izcn2u"},{"phid":"PHID-XACT-CMIT-szqymkdj5dsevvw"},{"phid":"PHID-XACT-CMIT-kjzsi37unuvfuxc"},{"phid":"PHID-XACT-CMIT-h4ib6bpunv3fu4r"},{"phid":"PHID-XACT-CMIT-bl2mc2oectnqku7"},{"phid":"PHID-XACT-CMIT-2456oftvn7oafpm"},{"hoverPHID":"PHID-USER-cyefun3pek5wwfhwullr"},{"phid":"PHID-XACT-CMIT-6wfudefbu7o6qej"},{"phid":"PHID-XACT-CMIT-bfu5s74mloduhnd"},{"phid":"PHID-XACT-CMIT-pjhjmee6blr623u"},{"phid":"PHID-XACT-CMIT-txgulnapds2ll55"},{"phid":"PHID-XACT-CMIT-xflnerb3k4llco5"},{"hoverPHID":"PHID-USER-v7nwllj3xghsaaqkuc2o"},{"hoverPHID":"PHID-USER-v7nwllj3xghsaaqkuc2o"},{"phid":"PHID-XACT-CMIT-v4jarvvruw5zpi4"},{"phid":"PHID-XACT-CMIT-7bvbwbo5fw7watp"},{"phid":"PHID-XACT-CMIT-ycvj5iiahi55jnn"},{"phid":"PHID-XACT-CMIT-izuzrov4c4td5bm"},{"phid":"PHID-XACT-CMIT-mwmcbbcby5oulyu"},{"phid":"PHID-XACT-CMIT-ebzpxh3orjo4lhk"},{"hoverPHID":"PHID-USER-xsfq6qxdhu2ax334sym5"},{"phid":"PHID-XACT-CMIT-r4h65adnh6uuc6j"},{"phid":"PHID-XACT-CMIT-cismuqdhnssvdin"},{"tip":"Via Daemon"},[],{"phid":"PHID-XACT-CMIT-yeaa22sjphjbzyj","anchor":"21542"},{"tip":"Via Daemon"},[],{"phid":"PHID-XACT-CMIT-uq6rak4c3nrrabt","anchor":"21543"},{"tip":"Via Web"},[],[],[],{"phid":"PHID-XACT-CMIT-v6tznkpr4izcn2u","anchor":"21585"},{"targetID":"UQ0_1","uri":"\/transactions\/quote\/PHID-XACT-CMIT-szqymkdj5dsevvw\/","ref":"rP19703#21628"},[],{"anchor":"21628"},[],{"items":"\u003cul class=\"phabricator-action-list-view \"\u003e\u003cli id=\"UQ0_1\" class=\"phabricator-action-view phabricator-action-view-href action-has-icon\" style=\"\"\u003e\u003ca href=\"#\" class=\"phabricator-action-view-item\" data-sigil=\"transaction-quote\" data-meta=\"0_40\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-quote-left phabricator-action-view-icon\" data-meta=\"0_41\" aria-hidden=\"true\"\u003e\u003c\/span\u003eQuote Comment\u003c\/a\u003e\u003c\/li\u003e\u003cli id=\"UQ0_3\" class=\"phabricator-action-view phabricator-action-view-href action-has-icon\" style=\"\"\u003e\u003ca href=\"\/transactions\/raw\/PHID-XACT-CMIT-szqymkdj5dsevvw\/\" class=\"phabricator-action-view-item\" data-sigil=\"transaction-raw\" data-meta=\"0_42\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-code phabricator-action-view-icon\" data-meta=\"0_43\" aria-hidden=\"true\"\u003e\u003c\/span\u003eView Raw Remarkup\u003c\/a\u003e\u003c\/li\u003e\u003c\/ul\u003e"},[],{"tip":"Via Web"},[],[],[],[],[],[],[],[],{"phid":"PHID-XACT-CMIT-szqymkdj5dsevvw","anchor":"21628"},{"tip":"Via Daemon"},[],{"phid":"PHID-XACT-CMIT-dospslyctl6p6m3","anchor":"21686"},{"targetID":"UQ0_1","uri":"\/transactions\/quote\/PHID-XACT-CMIT-6wfudefbu7o6qej\/","ref":"rP19703#21687"},[],{"anchor":"21687"},[],{"items":"\u003cul class=\"phabricator-action-list-view \"\u003e\u003cli id=\"UQ0_5\" class=\"phabricator-action-view phabricator-action-view-href action-has-icon\" style=\"\"\u003e\u003ca href=\"#\" class=\"phabricator-action-view-item\" data-sigil=\"transaction-quote\" data-meta=\"0_59\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-quote-left phabricator-action-view-icon\" data-meta=\"0_60\" aria-hidden=\"true\"\u003e\u003c\/span\u003eQuote Comment\u003c\/a\u003e\u003c\/li\u003e\u003cli id=\"UQ0_7\" class=\"phabricator-action-view phabricator-action-view-href action-has-icon\" style=\"\"\u003e\u003ca href=\"\/transactions\/raw\/PHID-XACT-CMIT-6wfudefbu7o6qej\/\" class=\"phabricator-action-view-item\" data-sigil=\"transaction-raw\" data-meta=\"0_61\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-code phabricator-action-view-icon\" data-meta=\"0_62\" aria-hidden=\"true\"\u003e\u003c\/span\u003eView Raw Remarkup\u003c\/a\u003e\u003c\/li\u003e\u003c\/ul\u003e"},[],{"tip":"Via Web"},[],[],[],[],[],[],[],{"phid":"PHID-XACT-CMIT-ns2y6ggh6g7z5if","anchor":"21687"},{"targetID":"UQ0_1","uri":"\/transactions\/quote\/PHID-XACT-CMIT-xflnerb3k4llco5\/","ref":"rP19703#21700"},[],{"anchor":"21700"},[],{"items":"\u003cul class=\"phabricator-action-list-view \"\u003e\u003cli id=\"UQ0_9\" class=\"phabricator-action-view phabricator-action-view-href action-has-icon\" style=\"\"\u003e\u003ca href=\"#\" class=\"phabricator-action-view-item\" data-sigil=\"transaction-quote\" data-meta=\"0_74\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-quote-left phabricator-action-view-icon\" data-meta=\"0_75\" aria-hidden=\"true\"\u003e\u003c\/span\u003eQuote Comment\u003c\/a\u003e\u003c\/li\u003e\u003cli id=\"UQ0_11\" class=\"phabricator-action-view phabricator-action-view-href action-has-icon\" style=\"\"\u003e\u003ca href=\"\/transactions\/raw\/PHID-XACT-CMIT-xflnerb3k4llco5\/\" class=\"phabricator-action-view-item\" data-sigil=\"transaction-raw\" data-meta=\"0_76\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-code phabricator-action-view-icon\" data-meta=\"0_77\" aria-hidden=\"true\"\u003e\u003c\/span\u003eView Raw Remarkup\u003c\/a\u003e\u003c\/li\u003e\u003c\/ul\u003e"},[],{"tip":"Via Web"},[],{"phid":"PHID-XACT-CMIT-xflnerb3k4llco5","anchor":"21700"},{"targetID":"UQ0_1","uri":"\/transactions\/quote\/PHID-XACT-CMIT-v4jarvvruw5zpi4\/","ref":"rP19703#22654"},[],{"anchor":"22654"},[],{"items":"\u003cul class=\"phabricator-action-list-view \"\u003e\u003cli id=\"UQ0_13\" class=\"phabricator-action-view phabricator-action-view-href action-has-icon\" style=\"\"\u003e\u003ca href=\"#\" class=\"phabricator-action-view-item\" data-sigil=\"transaction-quote\" data-meta=\"0_83\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-quote-left phabricator-action-view-icon\" data-meta=\"0_84\" aria-hidden=\"true\"\u003e\u003c\/span\u003eQuote Comment\u003c\/a\u003e\u003c\/li\u003e\u003cli id=\"UQ0_15\" class=\"phabricator-action-view phabricator-action-view-href action-has-icon\" style=\"\"\u003e\u003ca href=\"\/transactions\/raw\/PHID-XACT-CMIT-v4jarvvruw5zpi4\/\" class=\"phabricator-action-view-item\" data-sigil=\"transaction-raw\" data-meta=\"0_85\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-code phabricator-action-view-icon\" data-meta=\"0_86\" aria-hidden=\"true\"\u003e\u003c\/span\u003eView Raw Remarkup\u003c\/a\u003e\u003c\/li\u003e\u003c\/ul\u003e"},[],{"tip":"Via Web"},[],[],[],{"phid":"PHID-XACT-CMIT-rk3xxzivmalaf5a","anchor":"22654"},{"tip":"Via Web"},[],{"phid":"PHID-XACT-CMIT-zutzdvonyib5h2q","anchor":"22658"},{"targetID":"UQ0_1","uri":"\/transactions\/quote\/PHID-XACT-CMIT-7bvbwbo5fw7watp\/","ref":"rP19703#22660"},[],{"anchor":"22660"},[],{"items":"\u003cul class=\"phabricator-action-list-view \"\u003e\u003cli id=\"UQ0_17\" class=\"phabricator-action-view phabricator-action-view-href action-has-icon\" style=\"\"\u003e\u003ca href=\"#\" class=\"phabricator-action-view-item\" data-sigil=\"transaction-quote\" data-meta=\"0_97\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-quote-left phabricator-action-view-icon\" data-meta=\"0_98\" aria-hidden=\"true\"\u003e\u003c\/span\u003eQuote Comment\u003c\/a\u003e\u003c\/li\u003e\u003cli id=\"UQ0_19\" class=\"phabricator-action-view phabricator-action-view-href action-has-icon\" style=\"\"\u003e\u003ca href=\"\/transactions\/raw\/PHID-XACT-CMIT-7bvbwbo5fw7watp\/\" class=\"phabricator-action-view-item\" data-sigil=\"transaction-raw\" data-meta=\"0_99\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-code phabricator-action-view-icon\" data-meta=\"0_100\" aria-hidden=\"true\"\u003e\u003c\/span\u003eView Raw Remarkup\u003c\/a\u003e\u003c\/li\u003e\u003c\/ul\u003e"},[],{"tip":"Via Web"},[],[],[],[],[],[],[],{"phid":"PHID-XACT-CMIT-7bvbwbo5fw7watp","anchor":"22660"},{"tip":"Via Web"},[],{"phid":"PHID-XACT-CMIT-h5x3acueehfmza2","anchor":"22665"},{"tip":"Via Web"},[],{"phid":"PHID-XACT-CMIT-o6tzzrj7moy5miw","anchor":"22666"},{"targetID":"UQ0_1","uri":"\/transactions\/quote\/PHID-XACT-CMIT-r4h65adnh6uuc6j\/","ref":"rP19703#24554"},[],{"anchor":"24554"},[],{"items":"\u003cul class=\"phabricator-action-list-view \"\u003e\u003cli id=\"UQ0_21\" class=\"phabricator-action-view phabricator-action-view-href action-has-icon\" style=\"\"\u003e\u003ca href=\"#\" class=\"phabricator-action-view-item\" data-sigil=\"transaction-quote\" data-meta=\"0_118\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-quote-left phabricator-action-view-icon\" data-meta=\"0_119\" aria-hidden=\"true\"\u003e\u003c\/span\u003eQuote Comment\u003c\/a\u003e\u003c\/li\u003e\u003cli id=\"UQ0_23\" class=\"phabricator-action-view phabricator-action-view-href action-has-icon\" style=\"\"\u003e\u003ca href=\"\/transactions\/raw\/PHID-XACT-CMIT-r4h65adnh6uuc6j\/\" class=\"phabricator-action-view-item\" data-sigil=\"transaction-raw\" data-meta=\"0_120\"\u003e\u003cspan class=\"visual-only phui-icon-view phui-font-fa fa-code phabricator-action-view-icon\" data-meta=\"0_121\" aria-hidden=\"true\"\u003e\u003c\/span\u003eView Raw Remarkup\u003c\/a\u003e\u003c\/li\u003e\u003c\/ul\u003e"},[],{"tip":"Via Web"},[],[],[],[],{"phid":"PHID-XACT-CMIT-zv6wuipdds4gn33","anchor":"24554"}],"javelin_behaviors":{"phui-hovercards":[],"phabricator-watch-anchor":[],"phabricator-tooltips":[],"phui-dropdown-menu":[]},"javelin_resources":["https:\/\/code.wildfiregames.com\/res\/defaultX\/phabricator\/da792a0f\/core.pkg.css","https:\/\/code.wildfiregames.com\/res\/defaultX\/phabricator\/845355f4\/core.pkg.js","https:\/\/code.wildfiregames.com\/res\/defaultX\/phabricator\/98e6504a\/rsrc\/externals\/javelin\/core\/init.js","https:\/\/code.wildfiregames.com\/res\/defaultX\/phabricator\/5c459f92\/differential.pkg.css"]}