Page MenuHomeWildfire Games
Differential D1194

Shrinking things in Match Creator to provide more room for other stuff.
AbandonedPublic
Actions

Authored by gentz on Jan 4 2018, 6:38 AM.

Details

Reviewers
None
Summary

If we wanted to add a second chat panel or player list or anything really to the match creator we'd run into space issues at the default resolution (1024x768). We would either need to increase the minimum resolution or shrink the amount of space the existing things require. This does the latter.

This patch does the following:

  1. Shortens the headers for the player selector thingy at the top to allow it to shrink more.

I'd need this patch implemented if I wanted to do something like this: https://wildfiregames.com/forum/index.php?/topic/23633-fancy-lobby-chat-in-match-setup/&tab=comments#comment-345539

Outdated Screenshot: 1 window at 1080p, 2 windows at default resolution, 1 window at some random size.

To my understanding I only need a trac ticket if it's a complicated change, which I don't think this is.

Test Plan

Might need to check that it doesn't break with any locales (probably does tbh).

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4314
Build 7571: Vulcan BuildJenkins
Build 7570: arc lint + arc unit

Event Timeline

gentz created this revision.Jan 4 2018, 6:38 AM
Owners added subscribers: Restricted Owners Package, Restricted Owners Package, Restricted Owners Package.Jan 4 2018, 6:38 AM
gentz edited the summary of this revision. (Show Details)Jan 4 2018, 6:46 AM
Vulcan added a subscriber: Vulcan.Jan 4 2018, 7:37 AM

Successful build - Chance fights ever on the side of the prudent.

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...
Harbormaster completed remote builds in B4311: Diff 5080.Jan 4 2018, 7:37 AM
bb added a subscriber: bb.Jan 4 2018, 1:27 PM

Do not change .po files (those are translation files)
move files instead of adding+removing
Further we have D1027 for partially the same purpose
Add yourself in the programming.json

gentz updated this revision to Diff 5082.Jan 4 2018, 2:39 PM
Vulcan added a comment.Jan 4 2018, 2:41 PM

Build failure - The Moirai have given mortals hearts that can endure.

 Exception 
The program is attempting to read user input, but stdin is being piped from some other source (not a TTY).
(Run with `--trace` for a full exception trace.)
Harbormaster failed remote builds in B4313: Diff 5082!Jan 4 2018, 2:41 PM
gentz updated this revision to Diff 5083.Jan 4 2018, 3:04 PM
gentz edited the summary of this revision. (Show Details)

IMHO I think D1027 is a better solution for cramming more things in the bottom. I've removed things related to the map options. (A.k.a 90% of this patch)

Vulcan added a comment.Jan 4 2018, 3:46 PM

Successful build - Chance fights ever on the side of the prudent.

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...
Harbormaster completed remote builds in B4314: Diff 5083.Jan 4 2018, 3:46 PM
bb added a comment.Jan 22 2018, 11:38 PM

With D1027 in, is this patch still valid? We have a limit on the length of nicknames, but that is 20 characters, thus longer than player placement, so I do not see a need for shrinking that.
Maybe one could make the playername to something useful (it is only displaying player # right?, maybe it would be better to display "host", "client" or just a colored dot indicating the ready states), but without a clear plan, just renaming a wrong string to another wrong string doesn't seem worth it.

Imarok added a subscriber: Imarok.Jan 23 2018, 6:08 PM
In D1194#50551, @bb wrote:

Maybe one could make the playername to something useful (it is only displaying player # right?

In e.g. scenarios that is used to set it to the historical personality you play.

bb abandoned this revision.Mar 19 2018, 10:03 PM

Given that IMO this patch is a regression of the current state (those names can be longer: "Invasion Force" and vercingetorix_ are already of the same longer or equal), so abandoning the revisions, reopen is felt still required

Revision Contents
Changeset List

PathSize
binaries/
data/
mods/
public/
gui/
gamesetup/
4 lines

Diff 5083

View Options

binaries/data/mods/public/gui/gamesetup/gamesetup.xml

Loading...
Wildfire Games · Phabricator