Refs. D1268.
Details
- Reviewers
Freagarach bb - Commits
- rP23720: Allow a garrisonholder to not have health.
Verify that a garrisonHolder without health can be garrisoned and a garrisonHolder with health still behaves as usual.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/456/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/457/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/971/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/972/display/redirect
binaries/data/mods/public/simulation/components/GarrisonHolder.js | ||
---|---|---|
13–15 ↗ | (On Diff #10155) | Is it me or does it sound weird to have this set for units without a health component? |
binaries/data/mods/public/simulation/components/tests/test_GarrisonHolder.js | ||
172–174 ↗ | (On Diff #10155) | Don't add a disabled health component, rather test it before adding the health mock. One could consider testing more stuff without a health component (garrisoning and ejecting and stuff) |
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... Executing section JS... | | [NORMAL] ESLintBear (semi): | | Missing semicolon. |----| | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_GarrisonHolder.js | |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_GarrisonHolder.js | 135| 135| TS_ASSERT_EQUALS(cmpGarrisonHolder.IsFull(), false); | 136| 136| TS_ASSERT_EQUALS(cmpGarrisonHolder.UnloadAll(), true); | 137| 137| TS_ASSERT_UNEVAL_EQUALS(cmpGarrisonHolder.GetEntities(), []); | 138| |-} | | 138|+}; | 139| 139| | 140| 140| // No health component yet. | 141| 141| testGarrisonAllowed(); binaries/data/mods/public/simulation/components/tests/test_GarrisonHolder.js | 138| } | | [NORMAL] JSHintBear: | | Missing semicolon. Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1753/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2266/display/redirect