Differential D3391
Fix game speed multiplier sometimes being outside overlay box Authored by Imarok on Jan 16 2021, 10:33 PM.
Details
When you start a game with speed multiplier 1 and then change it the multiplier will be displayed outside the overlay box. The code tried to save resources by only recalculating the overlay size when the number of lines in the overlay changed. It therefore did not change the size when a line got so long that it got an automatic linebreak. As fix I just always recalculate the overlay size. Speed multiplayer is always visible when it should be.
Diff Detail
Event TimelineComment Actions Build has FAILED builderr-debug-macos.txt fatal error: fatal errorfatal error: : fatal errorfile '/Users/wfg/Jenkins/workspace/macos-differential/build/workspaces/gcc/../../../libraries/source/spidermonkey/include-unix-debug/js/Result.h' has been modified since the precompiled header 'obj/simulation2_Debug/precompiled.h.gch' was built: file '/Users/wfg/Jenkins/workspace/macos-differential/build/workspaces/gcc/../../../libraries/source/spidermonkey/include-unix-debug/js/Result.h' has been modified since the precompiled header 'obj/simulation2_Debug/precompiled.h.gch' was builtfile '/Users/wfg/Jenkins/workspace/macos-differential/build/workspaces/gcc/../../../libraries/source/spidermonkey/include-unix-debug/js/Result.h' has been modified since the precompiled header 'obj/simulation2_Debug/precompiled.h.gch' was built file '/Users/wfg/Jenkins/workspace/macos-differential/build/workspaces/gcc/../../../libraries/source/spidermonkey/include-unix-debug/js/Result.h' has been modified since the precompiled head Link to build: https://jenkins.wildfiregames.com/job/macos-differential/2910/display/redirect Comment Actions Tested it under macOS 10.15.7 SVN revision 24653 with applied patch D3391  After I "reset" my GameOptions and activate "FPS Overlay" + "Game time overlay" + game multiplier I get FPS distributed over two lines (see Picture A).  Comment Actions One could also perhaps give a callback to the speed multiplier to check whether the lines have changed? I didn't do any profiling, but it may be better. Comment Actions If one removes the 4 in the OverlayCounterTypes.prototype.FPS.prototype.Caption it works, but I don't know what it does? Does it set a max number of digits? Then the width of the overlay box might need to be updated. Comment Actions Problem is that the width is incorrect, hence the multiplier (and FPS when updating the config) fall on a new line. Comment Actions Fix linebreak noticed by Langbart. Comment Actions Build is green builderr-debug-macos.txt ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking. ld: warning: text-based stu See https://jenkins.wildfiregames.com/job/macos-differential/2998/display/redirect for more details. Comment Actions
| ||||||||||||||||||
