Page MenuHomeWildfire Games

D13 post-quisite 10: group-walk order
AbandonedPublic

Authored by wraitii on May 7 2017, 11:00 AM.

Details

Reviewers
Itms
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Owners Package(Owns No Changed Paths)
Summary

This reintroduces formation-like behaviour in the form of "grouped walking", ensuring that units walk together in a mostly sane manner.

Unlike our current formation code, it's handled strictly inside of UnitAI and doesn't require any change elsewhere. It uses a group-walk-manager system component to keep track of some things.

The result isn't nearly as neat, but units no longer bypass each other's obstruction (which is in large part why it's less neat). With pushing, the results would most likely be much better. It can also be improved quite a lot.

Test Plan

Apply all patches in this branch http://github.com/wraitii/0ad/commits/UMSplit and report on behaviour.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 1509
Build 2384: Vulcan BuildJenkins

Event Timeline

wraitii created this revision.May 7 2017, 11:00 AM

Note also that this introduces a function to compute a JPS path from the scripts.

binaries/data/mods/public/simulation/components/GuiInterface.js
807

This because it's supposed to apply on top of D439

Stan added a subscriber: Stan.May 7 2017, 1:12 PM
Stan added inline comments.
binaries/data/mods/public/simulation/components/GroupWalkManager.js
50

Should be in jsdoc @return if it's really usefull to say that. Also, undefined sounds like a wrong value that could be set to 0

56

Same here.

61

Use JSDOC syntax

88

Use JSDOC syntax

126

What is done below then ?

184

Make a function maybe ?

206

-> JSDOC at the top of the function.

Vulcan added a subscriber: Vulcan.May 7 2017, 4:21 PM

Build has FAILED

Link to build: http://jw:8080/job/phabricator/1052/
See console output for more information: http://jw:8080/job/phabricator/1052/console

wraitii abandoned this revision.May 15 2018, 8:26 AM

I'm going to support formations in D13 so drop this for now.