Paths

Table of Contentst

Differential D4976

Allow to set the biome with the autostart command.
ClosedPublic
Actions

Authored by Freagarach on Apr 3 2023, 11:04 AM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP27692: Allow to set the biome with the autostart command.

Trac Tickets

Summary

@Langbart added the option to the CLI.

Test Plan

Set the autostart-biome argument.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Freagarach created this revision.Apr 3 2023, 11:04 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8000/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/6911/display/redirect

Harbormaster completed remote builds in B21786: Diff 21706.Apr 3 2023, 11:31 AM

Freagarach requested review of this revision.Apr 3 2023, 11:31 AM

Missing entry in binaries/system/readme.txt

Add entry to ReadMe.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8002/display/redirect

I once hoped we could ditch the duplicate handling of gamesettings. Made a start with rP26584, never finished it. Adding an extra simple instance won't hurt.

source/ps/GameSetup/GameSetup.cpp
802–803 ↗	(On Diff #21708)	More duplicate documentation required.
969–974 ↗	(On Diff #21708)	Don't place this in the middle of the player handling. Rather above it.

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/6913/display/redirect

Harbormaster completed remote builds in B21788: Diff 21708.Apr 3 2023, 1:00 PM

@bb's comments.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8005/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/6916/display/redirect

Harbormaster completed remote builds in B21791: Diff 21711.Apr 3 2023, 1:56 PM

In D4976#212180, @bb wrote:

I once hoped we could ditch the duplicate handling of gamesettings. Made a start with rP26584, never finished it. Adding an extra simple instance won't hurt.

@bb are you aware D4646 ? I never bother to finish it but I agree it would be a good move

@Langbart added the option to the CLI.

@wraitii wrote it, just copied from D4117

This revision is now accepted and ready to land.Apr 5 2023, 7:02 PM

This revision was landed with ongoing or failed builds.Jun 14 2023, 8:35 AM

Closed by commit rP27692: Allow to set the biome with the autostart command. (authored by Freagarach). · Explain Why

This revision was automatically updated to reflect the committed changes.

Freagarach added a commit: rP27692: Allow to set the biome with the autostart command..

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

system/

1 line

source/

ps/

GameSetup/

7 lines

Diff 21913

ps/trunk/binaries/system/readme.txt

Loading...

ps/trunk/source/ps/GameSetup/GameSetup.cpp

Loading...