Page MenuHomeWildfire Games
Differential D5148

Split Shutdown
ClosedPublic
Actions

Authored by phosit on Oct 4 2023, 9:54 PM.

Details

Reviewers
vladislavbelov
Commits
rP28056: Split the Shutdown function
Summary

Remove a goto...
Now ShutdownConfigAndSubsequent undoes the effect of Init and and ShutdownNetworkAndUI undoes the effect of InitGraphics or InitNonVisual.

Test Plan

Run different paths throu the code: Install a mod, run Atlas, run from autostart.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

phosit created this revision.Oct 4 2023, 9:54 PM
Vulcan added a comment.Oct 4 2023, 9:55 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7362/display/redirect

Vulcan added a comment.Oct 4 2023, 10:02 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8451/display/redirect

Harbormaster completed remote builds in B22430: Diff 22361.Oct 4 2023, 10:22 PM
phosit requested review of this revision.Oct 4 2023, 10:22 PM
vladislavbelov added inline comments.Oct 5 2023, 8:32 PM
source/main.cpp
699–700 ↗(On Diff #22361)

The naming sounds like we do shutdown twice.

phosit updated this revision to Diff 22369.Oct 5 2023, 9:35 PM
phosit edited the summary of this revision. (Show Details)

I hope the names are more descriptive.

Vulcan added a comment.Oct 5 2023, 9:35 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7368/display/redirect

Vulcan added a comment.Oct 5 2023, 9:41 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8457/display/redirect

Harbormaster completed remote builds in B22440: Diff 22369.Oct 5 2023, 10:04 PM
phosit added a child revision: D5154: Implement OnScopeExit and use in in main.cpp.Oct 8 2023, 11:21 AM
phosit added a comment.Nov 4 2023, 3:56 PM

This got less usefull when abandoning D5154.

phosit abandoned this revision.Nov 4 2023, 4:28 PM
phosit reclaimed this revision.Feb 25 2024, 11:12 AM

Got more usefull with D5226.

phosit updated this revision to Diff 22804.Feb 25 2024, 11:24 AM

Rebase

phosit updated this revision to Diff 22836.Mar 23 2024, 5:48 PM

Rebase

This revision was not accepted when it landed; it landed in state Needs Review.Mar 24 2024, 1:48 PM
This revision was landed with ongoing or failed builds.
Closed by commit rP28056: Split the Shutdown function (authored by phosit). · Explain Why
This revision was automatically updated to reflect the committed changes.
phosit added a commit: rP28056: Split the Shutdown function.
Owners added a subscriber: Restricted Owners Package.Mar 24 2024, 1:48 PM

Revision Contents
Changeset List

PathSize
ps/
trunk/
source/
7 lines
ps/
GameSetup/
28 lines
9 lines
tools/
atlas/
GameInterface/
Handlers/
8 lines

Diff 22838

View Options

ps/trunk/source/main.cpp

Loading...
View Options

ps/trunk/source/ps/GameSetup/GameSetup.h

Loading...
View Options

ps/trunk/source/ps/GameSetup/GameSetup.cpp

Loading...
View Options

ps/trunk/source/tools/atlas/GameInterface/Handlers/GraphicsSetupHandlers.cpp

Loading...
Wildfire Games · Phabricator