Page MenuHomeWildfire Games
Differential D5260

Don't move elements in the bottom panel of the game setup
ClosedPublic
Actions

Authored by phosit on Sun, Apr 28, 1:10 PM.

Details

Reviewers
None
Commits
rP28078: Don't move elements in the bottom panel of the game setup
Summary

This removes much code.
This fixes the tooltip overlaping with the warning.
D4770 Adds another optional button which would make the code more complicated.

I'm not sure if the "ready button" should be hidden or just disabled.

Old:


New:


Test Plan

Test single palyer and multy player (as player and observer)

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

phosit created this revision.Sun, Apr 28, 1:10 PM
Vulcan added a comment.Sun, Apr 28, 1:12 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8792/display/redirect

Vulcan added a comment.Sun, Apr 28, 1:27 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7712/display/redirect

Harbormaster completed remote builds in B22903: Diff 22903.Sun, Apr 28, 1:27 PM
phosit requested review of this revision.Sun, Apr 28, 1:27 PM
phosit updated this revision to Diff 22904.Sun, Apr 28, 2:13 PM
phosit edited the summary of this revision. (Show Details)

Fix the tooltip size

Vulcan added a comment.Sun, Apr 28, 2:15 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8793/display/redirect

Vulcan added a comment.Sun, Apr 28, 2:29 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7713/display/redirect

Harbormaster completed remote builds in B22904: Diff 22904.Sun, Apr 28, 2:29 PM
real_tabasco_sauce awarded a token.Tue, Apr 30, 7:31 PM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, May 9, 1:13 PM
This revision was landed with ongoing or failed builds.
Closed by commit rP28078: Don't move elements in the bottom panel of the game setup (authored by phosit). · Explain Why
This revision was automatically updated to reflect the committed changes.
phosit added a commit: rP28078: Don't move elements in the bottom panel of the game setup.
Owners added a subscriber: Restricted Owners Package.Thu, May 9, 1:13 PM

Revision Contents
Changeset List

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
gui/
gamesetup/
Pages/
GameSetupPage/
3 lines
2 lines
Panels/
Buttons/
21 lines
9 lines
9 lines
11 lines
17 lines

Diff 22937

View Options

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/GameSetupPage.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/GameSetupPage.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/Panels/Buttons/CancelButton.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/Panels/Buttons/ReadyButton.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/Panels/Buttons/StartGameButton.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/Panels/GameSettingWarning.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/Panels/Tooltip.js

Loading...
Wildfire Games · Phabricator