removed the extra parameter textColorSelected from COList::DrawList()

This should prevent the compiler warnings.

updated the copyright years

Ok. I removed the whitespace.

Thanks.
Are the problematic whitespaces still there? I couldn't find them in the files, but the inline comment is gone now.

Nice. Is there anything else you want me to change?

In D5256#224195, @Norse_Harold wrote:

elexis said that this revision should not be marked as closing ticket #3307 because it doesn't resolve all of that ticket. So, remove the reference to ticket #3307 in the ticket field. Then add a comment to the description stating that this resolves part of ticket #3307.

I addressed most of the suggestions.

Ok, updated the diff. Is this how you wanted the comments?

Like this?

I added/updated the comments. Do you also want a comment before line 95? This.CountLabel is already marked for translation at this point (and has a comment explaining what it is).

Ok, nice. Made the change and added the trac ticket.

Ok, I made the change.

OK, and what's preferred?

In D5256#223808, @phosit wrote:

Before this diff the "forat translation" is allways done. That's almost certainly an issue.

Not sure what you mean by this, though. What should I change?

In D5256#223797, @phosit wrote:

I don't like it when data is mutated. (With the +=)
If one wants to know what's in the variable one has to reason about every point where it get's mutated.
If it's const one only has to reason abot the initialization.
Ideally there should be a chosenName and a translatedChosenName:

const translatedChosenName = this.settings.isNetworked ? chosenName : translate(chosenName);

elexis just wrote me again :)
User visible strings shouldn't be concatinated by + (or +=).

In D5256#223783, @phosit wrote:

I never saw Template Literals in this codepase. I don't object it. :)

The Mauryan emperors were sorted chronologically. I put them in alphabetical order too.

When the AINames are empty or don't exist, the game already throws errors before the step of choosing the names.

changing three let to const