HomeWildfire Games

Fixing the buggy passageMaker function. Smoothing the edges of the passes.
AuditedrP12641

Description

Fixing the buggy passageMaker function. Smoothing the edges of the passes.

Details

Auditors
elexis
Committed
SpahbodSep 8 2012, 12:04 PM
Parents
rP12640: Committing FeXoR's new fortress arrangement for Fortress random map. Fixes…
Branches
Unknown
Tags
Unknown

Event Timeline

elexis raised a concern with this commit.Oct 18 2017, 3:36 AM
elexis added a subscriber: elexis.

There seems to be some lineending issue preventing this commit to be displayed properly on Phabricator.

See the actual, small diff on trac:
https://trac.wildfiregames.com/changeset/12641

The commit changes 5 lines in passageMaker which look like they might be correct.
But it adds code to temporarily change TILE_CENTERED_HEIGHT_MAP (see rP10878) whereas that value is never read from in between, so it is dead & confusing code.

Like most other getHeight calls, it is intended to test the height of the center of the tile so that the center of the tile can be possibly modified.
But only one corner of the tile is tested against, so either the average of the 4 vertices of the tile or the minimum/maximum thereof should be tested ideally.

This commit now has outstanding concerns.Oct 18 2017, 3:36 AM
elexis accepted this commit.Nov 5 2017, 2:57 PM

Fixed by rP20410, rest of the commit seems good.

All concerns with this commit have now been addressed.Nov 5 2017, 2:57 PM