HomeWildfire Games
Diffusion 0 A.D. Public Repository rP20591

Move `GetAvailableMods`
rP20591
Actions

Description

Move GetAvailableMods

Reviewed by: elexis
Differential Revision: https://code.wildfiregames.com/D1106

Details

Committed
ImarokDec 5 2017, 6:17 PM
Reviewer
elexis
Differential Revision
D1106: Move `GetAvailableMods`
Parents
rP20590: [Windows] Automated build.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 3962
Build 6939: Trigger Windows Autobuild
Build 6938: Post-Commit BuildJenkins

Event Timeline

Imarok committed rP20591: Move `GetAvailableMods`.Dec 5 2017, 6:17 PM
Harbormaster completed building B3962: rP20591: Move `GetAvailableMods`.Dec 5 2017, 7:10 PM
elexis mentioned this in rP15677: Add mod selection mod..Dec 15 2017, 5:05 PM
elexis added a subscriber: elexis.Apr 25 2018, 4:10 PM
elexis added inline comments.
/ps/trunk/source/ps/scripting/JSInterface_Mod.h
21

unneeded include contradicting the forward declaration below

elexis mentioned this in rP21778: Move ModIo JS interface functions to a separate namespace, refs rP21759..Apr 25 2018, 4:13 PM
elexis added inline comments.Apr 25 2018, 4:16 PM
/ps/trunk/source/ps/scripting/JSInterface_Mod.h
21

(Well it's needed for the CxPrivate, but the forward declaration should have been nuked)

elexis mentioned this in D1470: Remove some unused includes and redundant forward declarations.Apr 25 2018, 5:01 PM
elexis mentioned this in rP21788: Clean some forward declarations..Apr 27 2018, 6:07 PM
elexis added inline comments.Apr 27 2018, 6:32 PM
/ps/trunk/source/ps/Mod.cpp
29

missing ScriptInterface include

/ps/trunk/source/ps/Mod.h
23

One of the few instances where a oneliner forward incoude would have been sufficient (still is)

/ps/trunk/source/ps/scripting/JSInterface_Mod.cpp
20

ScriptInterface.h still needed for the CxPrivate

elexis added inline comments.Apr 27 2018, 6:37 PM
/ps/trunk/source/ps/Mod.h
23

except for that JS::Value

elexis mentioned this in rP21789: Add missing ScriptInterface includes to.Apr 27 2018, 6:48 PM

Changes (4)

PathSize
ps/
trunk/
source/
ps/
scripting/

rP20591

View Options

ps/trunk/source/ps/Mod.cpp

Loading...
View Options

ps/trunk/source/ps/Mod.h

Loading...
View Options

ps/trunk/source/ps/scripting/JSInterface_Mod.cpp

Loading...
View Options

ps/trunk/source/ps/scripting/JSInterface_Mod.h

Loading...
Wildfire Games ยท Phabricator