Thanks for the patch!
Good idea to set the default that way (as long as the user-preference is inevitably lost upon map change anyhow. I still consider it a feature that we can change a random map without the map changing settings otherwise and it's reflected in the "random" random map. Right?).

/ps/trunk/binaries/data/mods/public/simulation/components/Trigger.js
34	Since the sim helper sets the fallback, we can set this to undefined with the next trigger difficulty patch afaics.
/ps/trunk/binaries/data/mods/public/simulation/helpers/Setup.js
48	(Hence I just recalled that the fallback is also triggered if the "random" random map is selected.)

In rP20760#26529, @elexis wrote:

Thanks for the patch!
Good idea to set the default that way (as long as the user-preference is inevitably lost upon map change anyhow. I still consider it a feature that we can change a random map without the map changing settings otherwise and it's reflected in the "random" random map. Right?).

right, i didn't think of the random random maps. But using the default in that case (because of the fallback) looks fine.

/ps/trunk/binaries/data/mods/public/simulation/components/Trigger.js
34	yep

Harbormaster completed building B4302: rP20760: Allows trigger script with different difficulty levels.Jan 3 2018, 1:23 PM

bb added a subscriber: bb.Jan 3 2018, 2:09 PM

bb added inline comments.

/ps/trunk/binaries/data/mods/public/simulation/components/Trigger.js
338	why argument?
/ps/trunk/binaries/data/mods/public/simulation/data/settings/trigger_difficulties.json
8	double periods wrong in English
/ps/trunk/binaries/data/mods/public/simulation/helpers/Setup.js
46	what if it is `0`? (can't happen in current code, but doesn't seem bad to support that)

mimo mentioned this in rP20763: cleanup rP20760 following bb's comments.Jan 3 2018, 4:27 PM

mimo mentioned this in rP20790: Fix trigger difficulty level (rP20760) for translation.Jan 7 2018, 6:37 PM

I will totally use this gamesetup attribute in rmgen/, we should rename it to MapDifficulty :-)

elexis added inline comments.Mar 15 2018, 6:51 PM

/ps/trunk/binaries/data/mods/public/simulation/data/settings/trigger_difficulties.json
31	Probably should have this in the map JSON, so maps can describe how they change depending on difficulty. For example gaia cities may not have towers, champions, siege engines or walls on lower levels.