New UI for gamesetup settings
rP20945
Actions

Description

New UI for gamesetup settings

Nuke the more options window
Create 3 tabs containing all options from more options and map options, giving more space for new options
Rename options => settings in gamesetup

Reviewed By: elexis
Comments By: ffffffff and gentz
Differential Revision: https://code.wildfiregames.com/D1027

Details

Committed

bb	Jan 21 2018, 1:35 PM

Reviewer

elexis

Differential Revision

D1027: New UI for gamesetup options

Parents

rP20944: Add missing icons, and update boudica's

Branches

Unknown

Tags

Unknown

Build Status

Buildable 4583
Build 7982: Post-Commit Build

Event Timeline

bb committed rP20945: New UI for gamesetup settings.Jan 21 2018, 1:35 PM

Harbormaster failed to build B4583: rP20945: New UI for gamesetup settings!Jan 21 2018, 1:37 PM

We should probably increase the dropdown width to what it was before, at least for > 1024x768. The unused GUI space is still ungood, we just need scrolling.

Perhaps we could move the options below the tabs, never display options to clients but always display the full gamedescription for them and for the host, only display the gamedescription parts that aren't part of the gamesettings, maybe.

Also map selection dropdown height should be increased

i got once a bug hope this is not coming again when i test commit now:
ERROR: JavaScript error: gui/gamesetup/gamesetup.js line 2248
TypeError: g_SettingsTabsGUI[g_TabCategorySelected] is undefined

updateGUIObjects@gui/gamesetup/gamesetup.js:2248:1
initGUIObjects/<@gui/gamesetup/gamesetup.js:1204:4
selectPanel@gui/common/tab_buttons.js:74:2
placeTabButtons@gui/common/tab_buttons.js:51:2
initGUIObjects@gui/gamesetup/gamesetup.js:1196:1
onTick@gui/gamesetup/gamesetup.js:1909:3
__eventhandler388 (tick)@setupWindow tick:0:1

i went into gamesetup gui tested all gone out and back again. this appeared all over screen.
r20960 freshly updated and compiled no changes.

how about hitting cancel key escape to hide tab content back?

This would it D1242

In rP20945#27266, @ffffffff wrote:
i got once a bug hope this is not coming again when i test commit now:
ERROR: JavaScript error: gui/gamesetup/gamesetup.js line 2248
TypeError: g_SettingsTabsGUI[g_TabCategorySelected] is undefined
updateGUIObjects@gui/gamesetup/gamesetup.js:2248:1
initGUIObjects/<@gui/gamesetup/gamesetup.js:1204:4
selectPanel@gui/common/tab_buttons.js:74:2
placeTabButtons@gui/common/tab_buttons.js:51:2
initGUIObjects@gui/gamesetup/gamesetup.js:1196:1
onTick@gui/gamesetup/gamesetup.js:1909:3
__eventhandler388 (tick)@setupWindow tick:0:1
i went into gamesetup gui tested all gone out and back again. this appeared all over screen.
r20960 freshly updated and compiled no changes.

Got it reproduced: hold Alt+S/W when switching the gui page

We should do a long-strings test, I'm concerned that the map dropdown width is too small for a number of languages and maps

In german, a number of maps don't fit into that dropdown, whereas they did in a22.

bb mentioned this in D1260: Adjust setting sizes in gamesetup.Jan 27 2018, 6:36 PM

Sorry for the complaint, but the checkbox is not vertically centered, it was this commit, wasn't it?

bb added inline comments.Feb 16 2018, 9:39 PM