Move some utility functions from the public mod to the mod mod in preparation…
rP21754
Actions

Description

Move some utility functions from the public mod to the mod mod in preparation for upcoming commit.
Small fixes and improvement while I'm at it, by temple and elexis.

Details

Committed

Itms	Apr 22 2018, 2:03 PM

Parents

rP21753: petra: improve mod support by allowing civs to build corrals when they can't…

Branches

Unknown

Tags

Unknown

Build Status

Buildable 5932
Build 9906: Post-Commit Build	Jenkins

Event Timeline

Itms committed rP21754: Move some utility functions from the public mod to the mod mod in preparation….Apr 22 2018, 2:03 PM

The eol-syle:native property wasn't added to the new functions_msgbox.js somehow.

Lineendings are always forgotton, better leave it out of the master commit I'll do a commit for the accumulated files

Itms mentioned this in D1029: mod.io support.Apr 22 2018, 2:19 PM

In rP21754#30322, @elexis wrote:

Lineendings are always forgotton, better leave it out of the master commit I'll do a commit for the accumulated files

• leper added a subscriber: • leper.Apr 22 2018, 2:53 PM

• leper added inline comments.

/ps/trunk/binaries/data/mods/mod/gui/page_msgbox.xml
8	This was not a move in the original patch.

Harbormaster completed building B5932: rP21754: Move some utility functions from the public mod to the mod mod in preparation….Apr 22 2018, 2:58 PM

Itms added inline comments.Apr 22 2018, 2:59 PM

/ps/trunk/binaries/data/mods/mod/gui/page_msgbox.xml
8	Ah yes I wondered as well (this wasn't a change I made on purpose, I saw it before committing this) but I figured the elements in `global.xml` should not be present in message boxes, even when we are in the public mod. The FPS counter, watermark and so on should be loaded in the top-level page and do not need to be loaded in the message box. You can check that even with this move and deletion, FPS counter and so on still work when opening a message box.