Diffusion 0 A.D. Public Repository rP23391

Fix gamesetup infinite loop when selecting a falsy (sandbox) AI difficulty…
rP23391
Actions

Description

Fix gamesetup infinite loop when selecting a falsy (sandbox) AI difficulty following rP23374/D2483.
Correctly hide tips panel upon window resize.
Reported by Stan.

Details

Committed

elexis

Jan 14 2020, 6:46 AM

Parents

rP23390: Optimize some props by not using transparency.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 10787
Build 18772: Post-Commit Build	Jenkins
Build 18771: Post-Commit Build (macOS)	Jenkins

Event Timeline

elexis committed rP23391: Fix gamesetup infinite loop when selecting a falsy (sandbox) AI difficulty….Jan 14 2020, 6:46 AM

Reported by Stan on http://irclogs.wildfiregames.com/2020-01/2020-01-13-QuakeNet-%230ad-dev.log
Checked all updateGameAttributes calls to see if I missed some other cases.
Tips panel and settings panel overlapping was reproduced on my end by pressing the hotkey to resize the window to 1024*768. Starting with 1024*768 didn't trigger that.

Harbormaster completed building B10787: rP23391: Fix gamesetup infinite loop when selecting a falsy (sandbox) AI difficulty….Jan 14 2020, 6:53 AM

elexis mentioned this in D2564: Gamesetup map specific options - Landscape, Daytime.Jan 14 2020, 7:50 AM