HomeWildfire Games

Fix rP25135 and rP25137

Description

Fix rP25135 and rP25137

Fix rP25135 and rP25137.

Patch By: Nescio

Differential Revision: https://code.wildfiregames.com/D3752

Details

Event Timeline

Silier raised a concern with this commit.Aug 8 2021, 5:50 PM
Silier added a subscriber: Silier.

regression

/ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_defensive_wall_tower.xml
11

<List datatype="tokens">Support Infantry</List>

This commit now has outstanding concerns.Aug 8 2021, 5:50 PM
wraitii added inline comments.Aug 8 2021, 7:11 PM
/ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_defensive_wall_tower.xml
11

Done on purpose, see https://code.wildfiregames.com/D3706#161503 and below.

Whether that was a good call is another question, but this isn't a concern per-se

Silier resigned from this commit.Aug 8 2021, 7:15 PM
Silier added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_defensive_wall_tower.xml
11

and none of commit messages mention it

This commit no longer requires audit.Aug 8 2021, 7:15 PM
Silier removed an auditor: Silier.Aug 8 2021, 7:16 PM