Diffusion 0 A.D. Public Repository rP25634

Allow mods to say they should be ignored in replay/MP compatibility checks
Concern RaisedrP25634
Actions

Description

Allow mods to say they should be ignored in replay/MP compatibility checks

Since it is very non-trivial to determine which mods change checksums and which don't, this relies on modder goodwill (and on verification on our end for signed mods).

The declaration is an optional "ignoreInCompatibilityChecks" boolean in mod.json

Also rework slightly the MP lobby mod display to always show the host mods in a clear manner.

Differential Revision: https://code.wildfiregames.com/D3968

Details

Auditors

Langbart

Committed

wraitii

Jun 2 2021, 8:50 AM

Differential Revision

D3968: Allow mods to declare they are 'checksum compatible', i.e. don't change checksums.

Parents

rP25633: Improve 'incompatible mods' splash screen

Branches

Unknown

Tags

Unknown

Build Status

Buildable 17655
Build 40999: Trigger Windows Autobuild
Build 40998: Post-Commit Build	Jenkins
Build 40997: Post-Commit Build (macOS)	Jenkins

Event Timeline

wraitii committed rP25634: Allow mods to say they should be ignored in replay/MP compatibility checks.Jun 2 2021, 8:50 AM

wraitii added an edge: D3968: Allow mods to declare they are 'checksum compatible', i.e. don't change checksums..

Harbormaster completed building B17655: rP25634: Allow mods to say they should be ignored in replay/MP compatibility checks.Jun 2 2021, 9:17 AM

Langbart mentioned this in D4052: Update MacOS libraries.Jun 2 2021, 11:18 AM

Fixed #5053

Silier added a subscriber: Silier.Jun 2 2021, 8:29 PM

Silier added inline comments.

/ps/trunk/binaries/data/mods/mod/gui/common/mod.js
7	ERROR: JavaScript error: gui/common/mod.js line 9 Script value conversion check failed: v.isString() \|\| v.isNumber() \|\| v.isBoolean() (got type undefined) hasSameMods@gui/common/mod.js:9:16 loadFile@gui/gamesetup/Persistence/PersistentMatchSettings.js:28:4 onLoad@gui/gamesetup/Controllers/GameSettingsController.js:87:76 SetupWindow@gui/gamesetup/SetupWindow.js:59:11 init@gui/gamesetup/gamesetup.js:47:18 onPress@gui/pregame/MainMenuItems.js:90:13 performButtonAction@gui/pregame/MainMenuItemHandler.js:77:9 pressButton@gui/pregame/MainMenuItemHandler.js:63:10 ERROR: GUI page 'page_gamesetup.xml': Failed to call init() function It is solved by deleting matchsettings from config but it will cause a lot of reports in release

Silier added inline comments.Jun 2 2021, 8:32 PM

/ps/trunk/binaries/data/mods/mod/gui/common/mod.js
7	https://wildfiregames.com/forum/topic/41900-error/

wraitii added inline comments.Jun 2 2021, 9:47 PM

/ps/trunk/binaries/data/mods/mod/gui/common/mod.js
7	mh, bit confused, as I do check for undefined at L7 and the error pops up L9. I guess I must be missing something.

wraitii mentioned this in rP25778: Fix lobby dgame details panel with incompatible mods..Jun 12 2021, 10:57 AM

I have investigated the problem for ticket #6201 and I think it starts with this changeset version.

This commit now has outstanding concerns.Jul 11 2021, 3:35 PM

Silier raised a concern with this commit.Jul 21 2021, 7:52 PM

Silier added inline comments.

/ps/trunk/binaries/data/mods/mod/gui/common/mod.js
21	this is supposed to use pathname, also old mods in replays stored as arrays will show undefined here

wraitii added inline comments.Jul 30 2021, 5:18 PM

/ps/trunk/binaries/data/mods/mod/gui/common/mod.js
21	I decided against pathname explicitly IIRC, so I'd say no? . Don't understand your latter comment.

Silier added inline comments.Jul 30 2021, 5:35 PM

/ps/trunk/source/ps/Replay.cpp
169	Then why is here pathname

wraitii added inline comments.Jul 30 2021, 5:47 PM

/ps/trunk/source/ps/Replay.cpp
169	Why not :p There's an inconsistency there, but in-game we show Codes everywhere, so pathname might not be explicit, whereas the command line expects pathnames (so this reports the 'correct' missing mod for a non-visual-replay user). I guess that's as good a reason as any.