HomeWildfire Games

Split the FSM-transitions and put them in an unordered_map
Concern RaisedrP28020

Description

Split the FSM-transitions and put them in an unordered_map

Comments By: @vladislavbelov

Differential Revision: https://code.wildfiregames.com/D5225

Event Timeline

vladislavbelov raised a concern with this commit.Jan 29 2024, 8:36 PM

unsigned int doesn't fit static assertions (see the diff build results):

1>source\network\fsm.h(173): error C2607: static assertion failed (compiling source file ..\..\..\source\network\FSM.cpp)
1>source\network\fsm.h(173): error C2607: static assertion failed (compiling source file ..\..\..\source\network\NetClient.cpp)
1>source\network\fsm.h(173): error C2607: static assertion failed (compiling source file ..\..\..\source\network\NetClientTurnManager.cpp)
1>source\network\fsm.h(173): error C2607: static assertion failed (compiling source file ..\..\..\source\network\NetSession.cpp)
1>source\network\fsm.h(173): error C2607: static assertion failed (compiling source file ..\..\..\source\network\NetFileTransfer.cpp)
1>source\network\fsm.h(173): error C2607: static assertion failed (compiling source file ..\..\..\source\network\NetServer.cpp)
1>source\network\fsm.h(173): error C2607: static assertion failed (compiling source file ..\..\..\source\network\NetServerTurnManager.cpp)
This commit now has outstanding concerns.Jan 29 2024, 8:36 PM