Page MenuHomeWildfire Games

Random maps: Fert , Fert Mountain, Dune with preview and triggers
AbandonedPublic

Authored by nani on Aug 19 2018, 1:44 AM.

Details

Reviewers
None
Summary

Adds two (three) new maps to the game.

Fert and Fert Mountain can be seen as variants but due not being able to have gui custom settings they need to be in two diferent maps files.

Test Plan

No test plan.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

nani created this revision.Aug 19 2018, 1:44 AM
nani updated this revision to Diff 6864.Aug 19 2018, 3:20 AM

Improved code style

smiley added a subscriber: smiley.EditedAug 19 2018, 3:22 AM

Some things I noticed. Probably would have missed stuff as I just quickly skimmed through it. Can test some time later, currently AFK since a few days.

binaries/data/mods/public/maps/random/dune.js
3

AFAICS, not used.

59

getCenter()

61

Dont use this proxy, why not just use the original thing.

77

New lines might be more readable.

93

One pair per line may be more readable. Also, thats a tab.

104

clWater, 2, 4

binaries/data/mods/public/maps/random/fert.js
85

Existent in Vector.js. Atleast I recall seeing something like that.

101

++py is also something thats encouraged.

115

Already done in setHeight.

binaries/data/mods/public/maps/random/fert_mountain.js
597

Lots of code duplicated. Maybe you can do something like what was done to unify unknown.

nani added inline comments.Aug 19 2018, 3:40 AM
binaries/data/mods/public/maps/random/fert.js
115

Checks for:
hlist.push(p)
plist.push(p)

binaries/data/mods/public/maps/random/fert_mountain.js
597

All the code is the same expect for:
const isMountain = true;

smiley added a subscriber: FeXoR.Aug 19 2018, 3:41 AM
smiley added inline comments.Aug 19 2018, 3:44 AM
binaries/data/mods/public/maps/random/fert.js
115

Diff was updated at the time. I was referring to if (g_Map.validHeight())

nani updated this revision to Diff 6868.Aug 19 2018, 11:11 PM
nani edited the summary of this revision. (Show Details)
nani edited the test plan for this revision. (Show Details)

Improved style changed and code in accordance to comments.

nani abandoned this revision.Sep 20 2018, 7:38 AM

I will make new separated diffs for each map.

FeXoR added a comment.Sep 25 2018, 6:06 PM

@nani terrific! Thanks!