Page MenuHomeWildfire Games

nani
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 18 2018, 10:57 PM (142 w, 4 d)

Recent Activity

Tue, May 4

nani awarded D3833: Map browser: input filter, also filter random map entry a Like token.
Tue, May 4, 9:08 PM

Sat, Apr 24

nani awarded D3865: Auto-Queue feature a Like token.
Sat, Apr 24, 6:14 AM · Contributors
nani added a comment to D3865: Auto-Queue feature.

You might want to add some hotkeys for this.
I suggest these ones I already use that I think work well:
Alt+q to enable auto queue
Alt+w to disable auto queue

Sat, Apr 24, 6:13 AM · Contributors

Wed, Apr 21

nani added a comment to D3532: Pick map in map browser upon hitting return..

@Freagarach this D3833: Map browser: input filter, also filter random map entry

Wed, Apr 21, 3:27 AM

Apr 11 2021

nani updated the Trac tickets for D3833: Map browser: input filter, also filter random map entry.
Apr 11 2021, 12:23 AM
nani requested review of D3833: Map browser: input filter, also filter random map entry.
Apr 11 2021, 12:13 AM

Apr 6 2021

nani added a comment to P249 Code to profile all javascript simulation components and helper classes methods. Need to be loaded after all the other files..

(I add this code to the folder /simulation/components and /simulation/helpers/ )

Apr 6 2021, 9:26 PM
nani updated subscribers of P249 Code to profile all javascript simulation components and helper classes methods. Need to be loaded after all the other files..

@wraitii testing this on a casual multiplayer game gives me that the most expensive simulation update looks to be on the component timer.update and all the handlers is has to process , maybe this will help find a way to finally find why javascript has this terrible simulation performance

Apr 6 2021, 9:22 PM

Apr 4 2021

nani changed the visibility for P249 Code to profile all javascript simulation components and helper classes methods. Need to be loaded after all the other files..
Apr 4 2021, 9:25 PM
nani created P249 Code to profile all javascript simulation components and helper classes methods. Need to be loaded after all the other files..
Apr 4 2021, 9:24 PM
nani awarded D3787: Implement an actor quality setting, with option. a Love token.
Apr 4 2021, 2:51 AM

Apr 2 2021

nani added a comment to D3603: Water-Patch.

@DanW58 what happened? This diff looked so promising would be a pity to be left to accumulate dust.

Apr 2 2021, 1:14 AM
nani awarded D3603: Water-Patch a Love token.
Apr 2 2021, 1:12 AM

Mar 31 2021

nani accepted D3766: Further hotkey fixes: don't retrigger on key release..

At first glance seem to work as advertised, testing different hotkeys doesn't produce "retriggers" anymore. Haven't look at the code. Functional part of the diff: accepted.

Mar 31 2021, 1:57 PM

Mar 29 2021

nani added a comment to D3767: Show non-default hotkeys that appear in JSON spec files in the hotkey editor..
In D3767#163831, @nani wrote:

What if the user defines his own custom hotkeys in user.cfg which you didn't specify in GUI/hotkeys/spec/**.json. I know I'm stretching the limits but will they be deleted?

Only if they're empty/unmapped.
It seems to me you're trying to get at some feature of your mod to automatically create hotkeys or something like that? One option would be to write a JSON file with the hotkeys from your mod code (it'll get written to the user mod, but that's fine).

If you actually need this feature, I could also make it more configurable that empty hotkeys get deleted.

Mar 29 2021, 7:57 PM
nani added a comment to D3767: Show non-default hotkeys that appear in JSON spec files in the hotkey editor..

What if the user defines his own custom hotkeys in user.cfg which you didn't specify in GUI/hotkeys/spec/**.json. I know I'm stretching the limits but will they be deleted?

Mar 29 2021, 7:28 PM
nani added a comment to D3767: Show non-default hotkeys that appear in JSON spec files in the hotkey editor..

I'm even more confused now, where are things stored, how are they handled, there seems to be at least 3 independent places where hotkey config is being modified and stored.

Mar 29 2021, 7:15 PM
nani added a comment to D3766: Further hotkey fixes: don't retrigger on key release..

Should 'Down' still be sent? This is the 'repeating' event.

Mar 29 2021, 7:08 PM
nani added inline comments to D3767: Show non-default hotkeys that appear in JSON spec files in the hotkey editor..
Mar 29 2021, 7:01 PM
nani added inline comments to D3641: Improve & translate hotkey name/descriptions.
Mar 29 2021, 6:02 PM

Mar 26 2021

nani accepted rP23701: Implement keyDown event .
In rP23701#50076, @bb wrote:

That is a feature not a bug. Keydown should repeat, keyPress should fire just once. StopUnits has been explicitly discussed to be keyDown (hence repeating), (One reason being ungarrison, another being units going the attack)

Mar 26 2021, 1:11 PM
nani raised a concern with rP23701: Implement keyDown event .

KeyDown event still keeps being called after being pressed down.
Example: add a warn inside stopUnits functions and see how it repeats.

Mar 26 2021, 12:59 PM

Mar 25 2021

nani added a comment to D3737: MP netcode: allow observers to lag however much they want..

Good option to add nonetheless.

Mar 25 2021, 3:31 PM
nani added a comment to D3737: MP netcode: allow observers to lag however much they want..
In D3737#162860, @nani wrote:

Given this is not a technical issue but gameplay decision maybe would be better do a poll in forums?

I'll just add a config option that defaults to "wait for observers" for now.

Mar 25 2021, 3:20 PM
nani added a comment to D3737: MP netcode: allow observers to lag however much they want..

Given this is not a technical issue but gameplay decision maybe would be better do a poll in forums?

Mar 25 2021, 2:47 PM

Mar 24 2021

nani added a comment to D3737: MP netcode: allow observers to lag however much they want..

What if the host is an observer? Host should then always be on sync.
I am aginst this as a default, it will break the experience of observing games online and make everyone confused.

Mar 24 2021, 10:54 PM

Mar 18 2021

nani awarded D3243: Gamesetup cleanup - Separate Game Settings from the GUI Gamesetup a Baby Tequila token.
Mar 18 2021, 9:54 AM
nani added a comment to D3243: Gamesetup cleanup - Separate Game Settings from the GUI Gamesetup.

As is it now, this looks like a frankentrain mixed with the two old systems that still linger in the gamesetup code.
I suggest to try it on an simpler case instead of going for the last boss, for example the options page looks like an easy candidate to change and fom there we can feel how it would translate to other more complex pages like gamesetup once we have the idea flesh out.

Mar 18 2021, 9:54 AM

Feb 27 2021

nani added a comment to D2936: Allow limiting the max number of corpses simultaneously visible in the game.

I made a new battle profile map and profiled it.


Vanilla

Limited to 100 corpses

Limited to 50 corpses


(D3554 is needed)

Feb 27 2021, 7:14 PM
nani added a comment to D2936: Allow limiting the max number of corpses simultaneously visible in the game.

You need an ordered set by insertion, all the others options are just doing the same with extra steps. Maybe you can skip the set and do a linked list if you can guarantee no insert repetition.

Feb 27 2021, 3:59 AM

Feb 24 2021

nani added a comment to rP23939: Switch Medium and Normal map sizes..

Maybe change default map size for random maps to "Medium" then?

Feb 24 2021, 4:34 PM

Feb 11 2021

nani added a comment to D3532: Pick map in map browser upon hitting return..

Ah, I'm not sure how to fix that, @nani.

Feb 11 2021, 12:37 AM

Feb 7 2021

nani accepted D3536: Debounce gamesetup network messages to avoid lag..
Feb 7 2021, 4:50 PM
nani added a comment to D3536: Debounce gamesetup network messages to avoid lag..

Works perfectly now.

Feb 7 2021, 4:50 PM
nani added a comment to D3536: Debounce gamesetup network messages to avoid lag..

Tested it, now there is no lag for clients. You can lower it to 200 ms so is more responsive (the lag starts when you send more than 30 network messages per second so 200 ms >> 1000/30 ~ 33.33 )
The host still lags as it updates his GUI state on its own so it should have another debounce for it somewhere (idk where but the profiler (F11) says updateGameAttributes is the culprit) for that and a debounce of 50 ms should be fine.

Feb 7 2021, 1:57 PM
nani added a comment to D3532: Pick map in map browser upon hitting return..

Should'va ve said sooner :(

Feb 7 2021, 12:22 PM
nani added a comment to D3532: Pick map in map browser upon hitting return..

I don't know if I clarified enough in the forum post but what I meant was having the confirmation hotkey trigger when you press enter while searching with the text input functionality and if you press Enter then it selects the first result for you. The idea was that when you are doing a search by name you don't need to leave/move your hands from the keyboard and directly hit enter without the need of mouse interaction and then leave the case for mouse interaction for when doing a more visual search exploration.

Feb 7 2021, 12:19 PM
nani requested review of D3533: Less interline space for lobby and gamesetup chats.
Feb 7 2021, 10:42 AM

Jun 11 2020

nani added a comment to D2805: [WIP] Reinventing React - Reducing the barrier between JS GUI and C++ GUI objects.
  • nani said there was something about possible Z issues

@nani < input?

Jun 11 2020, 10:14 PM

Jun 7 2020

nani awarded D2710: DiskPlacer: avoid scanning whole map a The World Burns token.
Jun 7 2020, 6:14 AM

Jun 3 2020

nani added inline comments to D2770: Clean up the data structures in RangeManager.
Jun 3 2020, 10:41 PM

May 25 2020

nani added a comment to D2667: Upgrade engine to handle up to 30 players.

Fair enough. Then I pass the commander to you if you want to try the grid approax.

May 25 2020, 8:19 AM
nani added inline comments to D2667: Upgrade engine to handle up to 30 players.
May 25 2020, 4:32 AM
nani added a comment to D2667: Upgrade engine to handle up to 30 players.

std::array bool doesn't do bitpacking and its size must be known at compile time ( < c++2020 ), std::vector allocates in the heap. current diff has many more chances than a more extensive refactor + upgrade to have less bugs. Is practically guaranteed same performance as previous because it doesn't leave to chance the optimisations that the compiler should make (is basically a wrapper of some operations and data encapsulation). So I don't see an extra benefit changing current diff to using grid.

May 25 2020, 4:28 AM

May 17 2020

nani edited reviewers for D2667: Upgrade engine to handle up to 30 players, added: wraitii; removed: Restricted Owners Package.

Adding wraitii as it might interest him.

May 17 2020, 11:42 PM

Apr 14 2020

nani added a comment to D2684: [gameplay] make rams less effective vs organic units.

Not sure of this change. All the other siege units also do a similar damage to regular units and the cost is the same and this change would mean a great disadvantage compared to other siege units. Also in this case the bonus should also apply against other siege units.

Apr 14 2020, 11:14 PM

Apr 8 2020

nani added inline comments to D2663: Colorize username in chat when is ready and leaves match.
Apr 8 2020, 8:35 PM
nani added inline comments to D2667: Upgrade engine to handle up to 30 players.
Apr 8 2020, 7:18 PM
nani updated the diff for D2667: Upgrade engine to handle up to 30 players.

Inline fixes.

Apr 8 2020, 7:14 PM

Apr 5 2020

nani added inline comments to D2069: Syntax cleanup of GUI-interface and test..
Apr 5 2020, 7:17 PM

Apr 1 2020

nani updated the diff for D2667: Upgrade engine to handle up to 30 players.

Added more parameters to the class template to specify how many bits per "value" we use.
Fixed all the code style issues and inline comments Stan and Angen mentioned.

Apr 1 2020, 9:11 PM

Mar 29 2020

nani updated the diff for D2667: Upgrade engine to handle up to 30 players.
Mar 29 2020, 5:16 PM
nani added a comment to D2667: Upgrade engine to handle up to 30 players.
In D2667#112888, @Angen wrote:

Aside from this I got idea how this could be unlimited number of players.
You would need to store inside PlayerData an array of m_data and work with the value based on index you get.
Lets say you store m_data as u32. So if you get index 0 - 16 you get first item from array. If you get index from 17 - 32 you get second item from array and subtract 16 from index.

Mar 29 2020, 5:04 PM
nani added inline comments to D2667: Upgrade engine to handle up to 30 players.
Mar 29 2020, 5:00 PM

Mar 28 2020

nani updated the diff for D2667: Upgrade engine to handle up to 30 players.
Mar 28 2020, 7:03 PM
nani added inline comments to D2667: Upgrade engine to handle up to 30 players.
Mar 28 2020, 7:00 PM

Mar 27 2020

nani added inline comments to D2667: Upgrade engine to handle up to 30 players.
Mar 27 2020, 8:03 PM
nani awarded D2667: Upgrade engine to handle up to 30 players a The World Burns token.
Mar 27 2020, 7:57 PM
nani added inline comments to D2667: Upgrade engine to handle up to 30 players.
Mar 27 2020, 7:53 PM
nani updated the diff for D2667: Upgrade engine to handle up to 30 players.
Mar 27 2020, 7:52 PM

Mar 26 2020

nani updated the diff for D2667: Upgrade engine to handle up to 30 players.

Removed const and gave the child template parameter a different name so it wont complain in gcc.

Mar 26 2020, 8:34 PM

Mar 25 2020

Freagarach awarded D2667: Upgrade engine to handle up to 30 players a Yellow Medal token.
Mar 25 2020, 7:15 AM
nani updated the summary of D2667: Upgrade engine to handle up to 30 players.
Mar 25 2020, 12:47 AM
nani created D2667: Upgrade engine to handle up to 30 players.
Mar 25 2020, 12:44 AM

Feb 28 2020

nani added a comment to rP23484: Adds anti-aliasing option with FXAA algorithm..

Hmm, is it intended, that FXAA is not used on maps with PostEffect to default even when I enabled FXAA in the options?
I guess we will definitely get some reports because of that after the release...

Feb 28 2020, 6:36 PM

Feb 26 2020

nani added inline comments to D2642: Contrast-Adaptiv-Sharpening pass.
Feb 26 2020, 4:45 PM

Feb 21 2020

nani awarded D2642: Contrast-Adaptiv-Sharpening pass a Like token.
Feb 21 2020, 12:02 AM

Feb 16 2020

Angen awarded D2638: Optimize the event broadcast a Yellow Medal token.
Feb 16 2020, 1:26 PM
nani created D2638: Optimize the event broadcast.
Feb 16 2020, 1:25 PM

Feb 12 2020

nani updated the summary of D1703: Map browser for gamesetup.
Feb 12 2020, 10:58 PM
nani added a comment to D1703: Map browser for gamesetup.

Feb 12 2020, 10:57 PM
nani updated the diff for D1703: Map browser for gamesetup.

Improved the interface controls and made them fit them all on the right panel.
Made the search box expand the search to all maps if doesn't find of the current type and filter.
Added missing tooltips for the buttons.

Feb 12 2020, 10:53 PM
nani commandeered D1703: Map browser for gamesetup.
Feb 12 2020, 10:47 PM

Feb 9 2020

nani added a comment to D1703: Map browser for gamesetup.
  • The missing scrolling is really bad. I didnt check your JS scrolling implementation, but a slider might also work as a workaround.

What scrolling implementation?

  • The code doesnt work as intended for clients (that aren't the host) unless I missed something reading the code

As the map browser was previously a different page the only host vs client check was on the callback handle in game setup page. Now the check should be on the the map browser code itself.

Feb 9 2020, 3:09 PM

Feb 4 2020

nani added inline comments to D1703: Map browser for gamesetup.
Feb 4 2020, 2:34 PM

Feb 1 2020

nani awarded D2607: Gamesetup support to select team placement pattern a Like token.
Feb 1 2020, 12:00 AM

Jan 30 2020

nani updated the diff for D1703: Map browser for gamesetup.

Created a class for each button.

Jan 30 2020, 5:33 PM

Jan 29 2020

nani added inline comments to D1703: Map browser for gamesetup.
Jan 29 2020, 8:52 PM
nani updated the diff for D1703: Map browser for gamesetup.

Adapted diff to the new gamesetup OOP rewrite.
Bundled all previous diffs as they are part of the same feature now.

Jan 29 2020, 3:19 PM

Jan 24 2020

nani added a comment to rP23430: Gamesetup slider support, use it for Ceasefire, RelicCount, RelicDuration….

Perhaps move the game speed setting to the top, to make things visually more pleasing? This looks a bit ugly to me:

  • The sliders are rather narrow and because you have to click on them, this makes them harder to use than the vertically much larger drop-down boxes.

It would be nice if clicking above the slider, rather than exactly on the line, would also work. It shouldn't be too hard to increase the (vertical) sensitive area? And maybe make the arrow keys work with sliders as well?

Jan 24 2020, 4:11 PM
nani added inline comments to D406: Add a steps param to sliders.
Jan 24 2020, 1:47 PM

Jan 23 2020

nani accepted D2592: CSlider IGUIButtonBehavior inheritance to gain Sound, Press and Release events.
Jan 23 2020, 7:46 PM
nani added a comment to D2592: CSlider IGUIButtonBehavior inheritance to gain Sound, Press and Release events.

Tested. Works as advertised.

Jan 23 2020, 7:45 PM

Jan 14 2020

nani added a comment to D1634: Fert random map..
  • What is a fert?
Jan 14 2020, 3:49 PM
nani changed the edit policy for D1634: Fert random map..
Jan 14 2020, 3:21 PM

Jan 9 2020

nani added a comment to D2537: Adds anti-aliasing option.
In D2537#106599, @Stan wrote:

I'm not sure but I think you inverted 0.1 and 0.0, the latter seems sharper. I also agree it's an improvement.

Jan 9 2020, 12:09 PM
nani added a comment to D2537: Adds anti-aliasing option.

Also, the diff seems to have failed to upload correctly for :

Jan 9 2020, 11:04 AM
nani added a comment to D2537: Adds anti-aliasing option.

factor: 0.1 (best imo)

Jan 9 2020, 10:53 AM

Jan 8 2020

nani added a comment to D2537: Adds anti-aliasing option.

Adding a extra optional sharpening pass in fxaa.xml should improve the output image.

Jan 8 2020, 10:39 PM

Jan 5 2020

nani awarded D2537: Adds anti-aliasing option a Orange Medal token.
Jan 5 2020, 7:20 PM

Jan 4 2020

nani awarded D2528: Performance improvements to VertexBuffer a Like token.
Jan 4 2020, 2:50 PM

Dec 27 2019

nani updated the summary of D1703: Map browser for gamesetup.
Dec 27 2019, 8:59 PM
nani added a comment to D1703: Map browser for gamesetup.

also needs D1777: Move maptype and mapfilter from gui/gamesetup/ to gui/common/settings.js

Dec 27 2019, 8:40 PM

Dec 24 2019

nani accepted rP23278: Atlas Valleys and Vesuvius skirmish maps.

The other maps have spaces not underscores in the filename, not sure if that was intentional.

The maps look very good, looks like an entirely different game, congratulations!

In rP23278#40228, @nani wrote:

Vesuvius needs generic default_walls.

Sure about that? The iberian walls for player 1 are skirmish entities, so they're deleted for Mauryas for instance.

Dec 24 2019, 9:18 PM

Dec 23 2019

nani raised a concern with rP23278: Atlas Valleys and Vesuvius skirmish maps.

Vesuvius needs generic default_walls.
Also would be nice to consider having the player slots correspond to a more coherent order so teams of 2v2 3v3 4v4 can be grouped easier.

Dec 23 2019, 7:34 PM

Dec 19 2019

nani added inline comments to D2446: [WIP] - Fake physics..
Dec 19 2019, 11:40 PM
nani awarded D2446: [WIP] - Fake physics. a Love token.
Dec 19 2019, 9:47 PM
nani added a comment to D2483: Gamesetup class rewrite.

When opening single player gamesetup from mainmenu

Dec 19 2019, 3:45 PM
nani awarded D2483: Gamesetup class rewrite a Like token.
Dec 19 2019, 9:59 AM

Dec 15 2019

nani added inline comments to D2470: Fix style, Cc and slightly refactor ProductionQueue.
Dec 15 2019, 5:34 PM