Page MenuHomeWildfire Games

nani
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 18 2018, 10:57 PM (109 w, 5 d)

Recent Activity

Jun 11 2020

nani added a comment to D2805: Let GUI scripts create and delete Objects. [somewhat proof of concept].
  • nani said there was something about possible Z issues

@nani < input?

Jun 11 2020, 10:14 PM

Jun 7 2020

nani awarded D2710: DiskPlacer: avoid scanning whole map a The World Burns token.
Jun 7 2020, 6:14 AM

Jun 3 2020

nani added inline comments to D2770: Clean up the data structures in RangeManager.
Jun 3 2020, 10:41 PM

May 25 2020

nani added a comment to D2667: Upgrade engine to handle up to 30 players.

Fair enough. Then I pass the commander to you if you want to try the grid approax.

May 25 2020, 8:19 AM
nani added inline comments to D2667: Upgrade engine to handle up to 30 players.
May 25 2020, 4:32 AM
nani added a comment to D2667: Upgrade engine to handle up to 30 players.

std::array bool doesn't do bitpacking and its size must be known at compile time ( < c++2020 ), std::vector allocates in the heap. current diff has many more chances than a more extensive refactor + upgrade to have less bugs. Is practically guaranteed same performance as previous because it doesn't leave to chance the optimisations that the compiler should make (is basically a wrapper of some operations and data encapsulation). So I don't see an extra benefit changing current diff to using grid.

May 25 2020, 4:28 AM

May 17 2020

nani edited reviewers for D2667: Upgrade engine to handle up to 30 players, added: wraitii; removed: Restricted Owners Package.

Adding wraitii as it might interest him.

May 17 2020, 11:42 PM

Apr 14 2020

nani added a comment to D2684: [gameplay] make rams less effective vs organic units.

Not sure of this change. All the other siege units also do a similar damage to regular units and the cost is the same and this change would mean a great disadvantage compared to other siege units. Also in this case the bonus should also apply against other siege units.

Apr 14 2020, 11:14 PM

Apr 8 2020

nani added inline comments to D2663: Colorize username in chat when is ready and leaves match.
Apr 8 2020, 8:35 PM
nani added inline comments to D2667: Upgrade engine to handle up to 30 players.
Apr 8 2020, 7:18 PM
nani updated the diff for D2667: Upgrade engine to handle up to 30 players.

Inline fixes.

Apr 8 2020, 7:14 PM

Apr 5 2020

nani added inline comments to D2069: Syntax cleanup of GUI-interface and test..
Apr 5 2020, 7:17 PM

Apr 1 2020

nani updated the diff for D2667: Upgrade engine to handle up to 30 players.

Added more parameters to the class template to specify how many bits per "value" we use.
Fixed all the code style issues and inline comments Stan and Angen mentioned.

Apr 1 2020, 9:11 PM

Mar 29 2020

nani updated the diff for D2667: Upgrade engine to handle up to 30 players.
Mar 29 2020, 5:16 PM
nani added a comment to D2667: Upgrade engine to handle up to 30 players.
In D2667#112888, @Angen wrote:

Aside from this I got idea how this could be unlimited number of players.
You would need to store inside PlayerData an array of m_data and work with the value based on index you get.
Lets say you store m_data as u32. So if you get index 0 - 16 you get first item from array. If you get index from 17 - 32 you get second item from array and subtract 16 from index.

Mar 29 2020, 5:04 PM
nani added inline comments to D2667: Upgrade engine to handle up to 30 players.
Mar 29 2020, 5:00 PM

Mar 28 2020

nani updated the diff for D2667: Upgrade engine to handle up to 30 players.
Mar 28 2020, 7:03 PM
nani added inline comments to D2667: Upgrade engine to handle up to 30 players.
Mar 28 2020, 7:00 PM

Mar 27 2020

nani added inline comments to D2667: Upgrade engine to handle up to 30 players.
Mar 27 2020, 8:03 PM
nani awarded D2667: Upgrade engine to handle up to 30 players a The World Burns token.
Mar 27 2020, 7:57 PM
nani added inline comments to D2667: Upgrade engine to handle up to 30 players.
Mar 27 2020, 7:53 PM
nani updated the diff for D2667: Upgrade engine to handle up to 30 players.
Mar 27 2020, 7:52 PM

Mar 26 2020

nani updated the diff for D2667: Upgrade engine to handle up to 30 players.

Removed const and gave the child template parameter a different name so it wont complain in gcc.

Mar 26 2020, 8:34 PM

Mar 25 2020

Freagarach awarded D2667: Upgrade engine to handle up to 30 players a Yellow Medal token.
Mar 25 2020, 7:15 AM
nani updated the summary of D2667: Upgrade engine to handle up to 30 players.
Mar 25 2020, 12:47 AM
nani created D2667: Upgrade engine to handle up to 30 players.
Mar 25 2020, 12:44 AM

Feb 28 2020

nani added a comment to rP23484: Adds anti-aliasing option with FXAA algorithm..

Hmm, is it intended, that FXAA is not used on maps with PostEffect to default even when I enabled FXAA in the options?
I guess we will definitely get some reports because of that after the release...

Feb 28 2020, 6:36 PM

Feb 26 2020

nani added inline comments to D2642: Contrast-Adaptiv-Sharpening pass.
Feb 26 2020, 4:45 PM

Feb 21 2020

nani awarded D2642: Contrast-Adaptiv-Sharpening pass a Like token.
Feb 21 2020, 12:02 AM

Feb 16 2020

Angen awarded D2638: Optimize the event broadcast a Yellow Medal token.
Feb 16 2020, 1:26 PM
nani created D2638: Optimize the event broadcast.
Feb 16 2020, 1:25 PM

Feb 12 2020

nani updated the summary of D1703: Map browser for gamesetup.
Feb 12 2020, 10:58 PM
nani added a comment to D1703: Map browser for gamesetup.

Feb 12 2020, 10:57 PM
nani updated the diff for D1703: Map browser for gamesetup.

Improved the interface controls and made them fit them all on the right panel.
Made the search box expand the search to all maps if doesn't find of the current type and filter.
Added missing tooltips for the buttons.

Feb 12 2020, 10:53 PM
nani commandeered D1703: Map browser for gamesetup.
Feb 12 2020, 10:47 PM

Feb 9 2020

nani added a comment to D1703: Map browser for gamesetup.
  • The missing scrolling is really bad. I didnt check your JS scrolling implementation, but a slider might also work as a workaround.

What scrolling implementation?

  • The code doesnt work as intended for clients (that aren't the host) unless I missed something reading the code

As the map browser was previously a different page the only host vs client check was on the callback handle in game setup page. Now the check should be on the the map browser code itself.

Feb 9 2020, 3:09 PM

Feb 4 2020

nani added inline comments to D1703: Map browser for gamesetup.
Feb 4 2020, 2:34 PM

Feb 1 2020

nani awarded D2607: Gamesetup support to select team placement pattern a Like token.
Feb 1 2020, 12:00 AM

Jan 30 2020

nani updated the diff for D1703: Map browser for gamesetup.

Created a class for each button.

Jan 30 2020, 5:33 PM

Jan 29 2020

nani added inline comments to D1703: Map browser for gamesetup.
Jan 29 2020, 8:52 PM
nani updated the diff for D1703: Map browser for gamesetup.

Adapted diff to the new gamesetup OOP rewrite.
Bundled all previous diffs as they are part of the same feature now.

Jan 29 2020, 3:19 PM

Jan 24 2020

nani added a comment to rP23430: Gamesetup slider support, use it for Ceasefire, RelicCount, RelicDuration….

Perhaps move the game speed setting to the top, to make things visually more pleasing? This looks a bit ugly to me:

  • The sliders are rather narrow and because you have to click on them, this makes them harder to use than the vertically much larger drop-down boxes.

It would be nice if clicking above the slider, rather than exactly on the line, would also work. It shouldn't be too hard to increase the (vertical) sensitive area? And maybe make the arrow keys work with sliders as well?

Jan 24 2020, 4:11 PM
nani added inline comments to D406: Add a steps param to sliders.
Jan 24 2020, 1:47 PM

Jan 23 2020

nani accepted D2592: CSlider IGUIButtonBehavior inheritance to gain Sound, Press and Release events.
Jan 23 2020, 7:46 PM
nani added a comment to D2592: CSlider IGUIButtonBehavior inheritance to gain Sound, Press and Release events.

Tested. Works as advertised.

Jan 23 2020, 7:45 PM

Jan 14 2020

nani added a comment to D1634: Fert random map..
  • What is a fert?
Jan 14 2020, 3:49 PM
nani changed the edit policy for D1634: Fert random map..
Jan 14 2020, 3:21 PM

Jan 9 2020

nani added a comment to D2537: Adds anti-aliasing option.
In D2537#106599, @Stan wrote:

I'm not sure but I think you inverted 0.1 and 0.0, the latter seems sharper. I also agree it's an improvement.

Jan 9 2020, 12:09 PM
nani added a comment to D2537: Adds anti-aliasing option.

Also, the diff seems to have failed to upload correctly for :

Jan 9 2020, 11:04 AM
nani added a comment to D2537: Adds anti-aliasing option.

factor: 0.1 (best imo)

Jan 9 2020, 10:53 AM

Jan 8 2020

nani added a comment to D2537: Adds anti-aliasing option.

Adding a extra optional sharpening pass in fxaa.xml should improve the output image.

Jan 8 2020, 10:39 PM

Jan 5 2020

nani awarded D2537: Adds anti-aliasing option a Orange Medal token.
Jan 5 2020, 7:20 PM

Jan 4 2020

nani awarded D2528: Performance improvements to VertexBuffer a Like token.
Jan 4 2020, 2:50 PM

Dec 27 2019

nani updated the summary of D1703: Map browser for gamesetup.
Dec 27 2019, 8:59 PM
nani added a comment to D1703: Map browser for gamesetup.

also needs D1777: Move maptype and mapfilter from gui/gamesetup/ to gui/common/settings.js

Dec 27 2019, 8:40 PM

Dec 24 2019

nani accepted rP23278: Atlas Valleys and Vesuvius skirmish maps.

The other maps have spaces not underscores in the filename, not sure if that was intentional.

The maps look very good, looks like an entirely different game, congratulations!

In rP23278#40228, @nani wrote:

Vesuvius needs generic default_walls.

Sure about that? The iberian walls for player 1 are skirmish entities, so they're deleted for Mauryas for instance.

Dec 24 2019, 9:18 PM

Dec 23 2019

nani raised a concern with rP23278: Atlas Valleys and Vesuvius skirmish maps.

Vesuvius needs generic default_walls.
Also would be nice to consider having the player slots correspond to a more coherent order so teams of 2v2 3v3 4v4 can be grouped easier.

Dec 23 2019, 7:34 PM

Dec 19 2019

nani added inline comments to D2446: [WIP] - Fake physics..
Dec 19 2019, 11:40 PM
nani awarded D2446: [WIP] - Fake physics. a Love token.
Dec 19 2019, 9:47 PM
nani added a comment to D2483: Gamesetup class rewrite.

When opening single player gamesetup from mainmenu

Dec 19 2019, 3:45 PM
nani awarded D2483: Gamesetup class rewrite a Like token.
Dec 19 2019, 9:59 AM

Dec 15 2019

nani added inline comments to D2470: Fix style, Cc and slightly refactor ProductionQueue.
Dec 15 2019, 5:34 PM

Dec 13 2019

nani added inline comments to D1630: Add perlin noise generator..
Dec 13 2019, 7:47 PM

Dec 10 2019

nani added a comment to D1634: Fert random map..
In D1634#103111, @Stan wrote:

Is there no way to force victory conditions?
Would be nice to have this gamemode as a victory condition :)

Dec 10 2019, 8:01 AM
nani added inline comments to D2454: Add 2d value noise for rmgen..
Dec 10 2019, 7:36 AM

Dec 9 2019

nani added reviewers for D1634: Fert random map.: elexis, FeXoR.
Dec 9 2019, 11:09 PM
nani added a comment to D2454: Add 2d value noise for rmgen..
In D2454#102824, @FeXoR wrote:

I'm a bit confused about the seemingly random numbers in randomNoiseHashx and randomNoiseHashx.
(Is there a particular reason to chose them like this? Would it be useful to make them optional arguments?)

Dec 9 2019, 11:07 PM
nani updated the diff for D1630: Add perlin noise generator..

Fix safeguard.

Dec 9 2019, 8:13 PM
nani updated the diff for D1630: Add perlin noise generator..

Move safeguard to top.

Dec 9 2019, 7:45 PM
nani updated the diff for D1630: Add perlin noise generator..

Added safeguard.

Dec 9 2019, 7:44 PM

Dec 8 2019

nani updated the diff for D1630: Add perlin noise generator..
Dec 8 2019, 6:26 PM
nani updated the diff for D1633: PerlinPainter add to rmgen..

Changed to class notation.

Dec 8 2019, 6:25 PM
nani added a comment to D1630: Add perlin noise generator..
In D1630#102908, @FeXoR wrote:

@"let weight = multiplier;":
Shouldn't waight start at 1 and then be reduced each iteration?

Dec 8 2019, 6:09 PM
nani updated the diff for D1633: PerlinPainter add to rmgen..

Bust -> Must

Dec 8 2019, 3:27 AM

Dec 7 2019

nani updated the summary of D1630: Add perlin noise generator..
Dec 7 2019, 10:50 PM
nani updated the test plan for D1633: PerlinPainter add to rmgen..
Dec 7 2019, 10:46 PM
nani updated the diff for D1633: PerlinPainter add to rmgen..
Dec 7 2019, 10:43 PM
nani updated the diff for D1630: Add perlin noise generator..
Dec 7 2019, 10:41 PM
nani added a comment to D2285: Inform player that second market is too close to setup trade route and use disabled action.

The code looks good but I wonder if the player should have the possibility of trading even if the gain is zero.

Dec 7 2019, 8:32 PM

Dec 6 2019

nani created D2454: Add 2d value noise for rmgen..
Dec 6 2019, 4:25 PM
nani updated the diff for D1635: Add DunePainter..

Made better dune generation, faster & better code, changed dependencies.

Dec 6 2019, 4:19 PM

Nov 30 2019

nani updated the diff for D1635: Add DunePainter..
Nov 30 2019, 1:07 PM
nani updated the diff for D1635: Add DunePainter..
Nov 30 2019, 12:58 PM
nani added inline comments to D1635: Add DunePainter..
Nov 30 2019, 12:38 PM
nani updated the diff for D1635: Add DunePainter..
Nov 30 2019, 12:08 PM
nani added inline comments to D1635: Add DunePainter..
Nov 30 2019, 12:07 PM
nani updated the diff for D1635: Add DunePainter..
Nov 30 2019, 11:18 AM
nani updated the diff for D1635: Add DunePainter..

Fixes (again)

Nov 30 2019, 10:58 AM
nani updated the diff for D1635: Add DunePainter..

Seems I forgot add the possibility to customize the base height (was always 0 if ELEVATION_SET)

Nov 30 2019, 10:50 AM
nani updated the diff for D1635: Add DunePainter..
Nov 30 2019, 10:43 AM
nani updated the diff for D1635: Add DunePainter..

prototype -> class

Nov 30 2019, 10:34 AM
nani updated the test plan for D1635: Add DunePainter..
Nov 30 2019, 10:20 AM

Nov 26 2019

nani added a comment to D1635: Add DunePainter..
In D1635#102030, @FeXoR wrote:

Could you add a screenshot as a showcase, please?
There was the rectangularSmoothToHight function that took an influence map of surrounding tiles that could also be used to create dunes. (looks like it has been removed in a cleanup frenzy though...)

Nov 26 2019, 7:20 PM
nani awarded D2445: Remove ancient GUI ScriptEvent lowercase struggle a Mountain of Wealth token.
Nov 26 2019, 6:43 PM

Nov 24 2019

nani awarded D2440: Discrete LOD a Like token.
Nov 24 2019, 9:28 PM

Nov 19 2019

nani added inline comments to D817: Lobby Dialog Overlay in-game and gamesetup.
Nov 19 2019, 9:36 PM
nani added inline comments to D817: Lobby Dialog Overlay in-game and gamesetup.
Nov 19 2019, 5:47 PM

Nov 18 2019

nani retitled D2363: Validate XML directory and file attributes strings when loading. from Check attribute directory path is actually a directory when loading the folder's scripts. to Validate XML directory and file attributes strings when loading..
Nov 18 2019, 4:43 PM

Nov 17 2019

nani awarded D1977: Cheer after no enemy entities left in range a Like token.
Nov 17 2019, 8:24 PM

Nov 12 2019

nani awarded D2199: Add RL interface for Reinforcement Learning a Like token.
Nov 12 2019, 4:21 AM