Page MenuHomeWildfire Games

Stop formation when ordered to stop
ClosedPublic

Authored by temple on Oct 31 2017, 8:53 PM.

Details

Summary

As described in #3565, units don't necessarily stay stopped when told to stop as part of a formation. The problem is that the formation continues to move, and later tells its members to hurry and catch up. This patch tells the formation controller itself to stop, so it fixes both issues mentioned in the trac ticket.

Test Plan

Verify that the bugs are fixed.

(You can uncomment the visual actor in template_formation to see a flag representing the formation controller, although I think I had to tweak a few things to get it to work.)

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

temple created this revision.Oct 31 2017, 8:53 PM
wraitii accepted this revision.Dec 3 2017, 6:34 PM
This revision is now accepted and ready to land.Dec 3 2017, 6:34 PM

pls commit :)

This revision was automatically updated to reflect the committed changes.