Page MenuHomeWildfire Games

wraitii (Lancelot)
Animal

Projects

User Details

User Since
Dec 21 2016, 1:38 PM (179 w, 5 d)

Recent Activity

Today

wraitii accepted D2778: Improve the warning message for FromJSValue<CColor>.
Mon, Jun 1, 1:00 PM
wraitii added a comment to D665: Make ship pickup nicer.

Trigger-based test map, showing rather poor behaviour all around. The patch fixes the particular issue it was made to fix, but not the fact that ships move around the map too much.
I noticed that ship behaviour is bad because they don't adjust when the unit they want to pick up moves, which is because they are following a "known bad path", so they only update the path when it ends (this is WAD but the design x).

Mon, Jun 1, 11:45 AM
wraitii added a comment to D2772: Prevent Upgrading units from moving.

This plays into two concepts:

  • Controllability (see D1960)
  • actually being able to move.
Mon, Jun 1, 9:19 AM
wraitii updated the diff for D2776: [#2] Trigger an exit-reentry when the target entity of an order is renamed.

Investigating further:

  • it seems one could patrol to a target by changing the GUI. Unlikely to have worked before, fixed by this patch.
  • Guarding has some seriously custom code in Transform.js to maintain the list of guards. It seems we could clean it up a bit.
  • As noted by bb, fleeing was broken before. This fixes it but plays the "panic" sound again, so I'll add a custom handler.
  • Garrison approaching will request a new pickup, which seems fair. Garrisoned early-exits.
  • Chasing & repairing have been noted and still work correctly.
Mon, Jun 1, 9:03 AM
wraitii updated the diff for D2775: [attempt 2] Enable garrisoning on gates / fix movement of units with visible garrison points.

Add tests & actually mage visible garrisoned entities have no obstruction at all because it still broke and that makes more sense than hacking around flags.

Mon, Jun 1, 8:30 AM
wraitii requested review of D270: Allow Modifiers to affect tokens..

For the record, given the hack I'm now introducing in ProductionQueue.js, I won't commit this until I either:

  • Get some other dev to look at this and agree that it's painful but we should go along with it
  • Refactor so I can remove the hack.
Mon, Jun 1, 7:15 AM
wraitii committed rP23722: Do not change the gamma of the display on startup..
Do not change the gamma of the display on startup.
Mon, Jun 1, 7:14 AM
wraitii closed D1976: Remove gamma ramp setting..
Mon, Jun 1, 7:14 AM
wraitii added a comment to D1976: Remove gamma ramp setting..

Thanks for the look both of you, this was one of these things that had been annoying me for a while :)

Mon, Jun 1, 7:13 AM
wraitii added inline comments to D2768: Switch JS GUI Objects to a Proxy class, cleaning custom function definition..
Mon, Jun 1, 7:01 AM
wraitii accepted D2627: Report GUI object script handler error stack.
Mon, Jun 1, 6:55 AM
wraitii added a comment to D2627: Report GUI object script handler error stack.

I independently rediscovered this on D2768. ReportError seems rather useless (particularly since JSNative functions can return false to indicate failure), and it is removed in later SM versions.

Mon, Jun 1, 6:55 AM

Yesterday

wraitii added a comment to rP22296: Add unit motion integration test map.
In rP22296#42528, @bb wrote:

Seems like the pmp file is missing, map doesn't load here

Sun, May 31, 8:53 PM
wraitii added inline comments to D2776: [#2] Trigger an exit-reentry when the target entity of an order is renamed.
Sun, May 31, 8:53 PM
wraitii created D2776: [#2] Trigger an exit-reentry when the target entity of an order is renamed.
Sun, May 31, 8:52 PM
wraitii requested verification of rP23710: Enable garrisoning on gates / fix movement of units with visible garrison points.

Start game with iberians.
Update long wall to gate.
Move unit through gate.
It will never ever close back.

Sun, May 31, 8:17 PM
wraitii created D2775: [attempt 2] Enable garrisoning on gates / fix movement of units with visible garrison points.
Sun, May 31, 8:12 PM
wraitii added a comment to D1445: Make structures not block construction.

Are there any unintended consequences?

Welp, this broke rP23710

Sun, May 31, 7:59 PM
wraitii updated subscribers of D1418: Enable garrisoning on gates / fix movement of units with visible garrison points.

@Itms It seems we can now set up 're-openable diffs' which would be rather convenient here, see https://stackoverflow.com/questions/13633031/how-to-reopen-differential-review-in-phabricator

Sun, May 31, 7:08 PM
wraitii added a comment to rP23710: Enable garrisoning on gates / fix movement of units with visible garrison points.

Tested by: Nescio

For the record, I don't believe I actually tested D1418; that would have involved rebuilding the source code. What I did was comment that I liked the concept, and ask for its current status.

Sun, May 31, 7:04 PM
wraitii added a reverting change for D2735: Trigger an exit-reentry when the target entity of an order is renamed: rP23714: Revert rP23708, rP23710 and rP23711.
Sun, May 31, 12:07 PM
wraitii added a reverting change for D1418: Enable garrisoning on gates / fix movement of units with visible garrison points: rP23714: Revert rP23708, rP23710 and rP23711.
Sun, May 31, 12:07 PM
wraitii added a reverting change for rP23708: Trigger an exit-reentry when the target entity of an order is renamed: rP23714: Revert rP23708, rP23710 and rP23711.
Sun, May 31, 12:07 PM
wraitii added a reverting change for rP23710: Enable garrisoning on gates / fix movement of units with visible garrison points: rP23714: Revert rP23708, rP23710 and rP23711.
Sun, May 31, 12:07 PM
wraitii added a reverting change for rP23711: Hotfix for rP23710 - remove the OnEntityRenamed handling.: rP23714: Revert rP23708, rP23710 and rP23711.
Sun, May 31, 12:07 PM
wraitii committed rP23714: Revert rP23708, rP23710 and rP23711.
Revert rP23708, rP23710 and rP23711
Sun, May 31, 12:07 PM
wraitii closed D2773: Revert rP23708, rP23710 and rP23711.
Sun, May 31, 12:07 PM
wraitii added a comment to D2773: Revert rP23708, rP23710 and rP23711.

I'm going to assume the gcc error is CI weirdness, because it compiles locally and on mac/windows.

Sun, May 31, 12:05 PM
wraitii created D2773: Revert rP23708, rP23710 and rP23711.
Sun, May 31, 11:46 AM

Sat, May 30

wraitii added a comment to D2651: Allow right-click on disabled buttons..

I'd agree about sending specific "disabled click" messages, then we can handle notifying the player on clicking a disabled button or something.

Sat, May 30, 5:07 PM
wraitii updated the diff for D2375: Do not require a garrisonHolder to have health..

Was about to nitpick but the nit was trivial so just did it myself.
Also rebased.

Sat, May 30, 4:29 PM
wraitii commandeered D2375: Do not require a garrisonHolder to have health..
Sat, May 30, 4:29 PM
wraitii committed rP23711: Hotfix for rP23710 - remove the OnEntityRenamed handling..
Hotfix for rP23710 - remove the OnEntityRenamed handling.
Sat, May 30, 4:27 PM
wraitii added a comment to D2651: Allow right-click on disabled buttons..
Sat, May 30, 3:58 PM
wraitii requested changes to D2368: Move some logic from UnitAI's "Garrisoned"-state to "Garrison:Approaching"..

I think it's much better to rename the current "GARRISONED" to "GARRISONING" and add a new, basically empty "GARRISONED" state. You're doing too many things in APPROACHING now, while that's only supposed to be used for... Approaching :p

Sat, May 30, 3:46 PM
wraitii added a comment to D2405: [WIP] - Show turrets separately from hidden entities in a garrisonHolder..

I think we need D2367 first, but this seems like another step in the right direction.

Sat, May 30, 3:42 PM
wraitii requested changes to D2270: Allow area damages to have a minimum range..

Needs a rebase & see inlines.

Sat, May 30, 3:40 PM
wraitii added a comment to D2676: Move common functionality of Foundation and Repairable to Buildable..

I think this only works because the naming is alphabetical, sadly :/

Sat, May 30, 3:34 PM
wraitii requested changes to D2658: Allow entities to autoproduce..

Other RTS games generally have a few buildings with this feature (I'm thinking of the terracotta army in RoN, but Age I think also has buildings like that).

Sat, May 30, 3:31 PM
wraitii added a comment to D2300: [gameplay] single walking speed for all citizen infantry.

I fully support this change, including for combat behaviour. Champions can be made arbitrarily slower.
That being said, it is controversial, so I'm merely stating my opinion here.

Sat, May 30, 3:17 PM
wraitii requested changes to D2698: Do not chase units in FOW/SOD..

I believe ShouldAbandonChase already has code to do that, but maybe compare with your implementation.

Sat, May 30, 3:15 PM
wraitii added a comment to D2647: Explicitly check for undefined when applying Auras and Technologies..

Does seem worth having for consistency, even if it's kind of a slower version of "replace" anyways.
Note that multiply: 0 and add: X are not the same as replace: X as replace early-exits and so further techs are still applied.
That in itself could be seen as a bug, as our ordering is only "kinda" consistent.

Sat, May 30, 3:11 PM
wraitii added a comment to D2525: Define auto-gather/-build ranges in template..

It doesn't seem actually worth caching the search range value, since that value is not used that often and further it's rather fast to calculate anyways. You're basically adding a cache on top of the regular modifiers manager cache, as that value probably won't get outdated too often.

Sat, May 30, 3:06 PM
wraitii requested changes to D2697: Do not let every entity with UnitAI listen to "OnGlobalConstructionFinished", while it is perhaps not needed anymore..

I think you can just hook into OnGlobalEntityRenamed. Will need a little care to not break things.

Sat, May 30, 3:01 PM
wraitii added a comment to D2621: Adds GLSL shaders of overlay lines.

think you should go ahead and commit this one earlier rather than later @vladislavbelov

Sat, May 30, 2:59 PM
wraitii added a reviewer for D2056: Resupport more garrisoned slots per entity.: wraitii.

The patch's idea is interesting, I think the feature is worth having on some level, there are no obvious mistakes in the implementation that I see from a cursory look.
I'm wondering if the ability to have garrisoning sizes + restricting classes is enough to express most of what we want.

Sat, May 30, 2:56 PM
wraitii added a comment to D2646: Remove special Animal state..

Conceptually, I rather like this. I think we need to commit D1960 first though.
Needs a rebase on top of rP23710 .

Sat, May 30, 2:47 PM
wraitii added a comment to D2709: Fix Let certain formations stay in formation while attacking.

Probably requires D2702 and D2763 to even think of working properly.

Sat, May 30, 2:44 PM
wraitii added a reviewer for D2664: Commit resources at a target rather than per type.: wraitii.

Adding to my review queue, this seems like a move in the right direction

Sat, May 30, 2:42 PM
wraitii requested changes to D2693: Allow entities to auto-upgrade..

This doesn't seem extremely worthwhile tbh.

Sat, May 30, 2:40 PM
wraitii abandoned D1926: Introduce some sort of prop LOD.

Seems better to do a distance-based filtering than this odd hardcoding tbh. I find Angen's approach in D2440

Sat, May 30, 2:32 PM
wraitii abandoned D2023: Add a coala bear to try and detect unimplemented mirage functions..

DoA, but running some static analysis on our JS is probably a good idea. Should look into js analysers & lexers.

Sat, May 30, 2:29 PM
wraitii added a comment to D1976: Remove gamma ramp setting..

@Stan if you want to test something :p

Sat, May 30, 2:28 PM
wraitii planned changes to D613: Remove UniqueRange custom code in favour of unique_ptr typedef (Atomic code upgrade step 1).

This seems still worth doing in some respect, but I would need to get back into it to really see what's happening.

Sat, May 30, 2:27 PM
wraitii abandoned D1503: Add TODOs.
Sat, May 30, 2:25 PM
wraitii abandoned D1507: Explicit fall through.
Sat, May 30, 2:23 PM
wraitii abandoned D1506: Update code with range-based for loops.

Change for the sake of change imo. I should do a number of those in the range manager in my own rewrite.

Sat, May 30, 2:23 PM
wraitii abandoned D1726: Change Max Health back into a nonNegativeInteger.

Probably not worth spending time on

Sat, May 30, 2:21 PM
wraitii abandoned D1876: UnitAI cleanup - Move logic from Orders to States.

Abandoning this under the assumption it was superseded by a bunch of things, then bunch of fixes on these things, and so on.

Sat, May 30, 2:15 PM
wraitii added a comment to D1829: Fix Pathgoal::RectContainsGoal family of function for SQUARE goals, reduce ambiguities, improve coherence among the different functions..

pinging @Itms on this again, as I do believe we still have the underlying bug :)

Sat, May 30, 2:09 PM
wraitii added a comment to D2296: StatusEffects v3 - More cleanup, allow stackable, upgrades..

I do agree with Stan, I ran into this weirdness when doing the i18n but splitting the strings between attack and defender didn't occur to me :/
In general this looks quite good, I do think my "level" idea is better than stacking but that'll be for v4 :p

Sat, May 30, 12:50 PM
wraitii added a comment to D2367: [WIP] - Move the ability to hold a turret to a separate file..

This is a good idea, but then again it's my suggestion so that's cheating :P

Sat, May 30, 12:45 PM
wraitii added inline comments to D11: Implement Single-Player (SP) campaign interface.
Sat, May 30, 11:41 AM
wraitii updated the diff for D11: Implement Single-Player (SP) campaign interface.

Fix Stan's remark & also prevent starting any scenario by double clicking on them :p

Sat, May 30, 11:40 AM
wraitii committed rP23710: Enable garrisoning on gates / fix movement of units with visible garrison points.
Enable garrisoning on gates / fix movement of units with visible garrison points
Sat, May 30, 11:19 AM
wraitii closed D1418: Enable garrisoning on gates / fix movement of units with visible garrison points.
Sat, May 30, 11:18 AM
wraitii updated the diff for D270: Allow Modifiers to affect tokens..

Had the rather good idea of testing this further, and I noticed that I didn't handle the case where a template being produced was changed.

Sat, May 30, 11:09 AM
wraitii committed rP23709: Do not compute capture points for the invalid player on player defeat.
Do not compute capture points for the invalid player on player defeat
Sat, May 30, 8:26 AM
wraitii closed D2748: Do not compute capture points for the invalid player on player defeat.
Sat, May 30, 8:26 AM
wraitii updated the diff for D2770: Clean up the data structures in RangeManager .

Had left an ASSERT (instead of an ENSURE) which didn't compile.
This should fix that and gcc warnings.

Sat, May 30, 8:18 AM
wraitii updated the diff for D1418: Enable garrisoning on gates / fix movement of units with visible garrison points.

Fix my own test from yesterday's commit, failed to notice it because GitHub has some lag.

Sat, May 30, 7:48 AM
wraitii commandeered D665: Make ship pickup nicer.

I have had enough. Years of inaction on this obviously necessary bug fix to an extremely annoying part of the game which was created on Jun 20 2017, this now being May 29 2020. Finally a few comments. So I have hope, I spend my time making some requested changes. Then, nothing again.

Sat, May 30, 7:39 AM

Fri, May 29

wraitii updated the diff for D11: Implement Single-Player (SP) campaign interface.

Fix a few issues, and bump years.

Fri, May 29, 7:41 PM
wraitii updated the diff for D1418: Enable garrisoning on gates / fix movement of units with visible garrison points.

Fix tests & remove template changes that Nescio re-introduces in D2760.
Will commit once CI is reasonably green.

Fri, May 29, 7:13 PM
wraitii committed rP23708: Trigger an exit-reentry when the target entity of an order is renamed.
Trigger an exit-reentry when the target entity of an order is renamed
Fri, May 29, 7:02 PM
wraitii closed D2735: Trigger an exit-reentry when the target entity of an order is renamed.
Fri, May 29, 7:02 PM
wraitii created D2770: Clean up the data structures in RangeManager .
Fri, May 29, 6:37 PM
wraitii requested changes to D2767: Stop dodging arrows by spamclicking or patrol.

Ayyy, just thought of an issue with this. It completely breaks if the "bird-flight" distance is not the right estimator.

Fri, May 29, 7:24 AM

Wed, May 27

wraitii added a comment to D2767: Stop dodging arrows by spamclicking or patrol.

I think the concerns about annoyance with regards to micro are valid.
The formation gif is pretty egregious, but that's the result of formations adjusting improperly when patrolling (check out the behaviour of more units.

Wed, May 27, 6:56 PM
wraitii added inline comments to D2767: Stop dodging arrows by spamclicking or patrol.
Wed, May 27, 12:42 PM
wraitii added inline comments to D2767: Stop dodging arrows by spamclicking or patrol.
Wed, May 27, 8:56 AM

Tue, May 26

wraitii added inline comments to D2767: Stop dodging arrows by spamclicking or patrol.
Tue, May 26, 9:48 PM
wraitii added a comment to rP23681: Internationalise Damage Types and Status Effects using (optional) JSON files..

Maybe move these into those new damage files?

Tue, May 26, 9:05 PM
wraitii added a comment to D1418: Enable garrisoning on gates / fix movement of units with visible garrison points.

Many thanks for D2760, I'll commit it alongside this.

Also, when units on walls no longer interfere with gates, then another thing that will be possible is visible garrison slots on wall towers; do you also want a patch for that?

Tue, May 26, 9:02 PM
wraitii accepted D2767: Stop dodging arrows by spamclicking or patrol.

Have to say this feels pretty good and it works perfectly -> in my test setup from #5106 all 4 units were killed in under 15 seconds, which is as good as I got by speeding arrows up 4 times.

Tue, May 26, 4:27 PM
wraitii updated the diff for D2757: i18n scripts - switch from pology to Babel for .POT generation and update to python3.

Update generateLongStrings (quite a funny output :p ). Also cleanup a a little more in a bunch of places.

Tue, May 26, 2:57 PM
wraitii added inline comments to D270: Allow Modifiers to affect tokens..
Tue, May 26, 1:39 PM
wraitii updated the diff for D270: Allow Modifiers to affect tokens..
In D270#116956, @Stan wrote:

Are most of your breaking attempts coveres by tests ?

Tue, May 26, 1:39 PM
wraitii updated the diff for D1418: Enable garrisoning on gates / fix movement of units with visible garrison points.

Perhaps it's better if you focus this patch on the necessary mechanics changes.

Tue, May 26, 12:43 PM
wraitii updated the diff for D2768: Switch JS GUI Objects to a Proxy class, cleaning custom function definition..

Uploaded the wrong diff :p

Tue, May 26, 9:43 AM
wraitii updated the diff for D2768: Switch JS GUI Objects to a Proxy class, cleaning custom function definition..

Fixup the using.

Tue, May 26, 9:35 AM
wraitii updated the diff for D2768: Switch JS GUI Objects to a Proxy class, cleaning custom function definition..

Of course, as I say that, I realise in D1781 that I made a small mistake.

Tue, May 26, 9:35 AM
wraitii added inline comments to D1781: Fix lobby chat performance issue..
Tue, May 26, 9:04 AM
wraitii added inline comments to D1781: Fix lobby chat performance issue..
Tue, May 26, 9:01 AM
wraitii updated the diff for D1781: Fix lobby chat performance issue..

Slightly cleaner code with D2768 improvements.

Tue, May 26, 8:58 AM
wraitii updated the summary of D2768: Switch JS GUI Objects to a Proxy class, cleaning custom function definition..
Tue, May 26, 8:57 AM
wraitii updated the diff for D2768: Switch JS GUI Objects to a Proxy class, cleaning custom function definition..

Cleanups:

  • used tag dispatch instead of SFINAE for call(), resulting in much more readable code
  • possibly fix an issue with the private pointer setting, by casting correctly on both write and read.
  • slight cleanup to the template code in general.
  • fix the "friend" mess I'd left.
  • cleanup GUI_OBJECT macro and define the JS Factory there too, so it's even easier to add new types (again, see updated D1781).
Tue, May 26, 8:56 AM

Mon, May 25

wraitii updated the diff for D2746: Correctly serialize/deserialize user-defined JS objects..

(Actually remove the WIP tag)

Mon, May 25, 11:15 PM
wraitii committed rP23699: Fix some cases of units getting stuck..
Fix some cases of units getting stuck.
Mon, May 25, 10:14 PM
wraitii closed D2754: Fix a rare case of units getting stuck.
Mon, May 25, 10:14 PM