Page MenuHomeWildfire Games

wraitii (Lancelot)
Animal

Projects

User Details

User Since
Dec 21 2016, 1:38 PM (213 w, 4 d)

Recent Activity

Today

wraitii added a comment to D3466: Make wall turrets upgrade into proper towers..

Oh yeah this is almost a duplicate of that, in fact. I've posted some of my comments there, I'll change this bit here to be about upgrading wall turrets into proper towers then after that diff goes in.

Sun, Jan 24, 9:41 PM
wraitii requested changes to D2769: [gameplay] add visible garrison points to wall towers.

I failed to realised that this existed, but I fully agree with this and duplicate it somewhat in D3466.

Sun, Jan 24, 9:40 PM
wraitii added inline comments to D2269: Combine attacker data in "attackerData" in attack-related code..
Sun, Jan 24, 9:32 PM
wraitii added a comment to D3467: Limit possibility of brute force attacks when guessing password.

This looks OK to me, but haven't tested, make sure to check it still works after the changes (and forgot about const, sorry)

Sun, Jan 24, 9:30 PM
wraitii added inline comments to D2269: Combine attacker data in "attackerData" in attack-related code..
Sun, Jan 24, 9:21 PM
wraitii added a comment to D2269: Combine attacker data in "attackerData" in attack-related code..

Hm, indeed, I was wrong in that we need the object anyways for melee for attack effects.

Sun, Jan 24, 9:20 PM
wraitii added inline comments to D3467: Limit possibility of brute force attacks when guessing password.
Sun, Jan 24, 9:15 PM
wraitii added inline comments to D3467: Limit possibility of brute force attacks when guessing password.
Sun, Jan 24, 9:13 PM
wraitii added inline comments to D3467: Limit possibility of brute force attacks when guessing password.
Sun, Jan 24, 8:41 PM
wraitii updated the diff for D3465: Nerf wall towers.

After discussing with FeldFeld, only do the HP change for A24.

Sun, Jan 24, 2:11 PM
wraitii published D3466: Make wall turrets upgrade into proper towers. for review.
Sun, Jan 24, 2:09 PM
wraitii published D3465: Nerf wall towers for review.
Sun, Jan 24, 2:09 PM
wraitii committed rP24779: Increase outpost base vision to 10.
Increase outpost base vision to 10
Sun, Jan 24, 12:07 PM
wraitii closed D3464: Increase outpost base vision to 10.
Sun, Jan 24, 12:05 PM
wraitii added inline comments to D3464: Increase outpost base vision to 10.
Sun, Jan 24, 11:55 AM
wraitii added a comment to D2269: Combine attacker data in "attackerData" in attack-related code..

I don't think the added object is a huge problem, but I agree that this currently seems like change for change's sake.

Sun, Jan 24, 11:25 AM
wraitii added a comment to D2053: Implement wrapper around displaying numbers in gui.

I had a thought on this, basically 'rounding for humans':

  • As an upper limit, we never really need more than 2 significant digits for the decimal places: 0.25 is better than 0.246
  • However, we probably want 2 significant digits at least: 0.25 is also better than 0.3 or 0.2 (see gather rates).
  • But we're not scientists and we don't care about 'insignificant' significant digits: 0.1 is generally better than 0.10, a fortiori 1 is better than 1.00
    • This is debatable to an extent, and we might prefer 1.0 over 1 or 1.00 if all other related numbers have decimal places, just for visual coherence.
  • We probably don't want to round integers: 12455 over 12000, even though it's also 2 significant digits.
  • But we probably no longer care about decimals at that point: 124 over 124.2
    • I would say above 10, only 1 decimal place at most instead of 2, and above 100, none: 1.23 over 1.2, 12.6 over 12.57.
  • Multiples of .25 are probably readable enough compared to rounding to the upper/lower digit, e.g. 3.75 over 3.8 even in a "1 digit" context. Likewise, 24.25 over 24.3
    • Also debatable
Sun, Jan 24, 11:06 AM
wraitii added a comment to D3464: Increase outpost base vision to 10.

Why 10 instead of 8?

Sun, Jan 24, 10:08 AM
wraitii added a comment to D3463: Fix StandGround freezing units..

I think we should probably change that as part of a more extensive stance rewrite ;)

Sun, Jan 24, 10:00 AM
wraitii requested review of D3464: Increase outpost base vision to 10.
Sun, Jan 24, 9:49 AM
wraitii updated the Trac tickets for D3463: Fix StandGround freezing units..
Sun, Jan 24, 9:30 AM
wraitii requested review of D3463: Fix StandGround freezing units..
Sun, Jan 24, 9:20 AM
wraitii accepted D3460: Limit gather rate tooltip to 2 decimal places.

This writes 1 as 1.00 but I think it's actually OK for readability because all numbers use the same decimals.

Sun, Jan 24, 8:51 AM

Yesterday

wraitii committed rP24778: Fix error when deserializing following 24759.
Fix error when deserializing following 24759
Sat, Jan 23, 10:13 PM
wraitii closed D3461: Fix error when deserializing following 24759.
Sat, Jan 23, 10:13 PM
wraitii added a comment to D3460: Limit gather rate tooltip to 2 decimal places.

Why 2 and not 1?

Sat, Jan 23, 9:57 PM
wraitii added a reverting change for D3169: [gameplay] Adjust aura ranges following rP24217: rP24776: Fix UnitAI range queries - allow queries to ignore sizes - partial revert of….
Sat, Jan 23, 7:58 PM
wraitii added a reverting change for rP24643: Fix AI's handling of buildRestriction distances following rP24217: rP24776: Fix UnitAI range queries - allow queries to ignore sizes - partial revert of….
Sat, Jan 23, 7:57 PM
wraitii added a reverting change for D3364: Fix AI's handling of buildRestriction distances following rP24217: rP24776: Fix UnitAI range queries - allow queries to ignore sizes - partial revert of….
Sat, Jan 23, 7:57 PM
wraitii added a reverting change for rP24349: Adjust range visualisation and aura ranges following rP24217: rP24776: Fix UnitAI range queries - allow queries to ignore sizes - partial revert of….
Sat, Jan 23, 7:57 PM
wraitii committed rP24776: Fix UnitAI range queries - allow queries to ignore sizes - partial revert of….
Fix UnitAI range queries - allow queries to ignore sizes - partial revert of…
Sat, Jan 23, 7:57 PM
wraitii closed D3456: Fix UnitAI range queries - allow queries to ignore sizes - partial revert of rP24217.
Sat, Jan 23, 7:57 PM
wraitii committed rP24775: Net Server: Verify password in Authenticate.
Net Server: Verify password in Authenticate
Sat, Jan 23, 7:04 PM
wraitii closed D3438: Verify password in Authenticate.
Sat, Jan 23, 7:04 PM
wraitii requested review of D3459: Hash match passwords better..
Sat, Jan 23, 6:59 PM
wraitii updated the diff for D3438: Verify password in Authenticate.

Slight formatting tweaks before commit.

Sat, Jan 23, 6:43 PM
wraitii updated the diff for D3438: Verify password in Authenticate.

Make the password not print to the logs. The length doesn't matter since it's hashed to a constant length (or 0 if there is no password, but that's also not secret information).

Sat, Jan 23, 4:59 PM
wraitii updated the diff for D3456: Fix UnitAI range queries - allow queries to ignore sizes - partial revert of rP24217.

Fix Angen's remarks.

Sat, Jan 23, 4:22 PM
wraitii added a comment to D3456: Fix UnitAI range queries - allow queries to ignore sizes - partial revert of rP24217.
In D3456#152814, @Stan wrote:

Is there a way to test what broke and forces the revert of this?

Sat, Jan 23, 4:22 PM
wraitii added a comment to D3411: Increase UnitAI formation safety.
In D3411#152810, @Stan wrote:

A24 or A25?

Sat, Jan 23, 3:59 PM
wraitii added a comment to D3446: Optimise FindWalkAndFightTargets.
In D3446#152808, @Stan wrote:

A24 or A25?

Sat, Jan 23, 3:58 PM
wraitii added a comment to D3326: Make WxWidgets High-DPI aware / Upgrade WXWidgets to 3.1.4 on MacOS.

Any news here?

Sat, Jan 23, 3:39 PM
wraitii committed rP24773: Fix issues with Cheering and PushOrderFront.
Fix issues with Cheering and PushOrderFront
Sat, Jan 23, 3:08 PM
wraitii closed D3452: Fix issues with Cheering and PushOrderFront.
Sat, Jan 23, 3:08 PM
wraitii committed rP24772: Fix hero cavalry spearman bonus.
Fix hero cavalry spearman bonus
Sat, Jan 23, 3:01 PM
wraitii closed D3453: Fix hero cavalry spearman bonus.
Sat, Jan 23, 3:01 PM
wraitii accepted D3453: Fix hero cavalry spearman bonus.

Confirmed & complete

Sat, Jan 23, 3:00 PM
wraitii added inline comments to D3398: improve some texts.
Sat, Jan 23, 2:56 PM
wraitii requested changes to D3398: improve some texts.

I'm not a fan of several of these, to be honest.

Sat, Jan 23, 2:52 PM
wraitii added a comment to D3457: Removes shadow bias for landscape shader.

I can see a few artefacts with mines with 0 bias, but 0.0005 is probably bigger than it needs to be for medium/high/very high shadow settings.
Perhaps we should just scale the bias with the shadow setting, from like 0.001 (very low) to 0.0001 (very high)

Sat, Jan 23, 2:23 PM
wraitii added inline comments to D3457: Removes shadow bias for landscape shader.
Sat, Jan 23, 2:08 PM
wraitii added inline comments to D3457: Removes shadow bias for landscape shader.
Sat, Jan 23, 2:04 PM
wraitii added inline comments to D3457: Removes shadow bias for landscape shader.
Sat, Jan 23, 2:02 PM
wraitii added inline comments to D3452: Fix issues with Cheering and PushOrderFront.
Sat, Jan 23, 1:02 PM
wraitii updated the diff for D3456: Fix UnitAI range queries - allow queries to ignore sizes - partial revert of rP24217.

Fix tests.

Sat, Jan 23, 12:57 PM
wraitii requested review of D3456: Fix UnitAI range queries - allow queries to ignore sizes - partial revert of rP24217.
Sat, Jan 23, 11:37 AM
wraitii accepted D3455: Fix cheering issue entering from idle state.
In D3455#152730, @Angen wrote:

I meant idle timer may not run yet

Sat, Jan 23, 11:31 AM
wraitii added a comment to D3455: Fix cheering issue entering from idle state.

I'm not entirely sure where units are supposed to check their surroundings in CHEERING, tbh.

Sat, Jan 23, 11:27 AM
wraitii added a reverting change for D3169: [gameplay] Adjust aura ranges following rP24217: D3456: Fix UnitAI range queries - allow queries to ignore sizes - partial revert of rP24217.
Sat, Jan 23, 11:25 AM
wraitii added a reverting change for rP24349: Adjust range visualisation and aura ranges following rP24217: D3456: Fix UnitAI range queries - allow queries to ignore sizes - partial revert of rP24217.
Sat, Jan 23, 11:25 AM
wraitii added a reverting change for D3364: Fix AI's handling of buildRestriction distances following rP24217: D3456: Fix UnitAI range queries - allow queries to ignore sizes - partial revert of rP24217.
Sat, Jan 23, 11:25 AM
wraitii added a reverting change for rP24643: Fix AI's handling of buildRestriction distances following rP24217: D3456: Fix UnitAI range queries - allow queries to ignore sizes - partial revert of rP24217.
Sat, Jan 23, 11:25 AM
wraitii added a comment to rP24217: Update range queries to account for entity size..

See https://trac.wildfiregames.com/ticket/5968

Sat, Jan 23, 10:30 AM
wraitii committed rP24771: Fix error in GATHERING when disbanding formation while members gather..
Fix error in GATHERING when disbanding formation while members gather.
Sat, Jan 23, 9:08 AM
wraitii closed D3450: Fix error in GATHERING when disbanding formation while members gather..
Sat, Jan 23, 9:08 AM
wraitii added a comment to D3454: Modified CFixedVector2D/3D that cache length to reduce calls to isqrt64(), plus a few other fixes.

Congrats on your first patch :)
A few general remarks:

  • Not everything is specified, but we have some general conventions here: https://trac.wildfiregames.com/wiki/Coding_Conventions
    • We write comments capitalised + dotted
  • from reading your forum posts, I believe you're used to 'older' C++, this has no real impact here but we're using C++17
  • we don't really do the "author: some comment" thing, though I guess you might intend those for review only. In that case, you can also leave inline comments on Phabricator.
  • you appear to have a few whitespace issues with the patch.
Sat, Jan 23, 8:56 AM

Fri, Jan 22

wraitii added a comment to D1971: Support attack-ground for ranged units..

You need to rebase this one m8 :p

Fri, Jan 22, 9:46 PM
wraitii requested review of D3452: Fix issues with Cheering and PushOrderFront.
Fri, Jan 22, 9:05 PM
wraitii raised a concern with rP24034: Cheer after combat when no enemy units are in range.

See https://trac.wildfiregames.com/ticket/5945#comment:10 & corresponding replay (works on rP24757 to rP24767)

Fri, Jan 22, 8:40 PM
wraitii committed rP24766: Fix target height computation when launching projectiles..
Fix target height computation when launching projectiles.
Fri, Jan 22, 7:16 PM
wraitii closed D3425: Fix target height computation when launching projectiles..
Fri, Jan 22, 7:16 PM
wraitii committed rP24765: Fix AI undefined error from garrisoned entities..
Fix AI undefined error from garrisoned entities.
Fri, Jan 22, 6:35 PM
wraitii closed D3451: Fix AI undefined error from garrisoned entities..
Fri, Jan 22, 6:35 PM
wraitii accepted D3388: [Petra/Ai] Fix not researching free and instant technologies.

Tested to work and this seems reasonable, and fixes Seleucids.

Fri, Jan 22, 6:30 PM
wraitii added a reverting change for D3067: Fix visual-replays not processing turn 0 commands.: rP24764: Revert rP24280, causing false OOS in visual replays..
Fri, Jan 22, 6:13 PM
wraitii added a reverting change for rP24280: Fix visual-replays not processing turn 0 commands.: rP24764: Revert rP24280, causing false OOS in visual replays..
Fri, Jan 22, 6:13 PM
wraitii committed rP24764: Revert rP24280, causing false OOS in visual replays..
Revert rP24280, causing false OOS in visual replays.
Fri, Jan 22, 6:13 PM
wraitii added a comment to D3425: Fix target height computation when launching projectiles..

Height difference (the one with the added height is obvious).



TBH at the moment it looks pretty bad because the projectile doesn't disappear on hit...

Fri, Jan 22, 4:05 PM
wraitii updated the diff for D3425: Fix target height computation when launching projectiles..

I actually renamed the C++ to "GetHeightAtFixed", which makes more sense.

Fri, Jan 22, 4:02 PM
wraitii added inline comments to D3450: Fix error in GATHERING when disbanding formation while members gather..
Fri, Jan 22, 3:45 PM
wraitii requested review of D3451: Fix AI undefined error from garrisoned entities..
Fri, Jan 22, 3:44 PM
wraitii requested review of D3450: Fix error in GATHERING when disbanding formation while members gather..
Fri, Jan 22, 3:21 PM
wraitii committed rP24763: Update bundle dist tools.
Update bundle dist tools
Fri, Jan 22, 1:54 PM
wraitii closed D3370: Update bundle dist tools.
Fri, Jan 22, 1:54 PM
wraitii committed rP24762: Fix audio leak that resulted in openAL errors after a while..
Fix audio leak that resulted in openAL errors after a while.
Fri, Jan 22, 1:50 PM
wraitii closed D3445: Probably fix OpenAL error on MacOS after a while.
Fri, Jan 22, 1:50 PM
wraitii updated the diff for D3445: Probably fix OpenAL error on MacOS after a while.

Cleanup StreamItem control flow per Stan

Fri, Jan 22, 10:00 AM
wraitii updated the diff for D3370: Update bundle dist tools.

logs/ folder under binaries/

Fri, Jan 22, 9:42 AM
wraitii added inline comments to D3370: Update bundle dist tools.
Fri, Jan 22, 9:42 AM
wraitii committed rP24759: Fix a crash in WaterRenderer.cpp.
Fix a crash in WaterRenderer.cpp
Fri, Jan 22, 9:14 AM
wraitii closed D3447: Fix a crash in WaterRenderer.cpp.
Fri, Jan 22, 9:14 AM
wraitii added a comment to D3448: Allows to override GL version for SDL.

Just FYI, but you might already now: on Mac OS, "compatibility" is always GL 2.1, and "core" is whatever is supported, generally 4.x something. Might be worth adding that as a comment / ifdef somewhere

Fri, Jan 22, 9:05 AM

Thu, Jan 21

wraitii requested review of D3447: Fix a crash in WaterRenderer.cpp.
Thu, Jan 21, 11:32 PM
wraitii updated the diff for D3445: Probably fix OpenAL error on MacOS after a while.

Inlines

Thu, Jan 21, 10:36 PM
wraitii updated the diff for D3370: Update bundle dist tools.

Really fix svn_revision & do #5955

Thu, Jan 21, 9:35 PM
wraitii requested review of D3446: Optimise FindWalkAndFightTargets.
Thu, Jan 21, 9:16 PM
wraitii resigned from rP24501: Combine "EntityCommand" and "AllyEntityCommand"..

Thnks for fixing

Thu, Jan 21, 7:02 PM
wraitii committed rP24752: Fix unit-only Attack move..
Fix unit-only Attack move.
Thu, Jan 21, 4:58 PM
wraitii closed D3436: Fix "Unit" Attack move..
Thu, Jan 21, 4:58 PM
wraitii added inline comments to D3445: Probably fix OpenAL error on MacOS after a while.
Thu, Jan 21, 4:53 PM