Page MenuHomeWildfire Games

wraitii (Lancelot)
Animal

Projects

User Details

User Since
Dec 21 2016, 1:38 PM (147 w, 3 d)

Recent Activity

Sun, Sep 29

wraitii added a comment to D2281: Status Effects v2 - More cleanup, allow modifiers..

See also IRC today -> some changes for i18n needed.

Sun, Sep 29, 11:41 AM
wraitii updated the diff for D2337: Internationalise damage types and status effects using (optional) JSON files.

Add the proper context, do the cleanup.

Sun, Sep 29, 11:26 AM
wraitii added a comment to D2281: Status Effects v2 - More cleanup, allow modifiers..

Think this looks good now, see inline and I'll commit this.

Sun, Sep 29, 10:55 AM
wraitii committed rP23014: Fix phase notification accidentally deleted in rP22767.
Fix phase notification accidentally deleted in rP22767
Sun, Sep 29, 10:53 AM
wraitii closed D2336: Fix phase notification deleted in ModifiersManager component D274/rP22767.
Sun, Sep 29, 10:53 AM
wraitii updated the summary of D2336: Fix phase notification deleted in ModifiersManager component D274/rP22767.
Sun, Sep 29, 10:52 AM
wraitii added a comment to D2337: Internationalise damage types and status effects using (optional) JSON files.

There's a few bits of debug code I left which I'll clean up later.

Sun, Sep 29, 10:51 AM
wraitii created D2337: Internationalise damage types and status effects using (optional) JSON files.
Sun, Sep 29, 10:49 AM
wraitii accepted D2327: Add missing round when calculating trader gain, removed in "fast-actions cheat using modifiers manager"/rP22964.

When trade is 0, this means it's impossible to set up trade between the two markets, without notification, which seems to be compatible with what existed before.

Sun, Sep 29, 9:09 AM
wraitii created D2336: Fix phase notification deleted in ModifiersManager component D274/rP22767.
Sun, Sep 29, 9:05 AM
wraitii committed rP23013: Add simple tests for Attacking..
Add simple tests for Attacking.
Sun, Sep 29, 9:03 AM
wraitii committed rP23012: Fix bonus multiplier issue in rP22754 (multiple attack effects) and consider….
Fix bonus multiplier issue in rP22754 (multiple attack effects) and consider…
Sun, Sep 29, 8:58 AM
wraitii closed D2322: Fix bonus multiplier issue in rP22754 (multiple attack effects) and consider all entities with Health instead of Resistance.
Sun, Sep 29, 8:58 AM
wraitii committed rP23011: Remove specific macedonian workshop code and template usage now that all….
Remove specific macedonian workshop code and template usage now that all…
Sun, Sep 29, 8:42 AM
wraitii closed D2323: Remove redundant macedonian workshop coding, template uses; follow up to rP22984.
Sun, Sep 29, 8:42 AM
wraitii accepted D2323: Remove redundant macedonian workshop coding, template uses; follow up to rP22984.

Complete and good, thanks for the patch.

Sun, Sep 29, 8:40 AM
wraitii retitled D2327: Add missing round when calculating trader gain, removed in "fast-actions cheat using modifiers manager"/rP22964 from Add missing round removed in fast-actions cheat using modifiers manager rP22964 to Add missing round when calculating trader gain, removed in "fast-actions cheat using modifiers manager"/rP22964.
Sun, Sep 29, 8:35 AM
wraitii added inline comments to rP22506: Restore previous formation behaviour of targeting nearby enemies when idle /….
Sun, Sep 29, 8:31 AM
wraitii added inline comments to rP22506: Restore previous formation behaviour of targeting nearby enemies when idle /….
Sun, Sep 29, 8:29 AM

Wed, Sep 25

wraitii added inline comments to rP22767: Add a system component to handle stat modifiers, make technologies and auras….
Wed, Sep 25, 5:14 PM
wraitii added inline comments to rP22767: Add a system component to handle stat modifiers, make technologies and auras….
Wed, Sep 25, 4:44 PM

Tue, Sep 24

wraitii accepted D2326: Fix projectiles fired from sky / missing cast in Vector3D in rP22184.

Thanks for looking at this, indeed that's broken.

Tue, Sep 24, 4:17 PM
wraitii added inline comments to D2281: Status Effects v2 - More cleanup, allow modifiers..
Tue, Sep 24, 9:47 AM
wraitii added a comment to D1960: Move the controllability of an entity to a component..

TBH I think you've over-engineered it. What's 'Order', what's 'Main' ?
I think you don't need to make something so generic. Just have 'deletable' and 'orderable' for now and handle everything from there.

Tue, Sep 24, 9:47 AM

Mon, Sep 23

wraitii added a comment to rP22982: Move palisades from other/ to structures/.

Out of curiosity, why did you decide to keep the final s? https://code.wildfiregames.com/D2234?id=9536 moved the templates to palisade_*, without s.

Mon, Sep 23, 1:31 PM
wraitii added a comment to D2281: Status Effects v2 - More cleanup, allow modifiers..
In D2281#97075, @Stan wrote:

Looks crowded. Shouldn't there be an icon in the unit icon ? One could then hover over it to get information.

Part of it is that the attack tooltip wraps, so we'd need to extend the width further.
Part of it is the text description, which probably shouldn't appear in this hover tooltip.
Part of it is that we need to rethink information entirely.

Mon, Sep 23, 1:19 PM
wraitii requested verification of rP22970: Adds a "properties"-property to resources and let mods be able to prevent….
Mon, Sep 23, 10:45 AM
wraitii added a comment to rP22984: Enable workshops for all civilisations..

list champions before heroes in the production queues of fortresses
Where is this?

Mon, Sep 23, 10:41 AM
wraitii updated the diff for D2322: Fix bonus multiplier issue in rP22754 (multiple attack effects) and consider all entities with Health instead of Resistance.

Better comments. See also discussion on IRC today (2019-09-23) about the order of entities and the 'break'.

Mon, Sep 23, 10:36 AM
wraitii committed rP22984: Enable workshops for all civilisations..
Enable workshops for all civilisations.
Mon, Sep 23, 10:35 AM
wraitii closed D1761: Enable workshops.
Mon, Sep 23, 10:35 AM
elexis awarded rP22983: Fix mistakes in rP22982 a Heartbreak token.
Mon, Sep 23, 10:28 AM
wraitii updated the diff for D2322: Fix bonus multiplier issue in rP22754 (multiple attack effects) and consider all entities with Health instead of Resistance.

Invert the concat order so that enemies come before Gaia

Mon, Sep 23, 10:19 AM
wraitii committed rP22983: Fix mistakes in rP22982.
Fix mistakes in rP22982
Mon, Sep 23, 10:17 AM
wraitii updated the diff for D2322: Fix bonus multiplier issue in rP22754 (multiple attack effects) and consider all entities with Health instead of Resistance.

Slight improvement to EntitiesNearPoint

Mon, Sep 23, 10:11 AM
wraitii accepted D1761: Enable workshops.

Works, all civs have correct actors and templates, fortresses correctly updated. I've simply moved the icon next to the fortress for keeping city-phase buildings together.

Mon, Sep 23, 9:54 AM
wraitii updated the diff for D1761: Enable workshops.

Move the workshop icon next to the fortress icons as those are both city phase buildings and I think this makes more sense.

Mon, Sep 23, 9:53 AM
wraitii committed rP22982: Move palisades from other/ to structures/.
Move palisades from other/ to structures/
Mon, Sep 23, 9:48 AM
wraitii closed D2234: move palisades from other/ to structures/.
Mon, Sep 23, 9:48 AM
wraitii accepted D2234: move palisades from other/ to structures/.

Accepting the change, I think the template rename is a good move.
I'll commit this with some proper svn mv magic.

Mon, Sep 23, 9:37 AM
wraitii added inline comments to D2322: Fix bonus multiplier issue in rP22754 (multiple attack effects) and consider all entities with Health instead of Resistance.
Mon, Sep 23, 9:19 AM
wraitii created D2322: Fix bonus multiplier issue in rP22754 (multiple attack effects) and consider all entities with Health instead of Resistance.
Mon, Sep 23, 9:16 AM
wraitii committed rP22980: Fix undefined resource in PetraAI diplomacy manager after D1846/rP22970..
Fix undefined resource in PetraAI diplomacy manager after D1846/rP22970.
Mon, Sep 23, 8:47 AM
wraitii closed D2319: Fix undefined resource in PetraAI diplomacy manager after D1846/rP22970..
Mon, Sep 23, 8:47 AM
wraitii accepted D2319: Fix undefined resource in PetraAI diplomacy manager after D1846/rP22970..

Ran a quick AI 2v1 with some tributing and looked at all other loops in the code, this looks to have been the only miss.

Mon, Sep 23, 8:45 AM
wraitii committed rP22979: Fix OOS introduced by pathfinder threading preparation diff rP22902.
Fix OOS introduced by pathfinder threading preparation diff rP22902
Mon, Sep 23, 8:38 AM
wraitii closed D2317: Fix OOS introduced by pathfinder threading preparation diff rP22902.
Mon, Sep 23, 8:38 AM

Sun, Sep 22

wraitii committed rP22971: Do not send Reflection and Refraction matrices to shader when not needed.
Do not send Reflection and Refraction matrices to shader when not needed
Sun, Sep 22, 4:56 PM
wraitii closed D1954: Do not send Reflection and Refraction matrices to shader when not needed.
Sun, Sep 22, 4:56 PM
wraitii updated subscribers of rP22970: Adds a "properties"-property to resources and let mods be able to prevent….

-_- Forgot to write 'Patch By: Freagarach', sorry.

Sun, Sep 22, 4:55 PM
wraitii committed rP22970: Adds a "properties"-property to resources and let mods be able to prevent….
Adds a "properties"-property to resources and let mods be able to prevent…
Sun, Sep 22, 4:54 PM
wraitii closed D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..
Sun, Sep 22, 4:53 PM
wraitii added a comment to D2318: Defragment IGUIButtonBehavior members.

This seems like a good move.

Sun, Sep 22, 4:51 PM
wraitii updated the diff for D1954: Do not send Reflection and Refraction matrices to shader when not needed.

Rebased before committing

Sun, Sep 22, 4:47 PM
wraitii updated the diff for D2281: Status Effects v2 - More cleanup, allow modifiers..

Remove debug code

Sun, Sep 22, 4:43 PM
wraitii updated the summary of D2317: Fix OOS introduced by pathfinder threading preparation diff rP22902.
Sun, Sep 22, 4:34 PM
wraitii created D2317: Fix OOS introduced by pathfinder threading preparation diff rP22902.
Sun, Sep 22, 2:44 PM
wraitii added a comment to D2016: Rename "ElevationBonus" and "Delay" to "AttackHeightOffset" and "DamageDelay", respectively..

But it is not necessarily a bonus, it can be a debonus as well?

Sun, Sep 22, 2:07 PM
wraitii committed rP22967: Fix issue with D274/rP22767 - modifications are a list of effects, not a single….
Fix issue with D274/rP22767 - modifications are a list of effects, not a single…
Sun, Sep 22, 2:05 PM
wraitii closed D2315: Fix issue with D274/rP22767 - modifications are a list of effects, not a single effect.
Sun, Sep 22, 2:05 PM
wraitii added inline comments to D2315: Fix issue with D274/rP22767 - modifications are a list of effects, not a single effect.
Sun, Sep 22, 1:08 PM
wraitii updated the diff for D2315: Fix issue with D274/rP22767 - modifications are a list of effects, not a single effect.

One more (y) >> { y; } change. I'm keeping the one that calls ForEach because it's not really more readable and the linter is fine with it.

Sun, Sep 22, 12:51 PM
wraitii added inline comments to D2315: Fix issue with D274/rP22767 - modifications are a list of effects, not a single effect.
Sun, Sep 22, 12:48 PM
wraitii added a comment to D2016: Rename "ElevationBonus" and "Delay" to "AttackHeightOffset" and "DamageDelay", respectively..

Mh, then I suggest keeping ElevationRangeBonus for now and it could be renamed HeightOffsetRangeBonus when/if that gets implemented.

Sun, Sep 22, 12:20 PM
wraitii updated the diff for D2315: Fix issue with D274/rP22767 - modifications are a list of effects, not a single effect.

Elexis comments, and hopefully jenkins now works since the latest autobuild contains prereqs changes

Sun, Sep 22, 12:17 PM
wraitii committed rP22965: Fix broken paths in rP22963.
Fix broken paths in rP22963
Sun, Sep 22, 12:11 PM
wraitii closed D2316: Fix broken paths in rP22963.
Sun, Sep 22, 12:11 PM
wraitii added a comment to rP22963: Improve js glue code in D1839/rP22909 (hotkey state fix) and deal with rebase….

Jenkins was correct, the last revision uploaded was correct, the committed one didnt commit all files it seems.

Sun, Sep 22, 12:08 PM
wraitii updated the diff for D2316: Fix broken paths in rP22963.

This one should run

Sun, Sep 22, 12:02 PM
wraitii added a comment to D2295: Improve js glue code in D1839/rP22909 (hotkey state fix) and deal with rebase issues..

Indeed, that appears to be what I've done. I generally download the latest patch from Phabricator when committing, but I must have messed sphere, perhaps because my last downloaded file was already this diff but in an earlier version.

Sun, Sep 22, 11:57 AM
wraitii created D2316: Fix broken paths in rP22963.
Sun, Sep 22, 11:55 AM
wraitii added a comment to rP22963: Improve js glue code in D1839/rP22909 (hotkey state fix) and deal with rebase….

Erh, I did that change and tested it locally... I went wrong somewhere but not sure how.

Sun, Sep 22, 11:50 AM
wraitii updated the diff for D2281: Status Effects v2 - More cleanup, allow modifiers..

Did the changes I suggested above because I was going to change the XML schema to handle <Interval> better, but then I discovered D2315.

Sun, Sep 22, 11:44 AM
wraitii added inline comments to D2281: Status Effects v2 - More cleanup, allow modifiers..
Sun, Sep 22, 11:43 AM
wraitii created D2315: Fix issue with D274/rP22767 - modifications are a list of effects, not a single effect.
Sun, Sep 22, 11:19 AM
wraitii requested verification of rP22909: Fix hotkey events synching with hotkey state..
Sun, Sep 22, 11:19 AM
wraitii requested verification of rP22817: Optimise MakeGoalReachable and FindNearestNavcellInRegions (D53 outtake).
Sun, Sep 22, 11:18 AM
wraitii committed rP22964: Update the fast-actions cheat and AI bonuses to use the modifiers manager.
Update the fast-actions cheat and AI bonuses to use the modifiers manager
Sun, Sep 22, 9:47 AM
wraitii closed D1011: Update the fast-actions cheat and AI bonuses to use the modifiers manager.
Sun, Sep 22, 9:46 AM
wraitii accepted D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..

Works fine and I think this is nice enough right now, making the game more moddable with little added complexity. The question of extending JSON files will have to be tackled some day but so far I don't have a good answer.

Sun, Sep 22, 9:44 AM
wraitii committed rP22963: Improve js glue code in D1839/rP22909 (hotkey state fix) and deal with rebase….
Improve js glue code in D1839/rP22909 (hotkey state fix) and deal with rebase…
Sun, Sep 22, 9:39 AM
wraitii closed D2295: Improve js glue code in D1839/rP22909 (hotkey state fix) and deal with rebase issues..
Sun, Sep 22, 9:38 AM
wraitii added inline comments to D1011: Update the fast-actions cheat and AI bonuses to use the modifiers manager.
Sun, Sep 22, 9:38 AM
wraitii added a reviewer for D1958: Turrets and/or sub-units.: wraitii.
Sun, Sep 22, 9:30 AM
wraitii added a comment to D1958: Turrets and/or sub-units..

I thought that the engine did not care about rotation?

It doesn't really right now, since anything can turn instantly. So adding that wouldn't make a ton of sense. But we'll need it if we want realistic-ish tanks or battleships (or horse riders) down the line.

Sun, Sep 22, 9:29 AM
wraitii updated the diff for D1011: Update the fast-actions cheat and AI bonuses to use the modifiers manager.

Stan's comments

Sun, Sep 22, 9:21 AM
wraitii updated the diff for D2295: Improve js glue code in D1839/rP22909 (hotkey state fix) and deal with rebase issues..

Move files into a folder, final cleanups.

Sun, Sep 22, 9:14 AM
wraitii added a comment to D2016: Rename "ElevationBonus" and "Delay" to "AttackHeightOffset" and "DamageDelay", respectively..

TBH I find 'AttackHeightOffset' much less understandable than 'ElevationRangeBonus'.

Sun, Sep 22, 9:10 AM

Sat, Sep 21

wraitii added a comment to D1346: List multiselection.

TBH this sounds like a relatively good candidate for CRTP.

Sat, Sep 21, 8:41 AM

Fri, Sep 20

wraitii added a comment to D270: Allow technologies to affect tokens..

Thanks for the look everyone, I will take this as confirmation that despite the relative bug-possibilities (tbh this seems safe enough to me), there is some good from digging deeper in this project.

Fri, Sep 20, 4:21 PM
wraitii added inline comments to D270: Allow technologies to affect tokens..
Fri, Sep 20, 3:21 PM
wraitii accepted D2207: Adds a function to pick entities with obstructions on screen.
Fri, Sep 20, 8:09 AM

Sep 19 2019

wraitii added a comment to D2295: Improve js glue code in D1839/rP22909 (hotkey state fix) and deal with rebase issues..
In D2295#96153, @elexis wrote:

Sorry that I was too lazy to review the original patch, one needs to know the circumstances of the hotkey code which takes some time to get back into again.

TBH that's fine. Your time, like mine, is limited. You'll never have the time to really look at everything in advance, but if you look at what gets committed that optimises your time and the code still gets to where it needs to be.
Indeed this patch was fairly tricky, I too had to dive deep again before committing because I'd forgotten why it worked.

Sep 19 2019, 8:51 AM

Sep 18 2019

wraitii added a comment to D2303: Fix SetGarrisoned missed in rP22753..
In D2303#96116, @elexis wrote:

But is the patch correct and complete too? I remember seeing Autogarrison, refs D885, D1146, D1228, D1403

Sep 18 2019, 9:54 PM
wraitii committed rP22929: Fix SetGarrisoned() call when transforming an entity.
Fix SetGarrisoned() call when transforming an entity
Sep 18 2019, 9:07 PM
wraitii closed D2303: Fix SetGarrisoned missed in rP22753..
Sep 18 2019, 9:07 PM
wraitii accepted D2196: Fixes values of clip planes in PostProcManager.

Change is positive and this works on my machine -> Accept.

Sep 18 2019, 9:02 PM
wraitii accepted D2303: Fix SetGarrisoned missed in rP22753..

Pretty weird bug haha.

Sep 18 2019, 8:59 PM
wraitii added inline comments to D2207: Adds a function to pick entities with obstructions on screen.
Sep 18 2019, 8:51 PM
wraitii updated the diff for D2295: Improve js glue code in D1839/rP22909 (hotkey state fix) and deal with rebase issues..

Add missing autorequests.

Sep 18 2019, 8:49 PM