Page MenuHomeWildfire Games

wraitii (Lancelot)
Animal

Projects

User Details

User Since
Dec 21 2016, 1:38 PM (225 w, 4 d)

Recent Activity

Yesterday

wraitii added inline comments to D3866: De-singletonify CConfigDB, make hooks RAII.
Sun, Apr 18, 6:12 PM
wraitii added a comment to D3848: Implement a threadpool.

Thanks for giving this a look :)

Sun, Apr 18, 4:59 PM
wraitii added inline comments to D3866: De-singletonify CConfigDB, make hooks RAII.
Sun, Apr 18, 4:53 PM
wraitii updated the diff for D3848: Implement a threadpool.

RC 2, fix header.

Sun, Apr 18, 4:27 PM
wraitii updated the diff for D3848: Implement a threadpool.

'Release Candidate' update.

Sun, Apr 18, 4:00 PM
wraitii awarded D3869: Moves cinematics overlays to GUI a Like token.
Sun, Apr 18, 3:40 PM
wraitii added inline comments to D3866: De-singletonify CConfigDB, make hooks RAII.
Sun, Apr 18, 3:37 PM

Sat, Apr 17

wraitii added inline comments to D3848: Implement a threadpool.
Sat, Apr 17, 2:49 PM
wraitii updated the diff for D3848: Implement a threadpool.

Don't autocancel on destruction.

Sat, Apr 17, 2:44 PM
wraitii updated the diff for D3848: Implement a threadpool.

Some comment clarification.
Make Status an enum class, forgot enums could be implicitly converted to int and that's terrible.
Make Future never-blocking, keep packaged_task blocking. I think that's easier on client code, and seems to be the direction of concurrency TS going forward (we'll see).

Sat, Apr 17, 11:37 AM
wraitii updated the diff for D3848: Implement a threadpool.

I'm moving the dev overlay checkbox to a later diff.
Improve the handling of configdb.

Sat, Apr 17, 9:43 AM
wraitii requested review of D3866: De-singletonify CConfigDB, make hooks RAII.
Sat, Apr 17, 9:39 AM
wraitii added a comment to D3863: Move custom JS classes to globalscripts..

One thing to check -> global scripts are run directly in the 'global namespace', not in a closure, so this might introduce some pollution/noise in the global namespace if local variables were defined by these scripts.

Sat, Apr 17, 8:29 AM
wraitii added a comment to D3865: Auto-Queue feature.

(Can we get a screenshot of the GUI setup? I'd possibly like to make the icon optional (as in hidden behind an option) / make it relatively non-intrusive)

Sat, Apr 17, 8:24 AM · Contributors
wraitii added a comment to D3865: Auto-Queue feature.

Make sure to triple check serialisation, as this introduces GUI - simulation interaction (though at a glance things look setup correctly)

Sat, Apr 17, 8:13 AM · Contributors

Fri, Apr 16

wraitii added inline comments to D3848: Implement a threadpool.
Fri, Apr 16, 6:54 PM
wraitii committed rP25280: Set a stack quota for JS scripts to prevent crashes from infinite loops..
Set a stack quota for JS scripts to prevent crashes from infinite loops.
Fri, Apr 16, 6:49 PM
wraitii closed D3851: Set a stack quota for JS scripts to prevent crashes from infinite loops..
Fri, Apr 16, 6:49 PM
wraitii updated the diff for D3612: Tweak sound attenuation.

Make the max distance configurable.

Fri, Apr 16, 6:30 PM
wraitii added inline comments to D3848: Implement a threadpool.
Fri, Apr 16, 6:28 PM
wraitii updated the diff for D3851: Set a stack quota for JS scripts to prevent crashes from infinite loops..

Comments, remove UnitAI debug before committing.

Fri, Apr 16, 6:07 PM
wraitii committed rP25279: Improvements on rP25210.
Improvements on rP25210
Fri, Apr 16, 6:04 PM
wraitii closed D3852: Fix Vlad's inline from rP25210.
Fri, Apr 16, 6:04 PM
wraitii committed rP25278: Rework rP25266.
Rework rP25266
Fri, Apr 16, 6:02 PM
wraitii closed D3860: Rework rP25266.
Fri, Apr 16, 6:02 PM
wraitii added inline comments to D3848: Implement a threadpool.
Fri, Apr 16, 5:35 PM
wraitii updated the diff for D3848: Implement a threadpool.

Should fix the test crash. I had a logic issue indeed.

Fri, Apr 16, 5:34 PM
wraitii updated the diff for D3848: Implement a threadpool.

Unbreak tests, fix cppcheck.

Fri, Apr 16, 4:34 PM
wraitii updated the diff for D3848: Implement a threadpool.

Minor tweaks. Hoping to clear the warning.
I need to double check the test_dbg error on macos, could be a logic issue in the tests.

Fri, Apr 16, 4:19 PM
wraitii added inline comments to D3848: Implement a threadpool.
Fri, Apr 16, 12:36 PM
wraitii updated the diff for D3848: Implement a threadpool.

More tests, some cleanup, better handling of temporary threads.

Fri, Apr 16, 10:25 AM
wraitii added inline comments to D3854: Use a map for the weighted list..
Fri, Apr 16, 8:06 AM
wraitii added a comment to D3858: Rename `Attacking.js` to `Attack.js` and its global to `AttackHelper`..

TBH AttackHelper.js might be better than Attack.js for the helper. It's a little redundant but it avoids ambiguity which is useful.

Fri, Apr 16, 7:38 AM
wraitii added a comment to D3861: [WIP] Enforce valid mods.

I'm wondering if it wouldn't be a good idea to have some JS files that cannot be overwritten by modders, and call these from C++ instead of doing workarounds like that.

Fri, Apr 16, 7:33 AM

Thu, Apr 15

wraitii added inline comments to D3848: Implement a threadpool.
Thu, Apr 15, 9:16 PM
wraitii added inline comments to D3848: Implement a threadpool.
Thu, Apr 15, 9:00 PM
wraitii added inline comments to D3848: Implement a threadpool.
Thu, Apr 15, 8:43 PM
wraitii updated the diff for D3848: Implement a threadpool.

Several bug fixes, a few improvements.

Thu, Apr 15, 8:09 PM
wraitii requested review of D3860: Rework rP25266.
Thu, Apr 15, 5:18 PM
wraitii added a comment to rP25266: Use type_identity to simplify Clamp usage..

That means added type_identity is useless, since Clamp<Type> works without it (you might grep occurrences before the commit).

Thu, Apr 15, 3:37 PM
wraitii added a comment to rP25266: Use type_identity to simplify Clamp usage..

static_cast<int> and Clamp<int> are explicit conversions, std::type_identity is not.

Yes, my point is that
Clamp<int>(some_double, some_float, some_size_t) is just as explicit as Clamp(static_cast<int>(some_double), ...) and much more readable.

Thu, Apr 15, 3:23 PM
wraitii added a comment to rP25266: Use type_identity to simplify Clamp usage..

That's a workaround. It makes all casts implicit, which isn't good. The STL clamp doesn't use std::type_identity.

Thu, Apr 15, 3:14 PM
wraitii committed rP25266: Use type_identity to simplify Clamp usage..
Use type_identity to simplify Clamp usage.
Thu, Apr 15, 3:01 PM
wraitii closed D3859: Use type_identity to simplify Clamp usage..
Thu, Apr 15, 3:01 PM
wraitii requested review of D3859: Use type_identity to simplify Clamp usage..
Thu, Apr 15, 2:50 PM
wraitii updated the summary of D3848: Implement a threadpool.
Thu, Apr 15, 2:19 PM
wraitii added inline comments to D3848: Implement a threadpool.
Thu, Apr 15, 12:06 PM
wraitii updated the diff for D14: Thread the pathfinder computations.

Rebased.

Thu, Apr 15, 11:59 AM
wraitii updated the diff for D3848: Implement a threadpool.
  • Rename CancellableFuture to Future since I don't have a non-cancellable-future type anyways.
  • Replace ThreadPoolTask with a generic PackagedTask (std::packaged_task replacement).
  • Move it to its own header - not particularly tied to ThreadPool.
  • Make it possible to return a value via the future.
  • Clean up executor interfaces
  • Add a few more tests.
Thu, Apr 15, 11:58 AM
wraitii added a comment to D3857: Removes low-level GL calls from graphics and geometrics primitives and adds DebugRenderer.

You could make it a namespace & declare classes friend to the original type if that's more convenient, not sure. Not sure it's that useful to make the class a member variable when it's all static methods, but maybe you have some notion that state will be useful in the future

Thu, Apr 15, 7:14 AM

Wed, Apr 14

wraitii updated the diff for D3848: Implement a threadpool.

Should fix the yellow status.

Wed, Apr 14, 7:17 PM
wraitii added inline comments to D3848: Implement a threadpool.
Wed, Apr 14, 6:32 PM
wraitii updated the diff for D3848: Implement a threadpool.

Properly do ^

Wed, Apr 14, 6:31 PM
wraitii updated the diff for D3848: Implement a threadpool.
  • Add a dev overlay option to disable the thread pool.
  • Fix include
  • Tweaks.
Wed, Apr 14, 6:27 PM
wraitii added inline comments to D3848: Implement a threadpool.
Wed, Apr 14, 5:31 PM
wraitii added a comment to D14: Thread the pathfinder computations.

There's some cleanup in the LongPathfinder, but it's quite related to threading (const-safety of the unused jump-point-cache)

Wed, Apr 14, 5:12 PM
wraitii awarded D3853: [Gameplay] - Don't chase when there are still targets around. a Like token.
Wed, Apr 14, 4:58 PM
wraitii updated the diff for D14: Thread the pathfinder computations.

Following rP25256 & on top of D3848.

Wed, Apr 14, 4:56 PM
wraitii added inline comments to D3848: Implement a threadpool.
Wed, Apr 14, 4:50 PM
wraitii updated the diff for D3848: Implement a threadpool.

Fix include, turn off debug define, add a config option for easier debugging.

Wed, Apr 14, 4:49 PM
wraitii updated the diff for D3848: Implement a threadpool.

Clean up the implementation. Clean up temporary threads.
Make it possible to get a 'pool-level' executor, using a global queue.
Add some tests.

Wed, Apr 14, 4:09 PM
wraitii added inline comments to D3035: optionally unrandomize entity appearance.
Wed, Apr 14, 11:51 AM
wraitii requested review of D3852: Fix Vlad's inline from rP25210.
Wed, Apr 14, 10:38 AM
wraitii added inline comments to rP24701: Use UnitMotion to predict target position in Attack.js to prevent 'dancing'.
Wed, Apr 14, 10:35 AM
wraitii updated the diff for D3851: Set a stack quota for JS scripts to prevent crashes from infinite loops..

Should fix the debug mode assert.

Wed, Apr 14, 9:41 AM
wraitii committed rP25258: Delete "Compact RelaxNG" / .rnc files.
Delete "Compact RelaxNG" / .rnc files
Wed, Apr 14, 9:40 AM
wraitii closed D3824: Delete "Compact RelaxNG" / .rnc files.
Wed, Apr 14, 9:40 AM
wraitii committed rP25257: Fix 4 small gamesetup issues.
Fix 4 small gamesetup issues
Wed, Apr 14, 9:30 AM
wraitii closed D3841: Fix 4 gamesetup issues.
Wed, Apr 14, 9:30 AM
wraitii added inline comments to D3851: Set a stack quota for JS scripts to prevent crashes from infinite loops..
Wed, Apr 14, 9:28 AM
wraitii added a reverting change for D1918: Move pathfinder work to a worker (not yet threaded - D14 prerequisite): rP25256: Rework the pathfinder path computation setup for threading..
Wed, Apr 14, 9:24 AM
wraitii committed rP25256: Rework the pathfinder path computation setup for threading..
Rework the pathfinder path computation setup for threading.
Wed, Apr 14, 9:24 AM
wraitii closed D3849: Rework the pathfinder path computation setup for threading..
Wed, Apr 14, 9:24 AM
wraitii requested review of D3851: Set a stack quota for JS scripts to prevent crashes from infinite loops..
Wed, Apr 14, 9:24 AM
wraitii updated the diff for D3824: Delete "Compact RelaxNG" / .rnc files.

Also delete the conversion script.

Wed, Apr 14, 8:31 AM
wraitii updated the diff for D3841: Fix 4 gamesetup issues.

Fix cheats being reset every time.

Wed, Apr 14, 8:22 AM

Tue, Apr 13

wraitii requested review of D3849: Rework the pathfinder path computation setup for threading..
Tue, Apr 13, 5:28 PM
wraitii added a reverting change for D1918: Move pathfinder work to a worker (not yet threaded - D14 prerequisite): D3849: Rework the pathfinder path computation setup for threading..
Tue, Apr 13, 5:02 PM
wraitii committed rP25251: Destroy components in reverse order of construction..
Destroy components in reverse order of construction.
Tue, Apr 13, 3:48 PM
wraitii closed D3843: Destroy components in reverse order of construction..
Tue, Apr 13, 3:48 PM
wraitii committed rP25250: Use unique_ptr for secondary sim data..
Use unique_ptr for secondary sim data.
Tue, Apr 13, 3:47 PM
wraitii closed D3842: Use unique_ptr for secondary sim data..
Tue, Apr 13, 3:47 PM
wraitii requested review of D3848: Implement a threadpool.
Tue, Apr 13, 3:00 PM
wraitii added a comment to D2967: Cache the model-animation maximum bounds..
In D2967#166312, @Stan wrote:

Well each time you'll reach the limit you'll get kicked out of the game have to press continue until it happens again.

Tue, Apr 13, 7:44 AM
wraitii added inline comments to D2967: Cache the model-animation maximum bounds..
Tue, Apr 13, 7:25 AM

Mon, Apr 12

wraitii added a comment to D3842: Use unique_ptr for secondary sim data..
In D3842#166293, @Stan wrote:

What's the gain? Shorter code?

It's safer, because if one changes things one cannot forgot to call delete somewhere with this version.

Mon, Apr 12, 10:40 PM
wraitii committed rP25247: Implement mul_round in checkrefs..
Implement mul_round in checkrefs.
Mon, Apr 12, 6:34 PM
wraitii added a comment to rP25242: Fix entities being able to attack allied structures in rare cases..

Reverted in rP25246.

Mon, Apr 12, 6:17 PM
wraitii added a reverting change for D3840: Fix entities able to attack allied structures.: rP25246: Revert rP25242 - infinite loop in UnitAI when slaughtering..
Mon, Apr 12, 6:17 PM
wraitii added a reverting change for rP25242: Fix entities being able to attack allied structures in rare cases.: rP25246: Revert rP25242 - infinite loop in UnitAI when slaughtering..
Mon, Apr 12, 6:17 PM
wraitii committed rP25246: Revert rP25242 - infinite loop in UnitAI when slaughtering..
Revert rP25242 - infinite loop in UnitAI when slaughtering.
Mon, Apr 12, 6:17 PM
wraitii added a comment to rP25242: Fix entities being able to attack allied structures in rare cases..

To reproduce: start Acropolis Bay skirmish map with an AI.

Mon, Apr 12, 6:03 PM
wraitii requested review of D3844: Save the profiler2 JSON data after a visual replay.
Mon, Apr 12, 5:57 PM
wraitii requested review of D3843: Destroy components in reverse order of construction..
Mon, Apr 12, 5:48 PM
wraitii requested review of D3842: Use unique_ptr for secondary sim data..
Mon, Apr 12, 5:38 PM
wraitii requested verification of rP25238: Mixins: Remove the special mercenary technology, apply template changes….

Fixed in rP25245

Mon, Apr 12, 5:37 PM
wraitii requested review of D3841: Fix 4 gamesetup issues.
Mon, Apr 12, 4:28 PM
wraitii updated the diff for D2967: Cache the model-animation maximum bounds..

I think hashable weak_ptr is better but it looks like we won't get that until C++23, so for now I'll go with this.

Mon, Apr 12, 4:23 PM
wraitii added inline comments to D3243: Gamesetup cleanup - Separate Game Settings from the GUI Gamesetup.
Mon, Apr 12, 4:21 PM
wraitii committed rP25245: Fix issue with r25238.
Fix issue with r25238
Mon, Apr 12, 4:08 PM