Page MenuHomeWildfire Games

wraitii (Lancelot)
Animal

Projects

User Details

User Since
Dec 21 2016, 1:38 PM (294 w, 1 d)

Recent Activity

Jul 6 2022

wraitii resigned from rP25410: Do not allow to start pyrogenesis with incompatible mods.
Jul 6 2022, 9:18 AM
wraitii resigned from rP13472: Write mod data correctly. Fixes #1940..
Jul 6 2022, 9:18 AM
wraitii resigned from rP13167: Fix mod priority. Add user mod support. Fixes #1838..
Jul 6 2022, 9:17 AM

Jun 25 2022

wraitii added inline comments to D4728: No recursive calls in FunctionWrapper.h.
Jun 25 2022, 6:16 PM
wraitii added a comment to D4728: No recursive calls in FunctionWrapper.h.

Looks neater. I don't think I had a particularly good reason to use recursion here.

Jun 25 2022, 4:24 PM

Jun 24 2022

wraitii accepted D4707: [GUI] increase msgbox button size to fix text overlap.

Think this looks fine.

Jun 24 2022, 11:02 AM

Jun 19 2022

wraitii accepted rP26801: Allow setting the passability class dynamically. This is needed to improve….
Jun 19 2022, 2:55 PM

Jun 18 2022

wraitii added a comment to D4703: Choose civ randomly in gamesetup.

I didn't realise we had this feature... I'm in favour, random should be random.

Jun 18 2022, 9:29 AM

Jun 17 2022

wraitii added inline comments to D4702: Groups close minimap icons to decrease their visible count.
Jun 17 2022, 9:05 AM

Jun 14 2022

wraitii added inline comments to D4698: Fix entvalidate.py.
Jun 14 2022, 9:34 AM

Jun 13 2022

wraitii published D4698: Fix entvalidate.py for review.
Jun 13 2022, 9:51 AM

Jun 12 2022

wraitii added inline comments to D4673: [NetClient] Clean up g_xmppClient checking.
Jun 12 2022, 11:58 AM
wraitii updated the diff for D4673: [NetClient] Clean up g_xmppClient checking.

TryToConnectWithXmpp -> TryToConnectViaLobby to match the SetupConnection call (and because XMPP is basically the lobby client).

Jun 12 2022, 11:19 AM
wraitii updated the diff for D4667: Add JS bindings for in game camera attributes.

GetCameraDirection -> GetCameraOrientation for consistency with C++

Jun 12 2022, 10:59 AM
wraitii added a comment to D4667: Add JS bindings for in game camera attributes.

@edoput How do you want to appear in the credits?

Jun 12 2022, 10:57 AM
wraitii accepted D4667: Add JS bindings for in game camera attributes.
Jun 12 2022, 10:55 AM
wraitii committed rP26939: Change deprecated binary_negate<> to not_fn<>.
Change deprecated binary_negate<> to not_fn<>
Jun 12 2022, 10:48 AM
wraitii closed D4693: Fix clang warning for deprecated binary_negate<>.
Jun 12 2022, 10:46 AM
wraitii added a comment to D4682: Profiler2 lives in main().
In D4682#199519, @Stan wrote:

Oh my bad then. Just thought it'd be nice if someday we decide to have proper dependency injection.

Jun 12 2022, 10:45 AM
wraitii accepted D4693: Fix clang warning for deprecated binary_negate<>.
Jun 12 2022, 10:38 AM
wraitii added a comment to D4687: Explicitly differentiate tiles and vertices in rmgen..

Seems like you could fix a few listing problems while at it, but this gets a +1 for being a good idea.

Jun 12 2022, 10:37 AM
wraitii added a comment to D4682: Profiler2 lives in main().

Per https://trac.wildfiregames.com/wiki/Coding_Conventions, we have Prefer global variables over singletons, because then they're not trying to hide their ugliness. It's definitely something I kind of like, because singletons by design make it annoying to have two of something, and that can occasionally be useful.

Jun 12 2022, 10:36 AM
wraitii added a comment to D4679: [Gameplay] - Only have capturing entities contribute to the capture regenrate..

That sounds like good play then? And reckless play from the defender? There are walls to fend off these kind of raids?

Jun 12 2022, 10:32 AM
wraitii added a comment to D4677: span and string_view for CmdLineArgs.

Think this is generally a fairly good first use case, but I believe you could write simpler code, particularly since this bit doesn't really require us to optimise it to death.

Jun 12 2022, 10:31 AM
wraitii added a comment to D4676: [WIP] [Gameplay] Change of the capture paradigm.

Maybe this is too simple, but why don’t we just switch default unit behavior to destroy instead of capture and adjust health and control metrics to reflect how we want them? [...] It seems like it an all around win.

Jun 12 2022, 10:24 AM
wraitii accepted D4673: [NetClient] Clean up g_xmppClient checking.

I'll make a minor tweak to avoid double-messages but I think this looks good

Jun 12 2022, 10:23 AM

Jun 10 2022

wraitii committed rP26934: Improve shadow artifact problems without shadow filtering in some A25….
Improve shadow artifact problems without shadow filtering in some A25…
Jun 10 2022, 9:40 AM
wraitii closed D4681: Fix shadow artifacts without shadow filtering in some A25 biomes/maps.
Jun 10 2022, 9:40 AM
wraitii committed rP26933: Fix gamesetup breakage when matchsettings.json contains incorrect victory….
Fix gamesetup breakage when matchsettings.json contains incorrect victory…
Jun 10 2022, 9:38 AM
wraitii closed D4678: Fix gamesetup breakage when matchsettings.json contains incorrect victory conditions..
Jun 10 2022, 9:38 AM

Jun 9 2022

wraitii updated the diff for D4678: Fix gamesetup breakage when matchsettings.json contains incorrect victory conditions..

Lint

Jun 9 2022, 8:57 AM
wraitii updated the diff for D4681: Fix shadow artifacts without shadow filtering in some A25 biomes/maps.

This should fix that case as well.

Jun 9 2022, 8:54 AM
wraitii added a comment to rP26925: Fix build without precompiled headers. Fixes Phab:rP26915.

Thanks Stan

Jun 9 2022, 8:44 AM

Jun 4 2022

wraitii added a comment to rP26915: Fix text alignment handling of spaces around wrapping..

Probably won't have time to fix it until Monday FYI

Jun 4 2022, 10:11 AM

Jun 3 2022

wraitii added inline comments to D4681: Fix shadow artifacts without shadow filtering in some A25 biomes/maps.
Jun 3 2022, 12:01 PM
wraitii added a comment to D4681: Fix shadow artifacts without shadow filtering in some A25 biomes/maps.

It doesn't fix the ticket, so the ticket must not be closed. But the fix might be committed as soon as accepted until we have a proper solution.

Jun 3 2022, 10:29 AM
wraitii requested review of D4681: Fix shadow artifacts without shadow filtering in some A25 biomes/maps.
Jun 3 2022, 9:40 AM

Jun 2 2022

wraitii requested review of D4678: Fix gamesetup breakage when matchsettings.json contains incorrect victory conditions..
Jun 2 2022, 5:52 PM
wraitii committed rP26916: Minor cleanup in Future and TaskManager.
Minor cleanup in Future and TaskManager
Jun 2 2022, 3:00 PM
wraitii closed D4675: [TaskManager] Minor cleanup in Future + TaskManager.
Jun 2 2022, 2:59 PM
wraitii committed rP26915: Fix text alignment handling of spaces around wrapping..
Fix text alignment handling of spaces around wrapping.
Jun 2 2022, 2:58 PM
wraitii closed D4662: Fix text alignment handling of spaces around wrapping.
Jun 2 2022, 2:58 PM
wraitii added a comment to D4676: [WIP] [Gameplay] Change of the capture paradigm.

I've written about this fairly extensively, and I think the main problem with capturing is that it's boring as hell. Your units don't even fight. I actually think the only legitimate use is sneak-capture. We need a complete revamp of the 'capture' logic to represent breaking-in, defender vs attacker losses, and control of the building as a non-abstract concept IMO for it to work.

Jun 2 2022, 9:32 AM

Jun 1 2022

wraitii updated the diff for D4675: [TaskManager] Minor cleanup in Future + TaskManager.

default in the cpp

Jun 1 2022, 6:16 PM
wraitii added a comment to D4675: [TaskManager] Minor cleanup in Future + TaskManager.

The = defaultwas ok but not in the header file.

Jun 1 2022, 6:14 PM
wraitii updated the diff for D4662: Fix text alignment handling of spaces around wrapping.

Add a specific test for multi-space words. It is indeed not collapsed.
I've de-activated the 'ignore space' logic in those cases, kind of arbitrarily. It seemed more coherent.

Jun 1 2022, 6:12 PM
wraitii committed rP26914: Don't reset wonder victory timer on ally defeat..
Don't reset wonder victory timer on ally defeat.
Jun 1 2022, 5:47 PM
wraitii closed D4661: Don't reset wonder victory timer on ally defeat..
Jun 1 2022, 5:47 PM
wraitii updated the diff for D4675: [TaskManager] Minor cleanup in Future + TaskManager.

Remove the TaskManager destructor change, merging once green.

Jun 1 2022, 5:42 PM
wraitii added inline comments to D4675: [TaskManager] Minor cleanup in Future + TaskManager.
Jun 1 2022, 5:40 PM
wraitii added a comment to D4673: [NetClient] Clean up g_xmppClient checking.

Looking at the details, the ip and port values inferred in the three conditional blocks are not used in the actual connection attempt. But rather those two values are only used to establish a Stun tunnel.
For that reason, I'm not convinced that QueryConnectionDetails() would be semantically accurate for the name. Instead, something like SetupStun() would more accurately reflect the intent.

You're right, I forgot how this bit worked.

Jun 1 2022, 9:20 AM
wraitii added a comment to D3877: ThreadPool extension -> Timer for recurrent task & adapt netClient..

Hey @wraitii are you planning on cleaning up and landing these changes soon? Asking since I'd like to pull in changes with the AddRecurrentTask API and can either wait for this to land, or put up a diff with an updated version of TimerThread :)

Jun 1 2022, 9:00 AM

May 31 2022

wraitii added a comment to D4672: Make the 'reset wonder timer on diplomacy change' thing a setting..

generally I think not _everything_ needs to be a setting, especially when looking at the complex setup that we have already, but since there is no consensus about what the right way is, I guess that might be ok.

May 31 2022, 11:37 AM
wraitii retitled D4661: Don't reset wonder victory timer on ally defeat. from Don't reset wonder victory timer on ally defeat. Do reseat when changing diplomacy. to Don't reset wonder victory timer on ally defeat..
May 31 2022, 10:26 AM
wraitii added a comment to D4664: Non-local condition_variable.

I need to get some more time to actually think about the implications here, but I think this looks generally workable.

May 31 2022, 10:24 AM
wraitii added a comment to D4673: [NetClient] Clean up g_xmppClient checking.

Hey, thanks for the patch. This does simplify the control-flow, particularly the last block that is kind of awkward.
I think however it would be more natural to have a QueryConnectionDetails function that encapsulates the ip/port finding logic, and call that (which can return immediately if g_xmppClient is not there), then simply setup the connection in the flow. That method should probably be a class method of CNetClient.

May 31 2022, 10:16 AM

May 30 2022

wraitii requested review of D4672: Make the 'reset wonder timer on diplomacy change' thing a setting..
May 30 2022, 7:54 PM
wraitii added a comment to D4662: Fix text alignment handling of spaces around wrapping.

What happens if there multiple spaces in the end? It needs at least tests.

May 30 2022, 7:51 PM
wraitii updated the diff for D4661: Don't reset wonder victory timer on ally defeat..

Only remove the 'player defeated' plot twist.

May 30 2022, 6:52 PM
wraitii retitled D4661: Don't reset wonder victory timer on ally defeat. from Don't reset wonder victory timer on ally defeat. Do reseat when changing diplomacy. to Don't reset wonder victory timer on ally defeat..
May 30 2022, 6:52 PM
wraitii updated the diff for D4662: Fix text alignment handling of spaces around wrapping.

*L" " to L' '

May 30 2022, 6:42 PM
wraitii added inline comments to D4662: Fix text alignment handling of spaces around wrapping.
May 30 2022, 6:41 PM
wraitii added a comment to rP26909: Fix Phab:rP26879 by adding the js files to the list of dependencies. They were….

Thanks for fixing this Stan, didn't have time

May 30 2022, 9:58 AM

May 25 2022

wraitii added a comment to D4668: Algorithms in renderer/WaterManager and iota_view.

I realise this is getting somewhat bikesheddy, but a more complete response:

May 25 2022, 6:55 PM
wraitii added inline comments to D4667: Add JS bindings for in game camera attributes.
May 25 2022, 2:25 PM
wraitii added a comment to D4668: Algorithms in renderer/WaterManager and iota_view.

General high level notes:

May 25 2022, 2:21 PM
wraitii added inline comments to D4667: Add JS bindings for in game camera attributes.
May 25 2022, 1:47 PM
wraitii added inline comments to D4667: Add JS bindings for in game camera attributes.
May 25 2022, 1:43 PM
wraitii added a comment to D4667: Add JS bindings for in game camera attributes.

I need this information in game to set a default rotation during the game. The current "reset camera" feature resets the camera rotation to the default values present in the config but these values are not available in game for the user to set.

Unrelated, but this sounds like you could just read the config values?

May 25 2022, 1:35 PM
wraitii added a comment to D4660: Native camera object.

Should I open another differential with only that changes?

May 25 2022, 9:59 AM

May 24 2022

wraitii added a comment to D2938: GL_ARB instancing to reduce draw calls.

Will there be an update on this, since it was committed for a minimap?

May 24 2022, 5:34 PM

May 23 2022

wraitii added a comment to D4663: delete some unused techs/ auras.

It sounds like this is just reporting those warnings, yeah, so I think you can go ahead

May 23 2022, 3:28 PM

May 22 2022

wraitii requested review of D4662: Fix text alignment handling of spaces around wrapping.
May 22 2022, 1:29 PM
wraitii abandoned D4652: Introduce some tests for CGUIText.

I ran into an actual bug while updating the tests following rP26889, gonna add tests in the fix for that instead.

May 22 2022, 12:45 PM
wraitii added a comment to D4661: Don't reset wonder victory timer on ally defeat..

hm actually, what about a diplomacy with no last man standing?
Imagine you're playing with a large wonder holding time and you decide to add a new ally after building a wonder. Doesn't it seem unfair that you get punished for doing so?

Mh, yes. The scenario I had in mind is the reverse: you are allied to some guy, then you remove that alliance at the last second, and you instawin because the timer isn't reset.

May 22 2022, 11:32 AM
wraitii requested review of D4661: Don't reset wonder victory timer on ally defeat..
May 22 2022, 9:32 AM
wraitii updated the diff for D4652: Introduce some tests for CGUIText.

The tests now show an asymmetry between the left & right align, which I don't think was there before. Need to investigate.

May 22 2022, 8:40 AM
wraitii added a comment to rP21441: Create winning teams for relic and wonder victory instead of letting all allies….

Has a topic or a ticket for this been made? For I could not find it.

May 22 2022, 8:20 AM

May 21 2022

wraitii added a comment to D4660: Native camera object.

There is some related code in D3507.

May 21 2022, 7:04 PM

May 19 2022

wraitii added a comment to D4653: [extreme POC] Compile AssemblyScript to WASM within Spidermonkey & run the webAssembly module.
In D4653#198209, @Stan wrote:

How about the projectile code ?

May 19 2022, 1:52 PM
wraitii added a comment to D4653: [extreme POC] Compile AssemblyScript to WASM within Spidermonkey & run the webAssembly module.
In D4653#198191, @Stan wrote:

That still sounds like something that should be tested. I wonder if the speed loss going through JS interfaces would not be mitigated by having a very fast component.

Yes, that's a bit of a question.

May 19 2022, 11:24 AM
wraitii added a comment to D4656: make ship and siege immune to poison.

(This is exactly why I push for D3886)

May 19 2022, 9:18 AM
wraitii added a comment to D4653: [extreme POC] Compile AssemblyScript to WASM within Spidermonkey & run the webAssembly module.
In D4653#198028, @Stan wrote:

So it's not worthwile at all?

May 19 2022, 9:17 AM

May 18 2022

wraitii added a comment to D4653: [extreme POC] Compile AssemblyScript to WASM within Spidermonkey & run the webAssembly module.

Recap of a talk with Mozilla SM devs today on their Matrix chat:

  • JS-WASM & JS-C++ interop can ultimately be expected to have about the same 'cost'. A dev said that the large cost was that IonCompiled code needed to dump registers in a GC-aware manner, in case the C++/Wasm call triggered a GC.
  • C++ <-> WASM interop is currently not implemented, and would have to go through JS, which I think makes the whole idea too inefficient right now. Though implementing c++ <-> wasm direct interop might be relatively easy to implement.
  • Given that we're gonna need the above in any case for the engine, this sounds like a somewhat complex path to optimisations.
May 18 2022, 12:54 PM
Stan awarded D4653: [extreme POC] Compile AssemblyScript to WASM within Spidermonkey & run the webAssembly module a Burninate token.
May 18 2022, 9:20 AM

May 17 2022

wraitii published D4653: [extreme POC] Compile AssemblyScript to WASM within Spidermonkey & run the webAssembly module for review.
May 17 2022, 10:15 PM
wraitii awarded rP26889: Fix an infinite loop when trying to word-wrap a The World Burns token.
May 17 2022, 2:44 PM
wraitii published D4652: Introduce some tests for CGUIText for review.
May 17 2022, 10:30 AM
wraitii added inline comments to D4650: Adds instancing support to backend and enables it for minimap.
May 17 2022, 9:28 AM
wraitii added inline comments to D4650: Adds instancing support to backend and enables it for minimap.
May 17 2022, 9:21 AM
wraitii added inline comments to D4650: Adds instancing support to backend and enables it for minimap.
May 17 2022, 9:15 AM

May 16 2022

wraitii added inline comments to D4650: Adds instancing support to backend and enables it for minimap.
May 16 2022, 11:07 PM
wraitii added a comment to D4530: Fix an infinite loop when trying to word-wrap.

God this code is a mess.

You're talking like other code is significantly better x)

May 16 2022, 10:55 PM
wraitii accepted D4530: Fix an infinite loop when trying to word-wrap.

God this code is a mess.

May 16 2022, 7:16 PM

May 15 2022

wraitii added inline comments to rP26881: Allo native builds on Mac OS M1 / Apple Silicon.
May 15 2022, 11:29 PM
wraitii committed rP26882: Fix SM compilation on M1, fix cross-compilation..
Fix SM compilation on M1, fix cross-compilation.
May 15 2022, 11:23 PM
wraitii closed D4647: Fix SM compilation on M1.
May 15 2022, 11:23 PM
wraitii updated the diff for D4647: Fix SM compilation on M1.

This one should work

May 15 2022, 10:54 PM
wraitii updated the diff for D4647: Fix SM compilation on M1.

Still learning lua

May 15 2022, 10:53 PM
wraitii updated the diff for D4647: Fix SM compilation on M1.

More debug

May 15 2022, 10:50 PM