Page MenuHomeWildfire Games

wraitii (Lancelot)
Animal

Projects

User Details

User Since
Dec 21 2016, 1:38 PM (102 w, 5 d)

Recent Activity

Jul 29 2018

wraitii added inline comments to D1590: 0 A.D. Empires Ascendant Multiplayer Lobby Privacy Policy.
Jul 29 2018, 6:02 PM

Jun 21 2018

wraitii added a comment to D438: D13 prereq 1 : change Run Speed into a Run multiplier.
In D438#63576, @bb wrote:

For some reason (couldn't quickly find why) a formation moves extremely slow right after it is created, when reforming (as in setting another shape) the problem is solved.

Jun 21 2018, 12:00 PM

Jun 4 2018

wraitii added a comment to D1559: Disable AIInterface earlier.

It's used to pass data to the AI, so no AIs -> useless. Order shouldn't matter here unless there's also an OOS bug in the AI Interface.

Jun 4 2018, 6:30 PM
wraitii accepted D1559: Disable AIInterface earlier.

Looks good, clean and easy optimisation. Should be committed for A23 rerelease imo.

Jun 4 2018, 1:55 PM
wraitii added a comment to D1510: Update to Spidermonkey 45.0.2.

I fully intend to commit this/let itms commit this before the SM60 thing. The upgrade to SM45 is fairly safe, the one to SM60 really isn't and will need much bigger reviews.

Jun 4 2018, 8:12 AM

Jun 3 2018

wraitii accepted D1558: Prevent doubleclicking on StartGame.

If an A23 hot fix, commit as is and raise concerns. If not, don't commit and handle the C++ changes.

Jun 3 2018, 7:49 AM

May 29 2018

wraitii accepted rP21830: Save oos_dump.dat too when saving oos_dump.txt..

Sure.

May 29 2018, 6:11 AM
wraitii added a comment to D1538: Nonvisual replay hashtesting option.

OOS were easier to debug when they were really "bad" :p
Cheers for this!

May 29 2018, 6:09 AM

May 28 2018

wraitii added a comment to D1519: Fix non-visual replay hash mismatch caused by CCmpSound condition in CCmpVisualActor in rP21359.
In D1519#62415, @elexis wrote:
In D1519#62413, @Stan wrote:

m_Unit is basically a part of graphics, so shouldn't ever be used to stuff that affects the simulation and/or may be serialised.

Do I have to change something for this ?

Only if you changed a different place where a serialized value depends on m_Unit

May 28 2018, 1:46 PM
wraitii added a comment to D1519: Fix non-visual replay hash mismatch caused by CCmpSound condition in CCmpVisualActor in rP21359.

m_Unit is basically a part of graphics, so shouldn't ever be used to stuff that affects the simulation and/or may be serialised.

May 28 2018, 7:03 AM

May 26 2018

wraitii added a reviewer for D1520: Automatically cancel unpacking when units are ordered to move: Restricted Owners Package.
May 26 2018, 6:55 AM
wraitii added inline comments to rP21823: Alpha 23 "lobby lag" release fix..
May 26 2018, 6:53 AM

May 24 2018

wraitii added inline comments to rP21359: Fix units not being able to play sounds when walking and running.
May 24 2018, 10:30 AM
wraitii added inline comments to rP21359: Fix units not being able to play sounds when walking and running.
May 24 2018, 10:12 AM
wraitii added inline comments to rP21359: Fix units not being able to play sounds when walking and running.
May 24 2018, 9:42 AM

May 23 2018

wraitii accepted D1518: Fix mod version comparison lag in lobby.js, gamesetup.js, load.js and any other place.

I tested' yesterday's version and it worked and was very similar.

May 23 2018, 2:37 PM
wraitii added a comment to D1518: Fix mod version comparison lag in lobby.js, gamesetup.js, load.js and any other place.

I don't know if there is a bug in the VFS. If there is, it should be fixed.

Well zip files are supposed to be faster than non-zip-files, so this sounds like a bug to me. I'll make a patch as said before

But no matter how good the code is, it has to open multiple files, possibly large fragmented zip files, reading mod.json from it, parsing the JSON data, possibly dozens of mods, so I doubt that this can't be optimized to microseconds without caching it.

Agreed, I was just messing around.

May 23 2018, 2:07 PM
wraitii added inline comments to rP21239: Check for and save mod version for savegames and replays.
May 23 2018, 12:43 PM
wraitii added a comment to D1518: Fix mod version comparison lag in lobby.js, gamesetup.js, load.js and any other place.

Agreed that after much debate this is the best solution.
I'll compile out of doing-the-right-thingness for accepting but this is OK by me.

May 23 2018, 12:42 PM
wraitii added inline comments to D1512: Fix Lobby lag when updating the game list.
May 23 2018, 11:56 AM

May 22 2018

wraitii updated the diff for D1510: Update to Spidermonkey 45.0.2.

This should fix the build and the JSPropertyDescriptor thing, which is fixed upstream https://github.com/mozilla/gecko-dev/blob/master/js/src/jsapi.h#L2049

May 22 2018, 8:06 PM
wraitii added a comment to P121 Simple launched mod version caching in js.

It's more of a "it's good practice to not call constant things in function bodies", but I agree that it ever so slightly lowers readability here.

May 22 2018, 7:33 PM
wraitii requested changes to D1512: Fix Lobby lag when updating the game list.

IMO OK once requested changes are done.

May 22 2018, 7:07 PM
wraitii added a comment to P121 Simple launched mod version caching in js.

I think the lobby change is still OK, but I'm fine with not adding it for slight readability reasons.

May 22 2018, 6:54 PM
wraitii added a comment to D1512: Fix Lobby lag when updating the game list.

The mountMods prerequisite is a little awkward indeed.

May 22 2018, 5:20 PM
wraitii added a comment to D1512: Fix Lobby lag when updating the game list.

As a c++ caching method, this is probably the best, but obviously the question is "when to cache the data". I'm okay with once in Init like you've done, otherwise it should probably go in GetEngineInfo with an if of some kind.

May 22 2018, 4:53 PM
wraitii added a comment to D1512: Fix Lobby lag when updating the game list.

Let's do it your way then, I'm not dying on this hill. Feel free to commandeer with your patch, otherwise I'll take it as a basis and carry on myself.

May 22 2018, 3:15 PM
wraitii added a comment to D1512: Fix Lobby lag when updating the game list.
In D1512#61930, @elexis wrote:
In D1512#61928, @Imarok wrote:

Could we just do a small and quick fix (common js only cache) for A23 and think about the approptiate fix for A24 after the rerelease?

Committing something without knowing what investigating the situation prior to the commit is not happening with my agreement and the matter is not hard to understand.

May 22 2018, 1:01 PM
wraitii added a comment to D1512: Fix Lobby lag when updating the game list.

@elexis : I don't really understand why you treat JSON as only the "way to natively store JS value", I see it more as a random document storing method, like XML. But whatever. Maybe this isn't the best approach but it seemed clean enough.
I believe initialising spider monkey could be done independently from VFS which is a very 0 A.D. thing so that sounds safe, but we'll have to see.

May 22 2018, 12:56 PM
wraitii added inline comments to D1512: Fix Lobby lag when updating the game list.
May 22 2018, 12:27 PM
wraitii added inline comments to D1512: Fix Lobby lag when updating the game list.
May 22 2018, 12:10 PM
wraitii added inline comments to D1512: Fix Lobby lag when updating the game list.
May 22 2018, 10:15 AM
wraitii planned changes to D1512: Fix Lobby lag when updating the game list.
May 22 2018, 9:19 AM
wraitii added inline comments to D1512: Fix Lobby lag when updating the game list.
May 22 2018, 9:19 AM
wraitii updated the diff for D1512: Fix Lobby lag when updating the game list.

VFS changes are un-necessary with the C++ caching. I still think they are correct, but probably for another diff.

May 22 2018, 7:56 AM
wraitii updated the diff for D1512: Fix Lobby lag when updating the game list.

Alternative patch with C++ caching.

May 22 2018, 7:40 AM

May 21 2018

wraitii updated the diff for D1512: Fix Lobby lag when updating the game list.

So I misunderstood that I couldn't reproduce this, because I could.

May 21 2018, 10:26 PM
wraitii updated the diff for D1512: Fix Lobby lag when updating the game list.

So the real cause of this freeze is definitely that we're fetching the data for every game instead. Then this is also perhaps slow on Windows for some odd pathological reason in the bundle that we should investigate (possibly windows is dumber about reading big zips than we thought).

May 21 2018, 7:29 PM
wraitii committed rP21822: Fix hosting games in the lobby..
Fix hosting games in the lobby.
May 21 2018, 7:20 PM
wraitii closed D1498: Fix hosting games in the lobby on OSX.
May 21 2018, 7:19 PM
wraitii commandeered D1512: Fix Lobby lag when updating the game list.
May 21 2018, 7:15 PM
wraitii added a comment to D1512: Fix Lobby lag when updating the game list.

FYI My plan is to commit if it doesn't appear to brea kantyhing and immediately raise a concern.

May 21 2018, 3:17 PM
wraitii updated subscribers of D1510: Update to Spidermonkey 45.0.2.

This is slightly ahead of @Itms' branch, and was created entirely independently, and we have mostly the same fixes (I just dropped scope chains, personally, since we used the global object).

May 21 2018, 9:05 AM
wraitii added a comment to D1395: Handle UTF-8 multibyte characters in Atlas when loading from JSON.

Haven't read older code but this now looks quite sane. The rule with UTF-8 (which we sadly haven't always followed) is to always use it and never handle it in any particular way unless you're rendering text.
We should probably validate that keyboard input works correctly.

May 21 2018, 8:12 AM
wraitii added a comment to D1510: Update to Spidermonkey 45.0.2.

Thanks for trying this out, really helpful.
I haven't run into this linker issue, maybe because I haven't tried compiling the debug spidermonkey? Anyhow it looks like it'd be fairly easy to write a tailor-made patch.

May 21 2018, 8:00 AM
wraitii added a reviewer for D844: Add a `GetTextSize()` function to the GUI.: wraitii.

Code looks good now, I just have a bunch of remarks. I'll try and test this soon enough and actually accept it.

May 21 2018, 7:58 AM

May 20 2018

wraitii added a comment to D1498: Fix hosting games in the lobby on OSX.

Works correctly for me.

May 20 2018, 8:32 PM
wraitii added inline comments to D1510: Update to Spidermonkey 45.0.2.
May 20 2018, 4:06 PM
wraitii created D1510: Update to Spidermonkey 45.0.2.
May 20 2018, 3:55 PM

May 19 2018

wraitii added inline comments to D1495: Alt + Tab during loading in fullscreen mode crash.
May 19 2018, 10:32 PM
wraitii added inline comments to D1506: Update code with range-based for loops.
May 19 2018, 10:31 PM
wraitii created D1508: Remove legacy trigger handling in map reader.
May 19 2018, 4:34 PM
wraitii created D1507: Explicit fall through.
May 19 2018, 4:32 PM
wraitii created D1506: Update code with range-based for loops.
May 19 2018, 4:30 PM
wraitii created D1504: Small commands.js cleanup.
May 19 2018, 3:43 PM
wraitii created D1503: Add TODOs.
May 19 2018, 3:34 PM
wraitii created D1502: Remove some unused functions.
May 19 2018, 3:24 PM
wraitii updated the diff for D1498: Fix hosting games in the lobby on OSX.

Transparent image.

May 19 2018, 2:24 PM
wraitii created D1499: Do not actually Kill in debug_break() in non-debug binaries.
May 19 2018, 7:25 AM
wraitii created D1498: Fix hosting games in the lobby on OSX.
May 19 2018, 6:56 AM

May 17 2018

wraitii added inline comments to D1495: Alt + Tab during loading in fullscreen mode crash.
May 17 2018, 7:28 AM

May 16 2018

wraitii updated the diff for D13: UnitMotion rewrite.

Low hanging fruits: const-correct, remove unused functions, reorder things.

May 16 2018, 9:02 PM
wraitii added inline comments to D1486: Graphics Improvements.
May 16 2018, 2:25 PM
wraitii added inline comments to D1486: Graphics Improvements.
May 16 2018, 12:34 PM
wraitii added inline comments to D13: UnitMotion rewrite.
May 16 2018, 7:53 AM
wraitii added a comment to D53: D13 prerequisite 8: Upgrade the hierarchical pathfinder.

This is RC review-wise. I've tested it a number of times and it returns very similar paths to SVN, as said above it's faster, and I have a number of other revisions that conflict with this so the sooner the better.

May 16 2018, 7:47 AM
wraitii accepted D1327: Remove SelectAnimation from MoveStarted and MoveCompleted.

These are irrelevant since visualActor overrides this. Likewise in D13. I think I'm removing them there already, so depending I might commit this or close it.

May 16 2018, 7:28 AM
wraitii added a comment to D1241: Change Fogging and AIProxy checks to INVALID_PLAYER.

Go ahead and commit this in A24, just remove the garrisonHolder changes.

May 16 2018, 7:26 AM
wraitii added a comment to D1074: Walk to target rather than walk to point.

Thanks for the patch, will commit this after A23 is released. Sorry for the delay.

May 16 2018, 7:24 AM
wraitii added a comment to D366: Lobby playername gamelist filter #4201.

@vladislavbelov Could you commit this after A23 is released?

May 16 2018, 7:21 AM
wraitii added a comment to D1490: Unit Pushing.

At the moment I'll focus on sane behaviour regardless of ownership, it's fairly easy to add it in later.

May 16 2018, 7:15 AM

May 15 2018

wraitii accepted D1270: SoundGroup cleanup..

you've missed a static_cast on L87
and some more redundant parens on L111 on the right

May 15 2018, 9:29 PM
wraitii requested changes to D1270: SoundGroup cleanup..

Other remarks.

May 15 2018, 8:57 PM
wraitii updated the diff for D359: Water shader improvements: fix some of the redness, fix edge-of-map showing up, improve entity-under-water, slight improvement to reflection edges..

Some more comparable screenshots. The fixed version is the one that doesn't look terrible.

May 15 2018, 8:38 PM
wraitii updated the diff for D78: Speed up the water manager recomputations.

With the changes this time -_-

May 15 2018, 8:36 PM
wraitii updated the diff for D78: Speed up the water manager recomputations.

Yup, it appears I'd forgotten to remove some piece of code or something at some point in the diff updates. Fixed.

May 15 2018, 8:34 PM
wraitii updated the test plan for D1494: Improve the "% of better frames" in the Profiler2 report when comparing 2 profiles.
May 15 2018, 8:00 PM
wraitii planned changes to D1494: Improve the "% of better frames" in the Profiler2 report when comparing 2 profiles.

Inconsistent zeroes.

May 15 2018, 7:48 PM
wraitii created D1494: Improve the "% of better frames" in the Profiler2 report when comparing 2 profiles.
May 15 2018, 7:45 PM
wraitii added a comment to D1490: Unit Pushing.

At the moment it's all units. I've thought about this and I'm not sure how to handle enemy units yet.

May 15 2018, 5:37 PM
wraitii added a comment to D13: UnitMotion rewrite.

Some comments on why svn unitMotion is a pile of hacks that needs to be cleansed with the holy waters of D13.

May 15 2018, 1:53 PM
wraitii abandoned D444: D13 post-quisite 10: group-walk order.

I'm going to support formations in D13 so drop this for now.

May 15 2018, 8:26 AM
wraitii abandoned D439: D13 prerequisite 3: remove existing formation code.
May 15 2018, 8:24 AM

May 14 2018

wraitii added a comment to D1490: Unit Pushing.

Some footage.
This is SVN: https://www.youtube.com/watch?v=QQC2wrIUHLQ
You can see that the units move around the phalanx formation, the movement around the tree is wonky, and there is a lot of collisions when they return resources.
This is with D13 and D1490: https://www.youtube.com/watch?v=aRfP7lA1m7Y
You can see that the unit can move through the phalanx in a way that looks (imo) somewhat nice, you can see that they clump around the tree much easier, and the ressource shuttling is also easier.
However, you can also see some bugs. Pushing isn't as natural as it could be, and units are oriented all wrong, and there's some jerking, and also formations aren't 100% similar to SVN yet.

May 14 2018, 10:01 PM
wraitii added a comment to D53: D13 prerequisite 8: Upgrade the hierarchical pathfinder.

And here's some approximate profiling of HierarchicalPathfinder::Update. We might expect that to be slower because of global regions, but it's actually also faster, 1.5 to 2 times faster (the relationship isn't entirely linear).

May 14 2018, 8:52 PM
wraitii added a comment to D53: D13 prerequisite 8: Upgrade the hierarchical pathfinder.

Some new profiling of MakeGoalReachable, on the following replay (which is just moving a pack of units around on Seleucid Sandbox).
Behaviour was virtually identical between svn and D53's result, not exactly the same as expected but sensibly the same result.

May 14 2018, 8:41 PM
wraitii requested changes to D1015: Forced attack on moving targets bug.

Still think time is better spent reviewing D13. In D13 there's a TODO for LOS, since after more thinking I do think LOS should be handled in unitMotion. UnitMotion will now be able to warn unitAI that the move will fail, and furthermore UnitAI was updated to do range checks in "Timer" instead of relying on Move Completed (which is far more correct).

May 14 2018, 4:44 PM
wraitii added inline comments to D13: UnitMotion rewrite.
May 14 2018, 4:43 PM
wraitii added a reviewer for D953: Add basic Clang 6 support: Restricted Owners Package.
May 14 2018, 4:40 PM
wraitii added a reviewer for D956: Long path improvements: Restricted Owners Package.

(I've been working on this, but it's challenging, of course. I wanted to say generally that I think we'll need something like a collision manager. Currently we move one unit at a time, but this leads to unnecessary traffic jams when a group of units are moving in the same direction, for example. So I think it would be better to break movement into two parts, first moving units to their ideal position, flagging potential collisions as we go, and second going through all the potential collisions to see if the units actually collided, and if so try to resolve the collision by pushing or requesting another path or something.)

May 14 2018, 4:39 PM
wraitii added a comment to D1440: Warn if the Obstruction size exceeds the Wallpiece length.

I have no idea what these perl scripts are doing and there are no comments, so I'd rather we had a new script, but we don't have a lot of conventions on that.

May 14 2018, 4:25 PM
wraitii added a comment to D1418: Enable garrisoning on gates.

Read this better, there's two things here. On the "remove obstruction" part, see above.

May 14 2018, 1:58 PM
wraitii added inline comments to D1418: Enable garrisoning on gates.
May 14 2018, 1:52 PM
wraitii requested changes to D1451: Increase contrast of water reflections.
May 14 2018, 1:48 PM
wraitii added a comment to D1472: Grouped civ bonuses into a single folder.

I like this, how do others feel?

May 14 2018, 1:45 PM
wraitii requested changes to D1332: Support swim animations and use with crocodile.

Rename "floating" to "CanFloat" wherever relevant and this is good to go imo, thanks for the patch!

May 14 2018, 1:44 PM
wraitii requested changes to D1418: Enable garrisoning on gates.

Nice bug.

May 14 2018, 1:37 PM
wraitii added a comment to D1401: Fix Skybox .

This fixes the squeezing at the very least.

May 14 2018, 12:09 PM
wraitii added a reviewer for D1331: Improve selection performance by adding a GetBasicEntityState function: Restricted Owners Package.
May 14 2018, 12:08 PM
wraitii added a reviewer for D1323: allow negative resource trickle rate: Restricted Owners Package.
May 14 2018, 12:08 PM