Page MenuHomeWildfire Games

wraitii (Lancelot)
Animal

Projects

User Details

User Since
Dec 21 2016, 1:38 PM (200 w, 4 d)

Recent Activity

Wed, Oct 21

wraitii added a comment to D3032: Treat code between `[]` and `{}` as one blob for translations..

I'm wondering if this can't be fixed by using template literals: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals
(though I don't really understand why you need it, if you could provide an example - haven't figured it out really from the diff before either)

Wed, Oct 21, 10:08 AM
wraitii added a comment to D2934: Enable link-time optimisation (LTO).

Does LTO work correctly for old supported compiler? Maybe it should be disabled by default since it might slow down compilation during development.

Wed, Oct 21, 10:05 AM

Wed, Oct 7

wraitii accepted D3027: Refactors water shader to separate reflection.

Looks correct and probably a good idea to separate the local variable mess that this shader was.

Wed, Oct 7, 9:40 AM

Sun, Oct 4

wraitii added inline comments to D2808: Allow resistance to StatusEffects..
Sun, Oct 4, 9:42 AM

Mon, Sep 28

wraitii added a comment to D2808: Allow resistance to StatusEffects..

I really fail to see how you want to find a typo in a name automically.

There's automatically and then there's "easily". We could detect close-names (such as capitalized/uncapitalized versions of the same string) quite easily with a script, and likewise typos aren't too complicated. Simply outputting all "known" status effect node-names would make it obvious if there are duplicates, and that's not extremely difficult to do.

Mon, Sep 28, 1:29 PM
wraitii added a comment to D2808: Allow resistance to StatusEffects..

That is also the case for damage types, right?

Mon, Sep 28, 9:05 AM

Sep 18 2020

wraitii added a comment to D2922: Fix a compartment mismatch in XmppClient / Possibly fix semi-random lobby / in game JS crash.

Just tested -> couldn't reproduce the crash via launching a map or triggering a shrinking GC on the lobby page.

Sep 18 2020, 10:55 AM

Sep 15 2020

wraitii accepted D2983: Reduces memory usage for fancy water.

Conceptually seems OK and no issues on my end.

Sep 15 2020, 5:50 PM

Sep 14 2020

wraitii added a comment to D2995: Properly internationalize attack names/Generlize to arbitrary names in the GUI.

I think the approach of having a template-configurable i18n is good, I'm wondering if it shouldn't be an attribute of the attack:

<Attack>
    <Ranged name="Boiling Oil">
    </Ranged
</Attack>

This would avoid having to think of a name for the tag.

Sep 14 2020, 10:45 AM

Sep 13 2020

wraitii added a comment to D2996: [gameplay] Move bireme to village phase and balance..

This seems sensible to me.
The fact that Biremes were enabled at town phase dates from rP12240 which introduced tech requirements for warships. It seems to me that biremes have no particularly strong reason to not be in village_phase, given the commit.

Sep 13 2020, 1:12 PM

Sep 11 2020

wraitii updated the summary of D2913: Stop dodging arrows by patrol: Wait a few seconds between patrol waypoints..
Sep 11 2020, 9:31 AM
wraitii updated the diff for D2913: Stop dodging arrows by patrol: Wait a few seconds between patrol waypoints..

Good thing I added a conditional there..

Sep 11 2020, 9:30 AM
wraitii added inline comments to D3005: Range safe buildingAI.
Sep 11 2020, 9:26 AM
wraitii awarded rP24034: Cheer after combat when no enemy units are in range a 100 token.
Sep 11 2020, 9:24 AM
wraitii updated the diff for D2913: Stop dodging arrows by patrol: Wait a few seconds between patrol waypoints..

Possibly final cleanup.

Sep 11 2020, 9:23 AM
wraitii added inline comments to D2913: Stop dodging arrows by patrol: Wait a few seconds between patrol waypoints..
Sep 11 2020, 9:19 AM
wraitii added inline comments to D2913: Stop dodging arrows by patrol: Wait a few seconds between patrol waypoints..
Sep 11 2020, 9:16 AM

Sep 10 2020

wraitii added a comment to D2362: Allow for building-specific build/repair animations and use seeding animation for fields.

My comment above remains valid, my status is "waiting on @Imarok to update the diff" ;)

Sep 10 2020, 11:02 AM
wraitii added inline comments to D2913: Stop dodging arrows by patrol: Wait a few seconds between patrol waypoints..
Sep 10 2020, 11:01 AM
wraitii updated the diff for D2913: Stop dodging arrows by patrol: Wait a few seconds between patrol waypoints..

Make formations walk again.

Sep 10 2020, 11:00 AM
wraitii added a comment to rP24032: Reuse "APPROACHING"-state in formation combat..

(The older way was made irrelevant by rP22313 which moved the "Move" call to states instead of orders.)

Sep 10 2020, 10:45 AM
wraitii awarded rP24032: Reuse "APPROACHING"-state in formation combat. a Love token.
Sep 10 2020, 10:43 AM
wraitii requested changes to D2368: Move movement logic from UnitAI's "Garrisoned"-state to approaching..

I think your previous diff had things in the wrong spot, and this one makes it obvious which.
Given the scope of things, I think you can get away with just "approaching" and "garrisoned", but you need to add some more code to "approaching" imo to not make it reliant on unit-motion.

Sep 10 2020, 10:39 AM
wraitii resigned from D2755: Don't store the gatherers per player..
Sep 10 2020, 10:19 AM
wraitii added a comment to D2752: Do not thread the game in Atlas.

Thanks for the comments @Itms , in that case I'll carry on investigating the FPS issue and move towards committing this :)

Sep 10 2020, 8:42 AM
wraitii added a comment to D2967: Cache the model-animation maximum bounds..

@vladislavbelov Do you think the approach is acceptable? Indeed it works, but only by "coincidence" that CSkeletonAnimDef are long-lived. However it does bring a rather tangible improvement.

Sep 10 2020, 8:42 AM
wraitii updated the diff for D2961: Fix issues in RangeManager following rP23769.

Updated, thanks for the look and thanks for reminding me I had uploaded this :p

Sep 10 2020, 8:38 AM

Sep 9 2020

wraitii added a comment to rP24016: Debuff outpost and remove un-necessary technologies..

This is 100% nonsense, in every competitive MP game I play, especially the vision tech is researched ALWAYS.

Sep 9 2020, 10:07 PM

Sep 8 2020

wraitii committed rP24029: Fix formation walking following "improved ship pickup"/rP23925.
Fix formation walking following "improved ship pickup"/rP23925
Sep 8 2020, 3:49 PM
wraitii closed D3006: Fix formation walking following "improved ship pickup" rP23925.
Sep 8 2020, 3:49 PM
wraitii requested review of D3006: Fix formation walking following "improved ship pickup" rP23925.
Sep 8 2020, 10:06 AM
wraitii added a comment to D2875: [gui] shrink selection panel icons.

Thanks for taking care of this @Angen :)

Sep 8 2020, 8:40 AM

Sep 7 2020

wraitii added a comment to D2998: Do not hardcode attacktypes in the engine/Atlas.

For what it's worth, javascript uses UTF-16 strings, so it's probably faster to use CStrW when interacting with JS code (fewer conversions). That being said, performance is not the utmost concern here, so using utf-8 strings is probably neater.

Sep 7 2020, 9:55 AM
wraitii added a comment to rP23925: Improve ship pickup..

Hm, these reports are odd indeed, I'll investigate.

Sep 7 2020, 9:51 AM

Sep 4 2020

wraitii added inline comments to D2967: Cache the model-animation maximum bounds..
Sep 4 2020, 11:02 AM

Sep 3 2020

wraitii added a comment to D2986: [gameplay] detower outpost.

This seems rather trivially a good change to me.

Sep 3 2020, 2:55 PM

Sep 2 2020

wraitii added a comment to rP24013: Allow training Axeman Cavalry at barracks..

Allow training Axeman Cavalry at barracks.

The commit message and title is incorrect and misleading. What it actually does is remove cavalry axemen from Persian barracks.

Sep 2 2020, 10:14 AM
wraitii committed rP24016: Debuff outpost and remove un-necessary technologies..
Debuff outpost and remove un-necessary technologies.
Sep 2 2020, 9:26 AM
wraitii closed D2933: [gameplay] tweak outpost and remove techs.
Sep 2 2020, 9:26 AM
wraitii committed rP24015: Balance economy techs to make City Phase less of a snowball..
Balance economy techs to make City Phase less of a snowball.
Sep 2 2020, 9:20 AM
wraitii closed D2916: [gameplay] balance economy techs.
Sep 2 2020, 9:20 AM
wraitii accepted D2916: [gameplay] balance economy techs.

Seems a solid improvement over the status quo regardless. Thanks for the patch!

Sep 2 2020, 9:16 AM
wraitii committed rP24014: Slightly buff melee units by making ranged units promote slower..
Slightly buff melee units by making ranged units promote slower.
Sep 2 2020, 9:12 AM
wraitii closed D2899: [gameplay] improve melee units.
Sep 2 2020, 9:12 AM
wraitii committed rP24013: Allow training Axeman Cavalry at barracks..
Allow training Axeman Cavalry at barracks.
Sep 2 2020, 9:03 AM
wraitii closed D2954: [gameplay] Fix persian axeman cavalry.
Sep 2 2020, 9:03 AM
wraitii accepted D2954: [gameplay] Fix persian axeman cavalry.
Sep 2 2020, 9:00 AM
wraitii committed rP24012: Move cavalry movement tech to village phase and make it cheaper..
Move cavalry movement tech to village phase and make it cheaper.
Sep 2 2020, 8:59 AM
wraitii closed D2966: [gameplay] Cavalry movement tech.
Sep 2 2020, 8:59 AM
wraitii accepted D2966: [gameplay] Cavalry movement tech.
Sep 2 2020, 8:53 AM
wraitii accepted D2698: Do not chase units in FOW/SOD..
Sep 2 2020, 8:47 AM

Sep 1 2020

wraitii updated subscribers of D2948: Move PopulationBonus to new component Population.

Why? Population is clearly a cost.

It is a cost in a semantic sense, but the "Cost" component represents a "resource transaction", which doesn't fit population very well right now. Separating them might actually make sense (and it might not -> haven't investigated enough, but I can see it).

Sep 1 2020, 10:01 AM

Aug 31 2020

wraitii committed rP24010: Improve splash damage falloff calculation to account for obstruction size..
Improve splash damage falloff calculation to account for obstruction size.
Aug 31 2020, 5:01 PM
wraitii closed D2963: Improve splash damage falloff calculation to account somewhat for obstruction size.
Aug 31 2020, 5:01 PM
wraitii added inline comments to D2698: Do not chase units in FOW/SOD..
Aug 31 2020, 3:11 PM
wraitii updated the diff for D2913: Stop dodging arrows by patrol: Wait a few seconds between patrol waypoints..

I'll create the ticket before merging this then.

Aug 31 2020, 11:45 AM
wraitii added inline comments to D2913: Stop dodging arrows by patrol: Wait a few seconds between patrol waypoints..
Aug 31 2020, 11:29 AM
wraitii updated the diff for D2963: Improve splash damage falloff calculation to account somewhat for obstruction size.

@bb's comments + Rebased.

Aug 31 2020, 11:19 AM
wraitii committed rP24009: Fix AI using Maurya elephant archers as hunters following rP23916.
Fix AI using Maurya elephant archers as hunters following rP23916
Aug 31 2020, 11:09 AM
wraitii closed D2962: Fix AI using Maurya elephant archers as hunters following rP23916.
Aug 31 2020, 11:08 AM
wraitii added a comment to D2975: damage resistance from nonNegativeDecimal to integer.

For what it's worth, there was debate already on D268...

Aug 31 2020, 9:40 AM

Aug 28 2020

wraitii added a comment to D2978: [WIP] - Update tooltips after rP24001..

Furthermore, quite a few technologies have "armor" in their name; should those be renamed too?

Aug 28 2020, 11:03 AM

Aug 27 2020

wraitii added a comment to D2229: Elaborate Armour..

I wanted to do that but noticed it needed a rebase and I wanted to let the bots run over it ^^

Aug 27 2020, 2:13 PM
wraitii added a comment to D2229: Elaborate Armour..

I think you should go ahead and merge this before rebasing introduces bugs.

Aug 27 2020, 11:05 AM
wraitii added a comment to D2972: [gameplay] Increase hack damage of pikemen.

I never really understood why Spearmen dealt so much pierce armour, effectively making them ranged units, damage-wise, which was always rather annoying to balance. I'd actually support moving them more towards Hack, if necessary adding some multipliers.

Aug 27 2020, 10:24 AM
wraitii added inline comments to D2963: Improve splash damage falloff calculation to account somewhat for obstruction size.
Aug 27 2020, 9:38 AM
wraitii added a comment to D2973: Add safeguards for all queryOwnerInterface calls.

Seems good overall

Aug 27 2020, 9:35 AM
wraitii added inline comments to D1960: Move the controllability of an entity to cmpIdentity..
Aug 27 2020, 9:32 AM
wraitii added a comment to D2913: Stop dodging arrows by patrol: Wait a few seconds between patrol waypoints..
In D2913#129854, @bb wrote:

Code desperately asking for an animation, needs ticket or so.

Aug 27 2020, 9:30 AM

Aug 25 2020

wraitii added a comment to D2971: blacksmith → forge.

I also approve the name change.

Aug 25 2020, 10:31 AM
wraitii added a comment to D2837: Stop dodging arrows by spamclicking or patrol: Waste time turning.

but still, it takes two or three steps to turn around ;)

I mean yeah, but it doesn't really affect my movement speed, as I can turn while moving. Try it, as you say :)
Turning "in place" does take a little time but that's not really relevant here.

Aug 25 2020, 10:28 AM

Aug 21 2020

wraitii added a comment to D1960: Move the controllability of an entity to cmpIdentity..

I can't find a fault in this version:

  • GUI works for controllable/uncontrollable entities of the player, and of other players
  • Activating the control-all cheat does allow one to control all uncontrollable entities
  • Controllable entities still work, obviously
Aug 21 2020, 9:59 AM
wraitii added a comment to D1958: Turrets and/or sub-units..

It enables the chariot to follow a target such that the subentity can keep attacking it, instead of moving in range and stopping.

Aug 21 2020, 9:49 AM
wraitii added a comment to D2646: Remove special Animal state..

I need to test this.
One remark: I think you can delete the FSM logic for duplicating a state.

Aug 21 2020, 9:34 AM
wraitii added inline comments to D1958: Turrets and/or sub-units..
Aug 21 2020, 9:22 AM

Aug 19 2020

wraitii requested review of D2967: Cache the model-animation maximum bounds..
Aug 19 2020, 6:19 PM

Aug 18 2020

wraitii added a reviewer for D2293: Allow code to register hooks which get called whenever a function value changes, use this to clean rendering options further.: vladislavbelov.
Aug 18 2020, 12:03 PM
wraitii committed rP23970: Check for lastPos existence in Combat-Approaching-MovementUpdate [fix rP22425].
Check for lastPos existence in Combat-Approaching-MovementUpdate [fix rP22425]
Aug 18 2020, 9:46 AM
wraitii closed D2960: Check for lastPos existence in Combat-Approaching-MovementUpdate [fix rP22425].
Aug 18 2020, 9:46 AM
wraitii updated the diff for D2960: Check for lastPos existence in Combat-Approaching-MovementUpdate [fix rP22425].

After a good night's sleep it obviously makes more sense to do this.

Aug 18 2020, 8:47 AM
wraitii updated the diff for D2961: Fix issues in RangeManager following rP23769.

Forgot to actually fix the reset() call.

Aug 18 2020, 8:45 AM
wraitii updated the diff for D2962: Fix AI using Maurya elephant archers as hunters following rP23916.

Remove FastMoving from the elephant since it indeed isn't.

Aug 18 2020, 8:43 AM

Aug 17 2020

wraitii added inline comments to D2962: Fix AI using Maurya elephant archers as hunters following rP23916.
Aug 17 2020, 1:08 PM
wraitii requested review of D2963: Improve splash damage falloff calculation to account somewhat for obstruction size.
Aug 17 2020, 1:04 PM
wraitii updated the diff for D2962: Fix AI using Maurya elephant archers as hunters following rP23916.

Then I really have no choice but to make the minimal diff...

Aug 17 2020, 12:51 PM
wraitii updated the diff for D2962: Fix AI using Maurya elephant archers as hunters following rP23916.

Alternative fix that checks that hunters can actually hunt.

Aug 17 2020, 12:42 PM
wraitii added a comment to D2759: Update range queries to account for entity size.

See D2963 for the splash fix.
I think this should wait for that indeed.

Aug 17 2020, 12:33 PM
wraitii added a comment to D2962: Fix AI using Maurya elephant archers as hunters following rP23916.

If I understand correctly, this means the AI won't be able to train them, since Petra uses the CitizenSoldier class for that (see simulation/ai/petra/attackPlan.js).
The Citizen class is used by auras and technologies to exclude champions and heroes; removing it means elephant archers no longer benefit from those, effectively weakening them, so that means this patch changes gameplay.

Aug 17 2020, 11:49 AM
wraitii added a comment to D2229: Elaborate Armour..

I'm wondering if <Entity> shouldn't be a compulsory tag for simplicity.

I don't think <Entity> should be compulsory. If an entity doesn't have resistance, but can be attacked still. Or one should introduce an Attackable component and use that in range queries and the like. Would make sense. (Then resistance wouldn't be compulsory either.)

Aug 17 2020, 11:27 AM
wraitii added a comment to D2229: Elaborate Armour..

I think you missed something in the rebased, TargetKilled is still in Resistance.

Aug 17 2020, 11:18 AM
wraitii requested review of D2962: Fix AI using Maurya elephant archers as hunters following rP23916.
Aug 17 2020, 11:17 AM
wraitii added inline comments to D2960: Check for lastPos existence in Combat-Approaching-MovementUpdate [fix rP22425].
Aug 17 2020, 11:08 AM
wraitii requested review of D2960: Check for lastPos existence in Combat-Approaching-MovementUpdate [fix rP22425].
Aug 17 2020, 10:52 AM
wraitii updated the diff for D2960: Check for lastPos existence in Combat-Approaching-MovementUpdate [fix rP22425].

Uhm, what happens when there is no lastPos and an entity gets movementUpdate.failure? They're stuck then, right?

Aug 17 2020, 10:37 AM
wraitii requested review of D2961: Fix issues in RangeManager following rP23769.
Aug 17 2020, 10:31 AM
wraitii added a comment to D2960: Check for lastPos existence in Combat-Approaching-MovementUpdate [fix rP22425].

Are there more places in UnitAI that can benefit from a check?

Aug 17 2020, 10:04 AM
wraitii added a comment to D2455: Add clang-format configuration for auto-formatting C++ code.

I don't have a very strong opinion overall, but starting with a more lazy approach seems fine to me.

Aug 17 2020, 10:03 AM
wraitii requested review of D2960: Check for lastPos existence in Combat-Approaching-MovementUpdate [fix rP22425].
Aug 17 2020, 9:55 AM
wraitii updated the summary of D2797: Check references from inside the engine [proof of concept].
Aug 17 2020, 9:53 AM
wraitii updated the Trac tickets for D2797: Check references from inside the engine [proof of concept].
Aug 17 2020, 9:52 AM