Differential D1116 Diff 4595 binaries/data/mods/public/gui/common/l10n.js

Changeset View

Standalone View

binaries/data/mods/public/gui/common/l10n.js

This file was added.

				function durationToString(time)
				{
				return Engine.FormatMillisecondsIntoDateStringGMT(time, time < 1000 * 60 * 60 ?
				// Translation: Format of the time elapsed or remaining, for game durations, ceasefire and wonder-victory countdowns, etc.
				// For a list of symbols that you can use, see:
				// https://sites.google.com/site/icuprojectuserguide/formatparse/datetime?pli=1#TOC-Date-Field-Symbol-Table
				translateWithContext("duration less than one hour", "m:ss") :
				// Translation: Format of the time elapsed or remaining, for game durations, ceasefire and wonder-victory countdowns, etc.
				// For a list of symbols that you can use, see:
				// https://sites.google.com/site/icuprojectuserguide/formatparse/datetime?pli=1#TOC-Date-Field-Symbol-Table
				translateWithContext("duration greater than one hour", "H:mm:ss"));
				elexisUnsubmitted Not Done Inline Actions Since we already have a multi line translation comment in lobby.js we at least woudn't be the first one to add an incomplete one, yay. To be sure one could look in `extractors.py` or look into the wiki pages (Internationalization_and_Localization and iirc more). From a quick look `messages.json` register the `Translation` keyword under `commentTags` and that is parsed by `extractJavascriptFromFile` in `extractors.py`. We see `multilinecomment` there. The only other reference to that keyword is in `jslexer.py`: ('multilinecomment', re.compile(r'/\.?\/(?us)')), So perhaps it is wrong in `lobby.js` after all. Experimental evidence comes in from the `po` files that this script produces (and that are getting uploaded to transifex automatically). -> it's broken #. Translation: Time prefix as shown in the multiplayer lobby (when you enable it in the options page). #: gui/lobby/lobby.js:1409 #, javascript-format msgid "\\[%(time)s]" msgstr "" seems to be the case since rP14098 elexis: Since we already have a multi line translation comment in lobby.js we at least woudn't be the…
				elexisUnsubmitted Not Done Inline Actions nope, rP14954 elexis: nope, rP14954
				templeAuthorUnsubmitted Not Done Inline Actions I'm not following. If you're talking about the translate("HH:mm") a couple lines before this in lobby.js, it's ignored because there's another translate("HH:mm") line earlier in the file. temple: I'm not following. If you're talking about the translate("HH:mm") a couple lines before this…
				elexisUnsubmitted Not Done Inline Actions I'm talking about the translation comments starting at `// Translation:` and ending at the URL. Those are supposed to be extracted to the `pot` files because this information is supposed to be displayed on www.transifex.com for translators without them having to open the source code. The mentioned extractor python tool is supposed to do that job, but `//` failts the pattern for a "multiline" comment. Hence it only extracts the first line of the multiline comment and your nice URL isnt actually seen on transifex. You can see that its already broken in svn and the current "pot" file shows it too. You can also run the script yourself (should be `updateTemplates.py` afaik) and generate the pot files yourself with the updated code and see if the multiline comment including the URL was successfully extracted. The pattern `/\.?\/(?us)` looks a bit obfuscated to me, perhaps they mean `/* Translation: foo` on the first line, `` no the second, just like JSdoc? elexis:* I'm talking about the translation comments starting at `// Translation:` and ending at the URL.
				}