Differential D1240 Diff 5484 binaries/data/mods/public/simulation/data/settings/victory_conditions/conquest.json

Changeset View

Standalone View

	{			{
	"TranslatedKeys": ["Title", "Description"],			"TranslatedKeys": ["Title", "Description"],
	"Data":			"Data":
	{			{
	"Title": "Conquest",			"Title": "Conquest",
	"Description": "Defeat all opponents to win.",			"Description": "Defeat opponents by killing all their units and destroying all their buildings.",
				elexisUnsubmitted Done Inline Actions (Can we falsify that sentence by finding a structure that isn't a building?) elexis: (Can we falsify that sentence by finding a structure that isn't a building?)
	"Scripts":			"Scripts":
	[			[
	"scripts/TriggerHelper.js",			"scripts/TriggerHelper.js",
	"scripts/ConquestCommon.js",			"scripts/ConquestCommon.js",
	"scripts/Conquest.js"			"scripts/Conquest.js"
	],			],
	"Default": true			"Default": true
	}			}
	}			}
				elexisUnsubmitted Not Done Inline Actions thumbs up. Perhaps we can find a more precise name? I thought it's a Set as in a set of items, but I think you mean the Set of Setting up victory conditions. The propery name should refelect it's action. elexis: thumbs up. Perhaps we can find a more precise name? I thought it's a Set as in a set of items…
				bbAuthorUnsubmitted Not Done Inline Actions `ChangeOnChecked`? (probably we should have some jsDocs of these files somewhere) bb: `ChangeOnChecked`? (probably we should have some jsDocs of these files somewhere)