yes should, thanks for noticing, I did not really check last updates yet :)

Again, filter through object...

probably the best would be to copy pickMostNeededResources and morphe it to what we need

Ah, thats what I wanted! I couldn't come up with that.

Also this function should request tributes anyways. You just need to pick the most wanted tributable resource.

But this is what it does right? At least that is what I meant ;) It loops over all resources and when the most needed resource is untributable, try the next one. If the the resource is tributable it should break the loop and use the requiredTribute as set lastly. Or am I thinking wrong now?

Then one can do

// Returns the first element matching the condition IsResourceTributable
// See: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/find
let requiredTribute = gameState.ai.HQ.pickMostNeededResources(gameState).find(res => Resources.GetTributable[requiredTribute]);

// Do not request tributes if no resources can be tributed.
if(!requiredTribute)
  return;

I can't seem to get this working. I've tried:

let requiredTribute = gameState.ai.HQ.pickMostNeededResources(gameState).find(res => Resources.GetTributable[res]);

for I think that is what you meant, but it keeps giving me a

WARNING: JavaScript warning: simulation/ai/petra/diplomacyManager.js line 408
reference to undefined property Resources.GetTributable[res]

:(

try with !== undefined ?

let requiredTribute = gameState.ai.HQ.pickMostNeededResources(gameState).find(res => Resources.GetTributable[res]);

I think you could with something like this (not sure):

let requiredTribute = gameState.ai.HQ.pickMostNeededResources(gameState).find(res => !!Resources.GetTributable[res] && Resources.GetTributable[res]);

Sadly not, neither of your suggestions work. There is no warning given, but requiredTribute is still not defined. uneval gives "(void 0)".

I've fixed it :) Thanks for the help!

I think requiredTribute = gameState.ai.HQ.pickMostNeededResources(gameState).find(res => Resources.GetTributableCodes().some(res2 => res2 == res)); would be better.

In terms of performance? Or is there a different reason?

Forgot type

gameState.ai.HQ.pickMostNeededResources(gameState).find(res => Resources.GetTributableCodes().some(res2 => res2 == res.type));

I think it's more readable saying "I want the first resource in the most needed resource that's in Resources.GetTributableCode()"

Than "I want the first resource in the most needed resource that's in where the first Resources.GetTributableCodes() that is not false is equal to res.type"

I thought this

Resources.GetTributableCodes().find(res2 => res2)

would just kind of loop over the tributable resource codes in that array? So returning that value.
But I agree and will change it.

Well this returns the first element that it finds :)

let array = [12,41,42,31,26];
let result = array.find(a => a); // → result = 12

ok, sorry its too late here :D (you find first tributable and break, got it now) but, it does not look correct anyway. You have to handle when no resource is tributable somewhere :)

I understand, it looks ugly ;)
Perhaps an "if i == Resources.GetCodes().length" after the i++? This would not be necessary if Stan's suggestion can be incorporated.

you can and should do check if at least one tributable resource globally exists before even calling mostneeded resources and deal with it there.