- User Since
- Sep 7 2017, 12:14 PM (117 w, 2 d)
Tue, Nov 26
Then let's hope another team member (@elexis?) will eventually find time to review this.
Mon, Nov 25
LOS → vision
Welcome Screen → welcome screen
Corrected start new match tooltip.
Sat, Nov 23
Rebased and updated:
- Lordgood → LordGood
- Hannibal_Baraq → Hannibal_Barca
Sounds like Documentation and would include things like Manuals too I suppose.
(We should avoid creating too narrow categories, as there would be possibly too many of them then.)
You're right. At least it isn't really art or programming.
No, I mean improvements to untranslated descriptions and tooltips, e.g. D2226.
Perhaps there should also be a separate list for user-facing text strings? E.g. @Gallaecio.
How do I achieve that with a program or does performance of the test plan mean going through every line by hand?
Opening the file and scrolling down works; at least that's what I did (twice).
Also the whitespace is inconsistent
But I agree the inconsistent order is bothering people when they insert a new author.
Also the sorting order is kind of irrelevant in the JSON file, the sorting can be performed programmatically.
At this point I wonder whether it's really worth to make an effort to sort these in the database rather than adding 2 lines of JS code to sort them for display?
Also, what if someone wants to sort one list differently, e.g. chronologically?
Also alphabetized art and misc credits, but not special (I assume the order is chronological), nor donators or translators (I assume they're generated via a script).
Right now I'm still unconvinced this is an improvement. Concerns I have:
- time stays closest to the actual modifications, reducing the chance of future inconsistencies
- rate is not less ambiguous than time
- ×0.8 (−20%) → +25% works out nice, but how about e.g. ×0.85 (−15%) → +17.647% or some other value? Right now we don't have to round in tooltips, but if rate is adopted, then we would need a sensible policy for (manual) rounding as well.
- time, not rate, is used for unit training (e.g. athen_player_teambonus.json) and researching technologies (e.g. gaul_player_teambonus.json)
- gather technology descriptions have rate, but here the modified value is indeed a rate, not a time interval
- how about siege engine pack time?
An argument in favour:
- rate is used in healer technology descriptions (e.g. heal_rate.json)
On the forums there was not an overwhelming response for any option; presumably people don't really care.
Fri, Nov 22
Perhaps the Kushite bonus ought to be replaced with something else? Half of the civilizations can't train elephant, so the Kushite team bonus is useless for them.
Mon, Nov 18
Great improvements, thanks again!
Two minor things. Firstly, without the world cap the default is 300, so with it 600 would be a sensible default (so in a two-player game they still start with 300).
Secondly, perhaps instead of two lines:
it could be reduced to just one: “Individual Population Cap” vs “World Population Cap”. The more lines there are displayed, the less readable the information typically becomes.
The patch is rather small when considering the amount of buildings that should be renamed to structure, but I reckon you've deliberately only changed non-code stuff.
Yes, I intentionally avoided code (my understanding is limited) and looked only inside the gui/ folder (to keep it reviewable).
Another thing: how about construction?
Maybe something for a future patch. Let's focus this one on building → structure.
Added some full stops per @Freagarach.
Furthermore, “amphitheatre” (ἀμφιθέατρον) is written with a ph, not a p; please correct.
Sun, Nov 17
Also, the licences are nowhere displayed in game; or am I mistaken?
gaia/fauna_fish_tuna.xml actually ought to be named gaia/fish/tuna.xml since it inherits from template_gaia_fish.xml, not from template_unit_fauna.xml. Just a reminder; it's out of scope of this patch, though.
Maintain title case in options.
Sat, Nov 16
“building” → “structure” incorporated in D2429.
Also, credits look ugly. It would be much better if nick and name were listed in two columns, the left one aligned to the right, the right to the left.
(Again, outside the scope of this patch.)
Also, @Stan is in the credits listed as stanislas69.
Rebased. Please check.
Capture attack is an attack, though; as is slaughter attack; e.g. template_unit_infantry.xml:
Yes, single-player is an adjective, as is multiplayer; I don't think I claimed otherwise.
Please have a careful look at the affected lines and point out which ought to be changed.
I believe in none these cases the meaning is as in “He is a single player.”
Interestingly, the winning player (green) seems to remain active (bartering) after defeating its opponent (blue):
Yeah, but it's unexpected. 300/1 is not 300/0.
Strange, this does not happen with me? Where did it show that? Is that on SVN or A23b?
svn, observer mode, after a player has won.
(Perhaps even nicer would be a slider?)
Personally I prefer discrete options.
The hyphen is there to avoid ambiguity. I don't think in any of the lines changed here “single player” or “singeplayer” would be better than “single-player”.
Also, for what's worth:
It's been a while since last time I looked at this. Whilst I agree this has become a large patch, it's not obvious to me which changes are straightforward and which are potentially controversial.
Feel free to commandeer and split or update as you see fit.
Great feature, thanks!
I tried one game with three AI players and a world population cap of 300. When one player was defeated, the population cap went up as expected (100→150), but when another was beaten, the surviving player was displayed as having a maximum population of “Infinity”, which is odd, because that didn't happen without this patch (i.e. always at 300).
Oct 3 2019
Also, as @Stan pointed out, e.g Arsinoe II II looks weird.
All civilizations have at least eight different AI names, so why do we need these numerals?
Sep 29 2019
Sep 26 2019
Wouldn't it be better if there were a one-on-one correspondence between icons and actors, i.e. a different portrait for each rank? (E.g. basic blue, advanced green, elite yellow, champion red.)
Either restore the order to H-P-C or alphabetize it to C-H-P, but make sure it's consistent throughout the entire game.
Sep 23 2019
Though palisade without s would be more correct; wall, gate, fence are not pluralized either. And stables was finally corrected to stable a couple of months ago.
Thank you for committing this!
list champions before heroes in the production queues of fortresses
Where is this?
Meh, it's not in there, shouldn't have trusted the description.
Out of curiosity, why did you decide to keep the final s? https://code.wildfiregames.com/D2234?id=9536 moved the templates to palisade_*, without s.
Sep 22 2019
End sentences with a full stop.
By the way, why does it say <repeat count="10"> in line 35 but <repeat count="8"> in line 72?
Sep 21 2019
Another question, which of the following do you think is best?
- PgUp and PgDn
- PageUp and PageDown
- Page Up and Page Down
- PgUp (Page Up) and PgDn (Page Down)
Why no colons? It introduces a list, f.e. https://www.thepunctuationguide.com/colon.html
No colon because these are section headers. Cf. the following:
Sep 20 2019
Two very good points, thanks! Those section captions should have neither title case nor colons; I'll check and correct them all.
Check whether the patch is complete (wink wink). Check the phrasing of the tooltip and Intro.txt advertizement [sic] of the hotkeys to reflect that they are used in both pages.
It's probably just a typo, but to advertise is written with -ise in all variaties of English, including American, never with -ize. (Likewise, to capsize is always written with -ize, never -ise. The -ise/-ize UK/US difference only applies to words going back to Greek -ιζ- verbs.)
Sep 19 2019
The changes in this diff arent so worthy for concern if it wasnt a pattern to ignore default.cfg that had led to many mistakes before that would have been found if carefully compared and always cosidered.
Isn't it actually more of a problem that people change keys in the default.cfg file but forget to update the intro.txt file?