Changeset View
Standalone View
binaries/data/mods/public/simulation/data/auras/structures/kush_temple_amun.json
{ | { | ||||
"type": "global", | "type": "global", | ||||
"affects": ["Hero"], | "affects": ["Hero"], | ||||
"modifications": [ | "modifications": [ | ||||
{ "value": "Health/Max", "multiply": 0.95 } | { "value": "Health/Max", "multiply": 0.95 } | ||||
], | ], | ||||
"auraName": "Powerful Priesthood", | "auraName": "Powerful Priesthood", | ||||
"auraDescription": "Strengthen the Priesthood of Amun and undermine your monarch's influence.\n-5% health for heroes per temple built.", | "auraDescription": "Heroes −5% health.", | ||||
bb: Just want to make sure the following is considered:
this tooltip contains besides the effect… | |||||
Not Done Inline ActionsI saw this in https://code.wildfiregames.com/D1807 as well Maybe we should leave these context strings for the time being, let these normalization patches focus specifically on the paragraph that needs normalization. There are changes we could implement in the future (move history backgrounds below the aura descriptions, keep them on a separate variable so that translators can focus on the gameplay-affecting texts first, and then maybe even let players choose whether or not they are shown in game through configuration if someone asks for it), but I think they are all out of the scope of these changes. Gallaecio: I saw this in https://code.wildfiregames.com/D1807 as well
Maybe we should leave these context… | |||||
Done Inline ActionsIn this particular case I'd say purge it; none of the other structure auras has filler text; the reason this one does is presumably because the Kushite files weren't rigorously checked before they were merged; nor is this specific string really informative. (Catafalques are a different story.) Nescio: In this particular case I'd say purge it; none of the other structure auras has filler text… | |||||
Not Done Inline ActionsOK from my side. Gallaecio: OK from my side. | |||||
Not Done Inline ActionsAren’t we keeping the flavor text for now? Gallaecio: Aren’t we keeping the flavor text for now? | |||||
Done Inline ActionsFor catafalques (D1808), yes.
Nescio: For catafalques (D1808), yes.
In this structure aura description, however, I think it ought to… | |||||
"stackable": true | "stackable": true | ||||
} | } |
Just want to make sure the following is considered:
this tooltip contains besides the effect also some historical reference, this patch deletes all those. Now I totally understand the complete irrelevance for gameplay of these referneces, however having such an explanation in a structree or unit viewer is a nice feature.