Differential D4298

Fix missing sell buttons
ClosedPublic
Actions

Authored by Silier on Oct 9 2021, 3:52 PM.

Details

Reviewers

None

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP25954: Fix missing sell buttons

Summary

Introduced in rP25927
Reported on https://wildfiregames.com/forum/topic/56568-petra-having-problems-with-fishing-on-maps-with-water-available/?tab=comments#comment-454690

Test Plan

open trade card from top menu
switch to observer, go back to player

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

/ps/trunk

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 18527
Build 43739: Vulcan Build	Jenkins
Build 43738: Vulcan Build (macOS)	Jenkins
Build 43737: Vulcan Build (Windows)
Build 43736: arc lint + arc unit

Event Timeline

Silier created this revision.Oct 9 2021, 3:52 PM

Owners added a subscriber: Restricted Owners Package.Oct 9 2021, 3:52 PM

Silier published this revision for review.Oct 9 2021, 3:52 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/5051/display/redirect

This revision was not accepted when it landed; it landed in state Needs Review.Oct 10 2021, 11:32 AM

This revision was landed with ongoing or failed builds.

Closed by commit rP25954: Fix missing sell buttons (authored by Silier). · Explain Why

This revision was automatically updated to reflect the committed changes.

Silier added a commit: rP25954: Fix missing sell buttons.

Revision Contents
Changeset List

Path

Size

binaries/

data/

mods/

public/

gui/

session/

trade/

BarterButton.js

1 line

Diff 18783

View Options

binaries/data/mods/public/gui/session/trade/BarterButton.js

Fix missing sell buttonsClosedPublicActions