Diffusion 0 A.D. Public Repository rP25927

Fix black buttons as observer on a GAIA market.
AuditedrP25927
Actions

Description

Fix black buttons as observer on a GAIA market.

Reported by: langbart

Reviewed By: bb

Fixes #6219

Differential Revision: https://code.wildfiregames.com/D4164

Details

Auditors

Silier

Committed

wraitii

Sep 17 2021, 7:01 PM

Reviewer

Differential Revision

D4164: Fix black buttons as observer on a GAIA market.

Parents

rP25926: Fix duplicate insertion error when detecting incompatible mods.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 18441
Build 43451: Post-Commit Build	Jenkins
Build 43450: Post-Commit Build (macOS)	Jenkins

Event Timeline

wraitii committed rP25927: Fix black buttons as observer on a GAIA market..Sep 17 2021, 7:01 PM

wraitii added an edge: D4164: Fix black buttons as observer on a GAIA market..

Harbormaster completed building B18441: rP25927: Fix black buttons as observer on a GAIA market..Sep 17 2021, 9:53 PM

open trade card from top menu
switch to observer, go back to player, missing buttons

https://wildfiregames.com/forum/topic/56568-petra-having-problems-with-fishing-on-maps-with-water-available/?do=findComment&comment=454690

Silier mentioned this in D4298: Fix missing sell buttons.Oct 9 2021, 3:52 PM

Silier raised a concern with this commit.Oct 9 2021, 7:48 PM

Silier added inline comments.

/ps/trunk/binaries/data/mods/public/gui/session/trade/BarterButton.js
55	never enabled back

This commit now has outstanding concerns.Oct 9 2021, 7:48 PM

Silier mentioned this in rP25954: Fix missing sell buttons.Oct 10 2021, 11:33 AM

Silier accepted this commit.Oct 10 2021, 11:48 AM

All concerns with this commit have now been addressed.Oct 10 2021, 11:48 AM

Changes (2)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gui/

session/

trade/

BarterButton.js

BarterButtonManager.js

rP25927

View Options

ps/trunk/binaries/data/mods/public/gui/session/trade/BarterButton.js