Page MenuHomeWildfire Games

JoshuaJB (Josh)
User

Projects

User Details

User Since
Jul 2 2017, 4:22 PM (127 w, 4 d)

Recent Activity

Sun, Dec 1

JoshuaJB requested changes to D2432: Add a -help option.

I think this is okay. While a build-time copy isn't perfect, having a binaries' help text rely on an external file seems equivalently undesirable. A help text should always work in my opinion.

Sun, Dec 1, 11:53 PM
JoshuaJB accepted D2448: Make GLES mode work on Mesa.

Thanks you so much for taking a look at this! Strong GL ES support has been on my wishlist for a long time. If the minimap still doesn't support GL ES (it didn't last I looked), I have a patch from years that could be salvaged rather than starting from scratch.

Sun, Dec 1, 11:36 PM

Sep 6 2019

JoshuaJB added inline comments to D2265: Delete Lobby Presence Update messages altogether.
Sep 6 2019, 11:53 PM
JoshuaJB added a comment to D2265: Delete Lobby Presence Update messages altogether.

With a much more thorough review, I believe my earlier concerns were completely misplaced. While I think we need to sit down and think about a cleaner way to handle all the possible lobby states, this does move things in the right direction. I only have one minor comment about side-effects.

Sep 6 2019, 11:48 PM
JoshuaJB added a comment to D2265: Delete Lobby Presence Update messages altogether.

Woah, give this one a minute for review. I think this is really the wrong approach and needs major rework before landing. I haven't had a chance to write up all my comments yet, but I wanted to quickly jump in and say that I think this should be rolled back until the review process can run its course.

Sep 6 2019, 7:25 PM

Jul 20 2019

JoshuaJB accepted D2094: Fix unreported memory leaks, remove unused code and use c++ style casts in the glooxwrapper following rP19703.

I'm not entirely sure that all these changes are needed, but they seem okay. Coming from mostly writing C, it strikes me as particularly strange to modify something passed as a C++ reference. However, it doesn't seem that there's anything technically wrong with that. I assume you've tested that hosting a game and STUN still work?

Jul 20 2019, 6:27 AM

Jul 19 2019

JoshuaJB requested changes to D1666: Have mod_ipstamp insert hostJID and remove hardcoded 0ad JIDs.
Jul 19 2019, 10:02 PM
JoshuaJB added a comment to D2090: glooxwrapper: Remove unused private 'm_Owned' in Jingle::Session::Jingle.

Thank you for bringing the problems with rP19703 to our attention Krinkle! It's much appreciated.

Jul 19 2019, 9:50 PM
JoshuaJB committed rP22514: Fix reported memory leaks in the glooxwrapper following rP19703.
Fix reported memory leaks in the glooxwrapper following rP19703
Jul 19 2019, 9:46 PM
JoshuaJB closed D2093: Fix reported memory leaks in the glooxwrapper following rP19703.
Jul 19 2019, 9:46 PM
JoshuaJB added inline comments to rP15069: New lobby connect/registration page. Not perfect but fixes most of the….
Jul 19 2019, 3:26 AM
JoshuaJB updated the diff for D2093: Fix reported memory leaks in the glooxwrapper following rP19703.

Correct the handling of sessionInitiate based off discussions with elexis on IRC yesterday.

Jul 19 2019, 1:41 AM
JoshuaJB added inline comments to rP15069: New lobby connect/registration page. Not perfect but fixes most of the….
Jul 19 2019, 1:16 AM

Jul 17 2019

JoshuaJB updated the diff for D2093: Fix reported memory leaks in the glooxwrapper following rP19703.

Remove a superfluous newline and tweak the wording

Jul 17 2019, 10:27 PM
JoshuaJB updated the diff for D2093: Fix reported memory leaks in the glooxwrapper following rP19703.

Add copyright year updates

Jul 17 2019, 10:18 PM
JoshuaJB updated the diff for D2093: Fix reported memory leaks in the glooxwrapper following rP19703.

Change the diff to be from the repository root rather than the source folder.

Jul 17 2019, 10:01 PM
JoshuaJB accepted rP19703: STUN + XMPP ICE implementation..

D2090 brought to my attention that a few outstanding comments on this were never addressed. I've annotated the remaining comments with where they were fixed and opened D2093 to handle the remaining problems.

Jul 17 2019, 9:55 PM
JoshuaJB created D2093: Fix reported memory leaks in the glooxwrapper following rP19703.
Jul 17 2019, 9:49 PM

Jul 15 2019

JoshuaJB added a comment to D2079: Adds snapping to edges for buildings.

Why put this behind a hotkey? This seems to me like desirable default placement behavior.

Jul 15 2019, 4:55 AM

Jul 16 2018

JoshuaJB accepted rP21847: Rewrite the prelobby pages and add the Terms of Service, Terms of Use and the….

Okay, seems reasonable; we want the user to verify their identity before accepting the terms. We could ask for the user to re-accept the terms (if they've changed) on another page after the login one to improve the experience. I can look into implementing that (and maybe storing the terms acceptance state per-account on the server) if there are no objections.

Jul 16 2018, 8:18 PM
JoshuaJB raised a concern with rP21847: Rewrite the prelobby pages and add the Terms of Service, Terms of Use and the….

There seems to be an issue where we do not always correctly persist the state of the user's acceptance on first-run.
Repro:

  1. Reset to default config
  2. Open lobby, enter incorrect password, accept terms, click login
  3. Observe incorrect password message
  4. Enter correct password
  5. Observe requirement to re-read and accept the terms, even though you already did that during your earlier login attempt
Jul 16 2018, 4:26 AM
JoshuaJB requested changes to D893: Hiding profile panel in lobby when it is not required for having a longer playerlist.

This seems to almost always work great, and the code looks pretty good. One bug though when I tested locally:

Jul 16 2018, 2:57 AM

Jan 24 2018

JoshuaJB added a comment to D893: Hiding profile panel in lobby when it is not required for having a longer playerlist.

Changes look great at a glance! I will try to take a longer look at it and try running it locally later today.

Jan 24 2018, 6:00 PM
JoshuaJB requested changes to D893: Hiding profile panel in lobby when it is not required for having a longer playerlist.

Fantastic direction! That panel should always have automatically hidden when empty, so no need to make it configurable. Thanks for finally looking into fixing this! I did a quick run over the patch and tried to point out anything that I imagine possibly being a problem.

Jan 24 2018, 6:43 AM
JoshuaJB added a comment to D1034: Wheel-adjustable batch size.

It seems to me that automatically saving the batch train amount adjusted by the scroll wheel would be unexpected and unituitve behavior for new players.

Jan 24 2018, 5:56 AM