Paths

Table of Contentst

Diffusion 0 A.D. Public Repository rP20637

Define, document, validate and test validation of the format of mod.json files.
AuditedrP20637
Actions

Description

Define, document, validate and test validation of the format of mod.json files.

The mod "name" may only consist of alphanumeric characters, underscore and dash, because it should be used for mod dependency checks.
Drop two special characters from the "version" property.

Differential Revision: https://code.wildfiregames.com/D1093
Res #4427, rP20552
Reviewed By: Itms

Details

Auditors

Imarok
mimo

Committed

elexis

Dec 10 2017, 5:13 PM

Reviewer

Itms

Differential Revision

D1093: Add mod documentation, specification, validation and validation test

Parents

rP20636: [Windows] Automated build.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 4074
Build 7153: Post-Commit Build	Jenkins

Event Timeline

elexis committed rP20637: Define, document, validate and test validation of the format of mod.json files..Dec 10 2017, 5:13 PM

Harbormaster completed building B4074: rP20637: Define, document, validate and test validation of the format of mod.json files..Dec 10 2017, 9:55 PM

Imarok added a subscriber: Imarok.Dec 11 2017, 3:04 PM

Imarok added inline comments.

/ps/trunk/binaries/data/mods/mod/gui/modmod/validatemod.js
123	Shouldn't this be version?

Imarok added inline comments.Dec 11 2017, 3:08 PM

/ps/trunk/binaries/data/mods/mod/gui/modmod/validatemod.js
41	What about capital letters?

Things above.
(If we don't allow caps in the mod name, the comment and the warning should state this)

This commit now has outstanding concerns.Dec 11 2017, 3:20 PM

Itms added a subscriber: Itms.Dec 12 2017, 7:52 PM

Itms added inline comments.

/ps/trunk/binaries/data/mods/mod/gui/modmod/validatemod.js
41	I am for keeping the regex like this and stating that in the doc.
123	Good catch, had missed it.

elexis mentioned this in D1094: Only allow numbers and at most 2 periods in mod versions.Dec 12 2017, 8:39 PM

"dependencies": ["0ad=0.0.23"] is broken, it gives a dependency not met message.

In rP20637#26036, @mimo wrote:

"dependencies": ["0ad=0.0.23"] is broken, it gives a dependency not met message.

Sure the dependency is met?

elexis mentioned this in rP15677: Add mod selection mod..Dec 15 2017, 5:05 PM

In rP20637#26045, @elexis wrote:

In rP20637#26036, @mimo wrote:

"dependencies": ["0ad=0.0.23"] is broken, it gives a dependency not met message.

Sure the dependency is met?

What do you mean? as I'm on svn, it should be the case. But does it work for you?

Was asking since one can disable the public mod and I thought I had tested it again. But you are right, it wasn't parsed correctly, g_RegExpComparison should be g_RegExpComparisonOperator.

/ps/trunk/binaries/data/mods/mod/gui/modmod/validatemod.js
41	There is an `i` here, but it's dropped when later combining the regex'

D1151

elexis mentioned this in rP20656: Fix three wrongly chosen variables in rP20637 / D1093, a wrong case-insensitive….Dec 16 2017, 12:38 AM

mimo accepted this commit.Dec 16 2017, 11:43 AM

elexis requested verification of this commit.Dec 16 2017, 5:58 PM

This commit now requires verification by auditors.Dec 16 2017, 5:58 PM

elexis mentioned this in rP20552: Cleanup mod selection GUI page..Dec 18 2017, 8:50 PM

Imarok accepted this commit.Dec 20 2017, 12:23 PM

All concerns with this commit have now been addressed.Dec 20 2017, 12:23 PM

Imarok accepted this commit

Since this commit is about the same file and closely related topics in rP20552, since you worked with this file recently and since you are one of the developers addressing linting patches, may I ask for a formal audit of that commit?

Silier mentioned this in rP25915: Fix typo in validatemods introduced in rP20637.Sep 11 2021, 11:17 AM