Differential D1101

Visit mod URL button
ClosedPublic
Actions

Authored by elexis on Dec 2 2017, 1:38 PM.

Details

Reviewers

Grugnas

Commits

rP20599: Add buttons to visit the website of the selected mod.

Summary

The second button could be moved to a separate line above the save/cancel/launch buttons (described here D1079).

Test Plan

Notice that the engine function doesnt execute for play0ad.com.

This might mean that we might consider changing the engine function and
also consider requiring the scheme part of the URL (https://en.wikipedia.org/wiki/URL#Syntax)

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.Dec 2 2017, 1:38 PM

elexis mentioned this in D1093: Add mod documentation, specification, validation and validation test.Dec 2 2017, 1:39 PM

Successful build - Chance fights ever on the side of the prudent.

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

Executing section Default...
Executing section Source...
Executing section JS...

Harbormaster completed remote builds in B3914: Diff 4490.Dec 2 2017, 2:28 PM

ffffffff added a subscriber: ffffffff.Dec 5 2017, 10:27 PM

ffffffff added inline comments.

binaries/data/mods/mod/gui/modmod/modmod.xml
105 ↗	(On Diff #4490)	name="websiteButton" enable="false" var g_Url = ""; list.onSelectionChange = checkModWebsite(this) function checkModWebsite(list) { let folder = list.list_folder[list.selected]; g_Url = folder && g_Mods[folder] && g_Mods[folder].url; Engine.GetGUIObjectByName(listName).enable = g_Url ? true : false; } function visitModWebsite() { if (!g_Url.startsWith("http://") \|\| g_Url.startsWith("https://")) g_Url = "http://" + g_Url; Engine.OpenURL(g_Url); }

ffffffff added inline comments.Dec 5 2017, 10:29 PM

binaries/data/mods/mod/gui/modmod/modmod.xml
105 ↗	(On Diff #4490)	Engine.GetGUIObjectByName(listName) wrong mean Engine.GetGUIObjectByName("websiteButton")

ffffffff added inline comments.Dec 5 2017, 10:30 PM

binaries/data/mods/mod/gui/modmod/modmod.xml
105 ↗	(On Diff #4490)	function visitModWebsite() { if (!g_Url) return; if (!g_Url.startsWith("http://") \|\| g_Url.startsWith("https://")) g_Url = "http://" + g_Url; Engine.OpenURL(g_Url); }

Accepted after the discussion about buttons organization.

This revision is now accepted and ready to land.Dec 6 2017, 8:46 PM

Thanks for the reviews.

binaries/data/mods/mod/gui/modmod/modmod.xml
105 ↗	(On Diff #4490)	I agree that the button should be disabled, but it won't work with only a single global. I think a disable-button implementation should encompass all buttons simultaneously.