Page MenuHomeWildfire Games

elexis (Alexander H)
User

Projects

User Details

User Since
Dec 21 2016, 3:52 PM (102 w, 5 d)

Recent Activity

Sat, Dec 8

elexis added a comment to D1689: Delete duplicate art/textures/texture rng/rnc/xml files following rP15678.

It's the same situation with mod/art/textures/ui/textures.xml it's only present in the "mod" mod, but the directory (without the xml file) also exists in "public".
And these rngs/rncs only exist in the public mod.
./mod/art/textures/texture.rng
./mod/audio/sound_group.rng
./mod/shaders/program.rng
./mod/gui/gui.rng
./mod/gui/gui_page.rng

Sat, Dec 8, 5:48 PM
elexis added a comment to D1689: Delete duplicate art/textures/texture rng/rnc/xml files following rP15678.

Whut? It's impossible to package without the modmod currently.

Sat, Dec 8, 5:37 PM
elexis created D1690: Fix Danubius ownershipchange subscription following rP21445.
Sat, Dec 8, 3:43 PM
elexis added inline comments to rP21445: Refactor and move random template composition triggerscript code used for gaia….
Sat, Dec 8, 3:39 PM
elexis created D1689: Delete duplicate art/textures/texture rng/rnc/xml files following rP15678.
Sat, Dec 8, 1:45 PM
elexis added inline comments to rP15678: Make the modmod standalone..
Sat, Dec 8, 1:35 PM
elexis added a comment to D1687: Fix build on OSX 10.9.5 Mavericks.
In D1687#66939, @Stan wrote:

It would be nice to disable all other librairies if possible.

Sat, Dec 8, 12:56 PM

Fri, Dec 7

elexis added inline comments to rP21726: Add a mod installer, fixes #4027..
Fri, Dec 7, 5:56 PM
elexis added a comment to rP21940: Build gloox with GnuTLS on macOS, refs #4705..

If it crashes for everyone on 10.9, 10.10, 10.11, we can disable TLS in the config and remove that one TLS sentence for OSX.

Fri, Dec 7, 5:15 PM
elexis added a comment to rP21726: Add a mod installer, fixes #4027..

Perhaps we could use a bugreport on the a24 milestone for the issue reported in previous posts, as users seem to run frequently into that.

Fri, Dec 7, 3:16 PM
elexis added a comment to rP21940: Build gloox with GnuTLS on macOS, refs #4705..

On versions of OSX/macOS up to 10.11, TLS handshakes can still fail and crash?

Fri, Dec 7, 2:10 PM
elexis awarded rP21941: Import part of commit https://github.com/premake/premake… a Like token.
Fri, Dec 7, 2:09 PM
elexis added a comment to rP21942: Target 10.9 as minimal OSX version in all scripts, in order to match the….

(I find it hard to beleve that since Nov 2016, Alpha 21 (SM38 / #3708), noone has tried running a release bundle on macOS 10.8 and reported it as defunct, on the other side I only recall people using recent macOS versions.)

Fri, Dec 7, 2:09 PM
elexis added a comment to D1688: Ignore entities out of the passable map area in GetLandSpawnPoints.
  • There is a ticket for removing the instances of the 3 border
  • The map should be fixed, the commit should be dug out.
  • I recall Petra complains too about stuff outside of the map area.
  • I wonder if there shouldn't be a warning or error message about entities placed outside of the map area (in the border or beyond) when parsing the finished mapgeneration. There is a ticket for warnings about gatherable entities that are on a too slopy position to be gatherable). CCmpPosition has the OutsideOfWorld boolean to represent units that are outside of the map area. There might be edge cases where one could argue that entities outside of the map area would be justified (for example there is a skirmish map that has a wonder where 50% of the area is inside the map and 50% in the shroud of darkness). But perhaps these edge cases can all be satisfied with the given restrictions (the center position may not be on a slope and must be inside the map). Otherwise if these edge cases are really relevant, one could add a boolean flag to the map that allows or complains (and possibly removes) entities at invalid positions. Thus adding an automated way of informing map authors when they broke their map. If the engine only loads valid maps, or if the PositionComponent prevents setting such an out-of-world position without setting out-of-world to true, it wouldn't have to add these border checks to every place in the simulation (including here).
Fri, Dec 7, 1:39 PM
elexis added a comment to rP21943: Update client\'s default.cfg for the new muc room `arena23b`.

Getting an OOS error at a later time in a match versus getting an OOS error at the beginning of a match is not a qualification to change the room in the re-release.
That WFG logs who accepted the new GDPR terms and that players can play without the a23 OOS errors are nice benefits, but not the reason to add this new room.
Most certainly multiple players in a match with 6-8 players getting disconnected at the gamestart and every rejoin attempt on every map due to the petra AI teambonus initialization freezing the non-threaded NetClient for 10+ seconds up to the point where it counts that as a disconnect is.
The only reason many 4v4s currently work is because those people use svn, that includes a petra AI skip and the NetServer and NetClient waiting for up to 60+ seconds on init before disconnect (relevant in case someone did enable AIs or any other code being that slow. The actual patch to use threading in the NetClient is unpublished).
There are a number of other committed C++ fixes, why spend additional effort to provide a partial release?
Usually the lobby becomes empty after the first day of a new release due to the lobby subject and the absence of players and games. The intention is that players can play the game without crashing in several ways and to push the players into actually installing the update, rather than continuing to get N reports about the bugs fixed this summer every day (including the macOS thing and some other OOS errors).
The mod version is not changed, so that people can still replay their old replays, continue their savegames, can use the same mods (which should all be fully compatible except fgod which is currently incompatible with our terms in two ways, so fpre rebasing that means he would fix that.).

Fri, Dec 7, 1:22 PM

Thu, Nov 29

elexis added a comment to D1684: Pass callback function to PushGuiPage and unify PopGuiPage/PopGuiPageCB.

As you see, I was right, with the patch you need to change a more number of lines to add new values to the GUI stack.
The patch now forbid to use different values passed to the GUI stack, only functions.

"Only functions" is the part that makes no sense to me

Thu, Nov 29, 4:35 PM
elexis added inline comments to D1684: Pass callback function to PushGuiPage and unify PopGuiPage/PopGuiPageCB.
Thu, Nov 29, 3:55 PM
elexis added a comment to D1684: Pass callback function to PushGuiPage and unify PopGuiPage/PopGuiPageCB.

The patch now forbid to use different values passed to the GUI stack, only functions.

I think you didn't read the patch right, because with and without the patch, one passes exactly one argument (that must be cloneable) to the callback function init called from PushGuiPage, and exactly one argument given by the PopGuiPage to the close function passed to PushGuiPage.
The patch does not remove any argument, but moves one property of the initarguments to a separate function argument.
Notice how wrong it logically is to add the function name of the close function to the arguments of function init(data).
So even the contrary - the currently committed code forbids to pass objects with an unrelated callback property to the init function, whereas with this patch that restriction is removed.

Thu, Nov 29, 3:54 PM
elexis updated the diff for D1684: Pass callback function to PushGuiPage and unify PopGuiPage/PopGuiPageCB.

Remove core.js closePage function formerly used by viewer.js.

Thu, Nov 29, 2:44 PM
elexis created D1684: Pass callback function to PushGuiPage and unify PopGuiPage/PopGuiPageCB.
Thu, Nov 29, 2:36 PM
elexis added inline comments to rP21339: Add buttons for changing between, and hotkeys for opening, the civinfo and….
Thu, Nov 29, 2:35 PM
elexis added inline comments to rP19940: Relocate and Rearrange the structree codebase.
Thu, Nov 29, 2:33 PM
elexis committed rP21935: Remove obsolete DisplayMessageBox function from rP7390, unused since rP8367..
Remove obsolete DisplayMessageBox function from rP7390, unused since rP8367.
Thu, Nov 29, 1:34 PM
elexis updated the Trac tickets for D1683: Removes hardcoded SkyBox sizes and use infinity sky.
Thu, Nov 29, 11:15 AM
elexis added a comment to D1683: Removes hardcoded SkyBox sizes and use infinity sky.

the sky is in infinity. So all clouds move together with the camera

If you mean the clouds in the sky texture, that doesn't seem like a problem.
If we want closer clouds, they should be separate from the skybox probably: #46.

Thu, Nov 29, 11:15 AM
elexis awarded D1683: Removes hardcoded SkyBox sizes and use infinity sky a Like token.
Thu, Nov 29, 11:02 AM

Wed, Nov 28

elexis added a comment to rP8367: Change S3TC warning yet again, to point to a web page with more information..

The DisplayMessageBox function introduced by rP7390 should have been deleted in this commit, because:

  1. This commit removed the only call to DisplayMessageBox
  2. As stated by the commit message: "stop hard-coding the message"
  3. C++ should be agnostic of JS/XML contents . It can send an event (for example replay-finished or oos-error) to the GUI and then the GUI can decide how to present it.
Wed, Nov 28, 3:04 PM

Tue, Nov 27

elexis committed rP21932: Allow users to disable TLS encryption entirely in the GUI to ease use of the….
Allow users to disable TLS encryption entirely in the GUI to ease use of the…
Tue, Nov 27, 4:12 PM
elexis closed D1679: Add an option to allow players to circumvent TLS bugs.
Tue, Nov 27, 4:12 PM

Mon, Nov 26

elexis added a comment to D1679: Add an option to allow players to circumvent TLS bugs.
In D1679#66711, @smiley wrote:

The problem of crashes still persists. The average user would not know (wont even try probably) the cause of the crash. And there would be a lot of “disable TLS” replies to reports. Pop-up or a tooltip would do maybe.

Mon, Nov 26, 11:39 AM
elexis added a comment to D1679: Add an option to allow players to circumvent TLS bugs.

Arguably the previous diff was better, because it didn't confuse the uneducated player further in the login dialog. Arguably this diff is better, because it empowers the educated player.
As a third alternative one could commit only the cpp + default.cfg diff, as linux people are usually smart enough to edit a config file, and the other platforms, macOS and windows, seem tested by us.
Meh.

Mon, Nov 26, 11:31 AM
elexis updated the diff for D1679: Add an option to allow players to circumvent TLS bugs.

Add the checkbox in to the login/register page instead of options dialog.

Mon, Nov 26, 11:24 AM
elexis added a comment to D1679: Add an option to allow players to circumvent TLS bugs.

I guess it's better if the option wouldn't exist and if there was only a message box popping up, asking the user if he wants to proceed if the connection is unsafe, otherwise presume TLS.
But that would require a bit more rework - first attempting to login with TLS enabled and then asking if that failed - which is also not an option to circumvent any TLS handshake crashes...

Mon, Nov 26, 11:21 AM
elexis added a comment to D1679: Add an option to allow players to circumvent TLS bugs.

Better would be a fix, investigating.

Compiling the entire GnuTLS / gloox / 0ad stack cleanly everytime in a VM takes 30min and makes my system unusuable or even freezes it, so it ended up being deleted...
especially because the next best platform can have broken gloox as well,
considering how many gloox/gnutls bugs are already reported,
and considering that I hardly know every detail about gloox, gnutls and fedora for every version.

Mon, Nov 26, 10:26 AM

Sun, Nov 25

elexis added inline comments to D1679: Add an option to allow players to circumvent TLS bugs.
Sun, Nov 25, 2:29 PM
elexis added a comment to D1680: Do not hardcode screen ratio in the main menu..

Just mere guessing, but doesn't that hardcode the ratio of the image rather than the ratio of the screen and tries to make sure that the image is moved into all directions with equal speed?

Sun, Nov 25, 11:55 AM
elexis added a comment to D1680: Do not hardcode screen ratio in the main menu..
In D1680#66674, @Stan wrote:

Basically this number is multiplied to whatever the height is. So in case it's 1080 you get 1920 if it's 1050 you get 1866 instead of 1680 (Because it's supposed to be a 16:10 ratio) if you give it 768 (for 1024x768 which is the minimun resolution we support) you get 1366. That is not a 4:3 ratio.

Sun, Nov 25, 11:13 AM
elexis updated the diff for D1679: Add an option to allow players to circumvent TLS bugs.

Use TLSDisabled, rephrase, nuke cert verification option until we have at least one machine where it works

Sun, Nov 25, 11:09 AM
elexis commandeered D1679: Add an option to allow players to circumvent TLS bugs.
Sun, Nov 25, 11:08 AM
elexis added a comment to D1679: Add an option to allow players to circumvent TLS bugs.

Fedora 29 uses GnuTLS 3.6.4 and gloox 1.0.14.
I've compiled with that GnuTLS version and the most recent gloox windows on Ubuntu 18.04 but can't reproduce there.
I suppose the checkbox is even relevant if the Fedora thing is fixed, because the next best platform might crash randomly as well.

Sun, Nov 25, 11:08 AM
elexis added a comment to D1680: Do not hardcode screen ratio in the main menu..

Stan can you describe how this number is used? It is not clear to me from a quick read and quick test (and why 1 is better than 1.7777?)

Sun, Nov 25, 10:46 AM

Sat, Nov 24

elexis requested changes to D1679: Add an option to allow players to circumvent TLS bugs.

Stacktrace is on the trac ticket.

Sat, Nov 24, 7:41 PM
elexis updated subscribers of D1611: Use pkg-config instead of hard-coding or library-specific programs.

@Itms @s0600204 The ticket where this build failure is reported is on the a23 milestone and I'm not sure if this irrelevant enough to be pushed. There was another bugreport on Nov 20th on the lobby:

Maanyavar: 0ad doesnt work on slackware 14.2

Sat, Nov 24, 3:06 PM
elexis added a comment to D1660: Move Wild Lake biome specifics to a JSON file.

I find less files easier to maintain then multiple files BTW.

In particular for Hellas typos when refering from JS to JSON were a bit painful.
The same argument is also often given for JS files, but there are also advantages to splitting things into different files (logical grouping, preventing fragmentation, etc).

Sat, Nov 24, 2:03 PM
elexis added a comment to D1679: Add an option to allow players to circumvent TLS bugs.

As mentioned in https://trac.wildfiregames.com/ticket/5349#comment:4 the question is whether gloox::TLSOptional should not rather become gloox::TLSDisabled in XmppClient.cpp if it crashes when trying the handshake.

Sat, Nov 24, 1:45 PM

Thu, Nov 22

elexis added a comment to D406: Add a steps param to sliders.

double > JS::Number conversion loses precision

But we already do that conversion and that conversion is not really related to this patch or the adapted one?

Thu, Nov 22, 1:04 AM
elexis added a comment to D406: Add a steps param to sliders.
In D406#66518, @elexis wrote:

We can convert a JS::Number <-> double well, so is it about some epsilon / rounding phenomenon?
Getting min + i * width rounded as wished shouldn't be so hard to accomplish, regardless which implementation is introducing the epsilon.

You can check it by returning a fixed number, like 4.5. JS may get from C++ the 4.499999 value. And for JS these values are different.

Thu, Nov 22, 12:20 AM

Wed, Nov 21

elexis added a comment to D406: Add a steps param to sliders.
In D406#66464, @elexis wrote:
In D406#66462, @Stan wrote:

We really need this feature for the GUI.Scale options. I think there is already a differential but if Not I can submit a patch

The patch for UI scale is uploaded but abandoned, should be reclaimed and receive an ugly workaround (message box that if not clicked after 7 seconds will reset the UI scale)

Not a workaround solution requires improvements in the our option page logic. Because we shouldn't change visible scale while a user is dragging the slider.

Wed, Nov 21, 11:24 PM
elexis added a comment to rP20625: Remove civ-specific hardcoding in rmgen wall-placement script..

(The obelisks are just meant to show the center e.g. to show where it is on fortress (the "center of mass") compared to e.g. regular polygons/circular where it's just the center of symmetry)

The obelisk in the center is good, just saying walls should not be replaced with placeholders to work around.

Wed, Nov 21, 11:10 PM
elexis added inline comments to D1675: Remove excess argument from shift call.
Wed, Nov 21, 11:01 PM
elexis added a comment to D1668: Rely on copy-elision / return-value-optimization for lobby string getters.

Smart, but the (N)RVO isn't guaranteed. Only since C++17.

Wed, Nov 21, 10:51 PM
elexis accepted D1675: Remove excess argument from shift call.
  • Confirmed with warn(uneval()) that the line is actually executed
  • The patch must be correct for any mapsettings, because there is only one call to sortPointsShortestCycle, that receives the argument from groupPlayersCycle, that receives the argument from getStartLocationsByHeightmap on wild lake and caledonian meadows and that function always returns a Vector2D array.
Wed, Nov 21, 6:24 PM
elexis added a comment to rP20625: Remove civ-specific hardcoding in rmgen wall-placement script..

About the unintended wallsets:

Wed, Nov 21, 5:13 PM
elexis added a comment to D1674: Check translations for sprintf errors.
In D1674#66477, @Itms wrote:

So the big flaw of rP19669 is that the Phabricator Jenkins plugin has this issue: https://github.com/uber/phabricator-jenkins-plugin/issues/224
The script is useless as long as issue 224 prevents the job from posting comments on autobuilder i18n commits.

Ah, it sounded like it would post on revision proposals. Posting red flags on autobuild commits indeed helps.

Wed, Nov 21, 1:55 PM
elexis added a comment to D1649: Update client loading state upon client disconnect too.
In D1649#66373, @Imarok wrote:

Anything more that needs review?

As said, not besides the comments I wrote.

Wed, Nov 21, 10:27 AM
elexis added a comment to D1556: NetClient and NetServer state comments, renames and cleanup.
In D1556#66171, @Imarok wrote:

The proposed renames in the patch description sound sane. 👍
The added descriptions are also good. (Besides the comments I gave)

Wed, Nov 21, 10:16 AM
elexis added reviewers for D1666: Have mod_ipstamp insert hostJID and remove hardcoded 0ad JIDs: Dunedan, user1.
Wed, Nov 21, 10:09 AM
elexis updated subscribers of D1668: Rely on copy-elision / return-value-optimization for lobby string getters.

@vladislavbelov are most compilers really smart enough to use copy elision for strings here as widely claimed on the internet?
(Some places use one pattern, other places use the other pattern, we should make up our mind what we want, otherwise it sounds contradictory if we claim there to be good reasons for both.)

Wed, Nov 21, 10:08 AM
elexis added a comment to D1674: Check translations for sprintf errors.

In particular: If we already have a script that satisfies this purpose, why didn't we find the broken sprintf arguments before?

"it have been 2 years there"

Wed, Nov 21, 10:03 AM
elexis added a comment to D1023: Improves the replay list interface.

I agree that this looks ugly in

, for 1600*1200 it already looks like a grid:

I suppose the math wasn't done right to always have the grid.

Wed, Nov 21, 10:01 AM
elexis added a comment to D406: Add a steps param to sliders.
In D406#66462, @Stan wrote:

We really need this feature for the GUI.Scale options. I think there is already a differential but if Not I can submit a patch

Wed, Nov 21, 9:46 AM
elexis added a comment to D1573: Adds callbacks to the CConfigDB.

And we don't know, was it really initialised.

Shouldn't there also be a callback function on failure then, used when globals are initialized by a config value?

Wed, Nov 21, 9:36 AM
elexis requested changes to D406: Add a steps param to sliders.

The JSON syntax should be tuned for people who modify the options file, not for the C++ code.

Wed, Nov 21, 9:32 AM
elexis added a comment to D1515: Split CColor from Shapes.

I agree with the patch, it's a good cleanup. A Color entirely is not a Shape and it will leave behind cleaner code if we don't include the shapes header if we only need the color.
(I suppose one could lose a lot of time reinvestigating the completeness of includes, better don't even start).
Otherwise I suppose one could test it by compilign without precompiled headers, running every function that uses colors and then it could be committed if it still doesn't fall apart and everything is confirmed to be the same code flow as before.

Wed, Nov 21, 9:23 AM
elexis added a comment to D1437: Disable shadows if we can't create a shadow map.

shadow map size may be set in local.cfg, in which case the shadow map quality setting does nothing

I didn't test, so I don't know if this patch handles the error gracefully with an affecting local.cfg.
If it doesn't, it would be safer to update the renderer to use shadow maps if and only if shadow maps can be used and are configured to be used; i.e. possibly don't change the configuration value, only a renderer value.

Wed, Nov 21, 9:13 AM
elexis added a comment to D1437: Disable shadows if we can't create a shadow map.

I think this patch have to be in alpha 23. It doesn't solve the problem of #4883, but it saves from his consequences.

This is a reasonable argument.
But we still need to check that the patch doesn't introduce other unintended consequences (which can be hard to tell for all possible platforms before a release) and that the patch is the final way to address the problem (so that we dont have to start investigating this issue from scratch).

Wed, Nov 21, 8:49 AM

Tue, Nov 20

elexis added a comment to D1589: Get rid of TERRAIN_SEPARATOR.

Perhaps instead of an object with 2 properties or an arry with 2 items, it would even be cleaner to use a function / constructor with 2 arguments (texture, entity = undefined), like using SimpleTerrain or RandomTerrain which receives an array of SimpleTerrain?

Tue, Nov 20, 10:01 PM
elexis added inline comments to D1675: Remove excess argument from shift call.
Tue, Nov 20, 9:58 PM
elexis added inline comments to D1589: Get rid of TERRAIN_SEPARATOR.
Tue, Nov 20, 6:50 PM
elexis added inline comments to D1589: Get rid of TERRAIN_SEPARATOR.
Tue, Nov 20, 6:41 PM
elexis added inline comments to D1675: Remove excess argument from shift call.
Tue, Nov 20, 4:05 PM
elexis added a comment to D1674: Check translations for sprintf errors.
In D1674#66409, @Itms wrote:

Thank you for the patch! Unfortunately those checks are the same as what is checked by build/jenkins/lint-translations.sh. The thing that is missing from this is a check for broken custom tags (like [font] ones, typically).
I am adding a note to ReleaseProcessDraft so the translation lint script is better advertised.

Tue, Nov 20, 3:53 PM

Sun, Nov 18

elexis added a comment to rP20625: Remove civ-specific hardcoding in rmgen wall-placement script..

ping @s0600204, doesn't this satisfy the problem described in #2631 and provides more flexibility to the random map author than the skirmish replacer, i.e. can be marked as fixed or won't fix?

Sun, Nov 18, 8:29 PM
elexis awarded D1676: Embed zpl-c's version of enet library a Yellow Medal token.
Sun, Nov 18, 7:11 PM
elexis added a comment to D1649: Update client loading state upon client disconnect too.
In D1649#66186, @Imarok wrote:

Besides the comments: Looks good.
Could reproduce and fixes. 👍

Sun, Nov 18, 10:28 AM
elexis added a comment to D1654: Build gloox with GnuTLS on macOS.
In D1654#66251, @Itms wrote:
In D1654#66152, @elexis wrote:

It was just that it shouldn't be possible to obtain the stacktrace that Tobbi received, where the macro says 10.8 and the compiler says 10.7:

Couldn't it come from what @trompetin17 has discovered, that premake5 itself has a hardcoded 10.4 minimum version? See this line and others, all coming from this code in p5 a10.

Sun, Nov 18, 8:45 AM
elexis awarded D1675: Remove excess argument from shift call a Like token.
Sun, Nov 18, 8:33 AM
elexis added inline comments to rP14097: glooxwrapper by Philip to support building gloox on Windows..
Sun, Nov 18, 3:58 AM

Fri, Nov 16

Angen awarded D1674: Check translations for sprintf errors a Like token.
Fri, Nov 16, 5:12 PM
elexis added a comment to D1640: ConvexPolygonPlacer optimization in rmgen..
In D1640#66306, @FeXoR wrote:

@elexis : On Vectors: Uhm, yes, I agree on using vectors can make things easier and they should be widely used (Though much less to those "unreadable", "impossible to understand", " obscured or unrecognizable" for those are IMO obscured references to properties of the reader, not the code... This depends strongly on habituation IMO).

Fri, Nov 16, 5:05 AM
elexis created D1674: Check translations for sprintf errors.
Fri, Nov 16, 4:07 AM

Thu, Nov 15

elexis added a comment to D1640: ConvexPolygonPlacer optimization in rmgen..
In D1640#66298, @FeXoR wrote:
In D1640#66297, @elexis wrote:

The question is how much faster this is. It must be worth the code complexity. If it's only a fraction of a second, that may be meh.

Agreed, as I wrote.

(Also my alarm goes off when I see variables storing X and Z coordinates that arent vectors)

x1, x2, y1, y2 are x/y ranges so it's absolutely valid to store them in variables IMO (just that they are constants).

Thu, Nov 15, 4:41 PM
elexis added a comment to D1640: ConvexPolygonPlacer optimization in rmgen..

The question is how much faster this is. It must be worth the code complexity. If it's only a fraction of a second, that may be meh.
(Also my alarm goes off when I see variables storing X and Z coordinates that arent vectors)

Thu, Nov 15, 2:29 PM
elexis planned changes to D1667: Lobby ScriptConversion to remove stanza property name hardcoding and duplication.

(To repeat) The current patch and the patch posted in the comments conceptually cannot work with child elements, while child elements should be used to remove the JSON encoded arrays in stanzas.

Thu, Nov 15, 11:57 AM
elexis added a comment to D1654: Build gloox with GnuTLS on macOS.

Alternatively gloox also supports OpenSSL and LibreSSL (https://camaya.net/gloox/download/). Dunno if that's more feasible to use. (gloox ought to support the native Secure Transport like curl does. https://developer.apple.com/documentation/security/secure_transport)

Thu, Nov 15, 5:01 AM

Wed, Nov 14

elexis added a comment to D1661: lobby bots systemd service.

Looks good, wanna commandeer and add the README entry?
Also would be good to support arguments that only work for some versions (for example disable TLS and the rating bot are recent arguments).

Wed, Nov 14, 5:25 PM
elexis added a comment to D1667: Lobby ScriptConversion to remove stanza property name hardcoding and duplication.

This is what a generic JS<->gloox:Tag converison would look like, revealing the array problem:

Wed, Nov 14, 12:43 PM
elexis added a comment to D1667: Lobby ScriptConversion to remove stanza property name hardcoding and duplication.

Notice all of this and the converse conversion work very well this way as long as we only work with attributes.

Wed, Nov 14, 12:26 PM

Tue, Nov 13

elexis added a comment to D1654: Build gloox with GnuTLS on macOS.

Tobbi compiled with this patch and bundled an image and could join the lobby. https://mega.nz/#!Jcd2EaqB!uX5NiOYuaIzfdliy10nOZx9T2vsQK8AKltStDbE5IQs

Tue, Nov 13, 10:40 AM
elexis added a comment to D1609: Small changes to the macOS scripts.

Tested by Tobbi: He had to compile with this NSPR flag too on macOS 10.13.6, but could also compile without the PSL one (presumably as he didnt install it).

Tue, Nov 13, 10:39 AM

Mon, Nov 12

elexis added inline comments to D1649: Update client loading state upon client disconnect too.
Mon, Nov 12, 9:54 PM
elexis added inline comments to D1556: NetClient and NetServer state comments, renames and cleanup.
Mon, Nov 12, 9:26 PM
elexis added inline comments to D1623: Fix missing translate call in modmod.
Mon, Nov 12, 9:10 PM
elexis accepted D1516: [NetServer] Split `OnInGame` function.

Yes, this split is overdue! There is nothing else to split, all lines that I read are copy&pasted correctly, I hope the other ones are copy&pasted correctly too, variable and function names are ideal.

Mon, Nov 12, 5:17 PM
elexis added inline comments to D1556: NetClient and NetServer state comments, renames and cleanup.
Mon, Nov 12, 5:07 PM
elexis added inline comments to D1649: Update client loading state upon client disconnect too.
Mon, Nov 12, 4:43 PM
elexis added inline comments to D1623: Fix missing translate call in modmod.
Mon, Nov 12, 4:30 PM
elexis added a comment to D1362: Remove the list of hardcoded training hotkeys..
In D1362#64805, @elexis wrote:

(There is a patch that assings hotkeys from JS and uses a loop for these.)

(I meant it not figuratively, but the patch fixing #2604. Trying to locate my version of the fix, it's actually in the unreleased patches to #5322. I guess they're not getting better if they're not being published, but who cares. Said diff changes C++ code to allow JS to insert hotkeys, allowing removal of all fixed XML while still using the event/subscription model.)

Mon, Nov 12, 4:23 PM

Nov 11 2018

elexis added inline comments to D1623: Fix missing translate call in modmod.
Nov 11 2018, 2:22 AM

Nov 10 2018

elexis added a comment to D1631: TileClass optimization..

Checked the performance benefit of the proposed early-return in TileClass: P142

Nov 10 2018, 5:07 PM