Page MenuHomeWildfire Games

elexis (Alexander H)
User

Projects

User Details

User Since
Dec 21 2016, 3:52 PM (130 w, 5 d)

Recent Activity

Today

elexis added inline comments to rP21847: Rewrite the prelobby pages and add the Terms of Service, Terms of Use and the….
Tue, Jun 25, 3:06 PM
elexis added a comment to rP22341: Fixes black water glitches for certain wind angles with the approximate….

Fix for rP15576.

Tue, Jun 25, 6:27 AM
elexis accepted D2009: Add a "new" checkbox to the map settings tab.
Tue, Jun 25, 6:16 AM · Restricted Project, macOS Developers
elexis added a comment to rP22331: Roman helmets texture recolor.

Fixes rP22082.

Tue, Jun 25, 6:11 AM
elexis accepted D2009: Add a "new" checkbox to the map settings tab.
  • Task of the ticket is reasonable.
  • Task of the ticket was extended to entail the Trigger keywords.
  • Review remarks were addressed.
  • Didn't get more compiler warnings than I already had before.
  • Tested, works in accordance with the gamesetup filters.
  • Thanks for the patch!
  • Fix that map -> maps typo before the commit and perhaps 5 -> 15 for better visual layout
Tue, Jun 25, 6:03 AM · Restricted Project, macOS Developers
elexis added a comment to rP22323: Further cleanup of MikkTSpace.

Pass pointers instead of arrays

How are arrays passed?

Tue, Jun 25, 5:46 AM
elexis added a comment to rP22318: Re-upload the uncompressed PNG files for the previous commits..

(Fixes rP22317)

Tue, Jun 25, 5:30 AM
elexis added a comment to D2009: Add a "new" checkbox to the map settings tab.

Looks good, I got some compile warnings however (gcc 9.1.0):

Tue, Jun 25, 5:22 AM · Restricted Project, macOS Developers
elexis added a comment to D2009: Add a "new" checkbox to the map settings tab.

You may want to add the trigger keyword, since there is also a filter for that in the gamesetup.

Tue, Jun 25, 4:59 AM · Restricted Project, macOS Developers
elexis raised a concern with rP22386: 3 New temperate maps by BigTiger..

Only a small concern, but something that should be fixed for the release. The maps should have the "new" keyword, so that they appear in the "new maps" filter.

Tue, Jun 25, 4:18 AM
elexis added a comment to rP22315: New horse and cattle fauna template corrections.

Fixes rP22257, rP22260.

Tue, Jun 25, 3:27 AM
elexis added a comment to rP22314: Fix a crash on some system when Alt-tabbing during game setup..

@Stan what does "break sound for me" mean, no sound at all (on windows?)? Is this reproduced by others (on windows)?

Tue, Jun 25, 3:26 AM
elexis awarded rP22308: Add a build flag to prefer locally-built libraries (linux/bsd systems) a Like token.
Tue, Jun 25, 2:52 AM

Yesterday

elexis added a comment to rP22312: Don't clear pathnames in vfs::GetPathnames so it can be called several times..

(Audit comment at D1914#83746)

Mon, Jun 24, 11:45 PM
elexis added a comment to D1914: Don't clear pathnames in vfs::GetPathnames so it can be called several times..

grep for GetPathnames, notice that this is safe.

Performed, confirmed grep -R 'GetPathnames' -B1

i18n/L10n.cpp-	std::wstring dictName = GetFallbackToAvailableDictLocale(icu::Locale::createCanonical(locale.c_str()));
i18n/L10n.cpp:	vfs::GetPathnames(g_VFS, L"l10n/", dictName.append(L".*.po").c_str(), filenames);
--
i18n/L10n.cpp-	{
i18n/L10n.cpp:		if (vfs::GetPathnames(g_VFS, L"l10n/", L"long.*.po", filenames) < 0)
--
i18n/L10n.cpp-		std::wstring dictName = GetFallbackToAvailableDictLocale(currentLocale);
i18n/L10n.cpp:		if (vfs::GetPathnames(g_VFS, L"l10n/", dictName.append(L".*.po").c_str(), filenames) < 0)
--
i18n/L10n.cpp-	VfsPaths filenames;
i18n/L10n.cpp:	if (vfs::GetPathnames(g_VFS, L"l10n/", L"*.po", filenames) < 0)
--
graphics/MapGenerator.cpp-	// Load all scripts in mapgen directory
graphics/MapGenerator.cpp:	Status ret = vfs::GetPathnames(g_VFS, path, L"*.js", pathnames);
--
graphics/ColladaManager.cpp-		VfsPaths pathnames;
graphics/ColladaManager.cpp:		if (vfs::GetPathnames(m_VFS, L"art/skeletons/", L"*.xml", pathnames) < 0)
--
graphics/ColladaManager.cpp-			VfsPaths paths;
graphics/ColladaManager.cpp:			if (vfs::GetPathnames(m_VFS, L"art/skeletons/", L"*.xml", paths) != INFO::OK)
--
renderer/PostprocManager.cpp-	VfsPaths pathnames;
renderer/PostprocManager.cpp:	if (vfs::GetPathnames(g_VFS, path, 0, pathnames) < 0)
--
gui/GUIManager.cpp-			VfsPaths pathnames;
gui/GUIManager.cpp:			vfs::GetPathnames(g_VFS, directory, L"*.xml", pathnames);
--
gui/CGUI.cpp-				VfsPaths pathnames;
gui/CGUI.cpp:				vfs::GetPathnames(g_VFS, directory, L"*.xml", pathnames);
--
gui/CGUI.cpp-		VfsPaths pathnames;
gui/CGUI.cpp:		vfs::GetPathnames(g_VFS, directory, L"*.js", pathnames);
--
scriptinterface/ScriptInterface.cpp-	VfsPaths pathnames;
scriptinterface/ScriptInterface.cpp:	vfs::GetPathnames(g_VFS, L"globalscripts/", L"*.js", pathnames);
--
lib/file/vfs/vfs_util.cpp-
lib/file/vfs/vfs_util.cpp:Status GetPathnames(const PIVFS& fs, const VfsPath& path, const wchar_t* filter, VfsPaths& pathnames)
--
lib/file/vfs/vfs_util.h-
lib/file/vfs/vfs_util.h:extern Status GetPathnames(const PIVFS& fs, const VfsPath& path, const wchar_t* filter, VfsPaths& pathnames);
--
lib/file/vfs/tests/test_vfs_util.h-		VfsPaths pathNames;
lib/file/vfs/tests/test_vfs_util.h:		vfs::GetPathnames(g_VFS, "", L"*.txt", pathNames);
lib/file/vfs/tests/test_vfs_util.h-		TS_ASSERT_EQUALS(pathNames.size(), 3);
lib/file/vfs/tests/test_vfs_util.h:		vfs::GetPathnames(g_VFS, "sub_folder_a/", L"*.txt", pathNames);
lib/file/vfs/tests/test_vfs_util.h-		TS_ASSERT_EQUALS(pathNames.size(), 5);
lib/file/vfs/tests/test_vfs_util.h:		vfs::GetPathnames(g_VFS, "sub_folder_b/", L"*.txt", pathNames);
--
simulation2/Simulation2.cpp-	VfsPaths pathnames;
simulation2/Simulation2.cpp:	if (vfs::GetPathnames(g_VFS, path, L"*.js", pathnames) < 0)
--
simulation2/Simulation2.cpp-	VfsPaths pathnames;
simulation2/Simulation2.cpp:	Status ret = vfs::GetPathnames(g_VFS, path, L"*.json", pathnames);
--
simulation2/components/CCmpAIManager.cpp-		VfsPaths pathnames;
simulation2/components/CCmpAIManager.cpp:		if (vfs::GetPathnames(g_VFS, L"simulation/ai/" + moduleName + L"/", L"*.js", pathnames) < 0)
--
simulation2/components/tests/test_scripts.h-		VfsPaths paths;
simulation2/components/tests/test_scripts.h:		TS_ASSERT_OK(vfs::GetPathnames(g_VFS, L"simulation/components/tests/", L"test_*.js", paths));
--
ps/SavedGame.cpp-	VfsPaths pathnames;
ps/SavedGame.cpp:	err = vfs::GetPathnames(g_VFS, "saves/", L"*.0adsave", pathnames);
Mon, Jun 24, 11:44 PM
elexis raised a concern with rP22304: Allow entities to be affected by Status Effects from ranged attacks..

StatusEffects name is problematic I'm afraid.

Mon, Jun 24, 6:49 PM
elexis added a comment to rP22305: Remove 'Async' from short/long path requests names.

Reviewed By: Kuba386

Would have been good if there was mentioned which aspects were reviewed, what was tested.

Mon, Jun 24, 6:27 PM
elexis added a comment to rP22302: Use pkg-config where possible instead of hard-coding or library-specific….

Without having looked at detail, the objectives of these two commits look very good. If I understand correctly rP22302 was only the consequential cleanup of rP21865, but did not fix some reported crash on Slackware on the forums (as rP22302 already fixed that), correct? (Otherwise it should be added to Alpha24)

Mon, Jun 24, 5:19 PM
elexis awarded rP22302: Use pkg-config where possible instead of hard-coding or library-specific… a Like token.
Mon, Jun 24, 4:49 PM
elexis added a comment to rP22300: Early-exit when destroying invalid entities (INVALID_ENTITY, already destroyed…).

(Audit comment at https://code.wildfiregames.com/D1736#83668)

Mon, Jun 24, 4:21 PM
elexis added a comment to D1736: Early-exit when destroying invalid entities (INVALID_ENTITY, already destroyed…).

Destroying INVALID_ENTITY is valid and should do nothing.
The current code will send MT_Destroy messages when doing this, which is un-necessary work and feels kind of broken to me.
Early-exit instead.

Mon, Jun 24, 4:21 PM
elexis raised a concern with rP22299: ShouldConsiderOurselvesAtDestination renamed to….

ShouldConsiderOurselvesAtDestination from rP17226.
Agree with that previous name being broken because this is only about the unit, not about the reader.

Mon, Jun 24, 4:07 PM
elexis added inline comments to rP22298: Health.js cleanup: add tests, add an "IsInjured" function, use this.hitpoints….
Mon, Jun 24, 3:59 PM
elexis added a comment to rP22296: Add unit motion integration test map.

unit_motion_integration_test.js

trigger scripts usually contain the name triggers:

./random/elephantine_triggers.js
./random/extinct_volcano_triggers.js
./random/survivalofthefittest_triggers.js
./random/wall_demo_triggers.js
./random/danubius_triggers.js
./random/jebel_barkal_triggers.js
./random/polar_sea_triggers.js

Except for scenario folders:

./unit_motion_integration_test.js
./treasure_islands.js
./Units_demo.js
./Triggers_demo.js
./Cinema_Demo.js

(But I technically don't want to spawn another rename clean thing now)

Mon, Jun 24, 3:26 PM
elexis added a comment to rP22295: Target build version explicitly for Xcode.

Reviewed By: Wraitii

Reviewed By is reserved for people other than the author.
Comments By: Itms can be added when people influenced the patch without having accepting it.

Mon, Jun 24, 3:15 PM
elexis added a comment to rP22292: Use Alexandermb's shield for the gaul theatron..

refs rP22105.

Mon, Jun 24, 3:08 PM
elexis added a comment to rP22278: Decouple long and hierarchical pathfinders to an extent..

(I didn't check the includes)

Mon, Jun 24, 2:38 PM
elexis added a comment to rP22270: Fix last checkrefs.pl warning because the cavalry variant was using an….

Fixes rP22269.

Mon, Jun 24, 12:47 PM
elexis added a comment to rP22266: moves territory_pull.xml from other/ to special/ and updates the only file in….

Regardless of whether and how special/ is renamed, territory_pull.xml must be moved to a different folder.

Mon, Jun 24, 12:45 PM
elexis added a comment to rP22261: Fix issue with seleucid cavalry armor..

Fixes rP22260.

Mon, Jun 24, 12:22 PM
elexis added a comment to rP22260: *New Horse models.

refs https://wildfiregames.com/forum/index.php?/topic/25397-committed-horse-update-20-retexture/

Mon, Jun 24, 12:04 PM
elexis added a comment to rP22259: Fix the kush background stuttering..

Fixes rP21953.

Mon, Jun 24, 11:55 AM
elexis added inline comments to D1939: redo rP21036, Create a ConfigDB_CreateAndWriteValueToFile function to absorb some duplication in the gui.
Mon, Jun 24, 11:47 AM
elexis added a comment to D1463: Unit for summary charts time axis.

hh:mm would seem appropriate on the graphs, and the axis labels usually appears on the graph axis.

Mon, Jun 24, 4:25 AM
elexis added a comment to rP22266: moves territory_pull.xml from other/ to special/ and updates the only file in….

No notes.

Mon, Jun 24, 4:19 AM
elexis added inline comments to D2007: standardize formation tooltips.
Mon, Jun 24, 4:11 AM
elexis accepted rP22151: New berry bushes by BigTiger.

If you really want it to be two variations I would suggest to increase the color differences so much that it actually becomes noticeable, even if it doesn't have to be so glaring differences that it becomes considered a different species by the player.
In doubt artistic freedom holds.

Mon, Jun 24, 4:06 AM

Sun, Jun 23

elexis added a comment to rP22245: Add special scaffoldings for the wall towers as well. Based on a model by….

The tower has 2x2 size, the foundation 3x3, so it appears too large, especially if the tower would be very close to adjacent buildings - then the foundation leaps into those buildings. But I guess it's not so bad, there are some decoartives on that additional margin.

Sun, Jun 23, 1:52 PM
elexis raised a concern with rP22241: Add a map to be able to test which foundation fits best an actor..
Sun, Jun 23, 1:44 PM
elexis added a comment to rP22237.

in rP22235

Sun, Jun 23, 1:27 PM
elexis added a comment to rP22222: Retexture: Illyrian helmet (Bronze and Gold variants).

(refs rP20747)

Sun, Jun 23, 1:14 PM
elexis added a comment to rP22151: New berry bushes by BigTiger.

Those are two different areas of the picture.

Sun, Jun 23, 12:55 PM
elexis added a comment to rP22151: New berry bushes by BigTiger.
In rP22151#34202, @Stan wrote:

The hue is slightly different.

Sun, Jun 23, 12:35 PM

Sat, Jun 22

elexis added a comment to rP22151: New berry bushes by BigTiger.

rP22394 fixes the duplicates from rP22383, but those two files mentioned still look the same?

Sat, Jun 22, 11:46 PM
elexis added a comment to rP22206: Add a few assertions to pathfinder tests, fix the disabled tests..

A --slow-tests command line argument could be used to run them without the need to compile again.

Sat, Jun 22, 10:05 PM
elexis added a comment to rP22194: cattails fix.

(Fixes rP22107.)

Sat, Jun 22, 9:38 PM
elexis added a comment to rP22186: New Texture: Iberian Units Retexture.

(The images take a bit to load, jump to page 4 to see the images: https://wildfiregames.com/forum/index.php?/topic/24988-task-iberian-units-update/&do=findComment&comment=372793 )

Sat, Jun 22, 9:28 PM
elexis added a comment to rP22171: Quarry stone.

These are only the small cut stones (e.g. the one lying on the floor), not the entire quarry:
https://wildfiregames.com/forum/index.php?/topic/25612-mines-stone-and-metal/&do=findComment&comment=372252

Sat, Jun 22, 9:12 PM
elexis added a comment to rP22172: fixed anchor points on quarry entities.

(Fixes rP22171)

Sat, Jun 22, 8:59 PM
elexis added a comment to rP22160: Fix berry bushes smoothing groups,.

refs rP22151

Sat, Jun 22, 8:04 PM
elexis raised a concern with rP22151: New berry bushes by BigTiger.

Renames to berry_bush_01.png and adds a copy to berry_bush_02.png?

Sat, Jun 22, 7:34 PM
elexis added a comment to rP22151: New berry bushes by BigTiger.

https://wildfiregames.com/forum/index.php?/topic/25431-task-trees/&do=findComment&comment=371865

Sat, Jun 22, 7:26 PM
elexis added a comment to rP22146: Updated date palms.

https://wildfiregames.com/forum/index.php?/topic/25431-task-trees/page/6/&tab=comments#comment-371655

Sat, Jun 22, 7:06 PM
elexis added a comment to rP22142: Palmyra Palms.

https://wildfiregames.com/forum/index.php?/topic/25431-task-trees/&do=findComment&comment=371386

Sat, Jun 22, 7:02 PM
elexis added a comment to rP22141: Doum and Nipa palms, Normal maps and specmaps for the new trees.

Nipa palms:
https://wildfiregames.com/forum/index.php?/topic/25431-task-trees/&do=findComment&comment=371337

Sat, Jun 22, 7:00 PM
elexis added a comment to rP22139: Mangroves.

See https://wildfiregames.com/forum/index.php?/topic/25431-task-trees/&do=findComment&comment=371194

Sat, Jun 22, 6:54 PM
elexis added a comment to rP22136: Baobab age variants, Bamboos and banyans.

Banyan Trees:
https://wildfiregames.com/forum/index.php?/topic/25431-task-trees/page/4/&tab=comments#comment-371125

Sat, Jun 22, 6:49 PM
elexis added a comment to rP22130: Normal edit modified previous trees, small UV edits on the baobabs.

Fixes rP22124, rP22107.

Sat, Jun 22, 6:34 PM
elexis added a comment to D1509: Page Down / Page Up Rotates Entities in Editor Even Without Focus.

(Might be worth a comment in the code if this is a common pitfall where to put the key code)

Sat, Jun 22, 6:30 PM
elexis added a comment to rP22107: Black Pines, Cattails, Atlas Cedars, and Saplings.

Black Pines:
https://wildfiregames.com/forum/index.php?/topic/25431-task-trees/&do=findComment&comment=370146

Sat, Jun 22, 6:23 PM
elexis awarded rP22116: Nuke the misleading Structure_Defence from the wallset template name a Like token.
Sat, Jun 22, 5:44 PM
elexis awarded rP22115: Move the fish template under template_gaia since fish is a resource like trees… a Like token.
Sat, Jun 22, 5:44 PM
elexis added a comment to rP22109: Add the gaul assembly to the Sandbox - Gauls map.

Refs rP22105.

Sat, Jun 22, 5:41 PM
elexis added a comment to rP22108: Fix gaul assembly's template. The civ was incorrect and it was missing a….

Fixes rP22105.

Sat, Jun 22, 5:40 PM
elexis added a comment to rP22081: Rome Testudo & Anti-Cavalry formations animations:.

(refs https://wildfiregames.com/forum/index.php?/topic/23578-rome-legionary/page/7/&tab=comments#comment-349249)

Sat, Jun 22, 4:43 PM
elexis added a comment to rP21953: New Kushite Background by Pedro Blanco.

No related forum thread, only a private conversation relayed to Wildfire Games at https://wildfiregames.com/forum/index.php?/topic/24839-art-contributor-pedro_blanco/
refs https://wildfiregames.com/forum/index.php?/profile/28119-pedro_blanco/

Sat, Jun 22, 4:38 PM
elexis added a comment to rP21948: Improved deer textures by Wijitmaker and I..

Refs from IRC today:

(04:31:42 PM) Stan-laptop: but I remember looking at https://wildfiregames.com/forum/index.php?/topic/744-animals/&tab=comments#comment-7878
(04:32:08 PM) Stan-laptop: Sending a mail to Jason to enquire whether either the texture in that thread or the one in art_source was under a compatible license
(04:32:12 PM) Stan-laptop: he said he made it

Sat, Jun 22, 4:35 PM
elexis added a comment to rP22082: Rome helmets (Also reverting a deleted song in rome civ template):.

refs https://wildfiregames.com/forum/index.php?/topic/24494-task-roma-helmets/

Sat, Jun 22, 4:22 PM
elexis added a comment to rP21995: New Texture: Celtic Elite Units.

(Only clothing updates in this commit)

Sat, Jun 22, 4:19 PM
elexis added a comment to rP22098: Footpaths and papyrus files+actors.

Paths:
https://wildfiregames.com/forum/index.php?/topic/25431-task-trees/&do=findComment&comment=370146

Sat, Jun 22, 4:14 PM
elexis added a comment to rP22097: Reduce Ships Update specular map texture size as conversed with Stan..

Ships Update specular map

(from rP22095)

Sat, Jun 22, 4:09 PM
elexis added a comment to rP22095: Ships update.

Thanks!

Sat, Jun 22, 3:43 PM
elexis added inline comments to rP22081: Rome Testudo & Anti-Cavalry formations animations:.
Sat, Jun 22, 1:48 PM
elexis raised a concern with rP22081: Rome Testudo & Anti-Cavalry formations animations:.

I wanted to see the squat, but I didn't test the repository of this commit, perhaps I missed 0ad dank meme material.
Testing with r22393 revealed some bugs, but they are probably not related to this commit (a segfault and units often not attacking anymore).

Sat, Jun 22, 1:46 PM

Fri, Jun 21

elexis added a comment to D1990: Add Krinkle to 0 A.D.'s programming credits.

(following rP22378, rP22380)

Fri, Jun 21, 9:46 PM
elexis added a comment to rP22006: Clean up and speed up the water manager distance computations.

Either the function RecomputeBlurredNormalMap is considered obsolete as of rP15484, then rP15484 / rP22006 should have deleted not only some parts of it but all of it, or that code was useful and those two commits shouldn't have removed the calls.

Fri, Jun 21, 9:42 PM
elexis added a comment to D1985: Skybox calculation - fix regression of rP22039 introduced in rP22297.

(1) So that the one reading this diff knows what's happening.
(2) So that cross-references are inserted

Fri, Jun 21, 9:39 PM
elexis added a comment to rP22029: Change internals of EntityMap to use an std::vector.

Reverted by rP22032.

Fri, Jun 21, 8:16 PM
elexis added inline comments to rP15484: Further WIP water improvements. Add 3 different textures for different looks..
Fri, Jun 21, 8:14 PM
elexis added a comment to rP22006: Clean up and speed up the water manager distance computations.

the other doesn't need to be called (apparently, since I removed coastal foam, which tbh I don't remember doing).

Coastal foam introduced in rP15576, seems to be present still, seems to be unrelated?
RecomputeBlurredNormalMap was introduced by rP15473, the only consumer of m_BlurredNormalMap was removed by rP15484.

Fri, Jun 21, 8:14 PM
elexis added inline comments to rP22016: Properly reset rally points on ownership changes..
Fri, Jun 21, 7:27 PM
elexis added a comment to D1985: Skybox calculation - fix regression of rP22039 introduced in rP22297.

(As mentioned byVladislav on IRC (http://irclogs.wildfiregames.com/2019-06/2019-06-21-QuakeNet-%230ad-dev.log) and in rP22297, this diff is correct because rP22297 reverted (and whitespace-formatted?) a hunk that was removed in rP22039.)

Fri, Jun 21, 6:57 PM
elexis raised a concern with rP22006: Clean up and speed up the water manager distance computations.
Fri, Jun 21, 3:52 PM
elexis added a comment to D78: Speed up the water manager recomputations.
In D78#14568, @mimo wrote:

while at it, here are a few defects i reported to you a long time ago on irc. Would be good to have a look at it some time

Fri, Jun 21, 3:48 PM
elexis added a comment to rP22006: Clean up and speed up the water manager distance computations.

(apparently, since I removed coastal foam, which tbh I don't remember doing).

I also can't remember everything I committed immediately sometimes, but why mention this in the commit message, which should inform the reader of the relevant information, so it leaves a worse impression to the reader than it needs to. Just refs the commit id. A commit message shouldn't state all the things one doesn't know, because one should have found the answers to these questions prior to the commit.

Fri, Jun 21, 3:33 PM
elexis added a comment to rP22004: Clean up and fix height of water vertex shader..

Tested on a different setup again, seems to look better than the last test I did in D1402, so the change seems right.
The commit actually reverts a change introduced by rP15576.

Fri, Jun 21, 3:10 PM
elexis awarded rP21970: Celtic helmet's Update (Including New Battersea Shield) a Like token.
Fri, Jun 21, 1:47 PM
elexis awarded rP21968: Fox Update: a Orange Medal token.
Fri, Jun 21, 1:46 PM
elexis added a comment to rP21966: Fix an incorrect credit due to a misunderstanding..

refs rP21965

Fri, Jun 21, 1:42 PM
elexis awarded rP21965: New Persian Farsi voices by dMZeroCold & dMAthena. a Like token.
Fri, Jun 21, 1:39 PM
elexis raised a concern with rP22297: Water GLSL shader improvements around reflections and whitespace fixes..

This uses the skybox for reflections when reflections are disabled

Fri, Jun 21, 12:38 PM

Thu, Jun 20

elexis added a comment to D1604: Make capturing optional.

I couldn't convince myself that it would be right to support disabling capturing in the gamesetup for vanilla. But for mods it would be good to provide an easy way to implement that.

Thu, Jun 20, 9:21 PM

Tue, Jun 18

elexis added a comment to D2000: standardize aura format.

spaces inside brackets, e.g. [ "Ship" ] instead of ["Ship"]

(The JS code has these spaces for obejcts but not arrays, Coding_Conventions#JavaScript recommends it for objects but doesn't speak on arrays. So if you would want to make it more consistent, JS arrays be updated too or those spaces ommitted. I suppose one can add that to the CC so that people don't have to become familiar with the large codebase in order to be able to apply the consistency rule of the CC.)

Tue, Jun 18, 11:19 PM

Sun, Jun 16

elexis resigned from D1754: Pass an argument to GUI events / SendEventToAll, remove loading screen progess workaround.
Sun, Jun 16, 10:06 PM

Sat, Jun 15

elexis added a comment to rP22003: Add "mul_round" op to template parsing to support multiplying-then-rounding..

I also don't care that much about this topic - apparently no-one did either since D268 never got much attention except from leper and the followup neither.

Sat, Jun 15, 8:43 PM
elexis added a comment to rP22003: Add "mul_round" op to template parsing to support multiplying-then-rounding..

We support integers just fine in our XML schemas. The problem is that multiplying an integer by a decimal sometimes leads to non-integer values.

As far as I understood the idea is to be able to support op="mul" and op="add" with integer types and do the rounding if the type is an integer, otherwise don't do the rounding.
This way the schema / template can continue to use the integer type if that is the datatype intended by the template author.

Sat, Jun 15, 8:14 PM
elexis raised a concern with rP22003: Add "mul_round" op to template parsing to support multiplying-then-rounding..
  • Integer/Schema:

Supporting an integer type in the schema sounds right regardless which templates 0ad provides.
I'm not so sure whether that wouldn't cover the feature better than mul_round.
The reason why someone would want to use mul_round in the template is that they want to specify an integer.

Sat, Jun 15, 7:58 PM
elexis updated the Trac tickets for D268: Add "mul_round" op to template parsing to support multiplying with integer types..
Sat, Jun 15, 7:08 PM
elexis raised a concern with rP21998: Do not actually Kill in debug_break() in non-debug binaries.

When I compile in release mode on arch linux:

Sat, Jun 15, 5:48 PM
elexis added inline comments to D1661: lobby bots systemd service.
Sat, Jun 15, 4:14 PM