Page MenuHomeWildfire Games

elexis (Alexander H)
User

Projects

User Details

User Since
Dec 21 2016, 3:52 PM (161 w, 2 d)

Recent Activity

Yesterday

elexis added a comment to rP23430: Gamesetup slider support, use it for Ceasefire, RelicCount, RelicDuration….

I wouldn't mind switching to nanis theme under the condition that it uses a color style that fits to the existing theme, i.e. using gold for enabled controls and gray for disabled ones, no? and secondly the rectangular shape looks more brutal than the current slider sprite. so if that square rectangle shape would be changed, I might agree with that diff. One advantage of nanis proposal might be that the area of the slider selector is larger, so it may be easier to use / move it (or not, I didnt look at the size property in the xml).

Fri, Jan 24, 6:08 PM
elexis added a comment to rP23430: Gamesetup slider support, use it for Ceasefire, RelicCount, RelicDuration….

Then one could at most use a 5 minute step dropdown, but that would also not allow chosing 2 minutes or 38 minutes for example.
It is also easier to pick values with a slider if there are 60 of them.

True; the question is how likely it is people would want 38 minutes, rather than 40.

Also dropdowns require hardcoding the values whereas a slider only has 3 datapoints (min, max, step)

Fri, Jan 24, 2:49 PM
elexis added a comment to rP23430: Gamesetup slider support, use it for Ceasefire, RelicCount, RelicDuration….

The relic and wonder time go from 0 to 60 minutes, ceasefire from 0 to 45; why not 60 as well, for consistency? 60 minutes ceasefire used to be an option.

The more narrow the range, the easier it is to pick values.
I have seen maybe 300 matches with Victory durations and they were usually 50minutes, since for shorter times it was too hard to attack the enemy, as it is easy to turtle up.
Ceasefire has the main use case at < 5 minutes on nomad.
(See also irc discussion with Vladislav linked)

Fri, Jan 24, 1:26 PM
elexis planned changes to D406: Add a steps param to sliders.
Fri, Jan 24, 3:42 AM
elexis updated the diff for D406: Add a steps param to sliders.

First proof of concept with stepWidth

Fri, Jan 24, 3:42 AM
elexis commandeered D406: Add a steps param to sliders.

From 2017-12-06-QuakeNet-#0ad-dev.log:

20:14 < temple> stepWidth sounds easier

Fri, Jan 24, 3:39 AM
elexis committed rP23435: CSlider inherits IGUIButtonBehavior to gains button sounds, press/release….
CSlider inherits IGUIButtonBehavior to gains button sounds, press/release…
Fri, Jan 24, 1:57 AM
elexis closed D2592: CSlider IGUIButtonBehavior inheritance to gain Sound, Press and Release events.
Fri, Jan 24, 1:57 AM
elexis added a comment to D2592: CSlider IGUIButtonBehavior inheritance to gain Sound, Press and Release events.

nani posted more review comments in a PM conversation, most importantly motivating me to create the second iteration of the patch, also he tested the patch.

Fri, Jan 24, 1:53 AM

Thu, Jan 23

elexis added a comment to D2568: gui: remove empty space between logo and buttons.

Perhaps it's easier if you'd state the percentages how you'd like to distribute the empty space?

(Finding good numbers would take some time, and to me its currently not broken.)

Thu, Jan 23, 5:15 PM
elexis updated the diff for D2592: CSlider IGUIButtonBehavior inheritance to gain Sound, Press and Release events.

Simplify CSlider code following the IGUIButtonBehavior inheritance by deleting m_IsPressed which is now redundant with m_Pressed from the inherited class.

Thu, Jan 23, 5:06 PM
elexis committed rP23434: Gamestup option to select the time the sea level starts to rise on Extinct….
Gamestup option to select the time the sea level starts to rise on Extinct…
Thu, Jan 23, 4:58 PM
elexis closed D2593: Map specific Gamesetup option: SeaLevelRise for Extinct Volcano map.
Thu, Jan 23, 4:58 PM
elexis updated the Trac tickets for D2593: Map specific Gamesetup option: SeaLevelRise for Extinct Volcano map.
Thu, Jan 23, 4:54 PM
elexis added inline comments to D2593: Map specific Gamesetup option: SeaLevelRise for Extinct Volcano map.
Thu, Jan 23, 4:50 PM
elexis updated the Trac tickets for D2476: Remove obsolete clipboard and GetVideoMode platform-specifics.
Thu, Jan 23, 3:33 PM
elexis retitled D2476: Remove obsolete clipboard and GetVideoMode platform-specifics from Remove obsolete platform-specifics to Remove obsolete clipboard and GetVideoMode platform-specifics.
Thu, Jan 23, 3:32 PM
elexis added a comment to D2476: Remove obsolete clipboard and GetVideoMode platform-specifics.

This patch fixes the "copy twice" bug described in #3145!
And the crash over there can't be reproduced by me on arch, nor by go2die on mint 19.3 Tricia.

Thu, Jan 23, 3:30 PM
elexis updated the Trac tickets for D2476: Remove obsolete clipboard and GetVideoMode platform-specifics.
Thu, Jan 23, 3:28 PM
elexis updated the diff for D2593: Map specific Gamesetup option: SeaLevelRise for Extinct Volcano map.

Missing file

Thu, Jan 23, 9:19 AM
elexis added inline comments to D2593: Map specific Gamesetup option: SeaLevelRise for Extinct Volcano map.
Thu, Jan 23, 9:18 AM
elexis created D2593: Map specific Gamesetup option: SeaLevelRise for Extinct Volcano map.
Thu, Jan 23, 9:14 AM
elexis updated the test plan for D2592: CSlider IGUIButtonBehavior inheritance to gain Sound, Press and Release events.
Thu, Jan 23, 6:21 AM
elexis created D2592: CSlider IGUIButtonBehavior inheritance to gain Sound, Press and Release events.
Thu, Jan 23, 6:19 AM

Wed, Jan 22

elexis committed rP23430: Gamesetup slider support, use it for Ceasefire, RelicCount, RelicDuration….
Gamesetup slider support, use it for Ceasefire, RelicCount, RelicDuration…
Wed, Jan 22, 10:38 PM
elexis closed D2571: Gamesetup support for sliders, use it for Ceasefire, RelicCount, RelicDuration, WonderDuration.
Wed, Jan 22, 10:38 PM
elexis added a comment to D2571: Gamesetup support for sliders, use it for Ceasefire, RelicCount, RelicDuration, WonderDuration.

I like the example in the description though I think it could a bigger top padding.

I could move the value label 1px further below, but if there is a dropdown coming below the dropdown, it will start to collapse with that. There is simply too few space, which is why the setting height was increased from 32px to 36px already:

Wed, Jan 22, 10:26 PM
elexis updated the summary of D2571: Gamesetup support for sliders, use it for Ceasefire, RelicCount, RelicDuration, WonderDuration.
Wed, Jan 22, 10:21 PM
elexis added inline comments to D2571: Gamesetup support for sliders, use it for Ceasefire, RelicCount, RelicDuration, WonderDuration.
Wed, Jan 22, 10:21 PM
elexis updated the summary of D2571: Gamesetup support for sliders, use it for Ceasefire, RelicCount, RelicDuration, WonderDuration.
Wed, Jan 22, 10:07 PM
elexis added a comment to D2571: Gamesetup support for sliders, use it for Ceasefire, RelicCount, RelicDuration, WonderDuration.
  • Discussed with Vladislav on http://irclogs.wildfiregames.com/2020-01/2020-01-19-QuakeNet-%230ad-dev.log on the problem that not all values are chosen with the same frequency by users
  • The UI theme was discussed with nani in a PM session today. nani proposed that the vertical center axis of the label on the left should be on the same vertical center as the average of the slider + label on the right side:
		Slider
Label:   -----------
		Number

which IMO looks worse.

Wed, Jan 22, 10:04 PM
elexis retitled D2571: Gamesetup support for sliders, use it for Ceasefire, RelicCount, RelicDuration, WonderDuration from Gamesetup: Use sliders for Ceasefire and VictoryDuration to Gamesetup support for sliders, use it for Ceasefire, RelicCount, RelicDuration, WonderDuration.
Wed, Jan 22, 9:56 PM
elexis updated the summary of D2571: Gamesetup support for sliders, use it for Ceasefire, RelicCount, RelicDuration, WonderDuration.
Wed, Jan 22, 8:05 PM
elexis updated the diff for D2571: Gamesetup support for sliders, use it for Ceasefire, RelicCount, RelicDuration, WonderDuration.

Rebase, add value label, use it for RelicCount too

Wed, Jan 22, 8:03 PM
elexis committed rP23429: Disable Quicksave during multiplayer, since the feature is not implemented and….
Disable Quicksave during multiplayer, since the feature is not implemented and…
Wed, Jan 22, 3:08 PM
elexis closed D2584: Disable QuickLoad during multiplayer.
Wed, Jan 22, 3:08 PM
elexis added inline comments to D2584: Disable QuickLoad during multiplayer.
Wed, Jan 22, 2:59 PM

Tue, Jan 21

elexis added a comment to D2584: Disable QuickLoad during multiplayer.
In D2584#108308, @Stan wrote:

I think it would be nicer to have the MP savegame features

Tue, Jan 21, 2:07 PM
elexis updated the summary of D2584: Disable QuickLoad during multiplayer.
Tue, Jan 21, 1:49 PM

Mon, Jan 20

elexis added a comment to D2568: gui: remove empty space between logo and buttons.

Perhaps the logo can be moved something like 25-100px depending on resolution, perhaps a percent number to the bottom, and then some margin to the buttons?

Mon, Jan 20, 6:06 PM
elexis added a comment to D2585: Cavalry archer speed adjustment.

Test plan: Changes were tested on the balance mod.

(I guess it takes a bit of time, but it wouldn't hurt to document the test sample (i.e. approximate number of matches, list of participating players who may be considered either capable of judging or capable of playing representatively for competitive players. If its easier, one could also just upload replays and perhaps a link to the mod. The purpose of the list of test participant would allow (1) the reviewers to determine in how far the patch was tested and (2) later consumers of the patches (a24 players and devs) to find identify which players were capable of judging, or what might have gone wrong or right in case it was a fail or success.)

Mon, Jan 20, 5:37 PM
elexis added a comment to D2568: gui: remove empty space between logo and buttons.

This is the patch I uploaded at https://code.wildfiregames.com/rP23387#40853 so it would be correct to credit that.

did you mean you want your username explicitly mentioned?

Yes. (I don't care about this one line changed here, just in general. Discussion != patch)

Mon, Jan 20, 5:26 PM
elexis added inline comments to rP23176: Single Player → single-player.
Mon, Jan 20, 2:34 PM
elexis created D2584: Disable QuickLoad during multiplayer.
Mon, Jan 20, 1:44 PM
elexis added a comment to D2567: Splits debug display of frustums.

(or posting that you accept it so that he can close the revision proposal since it was committed in rP23395, to avoid ambiguity with an empty review)

Mon, Jan 20, 11:57 AM
elexis added a comment to D2567: Splits debug display of frustums.

Please do not forget to post which parts were reviewed, which parts were tested when posting an acceptance.

Mon, Jan 20, 11:51 AM
elexis added a comment to D2568: gui: remove empty space between logo and buttons.

What do you mean exactly?

This is the patch I uploaded at https://code.wildfiregames.com/rP23387#40853 so it would be correct to credit that.

Mon, Jan 20, 11:18 AM
elexis committed rP23420: Show an error message instead of triggering a debug breakpoint if a GUI page….
Show an error message instead of triggering a debug breakpoint if a GUI page…
Mon, Jan 20, 10:58 AM
elexis closed D2363: Validate XML directory and file attributes strings when loading..
Mon, Jan 20, 10:58 AM
elexis accepted D2363: Validate XML directory and file attributes strings when loading..

The patch results in

ERROR: GUI: Script path gui/pregame is not a directory

while it actually is a directory, just not one recognized by the code.

Mon, Jan 20, 10:53 AM
elexis added a comment to rP23419: Rewrite Gamesetup AIConfig page to use class syntax, decouple settings and move….

Also:
Removes the hack to Pop and Push the dialog in order to update it.
Update the gameAttributes instantly when changing an AI dropdown, so that the selection isnt lost when another client changes any game setting, preparing for #3806.

Mon, Jan 20, 10:45 AM
elexis abandoned D1777: Move maptype and mapfilter from gui/gamesetup/ to gui/common/settings.js.
  • mapType moved to common/ in rP23374
  • mapFilter move is unwarranted following the decision in rP23413
Mon, Jan 20, 10:32 AM
elexis committed rP23419: Rewrite Gamesetup AIConfig page to use class syntax, decouple settings and move….
Rewrite Gamesetup AIConfig page to use class syntax, decouple settings and move…
Mon, Jan 20, 10:30 AM
elexis closed D2577: Use class syntax for AIConfig page and move it to Gamesetup/Pages subfolder.
Mon, Jan 20, 10:30 AM
elexis added a comment to D2577: Use class syntax for AIConfig page and move it to Gamesetup/Pages subfolder.

As mentioned in D2581, it is necessary to run the AIConfig page in the same script context as the GameSetupPage if one wants exclusively that page to be in charge of the AI attributes in g_GameAttributes.settings.PlayerData, since the page can't run code if its closed, but it can if its only hidden.
Not doing it that way would mean there would be a class in the AIConfig page manifesting the AI setting logic and another class in the Gamesetup page coding the same logic.
Second reason to perform this change is as mentioned the existing coupling between the Gamesetup page and subpages, which is a pattern, and thus refactoring this page to become a subpage means the pattern becomes an example of how to implement Gamesetup subpages, not a counterexample, with the new subpages being empowered and encouraged to reuse the existing gamesetup controlers (gameSettingsControl, playerAssignmentsControl, netMessages, mapCache, mapFilters, ...).

Mon, Jan 20, 10:18 AM
elexis updated the diff for D2577: Use class syntax for AIConfig page and move it to Gamesetup/Pages subfolder.

Rebase following rP23413 and remove more hardcodings.

Mon, Jan 20, 10:10 AM

Sat, Jan 18

elexis committed rP23414: Options page dropdown support for per-value hovered tooltips..
Options page dropdown support for per-value hovered tooltips.
Sat, Jan 18, 9:40 PM
elexis closed D2576: Options page to display per-value tooltips.
Sat, Jan 18, 9:40 PM
elexis added a comment to D2576: Options page to display per-value tooltips.

(The patch was not tested, see IRC)

Sat, Jan 18, 9:39 PM
elexis retitled D2577: Use class syntax for AIConfig page and move it to Gamesetup/Pages subfolder from Use class syntax for AIConfig page and move it to GamesetupPage to Use class syntax for AIConfig page and move it to Gamesetup/Pages subfolder.
Sat, Jan 18, 9:13 PM
elexis committed rP23413: Gamesetup subpages support..
Gamesetup subpages support.
Sat, Jan 18, 8:43 PM
elexis closed D2581: Refactor gamesetup page to support subpages.
Sat, Jan 18, 8:43 PM
elexis added a comment to D2581: Refactor gamesetup page to support subpages.

Discussed with Vladislav on http://irclogs.wildfiregames.com/2020-01/2020-01-18-QuakeNet-%230ad-dev.log and with nani in a PM, concluding preference for running it in the same page.
It is necessary to run it in the same page if there is a requirement to have the setting handler exclusively in one class, and in only one page, see summary.

Sat, Jan 18, 7:31 PM
elexis updated the summary of D2581: Refactor gamesetup page to support subpages.
Sat, Jan 18, 7:23 PM
elexis created D2581: Refactor gamesetup page to support subpages.
Sat, Jan 18, 3:23 PM
asterix awarded D2577: Use class syntax for AIConfig page and move it to Gamesetup/Pages subfolder a Like token.
Sat, Jan 18, 11:33 AM

Fri, Jan 17

elexis added a comment to D2510: [gameplay] change phase requirements.

Disagree both with reducing the amount of structures necessary to be built (the phases are usually eco-rushed through quite quickly) and with forcing the player to build certain structures.

Fri, Jan 17, 9:50 PM
elexis updated the test plan for D2577: Use class syntax for AIConfig page and move it to Gamesetup/Pages subfolder.
Fri, Jan 17, 9:06 PM
elexis updated the Trac tickets for D2577: Use class syntax for AIConfig page and move it to Gamesetup/Pages subfolder.
Fri, Jan 17, 8:55 PM
elexis created D2577: Use class syntax for AIConfig page and move it to Gamesetup/Pages subfolder.
Fri, Jan 17, 8:54 PM
elexis updated the test plan for D2576: Options page to display per-value tooltips.
Fri, Jan 17, 5:14 AM
elexis created D2576: Options page to display per-value tooltips.
Fri, Jan 17, 5:14 AM

Thu, Jan 16

elexis added a comment to D2573: Fix AI OOS on rejoin related to random calls.

(The string in rP19491 should be nuked and D598 abandoned in case this patch is committed and achieves the objective)

Thu, Jan 16, 12:34 PM
elexis awarded D2573: Fix AI OOS on rejoin related to random calls a Dat Boi token.
Thu, Jan 16, 12:32 PM
elexis added a comment to D2360: Fix entities not retaining repair order after target transforms..

It would be better to write new function SetBuilders and pass whole array at once.

Perhaps one can pass the Map or Map keys instead of creating an array as well.
Just have to be careful then, since the object reference might be taken over in case of assigning it directly, instead of getting a copy.
(I suppose that shouldn't break serialization, since object references are serialized as well, but checking would be better than assuming.
Also two entities having the same object reference in their state means that they cant modify it as if they owned it exclusively, as every modification to the object would change the state of both entities. In this case the old entity is destructed, so that might not be a problem.)

Thu, Jan 16, 12:31 PM
elexis added a comment to D2571: Gamesetup support for sliders, use it for Ceasefire, RelicCount, RelicDuration, WonderDuration.

(Note to self: forgot those)

Thu, Jan 16, 1:22 AM

Wed, Jan 15

elexis committed rP23403: Remove counterproductive lowercasing of GUI ScriptEvent names, refs #127..
Remove counterproductive lowercasing of GUI ScriptEvent names, refs #127.
Wed, Jan 15, 5:00 PM
elexis closed D2445: Remove ancient GUI ScriptEvent lowercase struggle.
Wed, Jan 15, 5:00 PM
elexis updated the test plan for D2445: Remove ancient GUI ScriptEvent lowercase struggle.
Wed, Jan 15, 4:58 PM
elexis committed rP23401: Don't continue to process pending netmessages in the gamesetup_mp page after….
Don't continue to process pending netmessages in the gamesetup_mp page after…
Wed, Jan 15, 2:34 PM
elexis closed D2559: Fix unknown GUID errors when rejoining while another client rejoins at an unlucky time.
Wed, Jan 15, 2:34 PM
elexis added a comment to rP23400: Fix lineendings..

I did.

Wed, Jan 15, 2:32 PM
elexis committed rP23400: Fix lineendings..
Fix lineendings.
Wed, Jan 15, 2:24 PM
elexis created P193 unknown type name 'OsPath' unknown type name 'GLenum';.
Wed, Jan 15, 2:20 PM
elexis planned changes to D2571: Gamesetup support for sliders, use it for Ceasefire, RelicCount, RelicDuration, WonderDuration.
Wed, Jan 15, 2:12 PM
elexis created D2571: Gamesetup support for sliders, use it for Ceasefire, RelicCount, RelicDuration, WonderDuration.
Wed, Jan 15, 2:11 PM
elexis committed rP23399: Nerf citizen javelinist team bonuses, because they allowed too quick….
Nerf citizen javelinist team bonuses, because they allowed too quick…
Wed, Jan 15, 1:06 PM
elexis closed D2392: Team bonus balancing.
Wed, Jan 15, 1:06 PM
elexis accepted D2392: Team bonus balancing.
  • Kush bonus:

So the only thing I wasnt sure about is the Kushite elephant bonus. It was discussed in the lobby about 2-3 weeks ago with ValihrAnt and on 2020-01-05.
It came out the purpose for nerving the elephant bonus was because some other non-uploaded patch (either borg or Valihrs balancing mod) changed the cost of elephants.
Since we don't have strong indication that this bonus is currently overpowered, we'll leave it out for now and if someone comes along and changes elephant stats or finds other aspects really warranting the bonus reduction for Kushites, we can add it then (once it's warranted).

Wed, Jan 15, 1:05 PM
elexis requested verification of rP23374: Gamesetup class rewrite, fixes #5322, refs #5387..
Wed, Jan 15, 12:52 PM
elexis requested verification of rP23392: Landscape and Daytime gamesetup options for the Unknown, Danubius and Polar Sea….
Wed, Jan 15, 12:52 PM
elexis committed rP23398: Fix some oversights in the gamesetup class rewrite rP23374/D2483 and one in the….
Fix some oversights in the gamesetup class rewrite rP23374/D2483 and one in the…
Wed, Jan 15, 12:51 PM

Tue, Jan 14

elexis added a comment to D2542: Adds smart search to the Atlas entity list.

From blackbox testing, search is acceptable to me, I'd prefer exact as a default too (I dont expect to ever use fuzzy search, but nani implemented it for his mapbrowser and other features too, so perhaps there are users for that).

Tue, Jan 14, 11:23 PM
elexis added a comment to D2568: gui: remove empty space between logo and buttons.

Should optimize the solution for the user, not for the developer, and it looks more appealing if it is vertically centered, which is relevant for all resolutions greater than that one?
Otherwise one should do an evaluation which of the two (top alignment vs center alignment) looks more appealing. (Or perhaps even some golden ratio stuff?)
And then pick the one that looks best for all relevant resolutions.

Tue, Jan 14, 6:30 PM
elexis added a comment to D2568: gui: remove empty space between logo and buttons.

Why did I post the JS?

Tue, Jan 14, 6:19 PM
elexis added a comment to rP23387: Move the credits button on main menu.

or this pattern (has the advantage of not hardcoding references to neighbors):

top = 50%-halfHeight
bottom = 50% + halfHeight
`

where 2 * halfHeight = buttons * buttonHeight

Tue, Jan 14, 5:52 PM
elexis added a comment to rP23387: Move the credits button on main menu.

Any ideas on how to remove the unnecessary empty space between the logo and the “Learn To Play” button (red)?

Tue, Jan 14, 5:50 PM
elexis added a comment to D1634: Fert random map..

Is there no way to force victory conditions?

Why not allow the host to vary the map more by playing with other or additional victory conditions?
Currently when selecting a skirmish/random map that comes with VictoryConditions, that choice is overwritten.
So the user still has to actively decide against the preference of the map.
(When playing in conquest, the player gaining the middle still has a big strategical advantage, and its the primary passage connecting the players, so the victory condition doesnt change the gameplay that much in case Conquest is enabled)
(It is quite easy to change the VictoryCondition format of maps to differentiate between forcing and overwriting a setting, the change could be local to VictoryConditions.js, except for the fact that Atlas would also need to be changed and perhaps the Gamesetup.cpp Autostart code)

Tue, Jan 14, 3:22 PM
elexis added a comment to rP23392: Landscape and Daytime gamesetup options for the Unknown, Danubius and Polar Sea….

Do you have a replay for that match? Or do you know which map it was? I cant reproduce with or without the persist file for skirmish maps, random maps and the unknown map, nor tutorial.

Tue, Jan 14, 2:59 PM
elexis created P192 AI serializationtest error.
Tue, Jan 14, 2:26 PM