Page MenuHomeWildfire Games

elexis (Alexander H)
User

Projects

User Details

User Since
Dec 21 2016, 3:52 PM (154 w, 4 d)

Recent Activity

Today

elexis added a comment to rP23216: Fix idle unit not attacking nearest unit..

Thanks for working on a fix! Does this also happen to fix #5610?

Sun, Dec 8, 1:47 PM
elexis awarded rP23219: Remove duplication of code from WaterManager a Like token.
Sun, Dec 8, 1:45 PM
elexis awarded rP23217: Fix formation-walking infinite loop introduced in rP22506 a Like token.
Sun, Dec 8, 1:45 PM
elexis removed 1 auditor(s) for rP22475: Fix IDLE-related infinite loops by moving stateful calls to IDLE.timer.: elexis.

Thanks for the fix!

Sun, Dec 8, 1:45 PM

Fri, Dec 6

elexis added inline comments to rP23172: Rewrite lobby page to use class semantics, add more gamedetails labels, improve….
Fri, Dec 6, 11:46 AM
elexis added a comment to D2261: lobby,gamesetup: Fix remaining ESLint warnings.

Looks like three other issues were introduced there but I will fix those separately so as to not confuse the references to this patch number.

153:3  warning  Nested block is redundant  no-lone-blocks
202:3  warning  Nested block is redundant  no-lone-blocks
110:3  warning  Nested block is redundant  no-lone-blocks
Working on the fix at D2452.
Fri, Dec 6, 11:41 AM
elexis added inline comments to rP23172: Rewrite lobby page to use class semantics, add more gamedetails labels, improve….
Fri, Dec 6, 11:39 AM

Thu, Dec 5

Krinkle awarded rP23172: Rewrite lobby page to use class semantics, add more gamedetails labels, improve… a Orange Medal token.
Thu, Dec 5, 11:37 PM
elexis added a comment to D2451: Little cleanup/fix in ChatMessageFormatPlayer.js.

Remove an useless reassign of isMe with the same value.

From D2409

the same value than above

Incorrect.

Thu, Dec 5, 12:13 PM
elexis added inline comments to rP23062: Rewrite session chat to use hierarchical object oriented design using class….
Thu, Dec 5, 12:02 PM
elexis added inline comments to D2409: GuiInterface TimeNotifications fixes and cleanup.
Thu, Dec 5, 12:01 PM
elexis added a comment to D1520: Automatically cancel unpacking when units are ordered to move.

(I didn't check the semantics)

Thu, Dec 5, 3:10 AM
elexis added a comment to D2338: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original name. Also restore the Wrapper name to reflect what it's wrapping and move it to renderer.
In D2338#102497, @Angen wrote:

Tests are passing.
Shader errors are reported.
From what I have seen shaders do work as without patch.

I can't tell from that if you have read the patch too or only blackbox tested it.

Thu, Dec 5, 2:29 AM

Mon, Dec 2

elexis added a comment to rP12756: Match setup GUI revamp. Adds pop-cap and starting resource options. Refs #802.

#802 -> #812

Mon, Dec 2, 12:56 PM

Thu, Nov 28

elexis added a comment to D2445: Remove ancient GUI ScriptEvent lowercase struggle.

Current naming cases are heterogenous.
It seems most of the UNDERSCORE_UPPERCASE seems to come from C developers.
We notice that at least in source/gui/ there are no UNDERSCORE_UPPERCASE constants, so the folder is selfconsistent.

Thu, Nov 28, 9:08 AM

Wed, Nov 27

elexis added inline comments to D2445: Remove ancient GUI ScriptEvent lowercase struggle.
Wed, Nov 27, 12:05 PM

Tue, Nov 26

elexis added inline comments to rP8997: Let exceptions in GUI script events triggered by script setters propagate out….
Tue, Nov 26, 9:50 PM
elexis updated the summary of D2445: Remove ancient GUI ScriptEvent lowercase struggle.
Tue, Nov 26, 6:47 PM
elexis updated the summary of D2445: Remove ancient GUI ScriptEvent lowercase struggle.
Tue, Nov 26, 6:45 PM
nani awarded D2445: Remove ancient GUI ScriptEvent lowercase struggle a Mountain of Wealth token.
Tue, Nov 26, 6:43 PM
elexis created D2445: Remove ancient GUI ScriptEvent lowercase struggle.
Tue, Nov 26, 6:34 PM
elexis raised a concern with rP23160: Bolt tower and ampitheater commit, updated ptolemaic sentry tower while I was….
Tue, Nov 26, 10:17 AM
elexis planned changes to D2410: Send NetClient GUIMessages to subscribing GUIObjects instead of pulling them onTick.

Botherthings:

  • XmppClient equally pulls onTick but only receives messages occasionally, so it should receive the same treatment
  • One needs to subscribe to a GUI Object, but the GUI object itself is not involved at all in the processing of the event. So it would seem nicer to subscribe the event globally, perhaps similar to D2260/rP22851. (The event handlers must be destroyed when the GUI page is destroyed, yet CGUI should remain agnostic of NetClient and XmppClient)
  • To trigger a ScriptEvent, one needs to call RecurseObject. But that means on a GUI object page with 10k objects and only 1 object using the event, it will iterate over 10k objects with 10k function calls for no reason. (However not iterating using RecurseObject means iteration order will not be hierarchical anymore, which is sad, but appears that it can be assumed to be negligible. Secondly it means having to copy the pointers to iterate since that container can change while iterating).
Tue, Nov 26, 9:32 AM

Mon, Nov 25

elexis committed rP23192: Fix warning about attempted empty batch train occurring if….
Fix warning about attempted empty batch train occurring if…
Mon, Nov 25, 9:59 PM
elexis committed rP23191: Replace boost::unordered_map, boost::unordered_set with std::unordered_map, std….
Replace boost::unordered_map, boost::unordered_set with std::unordered_map, std…
Mon, Nov 25, 3:30 PM
elexis closed D2441: Use std::unordered_map, std::unordered_set for boost::unordered_map, boost::unordered_set, drop std::unary_function.
Mon, Nov 25, 3:30 PM
elexis added a comment to D2441: Use std::unordered_map, std::unordered_set for boost::unordered_map, boost::unordered_set, drop std::unary_function.
In D2441#101896, @Stan wrote:

Any performance difference in using one of the other? I'm all for removing dependencies though.

(Just for the record I had written first half of the post already, I don't forget such a thing.)

Mon, Nov 25, 2:39 PM
elexis added inline comments to rP9961: cleanup and simplification of the really old h_mgr code..
Mon, Nov 25, 12:26 PM
elexis added a comment to D2441: Use std::unordered_map, std::unordered_set for boost::unordered_map, boost::unordered_set, drop std::unary_function.
Mon, Nov 25, 11:23 AM
elexis added a comment to D2392: Team bonus balancing.

You mean something historically relatable which perhaps could be grasped from Sundiatas thread?

Mon, Nov 25, 10:48 AM
elexis updated the diff for D2441: Use std::unordered_map, std::unordered_set for boost::unordered_map, boost::unordered_set, drop std::unary_function.

ugly namespace for all std::hash.

Mon, Nov 25, 12:23 AM
elexis updated the diff for D2441: Use std::unordered_map, std::unordered_set for boost::unordered_map, boost::unordered_set, drop std::unary_function.

namespace for path.h

Mon, Nov 25, 12:13 AM

Sun, Nov 24

elexis created D2441: Use std::unordered_map, std::unordered_set for boost::unordered_map, boost::unordered_set, drop std::unary_function.
Sun, Nov 24, 11:35 PM
elexis added a comment to D2440: Discrete LOD.

The intervals should probably not be buried in the code but specified somewhere, probably ideally in some model related art file or template (and ideally support more than two levels).
Perhaps std::pair<CStr, CStr>("lod", "low")) can be constructed only once per program launch instead of once per call.
{ on a separate line.
Hiding projectiles after a set distance means it will fail for some projectiles of a given size, so it should be moved to data files as well.
It would be a good feature, although I guess in the average case only high level of detail will be shown, since the camera is top down on average?

Sun, Nov 24, 8:27 PM
elexis raised a concern with rP23179: Amphitheater name fix, Gladiator commit and amphitheater integration, Maurya….

The tower seems very overpowered?

Sun, Nov 24, 12:49 PM
elexis committed rP23184: Move CGUI constructor to the top of its file following rP9..
Move CGUI constructor to the top of its file following rP9.
Sun, Nov 24, 11:27 AM
elexis closed D2439: Move CGUI object types to own file, CGUI constructor to the top of CGUI.cpp.
Sun, Nov 24, 11:27 AM
elexis updated the test plan for D2439: Move CGUI object types to own file, CGUI constructor to the top of CGUI.cpp.
Sun, Nov 24, 11:04 AM
elexis created D2439: Move CGUI object types to own file, CGUI constructor to the top of CGUI.cpp.
Sun, Nov 24, 11:01 AM

Sat, Nov 23

elexis added a comment to D2436: Credits: Add missing authors + balancing credits category.
Sat, Nov 23, 4:49 PM
elexis committed rP23182: Add Balancing credits, refs #5444..
Add Balancing credits, refs #5444.
Sat, Nov 23, 4:45 PM
elexis closed D2436: Credits: Add missing authors + balancing credits category.
Sat, Nov 23, 4:45 PM
elexis committed rP23181: Add some missing historic credits, refs #5444..
Add some missing historic credits, refs #5444.
Sat, Nov 23, 4:37 PM
elexis added a comment to D2436: Credits: Add missing authors + balancing credits category.

Great initiative!
Perhaps there should also be a separate list for user-facing text strings? E.g. @Gallaecio.

Sat, Nov 23, 4:36 PM
elexis added inline comments to rP23180: Split credits for "miscellaneous" categories into a Community and a History….
Sat, Nov 23, 4:33 PM
elexis committed rP23180: Split credits for "miscellaneous" categories into a Community and a History….
Split credits for "miscellaneous" categories into a Community and a History…
Sat, Nov 23, 4:02 PM
elexis added a comment to D2436: Credits: Add missing authors + balancing credits category.
In D2436#101535, @Stan wrote:

Any reason why you didn't create a separate file ?

Sat, Nov 23, 3:37 PM
elexis added a comment to D2427: Alphabetize credits.

Check for mistakes and omissions.

How do I achieve that with a program or does performance of the test plan mean going through every line by hand?

Sat, Nov 23, 3:27 PM
elexis updated the diff for D2436: Credits: Add missing authors + balancing credits category.

Add wacko, remove LordGood, markt.

Sat, Nov 23, 2:52 PM
elexis added a comment to D2436: Credits: Add missing authors + balancing credits category.

Balancing contributors:

Sat, Nov 23, 2:47 PM
elexis added a comment to D2436: Credits: Add missing authors + balancing credits category.

Balancing department heads:

Sat, Nov 23, 11:43 AM

Fri, Nov 22

elexis added a comment to D2436: Credits: Add missing authors + balancing credits category.
  1. Old svn entity template commits:
Fri, Nov 22, 9:15 PM
elexis added a comment to D2436: Credits: Add missing authors + balancing credits category.

Balancing authors:
How I obtained the list of balancing authors:

  1. New simulation entity commits git shortlog binaries/data/mods/public/simulation/templates/
  2. Old simulation entity commits git shortlog 29b5247bd5811365a2b405758bba019b2db93e81 -- ./official/entities/ See also https://github.com/0ad/0ad/commits/29b5247bd5811365a2b405758bba019b2db93e81/binaries/data/mods/official/entities to click.
Fri, Nov 22, 9:08 PM
elexis added a comment to D2436: Credits: Add missing authors + balancing credits category.

Quentin Pradet is cygal:

Fri, Nov 22, 8:54 PM
elexis added a comment to D2436: Credits: Add missing authors + balancing credits category.

2012-11-13-QuakeNet-#0ad-dev.log:21:36 < superMario_> I joined, made a few icons and images, and then got too busy with paid work :[

  • So it seems these cursors were made by him (?) rP7789
  • Fullname and nickname in that commit message
  • Nickname is fullname and was used in IRC while being aware that this is a public and logged channel

2010-07-22-QuakeNet-#0ad-reviewed.log:20:09 < mfmachado> Im supposed to add the new icon to the svn
2010-08-16-QuakeNet-#0ad.log:15:07 < mfmachado> new animal icon dds
2010-08-16-QuakeNet-#0ad.log:16:59 < Brian1> mfmachado: Commited your animal icons. They look great! :)
2010-08-12-QuakeNet-#0ad-reviewed.log:17:55 < Brian1> mfmachado: About the installer icon, you might want to center it vertically. I also noticed that scaling it down with an extra pixel on the left and right, and them resizing to cut off a pixel on the left and right, allowed a slightly taller icon. When it's scaled down that much (48x48), the pixel lost on each side isn't noticeable and the pixel gain on the top and bottom makes it look better.

Fri, Nov 22, 8:35 PM
elexis added a comment to D2436: Credits: Add missing authors + balancing credits category.

Author: Alexander Yakobovich

That this is the same Alex is shown in IRC logs matching those commits

2007-09/2007-09-15-QuakeNet-#wfg-Meeting.log:16:59 < {Alex}> I'll commit my XML files for now
./2007-07/2007-07-14-QuakeNet-#wfg-Meeting.log
18:29 < Matei> now that we have the building limit, we will even be able to prevent farm-spamming :)

  • rP5244 counts as a programming patch, I guess rP5261 as balancing patch
Fri, Nov 22, 8:28 PM
elexis added a comment to D2436: Credits: Add missing authors + balancing credits category.
In D2436#101535, @Stan wrote:

Any reason why you didn't create a separate file ?

Number of entries in comparison to the other categories:

 916  special.json
3.3K  misc.json
7.1K art.json
 11K  programming.json
 16K  donators.json
105K translators.json

and importance of the category in comparison to the others.

Fri, Nov 22, 8:27 PM
elexis added a comment to D2392: Team bonus balancing.

D2436 proposes a balancing credits category that allows us to add you to the credits properly.

Fri, Nov 22, 7:13 PM
elexis updated the summary of D2436: Credits: Add missing authors + balancing credits category.
Fri, Nov 22, 7:09 PM
elexis created D2436: Credits: Add missing authors + balancing credits category.
Fri, Nov 22, 5:51 PM

Thu, Nov 21

elexis committed rP23173: Rename Lobby.js to LobbyHandler.js to avoid filename conflict with lobby.js on….
Rename Lobby.js to LobbyHandler.js to avoid filename conflict with lobby.js on…
Thu, Nov 21, 7:22 PM
elexis committed rP23172: Rewrite lobby page to use class semantics, add more gamedetails labels, improve….
Rewrite lobby page to use class semantics, add more gamedetails labels, improve…
Thu, Nov 21, 2:45 PM
elexis closed D2412: Lobby class implementation.
Thu, Nov 21, 2:45 PM
elexis added a comment to D2412: Lobby class implementation.

Improvements of committed code:

  • g_Username -> g_Nickname
  • Update local nickname on nickchange
Thu, Nov 21, 2:44 PM

Wed, Nov 20

elexis updated the diff for D2412: Lobby class implementation.

Patch update:

Wed, Nov 20, 6:03 PM
elexis added a comment to D2412: Lobby class implementation.

Analysis of initial playerList performance:
TLDR: Delay GUI messages in XmppClient.cpp until m_initialLoadComplete.

Wed, Nov 20, 5:10 PM
elexis added a comment to D2432: Add a -help option.

Writing C++ code in premake sounds problematic, why not load the file in C++ directly? It seems like it'd be there even in the released version. On the other hand also seems unexpected that C++ code depends on a readme file?

Wed, Nov 20, 11:52 AM
elexis added a comment to D2412: Lobby class implementation.

Further rediscovered bugs:

  • #5638 for the COList missing features (column centering, only updating one line instead of all lines, obtaining positions of columns to align filters)
  • Rated game not updating playerlist: #4621, seems to be a serverside bug, not clientside.
  • IRC Removal in D1136
Wed, Nov 20, 11:24 AM
elexis added inline comments to rP22855: Drop lobby presence GUI messages altogether for better performance and less….
Wed, Nov 20, 11:19 AM
elexis abandoned D1136: Fix lobby IRC translation comment.

The missing translation comment:

#: gui/lobby/lobby.js:1382
#, javascript-format
msgctxt "lobby private message"
msgid "(%(private)s) <%(sender)s>"
msgstr ""
Wed, Nov 20, 11:17 AM
elexis added inline comments to D817: Lobby Dialog Overlay in-game and gamesetup.
Wed, Nov 20, 11:14 AM

Tue, Nov 19

elexis added inline comments to D817: Lobby Dialog Overlay in-game and gamesetup.
Tue, Nov 19, 9:10 PM
elexis updated the Trac tickets for D2412: Lobby class implementation.
Tue, Nov 19, 2:44 PM
elexis added inline comments to rP20886: Enable players to open the lobby as a dialog in the gamesetup, running games….
Tue, Nov 19, 2:42 PM
elexis added inline comments to rP22855: Drop lobby presence GUI messages altogether for better performance and less….
Tue, Nov 19, 10:37 AM
elexis updated the test plan for D2412: Lobby class implementation.
Tue, Nov 19, 10:31 AM
elexis updated the summary of D2412: Lobby class implementation.
Tue, Nov 19, 10:28 AM
elexis updated the test plan for D2412: Lobby class implementation.
Tue, Nov 19, 10:26 AM
elexis updated the diff for D2412: Lobby class implementation.

Remove Game class duplication, display victory conditions, mods, hostname in GameDetails.

Tue, Nov 19, 12:52 AM
elexis added a comment to D2412: Lobby class implementation.
  • Implemented another TODO from rP14098 by displaying the victory conditions.
  • Implemented display of mods if the game has different mods launched.
  • Display gamename in selection
  • Removed Game class duplication



Tue, Nov 19, 12:50 AM

Mon, Nov 18

elexis added a comment to D2412: Lobby class implementation.

Note for the above graph, the worst case scenario is a hypothetical scenario where every gamesetting of every host changed in every gamelist update.

Mon, Nov 18, 6:47 PM
Angen awarded D2412: Lobby class implementation a Love token.
Mon, Nov 18, 5:59 PM
elexis added a comment to D2412: Lobby class implementation.

The previously described class Game implementation was performed and it seems indeed to be the right thing as it is both more performant (performance doubled?) and if performance is irrelevant,
then it's still advantageous as one will be able to trigger event handlers such as a new game being registered, a game having been removed, a buddy having joined a game.

Mon, Nov 18, 5:57 PM
elexis updated the diff for D2412: Lobby class implementation.

Implement class Game.
Might contain some possible duplication to be attempted to be removed and profiling code.

Mon, Nov 18, 5:42 PM
elexis added inline comments to rP14098: Multiplayer lobby based on the XmPP protocol. Special thanks to Philip….
Mon, Nov 18, 2:19 PM
elexis updated the diff for D2412: Lobby class implementation.

See above, chat Status/System notification rewrite, updateGameList optimizations, TODO removal

Mon, Nov 18, 12:21 AM

Sun, Nov 17

elexis added a comment to D2412: Lobby class implementation.

Some notes of the changes in the patch so far (subset of the to be committ message):

Rewrite lobby GUI page to use class semantics.
Sun, Nov 17, 11:28 PM
elexis added a comment to D2412: Lobby class implementation.

Lobby rewrite logbook entry:

Sun, Nov 17, 10:47 PM

Sat, Nov 16

elexis added inline comments to rP19250: Implement clientside kick/ban support for the lobby..
Sat, Nov 16, 1:30 PM
elexis added inline comments to rP14098: Multiplayer lobby based on the XmPP protocol. Special thanks to Philip….
Sat, Nov 16, 1:35 AM
elexis added a comment to rP20064: XmppClient cleanup..

Seems cleaning the lobby subject doesnt broadcast the change instantly, players only notice upon relog, for non-empty subjects it does broadcast changes instantly, and it should be gloox fault since I see the update in pidgin and I dont see empty changes being filtered in 0ad xmppclient / glooxwrapper.

Sat, Nov 16, 12:50 AM
elexis added inline comments to D835: Allow specifying custom properties in the XmppClient GUIMessage struct (instead of nuking it and using JS Value).
Sat, Nov 16, 12:44 AM
elexis abandoned D720: Missing escapeText in the lobby, replay menu and remove 256 character limit.

pages other than lobby remaining (and those are mostly meh)

Sat, Nov 16, 12:31 AM

Fri, Nov 15

elexis added inline comments to rP21474: Implement combine victory conditions.
Fri, Nov 15, 7:20 PM
elexis added a comment to D720: Missing escapeText in the lobby, replay menu and remove 256 character limit.

The diff in D2412 will contain all escapeText calls that were identified to be necessary for the player to protect from GUI tag attackers, making this diff obsolete except for the replaymenu and maybe gamesetup/session/summary/... (IIRC NetServer prohibited those names, but in singleplayer it still breaks)

Fri, Nov 15, 5:07 PM
elexis retitled D720: Missing escapeText in the lobby, replay menu and remove 256 character limit from Missing escapeText in the lobby and remove 256 character limit to Missing escapeText in the lobby, replay menu and remove 256 character limit.
Fri, Nov 15, 4:58 PM

Thu, Nov 14

elexis raised a concern with rP22475: Fix IDLE-related infinite loops by moving stateful calls to IDLE.timer..

See above

Thu, Nov 14, 4:55 PM
elexis committed rP23157: Update sprintf.js library from 1.0.2 to 1.1.2..
Update sprintf.js library from 1.0.2 to 1.1.2.
Thu, Nov 14, 2:01 PM
elexis closed D2421: Update sprintf.js library.
Thu, Nov 14, 2:01 PM
elexis added a comment to D2421: Update sprintf.js library.

Test plan performance:

Thu, Nov 14, 1:43 PM