Tab, Shift + Tab easier to switch tabs and when text input is selected still hotkeys alt+s, alt+w works to switch, but harder to grap : ).
Details
Details
- Reviewers
elexis - Commits
- rP20959: Use Tab and Shift+Tab as the default hotkey to switch tabs.
- Trac Tickets
- #4982
test in options, summary, credits tabs
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Alternative hotkeys should be available for all settings, not only tabs. Also an arbitrary number of hotkeys should be allowed.
| binaries/data/config/default.cfg | ||
|---|---|---|
| 197 ↗ | (On Diff #4943) | ^ |
Comment Actions
As said (partially on IRC), one can do this by adding hotkey.tab.next = "Alt+S", "Tab" (similar for prev) to the user.cfg. Thus I see no real need for this patch.
This comment was removed by ffffffff.
Comment Actions
Not convinced this should make it into the vanilla game, however it is a nice PoC for everyone's user.cfg
Comment Actions
I either missed or forgot the IRC conversation, switching tabs with tab and shift+tab doesn't seem too bad, does it? It only doesn't work if a text input is focused, no?
(I guess what we actually want is tab and shift+tab to change focus between arbitrary GUI elements, but that will likely never happen)
Comment Actions
It's rather more convenient to switch than the alternative hotkey alt+s or alt+w as they only are the hotkeys because they working in text input fields.
Comment Actions
I fear having Alt+S, Alt+W hitted on focused text input field due to it leads to changed text in that field, while switching! tab, so u dont even see ur changed text in that field f. e. in options gui!
With tab as hotkey its clear its grabbing tab hotkey for input text field either make autocomplete or do nothing. So it's not changing anything in the text input and then switch! tab. this is severe.
This is for any hotkey within text field highly severe. Text input filed should grabbing all hotkeys when focused. So it's clear while focused it cant be changed anything else around.
After that tab key and shift+tab for next and previous is very easy to hit then for tabs switching and maybe should be changed to.
Comment Actions
With the new gamesetup UI in D1027 we definitely need this hotkey in my opinion. The current default is not very intuitive and doesn't work with some window managers like mine. Sure users can change the config, but at least in alpha 23, they have to go through the edit process which is troublesome.
The hotkey eases the UI interaction tremendously, at least on my end.
Thanks for the patch fpre!
(There is no conflict with the chat in the gamesetup as the hotkeys are only triggered if one isn't typing in an input field.)
Comment Actions
Will just change the order to have the more common key combination first.
As mentioned in the ticket, this doesn't fix the bug described in the ticket and I don't commit things to hide bugs.
I just happen to prefer this hotkey.