Page MenuHomeWildfire Games

bb
User

Projects

User Details

User Since
Jan 24 2017, 12:54 PM (116 w, 3 d)

Recent Activity

Tue, Apr 16

bb added inline comments to rP20939: Garrisoned units are lost after an upgrade towards a non garrison holder.
Tue, Apr 16, 11:16 PM
bb accepted rP20393: Move out of world promoted, packed and upgraded entity as they are not….

concern fixed by rP20939

Tue, Apr 16, 11:16 PM
bb accepted D1826: Fix missing parenthesis in the AI.
Tue, Apr 16, 6:14 PM
bb added inline comments to D1737: Slight cleanup of fogging OnDestroy and some comments.
Tue, Apr 16, 2:06 PM

Mon, Apr 15

bb committed rP22191: align the footprint an obstruction size with the model size for the kush range.
align the footprint an obstruction size with the model size for the kush range
Mon, Apr 15, 11:46 PM
bb committed rP22190: unparent the range from the barracks, and reduce the duplication in the civs'….
unparent the range from the barracks, and reduce the duplication in the civs'…
Mon, Apr 15, 11:40 PM
bb closed D1791: Separate range from barracks.
Mon, Apr 15, 11:40 PM
bb accepted D1791: Separate range from barracks.

Cav got removed from ranges (which makes sense)

Mon, Apr 15, 11:35 PM
bb updated the diff for D1398: Implement a press action to be called upon the first keyDown message of a hotkey and use keydown for current press.

years

Mon, Apr 15, 10:06 PM
bb accepted D438: Change Run Speed into a Run multiplier.

Some bot is complaining that this patch is rotting to long and needs a license year update

Mon, Apr 15, 9:35 PM
bb added a comment to D1815: match unit classes with templates.

Renamings of spear => spearman and co is good imo (wasn't there some earlier revision where it was discussed?)

Mon, Apr 15, 8:57 PM

Sun, Apr 14

bb added a comment to rP22188: Move tooltips on gamesetup dropdowns from xml to js, since by current gamestup….

Comments By: elexis, Imarok

Sun, Apr 14, 10:30 PM
bb committed rP22188: Move tooltips on gamesetup dropdowns from xml to js, since by current gamestup….
Move tooltips on gamesetup dropdowns from xml to js, since by current gamestup…
Sun, Apr 14, 10:29 PM
bb closed D594: Fix tooltips not used in gamesetup.
Sun, Apr 14, 10:29 PM · Contributors
bb accepted D594: Fix tooltips not used in gamesetup.

proofreading the gamesetup xml and global objects says the patch is complete (did not read the full file for any hidden tooltip in the code)

Sun, Apr 14, 10:23 PM · Contributors
bb added inline comments to D1776: Cleanup Timer.js and update documentation.
Sun, Apr 14, 10:00 PM
bb committed rP22187: Handle orderone hotkey also for the minimap.
Handle orderone hotkey also for the minimap
Sun, Apr 14, 9:30 PM
bb closed D1822: Handle hotkey to order only one unit on minimap.
Sun, Apr 14, 9:29 PM · Contributors
bb accepted D1822: Handle hotkey to order only one unit on minimap.

Thx for the patch

Sun, Apr 14, 9:12 PM · Contributors

Fri, Apr 12

bb committed rP22182: Add ConquestCritical to structures that want it, instead of removing it from….
Add ConquestCritical to structures that want it, instead of removing it from…
Fri, Apr 12, 5:05 PM
bb closed D1626: -ConquestCritical clear-up.
Fri, Apr 12, 5:05 PM
bb accepted D1626: -ConquestCritical clear-up.

Reading it again, the actual question is how to treat special (the rest looks good)

Fri, Apr 12, 5:04 PM
bb committed rP22181: Reduce duplication in template_structure_military*.
Reduce duplication in template_structure_military*
Fri, Apr 12, 4:12 PM
bb closed D1793: reduce template_structure_military* duplication.
Fri, Apr 12, 4:12 PM
bb accepted D1793: reduce template_structure_military* duplication.

Changes to trivial to not accept,

Fri, Apr 12, 3:58 PM
bb added a comment to D1796: create template_defensive_palisade.xml.
In D1796#74399, @Nescio wrote:

Maybe build time, wood cost, and loot ought to be made proportional to health, e.g. health/50?

Whatever makes sense compared to the other palisade structures. e.g cost wise a rocks_curve is pretty similar to a rocks_long, right?

Fri, Apr 12, 3:29 PM
bb added a comment to D1803: Communicate field diminishing returns to the player.

I assume agricultural products would be the most general term? Do we want that in game?

Fri, Apr 12, 3:19 PM
bb added inline comments to D1822: Handle hotkey to order only one unit on minimap.
Fri, Apr 12, 3:15 PM · Contributors

Sun, Apr 7

bb added a comment to D1810: Improvements to the translators credits script.

I get that ppl can choose whatever name they want, but who is named 4c905de7e2c9950b7d83273a8070b072 (second one in the german list)? I tried finding him/her in transifex but no luck.

Sun, Apr 7, 10:12 PM
bb added inline comments to D1651: aiTips gamesetup cleanup.
Sun, Apr 7, 10:11 PM · Contributors
bb added a comment to D1819: Make capture attack work with units with BuildingAI..

I won't stop anyone for making/commiting a temporal fix, but the underlying problem is that we have two components (buidlingAI and unitAI) on the same unit trying to achieve the same thing (attack something). In the end that is the thing we need to fix (as in subunits)

Sun, Apr 7, 6:15 PM
bb committed rP22169: recieve -> receive.
recieve -> receive
Sun, Apr 7, 6:06 PM
bb committed rP22166: Remove an unused variable.
Remove an unused variable
Sun, Apr 7, 12:04 AM
bb closed D1813: Remove unused variable from CInput.
Sun, Apr 7, 12:04 AM

Sat, Apr 6

bb committed rP22165: Update the wonder victory timer in case the wonder renames..
Update the wonder victory timer in case the wonder renames.
Sat, Apr 6, 11:58 PM
bb closed D1732: Wondervictory entity rename.
Sat, Apr 6, 11:58 PM
bb added a comment to D1732: Wondervictory entity rename.

Calling the traders out of scope of this patch

Sat, Apr 6, 11:58 PM
bb added inline comments to D1765: Gaia templates' <Selectable> clean-up.
Sat, Apr 6, 11:48 PM
bb requested changes to D1796: create template_defensive_palisade.xml.

Checked the difference between the templates as they are loading in game (by printing them out), it resulted in a number of actual changes, giving them below, some of them are not a problem (or actually make sense), a few need to be addressed.

Sat, Apr 6, 11:13 PM
elexis awarded rP22163: Remove unneeded death sounds from structure templates, as they inherit from… a Like token.
Sat, Apr 6, 5:48 PM
bb accepted D1813: Remove unused variable from CInput.

That must be a copy-pasta, text.delete.right doesn't have it, so completeness in that sense

Sat, Apr 6, 4:56 PM
bb added a comment to D1803: Communicate field diminishing returns to the player.

changing vegetables to grain wouldn't work since f.e. the Chinese mod has rise fields instead. One could consider "crops" though.

Sat, Apr 6, 4:48 PM
bb committed rP22163: Remove unneeded death sounds from structure templates, as they inherit from….
Remove unneeded death sounds from structure templates, as they inherit from…
Sat, Apr 6, 4:36 PM
bb closed D1795: remove unnecessary building_collapse_large sounds.
Sat, Apr 6, 4:36 PM
bb accepted D1795: remove unnecessary building_collapse_large sounds.

reads correct, greps complete, unit demo works => accept

Sat, Apr 6, 4:27 PM
bb added inline comments to D1806: standardized structure aura descriptions.
Sat, Apr 6, 4:02 PM

Fri, Apr 5

bb requested changes to D1702: GUI addon to animate objects proprieties.

As elexis mentioned the color animation would in the vanilla game be dead code, thus that shouldn't be there. Ofcourse it could be useful later, so I would propose to implement the system for the size only, but keep it extendable so the color could easily be added when required.

Fri, Apr 5, 12:56 PM
bb added inline comments to D1810: Improvements to the translators credits script.
Fri, Apr 5, 12:23 PM

Mar 18 2019

bb committed rP22132: seige to siege .
seige to siege
Mar 18 2019, 3:57 PM
bb closed D1797: seige → siege.
Mar 18 2019, 3:56 PM
bb accepted D1797: seige → siege.

Grepping says these are all cases of seige, so correct and complete

Mar 18 2019, 3:40 PM

Mar 17 2019

bb committed rP22129: Add "At Least" to the front of the disabledTooltips.
Add "At Least" to the front of the disabledTooltips
Mar 17 2019, 9:02 PM
bb closed D1792: X units required -> At least X units required.
Mar 17 2019, 9:02 PM
bb accepted D1792: X units required -> At least X units required.

Reads correct, checked all formation templates => accept

Mar 17 2019, 8:53 PM
bb added a comment to D1613: Improve the plural translation of the "<players> have won" string.

I get that some languages use singular for every other prime number, so to speak. But isn't exactly that the reason why we have markForPluralTranslation, so a translation can choose for which values it takes whatever form. If that isn't the case in the current code, we might have found a bug in our code. Stating the same problem more concretely: how is this particular call different from all the other markForPluralTranslation calls? or are all of them just wrong? (there are some in buildrestriction, wonderVictory, CaptureTheRelic, triggerHelper and Treasure Island)

Mar 17 2019, 8:51 PM
bb added a comment to D1613: Improve the plural translation of the "<players> have won" string.

Code should stand on itself, not referring to a phabricator revision. But isn't markForPluralTranslation designed to cover this case? So how does this solve the issue?
Furthermore markForPlural expects 3 arguments, now it only has 2.

Mar 17 2019, 6:53 PM
bb added a comment to D1613: Improve the plural translation of the "<players> have won" string.

Is that lengthy comment really required? Seems obvious from the code (or it is me who has such a language as mother tongue)

Mar 17 2019, 6:09 PM
bb added a comment to D1792: X units required -> At least X units required.

Period complaint while at it

Mar 17 2019, 4:52 PM
bb added a comment to D1791: Separate range from barracks.

Candidate != must be moved, I guess those should be in the children then...

Mar 17 2019, 4:41 PM
bb added a comment to D1791: Separate range from barracks.

GarrisonHolder: change the Max attribute in the childs, put the rest in the parent

Mar 17 2019, 4:25 PM
bb added a comment to D1791: Separate range from barracks.

That is a good point indeed, so we should be looking at which properties we can move to the military parent. Territoy, Vision, GarrsionHolder and Sound seem to be the biggest candidates

Mar 17 2019, 4:07 PM
bb added a comment to D1791: Separate range from barracks.

Can I propose to make a template_structure_military_training (or find better name) template as a parent of barracks, stable and range? That would solve the duplication of this patch and D1790

Mar 17 2019, 3:49 PM
bb committed rP22120: Change structure_defense to structure_defensive so it is consistent with the….
Change structure_defense to structure_defensive so it is consistent with the…
Mar 17 2019, 2:05 PM
bb closed D1788: rename template_structure_defense* to *defensive*.
Mar 17 2019, 2:05 PM
bb accepted D1788: rename template_structure_defense* to *defensive*.

Patch reads correct, unit demo test succeeded, grep gives translate hate=> accept

Mar 17 2019, 1:56 PM

Mar 16 2019

bb added a comment to D1788: rename template_structure_defense* to *defensive*.

Idea is ok, but patch is inclomplete: your grep doesn't seem to have found the skirmish buildings (the templates under skirmish/structures/)

Mar 16 2019, 11:25 PM
bb committed rP22118: Remove a misleading unit_fauna_decorative from the bird template.
Remove a misleading unit_fauna_decorative from the bird template
Mar 16 2019, 10:18 PM
bb closed D1787: rename template_unit_fauna_decorative to template_bird.
Mar 16 2019, 10:18 PM
bb accepted D1787: rename template_unit_fauna_decorative to template_bird.

Indeed inconsistent and misleading naming. Patch correct and complete, front doens't fall, also not in atlas

Mar 16 2019, 10:15 PM
bb committed rP22116: Nuke the misleading Structure_Defence from the wallset template name.
Nuke the misleading Structure_Defence from the wallset template name
Mar 16 2019, 10:03 PM
bb closed D1733: Rename wallset template.
Mar 16 2019, 10:03 PM
bb committed rP22115: Move the fish template under template_gaia since fish is a resource like trees….
Move the fish template under template_gaia since fish is a resource like trees…
Mar 16 2019, 9:57 PM
bb closed D1774: Change fish parent to gaia.
Mar 16 2019, 9:57 PM
bb accepted D1774: Change fish parent to gaia.

Game works, Atlas works changes make sense => accept

Mar 16 2019, 9:28 PM
bb added a comment to D1774: Change fish parent to gaia.

Idea seems good.

Mar 16 2019, 6:22 PM
bb added inline comments to D1765: Gaia templates' <Selectable> clean-up.
Mar 16 2019, 5:52 PM
bb accepted D1543: Don't require application restart to change the pauseonfocusloss option.

The option doesn't do anything outside the in-game so I suppose in-Game is the place...

Mar 16 2019, 5:41 PM
bb accepted D1171: Move more things in the projectile part of the Attack component.
Mar 16 2019, 5:26 PM
bb added a comment to D1171: Move more things in the projectile part of the Attack component.

One fairly trivial change required => accept

Mar 16 2019, 5:25 PM
bb committed rP22114: Also align the chat, refs rP22111.
Also align the chat, refs rP22111
Mar 16 2019, 5:07 PM
bb added inline comments to D438: Change Run Speed into a Run multiplier.
Mar 16 2019, 4:56 PM
bb added a comment to D438: Change Run Speed into a Run multiplier.

Something in the lioness changed, small rebase

Mar 16 2019, 4:47 PM
bb added a comment to rP22111: Align the settingspanel with its background, fixing te misalignment itroduced….

Broke the mp while at it, fix incoming

Mar 16 2019, 4:12 PM
bb committed rP22113: Fix a broken early return from rP21378.
Fix a broken early return from rP21378
Mar 16 2019, 3:40 PM
bb added a comment to rP21378: Allow units to be positioned with freehand placement.

@smiley: what would you think a "toFixed" would do on a vector? What we wanted to achieve is reducing the size of the command.txt for positioning units, thus dropping the precision after the 3rd decimal (as who cares about that?). To avoid duplication for any further such request a toFixed was added in the vector file. Regarding your example: if you use toFixed you expect a string, thus + gets a certain definition, so I don't see anything wrong....

Mar 16 2019, 3:36 PM
bb requested verification of rP21474: Implement combine victory conditions.
Mar 16 2019, 3:21 PM
bb committed rP22112: Add autostart conquest default description to readme.txt and add endless….
Add autostart conquest default description to readme.txt and add endless…
Mar 16 2019, 3:20 PM
bb requested verification of rP21957: Only update the gamesetup settings panel position when it actually changes..
Mar 16 2019, 3:16 PM
bb committed rP22111: Align the settingspanel with its background, fixing te misalignment itroduced….
Align the settingspanel with its background, fixing te misalignment itroduced…
Mar 16 2019, 3:15 PM
bb closed D1755: Fix line misaligment in gamesetup settings..
Mar 16 2019, 3:15 PM
bb accepted D1755: Fix line misaligment in gamesetup settings..

The horizontal size indeed is computed in js, since that size can change when you click on another tab, however the vertical size is the same always so coded in the xml. What went wrong in the initial slide panel commit (so it's not you who broke things nani, I did) is that the xml value or the background and front panel got different value. This was then masked by the ontick, but when that was removed, the real bug came out. However notice that the bug only happens when the panel width is maximal: in a small window everything is just aligned (Probably the reason I didn't find it....).

Mar 16 2019, 2:32 PM

Jan 19 2019

elexis awarded rP21957: Only update the gamesetup settings panel position when it actually changes. a Manufacturing Defect? token.
Jan 19 2019, 11:03 PM

Jan 6 2019

bb added a comment to D1732: Wondervictory entity rename.

well from a ownershipchange we can't see if it will be a rename, so when the new ent is brought up, we don't know it actually replaces another (one could change the entitylimits and allow two wonders, so an owners check wouldn't work), so the new timer will always be activated, which afterwards needs to be removed. Also from the destroy we don't know if it is a rename (one could very well create and destroy different wonders at the same turn), so we have to do it with the ent rename.

Jan 6 2019, 2:27 PM

Jan 5 2019

bb added inline comments to D1727: Update auras when a formation member renames.
Jan 5 2019, 11:25 PM
bb accepted D1733: Rename wallset template.

grepped for completeness, agreeing on the change, translators will hate
(note to self: be careful with file move)

Jan 5 2019, 11:01 PM
bb requested verification of rP21378: Allow units to be positioned with freehand placement.

should be fixed now: rP22030

Jan 5 2019, 9:47 PM
bb committed rP22030: Fix missing assignment from rP21378.
Fix missing assignment from rP21378
Jan 5 2019, 9:47 PM
bb closed D1656: Bugfix rP21378.
Jan 5 2019, 9:46 PM
bb accepted D1656: Bugfix rP21378.

see revision, proposed the same

Jan 5 2019, 9:29 PM
bb created D1732: Wondervictory entity rename.
Jan 5 2019, 8:54 PM