Page MenuHomeWildfire Games

bb
User

Projects

User Details

User Since
Jan 24 2017, 12:54 PM (107 w, 4 d)

Recent Activity

Sat, Jan 19

elexis awarded rP21957: Only update the gamesetup settings panel position when it actually changes. a Manufacturing Defect? token.
Sat, Jan 19, 11:03 PM

Jan 6 2019

bb added a comment to D1732: Wondervictory entity rename.

well from a ownershipchange we can't see if it will be a rename, so when the new ent is brought up, we don't know it actually replaces another (one could change the entitylimits and allow two wonders, so an owners check wouldn't work), so the new timer will always be activated, which afterwards needs to be removed. Also from the destroy we don't know if it is a rename (one could very well create and destroy different wonders at the same turn), so we have to do it with the ent rename.

Jan 6 2019, 2:27 PM

Jan 5 2019

bb added inline comments to D1727: Update auras when a formation member renames.
Jan 5 2019, 11:25 PM
bb accepted D1733: Rename wallset template.

grepped for completeness, agreeing on the change, translators will hate
(note to self: be careful with file move)

Jan 5 2019, 11:01 PM
bb requested verification of rP21378: Allow units to be positioned with freehand placement.

should be fixed now: rP22030

Jan 5 2019, 9:47 PM
bb committed rP22030: Fix missing assignment from rP21378.
Fix missing assignment from rP21378
Jan 5 2019, 9:47 PM
bb closed D1656: Bugfix rP21378.
Jan 5 2019, 9:46 PM
bb accepted D1656: Bugfix rP21378.

see revision, proposed the same

Jan 5 2019, 9:29 PM
bb created D1732: Wondervictory entity rename.
Jan 5 2019, 8:54 PM
bb requested changes to D1702: GUI addon to animate objects proprieties..
Jan 5 2019, 12:12 AM
bb added a comment to D1702: GUI addon to animate objects proprieties..

I guess every gui page should be able to access this file, also the mod-selection, thus mods/mod/gui/common should be the correct place

Jan 5 2019, 12:11 AM

Jan 4 2019

bb added a comment to D1537: playername → player name.

Isn't that what I say too? (notice the capital letter N)

Jan 4 2019, 9:57 PM
bb committed rP22020: Improve fishing net description.
Improve fishing net description
Jan 4 2019, 9:51 PM
bb closed D1549: Slightly rephrase the description of fishing nets.
Jan 4 2019, 9:51 PM
bb added a comment to D1727: Update auras when a formation member renames.

Don't be fooled by those two extra calls D997 tries to do, 1 of the function got removed by rP21243, and the other seems a phab bug

Jan 4 2019, 9:46 PM
bb committed rP22019: Handle entity renames in regicide.
Handle entity renames in regicide
Jan 4 2019, 9:09 PM
bb closed D1694: Handle entity renaming properly in regicide mode.
Jan 4 2019, 9:09 PM
bb accepted D1694: Handle entity renaming properly in regicide mode.

Tested against DE, correctness forces me to press accept

Jan 4 2019, 9:00 PM
bb accepted D1690: Fix Danubius ownershipchange subscription following rP21445.

Accepting because it is correct and complete for Danubius, but while looking at D1694, I guess the same bug can happen in (most of) the victory conditions, and potentially the other trigger scripts too (SotF, JB etc.)

Jan 4 2019, 4:00 PM
bb added a comment to D1694: Handle entity renaming properly in regicide mode.

Excuses for not replying to previous comments, and making you do an extra iteration...

Jan 4 2019, 3:53 PM

Jan 3 2019

bb added a comment to D1727: Update auras when a formation member renames.

reffing D997

Jan 3 2019, 9:32 PM

Dec 27 2018

bb added inline comments to D1386: Allied chat opens with t bug on linux.
Dec 27 2018, 3:00 PM
bb added a comment to D1693: Avoid unnecessary updates from updateSettingsPanelPosition.

Even better: the error wasn't introduced there

Dec 27 2018, 12:51 PM

Dec 26 2018

bb committed rP21957: Only update the gamesetup settings panel position when it actually changes..
Only update the gamesetup settings panel position when it actually changes.
Dec 26 2018, 11:35 PM
bb closed D1693: Avoid unnecessary updates from updateSettingsPanelPosition.
Dec 26 2018, 11:35 PM
bb accepted D1693: Avoid unnecessary updates from updateSettingsPanelPosition.

That should work

Dec 26 2018, 11:30 PM
bb requested changes to D1693: Avoid unnecessary updates from updateSettingsPanelPosition.

While committing thought of the programming.json: @nani please put your nick and if you want name in there and upload in a new patch on the revision so you are credited

Dec 26 2018, 10:16 PM
bb added a comment to D1693: Avoid unnecessary updates from updateSettingsPanelPosition.

introduced in rP20945 (code got shuffled a bit afterwards)

Dec 26 2018, 9:37 PM
bb accepted D1693: Avoid unnecessary updates from updateSettingsPanelPosition.

And here the guy to blame :S, can't even put off the blame by saying it was copied from the main-menu or ingame menu...

Dec 26 2018, 9:20 PM
bb updated the diff for D1469: Conquest structures fails on nomad.

fix the edgy case when only nonConquestCritical structures/units remain

Dec 26 2018, 9:05 PM
bb added inline comments to D1690: Fix Danubius ownershipchange subscription following rP21445.
Dec 26 2018, 5:58 PM
bb added a comment to D1463: Unit for summary charts time axis.

Was about to commit it, but the time displayed is minutes : seconds, so shouldn't the unit be something like minutes:ss?

Dec 26 2018, 5:52 PM
bb added a comment to D1626: -ConquestCritical clear-up.

15 removed cases, 10 added ones (if counting holds, the 15 goes down to 13 given the structure_defense_* comment)

Dec 26 2018, 5:42 PM
bb added inline comments to D1694: Handle entity renaming properly in regicide mode.
Dec 26 2018, 5:31 PM
bb added inline comments to rP21378: Allow units to be positioned with freehand placement.
Dec 26 2018, 5:02 PM

Nov 24 2018

bb added a comment to D1679: Add an option to allow players to circumvent TLS bugs.

Testing on fedora 28: patch doesn't solve the segfault, with or without the patch both segfault on lobby join. If required I could get access to a fedora 29 machine for testing.

Nov 24 2018, 3:08 PM

Oct 17 2018

bb added inline comments to rP21378: Allow units to be positioned with freehand placement.
Oct 17 2018, 7:58 PM

Aug 5 2018

bb updated the diff for D1602: Extract the terms code from the prelobby to reuse it for other term accepters (userreport).

Don't use a common/ global outside common/

Aug 5 2018, 5:53 PM

Aug 3 2018

bb updated the test plan for D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.
Aug 3 2018, 12:53 AM
bb added a parent revision for D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy: D1602: Extract the terms code from the prelobby to reuse it for other term accepters (userreport).
Aug 3 2018, 12:52 AM
bb added a child revision for D1602: Extract the terms code from the prelobby to reuse it for other term accepters (userreport): D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.
Aug 3 2018, 12:52 AM
bb updated the diff for D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.

Reflect the duplication avoid

Aug 3 2018, 12:52 AM
bb created D1602: Extract the terms code from the prelobby to reuse it for other term accepters (userreport).
Aug 3 2018, 12:52 AM

Jul 30 2018

bb updated the diff for D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.

fix an elexis' irc comment

Jul 30 2018, 2:34 PM

Jul 26 2018

bb accepted D1535: Remove quotes made unnecessary by capitalization.

complete as in all quotes around I and II are gone => accept

Jul 26 2018, 9:42 PM
bb accepted D1527: rally-point → rally point.

If that is so => accept

Jul 26 2018, 9:41 PM
bb added inline comments to D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.
Jul 26 2018, 4:40 PM
bb updated the diff for D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.
Jul 26 2018, 4:40 PM
bb added inline comments to D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.
Jul 26 2018, 1:32 AM
bb updated the test plan for D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.
Jul 26 2018, 1:17 AM
bb created D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.
Jul 26 2018, 1:16 AM

Jul 16 2018

bb added a comment to D1590: 0 A.D. Empires Ascendant Multiplayer Lobby Privacy Policy.
In D1590#63984, @Stan wrote:

What if as per article 18 one says he doesn't want his data processed for ratings. Do we delete the account ? Or do we force him not to go on rated games ? He might want to play with a fixed rating or no rating at all with player who want to get rated. How does it go

Which clause of art 18.1 applies?

Jul 16 2018, 6:39 PM
bb added inline comments to D1590: 0 A.D. Empires Ascendant Multiplayer Lobby Privacy Policy.
Jul 16 2018, 5:19 PM

Jul 9 2018

bb added a comment to D1590: 0 A.D. Empires Ascendant Multiplayer Lobby Privacy Policy.

Some digging in the GDPR leads me to two concerns (I am in no position to say if these are fixed everything is ok but would doubt if there are more problems)

Jul 9 2018, 11:29 PM

Jul 2 2018

bb added a comment to D1590: 0 A.D. Empires Ascendant Multiplayer Lobby Privacy Policy.

Read the code and comments, but as having very limited knowledge about these matter (nor an urgent will to become an expert), can't say anything about the completeness.

Jul 2 2018, 9:53 PM
bb added a comment to rP21441: Create winning teams for relic and wonder victory instead of letting all allies….

Objectives should be as straightforward as possible, as simple as possible, so I'd rather have went with only the first rule as was the case before (which doesn't mean that there might be a simple alternative satisfying more).

The objective is straightforward now, as the timer is reset on every event that the "winning team" changes

If my allies were defeated or declared war on me, that shouldn't make me lose the victory timer.

Certainly agree for lms, but in an allied victory game loosing a team member for me is enough reason to say the "team" is defeated. But as there is a new team meeting the victory conditions, a new timer is set for that team.

Jul 2 2018, 9:32 PM

Jul 1 2018

bb requested verification of rP21441: Create winning teams for relic and wonder victory instead of letting all allies….

The trick here is defining when the counter needs to be reset, to me defeating a player defending a wonder is enough reason to reset the countdown, one can argue differently however. But as the case is specifically named in the commit message Reset counters on playerDefeat requesting verification, further discussion should be in a trac ticket imo.

Jul 1 2018, 11:34 PM

Jun 28 2018

bb updated the diff for D981: Make commutative behaviour in the IsInRange function family and migrate them to a better home.
Jun 28 2018, 5:03 PM
bb added a comment to D981: Make commutative behaviour in the IsInRange function family and migrate them to a better home.
In D981#60827, @wraitii wrote:

Addendum: well while the above still seems true, another problem is that makeGoalReachable does not use a rounded rectangle but a flat one.

Jun 28 2018, 5:03 PM

Jun 25 2018

bb added a comment to D1535: Remove quotes made unnecessary by capitalization.

Checking for completeness is equal to going through all strings manually, so only checked for the Town Phase, I and II cases:

Jun 25 2018, 1:28 PM

Jun 20 2018

bb requested changes to D438: Change Run Speed into a Run multiplier.

For some reason (couldn't quickly find why) a formation moves extremely slow right after it is created, when reforming (as in setting another shape) the problem is solved.

Jun 20 2018, 11:23 PM

Jun 18 2018

bb added a comment to D1527: rally-point → rally point.

binaries/data/mods/public/gui/session/unit_actions.js has one too

Jun 18 2018, 4:42 PM
bb accepted D1537: playername → player name.

So in code it technically needs to be playerName, interesesting (out of scope comment)\

Jun 18 2018, 4:34 PM
bb accepted D1580: Improve the description of the Teacher aura.

Seems to be a pleonasm between research and technologies, but with costs also there => meh => ok

Jun 18 2018, 4:15 PM
bb accepted D1549: Slightly rephrase the description of fishing nets.
Jun 18 2018, 4:13 PM
bb accepted D1533: Reword the description of the Temple at Naqa aura.

certainly better

Jun 18 2018, 4:10 PM
bb added a comment to D1549: Slightly rephrase the description of fishing nets.

fine with me too

Jun 18 2018, 4:08 PM
bb accepted D1550: Rephrase the description of the wonder victory condition.
Jun 18 2018, 4:07 PM

Jun 14 2018

bb added a comment to D1552: Druides → Druid.

Same for the brit one

Jun 14 2018, 10:52 PM

Jun 12 2018

bb accepted D1529: BackSlash → Backslash.

Seems to be the correct English spelling indeed for the strings, in code I presume it should be BackSlash however => patch complete

Jun 12 2018, 4:23 PM
bb accepted D1530: cit-states → city-states.
Jun 12 2018, 4:17 PM
bb accepted D1574: Get XML syntax errors not only the first time that file is loaded.

If it would crash for mods, the mods would receive an error in the current code, thus not caching the file wouldn't change much there.

Jun 12 2018, 4:13 PM
bb added inline comments to D1570: Fix typo in lobby server README.
Jun 12 2018, 3:57 PM
bb accepted D1553: multi-coloured → multi-colored.

In the code there are many more cases of colour which strictly speaking should be changed, but whatever

Jun 12 2018, 3:54 PM

Jun 11 2018

bb accepted rP19694: Allow walls and fields to be captured by territory but not by capture attack….

Looks like fixed

Jun 11 2018, 11:38 PM

Jun 8 2018

bb accepted D1536: barracks → Barracks.
Jun 8 2018, 9:40 PM
bb accepted D1528: Chose → Choose (imperative).
Jun 8 2018, 9:37 PM
bb added inline comments to D1550: Rephrase the description of the wonder victory condition.
Jun 8 2018, 9:36 PM

Jun 1 2018

bb accepted D1539: <sentence> and <long sentence> and <long sentence> → <sentence> and <long sentence>. <long sentence>.

certainly (didn't check if more of these cases occur, presumably yes, but that requires reading through all strings => meh)

Jun 1 2018, 11:05 PM
bb added a comment to D1536: barracks → Barracks.

Have a look at these also: (AI comments can be left out in imo)

Jun 1 2018, 11:04 PM
bb accepted D1534: constructed → ready (a field).

Technically speaking of code and animations, the field is just as "constructed" as any other building, but probably sounds better otherwise

Jun 1 2018, 10:58 PM
bb added a comment to D1528: Chose → Choose (imperative).

(Don't we have some inline in another revision about this?)

Jun 1 2018, 10:57 PM
bb accepted D1531: aide → aid.

I will thrust you, you just removed that one character in that string (wondering why phab isn't highlighting it properly)

Jun 1 2018, 10:51 PM
bb accepted D1526: reaffect → reassign.

Noticed them some times before, thx for fixing them
patch correct and complete, not sure these kind of patches require a review, but whatever
should be committed in A24 development (so wait for an official leave of commit freeze)

Jun 1 2018, 10:47 PM
bb requested changes to D1504: Small commands.js cleanup.
Jun 1 2018, 10:24 PM
bb added a comment to D1469: Conquest structures fails on nomad.
In D1469#60219, @temple wrote:

Now you can lose with conquest structures even if you have structures left, or lose with conquest units even if you have units left. Non-conquest-critical ones (e.g. market + traders), but still.
Not sure about an alternative solution, other than to advise people not to choose conquest structures when playing nomad.

Jun 1 2018, 10:13 PM

May 9 2018

bb added a comment to rP21108: Set victory conditions for autostart games..

endless support readded in rP21474

May 9 2018, 12:53 PM

May 7 2018

bb accepted rP21630: Fix UnitAI behaviour inconsistent with its stance for packed units and set….

resolved

May 7 2018, 11:50 PM

Apr 27 2018

bb abandoned D1180: Set a tooltip for switching tabs and generalize coloredHotkey to allow multiple hotkeys.

Got lesser and lesser convinced of this patch over time...

Apr 27 2018, 4:31 PM

Apr 24 2018

bb created D1469: Conquest structures fails on nomad.
Apr 24 2018, 4:49 PM

Apr 23 2018

bb accepted D1463: Unit for summary charts time axis.

for after release

Apr 23 2018, 5:34 PM
bb committed rP21771: Hide the settingsPanel for non-controllers.
Hide the settingsPanel for non-controllers
Apr 23 2018, 5:30 PM
bb closed D1243: Default Hide Tab Content Of Game Settings In Game Setup.
Apr 23 2018, 5:29 PM
bb committed rP21770: Tidy up gamesetup initGUIObjects.
Tidy up gamesetup initGUIObjects
Apr 23 2018, 5:09 PM
bb committed rP21769: Split the sliding logic from the moving logic for the settingsPanel in gamesetup.
Split the sliding logic from the moving logic for the settingsPanel in gamesetup
Apr 23 2018, 4:51 PM
bb accepted D1243: Default Hide Tab Content Of Game Settings In Game Setup.

default argument also brings some duplicate hardcodings (for the controller case), so thx for the stubbornness

Apr 23 2018, 4:38 PM
bb committed rP21768: Use esc to close the tabs in gamesetup.
Use esc to close the tabs in gamesetup
Apr 23 2018, 4:08 PM
bb closed D1242: On Cancel Hide Tab Content On New Gamesetup UI.
Apr 23 2018, 4:08 PM
bb accepted D1242: On Cancel Hide Tab Content On New Gamesetup UI.

I misread in last comment, patch actually correct. A hotkey string should be added after the release

Apr 23 2018, 3:16 PM

Apr 22 2018

bb accepted D1464: Immediately update gui visibility when pressing the hotkey to toggle it.

Don't see an answer to the bonus question

Apr 22 2018, 7:07 PM