Page MenuHomeWildfire Games

bb
User

Projects

User Details

User Since
Jan 24 2017, 12:54 PM (284 w, 1 d)

Recent Activity

May 17 2022

wraitii awarded rP26889: Fix an infinite loop when trying to word-wrap a The World Burns token.
May 17 2022, 2:44 PM
bb committed rP26889: Fix an infinite loop when trying to word-wrap.
Fix an infinite loop when trying to word-wrap
May 17 2022, 2:11 PM
bb closed D4530: Fix an infinite loop when trying to word-wrap.
May 17 2022, 2:11 PM

Apr 30 2022

bb added a comment to D4527: Don't segfault on autostart nonVisual games after rP26584.

I think D4628 is overall the cleaner approach

Looks like at first site.

Apr 30 2022, 9:55 PM

Mar 14 2022

bb requested verification of rP26520: smoother formation manouvres.
Mar 14 2022, 8:51 PM
bb committed rP26651: Handle OutOfWorld for formations.
Handle OutOfWorld for formations
Mar 14 2022, 8:51 PM
bb closed D4535: Handle OutOfWorld for formations.
Mar 14 2022, 8:51 PM

Mar 9 2022

bb updated the diff for D4535: Handle OutOfWorld for formations.

tweaks

Mar 9 2022, 10:21 PM
bb added a comment to D4534: [WIP] fix formation not beeing in world after rP26520.

Sorry completely missed this, and created an own similar version as linked above.

Mar 9 2022, 10:05 PM
bb added inline comments to D4312: Error out on unstringifiable commands.
Mar 9 2022, 9:57 PM
bb requested review of D4535: Handle OutOfWorld for formations.
Mar 9 2022, 4:44 PM
bb added inline comments to D4530: Fix an infinite loop when trying to word-wrap.
Mar 9 2022, 3:36 PM
bb updated the diff for D4530: Fix an infinite loop when trying to word-wrap.

fix offsets

Mar 9 2022, 3:34 PM
bb planned changes to D4530: Fix an infinite loop when trying to word-wrap.
Mar 9 2022, 3:10 PM
bb added inline comments to D4530: Fix an infinite loop when trying to word-wrap.
Mar 9 2022, 3:04 PM
bb updated the diff for D4530: Fix an infinite loop when trying to word-wrap.
Mar 9 2022, 3:04 PM
bb requested review of D4530: Fix an infinite loop when trying to word-wrap.
Mar 9 2022, 1:46 AM

Mar 8 2022

bb added inline comments to D4527: Don't segfault on autostart nonVisual games after rP26584.
Mar 8 2022, 8:29 PM

Mar 7 2022

bb added inline comments to D4486: Fix maps after rP26298..
Mar 7 2022, 4:08 PM
bb updated the diff for D4527: Don't segfault on autostart nonVisual games after rP26584.

Less questionable approach: only load the gui and shield the g_Renderer call.

Mar 7 2022, 11:45 AM
bb requested review of D4527: Don't segfault on autostart nonVisual games after rP26584.
Mar 7 2022, 12:54 AM
bb updated the diff for D4312: Error out on unstringifiable commands.

Fix ai trade route setup

Mar 7 2022, 12:30 AM

Mar 6 2022

bb committed rP26587: [A26 Gameplay] Tweak the formation turning threshold.
[A26 Gameplay] Tweak the formation turning threshold
Mar 6 2022, 10:33 PM
bb closed D4517: [Gameplay] Tweak the formation turning threshold.
Mar 6 2022, 10:33 PM
bb committed rP26586: further optimizations for map Unknown: Passes.
further optimizations for map Unknown: Passes
Mar 6 2022, 10:31 PM
bb closed D4526: further optimizations for map Unknown: Passes.
Mar 6 2022, 10:30 PM
bb accepted D4526: further optimizations for map Unknown: Passes.

Looks good and correct.

Mar 6 2022, 10:28 PM
bb committed rP26584: Let the Gamesetup.cpp Autostart (starting from cl) use the gamesettings via the….
Let the Gamesetup.cpp Autostart (starting from cl) use the gamesettings via the…
Mar 6 2022, 10:12 PM
bb closed D4492: Let the Gamesetup.cpp Autostart (starting from cl) use the gamesettings via the autostart gui page..
Mar 6 2022, 10:12 PM
bb committed rP26583: Generalize fromInitAttributes loop.
Generalize fromInitAttributes loop
Mar 6 2022, 10:02 PM
bb closed D4521: Generalize fromInitAttributes loop.
Mar 6 2022, 10:01 PM
bb updated the diff for D4521: Generalize fromInitAttributes loop.

Don't create the same function every loop

Mar 6 2022, 3:09 PM
bb updated the diff for D4521: Generalize fromInitAttributes loop.
Mar 6 2022, 1:33 PM
bb added inline comments to D4486: Fix maps after rP26298..
Mar 6 2022, 12:33 PM
bb updated the diff for D4492: Let the Gamesetup.cpp Autostart (starting from cl) use the gamesettings via the autostart gui page..

Don't forget the readme.txt and add a random comment to CIV

Mar 6 2022, 12:13 PM
bb updated the diff for D4521: Generalize fromInitAttributes loop.

Please linter

Mar 6 2022, 11:13 AM
bb awarded D4512: [gameplay - Alpha 26] bump up the acceleration a Dislike token.
Mar 6 2022, 10:46 AM
bb awarded D4512: [gameplay - Alpha 26] bump up the acceleration a Like token.
Mar 6 2022, 10:42 AM
bb awarded D4512: [gameplay - Alpha 26] bump up the acceleration a Dislike token.
Mar 6 2022, 10:42 AM
bb committed rP26572: Make sure PlayerCiv values are initialized.
Make sure PlayerCiv values are initialized
Mar 6 2022, 10:41 AM
bb closed D4522: Make sure PlayerCiv values are initialized.
Mar 6 2022, 10:40 AM

Mar 4 2022

bb requested review of D4522: Make sure PlayerCiv values are initialized.
Mar 4 2022, 5:34 PM
bb updated the diff for D4521: Generalize fromInitAttributes loop.

Claim creative ownership since virtually every line has changed (not counting the spaces => tabs). All comments have been revamped.

Mar 4 2022, 4:44 PM
bb raised a concern with rP26438: Fix not selectable civilisations not showing if defined by the map.
Mar 4 2022, 4:28 PM
bb added a comment to D4521: Generalize fromInitAttributes loop.

refs D4312

Mar 4 2022, 3:23 PM
bb updated the diff for D4521: Generalize fromInitAttributes loop.
Mar 4 2022, 3:14 PM
bb updated the diff for D4521: Generalize fromInitAttributes loop.

Better difference checking with a deepCompare function based on https://www.joshbritz.co/posts/why-its-so-hard-to-check-object-equality/
Including tests

Mar 4 2022, 3:13 PM
bb added inline comments to D4521: Generalize fromInitAttributes loop.
Mar 4 2022, 3:12 PM
bb added a comment to D4492: Let the Gamesetup.cpp Autostart (starting from cl) use the gamesettings via the autostart gui page..
  • If you start the given example from the binaries/system/readme.txt -autostart="scenarios/Arcadia" -autostart-host -autostart-host-players=2 -autostart-playername="Bob" it will give errors.

Arcadia needs to be written in lowercase.

Don't blame this patch for that. Just blame me for rP23719. ;)

Mar 4 2022, 11:55 AM
bb updated the diff for D4492: Let the Gamesetup.cpp Autostart (starting from cl) use the gamesettings via the autostart gui page..

Help Arcadia of its cap see rP23719

Mar 4 2022, 11:55 AM

Mar 3 2022

bb added a comment to D1768: Formations: GetClosestMember passes wrong entity to filter function.

I fail to see how the bug you describe relates to this patch directly. I can see that choosing the same formation member over and over again can cause an infinite loop, however this patch won't cause that. In fact with this bug fixed one could fix it: if there are members failing for whatever reason, they can be excluded by the filter.

Mar 3 2022, 11:12 PM
bb requested review of D4521: Generalize fromInitAttributes loop.
Mar 3 2022, 10:23 PM
bb added a comment to D4287: [WIP] Add the possibility to start a game with a random civ from the command line..

One should test whether D4492 doesn't just include this by passing "random".

Mar 3 2022, 9:47 PM
bb committed rP26535: Generalise gamesettings pickRandomItems' loop.
Generalise gamesettings pickRandomItems' loop
Mar 3 2022, 5:13 PM
bb closed D4231: Generalise gamesettings pickRandomItems' loop.
Mar 3 2022, 5:13 PM
bb committed rP26533: removeable => removable.
removeable => removable
Mar 3 2022, 3:52 PM
bb closed D3663: Fix typo in ENUM.
Mar 3 2022, 3:52 PM
bb accepted D3663: Fix typo in ENUM.

Greps complete looks correct

Mar 3 2022, 3:40 PM
bb abandoned D3662: Fix typo in log message.

All upstream (also those other found by grep).

Mar 3 2022, 3:28 PM
bb committed rP26532: introduce template_unit_siege_flamethrower.xml.
introduce template_unit_siege_flamethrower.xml
Mar 3 2022, 3:12 PM
bb closed D3576: introduce template_unit_siege_flamethrower.xml.
Mar 3 2022, 3:12 PM
bb updated the diff for D4083: Fix invalid translation in options.json.

Make the l10n.js aware of the _string keyword over an unused message keyword

Mar 3 2022, 2:10 PM
bb requested changes to D4083: Fix invalid translation in options.json.
Mar 3 2022, 12:50 PM
bb added inline comments to D4083: Fix invalid translation in options.json.
Mar 3 2022, 12:49 PM
bb committed rP26530: Allied chat opens with t bug (on linux).
Allied chat opens with t bug (on linux)
Mar 3 2022, 12:36 PM
bb closed D1386: Allied chat opens with t bug on linux.
Mar 3 2022, 12:36 PM

Mar 2 2022

bb updated the diff for D3247: Use rotation times on all unitMotion driven rotations..

fix a segfault

Mar 2 2022, 10:13 PM
bb committed rP26523: Set the size of the overlaybox without relying on the arbitrary initSize.
Set the size of the overlaybox without relying on the arbitrary initSize
Mar 2 2022, 5:27 PM
bb closed D4489: Set the size of the overlaybox without relying on the arbitrary initSize.
Mar 2 2022, 5:27 PM
bb committed rP26522: Fix BufferZone in right alignment.
Fix BufferZone in right alignment
Mar 2 2022, 5:14 PM
bb closed D4490: Fix BufferZone in right alignment.
Mar 2 2022, 5:14 PM
bb requested review of D4517: [Gameplay] Tweak the formation turning threshold.
Mar 2 2022, 5:10 PM
bb committed rP26521: Fix template type in rP26520.
Fix template type in rP26520
Mar 2 2022, 4:56 PM
bb added a comment to D4492: Let the Gamesetup.cpp Autostart (starting from cl) use the gamesettings via the autostart gui page..

I noticed right away the word anonymous for a missing -autostart-playername flag. I can live with that, optimal I would want my name from the user.cfg file being used.

While I agree we should be using the user.cfg thingy or even the system username if that doesn't exists. I don't want to change this here, since this patch is meant to just implement the basics and copy the current autostart behaviour. Many things can be improved from here, including the playername.

Mar 2 2022, 3:23 PM
bb updated the diff for D4492: Let the Gamesetup.cpp Autostart (starting from cl) use the gamesettings via the autostart gui page..

Fix the issues noticed above

Mar 2 2022, 3:23 PM
bb committed rP26520: smoother formation manouvres.
smoother formation manouvres
Mar 2 2022, 1:55 PM
bb closed D4294: smoother formation manouvres.
Mar 2 2022, 1:55 PM

Feb 27 2022

bb added a comment to D4512: [gameplay - Alpha 26] bump up the acceleration.

Another way is to reduce the walk and run speeds across the board. Probably has the same visual effect, just slows the game down overall.

Feb 27 2022, 1:58 PM

Feb 26 2022

Langbart awarded D4492: Let the Gamesetup.cpp Autostart (starting from cl) use the gamesettings via the autostart gui page. a Love token.
Feb 26 2022, 3:22 AM

Feb 22 2022

bb updated the diff for D4492: Let the Gamesetup.cpp Autostart (starting from cl) use the gamesettings via the autostart gui page..

Deciding against moving stuff to the mod mod. We can't know how a mod wants to start the game, so the best we can do is just try to open the autostart*.xml if the mod has one (and crash otherwise).

Feb 22 2022, 6:28 PM
bb committed rP26464: Let StartingCamera react upon change in number of players.
Let StartingCamera react upon change in number of players
Feb 22 2022, 5:35 PM
bb closed D4498: Let StartingCamera react upon change in number of players.
Feb 22 2022, 5:35 PM

Feb 21 2022

bb added inline comments to D4492: Let the Gamesetup.cpp Autostart (starting from cl) use the gamesettings via the autostart gui page..
Feb 21 2022, 2:06 PM
bb added a comment to rP26393: Remove useless persistMatchSettings and handle some which weren't handled.

certainly

Feb 21 2022, 12:51 PM

Feb 20 2022

bb accepted D4294: smoother formation manouvres.

The formation is also reforming on regular intervals, making the idle counter flikker.

Feb 20 2022, 2:12 PM
bb updated the diff for D4492: Let the Gamesetup.cpp Autostart (starting from cl) use the gamesettings via the autostart gui page..

Fix the comments above.

Feb 20 2022, 1:44 AM

Feb 19 2022

bb added a comment to D4083: Fix invalid translation in options.json.

The extractors script got updated in rP26422. So one can use the following syntax: { "value": 1, "label": { "_string": "Very Easy", "context": "Difficulty of the AI" }. Behavior is very similar as that of the xml extractor.

Feb 19 2022, 6:24 PM
bb committed rP26422: Allow more general contexts in json translatable strings.
Allow more general contexts in json translatable strings
Feb 19 2022, 6:21 PM
bb closed D4483: Allow more general contexts in json translatable strings.
Feb 19 2022, 6:21 PM
bb added inline comments to rP26421: Add Han Chinese Maps.
Feb 19 2022, 6:07 PM
bb accepted D4429: Fix #6145.

Don't forget to re-add Spartans.

Feb 19 2022, 5:12 PM
bb added a comment to D4486: Fix maps after rP26298..

Not sure if I am verly happy with using a engine function in the globalscripts which is defined in sim/gui. Maybe should have an seperate JSInterface for Templates. Though we still would want to use the templateManager in the sim.

Feb 19 2022, 4:56 PM
bb accepted D4484: Make Icon non-optional..

grepping on "special/player" yields some places in the code (both js and source) for which it is good we don't have the parent template anymore.
Atlas front does not fall.
Units demo front doesn't fall

Feb 19 2022, 3:44 PM

Feb 17 2022

bb added inline comments to D4294: smoother formation manouvres.
Feb 17 2022, 6:11 PM
bb added a comment to D4294: smoother formation manouvres.

Different unit classes make things harder indeed. So we need to do some playtesting.

Feb 17 2022, 5:56 PM
bb added a comment to D4294: smoother formation manouvres.

Regarding the template values for different formations: I guess we should look how much symmetry the shape has:

  • Things like lines and columns (but also flank/syntagma/skirmish/anti-cav/phalanx) basically have a 2 fold rotational symmetry (meaning we can rotate by 180deg (Pi rad) and we have essentially the same shape). So for any of these type we should have a value of 90deg(Pi/2 rad) (we should switch about halfway between turning and repositioning).
Feb 17 2022, 3:06 PM
bb added a comment to D4492: Let the Gamesetup.cpp Autostart (starting from cl) use the gamesettings via the autostart gui page..

hosting currently broken.

Feb 17 2022, 12:14 AM

Feb 16 2022

bb added inline comments to D4492: Let the Gamesetup.cpp Autostart (starting from cl) use the gamesettings via the autostart gui page..
Feb 16 2022, 9:51 PM
bb requested review of D4492: Let the Gamesetup.cpp Autostart (starting from cl) use the gamesettings via the autostart gui page..
Feb 16 2022, 8:06 PM
bb added a comment to D1386: Allied chat opens with t bug on linux.

Maybe IGUIObject.IsFocused should be changed that the object on the back page does not show up as focused.

Feb 16 2022, 12:58 AM