Page MenuHomeWildfire Games

bb
User

Projects

User Details

User Since
Jan 24 2017, 12:54 PM (166 w, 6 d)

Recent Activity

Mar 6 2020

bb added a comment to D2296: StatusEffects v3 - More cleanup, allow stackable, upgrades..

What happens if these values become modifiable by techs? or otherwise get modified during the game? putting the strings in the template basically kills this possibility (one should also mod the tooltip with the same tech => hard to maintain). However I am not sure if we need to allow this to be modifiable.

Mar 6 2020, 10:36 PM

Feb 21 2020

bb added a comment to D2296: StatusEffects v3 - More cleanup, allow stackable, upgrades..

Random thought for the if else repeat mess: put all strings in a global with MarkForTranslation and get the correct on by constructing it using the template properties. Also translators might like some context

Feb 21 2020, 10:52 PM

Feb 17 2020

bb committed rP23504: Correct military colony footprint/obstruction.
Correct military colony footprint/obstruction
Feb 17 2020, 7:01 PM
bb closed D2639: adjust ptol military colony footprint.
Feb 17 2020, 7:01 PM
bb added inline comments to D2639: adjust ptol military colony footprint.
Feb 17 2020, 6:59 PM
bb accepted D2639: adjust ptol military colony footprint.

Correct and complete, no need to let this rot

Feb 17 2020, 6:56 PM
bb added inline comments to D1398: Fix shiftlag and implement HotkeyDown event, change HotkeyPress event to be non-repeating.
Feb 17 2020, 12:15 AM

Feb 16 2020

bb updated the diff for D1398: Fix shiftlag and implement HotkeyDown event, change HotkeyPress event to be non-repeating.

Fix years

Feb 16 2020, 10:29 PM
bb added inline comments to D1398: Fix shiftlag and implement HotkeyDown event, change HotkeyPress event to be non-repeating.
Feb 16 2020, 10:24 PM
bb updated the diff for D1398: Fix shiftlag and implement HotkeyDown event, change HotkeyPress event to be non-repeating.

Rebase

Feb 16 2020, 10:23 PM

Feb 12 2020

bb added a member for Contributors: Ampaex.
Feb 12 2020, 8:52 PM
bb added inline comments to D2375: Do not require a garrisonHolder to have health..
Feb 12 2020, 8:17 PM
bb added a comment to D2573: Fix AI OOS on rejoin related to random calls.

For those who want:

Feb 12 2020, 3:30 PM
bb added a comment to D2573: Fix AI OOS on rejoin related to random calls.

OOS at turn 80:

Feb 12 2020, 3:22 PM

Feb 11 2020

bb edited reviewers for D2502: adjust wall footprints etc, added: Restricted Owners Package; removed: Restricted Owners Package.
Feb 11 2020, 11:18 PM
bb requested changes to D2502: adjust wall footprints etc.

I made a testing map for this patch: you can see the obstruction sizes in game by opening the map ingame, hitting alt+D and toggling the pathfinder overlay (and possibly the obstruction overlay), this will give you a easier way to tweak the obstruction sizes. Many walls already have the correct size, a couple not (the persian walls looked good for example, mostly gates seems a bit "oversized").

Feb 11 2020, 11:17 PM
bb added a comment to D2625: Set m_RNG in Ai Deserialisation as last.

Performing the test plan yields an oos:

--- oos_dump1.txt	2020-02-11 21:35:38.942198026 +0100
+++ oos_dump.txt	2020-02-11 21:35:38.988197402 +0100
@@ -1550,7 +1550,7 @@
     value: 154
   AIManager:
     num ais: 1
-    rng: "247049416601596"
+    rng: "259292060214002"
     turn: 0
     useSharedScript: true
     sharedData: {
Feb 11 2020, 9:43 PM
bb committed rP23493: Removing trailing 0's and leading +'s from operators in templates..
Removing trailing 0's and leading +'s from operators in templates.
Feb 11 2020, 9:08 PM
bb closed D2609: minor template operator corrections.
Feb 11 2020, 9:08 PM
bb accepted D2609: minor template operator corrections.

Grepped for completeness. Front doesn't fall.

Feb 11 2020, 9:06 PM
bb committed rP23492: Correct watermarks aspect ratio.
Correct watermarks aspect ratio
Feb 11 2020, 9:30 AM
bb closed D2589: correct watermark aspect ratio.
Feb 11 2020, 9:30 AM

Jan 29 2020

bb added a comment to D2573: Fix AI OOS on rejoin related to random calls.

Looking at the identity component I see a similar structure: a random call on init. Why is this not creating an OOS?

Jan 29 2020, 9:44 PM

Jan 25 2020

bb accepted D2594: [gui]: two decimals for gather rate tooltips.
Jan 25 2020, 5:22 PM
bb added a comment to D2594: [gui]: two decimals for gather rate tooltips.

All relevant cases of resourceGatherRates covered.

Jan 25 2020, 5:22 PM

Jan 23 2020

bb accepted D2589: correct watermark aspect ratio.

diff 11136 appears best for me, maybe some artist wants to have an opinion?

Jan 23 2020, 4:07 PM

Jan 22 2020

bb committed rP23432: Remove trailing 0's from Armour items in templates.
Remove trailing 0's from Armour items in templates
Jan 22 2020, 11:23 PM
bb closed D2280: remove armour trailing zeroes from templates.
Jan 22 2020, 11:23 PM
bb accepted D2280: remove armour trailing zeroes from templates.

All Armour values got consistent now, feel free to removing trailing 0's from other template values too

Jan 22 2020, 11:20 PM
bb committed rP23431: Merge kushites champion infantry attack bonusses.
Merge kushites champion infantry attack bonusses
Jan 22 2020, 11:13 PM
bb closed D2262: Use matching classes in damage bonus (from rP22769)..
Jan 22 2020, 11:13 PM
bb accepted D2262: Use matching classes in damage bonus (from rP22769)..

Looks correct and complete to me

Jan 22 2020, 10:54 PM

Jan 21 2020

bb accepted rP23392: Landscape and Daytime gamesetup options for the Unknown, Danubius and Polar Sea….

bug disappeared

Jan 21 2020, 4:55 PM
bb accepted rP23374: Gamesetup class rewrite, fixes #5322, refs #5387..

Reported bug has been fixed, one can notice that the animation changed in the case when switching from 2 to 1 tab (there now is a gap between the panelButtons and the settingsPanel). New version fine with me too

Jan 21 2020, 4:54 PM

Jan 14 2020

bb added a comment to D2404: Optimize GetIdentityClasses in Templates.js.

Testing with SM gave that string without regex is fastest (about 20x), difference between other options is small.

Jan 14 2020, 10:41 PM
bb committed rP23393: Standardize modmod buttons width.
Standardize modmod buttons width
Jan 14 2020, 10:03 PM
bb closed D2569: gui: standardize modmod buttons width.
Jan 14 2020, 10:03 PM
bb accepted D2400: Optimize Resource Trickle by not running timers when not necessary.

only trivialities left

Jan 14 2020, 9:50 PM
bb added a comment to D2425: Show number of builders besides (not in space) build time..

Adding the number of builders to the "front page" should imply adding the time left to the tooltip

Jan 14 2020, 9:11 PM
bb accepted D2569: gui: standardize modmod buttons width.
Jan 14 2020, 9:02 PM
bb added inline comments to D2546: Adds an option to enable/disable building snapping.
Jan 14 2020, 8:38 PM
bb added a comment to D2545: Building snapping loading screen tip.

D2546 would require to change this

Jan 14 2020, 8:27 PM
bb added inline comments to D2569: gui: standardize modmod buttons width.
Jan 14 2020, 8:23 PM
bb added a comment to rP23392: Landscape and Daytime gamesetup options for the Unknown, Danubius and Polar Sea….

The random Random map ;)

Jan 14 2020, 7:15 PM
bb raised a concern with rP23374: Gamesetup class rewrite, fixes #5322, refs #5387..

On min res: enable both relics and regicide. Not all options are visible

Jan 14 2020, 12:26 PM
bb raised a concern with rP23392: Landscape and Daytime gamesetup options for the Unknown, Danubius and Polar Sea….

When starting a SP match

ERROR: JavaScript error: gui/gamesetup/GameSettings/Single/Dropdowns/Landscape.js line 97
TypeError: this.mapData is undefined
  onPickRandomItems@gui/gamesetup/GameSettings/Single/Dropdowns/Landscape.js:97:7
  pickRandomItems@gui/gamesetup/Controls/GameSettingsControl.js:247:4
  onLaunchGame@gui/gamesetup/Controls/GameSettingsControl.js:255:3
  launchGame@gui/gamesetup/Controls/StartGameControl.js:35:4
  onPress@gui/gamesetup/Panels/Buttons/StartGameButton.js:61:3
Jan 14 2020, 12:17 PM

Jan 13 2020

bb added inline comments to D2404: Optimize GetIdentityClasses in Templates.js.
Jan 13 2020, 7:48 PM
bb committed rP23387: Move the credits button on main menu.
Move the credits button on main menu
Jan 13 2020, 7:34 PM
bb closed D2430: list “Credits” above “Exit”.
Jan 13 2020, 7:33 PM
bb updated the diff for D1205: Cleanup summary selection from D810 / rP20644.

rebase

Jan 13 2020, 7:31 PM
bb added inline comments to D2525: Define auto-gather/-build ranges in template..
Jan 13 2020, 1:52 PM
bb accepted D2430: list “Credits” above “Exit”.

change seems same

Jan 13 2020, 1:12 PM
bb added a comment to rP23374: Gamesetup class rewrite, fixes #5322, refs #5387..

refs #5663

Jan 13 2020, 12:49 PM

Oct 15 2019

bb committed rP23074: Fix PanelEntButton undefined, by not trying to fill gui elements that don't….
Fix PanelEntButton undefined, by not trying to fill gui elements that don't…
Oct 15 2019, 4:24 PM
bb closed D1397: Entities panel error out on hero death.
Oct 15 2019, 4:24 PM

Oct 12 2019

bb updated the diff for D1398: Fix shiftlag and implement HotkeyDown event, change HotkeyPress event to be non-repeating.
Oct 12 2019, 11:11 PM
bb added inline comments to D1398: Fix shiftlag and implement HotkeyDown event, change HotkeyPress event to be non-repeating.
Oct 12 2019, 11:08 PM
bb updated the diff for D1398: Fix shiftlag and implement HotkeyDown event, change HotkeyPress event to be non-repeating.

Rebase

Oct 12 2019, 11:06 PM

Sep 30 2019

bb added a comment to D1958: Turrets and/or sub-units..

Per request by @Freagarach some outdated draft I once made but never finished

Sep 30 2019, 3:21 PM

Sep 22 2019

bb raised a concern with rP22970: Adds a "properties"-property to resources and let mods be able to prevent….
Sep 22 2019, 9:41 PM
bb added a comment to D2306: remove "Goods" from trade window stings.

String here seems to originate from rP14417, for me "Resources" is indeed an improvement. One might want to nuke "goods" in the code too

Sep 22 2019, 4:41 PM
bb committed rP22968: Use arrow functions in AI filters.
Use arrow functions in AI filters
Sep 22 2019, 4:01 PM
bb closed D1883: Use arrow functions in ai filters.
Sep 22 2019, 4:01 PM

Sep 9 2019

bb updated the diff for D1398: Fix shiftlag and implement HotkeyDown event, change HotkeyPress event to be non-repeating.

Notice that mouseWheel and mouseButton events are never repeated (at least that is what testing says here)

Sep 9 2019, 8:28 PM

Sep 5 2019

bb added inline comments to D1398: Fix shiftlag and implement HotkeyDown event, change HotkeyPress event to be non-repeating.
Sep 5 2019, 1:41 PM

Sep 4 2019

bb updated the diff for D1398: Fix shiftlag and implement HotkeyDown event, change HotkeyPress event to be non-repeating.
Sep 4 2019, 8:05 PM

Aug 30 2019

bb added inline comments to D1398: Fix shiftlag and implement HotkeyDown event, change HotkeyPress event to be non-repeating.
Aug 30 2019, 8:32 PM
bb updated the diff for D1398: Fix shiftlag and implement HotkeyDown event, change HotkeyPress event to be non-repeating.
Aug 30 2019, 7:18 PM
bb added inline comments to D2064: Move "PlayersToDamage" from calling functions to "CauseDamageOverArea" and replace it with FF..
Aug 30 2019, 5:49 PM
bb added inline comments to D2200: fix a wrong class (CitizenSoldier).
Aug 30 2019, 5:25 PM
bb added a comment to D2064: Move "PlayersToDamage" from calling functions to "CauseDamageOverArea" and replace it with FF..

did not check for completeness, however committing stuff reduces rebases...

Aug 30 2019, 5:20 PM
bb added a comment to rP22754: Generalise Attack effects. All attacks, including death damage and splash, can….
In D368#91976, @wraitii wrote:

@bb: I've committed rP22754, making "Damage" and "Capture" not based on the attack names, allowing you to drop that from this diff.
I think you'll find my final decision OK with regards to how templates get written.
If not, feel free to discuss this by PM or on a forum thread or through the audit feature or something.

I am actually quite positive about this patch, thanks for the endurance, I think it ended up in better code after all. However the above appears to give me the right to be picky ;)

Aug 30 2019, 5:03 PM

Aug 5 2019

bb committed rP22615: redo rP21036, Create a ConfigDB_CreateAndWriteValueToFile function to absorb….
redo rP21036, Create a ConfigDB_CreateAndWriteValueToFile function to absorb…
Aug 5 2019, 4:13 PM
bb closed D1939: redo rP21036, Create a ConfigDB_CreateAndWriteValueToFile function to absorb some duplication in the gui.
Aug 5 2019, 4:13 PM
bb added a comment to D1939: redo rP21036, Create a ConfigDB_CreateAndWriteValueToFile function to absorb some duplication in the gui.
In D1939#87819, @elexis wrote:

modmod.js saveMods() should also be updated; it wasn't present there since the function was located public/.

We call WriteFile there, so everytime we save the mods, we save everything, sounds wrong...

Aug 5 2019, 12:49 PM

Aug 4 2019

bb added a comment to D2112: Fix "GetBestAttackAgainst"-function in "Attack.js"..

This probably wasn't done at the time since I didn't want to change code twice, but the change is in principle correct

Aug 4 2019, 12:36 PM
bb added a comment to D2038: Let "GetBestAttackAgainst" depend on DPS..

In D368 DPS has its function in the DamageReciever. Range is added as a multiplication factor:

  • in range, the factor is 1
  • inside minrange or outside maxrange we let the factor drop exponentially
Aug 4 2019, 12:34 PM

Jul 25 2019

bb added a comment to D2092: Generalise Attack effects - any attack can do damage, capture, inflict status effects, including splash. Also damage bonuses..

D368 way

Template structure:

<AttackType>
   <Effects>
      <Hack>5</Hack>
      <Capture>4</Capture>
      <StatusEffects>
         <Burn>...</Burn>
      </StatusEffects>
   </Effects>
</AttackType>

Not exactly what is proposed:

<AttackType>
   <Effects>
      <Damage>
         <Hack>5</Hack>
         <Capture>4</Capture>
      </Damage>
      <StatusEffects>
         <Burn>...</Burn>
      </StatusEffects>
   </Effects>
</AttackType>

(Even more precise would be without the Effects indentation, but fine with adding that)
Pros:
Effects can be iterated over
Nodes reflect the component it maps to (Damage to DamageReciever, StatusEffect to statuseffectReceiver), thus no hardcoding of these
Damagetypes can be iterated over within all effects, thus statusEffects can capture immediately

Jul 25 2019, 1:28 PM
bb added a comment to D2109: Move duplicated "Attack.js" schema code to helper..

The question is preferred classes and restricted classes (ping @bb ). Are they a property of the attacker or the attack itself.
Preferred classes seem obviously the first - it's a hint to unitAI, relating to GetBestAttackAgainst (@Freagarach please split from D2044 ;) ).

Well I agree on the statement that preferred classes should be an attacker unitAI hint, which targets it should attack. However that has not much todo with GetBestAttackAgainst since there we already have chosen the target. Maybe preferred classes should be in the unitAI template instead?

There are two behaviours: making attacks ineffective (related to D2044), and hints to unitAI - which may or may not be needed. For walls for example - if we made the impervious to hack/pierce, they would effectively be restricted from damage by non-siege units right now.

If there are two behaviors maybe make two template entries, one for each?

Jul 25 2019, 1:04 PM

Jul 22 2019

bb added a comment to rP22527: Easier introduction of new damage types..

However, we never actually need to refer to this script since we can always use the damage types provided by the template/context/object we are looping over/...

That part is contested when/if we want to generalize damagetype to affect other components than just Health or if we want to set any other damageType specific value (i.e. one could think of making "crush" only work on building class units, setting immunities could work for this case too, but there might be other similar ideas)

Jul 22 2019, 9:57 PM
bb awarded rP22527: Easier introduction of new damage types. a Heartbreak token.
Jul 22 2019, 9:57 PM

Jul 18 2019

bb updated the diff for D1397: Entities panel error out on hero death.

A replay for current svn:

Jul 18 2019, 12:56 PM
bb updated the Trac tickets for D1397: Entities panel error out on hero death.
Jul 18 2019, 12:21 PM
bb committed rP22504: Clean Gaia's Selectable.
Clean Gaia's Selectable
Jul 18 2019, 12:04 PM
bb closed D1765: Gaia templates' <Selectable> clean-up.
Jul 18 2019, 12:04 PM
bb accepted D1765: Gaia templates' <Selectable> clean-up.
Jul 18 2019, 12:02 PM

Jul 17 2019

bb added inline comments to D1810: Improvements to the translators credits script.
Jul 17 2019, 10:38 PM
bb accepted D1810: Improvements to the translators credits script.
Jul 17 2019, 10:33 PM
bb committed rP22498: Standardize formation tooltips.
Standardize formation tooltips
Jul 17 2019, 10:20 PM
bb closed D2007: standardize formation tooltips.
Jul 17 2019, 10:20 PM
bb accepted D2007: standardize formation tooltips.

Reads correct and complete now

Jul 17 2019, 10:19 PM
bb committed rP22497: Add skirmish templates for range, stable, wonder and workshop.
Add skirmish templates for range, stable, wonder and workshop
Jul 17 2019, 9:41 PM
bb closed D2049: Add four default skirm structures.
Jul 17 2019, 9:41 PM
bb added a comment to D2049: Add four default skirm structures.

Default skirmish placeholders for the elephant stable aren't added, because not all civilizations have one; for comparison, other structures shared by some but not all (e.g. library, rotary mill, theatre) don't have them either.

Notice that houses have a skirmish replacer and there actually are 2 types of them i.e. small and big houses, so that would be the way to handle the structures that not all civs have

Jul 17 2019, 9:40 PM
bb accepted D2049: Add four default skirm structures.
In D2049#86151, @Nescio wrote:

Good point! Not all skirmish templates specify a footprint, though; should those (barracks, blacksmith, civic centre, etc) be updated here as well?

The skirmish templates could inherit the correct value from the parent, if that is not the case it needs to be updated, however sounds like a topic of another patch, excluding the barracks chance for now

Jul 17 2019, 9:29 PM
bb added inline comments to D2007: standardize formation tooltips.
Jul 17 2019, 7:57 PM
bb added inline comments to D2007: standardize formation tooltips.
Jul 17 2019, 7:54 PM
bb added inline comments to D2081: Add status effects support to splash, melee and death damage..
Jul 17 2019, 2:28 PM
bb requested changes to D2081: Add status effects support to splash, melee and death damage..

In the related ticket #1144, it was stated (first comment, by non-team member) that although a unit is not allowed to attack a specific entity, it *should* be able to damage it

You mean https://trac.wildfiregames.com/ticket/1144#comment:1 ? I read more in that that a unit could be restricted to attack another unit with a certain attacktype, however it still can attack with another attackType (i.e it can't use Capture but can use Melee)

Jul 17 2019, 2:04 PM
bb updated the diff for D1398: Fix shiftlag and implement HotkeyDown event, change HotkeyPress event to be non-repeating.
Jul 17 2019, 1:14 AM