Page MenuHomeWildfire Games

bb
User

Projects

User Details

User Since
Jan 24 2017, 12:54 PM (97 w, 6 d)

Recent Activity

Sat, Nov 24

bb added a comment to D1679: Add an option to allow players to circumvent TLS bugs.

Testing on fedora 28: patch doesn't solve the segfault, with or without the patch both segfault on lobby join. If required I could get access to a fedora 29 machine for testing.

Sat, Nov 24, 3:08 PM

Oct 17 2018

bb added inline comments to rP21378: Allow units to be positioned with freehand placement.
Oct 17 2018, 7:58 PM

Aug 5 2018

bb updated the diff for D1602: Extract the terms code from the prelobby to reuse it for other term accepters (userreport).

Don't use a common/ global outside common/

Aug 5 2018, 5:53 PM

Aug 3 2018

bb updated the test plan for D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.
Aug 3 2018, 12:53 AM
bb added a parent revision for D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy: D1602: Extract the terms code from the prelobby to reuse it for other term accepters (userreport).
Aug 3 2018, 12:52 AM
bb added a child revision for D1602: Extract the terms code from the prelobby to reuse it for other term accepters (userreport): D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.
Aug 3 2018, 12:52 AM
bb updated the diff for D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.

Reflect the duplication avoid

Aug 3 2018, 12:52 AM
bb created D1602: Extract the terms code from the prelobby to reuse it for other term accepters (userreport).
Aug 3 2018, 12:52 AM

Jul 30 2018

bb updated the diff for D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.

fix an elexis' irc comment

Jul 30 2018, 2:34 PM

Jul 26 2018

bb accepted D1535: Remove quotes made unnecessary by capitalization.

complete as in all quotes around I and II are gone => accept

Jul 26 2018, 9:42 PM
bb accepted D1527: rally-point → rally point.

If that is so => accept

Jul 26 2018, 9:41 PM
bb added inline comments to D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.
Jul 26 2018, 4:40 PM
bb updated the diff for D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.
Jul 26 2018, 4:40 PM
bb added inline comments to D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.
Jul 26 2018, 1:32 AM
bb updated the test plan for D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.
Jul 26 2018, 1:17 AM
bb created D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.
Jul 26 2018, 1:16 AM

Jul 16 2018

bb added a comment to D1590: 0 A.D. Empires Ascendant Multiplayer Lobby Privacy Policy.
In D1590#63984, @Stan wrote:

What if as per article 18 one says he doesn't want his data processed for ratings. Do we delete the account ? Or do we force him not to go on rated games ? He might want to play with a fixed rating or no rating at all with player who want to get rated. How does it go

Which clause of art 18.1 applies?

Jul 16 2018, 6:39 PM
bb added inline comments to D1590: 0 A.D. Empires Ascendant Multiplayer Lobby Privacy Policy.
Jul 16 2018, 5:19 PM

Jul 9 2018

bb added a comment to D1590: 0 A.D. Empires Ascendant Multiplayer Lobby Privacy Policy.

Some digging in the GDPR leads me to two concerns (I am in no position to say if these are fixed everything is ok but would doubt if there are more problems)

Jul 9 2018, 11:29 PM

Jul 2 2018

bb added a comment to D1590: 0 A.D. Empires Ascendant Multiplayer Lobby Privacy Policy.

Read the code and comments, but as having very limited knowledge about these matter (nor an urgent will to become an expert), can't say anything about the completeness.

Jul 2 2018, 9:53 PM
bb added a comment to rP21441: Create winning teams for relic and wonder victory instead of letting all allies….

Objectives should be as straightforward as possible, as simple as possible, so I'd rather have went with only the first rule as was the case before (which doesn't mean that there might be a simple alternative satisfying more).

The objective is straightforward now, as the timer is reset on every event that the "winning team" changes

If my allies were defeated or declared war on me, that shouldn't make me lose the victory timer.

Certainly agree for lms, but in an allied victory game loosing a team member for me is enough reason to say the "team" is defeated. But as there is a new team meeting the victory conditions, a new timer is set for that team.

Jul 2 2018, 9:32 PM

Jul 1 2018

bb requested verification of rP21441: Create winning teams for relic and wonder victory instead of letting all allies….

The trick here is defining when the counter needs to be reset, to me defeating a player defending a wonder is enough reason to reset the countdown, one can argue differently however. But as the case is specifically named in the commit message Reset counters on playerDefeat requesting verification, further discussion should be in a trac ticket imo.

Jul 1 2018, 11:34 PM

Jun 28 2018

bb updated the diff for D981: Make commutative behaviour in the IsInRange function family and migrate them to a better home.
Jun 28 2018, 5:03 PM
bb added a comment to D981: Make commutative behaviour in the IsInRange function family and migrate them to a better home.
In D981#60827, @wraitii wrote:

Addendum: well while the above still seems true, another problem is that makeGoalReachable does not use a rounded rectangle but a flat one.

Jun 28 2018, 5:03 PM

Jun 25 2018

bb added a comment to D1535: Remove quotes made unnecessary by capitalization.

Checking for completeness is equal to going through all strings manually, so only checked for the Town Phase, I and II cases:

Jun 25 2018, 1:28 PM

Jun 20 2018

bb requested changes to D438: D13 prereq 1 : change Run Speed into a Run multiplier.

For some reason (couldn't quickly find why) a formation moves extremely slow right after it is created, when reforming (as in setting another shape) the problem is solved.

Jun 20 2018, 11:23 PM

Jun 18 2018

bb added a comment to D1527: rally-point → rally point.

binaries/data/mods/public/gui/session/unit_actions.js has one too

Jun 18 2018, 4:42 PM
bb accepted D1537: playername → player name.

So in code it technically needs to be playerName, interesesting (out of scope comment)\

Jun 18 2018, 4:34 PM
bb accepted D1580: Improve the description of the Teacher aura.

Seems to be a pleonasm between research and technologies, but with costs also there => meh => ok

Jun 18 2018, 4:15 PM
bb accepted D1549: Slightly rephrase the description of fishing nets.
Jun 18 2018, 4:13 PM
bb accepted D1533: Reword the description of the Temple at Naqa aura.

certainly better

Jun 18 2018, 4:10 PM
bb added a comment to D1549: Slightly rephrase the description of fishing nets.

fine with me too

Jun 18 2018, 4:08 PM
bb accepted D1550: Rephrase the description of the wonder victory condition.
Jun 18 2018, 4:07 PM

Jun 14 2018

bb added a comment to D1552: Druides → Druid.

Same for the brit one

Jun 14 2018, 10:52 PM

Jun 12 2018

bb accepted D1529: BackSlash → Backslash.

Seems to be the correct English spelling indeed for the strings, in code I presume it should be BackSlash however => patch complete

Jun 12 2018, 4:23 PM
bb accepted D1530: cit-states → city-states.
Jun 12 2018, 4:17 PM
bb accepted D1574: Get XML syntax errors not only the first time that file is loaded.

If it would crash for mods, the mods would receive an error in the current code, thus not caching the file wouldn't change much there.

Jun 12 2018, 4:13 PM
bb added inline comments to D1570: Fix typo in lobby server README.
Jun 12 2018, 3:57 PM
bb accepted D1553: multi-coloured → multi-colored.

In the code there are many more cases of colour which strictly speaking should be changed, but whatever

Jun 12 2018, 3:54 PM

Jun 11 2018

bb accepted rP19694: Allow walls and fields to be captured by territory but not by capture attack….

Looks like fixed

Jun 11 2018, 11:38 PM

Jun 8 2018

bb accepted D1536: barracks → Barracks.
Jun 8 2018, 9:40 PM
bb accepted D1528: Chose → Choose (imperative).
Jun 8 2018, 9:37 PM
bb added inline comments to D1550: Rephrase the description of the wonder victory condition.
Jun 8 2018, 9:36 PM

Jun 1 2018

bb accepted D1539: <sentence> and <long sentence> and <long sentence> → <sentence> and <long sentence>. <long sentence>.

certainly (didn't check if more of these cases occur, presumably yes, but that requires reading through all strings => meh)

Jun 1 2018, 11:05 PM
bb added a comment to D1536: barracks → Barracks.

Have a look at these also: (AI comments can be left out in imo)

Jun 1 2018, 11:04 PM
bb accepted D1534: constructed → ready (a field).

Technically speaking of code and animations, the field is just as "constructed" as any other building, but probably sounds better otherwise

Jun 1 2018, 10:58 PM
bb added a comment to D1528: Chose → Choose (imperative).

(Don't we have some inline in another revision about this?)

Jun 1 2018, 10:57 PM
bb accepted D1531: aide → aid.

I will thrust you, you just removed that one character in that string (wondering why phab isn't highlighting it properly)

Jun 1 2018, 10:51 PM
bb accepted D1526: reaffect → reassign.

Noticed them some times before, thx for fixing them
patch correct and complete, not sure these kind of patches require a review, but whatever
should be committed in A24 development (so wait for an official leave of commit freeze)

Jun 1 2018, 10:47 PM
bb requested changes to D1504: Small commands.js cleanup.
Jun 1 2018, 10:24 PM
bb added a comment to D1469: Conquest structures fails on nomad.
In D1469#60219, @temple wrote:

Now you can lose with conquest structures even if you have structures left, or lose with conquest units even if you have units left. Non-conquest-critical ones (e.g. market + traders), but still.
Not sure about an alternative solution, other than to advise people not to choose conquest structures when playing nomad.

Jun 1 2018, 10:13 PM

May 9 2018

bb added a comment to rP21108: Set victory conditions for autostart games..

endless support readded in rP21474

May 9 2018, 12:53 PM

May 7 2018

bb accepted rP21630: Fix UnitAI behaviour inconsistent with its stance for packed units and set….

resolved

May 7 2018, 11:50 PM

Apr 27 2018

bb abandoned D1180: Set a tooltip for switching tabs and generalize coloredHotkey to allow multiple hotkeys.

Got lesser and lesser convinced of this patch over time...

Apr 27 2018, 4:31 PM

Apr 24 2018

bb created D1469: Conquest structures fails on nomad.
Apr 24 2018, 4:49 PM

Apr 23 2018

bb accepted D1463: Unit for summary charts time axis.

for after release

Apr 23 2018, 5:34 PM
bb committed rP21771: Hide the settingsPanel for non-controllers.
Hide the settingsPanel for non-controllers
Apr 23 2018, 5:30 PM
bb closed D1243: Default Hide Tab Content Of Game Settings In Game Setup.
Apr 23 2018, 5:29 PM
bb committed rP21770: Tidy up gamesetup initGUIObjects.
Tidy up gamesetup initGUIObjects
Apr 23 2018, 5:09 PM
bb committed rP21769: Split the sliding logic from the moving logic for the settingsPanel in gamesetup.
Split the sliding logic from the moving logic for the settingsPanel in gamesetup
Apr 23 2018, 4:51 PM
bb accepted D1243: Default Hide Tab Content Of Game Settings In Game Setup.

default argument also brings some duplicate hardcodings (for the controller case), so thx for the stubbornness

Apr 23 2018, 4:38 PM
bb committed rP21768: Use esc to close the tabs in gamesetup.
Use esc to close the tabs in gamesetup
Apr 23 2018, 4:08 PM
bb closed D1242: On Cancel Hide Tab Content On New Gamesetup UI.
Apr 23 2018, 4:08 PM
bb accepted D1242: On Cancel Hide Tab Content On New Gamesetup UI.

I misread in last comment, patch actually correct. A hotkey string should be added after the release

Apr 23 2018, 3:16 PM

Apr 22 2018

bb accepted D1464: Immediately update gui visibility when pressing the hotkey to toggle it.

Don't see an answer to the bonus question

Apr 22 2018, 7:07 PM

Apr 21 2018

bb accepted D1460: Add an experience status bar.

One should consider crowdyness for these stuff, maybe at some point we need to push the bars in the option menu.

Apr 21 2018, 10:57 PM
bb added inline comments to D1462: Enforce formation required member count.
Apr 21 2018, 10:12 PM
bb accepted rP21721: Make modmod looking nicer.
Apr 21 2018, 10:00 PM

Apr 17 2018

bb added inline comments to rP21630: Fix UnitAI behaviour inconsistent with its stance for packed units and set….
Apr 17 2018, 10:25 AM

Apr 16 2018

bb raised a concern with rP21630: Fix UnitAI behaviour inconsistent with its stance for packed units and set….
Apr 16 2018, 4:32 PM
bb added inline comments to D1243: Default Hide Tab Content Of Game Settings In Game Setup.
Apr 16 2018, 1:29 PM
bb added inline comments to D1242: On Cancel Hide Tab Content On New Gamesetup UI.
Apr 16 2018, 1:05 PM

Apr 14 2018

bb raised a concern with rP21721: Make modmod looking nicer.

Commitment of images has failed ;P

Apr 14 2018, 10:09 PM
bb added a comment to D1438: Use Math.floor in resource costs.

Ever since I upladed my first patch, the montra has been: "No rounding in sim, only in GUI."

Apr 14 2018, 3:26 PM

Apr 13 2018

bb accepted D1294: Fix stats of peak percentage of map controlled.

New code looks much simpler and less error prone

Apr 13 2018, 2:34 PM

Apr 8 2018

bb accepted D1444: Give capturePoints of defeated Players to gaia.

works as expected

Apr 8 2018, 11:53 PM
bb accepted D1443: Fix undefined property g_GameAttributes.settings.Keywords in autostarted games.

Cannot reproduce the error, but any looks good and correct and doesn't seems to break anything. Agree with the picked option to not depend on that keyword for gui settings.

Apr 8 2018, 11:30 PM

Apr 6 2018

bb requested changes to D285: Lobby player search input.
Apr 6 2018, 6:15 PM
bb requested changes to D948: Players/Games Numbers Stats in Lobby.

for a24

Apr 6 2018, 6:12 PM
bb added a comment to D293: Proposal for games header in Lobby.

(you can abandon revisions yourself, if it became deprecated)

Apr 6 2018, 5:30 PM

Apr 3 2018

bb added inline comments to D1425: Formation members shouldn't use IsWalkingAndFighting.
Apr 3 2018, 4:41 PM

Mar 23 2018

bb updated the diff for D1398: Implement a press action to be called upon the first keyDown message of a hotkey and use keydown for current press.

Make SDL_HOTKEYPRESS event, so also hotkeys defined in cpp can benefit

Mar 23 2018, 12:42 AM
bb added inline comments to D1398: Implement a press action to be called upon the first keyDown message of a hotkey and use keydown for current press.
Mar 23 2018, 12:23 AM
bb added inline comments to D1398: Implement a press action to be called upon the first keyDown message of a hotkey and use keydown for current press.
Mar 23 2018, 12:04 AM

Mar 22 2018

bb added a comment to D1324: GUI: vertically space objects and separate top_panel.js file.

The function looks good and seems already useable in a couple of places in the public mod, (from the top of my mind: tab_buttons, options in options menu, settings in gamesetup). It would be great to let those places use the new function while adding the function to he codebase.

Mar 22 2018, 11:50 AM
bb accepted D1410: GUI: separate top_panel.js file.

Agreeing on the change, testing says front doesn't fall => accept
(will commit after release as we move some translated strings around)

Mar 22 2018, 11:41 AM

Mar 21 2018

bb updated the diff for D1398: Implement a press action to be called upon the first keyDown message of a hotkey and use keydown for current press.

Make a bool in SDL_HOTKEYDOWN

Mar 21 2018, 10:56 PM
bb added a comment to D1324: GUI: vertically space objects and separate top_panel.js file.
In D1324#57779, @Nescio wrote:

The reason I'm proposing this patch is to improve mod support for myself and others who'd like to modify e.g. the resource bar like I did in my 0abc mod.

The "verticallySpaceObjects" function is basically a copy of the "horizontallySpaceObjects" function directly above, mutatis mutandis. I use it in my 0abc mod; including it in the main game would save me, and other modders who'd like to list objects vertically, the trouble of maintaining a full copy of the functions_utility.js file.

I understand that, and agree such a function could be useful and actually already is (see last comments). So I am only saying that the two proposed changes (function move and new function) should both get an own revision and that the function should be used in a few places already.

Also, I don't intend to change "updateTopPanel" the function; I can see it works, but I don't fully understand it in detail. This patch merely moves the function out of the hard-to-maintain session.js into a new file. This way modders don't have to keep a copy of session.js, they can simply tweak the small top_panel.js file instead.

Didn't ask for real changes (as in executing the code would result in the same), but only a small style fix.

Mar 21 2018, 10:32 PM
bb updated the diff for D1398: Implement a press action to be called upon the first keyDown message of a hotkey and use keydown for current press.
Mar 21 2018, 10:26 PM
bb added inline comments to D1398: Implement a press action to be called upon the first keyDown message of a hotkey and use keydown for current press.
Mar 21 2018, 10:26 PM

Mar 20 2018

bb updated the diff for D1398: Implement a press action to be called upon the first keyDown message of a hotkey and use keydown for current press.

Is this casting correct?

Mar 20 2018, 5:29 PM
bb added inline comments to D1398: Implement a press action to be called upon the first keyDown message of a hotkey and use keydown for current press.
Mar 20 2018, 5:29 PM
bb added a comment to D1406: Fix infinite UnitAI loop when units are moved out of world (after promotion).

(Still thinking "moving out of range if killed" is a hack as noticed in that old revision meh)

Mar 20 2018, 5:28 PM

Mar 19 2018

bb added a comment to D1324: GUI: vertically space objects and separate top_panel.js file.

shouldn't updateViewedPlayerDropdown be in the new file too? ( for getBuildString see D1348)

Mar 19 2018, 11:17 PM
bb added inline comments to D1348: Simple refactoring of build information getters.
Mar 19 2018, 11:09 PM
bb requested changes to D790: Lobby auto away after inactive time or window is in background.

Patch looks almost done, will get in shortly after the release I guess (string freeze and stuff blocks me from committing)

Mar 19 2018, 10:49 PM
bb abandoned D1194: Shrinking things in Match Creator to provide more room for other stuff..

Given that IMO this patch is a regression of the current state (those names can be longer: "Invasion Force" and vercingetorix_ are already of the same longer or equal), so abandoning the revisions, reopen is felt still required

Mar 19 2018, 10:03 PM
bb requested changes to D1268: Remove health component from relics.

(one could add a test here and there with units without health components)

Mar 19 2018, 9:13 PM
bb added inline comments to D1398: Implement a press action to be called upon the first keyDown message of a hotkey and use keydown for current press.
Mar 19 2018, 8:24 PM
bb updated the diff for D1398: Implement a press action to be called upon the first keyDown message of a hotkey and use keydown for current press.
Mar 19 2018, 8:24 PM