- User Since
- Jan 24 2017, 12:54 PM (107 w, 4 d)
Sat, Jan 19
Jan 6 2019
well from a ownershipchange we can't see if it will be a rename, so when the new ent is brought up, we don't know it actually replaces another (one could change the entitylimits and allow two wonders, so an owners check wouldn't work), so the new timer will always be activated, which afterwards needs to be removed. Also from the destroy we don't know if it is a rename (one could very well create and destroy different wonders at the same turn), so we have to do it with the ent rename.
Jan 5 2019
grepped for completeness, agreeing on the change, translators will hate
(note to self: be careful with file move)
should be fixed now: rP22030
I guess every gui page should be able to access this file, also the mod-selection, thus mods/mod/gui/common should be the correct place
Jan 4 2019
Isn't that what I say too? (notice the capital letter N)
Tested against DE, correctness forces me to press accept
Accepting because it is correct and complete for Danubius, but while looking at D1694, I guess the same bug can happen in (most of) the victory conditions, and potentially the other trigger scripts too (SotF, JB etc.)
Excuses for not replying to previous comments, and making you do an extra iteration...
Jan 3 2019
Dec 27 2018
Even better: the error wasn't introduced there
Dec 26 2018
That should work
While committing thought of the programming.json: @nani please put your nick and if you want name in there and upload in a new patch on the revision so you are credited
introduced in rP20945 (code got shuffled a bit afterwards)
And here the guy to blame :S, can't even put off the blame by saying it was copied from the main-menu or ingame menu...
fix the edgy case when only nonConquestCritical structures/units remain
Was about to commit it, but the time displayed is minutes : seconds, so shouldn't the unit be something like minutes:ss?
15 removed cases, 10 added ones (if counting holds, the 15 goes down to 13 given the structure_defense_* comment)
Nov 24 2018
Testing on fedora 28: patch doesn't solve the segfault, with or without the patch both segfault on lobby join. If required I could get access to a fedora 29 machine for testing.
Oct 17 2018
Aug 5 2018
Don't use a common/ global outside common/
Aug 3 2018
Reflect the duplication avoid
Jul 30 2018
fix an elexis' irc comment
Jul 26 2018
complete as in all quotes around I and II are gone => accept
Jul 16 2018
Which clause of art 18.1 applies?
Jul 9 2018
Some digging in the GDPR leads me to two concerns (I am in no position to say if these are fixed everything is ok but would doubt if there are more problems)
Jul 2 2018
Read the code and comments, but as having very limited knowledge about these matter (nor an urgent will to become an expert), can't say anything about the completeness.
The objective is straightforward now, as the timer is reset on every event that the "winning team" changes
If my allies were defeated or declared war on me, that shouldn't make me lose the victory timer.
Certainly agree for lms, but in an allied victory game loosing a team member for me is enough reason to say the "team" is defeated. But as there is a new team meeting the victory conditions, a new timer is set for that team.
Jul 1 2018
The trick here is defining when the counter needs to be reset, to me defeating a player defending a wonder is enough reason to reset the countdown, one can argue differently however. But as the case is specifically named in the commit message Reset counters on playerDefeat requesting verification, further discussion should be in a trac ticket imo.
Jun 28 2018
Jun 25 2018
Checking for completeness is equal to going through all strings manually, so only checked for the Town Phase, I and II cases:
Jun 20 2018
For some reason (couldn't quickly find why) a formation moves extremely slow right after it is created, when reforming (as in setting another shape) the problem is solved.
Jun 18 2018
binaries/data/mods/public/gui/session/unit_actions.js has one too
So in code it technically needs to be playerName, interesesting (out of scope comment)\
Seems to be a pleonasm between research and technologies, but with costs also there => meh => ok
fine with me too
Jun 14 2018
Jun 12 2018
Seems to be the correct English spelling indeed for the strings, in code I presume it should be BackSlash however => patch complete
If it would crash for mods, the mods would receive an error in the current code, thus not caching the file wouldn't change much there.
In the code there are many more cases of colour which strictly speaking should be changed, but whatever
Jun 11 2018
Looks like fixed
Jun 8 2018
Jun 1 2018
certainly (didn't check if more of these cases occur, presumably yes, but that requires reading through all strings => meh)
Have a look at these also: (AI comments can be left out in imo)
Technically speaking of code and animations, the field is just as "constructed" as any other building, but probably sounds better otherwise
(Don't we have some inline in another revision about this?)
I will thrust you, you just removed that one character in that string (wondering why phab isn't highlighting it properly)
Noticed them some times before, thx for fixing them
patch correct and complete, not sure these kind of patches require a review, but whatever
should be committed in A24 development (so wait for an official leave of commit freeze)
May 9 2018
endless support readded in rP21474
May 7 2018
Apr 27 2018
Got lesser and lesser convinced of this patch over time...
Apr 24 2018
Apr 23 2018
default argument also brings some duplicate hardcodings (for the controller case), so thx for the stubbornness
I misread in last comment, patch actually correct. A hotkey string should be added after the release
Apr 22 2018
Don't see an answer to the bonus question