Page MenuHomeWildfire Games

bb
User

Projects

User Details

User Since
Jan 24 2017, 12:54 PM (201 w, 2 d)

Recent Activity

Thu, Nov 19

bb added a comment to rP24217: Update range queries to account for entity size..

To get to the original situation, one should add the size (== half diagonal length) of the gate to the range. As gates tend to be rather long and thus have a large size, the reduction was done to make gates close in roughly the same situations. Now if you take the brit gate: 37x8, you get half diagonal of (just under )19, so in fact the range got slightly bigger there (similar values are true for the other gates).

Thu, Nov 19, 3:59 PM

Wed, Nov 18

bb added a comment to D3109: Fix tab buttons not playing sounds.

The problem here is that IGUIButtonBehavior is never called when setting the style. While this fix works for the given problem, it is a result of a more general problem: setting styles on buttons does not update the button behaviour. I would somehow be nice if the cpp could solve our problem. I.e., some message is send when a new style is added. Not sure if this is worth it though.

Wed, Nov 18, 10:54 PM
bb committed rP24209: Generalize to arbitrary translatable attacknames in the GUI.
Generalize to arbitrary translatable attacknames in the GUI
Wed, Nov 18, 10:35 PM
bb closed D2995: Introduce translatable attack names.
Wed, Nov 18, 10:34 PM
bb added a comment to D2995: Introduce translatable attack names.

Big thank you, @Nescio, your comments and questions have improved the code and strings tremendously.

Wed, Nov 18, 9:41 PM
bb committed rP24198: Lets not break tests in rP24197.
Lets not break tests in rP24197
Wed, Nov 18, 9:31 AM
bb committed rP24197: Don't uselessly traffic constant statuseffect translatable strings and icons….
Don't uselessly traffic constant statuseffect translatable strings and icons…
Wed, Nov 18, 9:26 AM
bb closed D3112: Don't uselessly traffic constant statuseffect translatable strings and icons through the guiinterface.
Wed, Nov 18, 9:26 AM
bb accepted rP24162: Allow resistances to StatusEffects..
Wed, Nov 18, 9:25 AM

Tue, Nov 17

bb accepted D2860: Notify players with a sound when a player is defeated.

Testing verifies sounds are heard, also for observers (when viewing a player). Defeating sound work (sim is processed before gui, the g_ViewedPlayer didn't change yet when the sound is played).

Tue, Nov 17, 10:42 PM
bb requested review of D3112: Don't uselessly traffic constant statuseffect translatable strings and icons through the guiinterface.
Tue, Nov 17, 10:31 PM
bb raised a concern with rP24162: Allow resistances to StatusEffects..
Tue, Nov 17, 10:27 PM
bb added a comment to D2860: Notify players with a sound when a player is defeated.

Observer not viewing a player don't hear anything => probably wanted, certainly not possible i the current design (also would need new sound).

Tue, Nov 17, 9:43 PM
bb added a comment to D2995: Introduce translatable attack names.

Indeed, especially since a different context can mean a different translations.

Tue, Nov 17, 11:05 AM

Mon, Nov 16

bb added inline comments to D3103: Fix rP24185.
Mon, Nov 16, 8:20 PM
bb added a comment to D2995: Introduce translatable attack names.

Annoying indeed, but it is how getText works...
To be more precise: the default context is defined in the messages.json file, the tooltip.js string indeed needs to match this string (that way we can retrieve the correct string). Therefore changing the tooltip.js line doesn't cause any retranslations. Changing the string only in tooltips.js, will result in non translated strings. Changing the string in the messages.json, WILL cause retranslations (and to see the translation ingame one also needs to change the tooltips.js string). I hope this is somehow clear...

Mon, Nov 16, 12:54 PM

Sun, Nov 15

bb updated the diff for D3103: Fix rP24185.

try on fixing tests (everything works here)

Sun, Nov 15, 11:33 PM
bb updated the diff for D3103: Fix rP24185.

propset

Sun, Nov 15, 11:16 PM
bb updated the diff for D3103: Fix rP24185.

Also add new files...

Sun, Nov 15, 11:11 PM
bb updated the diff for D3103: Fix rP24185.

Add CI test

Sun, Nov 15, 10:53 PM
bb added inline comments to D3103: Fix rP24185.
Sun, Nov 15, 4:16 PM
bb updated the diff for D3103: Fix rP24185.

Add test of removing handlers on handlers. Note that the removed handlers are not called, since their m_EventHandler is deleted (this is how it was before too).

Sun, Nov 15, 4:16 PM
bb added a comment to D2995: Introduce translatable attack names.

Another question: does a string have to be retranslated if the context is changed?

Sun, Nov 15, 2:25 PM
bb added inline comments to rP24185: Optimize the GUI event broadcast.
Sun, Nov 15, 2:23 PM
bb requested review of D3103: Fix rP24185.
Sun, Nov 15, 2:52 AM

Sat, Nov 14

bb added inline comments to rP24185: Optimize the GUI event broadcast.
Sat, Nov 14, 11:33 PM
bb added a comment to D2995: Introduce translatable attack names.

The proposed attack name contexts are a bit verbose; wouldn't just “A single-edged sword.” or “Attack using a single-edged sword.” instead of “Name of an attack using a single-edged sword.” be sufficiently clear?

I rather be too much verbose than to less in this case. We actually want some identifier for the way of attacking, not necessarily the weapon (“A single-edged sword.”) or the act of attacking (“Attack using a single-edged sword.”) and I wouldn't be surprised if there were languages who would make a difference between this.

Sat, Nov 14, 11:20 PM
bb updated the diff for D2995: Introduce translatable attack names.

Comments

Sat, Nov 14, 11:20 PM
bb committed rP24185: Optimize the GUI event broadcast.
Optimize the GUI event broadcast
Sat, Nov 14, 10:54 PM
bb closed D2638: Optimize the event broadcast.
Sat, Nov 14, 10:54 PM
bb accepted D2638: Optimize the event broadcast.
Sat, Nov 14, 10:33 PM
bb added a comment to D2638: Optimize the event broadcast.

The order of calling is ambiguous anyway, so changing it is fine.

Sat, Nov 14, 10:31 PM
bb updated the summary of D3034: un-crowdify graphics options panel.
Sat, Nov 14, 9:44 PM
bb updated the diff for D3034: un-crowdify graphics options panel.

How about this?

Sat, Nov 14, 9:36 PM

Fri, Nov 13

bb updated the diff for D3034: un-crowdify graphics options panel.

Better name suggestion are welcome

Fri, Nov 13, 11:43 PM
bb added inline comments to D3073: Use player color for rally point lines in SOW.
Fri, Nov 13, 11:19 PM
bb added a comment to D3073: Use player color for rally point lines in SOW.

https://code.wildfiregames.com/D623#25469

Fri, Nov 13, 11:17 PM
bb added a comment to D3099: Play sound of entity that is actually able to perform command..

Lets loop another time through all entities, hardly a way around it though.

Fri, Nov 13, 11:10 PM
bb added a comment to D3081: Make cheering time moddable.

Either make it mandatory, or say that a unit with no cheertime shouldn't cheer (several ways to do this, either pass the time in the order and not send the order if no time, or finishorder on enter, or discard the order on order.Cheer)

Fri, Nov 13, 10:57 PM
bb updated the diff for D2995: Introduce translatable attack names.

comments

Fri, Nov 13, 10:50 PM
bb added a comment to D2995: Introduce translatable attack names.

Actually can't easily remove the slaughter thingy, since it is processed through the code. On the topic on whether it will be shown: #252 will abstract the notion of attacktype, so there won't be any difference between the attacktypes. Don't worry slaughter won't be able to instakill everything, we have restricted classes for that. Showing the restricted classes might be something to consider.

Fri, Nov 13, 10:47 PM
bb added a comment to D2995: Introduce translatable attack names.

Maybe I remove the slaughter thingy, since it is adding dead code here. I find it somewhat bad that it is not displayed. IMO it should just be displayed along side the other types (I actually do this in #252). Changing one template there won't hurt too much (especially since we need to change that template then anyway).

Fri, Nov 13, 10:52 AM

Thu, Nov 12

bb added a comment to D2759: Update range queries to account for entity size.

see #4000, buildingAI currently takes preceding (adding other attacktypes to those entities will not do anything)

Thu, Nov 12, 11:51 AM
bb added a comment to D2759: Update range queries to account for entity size.

Fundamentally there is no difference between melee and ranged attacks. So if buildingAI were to use melee attacks (which it is hardcoded not to do), this patch would change stuff. As buildingAI does not have melee attacks, there is no change. UnitAI attack logic is not directly affected, so for unitAI ents, there are "no" changes (there are some other slight changes, like I expect units to look for targets further away now)

Thu, Nov 12, 11:36 AM

Wed, Nov 11

bb added inline comments to D2995: Introduce translatable attack names.
Wed, Nov 11, 11:26 PM
bb updated the diff for D2995: Introduce translatable attack names.
Wed, Nov 11, 11:26 PM
bb added a comment to D3094: [SM52] Spidermonkey Upgrade 1/2 : build system upgrade to 52.9.1.

No idea which patch it exactly comes from but doing a clean build with D3085-95 applied, gives me

Building SpiderMonkey...
Wed, Nov 11, 10:43 PM
bb added a comment to D2759: Update range queries to account for entity size.

Lower gate opening range which was much too high now.

Did you intentionally remove the rebalance changes from an earlier patch? (Can be committed separately, I don't mind)

Wed, Nov 11, 10:29 PM
bb accepted D2759: Update range queries to account for entity size.

Testing confirms this works as expected. Just some comments on the comments, should be trivial to fix those.

Wed, Nov 11, 10:26 PM
bb updated the Trac tickets for D2759: Update range queries to account for entity size.
Wed, Nov 11, 1:19 PM

Tue, Nov 10

bb added a comment to D2759: Update range queries to account for entity size.

To account for sphere sizes, we can treat them as squares (Size•Size) and do this:
inrange(max(d-size, 0), h-size, range)

That is not what we want to check. The size does not have a vertical factor afaik, so you want inrange(max(d-size, 0), h, range)

Tue, Nov 10, 10:40 PM

Mon, Nov 9

bb added inline comments to D2759: Update range queries to account for entity size.
Mon, Nov 9, 11:04 PM
bb added inline comments to D2759: Update range queries to account for entity size.
Mon, Nov 9, 11:00 PM
bb added inline comments to D2759: Update range queries to account for entity size.
Mon, Nov 9, 10:55 PM

Sat, Nov 7

bb added inline comments to D2759: Update range queries to account for entity size.
Sat, Nov 7, 10:19 PM
bb added a comment to D2759: Update range queries to account for entity size.

The clue in finding a correct parabolic range check, is not finding the check, it is finding a fast check. Write d>0 for the distance, s>0 for the shap size (so sourceSize+targetSize), r>0 for the range and h for the height factor. Notice for computing d we need sqrt, while we can compute d^2. Now assuming all obstructions are circles, the following check is completely sharp: sqrt(r^2+2rh)>=d-s. However we want to avoid sqrt'ing for performance. An equivalent check is r^2+2rh>=(d-s)^2 || d^2<s^2 (square the previous relation but be careful with negative values). Writing some stuff around this is equivalent to r^2+2rh-d^2-s^2>=-2ds || d^2<s^2 and flipping the sign gives d^2+s^2-r^2-2rh<=2ds || d^2<s^2. Again squaring gives the equivalent relation (d^2+s^2-r^2-2rh)^2<=4d^2s^2 || d^2+s^2<r^2+2rh || d^2<s^2. This can be computed without sqrt, but one should be careful with overflows.

Sat, Nov 7, 9:56 PM
bb added a comment to D2995: Introduce translatable attack names.

In my opinion it would be better to define the attack name in the template where the attack node is defined, and match the names with the types, i.e. stick with Melee and Ranged, at least for now.

We can't use the node key directly, since that cannot be translated.

Sat, Nov 7, 9:31 PM
bb updated the diff for D2995: Introduce translatable attack names.
Sat, Nov 7, 9:31 PM
bb added a comment to D3034: un-crowdify graphics options panel.
In D3034#133190, @Angen wrote:

maybe windowed option could be moved somewhere else, e.g. general ?

Sat, Nov 7, 8:58 PM

Wed, Nov 4

bb added inline comments to D2808: Allow resistance to StatusEffects..
Wed, Nov 4, 9:01 PM

Nov 2 2020

bb added a comment to D2759: Update range queries to account for entity size.

As I've noted inline, I've updated the code once more because I need to account for the fact that size is the diagonal size but I don't know the 'smallest' side, so I can't account for the 'querier size' in the minrange case and the 'target size' for the maxrange case. I think everything is correct this time around.

Nov 2 2020, 2:08 PM

Oct 29 2020

bb added a comment to D2837: Stop dodging arrows by spamclicking or patrol: Waste time turning.

Not all rotation is done in unitMotion, only on the first turn, when m_TurnTime is enabled

Oct 29 2020, 9:35 AM

Oct 28 2020

bb added inline comments to D2837: Stop dodging arrows by spamclicking or patrol: Waste time turning.
Oct 28 2020, 10:43 PM
bb updated the diff for D2995: Introduce translatable attack names.
Oct 28 2020, 10:40 PM
bb added inline comments to D2995: Introduce translatable attack names.
Oct 28 2020, 10:40 PM
bb updated the diff for D3035: optionally unrandomize entity appearance.

comments

Oct 28 2020, 10:34 PM
bb added inline comments to D3035: optionally unrandomize entity appearance.
Oct 28 2020, 10:31 PM

Oct 26 2020

bb added inline comments to D3035: optionally unrandomize entity appearance.
Oct 26 2020, 10:42 PM
bb updated the diff for D3035: optionally unrandomize entity appearance.
Oct 26 2020, 10:40 PM
bb added a comment to D3039: Add a logarithmicly scaled slider to the options.

GetSliderRatio did exactly what the comment said, you might think that the value is the misleading name though.

@return ratio between the value of the slider and its actual size in the GUI value is clearly wrong, whether you call it misleading or whatelse, misleading comments are just as much telling lies about the code.

Oct 26 2020, 10:02 PM
bb accepted D3045: Nuke comments in UnitAI..

no will to relook at. Eyeballed through all commends in the unitAI, found a few, otherwise mehing

Oct 26 2020, 9:50 PM

Oct 25 2020

bb added a comment to D3032: Treat code between `[]` and `{}` as one blob for translations..

I'm wondering if this can't be fixed by using template literals: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals

Don't really see the relevance

(though I don't really understand why you need it, if you could provide an example - haven't figured it out really from the diff before either)

See revision summary for example. More generally, the current script sees any string between the brackets after translate even if they are not really translatable strings, but rather strings used for array/object/inlined function construction or (as the example) for accessing array/object values.

Oct 25 2020, 9:30 PM

Oct 23 2020

bb added inline comments to rP24071: Show correct trade info for observers.
Oct 23 2020, 10:59 AM

Oct 22 2020

bb added inline comments to rP24071: Show correct trade info for observers.
Oct 22 2020, 10:03 PM
bb added inline comments to rP24071: Show correct trade info for observers.
Oct 22 2020, 9:51 PM

Oct 16 2020

bb requested review of D3039: Add a logarithmicly scaled slider to the options.
Oct 16 2020, 11:51 PM
bb added inline comments to D3035: optionally unrandomize entity appearance.
Oct 16 2020, 8:47 PM
bb updated the diff for D3035: optionally unrandomize entity appearance.
Oct 16 2020, 8:47 PM
bb updated the diff for D2995: Introduce translatable attack names.

split object definition over several lines

Oct 16 2020, 7:57 PM

Oct 13 2020

bb requested review of D3035: optionally unrandomize entity appearance.
Oct 13 2020, 10:51 PM
bb requested review of D3034: un-crowdify graphics options panel.
Oct 13 2020, 10:46 PM
bb updated the test plan for D3032: Treat code between `[]` and `{}` as one blob for translations..
Oct 13 2020, 10:00 PM
bb added inline comments to D2808: Allow resistance to StatusEffects..
Oct 13 2020, 9:15 PM
bb added inline comments to D506: Port Transifex scripts to Python 3.
Oct 13 2020, 7:02 PM
bb updated the diff for D3032: Treat code between `[]` and `{}` as one blob for translations..

year

Oct 13 2020, 6:51 PM

Oct 12 2020

bb requested review of D3032: Treat code between `[]` and `{}` as one blob for translations..
Oct 12 2020, 11:23 PM
bb updated subscribers of rP24062: Make fauna names consistent.

@Itms This patch moved some templates around and thus should have changed the template-others pot file, however that file hasn't been changed since rP24049. Any idea what went wrong here?

Oct 12 2020, 10:26 PM
bb added a comment to D3022: Allow cText to be non-wrapping.

How is the behavior for Width==0 defined? The Width usually refers to the horizontal size of the guiObject. Having Width==0 work as nowrap doesn't work due to L235/L240 in cGUIString.cpp and we have to do something is Width==0.

Oct 12 2020, 8:26 PM
bb added a comment to D2630: Major improvements to the lobby bots XpartaMuPP and EcheLOn. .

I suppose the lobbybot readme needs some updates too

Oct 12 2020, 8:22 PM
bb accepted rP23592: Add a C++ interface for CCmpAttack..
Oct 12 2020, 2:11 PM

Oct 10 2020

bb added inline comments to D2860: Notify players with a sound when a player is defeated.
Oct 10 2020, 5:18 PM
bb committed rP24095: Do not hardcode attacktypes in the engine/Atlas.
Do not hardcode attacktypes in the engine/Atlas
Oct 10 2020, 5:15 PM
bb closed D2998: Do not hardcode attacktypes in the engine/Atlas.
Oct 10 2020, 5:14 PM
bb added inline comments to D3021: Stop dodging arrows by spamclicking or patrol: Acceleration.
Oct 10 2020, 5:12 PM
bb updated the diff for D3021: Stop dodging arrows by spamclicking or patrol: Acceleration.

Comments

Oct 10 2020, 4:53 PM

Oct 5 2020

bb added a comment to rP23997: Add some missing credits.

Some probably should have been added in rP23182, for some others times changed.

Oct 5 2020, 8:40 PM

Sep 29 2020

bb added inline comments to D2860: Notify players with a sound when a player is defeated.
Sep 29 2020, 9:27 PM
bb added a comment to D3022: Allow cText to be non-wrapping.

These Width == 0 checks are nagging me a bit, they seem to have some undefined behaviour.

Sep 29 2020, 7:25 PM
bb updated the diff for D3022: Allow cText to be non-wrapping.

Better noWrap handling

Sep 29 2020, 6:09 PM
bb added a comment to rP24076: Redo the previous commit by actually parsing the comments in the revision: use….

Yea, was messing up stuff

Sep 29 2020, 5:25 PM