Page MenuHomeWildfire Games

bb
User

Projects

User Details

User Since
Jan 24 2017, 12:54 PM (126 w, 1 h)

Recent Activity

Sat, Jun 22

elexis awarded rP22116: Nuke the misleading Structure_Defence from the wallset template name a Like token.
Sat, Jun 22, 5:44 PM
elexis awarded rP22115: Move the fish template under template_gaia since fish is a resource like trees… a Like token.
Sat, Jun 22, 5:44 PM

Wed, Jun 19

bb added a comment to D2002: Support for arbitrary attack types..

For reference this was a WIP while I was working on the full system https://github.com/0ad/0ad/compare/master...bb-bb:t252_secondAttack. I have a little better version iirc, but that needs a rebase before uploading.

Wed, Jun 19, 11:36 AM
bb added a reviewer for D2002: Support for arbitrary attack types.: bb.
Wed, Jun 19, 11:05 AM
bb added a comment to D2002: Support for arbitrary attack types..

I indeed have a branch for the secondary attacks, which also generalizes the attackTypes. That branch is pretty much a more or less complete version of this revision, I will update that branch to current svn soon, but that will come after my exams of next week...

Wed, Jun 19, 11:05 AM

Wed, Jun 5

bb added a comment to D1953: every technology modification on a new line.

it "should", but noone was ever crazy enough to spend some hours/days/weeks/month/years/centuries adding all the spaces

Wed, Jun 5, 8:56 PM
bb added a comment to D1953: every technology modification on a new line.

Well no, { "key": value } is the convention in js, so also in the json...

Wed, Jun 5, 8:37 PM
bb added a comment to D1936: Load damageTypes from "simulation/data/damagetypes"-files..

So to me the main question is really "do we need to soft-code damage types anywhere"? Can we get away with just art and templates specification?

It seems this question is equivalent to asking "do we need a list of all possible damageTypes somewhere in the code?" Retrieving the list from looking at all templates doesn't look like worth it to me. For the sim, the answer seems to be "no", since a type only the present types in an attack schema actually do something, and a nonexisting in a damageReciever can be defaulted to 0. However for the gui consider the case that 1 unit attacks with an unique damageType, than no unit will have that type present in the Armour tooltip, sure the effective value is 0, but shouldn't we communicate that to the player? Considering this I would argue for the need of such a list and thus a softcodation.

Wed, Jun 5, 8:34 PM

Tue, Jun 4

bb added a comment to rP18964: Merge resource agnostic branch by s0600204, fixes #3934..

While duplicating a file in D1936:

Tue, Jun 4, 11:04 PM

Fri, May 31

bb committed rP22329: Merge persian and mauryan Archery Tradition technologies.
Merge persian and mauryan Archery Tradition technologies
Fri, May 31, 11:35 PM
bb closed D1941: merge archery tradition.
Fri, May 31, 11:35 PM
bb accepted D1941: merge archery tradition.

Given that there is more versioning on the persian file, rename that one instead

Fri, May 31, 11:05 PM
bb committed rP22328: Rename Stables class to Stable since we use the singular forms..
Rename Stables class to Stable since we use the singular forms.
Fri, May 31, 10:48 PM
bb closed D1890: Rename class Stables to Stable following introduction in rP22280.
Fri, May 31, 10:48 PM
bb accepted D1890: Rename class Stables to Stable following introduction in rP22280.

No more instances of Stables left in the public mod

Fri, May 31, 10:45 PM
bb added inline comments to D1939: redo rP21036, Create a ConfigDB_CreateAndWriteValueToFile function to absorb some duplication in the gui.
Fri, May 31, 5:25 PM
bb created D1939: redo rP21036, Create a ConfigDB_CreateAndWriteValueToFile function to absorb some duplication in the gui.
Fri, May 31, 4:59 PM
bb committed rP22326: Set ship status bars in parent.
Set ship status bars in parent
Fri, May 31, 2:01 PM
bb closed D1842: Set ship status bars in parent.
Fri, May 31, 2:00 PM
bb added inline comments to D1462: Enforce formation required member count.
Fri, May 31, 1:56 PM
bb committed rP22325: Reduce defensive_wall* duplication.
Reduce defensive_wall* duplication
Fri, May 31, 1:17 PM
bb closed D1794: template_structure_defensive_wall* simplification.
Fri, May 31, 1:17 PM
bb accepted D1794: template_structure_defensive_wall* simplification.

Couple of minor issues, fixing while committing

Fri, May 31, 1:16 PM
bb added inline comments to D1764: Dynamically sizes the dataCounter overlay.
Fri, May 31, 1:46 AM
bb added inline comments to D828: Unselect lobby game if the selected player isn't present in any game.
Fri, May 31, 12:54 AM

Thu, May 30

bb added inline comments to D1790: Separate stable from barracks.
Thu, May 30, 11:01 PM
bb committed rP22322: Seperate stable from barracks.
Seperate stable from barracks
Thu, May 30, 11:00 PM
bb closed D1790: Separate stable from barracks.
Thu, May 30, 11:00 PM
bb accepted D1790: Separate stable from barracks.
Thu, May 30, 10:55 PM
bb accepted D1768: Formations: GetClosestMember passes wrong entity to filter function.

Once someone starts doing anything with formations, having such a big around can only be annoying, so rather fix it beforehand.

Thu, May 30, 10:15 PM
bb added inline comments to D1790: Separate stable from barracks.
Thu, May 30, 10:01 PM
bb requested changes to D1727: Update auras when a formation member renames.

As a general comment, it might be easier/cleaner to extract some parts of the Add/RemoveMembers function and reuse those (since that is what we will be doing anyways), maybe even creating some helper functions of those exerts.

Thu, May 30, 9:25 PM
bb accepted D1842: Set ship status bars in parent.

No templates changed under this patch, just cleanup => accept

Thu, May 30, 7:27 PM
bb committed rP22320: Rename pers_stables to pers_stable as rest of {civ}_stable to simplify check….
Rename pers_stables to pers_stable as rest of {civ}_stable to simplify check…
Thu, May 30, 7:02 PM
bb closed D1860: Rename pers_stables to pers_stable as rest of {civ}_stable to simplify check done by Petra.
Thu, May 30, 7:02 PM
bb raised a concern with rP20393: Move out of world promoted, packed and upgraded entity as they are not….

Causing another bug revealed by rP22313: a unit that tries to flee from a promoted unit, doesn't know anymore where to flee (since the attacker has no position anymore). This is fixable, by first passing on the fleeing call with the old entID and the promoting it. If required we can always listen to OnEntityRename, but when the attack occurs we don't know the new ent ID (we don't even now if it promotes), see the Damage.js CauseDamge.
Probably needs a test too.

Thu, May 30, 5:36 PM
bb raised a concern with rP22313: Unit Motion: MoveTo family of function no longer returns false if the move is….

While investigating an error messages found two issues in this commit, see the inlines.

Thu, May 30, 5:28 PM

Wed, May 29

bb updated the diff for D1883: Use arrow functions in ai filters.

Up/Down: made this because I stumbled upon this when working on some other patches
Other: kindof hard to look into something without access

Wed, May 29, 10:04 PM

May 13 2019

bb added a comment to D1860: Rename pers_stables to pers_stable as rest of {civ}_stable to simplify check done by Petra.

Upload RIP again, well patch easy enough to review without context. I guess arc is complaining about the spaces in the mapfile names, also committer needs to be careful with the file move...

May 13 2019, 10:25 PM
bb added inline comments to rP22280: Make the ai aware ranges no longer have the barracks class.
May 13 2019, 9:14 PM
bb accepted D1878: [CChart] Add a percentage format.

looks like all summary percentages have a symbol now

May 13 2019, 9:00 PM
bb committed rP22280: Make the ai aware ranges no longer have the barracks class.
Make the ai aware ranges no longer have the barracks class
May 13 2019, 8:53 PM
bb closed D1857: Correct detected number of Barracks by Petra when building training facilities.
May 13 2019, 8:53 PM
bb accepted D1857: Correct detected number of Barracks by Petra when building training facilities.

No other cases of "archery" in code

May 13 2019, 8:41 PM
bb created D1883: Use arrow functions in ai filters.
May 13 2019, 7:46 PM
bb added a comment to D1865: Unit Motion / AI - check ranges explicitly, move in the the State handlers instead of the orders..

I don't think this patch helps D981 a great deal, since consider a unit that is asked to attack something and unitmotion drops it of (with a moveToRange function) just outside the area an IsInRange function thinks it is in range. With this patch unitAI will now think the unit can't move and thus do nothing, meaning we will get idlers.

May 13 2019, 5:13 PM

May 2 2019

bb added a comment to D1857: Correct detected number of Barracks by Petra when building training facilities.

Thanks for noticing this, didn't we also rename the archery class in the commit?

May 2 2019, 1:51 PM

Apr 27 2019

bb added a comment to D1737: Slight cleanup of fogging OnDestroy and some comments.

comment I had laying around:

Apr 27 2019, 11:37 PM

Apr 26 2019

bb added a comment to D1843: ProductionQueue - Refactor the remove item function.

Among other things we should be able to spawn units in autogarnison if free slots but it's not the diff for that)

Careful with Extinct volcano OP-ness (on that map autogarrison would give a significant advantage to some civs)

Apr 26 2019, 9:23 PM · Contributors

Apr 24 2019

bb requested verification of rP22203: Communicate field diminishing returns to the player in the fields tooltip.
Apr 24 2019, 9:17 PM
bb committed rP22220: Correct the grammer of rP22203.
Correct the grammer of rP22203
Apr 24 2019, 9:16 PM
bb closed D1841: efficient -> efficiently in rP22203.
Apr 24 2019, 9:16 PM
bb accepted D1841: efficient -> efficiently in rP22203.
Apr 24 2019, 9:16 PM

Apr 21 2019

bb added a comment to D1613: Improve the plural translation of the "<players> have won" string.

k, now I understand the problem, gaelic hardcodes that 1 and 11 must always be the singular form, however that isn't the case in this string.

Apr 21 2019, 10:32 PM
bb accepted D1663: Display lobby bots differently in the lobby.

Patch still applies correctly, reads correct, front doesn't fall => accept

Apr 21 2019, 9:39 PM
bb added inline comments to D1727: Update auras when a formation member renames.
Apr 21 2019, 6:53 PM
bb added a comment to D1840: RunSpeedMultiplier cleanup: improve variable names and reuse a duplicated function (rP22197).
In D1840#75562, @elexis wrote:

If the value that SetSpeedRatio computes differs from the serialized value, by definition it's OOS?

Yes.
However, that value can only differ if m_SpeedRatio > std::min(ratio, m_RunSpeedMultiplier).
Which is impossible because the only place modifying m_SpeedRatio is SetSpeedRatio, which does m_SpeedRatio = std::min(ratio, m_RunSpeedMultiplier).

consider modifiying m_RunSpeedMultiplier too, which is only done on ownershipchange and valuemodification (afaik), where we set the value too

Apr 21 2019, 6:46 PM
bb committed rP22203: Communicate field diminishing returns to the player in the fields tooltip.
Communicate field diminishing returns to the player in the fields tooltip
Apr 21 2019, 6:26 PM
bb closed D1803: Communicate field diminishing returns to the player.
Apr 21 2019, 6:26 PM
bb accepted D1803: Communicate field diminishing returns to the player.

when someone decides to have something other than a grain field, one can always change it in the parent.

Apr 21 2019, 6:24 PM
bb added inline comments to D1829: Fix Pathgoal::RectContainsGoal family of function for SQUARE goals, reduce ambiguities, improve coherence among the different functions..
Apr 21 2019, 5:51 PM
bb added inline comments to rP22197: Change Run Speed into a Run multiplier..
Apr 21 2019, 5:34 PM
bb added a comment to D438: Change Run Speed into a Run multiplier.
In D438#75520, @elexis wrote:
In D438#74992, @bb wrote:

(we also need to do an OOS test on this btw)
did a quick rejoin test, which did not oos

What does quick rejoin test mean? Which steps did you perform?

Host a game and join with another player (both with the patch ofc), load the game and move stuff around (in formation, guard, attack a deer, do a tech etc.), leave with the joiner, and rejoin. Now move some more stuff and wait a little.

UnitMotion cannot know if this speed is on purpose or not so always adjust and let unitAI and such adapt

Assume this comment is true,
then UnitAI changes the runmultiplier and it yields an OOS, correct?

How will UnitAI change the runMultiplier? it is a template value, maybe modified by some tech...

Isn't serialization of the run multiplier so that UnitMotion can know if this speed is on purpose?

Where is it serialized? It is desirialized such that the rejoiner knows that a tech is researched, further it is a template value.

Is the deserialized runmultiplier read from? It looks like it's overwritten with a different value before it's read from.

The only other place I see it is set, is the init, which should be earlier right?

Apr 21 2019, 5:31 PM
bb committed rP22202: Bring the palisade templates under their own parent (instead of the stone wall)..
Bring the palisade templates under their own parent (instead of the stone wall).
Apr 21 2019, 4:55 PM
bb closed D1796: create template_defensive_palisade.xml.
Apr 21 2019, 4:55 PM
bb accepted D1796: create template_defensive_palisade.xml.

I noticed that some structures have smaller cost than loot, which looks a bit weird. Leaving that as is for now, this patch doesn't change this.

Apr 21 2019, 4:51 PM

Apr 20 2019

bb added inline comments to D1829: Fix Pathgoal::RectContainsGoal family of function for SQUARE goals, reduce ambiguities, improve coherence among the different functions..
Apr 20 2019, 6:55 PM
bb added inline comments to D1828: Health.js cleanup: add tests, add an "IsInjured" function, use GetHitpoints everywhere.
Apr 20 2019, 6:13 PM

Apr 16 2019

bb added inline comments to rP20939: Garrisoned units are lost after an upgrade towards a non garrison holder.
Apr 16 2019, 11:16 PM
bb accepted rP20393: Move out of world promoted, packed and upgraded entity as they are not….

concern fixed by rP20939

Apr 16 2019, 11:16 PM
bb accepted D1826: Fix missing parenthesis in the AI.
Apr 16 2019, 6:14 PM
bb added inline comments to D1737: Slight cleanup of fogging OnDestroy and some comments.
Apr 16 2019, 2:06 PM

Apr 15 2019

bb committed rP22191: align the footprint an obstruction size with the model size for the kush range.
align the footprint an obstruction size with the model size for the kush range
Apr 15 2019, 11:46 PM
bb committed rP22190: unparent the range from the barracks, and reduce the duplication in the civs'….
unparent the range from the barracks, and reduce the duplication in the civs'…
Apr 15 2019, 11:40 PM
bb closed D1791: Separate range from barracks.
Apr 15 2019, 11:40 PM
bb accepted D1791: Separate range from barracks.

Cav got removed from ranges (which makes sense)

Apr 15 2019, 11:35 PM
bb updated the diff for D1398: Implement a press action to be called upon the first keyDown message of a hotkey and use keydown for current press.

years

Apr 15 2019, 10:06 PM
bb accepted D438: Change Run Speed into a Run multiplier.

Some bot is complaining that this patch is rotting to long and needs a license year update

Apr 15 2019, 9:35 PM
bb added a comment to D1815: match unit classes with templates.

Renamings of spear => spearman and co is good imo (wasn't there some earlier revision where it was discussed?)

Apr 15 2019, 8:57 PM

Apr 14 2019

bb added a comment to rP22188: Move tooltips on gamesetup dropdowns from xml to js, since by current gamestup….

Comments By: elexis, Imarok

Apr 14 2019, 10:30 PM
bb committed rP22188: Move tooltips on gamesetup dropdowns from xml to js, since by current gamestup….
Move tooltips on gamesetup dropdowns from xml to js, since by current gamestup…
Apr 14 2019, 10:29 PM
bb closed D594: Fix tooltips not used in gamesetup.
Apr 14 2019, 10:29 PM · Contributors
bb accepted D594: Fix tooltips not used in gamesetup.

proofreading the gamesetup xml and global objects says the patch is complete (did not read the full file for any hidden tooltip in the code)

Apr 14 2019, 10:23 PM · Contributors
bb added inline comments to D1776: Cleanup Timer.js and update documentation.
Apr 14 2019, 10:00 PM
bb committed rP22187: Handle orderone hotkey also for the minimap.
Handle orderone hotkey also for the minimap
Apr 14 2019, 9:30 PM
bb closed D1822: Handle hotkey to order only one unit on minimap.
Apr 14 2019, 9:29 PM · Contributors
bb accepted D1822: Handle hotkey to order only one unit on minimap.

Thx for the patch

Apr 14 2019, 9:12 PM · Contributors

Apr 12 2019

bb committed rP22182: Add ConquestCritical to structures that want it, instead of removing it from….
Add ConquestCritical to structures that want it, instead of removing it from…
Apr 12 2019, 5:05 PM
bb closed D1626: -ConquestCritical clear-up.
Apr 12 2019, 5:05 PM
bb accepted D1626: -ConquestCritical clear-up.

Reading it again, the actual question is how to treat special (the rest looks good)

Apr 12 2019, 5:04 PM
bb committed rP22181: Reduce duplication in template_structure_military*.
Reduce duplication in template_structure_military*
Apr 12 2019, 4:12 PM
bb closed D1793: reduce template_structure_military* duplication.
Apr 12 2019, 4:12 PM
bb accepted D1793: reduce template_structure_military* duplication.

Changes to trivial to not accept,

Apr 12 2019, 3:58 PM
bb added a comment to D1796: create template_defensive_palisade.xml.
In D1796#74399, @Nescio wrote:

Maybe build time, wood cost, and loot ought to be made proportional to health, e.g. health/50?

Whatever makes sense compared to the other palisade structures. e.g cost wise a rocks_curve is pretty similar to a rocks_long, right?

Apr 12 2019, 3:29 PM
bb added a comment to D1803: Communicate field diminishing returns to the player.

I assume agricultural products would be the most general term? Do we want that in game?

Apr 12 2019, 3:19 PM
bb added inline comments to D1822: Handle hotkey to order only one unit on minimap.
Apr 12 2019, 3:15 PM · Contributors

Apr 7 2019

bb added a comment to D1810: Improvements to the translators credits script.

I get that ppl can choose whatever name they want, but who is named 4c905de7e2c9950b7d83273a8070b072 (second one in the german list)? I tried finding him/her in transifex but no luck.

Apr 7 2019, 10:12 PM
bb added inline comments to D1651: aiTips gamesetup cleanup.
Apr 7 2019, 10:11 PM · Contributors
bb added a comment to D1819: Make capture attack work with units with BuildingAI..

I won't stop anyone for making/commiting a temporal fix, but the underlying problem is that we have two components (buidlingAI and unitAI) on the same unit trying to achieve the same thing (attack something). In the end that is the thing we need to fix (as in subunits)

Apr 7 2019, 6:15 PM
bb committed rP22169: recieve -> receive.
recieve -> receive
Apr 7 2019, 6:06 PM