Page MenuHomeWildfire Games

bb
User

Projects

User Details

User Since
Jan 24 2017, 12:54 PM (190 w, 6 d)

Recent Activity

Today

bb accepted D2654: Allow free Upgrades and/or Technologies..
Mon, Sep 21, 6:36 PM
bb added a comment to D2995: Properly internationalize attack names/Generlize to arbitrary names in the GUI.

Then there is the problem of translating. For instance, whilst ‘sword’ can refer to both single- and double-edged blades in English, this is not true for all languages. In Chinese, jiàn is the word for double-edged swords and dāo the term for single-edged swords (and knives). Thus in those languages “sword” would be wrong in about half of the cases.

This is actually easy to fix, we can add a context tag in the template, which will be extracted already. So I just added the code to pipe the context through and use it for translations. In example: one can put <AttackName context="Double-edged">Sword</AttackName> in the template. On this specific topic: I also added context for all sword wielding units.

Mon, Sep 21, 6:35 PM
bb updated the diff for D2995: Properly internationalize attack names/Generlize to arbitrary names in the GUI.

Back to attackName
add context support
add context for swords
improve some names

Mon, Sep 21, 6:33 PM
bb accepted D3009: Refactor UpdateMessageSubscriptions in CCmpRangeOverlayRenderer.

Digging back to D555, this code must be ccmpSelectable copy-pasta

Mon, Sep 21, 2:12 PM

Sat, Sep 19

bb committed rP24050: Add safeguards for all queryOwnerInterface calls.
Add safeguards for all queryOwnerInterface calls
Sat, Sep 19, 7:56 PM
bb closed D2973: Add safeguards for all queryOwnerInterface calls.
Sat, Sep 19, 7:56 PM

Tue, Sep 15

Angen awarded D3008: Correctize cost tooltip for upgrades a Like token.
Tue, Sep 15, 11:54 AM

Mon, Sep 14

bb added inline comments to rP20046: JS Cleanup..
Mon, Sep 14, 11:38 PM
bb requested review of D3008: Correctize cost tooltip for upgrades.
Mon, Sep 14, 9:10 PM
bb added inline comments to rP20046: JS Cleanup..
Mon, Sep 14, 9:00 PM
bb accepted D2654: Allow free Upgrades and/or Technologies..

While reviewing noticed that an upgrade without a cost will add a weird newline in the tooltip. However this is a separate bug, patch incomming.

Mon, Sep 14, 8:34 PM
bb committed rP24040: sloppyness → sloppiness.
sloppyness → sloppiness
Mon, Sep 14, 6:55 PM
bb closed D3003: sloppyness → sloppiness.
Mon, Sep 14, 6:55 PM
bb accepted D3003: sloppyness → sloppiness.
Mon, Sep 14, 6:54 PM

Sun, Sep 13

bb updated the diff for D2995: Properly internationalize attack names/Generlize to arbitrary names in the GUI.

Weapon => WeaponName

Sun, Sep 13, 2:03 PM
bb committed rP24038: Remove visibleclasses from guiinterface.
Remove visibleclasses from guiinterface
Sun, Sep 13, 1:21 PM
bb closed D2997: Remove visibleclasses from guiinterface.
Sun, Sep 13, 1:21 PM
bb added a comment to D2997: Remove visibleclasses from guiinterface.

Or make it useful by using sim-information in the tooltip? Although I guess PetraAI would break if one changes classes in-game.

Note too that the current implementation is broken: from the template we store it under visibleIdentityClasses. Hence the patch letting classes be modifyable, or the patch wanting classes in the simstate, should properly implement it.

Sun, Sep 13, 1:17 PM

Fri, Sep 11

bb updated the diff for D3005: Range safe buildingAI.

Move the check to a loop below. This should help performance since most entities returned by the rangemanager will be in range. Also nukes a loop

Fri, Sep 11, 7:22 PM

Wed, Sep 9

bb added a comment to rP24016: Debuff outpost and remove un-necessary technologies..

Technologies were not very potent and hardly ever researched.

Wed, Sep 9, 8:19 PM

Tue, Sep 8

bb accepted rP23925: Improve ship pickup..
Tue, Sep 8, 3:50 PM
bb added inline comments to D2652: Do not allow upgrading when entity is producing and vice versa..
Tue, Sep 8, 2:05 PM
bb accepted D2755: Don't store the gatherers per player..

The only reason I can see (now) to keep the per player storage is when ordering a unit to gather somewhere, where also enemies are gathering, the unit maybe should kill the enemies before gathering. However this can be considered player responsibility too, sine he should be able too see the enemies in this case. If he can't see them (very large resourcesupply ent or so), it is fine this way. So probably behavior we don't need want.

Tue, Sep 8, 1:23 PM
bb accepted D3006: Fix formation walking following "improved ship pickup" rP23925.

All cases of CMessageMotionUpdate::OBSTRUCTED got the treatment
Both issues seem fixed.

Tue, Sep 8, 11:56 AM

Mon, Sep 7

bb requested review of D3005: Range safe buildingAI.
Mon, Sep 7, 6:32 PM
bb requested changes to D2759: Update range queries to account for entity size.

Considering whether returning to many entities can cause a problem. These are the affected components:
BuildingAI: arrows can fire out of range now. Probably can get away with checking the proper range in the buildingAI (slightly bad that we compute the range twice, with increasing precision)
Auras: probably who cares in this case
Gate: ^^
buildrestiction: ranges got a bit modified => no problem, since the ranges are large compared to the obstructions, small nerf for fortresses and some other structures (they need to be placed further apart)
AlertRaiser: ranges modified => same story as buildrestrictions (small obstruction, large range).
unitAI => nothing really changes, we just respond to more entities, but we still move in range
Attacking/delayedDamaged => fixed by D2963
Trigger: Changed as they should.

Mon, Sep 7, 5:28 PM
bb added inline comments to D2652: Do not allow upgrading when entity is producing and vice versa..
Mon, Sep 7, 3:07 PM
bb accepted D2652: Do not allow upgrading when entity is producing and vice versa..

stylistic issues can be fixed while committing

Mon, Sep 7, 2:42 PM

Sun, Sep 6

bb added a comment to D2657: Allow modders to let buildings spawn buildings..

This patch allows buildings to be build too close to other buildings, outside territory and everything else that buildRestrictions forbids. We should somehow reuse that code here too.

Sun, Sep 6, 9:44 PM
bb added a comment to D3004: Do not display right click tooltip when it is not supported right now.

Don't feel this is the correct way of approaching the issue. I rather have the buttons enabled for the right click.

Sun, Sep 6, 9:05 PM
bb added a comment to rP24025: Fix broken translations of rP24022.

Noted by elexis

Sun, Sep 6, 8:38 PM
bb committed rP24025: Fix broken translations of rP24022.
Fix broken translations of rP24022
Sun, Sep 6, 8:37 PM
bb added a comment to D3002: [Petra/Ai] Use parabolic range calculation when checking range of ranged attacks using elevation bonus from templates.

Shouldn't we do something similar for all attackRange queries in the ai?

Sun, Sep 6, 5:38 PM
bb updated the diff for D2998: Do not hardcode attacktypes in the engine/Atlas.
Sun, Sep 6, 1:02 PM
bb added a comment to D2661: Get attack effects from JSON..

Make sure you consider rP23994 when committing

Sun, Sep 6, 12:52 PM
bb updated the diff for D2998: Do not hardcode attacktypes in the engine/Atlas.
Sun, Sep 6, 12:00 PM
bb updated the diff for D2998: Do not hardcode attacktypes in the engine/Atlas.

Use Cstr, nuke boost

Sun, Sep 6, 12:01 AM

Sat, Sep 5

bb requested review of D2998: Do not hardcode attacktypes in the engine/Atlas.
Sat, Sep 5, 10:54 PM
bb updated the diff for D2997: Remove visibleclasses from guiinterface.

They were used in the tests...

Sat, Sep 5, 9:36 PM
bb requested review of D2997: Remove visibleclasses from guiinterface.
Sat, Sep 5, 9:33 PM
bb added a comment to D2995: Properly internationalize attack names/Generlize to arbitrary names in the GUI.

Why not simply set a translate() in the gui/common/tooltips.js, as used to be the case, and is also done for resistance (e.g. line 198)?

It is not as simple as that: the strings that need to be translated need to be extracted from the scripts, so "just setting a translate call" won't do anything, since the english strings won't be uploaded to transifex.

There are not that many possibilities (Capture, Melee, Ranged). Or just take and translate the node itself?

After D368 the nodes are arbitrary, so many more possibilities. Translating nodes themselves isn't possible either, since they can't be extracted. Moreover, nodes can't contain spaces, while names can (see my Machine gun creation).

Introducing a new node means changing a lot of templates, and more importantly, the names are arbitrary.

Changing templates needs to happen anyways and names will become arbitrary too. This patch is exactly designed for changing all the templates, such that we don't need to do it when changing the code.

Sat, Sep 5, 1:54 PM
bb updated the diff for D2995: Properly internationalize attack names/Generlize to arbitrary names in the GUI.

AttackName => Weapon
Use name of the weapons everywhere, no more projectile names (k, javelin, but that is a weapon too)
Improve elephant and animal names

Sat, Sep 5, 1:53 PM
bb updated the diff for D2995: Properly internationalize attack names/Generlize to arbitrary names in the GUI.
Sat, Sep 5, 1:26 AM
bb requested review of D2995: Properly internationalize attack names/Generlize to arbitrary names in the GUI.
Sat, Sep 5, 12:57 AM

Fri, Sep 4

bb raised a concern with rP23925: Improve ship pickup..

For some reason formation movement is broken after this commit: formationmembers get stuck at obstruction when colliding with them on a path. Reproducible by ordering a (large enough) formation to walk to the other side of a tree (or any obstruction really).

Fri, Sep 4, 11:21 PM
bb accepted D2989: Reuse "APPROACHING"-state in formation combat..

Looks correct from the code, individuals do the same too.
Checking all pushOrderFront calls in the unitIA shows this patch is complete

Fri, Sep 4, 11:17 PM
bb committed rP24022: Indent attack tooltips.
Indent attack tooltips
Fri, Sep 4, 10:22 PM
bb closed D2984: [gui] combine attack tooltips.
Fri, Sep 4, 10:22 PM
bb accepted D2984: [gui] combine attack tooltips.

Note that some tooltips are wrapped to the next line (towers, siege tower), but it is not introduced, nor made worse by this patch

Fri, Sep 4, 10:15 PM
bb added a comment to D2984: [gui] combine attack tooltips.

Note that internationalization is as broken as before (rP22754)

Fri, Sep 4, 4:43 PM

Thu, Sep 3

bb added a comment to D2988: [gameplay] deprecate animal technology .

Instead of nuking the tech, I think there are some other option that should be considered (also combinations):

  • Buff phase requirement to town/city
  • Buff costs (50 food one can do before the first animal, higher amounts maybe not)
  • Split in several parenting techs
Thu, Sep 3, 9:33 PM
bb updated the diff for D2984: [gui] combine attack tooltips.

A proposal: indent splash and statuseffects under the attacktype

Thu, Sep 3, 9:06 PM
bb added inline comments to D2755: Don't store the gatherers per player..
Thu, Sep 3, 1:06 PM
bb added a comment to D2984: [gui] combine attack tooltips.

Seems nice overall indeed. I do would like the splash issue to be fixed before merging.

Thu, Sep 3, 12:35 PM

Wed, Sep 2

bb abandoned D1015: Forced attack on moving targets bug.

Obsolete after D2698

Wed, Sep 2, 8:27 PM

Mon, Aug 31

bb added a comment to D2732: Allow to guard a guard..

Code looks complete and works as advertised.

Mon, Aug 31, 10:50 PM
bb accepted D2698: Do not chase units in FOW/SOD..

D1015 should be abandoned after this patch: bug has gone away and unitmotion doesn't treat moving targets anymore

Mon, Aug 31, 12:12 PM

Fri, Aug 28

bb raised a concern with rP24001: Rename Armour to Resistance and change the way it is processed..
Fri, Aug 28, 9:16 PM
bb added a comment to D2913: Stop dodging arrows by patrol: Wait a few seconds between patrol waypoints..
In D2913#129854, @bb wrote:

Code desperately asking for an animation, needs ticket or so.

Do you think the lack of animation blocks merging?
IMO it could be done later.

Absence of animation doesn't block merging, absence of ticket does ;)

Fri, Aug 28, 8:18 PM
bb committed rP24005: Damage parent of mirage instead of trying to damage the mirage.
Damage parent of mirage instead of trying to damage the mirage
Fri, Aug 28, 8:06 PM
bb closed D2979: Don't try to damage ghosts.
Fri, Aug 28, 8:06 PM
bb updated the diff for D2973: Add safeguards for all queryOwnerInterface calls.
Fri, Aug 28, 7:56 PM
bb added inline comments to D2973: Add safeguards for all queryOwnerInterface calls.
Fri, Aug 28, 6:59 PM
bb updated the diff for D2973: Add safeguards for all queryOwnerInterface calls.
Fri, Aug 28, 6:59 PM
bb updated the diff for D2979: Don't try to damage ghosts.
Fri, Aug 28, 5:29 PM
bb updated the diff for D2979: Don't try to damage ghosts.
Fri, Aug 28, 4:51 PM
bb updated the diff for D2979: Don't try to damage ghosts.

Add test

Fri, Aug 28, 4:49 PM
bb updated the diff for D2979: Don't try to damage ghosts.
Fri, Aug 28, 3:56 PM
bb requested review of D2979: Don't try to damage ghosts.
Fri, Aug 28, 3:52 PM
bb added a comment to D2975: damage resistance from nonNegativeDecimal to integer.

Also what about techs/auras wanting a +x% on armour?

There are none.

Currently yes, but why disallow it for any future mod?

Fri, Aug 28, 2:45 PM
bb accepted D2977: Fix StatusEffects not being applied after rP24001..

grepped for completion that all HandleAttackEffects got a treatment (should have done that earlier)

Fri, Aug 28, 2:32 PM

Thu, Aug 27

bb added a comment to D2975: damage resistance from nonNegativeDecimal to integer.

Don't understand the change from decimals to integers, sounds like a regression to me. If all known mods use integers fine, but why disable any future mod wanting decimals? Also what about techs/auras wanting a +x% on armour?

Thu, Aug 27, 1:23 PM

Wed, Aug 26

bb added a comment to D2913: Stop dodging arrows by patrol: Wait a few seconds between patrol waypoints..

Code desperately asking for an animation, needs ticket or so.

Wed, Aug 26, 9:37 PM
bb added a comment to D1960: Move the controllability of an entity to cmpIdentity..

Open question: do we need to put this in the unit viewer/tooltip? Maybe not since the tooltip will say it quickly.

Wed, Aug 26, 8:50 PM
bb committed rP24000: Group buildings by function in the right selection panel.
Group buildings by function in the right selection panel
Wed, Aug 26, 5:36 PM
bb closed D2807: group defensive structures together.
Wed, Aug 26, 5:36 PM
bb added a comment to D2807: group defensive structures together.

Pre rP23548, the ordering was by phase, common agreement there broke that and hence better group buildings by function then.

Wed, Aug 26, 5:33 PM
bb accepted D2807: group defensive structures together.
Wed, Aug 26, 5:30 PM
bb requested changes to D2807: group defensive structures together.

females and slaves need the same treatment.

Wed, Aug 26, 3:06 PM
bb committed rP23997: Add some missing credits.
Add some missing credits
Wed, Aug 26, 2:49 PM
bb closed D2882: update credits.
Wed, Aug 26, 2:49 PM
bb added a comment to D2882: update credits.

New people should be credited and heads should also be in the list, however, heads should also be credited as such, even former heads.

Wed, Aug 26, 2:47 PM
bb requested review of D2973: Add safeguards for all queryOwnerInterface calls.
Wed, Aug 26, 1:29 PM

Tue, Aug 25

bb accepted D2949: Disable the WordPopulation checkbox for scenarios..
Tue, Aug 25, 4:25 PM
bb committed rP23994: Fix lineendings for json files.
Fix lineendings for json files
Tue, Aug 25, 4:19 PM
bb closed D2958: svn propset for json files.
Tue, Aug 25, 4:19 PM
bb accepted D2958: svn propset for json files.

We should run

svn propset svn:eol-style native $(find . -type f -name "*.json")
svn propset svn:mime-type text/json $(find . -type f -name "*.json")

from time to time in the repo, or let some bot do it

Tue, Aug 25, 4:15 PM
bb accepted D2962: Fix AI using Maurya elephant archers as hunters following rP23916.
Tue, Aug 25, 3:12 PM
bb accepted D2963: Improve splash damage falloff calculation to account somewhat for obstruction size.

Good use of those range functions imo.

Tue, Aug 25, 1:55 PM
bb added a comment to D2968: Play feedback sound on invalid building placement.

Code looks good.

Tue, Aug 25, 10:40 AM

Mon, Aug 24

bb added a comment to D2969: Fix gates reclosing upon garrison..

Here is what happens:

  • Note that first the closing animation of the gate has to be shown once, otherwise the bug does not occur. This (perfectly normal and wanted!!) closing animation sets unitAnimation (via cmpVisual) to play the animation once. Now when a unit is ejected, we go over UpdateGarrisonFlag in the garrisonHolder, which will reload the animation (this is wanted for the garrison flag ofc, it needs to wave in the wind). But for gates, unitAnimation only knows about the closing anim, and will play that again.
Mon, Aug 24, 5:52 PM
bb accepted D2970: Move 'GetDamageBonus"-function from its own helper file to 'Attacking.js'-helper..

Seems like vulcan doesn't like removing files or so, tests work here

Mon, Aug 24, 4:40 PM
bb accepted D2229: Elaborate Armour..

Looks good to me, only a few small issues:

Mon, Aug 24, 2:01 PM
bb committed rP23992: Fix more JsDocs numbers/bools/strings.
Fix more JsDocs numbers/bools/strings
Mon, Aug 24, 1:50 PM
bb committed rP23991: Fix jsDocs object => Object.
Fix jsDocs object => Object
Mon, Aug 24, 1:01 PM

Jul 30 2020

bb added inline comments to D2697: Do not let every entity with UnitAI listen to "OnGlobalConstructionFinished"..
Jul 30 2020, 3:49 PM
bb requested changes to D2229: Elaborate Armour..

Vulcan found some stuff in Resistance.js

Jul 30 2020, 3:26 PM

Jul 27 2020

bb accepted D2904: Fix warning with disabled templates in rP23843.

Looks correct, greps complete

Jul 27 2020, 6:53 PM
bb committed rP23905: Split Audio and Map credits from Art..
Split Audio and Map credits from Art.
Jul 27 2020, 5:19 PM
bb closed D2912: [gui] split art credits.
Jul 27 2020, 5:19 PM