Page MenuHomeWildfire Games
Differential D1224

Engine js call IsXmppClientConnected for XmppClient
ClosedPublic
Actions

Authored by ffffffff on Jan 15 2018, 1:56 AM.

Details

Reviewers
elexis
Commits
rP20872: Allow the JS GUI to find out if the lobby client is currently disconnected.
Summary

States if xmpp client is connected or not.
Test connection

Test Plan

Test connection

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ffffffff created this revision.Jan 15 2018, 1:56 AM
ffffffff updated this revision to Diff 5312.Jan 15 2018, 3:58 AM
ffffffff updated this revision to Diff 5313.

Order m_IsConnected=true/false set before sending gui message.

ffffffff updated this revision to Diff 5318.Jan 15 2018, 4:26 AM
elexis accepted this revision.Jan 15 2018, 5:28 AM

#4315 states that timeout handling basically doesn't exist. It's not a problem of this patch however.
This works for all intends and purposes.
Patch correct and complete. Function names are all good.
Thanks for the patch!

source/lobby/XmppClient.cpp
241 ↗(On Diff #5318)

Crucial to set the bool before sending the message, so that the message can test for the correct state.

source/lobby/scripting/JSInterface_Lobby.cpp
1 ↗(On Diff #5318)

2018 in all files

This revision is now accepted and ready to land.Jan 15 2018, 5:28 AM
Closed by commit rP20872: Allow the JS GUI to find out if the lobby client is currently disconnected. (authored by elexis). · Explain WhyJan 15 2018, 5:30 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
ps/
trunk/
source/
lobby/
3 lines
4 lines
12 lines
scripting/
3 lines
9 lines

Diff 5319

View Options

ps/trunk/source/lobby/IXmppClient.h

Loading...
View Options

ps/trunk/source/lobby/XmppClient.h

Loading...
View Options

ps/trunk/source/lobby/XmppClient.cpp

Loading...
View Options

ps/trunk/source/lobby/scripting/JSInterface_Lobby.h

Loading...
View Options

ps/trunk/source/lobby/scripting/JSInterface_Lobby.cpp

Loading...
Wildfire Games · Phabricator