Details

Reviewers

elexis

Commits

rP20872: Allow the JS GUI to find out if the lobby client is currently disconnected.

Summary

States if xmpp client is connected or not.
Test connection

Test Plan

Test connection

Diff Detail

Lint

Lint Skipped

Unit

Unit Tests Skipped

Event Timeline

ffffffff created this revision.Jan 15 2018, 1:56 AM

Order m_IsConnected=true/false set before sending gui message.

ffffffff updated this revision to Diff 5318.Jan 15 2018, 4:26 AM

#4315 states that timeout handling basically doesn't exist. It's not a problem of this patch however.
This works for all intends and purposes.
Patch correct and complete. Function names are all good.
Thanks for the patch!

source/lobby/XmppClient.cpp
240–241	Crucial to set the bool before sending the message, so that the message can test for the correct state.
source/lobby/scripting/JSInterface_Lobby.cpp
1	2018 in all files

This revision is now accepted and ready to land.Jan 15 2018, 5:28 AM

Closed by commit rP20872: Allow the JS GUI to find out if the lobby client is currently disconnected. (authored by elexis). · Explain WhyJan 15 2018, 5:30 AM

This revision was automatically updated to reflect the committed changes.

Engine js call IsXmppClientConnected for XmppClient
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 5304

source/lobby/IXmppClient.h

source/lobby/XmppClient.h

source/lobby/XmppClient.cpp

source/lobby/scripting/JSInterface_Lobby.h

source/lobby/scripting/JSInterface_Lobby.cpp

Engine js call IsXmppClientConnected for XmppClientClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 5304

source/lobby/IXmppClient.h

source/lobby/XmppClient.h

source/lobby/XmppClient.cpp

source/lobby/scripting/JSInterface_Lobby.h

source/lobby/scripting/JSInterface_Lobby.cpp

Engine js call IsXmppClientConnected for XmppClient
ClosedPublic
Actions

Revision Contents
Changeset List