Load / Delete buttons are not disabled on load panel when there is no any saved game
ClosedPublic
Actions

Authored by ztamas on Mar 1 2018, 5:19 AM.

Details

Reviewers

vladislavbelov

Commits

rP21409: Disables load/delete buttons for an empty savegames list. Fixes #5057.

Trac Tickets

#5057

Test Plan

Open load dialog with some saved games: First item is selected and the two buttons are enabled.
Open load dialog without any saved games: The two buttons are disabled.
Open load dialog with some saved games and remove all items from the list: the two buttons become disabled.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ztamas created this revision.Mar 1 2018, 5:19 AM

Owners added a subscriber: Restricted Owners Package.Mar 1 2018, 5:19 AM

vladislavbelov requested changes to this revision.Mar 1 2018, 9:01 PM

vladislavbelov added a subscriber: vladislavbelov.

vladislavbelov added inline comments.

binaries/data/mods/public/gui/loadgame/load.js
93 ↗	(On Diff #5978)	This duplicates the code, because we already have a logic to disable these buttons in the `selectionChanged()` function. So I suggest to just call the `selectionChanged()`.

This revision now requires changes to proceed.Mar 1 2018, 9:01 PM

Use the selectionChanged method as suggested. It does the same thing, additionally sets validGame / invalidGame status.

vladislavbelov accepted this revision.Mar 1 2018, 9:38 PM

This revision is now accepted and ready to land.Mar 1 2018, 9:38 PM

Closed by commit rP21409: Disables load/delete buttons for an empty savegames list. Fixes #5057. (authored by vladislavbelov). · Explain WhyMar 1 2018, 9:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gui/

loadgame/

load.js

1 line

Diff 5991

View Options

ps/trunk/binaries/data/mods/public/gui/loadgame/load.js

Load / Delete buttons are not disabled on load panel when there is no any saved gameClosedPublicActions