- User Since
- Feb 3 2017, 10:51 PM (106 w, 4 d)
Sun, Feb 17
Actually no, though AddIcons is better than AddIcon. I think these functions are dangerous currently.
It's true, but we didn't drop it yet.
Ok, it should be linked then (I added).
Do we have to update our fcollada? Especially if it has useful changes.
Sat, Feb 16
Currently few of my comments should be fixed anyway, so I add a "Request changes". But also I want to discuss about a method to pass the ping event to the C++.
What's about wraitii suggestion:
If not, I would recommend passing an enum VFS::SORTED or something instead of true or false since C++ doesn't have named arguments
It makes sense to use a name. It'd be easier to read such code.
As we discussed XML is a pretty specific case and it may have some problems. But I can suggest to add a more common parameter, like an ignore mask. Example:
But it also requires a motivation.
I would ask you add a context to your patch.
The patch looks good for me. It only needs to fix some details.
I disagree with that.
Mon, Jan 28
Fri, Jan 25
Fixes elexis and another other another Stan notes.
Thu, Jan 24
Fixes other another Stan notes.
Fixes another Stan notes.
Fixes Stan notes.
@gentz thank you for the patch!
I tested the patch, it works and looks good for me. In any case it's the improvement. If someone wants a more flexible header, the one can create a ticket or ask for a patch.
Tue, Jan 22
Which word or sentence?
1/5 of RAM.
Mon, Jan 21
If 1/5 of the game is one file that will be outdated each next month and that used only for a small feature, it's pretty strange for me.
Jan 20 2019
How many elements are sorted for a worst case?
Yes, it could be. If it's needed for someone.
The GeoLite2 Country and City databases are updated on the first Tuesday of each month. The GeoLite2 ASN database is updated every Tuesday.
It means that our packed IP list will be outdated for the next month after each release.
Jan 19 2019
I made a performance test for comparison: P149.
Ah, I got it. Yes, you're absolutely right. The origin is inside the sphere, not the ray.
How many space the list of only countries costs?
Yes. Because it won't be handled as intersection currently.
- add basic C++ headers
- a little bit of polishing
Because a VPN service can use a random IP, you can't predict which IP is proxy (because of botnet, etc). Some people use custom VPN (dedicated server with a simple tunnel). So I suppose the GeoLite2 can detect only popular VPN for usual users.
So the status of proxy is useless, because it does guarantee anything.
The problem is that the database can not be complete.
Jan 18 2019
@elexis Do you have any objection that prevents to commit the patch?
*VPN detection:* Notice the Blocks file contains which clients are using proxies / VPN networks.
It's not possible for all proxies/VPN.
I think we should restrict the number of pings, because I'm sure there will be many spammer on servers.
I didn't take a look at the JS code.
Jan 14 2019
We shouldn't use such way of dynamic loading until we have atlases for textures. Because currently the AddIcon calling for each sprite means the slow cycle: (init) read data from drive/memory > create a small texture on GPU > fill the texture, (draw) bind the texture > draw the texture. All this makes the RAM and VRAM pretty fragmented.
Jan 13 2019
Jan 7 2019
Could you attach a link to the build?
Also check that:
- A comment starts with a capital letter.
- No space before brace in static_cast<...>(.