Page MenuHomeWildfire Games

vladislavbelov (Vladislav Belov)
UserAdministrator

User Details

User Since
Feb 3 2017, 10:51 PM (371 w, 3 d)
Roles
Administrator

Recent Activity

Fri, Feb 23

vladislavbelov added a comment to D5245: Cleanup onager after removing soldier construction.

The patch isn't related to the OOS reason. Building a unit preview is just a trigger for the OOS. So this change does seem like a cleanup after the previous one. But maybe we want to support building units, then we must have elexis's patch (I'd prefer to commit it anyway, maybe after some changes/tests).

Fri, Feb 23, 8:01 PM

Sun, Feb 18

vladislavbelov added a comment to D5242: Deprecates OpenGL ARB backend.
In D5242#223156, @sera wrote:

You could render in a different window and copy back the frame as well as forward the events. Worth it? Probably not.

Also might be a performance loss.

Sun, Feb 18, 5:16 PM
vladislavbelov added a comment to D5244: Adds a hack to detect missing SPIR-V mod for SVN.
In D5244#223158, @sera wrote:

I suggest to add a shaders not found error message and maybe give a hint as for the possible cause and solution, otherwise LGTM apart from the obvious linter warning.

Sun, Feb 18, 5:11 PM
vladislavbelov requested review of D5244: Adds a hack to detect missing SPIR-V mod for SVN.
Sun, Feb 18, 4:17 PM

Feb 17 2024

vladislavbelov added a comment to D5242: Deprecates OpenGL ARB backend.
In D5242#223121, @sera wrote:

About atlas, wx itself uses gl but that doesn't mean you can't use vulkan for the viewport, anyway mostly a non issue and certainly low prio.

Vulkan can't access the viewport without interacting with wx.

Feb 17 2024, 3:34 PM

Feb 16 2024

vladislavbelov requested review of D5242: Deprecates OpenGL ARB backend.
Feb 16 2024, 8:12 PM
vladislavbelov committed rP28034: Accounts maxAnisotropy for Vulkan samplers..
Accounts maxAnisotropy for Vulkan samplers.
Feb 16 2024, 7:46 PM

Feb 14 2024

vladislavbelov added a comment to D5239: Use std::function instead of inhereting from CNetFileReceiveTask.

Is it possible to make a test?

Feb 14 2024, 7:10 PM
vladislavbelov accepted D5237: More generic hash function for FSM.

LGTM.

Feb 14 2024, 7:09 PM
vladislavbelov added inline comments to D5237: More generic hash function for FSM.
Feb 14 2024, 11:42 AM

Feb 13 2024

vladislavbelov added inline comments to D5239: Use std::function instead of inhereting from CNetFileReceiveTask.
Feb 13 2024, 10:55 PM
vladislavbelov added inline comments to D5237: More generic hash function for FSM.
Feb 13 2024, 10:45 PM
vladislavbelov added a comment to D5241: Fixing inverted increasing / decreasing of camera rotation speed.

@Papnaas you can abandon the patch, for that you need to choose Add Action > Revision Action > Abandon Revision.

Feb 13 2024, 11:18 AM

Feb 12 2024

vladislavbelov added inline comments to D5239: Use std::function instead of inhereting from CNetFileReceiveTask.
Feb 12 2024, 11:53 PM
vladislavbelov accepted D5236: Remove the StateSet from FSM.

LGTM.

Feb 12 2024, 11:34 PM
vladislavbelov added inline comments to D5237: More generic hash function for FSM.
Feb 12 2024, 11:27 PM

Jan 29 2024

vladislavbelov raised a concern with rP28020: Split the FSM-transitions and put them in an unordered_map.

unsigned int doesn't fit static assertions (see the diff build results):

1>source\network\fsm.h(173): error C2607: static assertion failed (compiling source file ..\..\..\source\network\FSM.cpp)
1>source\network\fsm.h(173): error C2607: static assertion failed (compiling source file ..\..\..\source\network\NetClient.cpp)
1>source\network\fsm.h(173): error C2607: static assertion failed (compiling source file ..\..\..\source\network\NetClientTurnManager.cpp)
1>source\network\fsm.h(173): error C2607: static assertion failed (compiling source file ..\..\..\source\network\NetSession.cpp)
1>source\network\fsm.h(173): error C2607: static assertion failed (compiling source file ..\..\..\source\network\NetFileTransfer.cpp)
1>source\network\fsm.h(173): error C2607: static assertion failed (compiling source file ..\..\..\source\network\NetServer.cpp)
1>source\network\fsm.h(173): error C2607: static assertion failed (compiling source file ..\..\..\source\network\NetServerTurnManager.cpp)
Jan 29 2024, 8:36 PM
vladislavbelov added inline comments to D5225: Put the FSM-transitions in an unordered_map.
Jan 29 2024, 8:28 PM
vladislavbelov added a comment to D5206: [Gameplay][fix] Use a promotion approach for marian reforms.

elexis found the problem (I'll try to make a patch): this.phenotype = pickRandom(this.GetPossiblePhenotypes()); in Identity. So the current patch is needed only if it's useful for the gameplay.

Jan 29 2024, 11:02 AM

Jan 20 2024

vladislavbelov added a comment to D5235: #5288: N18 - realloc() possible leak.

We're trying to avoid patching third parties. Ideally a PR should be created in the third party repo and then our library might be updated.

Jan 20 2024, 1:29 PM
vladislavbelov added a comment to D5234: #5288: N16, N17 - checking memory allocation made using new..

@phosit LGTM, you might commit it.

Jan 20 2024, 1:27 PM
vladislavbelov added a comment to D5231: [GUI] Improve and Combine in-game HUD panel textures into a texture sheet.

@vladislavbelov does it address your concerns now?

The texture seems ok to me. Maybe I'd rename it to hud_panel (because it's reused for all panels), but it's optional.

Jan 20 2024, 10:40 AM

Jan 17 2024

vladislavbelov committed rP28011: Makes pipeline state dirty on Vulkan only when VertexInputLayout was changed..
Makes pipeline state dirty on Vulkan only when VertexInputLayout was changed.
Jan 17 2024, 8:55 PM
vladislavbelov committed rP28010: Adds compute shaders support and scaling with FSR..
Adds compute shaders support and scaling with FSR.
Jan 17 2024, 8:43 PM
vladislavbelov closed D5218: Adds compute shaders support and scaling with FSR.
Jan 17 2024, 8:43 PM

Jan 16 2024

vladislavbelov added a comment to D5206: [Gameplay][fix] Use a promotion approach for marian reforms.

So, those issues being: graphic error upon click, errors for training while reforms tech completes (fixed with current diff), and the OOS?
I really don't know what would cause this graphics error, particularly when something is clicked. @nifa made was responsible for some changes to the onager and particularly for designing the packed onager. I would think it is because of a missing spirv shader, but that fact it only happens upon click makes me doubt that.

Jan 16 2024, 12:05 AM

Jan 15 2024

vladislavbelov added a comment to D5206: [Gameplay][fix] Use a promotion approach for marian reforms.

see https://trac.wildfiregames.com/ticket/6888#

I'd like to note that #6888 contains 3 different issues (4 maybe). OOS is unrelated to the current diff.

Jan 15 2024, 11:21 PM

Jan 12 2024

vladislavbelov added a comment to D5231: [GUI] Improve and Combine in-game HUD panel textures into a texture sheet.

Combines the textures of all 3 panels into one texture sheet (per @vladislavbelov 's ancient request).

It's best when textures are reused or tightly packed. According to the preview it has much more of redundant space. Is it possible to reuse the same texture for all three panels?

Jan 12 2024, 7:22 PM

Jan 8 2024

vladislavbelov added inline comments to D5218: Adds compute shaders support and scaling with FSR.
Jan 8 2024, 7:18 PM
vladislavbelov updated the diff for D5218: Adds compute shaders support and scaling with FSR.

Fixes notes.

Jan 8 2024, 6:26 PM
vladislavbelov added inline comments to D5218: Adds compute shaders support and scaling with FSR.
Jan 8 2024, 6:20 PM
vladislavbelov added inline comments to D5218: Adds compute shaders support and scaling with FSR.
Jan 8 2024, 5:54 PM
vladislavbelov added inline comments to D5218: Adds compute shaders support and scaling with FSR.
Jan 8 2024, 4:42 PM
vladislavbelov updated the diff for D5218: Adds compute shaders support and scaling with FSR.

Fixes notes for options by @Stan and @sera.

Jan 8 2024, 2:51 PM

Jan 6 2024

vladislavbelov added inline comments to D5218: Adds compute shaders support and scaling with FSR.
Jan 6 2024, 6:48 PM
vladislavbelov added inline comments to D5218: Adds compute shaders support and scaling with FSR.
Jan 6 2024, 3:46 PM
vladislavbelov added inline comments to D5218: Adds compute shaders support and scaling with FSR.
Jan 6 2024, 3:29 PM
vladislavbelov added inline comments to D5218: Adds compute shaders support and scaling with FSR.
Jan 6 2024, 12:49 PM
vladislavbelov updated the diff for D5218: Adds compute shaders support and scaling with FSR.
Jan 6 2024, 12:21 AM

Jan 4 2024

vladislavbelov added a comment to D5218: Adds compute shaders support and scaling with FSR.

Likely we mean something different. I suggested a change for the two places I thought about.

I thought you're talking about all shaders code :)

Jan 4 2024, 9:42 PM

Jan 3 2024

vladislavbelov added inline comments to D5218: Adds compute shaders support and scaling with FSR.
Jan 3 2024, 10:00 PM
vladislavbelov added a comment to D5218: Adds compute shaders support and scaling with FSR.

There is still a lot duplication.

I agree and I'd like to fix it. But unfortunately I don't have time for everything, first of all I'd like to get some performance for the next release.

Jan 3 2024, 9:55 PM
vladislavbelov accepted D5228: Set svn:eol-style native on files added in rP27994.
Jan 3 2024, 9:46 PM

Dec 31 2023

vladislavbelov resigned from rP27786: Make the space in 0 A.D. non-breaking throughout the codebase..
Dec 31 2023, 12:17 PM
vladislavbelov resigned from rP27908: Make the RLInterface local.
Dec 31 2023, 12:17 PM

Dec 30 2023

vladislavbelov added a comment to D5222: Don't use a ScriptContext on the server.

We don't have any passing network test.

That's not good.

Dec 30 2023, 2:47 PM
vladislavbelov added a comment to rP27994: Add files that are missing in rP27992.

There are missing svn:eol-style native.

Dec 30 2023, 2:41 PM

Dec 29 2023

vladislavbelov added a comment to D5222: Don't use a ScriptContext on the server.

But every object can be rearanged to be serializable.

It means additional work for each type and duplicated serializers for JSON.

Dec 29 2023, 3:34 PM

Dec 28 2023

vladislavbelov updated the diff for D5218: Adds compute shaders support and scaling with FSR.

Fixes notes.

Dec 28 2023, 9:59 PM

Dec 25 2023

vladislavbelov added a comment to D5222: Don't use a ScriptContext on the server.

No

It'd be good to have one.

Dec 25 2023, 10:08 PM
vladislavbelov added inline comments to D5218: Adds compute shaders support and scaling with FSR.
Dec 25 2023, 8:50 PM
vladislavbelov added a comment to D5223: Don't use std::shared_ptr<ScriptContext> in the CSimulation2.

The patch itself seems ok. But https://code.wildfiregames.com/rP27945 doesn't have lifetime guarantes.

Dec 25 2023, 8:50 PM
vladislavbelov added a comment to D5222: Don't use a ScriptContext on the server.

Do we have tests for allowCheats be properly broadcasted? Can you imagine that we'd add a JS value in the future (maybe there is an existing patch)?

Dec 25 2023, 8:03 PM
vladislavbelov added a comment to D5225: Put the FSM-transitions in an unordered_map.

How many transitions we have in the worst case?

Dec 25 2023, 8:00 PM
vladislavbelov added a comment to D5226: [WIP] I tried to remove g_XmppClient.

See https://code.wildfiregames.com/D5221#inline-101376 why I think the change isn't so useful.

Dec 25 2023, 7:50 PM
vladislavbelov added inline comments to D5221: Don't use std::shared_ptr to store m_ScriptContext and m_ScriptInterface in the CGUIManager.
Dec 25 2023, 7:49 PM
vladislavbelov added inline comments to D5195: Use templates instead of macros to restrict access to the VFS.
Dec 25 2023, 7:30 PM
vladislavbelov added a comment to D5208: Don't execute the task when no Future awaits it anymore.

Most of the times the callback stores a reference to a variable in scope where the Future is in. When the scope is left the reference get's dangling. CancelOrWait is called in multiple places (mostly destructors) to ensure the callback isn't executed anymore.

Dec 25 2023, 7:24 PM

Dec 24 2023

vladislavbelov added a comment to D5211: Use std functionality for fps-limit.

Are you on windows? In msvc high_resulution_clock is an alias for steady_clock.

Yes, I was testing on Windows.

Dec 24 2023, 1:02 AM
vladislavbelov added a comment to D5221: Don't use std::shared_ptr to store m_ScriptContext and m_ScriptInterface in the CGUIManager.

Also dates.

Dec 24 2023, 12:48 AM

Dec 22 2023

vladislavbelov added a comment to D5106: Uses per-vertex lighting for translucent objects until they are fixed.

Okay to commit, you think?

Dec 22 2023, 11:29 PM
wowgetoffyourcellphone awarded D5106: Uses per-vertex lighting for translucent objects until they are fixed a Dat Boi token.
Dec 22 2023, 7:38 AM

Dec 14 2023

vladislavbelov added a comment to D4425: Use the threadpool for texture conversion.

12 seems fine as an arbitrary limit.

Dec 14 2023, 9:48 PM
vladislavbelov updated the diff for D5218: Adds compute shaders support and scaling with FSR.
Dec 14 2023, 8:06 PM

Dec 13 2023

vladislavbelov removed a reviewer for D5219: Fix build with libxml2 v2.12.1: Itms.
Dec 13 2023, 9:14 PM

Dec 12 2023

vladislavbelov added a comment to D5211: Use std functionality for fps-limit.

It seems the behavior was changed (maybe because of steady_clock precision): when I set FPS throttling in menus to 100 (100.11 to be precise) shown FPS is ~91 with the patch and ~100 without the patch.

Dec 12 2023, 10:56 PM
vladislavbelov accepted D5219: Fix build with libxml2 v2.12.1.

I don't think avoiding preprocessor helps here. But I don't mind for that case.

Dec 12 2023, 10:45 PM
vladislavbelov added a comment to D5166: follow the selected entity by clicking on its portrait or double-clicking on its icon.

The patch changes behavior for heroes and treasures (also maybe researchers) which isn't mentioned. When a hero is moving the camera follows (without the patch it just goes to that position at the time and stays still).

Dec 12 2023, 10:41 PM

Dec 10 2023

vladislavbelov added a comment to D5218: Adds compute shaders support and scaling with FSR.
In D5218#221743, @sera wrote:

Could repro again and the change fixes it

Great, thank you!

Dec 10 2023, 10:18 PM
vladislavbelov updated the summary of D5218: Adds compute shaders support and scaling with FSR.
Dec 10 2023, 9:56 PM
vladislavbelov added a comment to D5218: Adds compute shaders support and scaling with FSR.
In D5218#221718, @sera wrote:
ERROR: Failed to compile shader 'shaders/glsl/compute_downscale.cs':
0:27(31): error: no function with name 'texture2D'
0:27(2): error: no matching function for call to `imageStore(image2D, ivec2, error)'; candidates are:

Should be fixed with the last update. To reproduce (I wasn't able locally) you need to choose OpenGL backend (restart after that), enable post processing, set scale to 200%.

Dec 10 2023, 9:41 PM
vladislavbelov updated the diff for D5218: Adds compute shaders support and scaling with FSR.

Fixes compute_downscale.cs compilation

Dec 10 2023, 9:40 PM
vladislavbelov added a comment to D5218: Adds compute shaders support and scaling with FSR.
In D5218#221730, @sera wrote:

But might have been using opengl, maybe related to enabling preprocessing or some part thereof.

Scaling requires post processing be enabled indeed.

Dec 10 2023, 9:20 PM
vladislavbelov added a comment to D5219: Fix build with libxml2 v2.12.1.

libxml2 v1.12.1 includes less header implicitly.

You mean v2.12.1?

Dec 10 2023, 9:19 PM
vladislavbelov added a comment to D5218: Adds compute shaders support and scaling with FSR.
In D5218#221718, @sera wrote:

After fiddling a while with this new feature and checking the console after I saw the above, but can't figure out how to reproduce it :)

Generally seems to work.

Could you post your userreport_hwdetect.txt?

Dec 10 2023, 8:44 PM
vladislavbelov updated the Trac tickets for D5218: Adds compute shaders support and scaling with FSR.
Dec 10 2023, 3:15 PM
vladislavbelov added a comment to D5218: Adds compute shaders support and scaling with FSR.

I suggest you post on forums like you did with testing Vulkan implementation.

Yeah, I will do after committing.

Dec 10 2023, 3:12 PM
asterix awarded D5218: Adds compute shaders support and scaling with FSR a Party Time token.
Dec 10 2023, 7:30 AM

Dec 9 2023

vladislavbelov requested review of D5218: Adds compute shaders support and scaling with FSR.
Dec 9 2023, 11:49 PM

Dec 8 2023

vladislavbelov added inline comments to rP27962: Split Receiver from SharedState.
Dec 8 2023, 11:24 AM

Dec 3 2023

vladislavbelov committed rP27965: Revert non-ASCII characters from source and configuration files introduced in….
Revert non-ASCII characters from source and configuration files introduced in…
Dec 3 2023, 1:30 AM
vladislavbelov closed D5185: Revert non-ASCII characters from source and configuration files introduced in rP27786.
Dec 3 2023, 1:30 AM
vladislavbelov added a comment to D4425: Use the threadpool for texture conversion.

So the queue limit was about memory-consumption? I thought it was about lag.

It was and still is about lag, but I'm also worrying that the queue capacity isn't limited anymore.

Dec 3 2023, 12:06 AM

Dec 2 2023

vladislavbelov added inline comments to D5139: [Map] Extend Flood.
Dec 2 2023, 11:59 PM
vladislavbelov added inline comments to rP27941: Move placement options from rmgen2 to rmgen-common.
Dec 2 2023, 11:58 PM
vladislavbelov added inline comments to rP27928: Fix serialization test following rP27673 - Fix CalculateTerritories after….
Dec 2 2023, 11:55 PM
vladislavbelov added a comment to D5189: Turn the FLOODFILL macro in to a function.

Have you measured performance for those changes?

Dec 2 2023, 11:52 PM
vladislavbelov added inline comments to rP27962: Split Receiver from SharedState.
Dec 2 2023, 11:29 PM

Nov 30 2023

vladislavbelov added inline comments to D4425: Use the threadpool for texture conversion.
Nov 30 2023, 11:55 PM

Nov 20 2023

vladislavbelov added inline comments to rP27944: Put the CMapGeneratorWorker completely inside the task.
Nov 20 2023, 7:51 PM

Nov 10 2023

vladislavbelov added a comment to D5167: Introduce CLogger::ScopedReplacement and FileLogger.

@vladislavbelov do you have a outstanding input?

Nov 10 2023, 8:38 PM

Nov 9 2023

vladislavbelov committed rP27925: Adds test for loading actor and model having proper flags..
Adds test for loading actor and model having proper flags.
Nov 9 2023, 12:23 AM
vladislavbelov closed D5172: Adds test for loading actor and model having proper flags.
Nov 9 2023, 12:23 AM
vladislavbelov committed rP27924: Reduces code duplication of specular calculation in shaders..
Reduces code duplication of specular calculation in shaders.
Nov 9 2023, 12:08 AM
vladislavbelov closed D5178: Reduces code duplication of specular calculation.
Nov 9 2023, 12:08 AM

Nov 8 2023

vladislavbelov updated the diff for D5172: Adds test for loading actor and model having proper flags.
Nov 8 2023, 11:28 PM
vladislavbelov added a comment to D5181: Fix serialization test following rP27673 - Fix CalculateTerritories after deserialization.

I believe this also affected blinking territory, but I'm slightly less sure there - unlikely it would show up in game since it can only affect the center of a group of territory tiles, and unless I'm wrong we don't show borders when the borders are very small?

You mean like #1229?

Nov 8 2023, 6:28 PM

Nov 7 2023

vladislavbelov updated the diff for D5185: Revert non-ASCII characters from source and configuration files introduced in rP27786.
Nov 7 2023, 10:53 PM
vladislavbelov added a comment to D5185: Revert non-ASCII characters from source and configuration files introduced in rP27786.

You probably should fix the linter as well.

Yeah, thanks!

Nov 7 2023, 10:53 PM
vladislavbelov committed rP27921: Moves single descriptor set binding management for Vulkan to a separate class..
Moves single descriptor set binding management for Vulkan to a separate class.
Nov 7 2023, 10:44 PM