Page MenuHomeWildfire Games

vladislavbelov (Vladislav Belov)
User

User Details

User Since
Feb 3 2017, 10:51 PM (319 w, 6 d)

Recent Activity

Fri, Mar 17

vladislavbelov added a comment to D4969: Script to generate SPIR-V from GLSL shaders.
In D4969#211913, @Stan wrote:

The Readme should probably mention you need to install GLSLC (does it have a minimum version?)

Added.

Fri, Mar 17, 5:14 PM
vladislavbelov updated the diff for D4969: Script to generate SPIR-V from GLSL shaders.
Fri, Mar 17, 5:13 PM

Thu, Mar 16

vladislavbelov updated the diff for D4969: Script to generate SPIR-V from GLSL shaders.
Thu, Mar 16, 5:36 PM
vladislavbelov updated the diff for D4969: Script to generate SPIR-V from GLSL shaders.
Thu, Mar 16, 5:19 PM

Tue, Mar 14

vladislavbelov committed rP27579: Fixes the property name of available devices in a Vulkan report..
Fixes the property name of available devices in a Vulkan report.
Tue, Mar 14, 9:22 PM

Sun, Mar 12

vladislavbelov committed rP27576: Fixes decals with default normal texture..
Fixes decals with default normal texture.
Sun, Mar 12, 2:10 PM
vladislavbelov closed D4966: Fixes decals with default normal texture.
Sun, Mar 12, 2:09 PM
vladislavbelov committed rP27575: Fixes grass with normal and specular textures..
Fixes grass with normal and specular textures.
Sun, Mar 12, 1:05 PM
vladislavbelov closed D4968: Fixes grass with normal and specular textures.
Sun, Mar 12, 1:05 PM

Sat, Mar 11

wowgetoffyourcellphone awarded D4966: Fixes decals with default normal texture a Dat Boi token.
Sat, Mar 11, 9:09 PM
vladislavbelov committed rP27573: Switches VMA to Vulkan 1.1..
Switches VMA to Vulkan 1.1.
Sat, Mar 11, 8:16 PM
vladislavbelov closed D4947: Switches VMA to Vulkan 1.1.
Sat, Mar 11, 8:16 PM

Fri, Mar 10

vladislavbelov requested review of D4969: Script to generate SPIR-V from GLSL shaders.
Fri, Mar 10, 8:31 PM
vladislavbelov updated the summary of D4968: Fixes grass with normal and specular textures.
Fri, Mar 10, 7:56 PM
vladislavbelov requested review of D4968: Fixes grass with normal and specular textures.
Fri, Mar 10, 7:11 PM
vladislavbelov updated the summary of D4966: Fixes decals with default normal texture.
Fri, Mar 10, 8:20 AM

Thu, Mar 9

vladislavbelov updated the diff for D4947: Switches VMA to Vulkan 1.1.
Thu, Mar 9, 8:46 PM
vladislavbelov added a comment to D4966: Fixes decals with default normal texture.
In D4966#211595, @Stan wrote:

In the future we need to replace all textures by CLAMP_TO_EDGE, because border color might be only black, white or transparent on some hardware.

Can you clarify this for me? Do you mean texture samplers? What is the border here?

I mean address mode of texture samplers, particularly Sampler::AddressMode::CLAMP_TO_EDGE.

Thu, Mar 9, 6:20 PM
vladislavbelov requested review of D4966: Fixes decals with default normal texture.
Thu, Mar 9, 5:57 PM

Tue, Feb 28

vladislavbelov updated the diff for D4947: Switches VMA to Vulkan 1.1.
Tue, Feb 28, 11:28 PM
vladislavbelov added a comment to D4949: Adds more libraries to feedback reports.

It already is accessable.

Nope, it's implementation defined. You just recieve const JS::RootedValue& librarySettings. It might be silently built or copied inside.

Tue, Feb 28, 8:09 PM
vladislavbelov added a comment to D4949: Adds more libraries to feedback reports.

That isn't that hard: make m_LibrarySettings public and use reporter.m_LibrarySettings.

It's not good to allow access for everyone.

Tue, Feb 28, 6:31 PM
vladislavbelov committed rP27564: Fixes GL ES version report after GL_INVALID_ENUM triggered by glEnable….
Fixes GL ES version report after GL_INVALID_ENUM triggered by glEnable…
Tue, Feb 28, 5:58 PM
vladislavbelov added a comment to D4949: Adds more libraries to feedback reports.

Whow that changed much... Im not sure if it's for the better. I dont like the callback (it hides the data-flow)

appendLibrary(LibraryReporter{rq, "boost"}.Add("version", BOOST_VERSION));

In appendLibrary you still need to extract JS::RootedValue (JS::RootedValue isn't movable nor copyable IIRC) that means you still hides the data-flow.

Tue, Feb 28, 5:42 PM
vladislavbelov updated the diff for D4949: Adds more libraries to feedback reports.
Tue, Feb 28, 11:02 AM

Wed, Feb 22

vladislavbelov added a comment to D4949: Adds more libraries to feedback reports.

I would make libraries an array instead of a class (I know it's not called class in JS).
Should "libraries" only contain versions then it should be called "library_versions". If it does contain everithing library related (I prefere that option) then SDL should also be in there.

I don't mind, though it'll make the report a bit bigger:

// This:
{
	"enet": "...",
	// ...
}
// Or this:
[
	{
		"name": "enet",
		"version": "...",
	},
	// ...
]

Propably also Vulkan...

Vulkan isn't just a library, it's a backend which depends on environment and configuration. Libraries look more constant in that way.

Wed, Feb 22, 3:46 PM

Feb 21 2023

vladislavbelov updated the diff for D4950: Removes ogl.h from PCH.
Feb 21 2023, 9:54 AM

Feb 20 2023

vladislavbelov updated the diff for D4947: Switches VMA to Vulkan 1.1.
Feb 20 2023, 9:30 PM
vladislavbelov updated the diff for D4950: Removes ogl.h from PCH.
Feb 20 2023, 9:26 PM
vladislavbelov committed rP27556: Removes ogl.h from PCH..
Removes ogl.h from PCH.
Feb 20 2023, 9:07 PM
vladislavbelov closed D4950: Removes ogl.h from PCH.
Feb 20 2023, 9:07 PM
vladislavbelov requested review of D4950: Removes ogl.h from PCH.
Feb 20 2023, 6:18 PM
vladislavbelov added a comment to D4949: Adds more libraries to feedback reports.

Why not call ReportSDL from within ReportLibraries?

I was thinking about that. I'm not sure which variant is better. In one hand SDL is a library on other hand SDL needs to print not only its version but also some additional info like CPU count.

Feb 20 2023, 6:07 PM
vladislavbelov requested review of D4949: Adds more libraries to feedback reports.
Feb 20 2023, 11:28 AM

Feb 17 2023

vladislavbelov committed rP27552: Implements framebuffer readback for Vulkan to allow screenshots..
Implements framebuffer readback for Vulkan to allow screenshots.
Feb 17 2023, 6:38 PM
vladislavbelov closed D4940: Implements framebuffer readback for Vulkan to allow screenshots.
Feb 17 2023, 6:36 PM
vladislavbelov updated the diff for D4940: Implements framebuffer readback for Vulkan to allow screenshots.
Feb 17 2023, 5:16 PM

Feb 16 2023

vladislavbelov updated the diff for D4940: Implements framebuffer readback for Vulkan to allow screenshots.
Feb 16 2023, 6:28 PM
vladislavbelov added inline comments to D4940: Implements framebuffer readback for Vulkan to allow screenshots.
Feb 16 2023, 5:24 PM

Feb 15 2023

vladislavbelov requested review of D4940: Implements framebuffer readback for Vulkan to allow screenshots.
Feb 15 2023, 7:04 PM

Feb 13 2023

vladislavbelov committed rP27537: Increases minImageCount for Vulkan swapchain only when there is a room for that..
Increases minImageCount for Vulkan swapchain only when there is a room for that.
Feb 13 2023, 12:13 AM

Feb 12 2023

vladislavbelov committed rP27536: Fixes invalid swapchain size during a window minimize..
Fixes invalid swapchain size during a window minimize.
Feb 12 2023, 11:59 PM
vladislavbelov closed D4932: Fixes invalid swapchain size during a window minimize.
Feb 12 2023, 11:59 PM

Feb 9 2023

vladislavbelov added a comment to D4935: New input handler system.

I'd prefer to rewrite our event system, because currently it's too C-style and unsafe.

Feb 9 2023, 8:31 PM
vladislavbelov added inline comments to D4932: Fixes invalid swapchain size during a window minimize.
Feb 9 2023, 8:09 PM

Feb 8 2023

vladislavbelov added inline comments to D4932: Fixes invalid swapchain size during a window minimize.
Feb 8 2023, 5:18 PM

Feb 7 2023

vladislavbelov requested review of D4932: Fixes invalid swapchain size during a window minimize.
Feb 7 2023, 11:49 PM

Feb 2 2023

vladislavbelov added a comment to D4927: Local render statistics.

Is that a consern or an idea for another task?
Why is it less error prone?
Nit: It would add duplication.

Feb 2 2023, 6:38 PM
vladislavbelov added a comment to D4927: Local render statistics.

I'd prefer to calculate the number of draw calls and related numbers inside backend as it's much less error prone.

Feb 2 2023, 4:17 PM
vladislavbelov added inline comments to D4923: Fix player owned entities that should belong to gaia (Editor).
Feb 2 2023, 8:50 AM

Feb 1 2023

vladislavbelov committed rP27522: Fixes overflow of inplace vertex and index Vulkan buffers..
Fixes overflow of inplace vertex and index Vulkan buffers.
Feb 1 2023, 11:09 PM
vladislavbelov closed D4920: Fixes overflow of inplace vertex and index buffers.
Feb 1 2023, 11:09 PM
vladislavbelov committed rP27521: Fixes Atlas previews after rP26142..
Fixes Atlas previews after rP26142.
Feb 1 2023, 10:57 PM
vladislavbelov closed D4919: Fixes Atlas preview after rP26142.
Feb 1 2023, 10:56 PM
vladislavbelov added inline comments to D4920: Fixes overflow of inplace vertex and index buffers.
Feb 1 2023, 8:45 PM
vladislavbelov added inline comments to D4920: Fixes overflow of inplace vertex and index buffers.
Feb 1 2023, 8:40 PM
vladislavbelov updated the diff for D4920: Fixes overflow of inplace vertex and index buffers.
Feb 1 2023, 8:37 PM
vladislavbelov added inline comments to D4920: Fixes overflow of inplace vertex and index buffers.
Feb 1 2023, 8:28 PM
vladislavbelov added inline comments to D4919: Fixes Atlas preview after rP26142.
Feb 1 2023, 8:21 PM

Jan 31 2023

vladislavbelov updated the diff for D4920: Fixes overflow of inplace vertex and index buffers.
Jan 31 2023, 11:37 PM
vladislavbelov added inline comments to D4919: Fixes Atlas preview after rP26142.
Jan 31 2023, 11:36 PM
vladislavbelov requested review of D4920: Fixes overflow of inplace vertex and index buffers.
Jan 31 2023, 11:32 PM
vladislavbelov added inline comments to D4919: Fixes Atlas preview after rP26142.
Jan 31 2023, 10:53 PM
vladislavbelov requested review of D4919: Fixes Atlas preview after rP26142.
Jan 31 2023, 10:02 PM
vladislavbelov committed rP27516: Makes Vulkan device selection stop searching after a first suitable queue….
Makes Vulkan device selection stop searching after a first suitable queue…
Jan 31 2023, 6:02 PM
vladislavbelov added inline comments to D4891: Adds --with-lto premake parameter.
Jan 31 2023, 7:54 AM

Jan 30 2023

vladislavbelov committed rP27512: Fixes DisplayVersion in NSIS on Windows..
Fixes DisplayVersion in NSIS on Windows.
Jan 30 2023, 10:29 PM
vladislavbelov closed D4892: Fixes DisplayVersion in NSIS on Windows.
Jan 30 2023, 10:29 PM
vladislavbelov committed rP27511: Fixes descriptor set overwrite when multiple textures reference it with delayed….
Fixes descriptor set overwrite when multiple textures reference it with delayed…
Jan 30 2023, 10:24 PM
vladislavbelov closed D4916: Fixes descriptor set overwrite when multiple textures reference it with delayed deletion.
Jan 30 2023, 10:23 PM
vladislavbelov added a comment to rP27490: Upgrade gloox to the development trunk version on Windows, refs #3004. This….
In rP27490#60081, @Itms wrote:

so I'm a bit bothered and I'd like opinions. I'd go with the first fix unless you prefer the second one.

I don't mind both of them, but upstream should be done and shouldn't be forgotten.

Jan 30 2023, 10:22 PM
vladislavbelov accepted D4915: ATLAS UI be aware of GUI Scale user config.

It seems ok for Atlas.

Jan 30 2023, 10:20 PM
vladislavbelov committed rP27510: Extends logs for Vulkan available device. .
Extends logs for Vulkan available device.
Jan 30 2023, 10:17 PM
vladislavbelov closed D4917: Extends logs for Vulkan available device.
Jan 30 2023, 10:17 PM
vladislavbelov added a comment to D4917: Extends logs for Vulkan available device.

BTW: did you see the warnings ^ on gcc? I have the same.

Yeah, I need to update VMA.

Jan 30 2023, 10:16 PM
vladislavbelov requested review of D4917: Extends logs for Vulkan available device.
Jan 30 2023, 9:03 PM
vladislavbelov updated the diff for D4916: Fixes descriptor set overwrite when multiple textures reference it with delayed deletion.
Jan 30 2023, 8:12 PM
vladislavbelov added inline comments to D4916: Fixes descriptor set overwrite when multiple textures reference it with delayed deletion.
Jan 30 2023, 8:09 PM
vladislavbelov requested review of D4916: Fixes descriptor set overwrite when multiple textures reference it with delayed deletion.
Jan 30 2023, 9:30 AM
vladislavbelov committed rP27503: Uses Vulkan physical device indices as the last comparison for device selection..
Uses Vulkan physical device indices as the last comparison for device selection.
Jan 30 2023, 12:06 AM

Jan 29 2023

vladislavbelov committed rP27502: Adds more features to report for Vulkan backend..
Adds more features to report for Vulkan backend.
Jan 29 2023, 11:13 PM

Jan 28 2023

vladislavbelov accepted D4900: Crash atlas in relation to Terrain.cpp CalcPosition.

Looks ok for Atlas.

Jan 28 2023, 11:33 PM

Jan 26 2023

vladislavbelov committed rP27496: Prevents using R8G8B8_UNORM format for Vulkan textures as it can be supported….
Prevents using R8G8B8_UNORM format for Vulkan textures as it can be supported…
Jan 26 2023, 10:45 PM
vladislavbelov committed rP27495: Creates image views for Vulkan textures only when needed..
Creates image views for Vulkan textures only when needed.
Jan 26 2023, 10:38 PM
vladislavbelov added a comment to rP27490: Upgrade gloox to the development trunk version on Windows, refs #3004. This….

I got the following warnings when build with --build-shared-glooxwrapper:

libraries\win32\gloox\include\gloox\clientbase.h(769): warning C4373: 'gloox::ClientBase::handlePing': virtual function overrides 'gloox::PingHandler::handlePing', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers
libraries\win32\gloox\include\gloox\pinghandler.h(61): note: see declaration of 'gloox::PingHandler::handlePing'
libraries\win32\gloox\include\gloox\clientbase.h(769): warning C4373: 'gloox::ClientBase::handlePing': virtual function overrides 'gloox::PingHandler::handlePing', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers (compiling source file ..\..\..\source\lobby\StanzaExtensions.cpp)
libraries\win32\gloox\include\gloox\pinghandler.h(61): note: see declaration of 'gloox::PingHandler::handlePing' (compiling source file ..\..\..\source\lobby\StanzaExtensions.cpp)
libraries\win32\gloox\include\gloox\clientbase.h(769): warning C4373: 'gloox::ClientBase::handlePing': virtual function overrides 'gloox::PingHandler::handlePing', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers (compiling source file ..\..\..\source\lobby\scripting\GlooxScriptConversions.cpp)
libraries\win32\gloox\include\gloox\pinghandler.h(61): note: see declaration of 'gloox::PingHandler::handlePing' (compiling source file ..\..\..\source\lobby\scripting\GlooxScriptConversions.cpp)
libraries\win32\gloox\include\gloox\clientbase.h(769): warning C4373: 'gloox::ClientBase::handlePing': virtual function overrides 'gloox::PingHandler::handlePing', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers (compiling source file ..\..\..\source\lobby\XmppClient.cpp)
libraries\win32\gloox\include\gloox\pinghandler.h(61): note: see declaration of 'gloox::PingHandler::handlePing' (compiling source file ..\..\..\source\lobby\XmppClient.cpp)
Jan 26 2023, 10:26 PM
vladislavbelov committed rP27494: Enables non-solid fill for Vulkan to allow wireframe drawing..
Enables non-solid fill for Vulkan to allow wireframe drawing.
Jan 26 2023, 6:24 PM
vladislavbelov committed rP27493: Updates shadows camera frustum after its recalculation..
Updates shadows camera frustum after its recalculation.
Jan 26 2023, 6:13 PM
vladislavbelov committed rP27492: Fixes shadows cascades iteration..
Fixes shadows cascades iteration.
Jan 26 2023, 6:12 PM
vladislavbelov added a comment to D4905: Molten VK Support.
In D4905#209775, @Stan wrote:

Thanks for the detailed reports:

  • Vulkan doesn't support vsync yet.

Vulkan does support vsync, MoltenVK might not.

Jan 26 2023, 9:20 AM

Jan 22 2023

vladislavbelov added inline comments to D4900: Crash atlas in relation to Terrain.cpp CalcPosition.
Jan 22 2023, 12:49 PM
vladislavbelov committed rP27478: Adds a warning in case of Vulkan window creation failure..
Adds a warning in case of Vulkan window creation failure.
Jan 22 2023, 12:14 AM

Jan 21 2023

vladislavbelov committed rP27477: Disables descriptor indexing on macOS..
Disables descriptor indexing on macOS.
Jan 21 2023, 11:53 PM
vladislavbelov committed rP27475: Fixes querying descriptor indexing features and properties on some drivers..
Fixes querying descriptor indexing features and properties on some drivers.
Jan 21 2023, 6:07 PM
vladislavbelov updated the test plan for D4892: Fixes DisplayVersion in NSIS on Windows.
Jan 21 2023, 10:49 AM

Jan 20 2023

vladislavbelov added inline comments to rP27470: Follow proper Shutdown sequence when using -dumpSchema, fixes #6696..
Jan 20 2023, 12:38 PM
vladislavbelov added inline comments to rP27470: Follow proper Shutdown sequence when using -dumpSchema, fixes #6696..
Jan 20 2023, 9:38 AM
vladislavbelov added inline comments to rP27470: Follow proper Shutdown sequence when using -dumpSchema, fixes #6696..
Jan 20 2023, 7:52 AM

Jan 16 2023

vladislavbelov added inline comments to D4870: Extends network profiler to show sampled values as statistics.
Jan 16 2023, 12:41 PM
vladislavbelov committed rP27451: Fixes builds on some platforms for libfmt 4 after rP27329..
Fixes builds on some platforms for libfmt 4 after rP27329.
Jan 16 2023, 7:38 AM
vladislavbelov closed D4890: Fixes builds for libfmt 4 after rP27329.
Jan 16 2023, 7:38 AM