- User Since
- Feb 3 2017, 10:51 PM (140 w, 5 d)
Sun, Oct 6
Fixes @Stan `s notes.
Adds if ( space and moves destructor to header.
Sat, Oct 5
Removes unused variables.
Fixes @elexis `s notes.
Fri, Oct 4
Reverts vector changes.
Fixes @elexis `s note.
Thu, Oct 3
Fixes @elexis`s notes.
Yeah, I can call it TODO, because I want to remove it after new projection type will be added.
Wrong commit message, the right one is "Fixed assert fails in Actor Editor".
@shh thank you for the patch! Sorry for long reviewing.
My result on macOS (clang-11.0.0) for https://code.wildfiregames.com/P184:
Wed, Oct 2
The patch seems ok to me. I'm going to commit that if nobody has objections.
I tested it on VS2015, it works for me. The movement looks ok, the old code has some issues, but it'd be better to fix them in a separate diff.
I didn't talk about underscores, only about name semantic.
I refer to this line: "Then, try to match the style of the other code in the subdirectory you're editing.".
Before your change there were 100 folders with lower case name underscore and 2 with upper case. After your change there are 99 folders with lower case name underscore and 6 with upper case
See my comment above.
Well, before the change we didn't have such name in the folders, but we have tests and scripting. So you broke the rules from CC.
Well its not like I didnt mentioned the folder names or the reasoning several times in the discussion we had http://irclogs.wildfiregames.com/2019-10/2019-10-01-QuakeNet-%230ad-dev.log20:02 < Vladislav> I agree with most, I just can't call it object_base.
It was in context of your patch https://code.wildfiregames.com/P183, and it contains only underscores.
I think Scripting has a wrong case, it's out of repo CC. Object* and SettingTypes are not so "out of rules", but I'd prefer underscore to fit into all other folder names.
I agree that the code should be refactored, but at the same time I want to keep the diff as small as possible (only movement).
Tue, Oct 1
Thu, Sep 26
Also the code doesn't support square maps.
Mon, Sep 23
Fri, Sep 20
Thu, Sep 19
The patch looks good to me. Though I didn't test it.
Wed, Sep 18
Updates after last commits.
Adds template function.
I will commit it in separate commits, grouped by folders.
Sep 16 2019
Sep 3 2019
No, it's fixed. As I created the ticket only for logs.