Page MenuHomeWildfire Games

vladislavbelov (Vladislav Belov)
User

User Details

User Since
Feb 3 2017, 10:51 PM (259 w, 6 d)

Recent Activity

Yesterday

vladislavbelov requested review of D4463: Disables possibility to mix shader types with a single backend.
Thu, Jan 27, 7:56 PM
vladislavbelov committed rP26260: Removes redundant comment about alpha test in shaders forgotten in rP26211..
Removes redundant comment about alpha test in shaders forgotten in rP26211.
Thu, Jan 27, 6:32 PM
vladislavbelov committed rP26259: Moves culling mode and front face state management to DeviceCommandContext..
Moves culling mode and front face state management to DeviceCommandContext.
Thu, Jan 27, 6:26 PM
vladislavbelov closed D4456: Moves culling mode and front face state management to DeviceCommandContext.
Thu, Jan 27, 6:25 PM

Wed, Jan 26

vladislavbelov added a comment to D4455: SetTerrainDirty on CModelAbstract without going through CmpVisualActor.

There is a comment inside GameSetup.cpp:

// Need some stuff for terrain movement costs:
// (TODO: this ought to be independent of any graphics code)
new CTerrainTextureManager;
g_TexMan.LoadTerrainTextures();

Doesn't it contradict to your sentence?:

As a side effect, we don't actually need to inform the simulation when the terrain textures change so don't do that.

Wed, Jan 26, 10:11 AM
vladislavbelov accepted D4454: Move BuildAnimation to CSkeletalAnimMgr / CObjectEntry.

Seems reasonable to me.

Wed, Jan 26, 10:06 AM
vladislavbelov updated the diff for D4456: Moves culling mode and front face state management to DeviceCommandContext.
Wed, Jan 26, 7:15 AM

Tue, Jan 25

vladislavbelov added inline comments to D4458: Add tests from FromFraction.
Tue, Jan 25, 9:27 PM
vladislavbelov added inline comments to D4458: Add tests from FromFraction.
Tue, Jan 25, 9:27 PM
vladislavbelov added inline comments to D4454: Move BuildAnimation to CSkeletalAnimMgr / CObjectEntry.
Tue, Jan 25, 6:48 PM
vladislavbelov added inline comments to rP26249: Remove RENDERDATA_UPDATE_COLOR, which is not used, and cleanup..
Tue, Jan 25, 6:43 PM
vladislavbelov updated the diff for D4456: Moves culling mode and front face state management to DeviceCommandContext.
Tue, Jan 25, 5:30 PM
vladislavbelov committed rP26248: Adds a rasterization state to the renderer backend pipeline state..
Adds a rasterization state to the renderer backend pipeline state.
Tue, Jan 25, 5:29 PM
vladislavbelov updated the diff for D4456: Moves culling mode and front face state management to DeviceCommandContext.
Tue, Jan 25, 7:37 AM

Mon, Jan 24

vladislavbelov requested review of D4456: Moves culling mode and front face state management to DeviceCommandContext.
Mon, Jan 24, 8:34 PM
vladislavbelov added a comment to D4453: Remove RENDERDATA_UPDATE_COLOR following rP24124.

It seems RENDERDATA_UPDATE_COLOR wasn't used even before rP24124.

Mon, Jan 24, 8:06 PM
vladislavbelov added a comment to rP26142: Speedups terrain painting tab in Atlas by asynchronous texture loading..

This may have sped up the loading, but now the previews are very aliased and difficult to use.

Mon, Jan 24, 6:42 PM
vladislavbelov added inline comments to rP26245: UnitMotion pushing improvements.
Mon, Jan 24, 5:46 PM
vladislavbelov committed rP26239: Uses MIPs for terrain textures previews following rP26142..
Uses MIPs for terrain textures previews following rP26142.
Mon, Jan 24, 8:02 AM
vladislavbelov closed D4447: Uses MIPs for terrain textures previews following rP26142.
Mon, Jan 24, 8:01 AM
vladislavbelov updated the diff for D4447: Uses MIPs for terrain textures previews following rP26142.
Mon, Jan 24, 7:12 AM

Sun, Jan 23

wowgetoffyourcellphone awarded D4447: Uses MIPs for terrain textures previews following rP26142 a 100 token.
Sun, Jan 23, 6:12 PM
vladislavbelov requested review of D4447: Uses MIPs for terrain textures previews following rP26142.
Sun, Jan 23, 4:13 PM
vladislavbelov committed rP26237: Removes mem_get_ptr from the Tex::get_data comment forgotten in rP5518..
Removes mem_get_ptr from the Tex::get_data comment forgotten in rP5518.
Sun, Jan 23, 1:00 PM
vladislavbelov updated the summary of D4444: [WIP] Uses triangles for drawing lines in CCanvas2D..
Sun, Jan 23, 12:30 AM

Fri, Jan 21

vladislavbelov requested review of D4444: [WIP] Uses triangles for drawing lines in CCanvas2D..
Fri, Jan 21, 9:17 AM

Thu, Jan 20

vladislavbelov added a comment to rP26215: Splits water surface and shore drawing functions and fixes their switch..

Only seems to happen with this combination of settings.

Thu, Jan 20, 6:33 PM
vladislavbelov committed rP26231: Fixes fancy water shores drawing after rP26215..
Fixes fancy water shores drawing after rP26215.
Thu, Jan 20, 6:32 PM

Wed, Jan 19

vladislavbelov committed rP26229: Fixes minimap texture scissoring rect following rP25997. Fixes #6382.
Fixes minimap texture scissoring rect following rP25997. Fixes #6382
Wed, Jan 19, 6:40 PM
vladislavbelov committed rP26228: Moves blend state management to DeviceCommandContext. Fixes #6420.
Moves blend state management to DeviceCommandContext. Fixes #6420
Wed, Jan 19, 6:31 PM
vladislavbelov closed D4441: Moves blend state management to DeviceCommandContext.
Wed, Jan 19, 6:31 PM
vladislavbelov updated the diff for D4441: Moves blend state management to DeviceCommandContext.
Wed, Jan 19, 11:00 AM
vladislavbelov updated the summary of D4441: Moves blend state management to DeviceCommandContext.
Wed, Jan 19, 10:58 AM
vladislavbelov added a comment to D4441: Moves blend state management to DeviceCommandContext.

Silhouettes work, but they look less transparent than in A25b and are therefore more eye-catching. If the colour for the silhouettes can be made a little more transparent with no extra effort, that's good, otherwise I'll get used to it.

Wed, Jan 19, 10:51 AM
vladislavbelov updated the diff for D4441: Moves blend state management to DeviceCommandContext.

Fixes state changes check.

Wed, Jan 19, 10:51 AM

Tue, Jan 18

vladislavbelov updated the diff for D4441: Moves blend state management to DeviceCommandContext.
Tue, Jan 18, 3:00 PM
vladislavbelov added a comment to D4441: Moves blend state management to DeviceCommandContext.

Apply the patch and compile the game

Ok, worked with the pull0ad function. rP26226 + D4441 (but with diffID 19480)

Make sure the game looks the same for GLSL and ARB

Yes, i think so. Took some screenshots.

Thank you for your testing!

Tue, Jan 18, 1:31 PM
vladislavbelov updated the diff for D4441: Moves blend state management to DeviceCommandContext.
Tue, Jan 18, 8:11 AM
vladislavbelov updated the diff for D4441: Moves blend state management to DeviceCommandContext.
Tue, Jan 18, 7:04 AM

Mon, Jan 17

vladislavbelov updated subscribers of D4441: Moves blend state management to DeviceCommandContext.

@nwtour and @Langbart could you test performance with this patch?

Mon, Jan 17, 8:49 PM
vladislavbelov requested review of D4441: Moves blend state management to DeviceCommandContext.
Mon, Jan 17, 8:31 PM
vladislavbelov added a comment to rP26215: Splits water surface and shore drawing functions and fixes their switch..

Only seems to happen with this combination of settings.

Mon, Jan 17, 7:39 PM

Sat, Jan 15

vladislavbelov requested verification of rP26215: Splits water surface and shore drawing functions and fixes their switch..

Fixed in rP26223.

Sat, Jan 15, 5:48 PM
vladislavbelov committed rP26223: Removes binding additional attribute for water shader added in rP26215..
Removes binding additional attribute for water shader added in rP26215.
Sat, Jan 15, 5:47 PM
vladislavbelov added inline comments to rP26217: Moves hardcoded blend state in ParticleRenderer to the transparent particles….
Sat, Jan 15, 5:36 PM
vladislavbelov committed rP26222: Removes unused variable in ParticleRenderer after rP26217..
Removes unused variable in ParticleRenderer after rP26217.
Sat, Jan 15, 5:29 PM

Fri, Jan 14

vladislavbelov committed rP26218: Moves hardcoded blend state in debug overlay and water to their techniques..
Moves hardcoded blend state in debug overlay and water to their techniques.
Fri, Jan 14, 7:44 PM
vladislavbelov committed rP26217: Moves hardcoded blend state in ParticleRenderer to the transparent particles….
Moves hardcoded blend state in ParticleRenderer to the transparent particles…
Fri, Jan 14, 7:18 PM
vladislavbelov committed rP26216: Moves hardcoded blend state in CCanvas2D to its technique..
Moves hardcoded blend state in CCanvas2D to its technique.
Fri, Jan 14, 6:44 PM
vladislavbelov committed rP26215: Splits water surface and shore drawing functions and fixes their switch..
Splits water surface and shore drawing functions and fixes their switch.
Fri, Jan 14, 6:35 PM
vladislavbelov closed D4436: Splits water surface and shore drawing functions and fixes their switch.
Fri, Jan 14, 6:35 PM
vladislavbelov requested review of D4436: Splits water surface and shore drawing functions and fixes their switch.
Fri, Jan 14, 1:22 PM
vladislavbelov committed rP26213: Draws slider button only inside its element..
Draws slider button only inside its element.
Fri, Jan 14, 7:51 AM
vladislavbelov closed D4435: Draws slider button only inside its element.
Fri, Jan 14, 7:50 AM

Thu, Jan 13

vladislavbelov requested review of D4435: Draws slider button only inside its element.
Thu, Jan 13, 10:38 PM
vladislavbelov committed rP26211: Removes deprecated GL alpha test..
Removes deprecated GL alpha test.
Thu, Jan 13, 6:50 PM
vladislavbelov closed D4434: Removes deprecated alpha test.
Thu, Jan 13, 6:50 PM
vladislavbelov updated the diff for D4434: Removes deprecated alpha test.

Removes material usages.

Thu, Jan 13, 5:24 PM
vladislavbelov updated the diff for D4434: Removes deprecated alpha test.
Thu, Jan 13, 2:23 PM
vladislavbelov added inline comments to D4434: Removes deprecated alpha test.
Thu, Jan 13, 2:23 PM
vladislavbelov requested review of D4434: Removes deprecated alpha test.
Thu, Jan 13, 11:36 AM

Wed, Jan 12

vladislavbelov accepted D4420: Write an ARB equivalent for los_interp.

Seems to work.

Wed, Jan 12, 7:58 PM

Tue, Jan 11

vladislavbelov added inline comments to D4318: Fix timeout confirmation box.
Tue, Jan 11, 5:47 PM
vladislavbelov committed rP26201: Removes unused method from CShaderTechnique..
Removes unused method from CShaderTechnique.
Tue, Jan 11, 5:02 PM
vladislavbelov committed rP26199: Removes direct shader binding, uses BeginPass always following rP26020..
Removes direct shader binding, uses BeginPass always following rP26020.
Tue, Jan 11, 6:57 AM
vladislavbelov closed D4431: Removes direct shader binding, uses BeginPass always following rP26020.
Tue, Jan 11, 6:56 AM

Mon, Jan 10

vladislavbelov requested review of D4431: Removes direct shader binding, uses BeginPass always following rP26020.
Mon, Jan 10, 7:53 PM
vladislavbelov committed rP26197: Fixes comments of CLOSTexture and CTerritoryTexture following rP26107..
Fixes comments of CLOSTexture and CTerritoryTexture following rP26107.
Mon, Jan 10, 6:59 PM
vladislavbelov added inline comments to D4420: Write an ARB equivalent for los_interp.
Mon, Jan 10, 6:29 PM
vladislavbelov committed rP26196: Uses CVertexBufferManager handle instead of raw VBChunk pointer management..
Uses CVertexBufferManager handle instead of raw VBChunk pointer management.
Mon, Jan 10, 5:51 PM
vladislavbelov closed D4430: Uses CVertexBufferManager handle instead of raw VBChunk pointer management.
Mon, Jan 10, 5:51 PM
vladislavbelov updated the diff for D4430: Uses CVertexBufferManager handle instead of raw VBChunk pointer management.
Mon, Jan 10, 7:40 AM
vladislavbelov added inline comments to D4430: Uses CVertexBufferManager handle instead of raw VBChunk pointer management.
Mon, Jan 10, 7:27 AM

Sun, Jan 9

vladislavbelov requested review of D4430: Uses CVertexBufferManager handle instead of raw VBChunk pointer management.
Sun, Jan 9, 10:48 PM
vladislavbelov added a comment to D4425: Use the threadpool for texture conversion.

Mh, you're skipping over the bit where it won't stuck :P . Either the tasks will be cancelled before they're started, and the the main thread will compute paths, or they'll actually be started, so they won't hang on texture conversion.

Sun, Jan 9, 10:04 AM
vladislavbelov added a comment to D4425: Use the threadpool for texture conversion.

I believe the simulation (pathfinder anyways) ends up running computations on the main thread anyways right now, so it wouldn't get stuck.

It's written so that it will stuck.

Sun, Jan 9, 9:31 AM
vladislavbelov added a comment to D4425: Use the threadpool for texture conversion.

Also it seems that converting many textures may stuck the game, particularly simulation. If threads are overused by the converter.

Sun, Jan 9, 8:52 AM
vladislavbelov added a comment to D4423: A try to replace glDrawRangeElements by glDrawElements.

So in principle there should be no performance changes

It depends on implementation, it uses glDrawRangeElements with max numbers. In some particular implementation driver might prefetch data for caches according to the range, especially if it sees that the range is continuous.

Sun, Jan 9, 8:50 AM
vladislavbelov added inline comments to D4425: Use the threadpool for texture conversion.
Sun, Jan 9, 8:48 AM
vladislavbelov committed rP26193: Removes asking GL of current bind framebuffer to avoid syncs..
Removes asking GL of current bind framebuffer to avoid syncs.
Sun, Jan 9, 8:37 AM
vladislavbelov closed D4422: Removes asking current bind framebuffer to avoid syncs.
Sun, Jan 9, 8:37 AM

Sat, Jan 8

vladislavbelov requested review of D4423: A try to replace glDrawRangeElements by glDrawElements.
Sat, Jan 8, 3:41 PM
vladislavbelov added a comment to rP26157: Remove topology.cpp. The data isn't useful to us, and it prevents some players….

There are forgotten dependencies.

Sat, Jan 8, 3:09 PM
vladislavbelov committed rP26189: Removes redundant layer check added in rP26185..
Removes redundant layer check added in rP26185.
Sat, Jan 8, 2:45 PM
vladislavbelov added inline comments to rP26185: Uploads cube textures in SkyManager via DeviceCommandContext..
Sat, Jan 8, 9:56 AM
vladislavbelov added a comment to rP26185: Uploads cube textures in SkyManager via DeviceCommandContext..
DeviceCommandContext.cpp
In file included from ../../../source/lib/precompiled.h:74,
                 from ../../../source/pch/graphics/precompiled.h:18,
                 from ../../../source/renderer/backend/gl/DeviceCommandContext.cpp:18:
../../../source/renderer/backend/gl/DeviceCommandContext.cpp: In member function ‘void Renderer::Backend::GL::CDeviceCommandContext::UploadTextureRegion(Renderer::Backend::GL::CTexture*, Renderer::Backend::Format, const void*, size_t, uint32_t, uint32_t, uint32_t, uint32_t, uint32_t, uint32_t)’:
../../../source/renderer/backend/gl/DeviceCommandContext.cpp:89:48: warning: comparison of unsigned expression in ‘>= 0’ is always true [-Wtype-limits]
   89 |                         ENSURE(level == 0 && 0 <= layer && layer < 6);
      |                                              ~~^~~~~~~~
../../../source/lib/debug.h:295:22: note: in definition of macro ‘ENSURE’
  295 |                 if(!(expr))\
      |                      ^~~~

(This might have been here before.)

Sat, Jan 8, 9:53 AM
vladislavbelov requested review of D4422: Removes asking current bind framebuffer to avoid syncs.
Sat, Jan 8, 12:32 AM

Fri, Jan 7

vladislavbelov committed rP26187: Moves default GL state setup to GL device..
Moves default GL state setup to GL device.
Fri, Jan 7, 11:21 PM
vladislavbelov committed rP26186: Fixes rendering big screenshot pieces onto screen, refs rP2994..
Fixes rendering big screenshot pieces onto screen, refs rP2994.
Fri, Jan 7, 9:16 PM
vladislavbelov committed rP26185: Uploads cube textures in SkyManager via DeviceCommandContext..
Uploads cube textures in SkyManager via DeviceCommandContext.
Fri, Jan 7, 9:01 PM
vladislavbelov closed D4421: Uploads cube textures in SkyManager via DeviceCommandContext.
Fri, Jan 7, 9:01 PM
vladislavbelov updated the diff for D4421: Uploads cube textures in SkyManager via DeviceCommandContext.

Fixes notes.

Fri, Jan 7, 6:01 PM
vladislavbelov added inline comments to D4421: Uploads cube textures in SkyManager via DeviceCommandContext.
Fri, Jan 7, 6:00 PM
vladislavbelov requested review of D4421: Uploads cube textures in SkyManager via DeviceCommandContext.
Fri, Jan 7, 5:53 PM
vladislavbelov committed rP26184: Separates terrain alphamap combining and uploading..
Separates terrain alphamap combining and uploading.
Fri, Jan 7, 3:34 PM
vladislavbelov closed D4419: Separates terrain alphamap combining and uploading.
Fri, Jan 7, 3:34 PM
vladislavbelov updated the diff for D4419: Separates terrain alphamap combining and uploading.
Fri, Jan 7, 12:10 PM
vladislavbelov added inline comments to D4419: Separates terrain alphamap combining and uploading.
Fri, Jan 7, 12:10 PM
vladislavbelov requested review of D4419: Separates terrain alphamap combining and uploading.
Fri, Jan 7, 3:15 AM
vladislavbelov added inline comments to rP26181: Removes ogl_tex usage from CRenderer..
Fri, Jan 7, 1:04 AM