Page MenuHomeWildfire Games

vladislavbelov (Vladislav Belov)
User

User Details

User Since
Feb 3 2017, 10:51 PM (211 w, 5 d)

Recent Activity

Fri, Feb 19

vladislavbelov requested verification of rP22037: Add an error message for crashes without required UV sets..
Fri, Feb 19, 9:10 AM

Thu, Feb 18

vladislavbelov requested verification of rP24870: Switches decals to VBChunk to reduce the number of state changes..
Thu, Feb 18, 10:11 PM
vladislavbelov added a comment to rP24932: Do not generate render data in case CDecal calculated wrong coordinates..

Fixes #6034.

Thu, Feb 18, 10:10 PM
vladislavbelov committed rP24932: Do not generate render data in case CDecal calculated wrong coordinates..
Do not generate render data in case CDecal calculated wrong coordinates.
Thu, Feb 18, 10:10 PM
vladislavbelov closed D3578: Do not generate render data in case Decal calculated wrong coordinates.
Thu, Feb 18, 10:10 PM

Wed, Feb 17

vladislavbelov requested review of D3578: Do not generate render data in case Decal calculated wrong coordinates.
Wed, Feb 17, 11:30 PM
vladislavbelov added inline comments to rP24870: Switches decals to VBChunk to reduce the number of state changes..
Wed, Feb 17, 10:31 PM

Sun, Feb 14

vladislavbelov added a comment to rP24922: Fixes config crash in case of an empty value.

Fixes rP24618.

Sun, Feb 14, 12:50 PM
vladislavbelov requested review of D3567: Fixes config crash in case of an empty value.
Sun, Feb 14, 3:08 AM
vladislavbelov committed rP24915: Refactors smart pointers creation, reduces code duplication and improves….
Refactors smart pointers creation, reduces code duplication and improves…
Sun, Feb 14, 12:54 AM
vladislavbelov committed rP24905: Fixes UB in shared_ptr usage of an array. Refs #5288.
Fixes UB in shared_ptr usage of an array. Refs #5288
Sun, Feb 14, 12:26 AM

Sat, Feb 13

vladislavbelov added inline comments to rP22666: pthread -> std::thread (4/7) - Replace pthread in remaining files.
Sat, Feb 13, 7:47 PM
vladislavbelov committed rP24903: Fixes leaking of a file handle in case of an error. Refs #5288.
Fixes leaking of a file handle in case of an error. Refs #5288
Sat, Feb 13, 6:58 PM
vladislavbelov committed rP24899: Makes DynamicArena more cache-friendly and removes useless member..
Makes DynamicArena more cache-friendly and removes useless member.
Sat, Feb 13, 6:33 PM
vladislavbelov closed D3560: Makes DynamicArena more cache-friendly and removes useless member.
Sat, Feb 13, 6:33 PM
vladislavbelov retitled D3560: Makes DynamicArena more cache-friendly and removes useless member from Makes DynamicArena more cache-friendly to Makes DynamicArena more cache-friendly and removes useless member.
Sat, Feb 13, 6:32 PM
vladislavbelov retitled D3560: Makes DynamicArena more cache-friendly and removes useless member from Makes DynamicArena more cache-friendly and removes expensive memset to Makes DynamicArena more cache-friendly.
Sat, Feb 13, 6:32 PM
vladislavbelov requested review of D3560: Makes DynamicArena more cache-friendly and removes useless member.
Sat, Feb 13, 3:17 AM

Fri, Feb 12

vladislavbelov committed rP24891: Fixes big screenshots with water (reflection or refraction camera), adds big….
Fixes big screenshots with water (reflection or refraction camera), adds big…
Fri, Feb 12, 10:20 PM
vladislavbelov closed D3557: Fixes big screenshots with water.
Fri, Feb 12, 10:20 PM
vladislavbelov added inline comments to D3557: Fixes big screenshots with water.
Fri, Feb 12, 8:44 PM
vladislavbelov added inline comments to D3557: Fixes big screenshots with water.
Fri, Feb 12, 10:50 AM
vladislavbelov added inline comments to D3557: Fixes big screenshots with water.
Fri, Feb 12, 9:50 AM
vladislavbelov requested review of D3557: Fixes big screenshots with water.
Fri, Feb 12, 12:07 AM

Thu, Feb 11

vladislavbelov raised a concern with rP22136: Baobab age variants, Bamboos and banyans.

banyan_leaves_1.png - bad texture, contains only white in the transparent area, the same for banyan_trunk_1.png. Normals are too sharp for leaves.

Thu, Feb 11, 8:51 PM
vladislavbelov committed rP24885: Reduces the number of GL state changes in GUI..
Reduces the number of GL state changes in GUI.
Thu, Feb 11, 8:15 PM
vladislavbelov committed rP24870: Switches decals to VBChunk to reduce the number of state changes..
Switches decals to VBChunk to reduce the number of state changes.
Thu, Feb 11, 12:49 AM
vladislavbelov closed D3553: Switches decals to VBChunk to make it using compressed vertices in future.
Thu, Feb 11, 12:49 AM
vladislavbelov retitled D3553: Switches decals to VBChunk to make it using compressed vertices in future from [WIP] Switches decals to VBChunk to make it using compressed vertices in future to Switches decals to VBChunk to make it using compressed vertices in future.
Thu, Feb 11, 12:09 AM
vladislavbelov updated the diff for D3553: Switches decals to VBChunk to make it using compressed vertices in future.
Thu, Feb 11, 12:09 AM

Wed, Feb 10

vladislavbelov added a comment to D3553: Switches decals to VBChunk to make it using compressed vertices in future.
In D3553#155603, @Stan wrote:

WIP means for A25?

Wed, Feb 10, 9:45 PM
vladislavbelov requested review of D3553: Switches decals to VBChunk to make it using compressed vertices in future.
Wed, Feb 10, 8:05 PM
vladislavbelov committed rP24867: Batches decals and reduces the number of state changes..
Batches decals and reduces the number of state changes.
Wed, Feb 10, 5:43 PM
vladislavbelov closed D3545: Batches decals and reduces the number of state changes.
Wed, Feb 10, 5:43 PM

Tue, Feb 9

vladislavbelov added a comment to D3545: Batches decals and reduces the number of state changes.

I think you should also sort by texture & make sure we don't bind un-needed textures (it appears we do).

I definitely agree, but I want to make it in a separate patch to test some unrelated ideas and compare performance.

Tue, Feb 9, 10:06 AM
vladislavbelov requested review of D3545: Batches decals and reduces the number of state changes.
Tue, Feb 9, 12:50 AM

Mon, Feb 8

vladislavbelov committed rP24861: Changes CVertexBufferManager container from std::list to std::vector..
Changes CVertexBufferManager container from std::list to std::vector.
Mon, Feb 8, 11:38 PM
vladislavbelov committed rP24860: Separates allocated vertex buffers into groups for data locality..
Separates allocated vertex buffers into groups for data locality.
Mon, Feb 8, 11:34 PM
vladislavbelov closed D3522: Separates allocated vertex buffers into groups.
Mon, Feb 8, 11:34 PM
vladislavbelov added a comment to D3475: General improvements to 0ad.desktop.

The patch seems useful. How it would behave for versions not supporting PrefersNonDefaultGPU?

Mon, Feb 8, 4:28 PM
vladislavbelov added inline comments to D3522: Separates allocated vertex buffers into groups.
Mon, Feb 8, 4:21 PM
vladislavbelov added inline comments to D3522: Separates allocated vertex buffers into groups.
Mon, Feb 8, 8:26 AM

Sun, Feb 7

vladislavbelov updated the diff for D3522: Separates allocated vertex buffers into groups.
Sun, Feb 7, 5:00 PM
vladislavbelov added inline comments to D1751: [WIP] Map flares.
Sun, Feb 7, 12:53 AM

Sat, Feb 6

vladislavbelov accepted rP24727: Commit the actual images for r24726.
Sat, Feb 6, 12:56 AM
vladislavbelov added a comment to D3522: Separates allocated vertex buffers into groups.
In D3522#154836, @Stan wrote:

Why was the separation between TERRAIN and TERRAIN_BLEND removed?

Sat, Feb 6, 12:48 AM
vladislavbelov updated the diff for D3522: Separates allocated vertex buffers into groups.

Increases buffer density.

Sat, Feb 6, 12:27 AM

Fri, Feb 5

vladislavbelov added a comment to D3522: Separates allocated vertex buffers into groups.

I can't notice a performance improvement. But I only checked the profiler2.


red vanilla, green patched

Fri, Feb 5, 9:35 PM
vladislavbelov requested review of D3522: Separates allocated vertex buffers into groups.
Fri, Feb 5, 6:08 PM
vladislavbelov added a comment to D3521: Rename ModelAbstract to SceneObject and clean up interfaces a bit..

"SceneObject" doesn't usually mean renderable object, it might a script, a group or a sound. Also owning CSceneObject by CUnit looks like a more detailed object owns a more abstract object.

Fri, Feb 5, 12:25 PM
vladislavbelov committed rP24835: Further VertexBuffer improvements after rP24834..
Further VertexBuffer improvements after rP24834.
Fri, Feb 5, 12:48 AM
vladislavbelov added a comment to D2528: Performance improvements to VertexBuffer.

@dm thank you for the patch!

Fri, Feb 5, 12:30 AM
vladislavbelov committed rP24834: Performance improvements to VertexBuffer..
Performance improvements to VertexBuffer.
Fri, Feb 5, 12:27 AM
vladislavbelov closed D2528: Performance improvements to VertexBuffer.
Fri, Feb 5, 12:26 AM
vladislavbelov added inline comments to D2528: Performance improvements to VertexBuffer.
Fri, Feb 5, 12:15 AM

Thu, Feb 4

vladislavbelov committed rP24833: Removes redundant normalizations for float types..
Removes redundant normalizations for float types.
Thu, Feb 4, 9:03 PM
vladislavbelov closed D3517: Removes redundant normalizations for float types.
Thu, Feb 4, 9:03 PM
vladislavbelov requested review of D3517: Removes redundant normalizations for float types.
Thu, Feb 4, 3:18 AM
vladislavbelov committed rP24828: Removes unused dummy shader from decals rendering..
Removes unused dummy shader from decals rendering.
Thu, Feb 4, 1:01 AM

Wed, Feb 3

vladislavbelov raised a concern with rP24727: Commit the actual images for r24726.

partial_mask.png has a size not power of two.

Wed, Feb 3, 7:17 PM
vladislavbelov committed rP24827: Fixes building snapping for non-square foundations. Fixes #5976.
Fixes building snapping for non-square foundations. Fixes #5976
Wed, Feb 3, 6:04 PM
vladislavbelov closed D3510: Fixes building snapping for non-square foundations.
Wed, Feb 3, 6:03 PM
vladislavbelov committed rP24826: Significantly reduces number of OpenGL state changes for terrain rendering..
Significantly reduces number of OpenGL state changes for terrain rendering.
Wed, Feb 3, 6:02 PM
vladislavbelov closed D3512: Significantly reduces number of OpenGL state changes for terrain rendering.
Wed, Feb 3, 6:02 PM

Tue, Feb 2

vladislavbelov requested review of D3512: Significantly reduces number of OpenGL state changes for terrain rendering.
Tue, Feb 2, 6:31 PM
vladislavbelov committed rP24822: Removes unused dummy shader from terrain rendering..
Removes unused dummy shader from terrain rendering.
Tue, Feb 2, 4:35 PM
vladislavbelov requested review of D3510: Fixes building snapping for non-square foundations.
Tue, Feb 2, 3:22 AM

Mon, Feb 1

vladislavbelov committed rP24815: Stops parsing a shader if an include has an error..
Stops parsing a shader if an include has an error.
Mon, Feb 1, 3:12 PM
vladislavbelov committed rP24814: Adds logging of a shader name on an error after reload..
Adds logging of a shader name on an error after reload.
Mon, Feb 1, 2:50 PM
vladislavbelov closed D3462: Adds error shader name logging on reload.
Mon, Feb 1, 2:50 PM
vladislavbelov added a comment to D3507: Trailer hacks [not for commit].
In D3507#154343, @Stan wrote:

we just take a awful lot of screenshots and make sure we have 60 image per second of game.

That's called video stream. Just saving it to files.

Mon, Feb 1, 1:22 PM

Fri, Jan 29

vladislavbelov added a comment to D3386: Move DevOverlay down a bit to not hide 'exit'.

Why not to make the Z for dev higher? It seems the same functionality as the console. So it might include a functionality to work with popups.

Fri, Jan 29, 2:41 PM
vladislavbelov added a comment to D3494: Fix Z-fight in the menu.

It does indeed. I think D3386 was the proper fix in the first place, then.

Fri, Jan 29, 2:36 PM
vladislavbelov added a comment to D3494: Fix Z-fight in the menu.

Does it work with popups? Like chats, charts, messages, tutorials (other popup-like pages)?

Fri, Jan 29, 12:59 PM

Thu, Jan 28

vladislavbelov raised a concern with rP24667: Make the in-game menu go over the dev overlay..

Now menu goes over the menu button. That triggers tooltip blinking and a not really good text intersection.

Thu, Jan 28, 5:23 PM

Jan 24 2021

vladislavbelov requested review of D3462: Adds error shader name logging on reload.
Jan 24 2021, 3:08 AM

Jan 23 2021

vladislavbelov committed rP24777: Reduces shadow biases for landscape shaders..
Reduces shadow biases for landscape shaders.
Jan 23 2021, 8:41 PM
vladislavbelov closed D3457: Removes shadow bias for landscape shader.
Jan 23 2021, 8:41 PM
vladislavbelov updated the test plan for D3457: Removes shadow bias for landscape shader.
Jan 23 2021, 2:08 PM
vladislavbelov added inline comments to D3457: Removes shadow bias for landscape shader.
Jan 23 2021, 2:07 PM
vladislavbelov added inline comments to D3457: Removes shadow bias for landscape shader.
Jan 23 2021, 2:04 PM
vladislavbelov requested review of D3457: Removes shadow bias for landscape shader.
Jan 23 2021, 1:57 PM

Jan 22 2021

vladislavbelov committed rP24768: Allows to override GL version for SDL..
Allows to override GL version for SDL.
Jan 22 2021, 8:40 PM
vladislavbelov closed D3448: Allows to override GL version for SDL.
Jan 22 2021, 8:40 PM

Jan 21 2021

vladislavbelov requested review of D3448: Allows to override GL version for SDL.
Jan 21 2021, 11:51 PM
vladislavbelov committed rP24756: Removes useless transparent pass before the water for lowest settings since the….
Removes useless transparent pass before the water for lowest settings since the…
Jan 21 2021, 11:38 PM
vladislavbelov requested verification of rP24732: Removes shader code duplication to calculate LOS..
Jan 21 2021, 12:36 PM
vladislavbelov committed rP24746: Fixes simple ARB water after rP24732. Completely removing losMatrix usages..
Fixes simple ARB water after rP24732. Completely removing losMatrix usages.
Jan 21 2021, 12:35 PM
vladislavbelov added a comment to rP24740: Optimization for include resolving in PreprocessorWrapper..

Thanks for looking a quick look at my fixing diff.

Jan 21 2021, 12:07 PM
vladislavbelov requested verification of rP24740: Optimization for include resolving in PreprocessorWrapper..
Jan 21 2021, 10:12 AM
vladislavbelov added a comment to rP24740: Optimization for include resolving in PreprocessorWrapper..

I believe the problem is that string_view is a pointer, and the pointers get invalidated at some point.

Yep.

Jan 21 2021, 10:11 AM
vladislavbelov added inline comments to D3441: Fix rP24740 issue revealed by mac tests.
Jan 21 2021, 9:33 AM
vladislavbelov accepted D3441: Fix rP24740 issue revealed by mac tests.
Jan 21 2021, 9:33 AM
vladislavbelov published D3441: Fix rP24740 issue revealed by mac tests for review.
Jan 21 2021, 9:33 AM
vladislavbelov committed rP24740: Optimization for include resolving in PreprocessorWrapper..
Optimization for include resolving in PreprocessorWrapper.
Jan 21 2021, 12:05 AM
vladislavbelov closed D3439: Optimization for include resolving.
Jan 21 2021, 12:05 AM

Jan 20 2021

vladislavbelov added inline comments to D3439: Optimization for include resolving.
Jan 20 2021, 11:59 PM
vladislavbelov requested review of D3439: Optimization for include resolving.
Jan 20 2021, 11:39 PM
vladislavbelov committed rP24739: Refactors water_high shader, cleanups water changes after rP24732..
Refactors water_high shader, cleanups water changes after rP24732.
Jan 20 2021, 11:36 PM
vladislavbelov committed rP24732: Removes shader code duplication to calculate LOS..
Removes shader code duplication to calculate LOS.
Jan 20 2021, 7:46 PM