Page MenuHomeWildfire Games

vladislavbelov (Vladislav Belov)
User

User Details

User Since
Feb 3 2017, 10:51 PM (106 w, 4 d)

Recent Activity

Sun, Feb 17

vladislavbelov added a comment to D1698: Various compilation fixes for different compilers.
In D1698#72244, @Stan wrote:

It's still using the 2017 toolset so yes.

Sun, Feb 17, 9:16 PM
vladislavbelov added a comment to D1745: Allow loading Icons at runtime.
In D1745#72226, @elexis wrote:

So you're asking for AddIcons instead of AddIcon.

Actually no, though AddIcons is better than AddIcon. I think these functions are dangerous currently.

Sun, Feb 17, 9:13 PM
vladislavbelov added a comment to D1698: Various compilation fixes for different compilers.
In D1698#72240, @Stan wrote:

the goal is to drop support eventually and move on to 2015 2017

It's true, but we didn't drop it yet.

Sun, Feb 17, 3:36 PM
vladislavbelov added a comment to D1698: Various compilation fixes for different compilers.
In D1698#72235, @Stan wrote:

Errors for debug build are here https://trac.wildfiregames.com/ticket/4460

Ok, it should be linked then (I added).

Sun, Feb 17, 1:29 PM
vladislavbelov updated the Trac tickets for D1698: Various compilation fixes for different compilers.
Sun, Feb 17, 1:28 PM
vladislavbelov added a comment to D1698: Various compilation fixes for different compilers.
In D1698#72233, @Stan wrote:

Updating Fcollada is not that important. Nevertheless though our debug build is broken on windows because of it and the game doesn't work with Fcollada compiled with vs2015 instant default.

So I thought we might as well take all the fixes from the other forks over the internet.

Sun, Feb 17, 12:00 PM
vladislavbelov added a comment to D1698: Various compilation fixes for different compilers.

Do we have to update our fcollada? Especially if it has useful changes.

Sun, Feb 17, 11:37 AM

Sat, Feb 16

vladislavbelov added a comment to D1745: Allow loading Icons at runtime.
In D1745#72176, @elexis wrote:

So the numbers show us that displaying 250 new textures means that 250 more textures are processed, but that's not surprising, is it?

Of course.

Sat, Feb 16, 10:52 PM
vladislavbelov added inline comments to D1752: Add GUI events for middle mouse click.
Sat, Feb 16, 6:27 PM
vladislavbelov requested changes to D1751: [WIP] Map ping.

Currently few of my comments should be fixed anyway, so I add a "Request changes". But also I want to discuss about a method to pass the ping event to the C++.

Sat, Feb 16, 6:21 PM
vladislavbelov added a comment to D1756: #loadingordermatters.

What's about wraitii suggestion:

If not, I would recommend passing an enum VFS::SORTED or something instead of true or false since C++ doesn't have named arguments

It makes sense to use a name. It'd be easier to read such code.

Sat, Feb 16, 6:11 PM
vladislavbelov added inline comments to D1622: [CSlider] On click move the slider-button to the mouse position.
Sat, Feb 16, 5:53 PM
vladislavbelov added a comment to D1586: Allow mod packagers to not bundle XML files.

As we discussed XML is a pretty specific case and it may have some problems. But I can suggest to add a more common parameter, like an ignore mask. Example:

... --ignore-mask="*test.js|*.xmb"

But it also requires a motivation.

Sat, Feb 16, 5:38 PM
vladislavbelov added inline comments to D1584: Seed random sounds.
Sat, Feb 16, 5:29 PM
vladislavbelov added a comment to D1581: Mod Interface: Enable setting territory visibility.

I would ask you add a context to your patch.

Sat, Feb 16, 5:25 PM
vladislavbelov requested changes to D1584: Seed random sounds.
Sat, Feb 16, 5:19 PM
vladislavbelov requested changes to D1491: Const-Correct the long range pathfinder.

The patch looks good for me. It only needs to fix some details.

Sat, Feb 16, 5:06 PM
vladislavbelov added a comment to D1745: Allow loading Icons at runtime.
In D1745#70233, @elexis wrote:

I get the impression that you two didn't read the patch and spent maybe 2 minutes on your reply.

I disagree with that.

Sat, Feb 16, 4:21 PM

Mon, Jan 28

vladislavbelov added inline comments to D1756: #loadingordermatters.
Mon, Jan 28, 8:10 PM

Fri, Jan 25

vladislavbelov added a comment to D1763: Removes duplication of Clamp function.
In D1763#71069, @smiley wrote:

(Re: ssize_t to size_t
I thought that this was discouraged since it can introduce subtle bugs.
Google's C++ style guide also mentions something like this)

Fri, Jan 25, 9:29 PM
vladislavbelov added inline comments to D1763: Removes duplication of Clamp function.
Fri, Jan 25, 8:43 PM
vladislavbelov updated the diff for D1763: Removes duplication of Clamp function.

Fixes elexis and another other another Stan notes.

Fri, Jan 25, 8:43 PM

Thu, Jan 24

vladislavbelov updated the diff for D1763: Removes duplication of Clamp function.

Fixes other another Stan notes.

Thu, Jan 24, 11:49 PM
vladislavbelov added inline comments to D1763: Removes duplication of Clamp function.
Thu, Jan 24, 11:39 PM
vladislavbelov updated the diff for D1763: Removes duplication of Clamp function.

Fixes another Stan notes.

Thu, Jan 24, 11:38 PM
vladislavbelov updated the diff for D1763: Removes duplication of Clamp function.

Fixes Stan notes.

Thu, Jan 24, 11:02 PM
vladislavbelov added a comment to D1763: Removes duplication of Clamp function.
In D1763#70987, @Stan wrote:

Which of the two implementation was the fastest ? :)

Thu, Jan 24, 10:23 PM
vladislavbelov created D1763: Removes duplication of Clamp function.
Thu, Jan 24, 9:52 PM
vladislavbelov added a comment to D1717: Fix Olist text wrapping.

@gentz thank you for the patch!

Thu, Jan 24, 9:06 PM
vladislavbelov committed rP22066: Fix cell text wrapping inside COList..
Fix cell text wrapping inside COList.
Thu, Jan 24, 9:01 PM
vladislavbelov closed D1717: Fix Olist text wrapping.
Thu, Jan 24, 9:01 PM
vladislavbelov accepted D1717: Fix Olist text wrapping.

I tested the patch, it works and looks good for me. In any case it's the improvement. If someone wants a more flexible header, the one can create a ticket or ask for a patch.

Thu, Jan 24, 8:54 PM

Tue, Jan 22

vladislavbelov added a comment to D1746: Network Dialog / Troll removal device.
In D1746#70770, @elexis wrote:

ctrl+f currentness.

Which word or sentence?

Tue, Jan 22, 4:37 PM
vladislavbelov added a comment to D1746: Network Dialog / Troll removal device.
In D1746#70762, @elexis wrote:

If 1/5 of the things I post in a revision proposal are repetitions of something that I already repeated about 3 or 4 times and still not being understood, that's pretty strange for me. Perhaps I misphrased something?

1/5 of RAM.

Tue, Jan 22, 2:27 PM

Mon, Jan 21

vladislavbelov added inline comments to D1746: Network Dialog / Troll removal device.
Mon, Jan 21, 10:25 PM
vladislavbelov added inline comments to D1676: Embed zpl-c's version of enet library.
Mon, Jan 21, 10:18 PM
vladislavbelov added a comment to D1746: Network Dialog / Troll removal device.
In D1746#70734, @Stan wrote:

If you significantly increase the size of the bundle like by 500MB to add that file, we will have to find workarounds for the windows installer as it has a size limit (IIRC 2GB) bigger than that it cannot handle. This is I believe one of the reason we don't have the Asian Fonts as part of the main bundle.

If 1/5 of the game is one file that will be outdated each next month and that used only for a small feature, it's pretty strange for me.

Mon, Jan 21, 9:06 PM
vladislavbelov added a comment to D1676: Embed zpl-c's version of enet library.
In D1676#70736, @Stan wrote:

Could you guys have a look at this. It's starting to be a really wanted feature.

Mon, Jan 21, 9:02 PM

Jan 20 2019

vladislavbelov added a comment to D1756: #loadingordermatters.

How many elements are sorted for a worst case?

Jan 20 2019, 8:20 PM
vladislavbelov added inline comments to D1573: Adds callbacks to the CConfigDB.
Jan 20 2019, 3:44 PM
vladislavbelov added a comment to D1573: Adds callbacks to the CConfigDB.
In D1573#66460, @elexis wrote:

And we don't know, was it really initialised.

Shouldn't there also be a callback function on failure then, used when globals are initialized by a config value?

Yes, it could be. If it's needed for someone.

Jan 20 2019, 2:42 PM
vladislavbelov updated the summary of D1573: Adds callbacks to the CConfigDB.
Jan 20 2019, 2:37 PM
vladislavbelov updated the diff for D1573: Adds callbacks to the CConfigDB.

Fix notes.

Jan 20 2019, 2:37 PM
vladislavbelov added a comment to D1746: Network Dialog / Troll removal device.

From https://dev.maxmind.com/geoip/geoip2/geolite2/:

The GeoLite2 Country and City databases are updated on the first Tuesday of each month. The GeoLite2 ASN database is updated every Tuesday.

It means that our packed IP list will be outdated for the next month after each release.

Jan 20 2019, 1:41 PM
vladislavbelov added inline comments to D1576: Refactor CBoundingSphere and add tests.
Jan 20 2019, 10:40 AM

Jan 19 2019

vladislavbelov added inline comments to D1576: Refactor CBoundingSphere and add tests.
Jan 19 2019, 6:37 PM
vladislavbelov added a comment to D1515: Split CColor from Shapes.

I made a performance test for comparison: P149.

Jan 19 2019, 6:15 PM
vladislavbelov added a comment to D1576: Refactor CBoundingSphere and add tests.

No I just meant an infinite ray can't be contained inside a sphere, so rather its origin is inside the sphere. Otherwise I'm OK with this patch.

Ah, I got it. Yes, you're absolutely right. The origin is inside the sphere, not the ray.

Jan 19 2019, 6:14 PM
vladislavbelov added inline comments to D1576: Refactor CBoundingSphere and add tests.
Jan 19 2019, 4:39 PM
vladislavbelov added a comment to D1746: Network Dialog / Troll removal device.

How many space the list of only countries costs?

Jan 19 2019, 4:34 PM
vladislavbelov added inline comments to D1576: Refactor CBoundingSphere and add tests.
Jan 19 2019, 4:34 PM
vladislavbelov added inline comments to D1576: Refactor CBoundingSphere and add tests.
Jan 19 2019, 4:15 PM
vladislavbelov added a comment to D1576: Refactor CBoundingSphere and add tests.

Does it really make sense to talk about 'inside' for infinite rays?

I guess the bug you are fixing is when the ray's origin is inside the sphere.

Yes. Because it won't be handled as intersection currently.

Jan 19 2019, 3:17 PM
vladislavbelov updated the diff for D1753: Script to auto update year for all modified files.
  • s/header/year/
  • add basic C++ headers
  • a little bit of polishing
Jan 19 2019, 3:12 PM
vladislavbelov added inline comments to D1753: Script to auto update year for all modified files.
Jan 19 2019, 3:05 PM
vladislavbelov added inline comments to D1753: Script to auto update year for all modified files.
Jan 19 2019, 3:03 PM
vladislavbelov added inline comments to D1753: Script to auto update year for all modified files.
Jan 19 2019, 2:57 PM
vladislavbelov added a comment to D1746: Network Dialog / Troll removal device.
In D1746#70505, @elexis wrote:
In D1746#70502, @elexis wrote:

Where is the problem? It just displays nothing or "?" then. It can be the case for any column and any row. It displays something if there is data, otherwise it doesn't.

So the status of proxy is useless, because it does guarantee anything.

I don't understand why you say that. If there is a 1 in the database for that field, then it's a VPN. If it's a VPN and people want to rule out anonymous users / smurfs, it's very useful to them.
If there was any entry in the GeoLite2 database that was useless, it wouldn't be in the database.

Because a VPN service can use a random IP, you can't predict which IP is proxy (because of botnet, etc). Some people use custom VPN (dedicated server with a simple tunnel). So I suppose the GeoLite2 can detect only popular VPN for usual users.

Jan 19 2019, 2:53 PM
vladislavbelov added inline comments to D1753: Script to auto update year for all modified files.
Jan 19 2019, 2:43 PM
vladislavbelov added a comment to D1746: Network Dialog / Troll removal device.
In D1746#70502, @elexis wrote:

Where is the problem? It just displays nothing or "?" then. It can be the case for any column and any row. It displays something if there is data, otherwise it doesn't.

So the status of proxy is useless, because it does guarantee anything.

Jan 19 2019, 1:11 AM
vladislavbelov added a comment to D1746: Network Dialog / Troll removal device.
In D1746#70499, @elexis wrote:

Dunno, it's in the database and it can be displayed. The database is incomplete here and there with some entries and that should be caught already. Just a matter of displaying it in JS.

The problem is that the database can not be complete.

Jan 19 2019, 12:45 AM
vladislavbelov added a comment to D1717: Fix Olist text wrapping.
In D1717#70498, @elexis wrote:

https://code.wildfiregames.com/D1717#68827 (also that wall of text about committing things)

Jan 19 2019, 12:21 AM

Jan 18 2019

vladislavbelov added a comment to D1717: Fix Olist text wrapping.

@elexis Do you have any objection that prevents to commit the patch?

Jan 18 2019, 11:26 PM
vladislavbelov added a comment to D1746: Network Dialog / Troll removal device.

*VPN detection:* Notice the Blocks file contains which clients are using proxies / VPN networks.

It's not possible for all proxies/VPN.

Jan 18 2019, 11:24 PM
vladislavbelov added a comment to D1751: [WIP] Map ping.

I think we should restrict the number of pings, because I'm sure there will be many spammer on servers.

Jan 18 2019, 10:26 PM
vladislavbelov added inline comments to D1751: [WIP] Map ping.
Jan 18 2019, 10:21 PM
vladislavbelov added a comment to D1751: [WIP] Map ping.

I didn't take a look at the JS code.

Jan 18 2019, 10:19 PM
vladislavbelov added inline comments to D1752: Add GUI events for middle mouse click.
Jan 18 2019, 9:51 PM
Angen awarded D1753: Script to auto update year for all modified files a Yellow Medal token.
Jan 18 2019, 9:47 PM
vladislavbelov updated the summary of D1753: Script to auto update year for all modified files.
Jan 18 2019, 9:47 PM
vladislavbelov updated the diff for D1753: Script to auto update year for all modified files.
Jan 18 2019, 9:46 PM
vladislavbelov created D1753: Script to auto update year for all modified files.
Jan 18 2019, 9:45 PM

Jan 14 2019

vladislavbelov added inline comments to D1745: Allow loading Icons at runtime.
Jan 14 2019, 12:58 PM
vladislavbelov added a comment to D1745: Allow loading Icons at runtime.

While that is correct I think it would be reasonably easy to adapt and thus can probably be merged regardless - I'll defer to your opinion but it doesn't seem like we'll use this feature _intensively_.

Jan 14 2019, 12:54 PM
vladislavbelov added a comment to D1745: Allow loading Icons at runtime.

We shouldn't use such way of dynamic loading until we have atlases for textures. Because currently the AddIcon calling for each sprite means the slow cycle: (init) read data from drive/memory > create a small texture on GPU > fill the texture, (draw) bind the texture > draw the texture. All this makes the RAM and VRAM pretty fragmented.

Jan 14 2019, 11:44 AM

Jan 13 2019

vladislavbelov added inline comments to D1622: [CSlider] On click move the slider-button to the mouse position.
Jan 13 2019, 8:03 PM
vladislavbelov committed rP22051: Split CColor from Shapes..
Split CColor from Shapes.
Jan 13 2019, 4:39 PM
vladislavbelov closed D1515: Split CColor from Shapes.
Jan 13 2019, 4:38 PM
vladislavbelov committed rP22050: Simple refactoring of Singleton. Make it non-copyable..
Simple refactoring of Singleton. Make it non-copyable.
Jan 13 2019, 4:12 PM
vladislavbelov closed D1564: Simple refactoring of Singleton.
Jan 13 2019, 4:11 PM
vladislavbelov added inline comments to D1682: Cleanup RallyPointRenderer.
Jan 13 2019, 3:30 PM
vladislavbelov added inline comments to D1741: Fix some warning for vs2015 in Atlas.
Jan 13 2019, 3:22 PM
vladislavbelov added inline comments to D1515: Split CColor from Shapes.
Jan 13 2019, 3:17 PM
vladislavbelov added inline comments to D1741: Fix some warning for vs2015 in Atlas.
Jan 13 2019, 3:11 PM
vladislavbelov added inline comments to D1740: Support inheritance in special filter templates.
Jan 13 2019, 3:03 PM

Jan 7 2019

vladislavbelov added a comment to rP22010: Add Coala Bear for the license header check..

Is it intended that the Vulcan marks diffs with a wrong year in the header as "build failed"? It seems more like a lint warning.

Edit: Seems to be the case that it warns only, I thought I had seen it in a revision proposal.

Could you attach a link to the build?

Jan 7 2019, 2:09 PM
vladislavbelov added inline comments to D1682: Cleanup RallyPointRenderer.
Jan 7 2019, 1:45 AM
vladislavbelov added a comment to D1682: Cleanup RallyPointRenderer.

Also check that:

  • A comment starts with a capital letter.
  • No space before brace in static_cast<...>(.
Jan 7 2019, 1:44 AM

Jan 6 2019

Angen awarded rP22039: Remove hardcoded SkyBox sizes and use the infinity sky. No we render a Like token.
Jan 6 2019, 10:56 PM
vladislavbelov committed rP22039: Remove hardcoded SkyBox sizes and use the infinity sky. No we render.
Remove hardcoded SkyBox sizes and use the infinity sky. No we render
Jan 6 2019, 10:55 PM
vladislavbelov closed D1683: Removes hardcoded SkyBox sizes and use infinity sky.
Jan 6 2019, 10:55 PM
vladislavbelov committed rP22038: Removes active values from UserReport, they are not hardware statistics..
Removes active values from UserReport, they are not hardware statistics.
Jan 6 2019, 10:19 PM
vladislavbelov closed D1621: Removes active values from UserReport.
Jan 6 2019, 10:19 PM
vladislavbelov committed rP22037: Add an error message for crashes without required UV sets..
Add an error message for crashes without required UV sets.
Jan 6 2019, 10:04 PM
vladislavbelov closed D433: Add an error message for crashes without required UV sets.
Jan 6 2019, 10:04 PM
vladislavbelov added inline comments to D1736: Early-exit when destroying invalid entities (INVALID_ENTITY, already destroyed…).
Jan 6 2019, 9:50 PM
vladislavbelov committed rP22035: Refactor build information getters and remove the useless code..
Refactor build information getters and remove the useless code.
Jan 6 2019, 3:33 PM
vladislavbelov closed D1348: Simple refactoring of build information getters.
Jan 6 2019, 3:33 PM

Jan 5 2019

vladislavbelov committed rP22033: Cleanup Camera code for projections..
Cleanup Camera code for projections.
Jan 5 2019, 11:41 PM
vladislavbelov closed D1514: Cleanup Camera code for projections.
Jan 5 2019, 11:41 PM