Page MenuHomeWildfire Games

vladislavbelov (Vladislav Belov)
User

User Details

User Since
Feb 3 2017, 10:51 PM (115 w, 4 h)

Recent Activity

Mon, Apr 15

vladislavbelov added a comment to D1823: Replace includes uniform_foo with uniform_foo_distribution.

Which version of boost starts support it?

Mon, Apr 15, 1:21 AM

Wed, Apr 10

Angen awarded D1763: Removes duplication of Clamp function a Like token.
Wed, Apr 10, 9:36 PM
vladislavbelov added inline comments to D1584: Seed random sounds.
Wed, Apr 10, 8:56 PM

Tue, Apr 9

vladislavbelov accepted D1821: Remove useless Random class.

I suppose we won't loose distribution here, at least we won't notice it.

Tue, Apr 9, 9:42 PM
vladislavbelov added a comment to D1821: Remove useless Random class.

The WELL512 usage was introduces in rP10446 along a bug fixing. So the only question is: would be enough to have the mt19937 to prevent the bug.

Tue, Apr 9, 9:35 PM
vladislavbelov added a comment to D1584: Seed random sounds.

mt19937 seems ok for me, but I'm worrying about performance. Could you test how many calls of the UploadPropertiesAndPlay function we have on the biggest map with biggest number of units per second?

Tue, Apr 9, 9:29 PM
vladislavbelov added a comment to D1821: Remove useless Random class.
In D1821#74573, @Stan wrote:

That's a test so it doesn't matter much.

Actually we run all tests on our server for each diff, so it does matters if it significantly slower.

Tue, Apr 9, 9:20 PM
vladislavbelov added a comment to D1821: Remove useless Random class.

What's about performance?

Tue, Apr 9, 9:10 PM
vladislavbelov accepted rP22151: New berry bushes by BigTiger.
Tue, Apr 9, 4:38 PM
vladislavbelov added a comment to D1584: Seed random sounds.
In D1584#74541, @Stan wrote:
Tue, Apr 9, 11:14 AM

Mon, Apr 8

vladislavbelov added inline comments to D1571: Refactor and cleanup of CGameView.
Mon, Apr 8, 10:15 PM

Sun, Apr 7

vladislavbelov added a comment to D1814: Unused iterator in Xeromyces.

@Angen thank you for the patch!

Sun, Apr 7, 9:31 PM
vladislavbelov committed rP22170: Removes unused iterator in Xeromyces. Its usage was removed in rP16888..
Removes unused iterator in Xeromyces. Its usage was removed in rP16888.
Sun, Apr 7, 8:23 PM
vladislavbelov closed D1814: Unused iterator in Xeromyces.
Sun, Apr 7, 8:23 PM
vladislavbelov accepted D1814: Unused iterator in Xeromyces.

I tested the patch and it works. Since the problem is reported by cppcheck (probably by some compiler too) I don't see a reason to refactor the whole file, because it's a bit other problem.

Sun, Apr 7, 8:21 PM
vladislavbelov added inline comments to D1584: Seed random sounds.
Sun, Apr 7, 12:42 PM

Sat, Apr 6

vladislavbelov added a comment to D1584: Seed random sounds.
In D1584#74336, @Stan wrote:

Does setting the seed reset the rng ?

Sat, Apr 6, 6:11 PM
vladislavbelov added a comment to D1584: Seed random sounds.
In D1584#74323, @Stan wrote:

Can't really make it static since we always want to generate the same number for a given Actor seed.

Sat, Apr 6, 4:58 PM
vladislavbelov added a comment to D1584: Seed random sounds.
In D1584#74317, @Stan wrote:
Sat, Apr 6, 4:21 PM
vladislavbelov added inline comments to D1622: [CSlider] On click move the slider-button to the mouse position.
Sat, Apr 6, 4:05 PM
vladislavbelov added inline comments to D1622: [CSlider] On click move the slider-button to the mouse position.
Sat, Apr 6, 4:00 PM
vladislavbelov added a comment to D1584: Seed random sounds.
In D1584#74312, @Stan wrote:

1000000 Samples

Could you attach the source?

Sat, Apr 6, 3:59 PM

Fri, Apr 5

vladislavbelov added a comment to D1584: Seed random sounds.
In D1584#74289, @Stan wrote:

How should I test it ? I'm not really confident with profiling :)

Fri, Apr 5, 8:37 PM
vladislavbelov added a comment to D1584: Seed random sounds.

But! mt19937 could be a bit slower of faster than the previous solution for many sounds, could you test it?

Fri, Apr 5, 8:03 PM
vladislavbelov accepted D1584: Seed random sounds.

I tested the patch, it works well. We already use mt19937 but from boost. I don't see any strong reason to use the boost one. Maybe someone wants to replace them by the std:: version in future. By https://trac.wildfiregames.com/wiki/CppSupport all supported compilers support <random>.

Fri, Apr 5, 8:01 PM
vladislavbelov added inline comments to rP22161: Fixes.
Fri, Apr 5, 5:45 PM
vladislavbelov added a comment to D1816: Remove wrong assignment introduced in rP21113.
In D1816#74161, @Angen wrote:

clamp has int as parameters (32 bits), std::max returns only 8 bits so might not bee needed. But I am not sure about that.

Clamp is a template function, so a compiler deduce a type from its arguments.

Fri, Apr 5, 11:37 AM
vladislavbelov added inline comments to D1622: [CSlider] On click move the slider-button to the mouse position.
Fri, Apr 5, 1:00 AM

Thu, Apr 4

vladislavbelov added inline comments to D1622: [CSlider] On click move the slider-button to the mouse position.
Thu, Apr 4, 11:42 PM
vladislavbelov requested changes to D1543: Don't require application restart to change the pauseonfocusloss option.
Thu, Apr 4, 10:51 PM
vladislavbelov added inline comments to D1574: Get XML syntax errors not only the first time that file is loaded.
Thu, Apr 4, 10:44 PM
vladislavbelov added a comment to rP22151: New berry bushes by BigTiger.

The model works now without any error, but the berries looks too polygonized. Did you smooth normals?

Thu, Apr 4, 9:09 PM
vladislavbelov added a comment to D1799: [Windows] Add information about data paths to error window.
In D1799#74092, @Itms wrote:

If you want go ahead! Else I can commit it in an hour or two

Thu, Apr 4, 8:42 PM
vladislavbelov added a comment to D1799: [Windows] Add information about data paths to error window.
In D1799#74058, @Itms wrote:

Still good after testing! The text improvement is a good idea yeah 🙂

Thu, Apr 4, 8:17 PM

Wed, Apr 3

vladislavbelov added a comment to D1799: [Windows] Add information about data paths to error window.
In D1799#74045, @Itms wrote:

Do you want me to test on Windows @vladislavbelov?

As you want, I just wanted you check the text :)

Wed, Apr 3, 9:30 PM
vladislavbelov added inline comments to D1812: Remove unused variable from ModelRenderer.
Wed, Apr 3, 8:19 PM
vladislavbelov accepted D1799: [Windows] Add information about data paths to error window.

The C++ part is clear for me.

Wed, Apr 3, 7:18 PM
vladislavbelov added inline comments to D1584: Seed random sounds.
Wed, Apr 3, 6:56 PM
vladislavbelov added inline comments to D1584: Seed random sounds.
Wed, Apr 3, 6:54 PM
vladislavbelov added inline comments to D1584: Seed random sounds.
Wed, Apr 3, 6:24 PM
vladislavbelov added inline comments to D1584: Seed random sounds.
Wed, Apr 3, 5:55 PM
vladislavbelov added inline comments to D1584: Seed random sounds.
Wed, Apr 3, 4:38 PM
vladislavbelov added inline comments to D1584: Seed random sounds.
Wed, Apr 3, 3:55 PM
vladislavbelov added a comment to D1809: Simple cleanup of Shapes.
In D1809#73950, @elexis wrote:

Then add it to CC.

CC is to allow people to chose between multiple syntactically and semantically correct solutions.
It's not a convention that we avoid bugs.

But CC helps to make less mistakes.

Wed, Apr 3, 3:00 PM
vladislavbelov added inline comments to D1682: Cleanup RallyPointRenderer.
Wed, Apr 3, 1:55 PM
vladislavbelov added inline comments to D1741: Fix some warning for vs2015 in Atlas.
Wed, Apr 3, 1:49 PM
vladislavbelov added inline comments to D1584: Seed random sounds.
Wed, Apr 3, 1:45 PM
vladislavbelov added a comment to D1809: Simple cleanup of Shapes.
In D1809#73924, @elexis wrote:

This commit is not a cleanup, but a bugfix with some additional cleanup.
So it makes sense to add a comment so that people don't reintroduce the bug.

Then add it to CC.

Wed, Apr 3, 1:40 PM
vladislavbelov added inline comments to D1763: Removes duplication of Clamp function.
Wed, Apr 3, 1:22 PM
vladislavbelov added a comment to D1809: Simple cleanup of Shapes.
In D1809#73904, @elexis wrote:

But even better might be adding the comment to the code itself, so that people stubmle upon it while reading the code.

About what? It's too common thing and it's related to many places in the code. So I'd prefer to add comments to our CC.

Wed, Apr 3, 11:01 AM
vladislavbelov added inline comments to D1682: Cleanup RallyPointRenderer.
Wed, Apr 3, 10:55 AM
vladislavbelov requested changes to D1682: Cleanup RallyPointRenderer.
Wed, Apr 3, 3:06 AM
vladislavbelov raised a concern with rP22151: New berry bushes by BigTiger.

I got an error on the African Plains map:

ERROR: Could not load mesh 'art/meshes/gaia/berry_bush_02.dae'
ERROR: CObjectEntry::BuildVariation(): Model art/meshes/gaia/berry_bush_02.dae failed to load
Wed, Apr 3, 2:34 AM
vladislavbelov added inline comments to D1741: Fix some warning for vs2015 in Atlas.
Wed, Apr 3, 12:53 AM

Tue, Apr 2

vladislavbelov added inline comments to D1799: [Windows] Add information about data paths to error window.
Tue, Apr 2, 11:13 PM
vladislavbelov added inline comments to D1799: [Windows] Add information about data paths to error window.
Tue, Apr 2, 10:59 PM
elexis awarded rP22154: Removes unused variable. It was introduced in rP3893, an interface to control a Like token.
Tue, Apr 2, 9:35 PM
vladislavbelov committed rP22154: Removes unused variable. It was introduced in rP3893, an interface to control.
Removes unused variable. It was introduced in rP3893, an interface to control
Tue, Apr 2, 8:50 PM
vladislavbelov requested changes to D1483: Use Homebrew to fetch OSX libraries instead of compiling them all.

I suppose you plan changes here.

Tue, Apr 2, 4:43 PM
vladislavbelov updated subscribers of D1493: Camera view config options.
In D1493#70804, @Stan wrote:

@vladislavbelov Any comment on this patch ?

Did you test it? There is a chance that some values on edges may lead to a strange behaviour.

Tue, Apr 2, 4:40 PM
vladislavbelov requested changes to D1511: Patch to solve ticket #5165 (Zip files with comments trip assertion on game startup).
Tue, Apr 2, 4:38 PM
vladislavbelov added a comment to D1511: Patch to solve ticket #5165 (Zip files with comments trip assertion on game startup).

Could you create a patch with context: https://trac.wildfiregames.com/wiki/SubmittingPatches#Makingsomechanges? It helps a lot when you're reviewing, thank you. Currently it's harder to me to review a logic without context.

Tue, Apr 2, 4:38 PM
vladislavbelov requested changes to D1584: Seed random sounds.
Tue, Apr 2, 4:31 PM

Mon, Apr 1

vladislavbelov added a comment to D1809: Simple cleanup of Shapes.
In D1809#73829, @elexis wrote:

Tests?

I plan to add it later. I have a big queue. But there is no logic change.

Mon, Apr 1, 10:18 PM
vladislavbelov updated the diff for D1809: Simple cleanup of Shapes.
Mon, Apr 1, 9:08 PM
vladislavbelov created D1809: Simple cleanup of Shapes.
Mon, Apr 1, 8:49 PM

Sat, Mar 30

vladislavbelov added a comment to D1804: Fixes black water glitches for certain wind angles.
In D1804#73657, @elexis wrote:

I'm sure we can find a wrong formula that can give the right results too in a blackbox test.

It's true, our water shader has a lot of things to improve.

Sat, Mar 30, 10:02 PM
elexis awarded D1804: Fixes black water glitches for certain wind angles a Like token.
Sat, Mar 30, 9:28 PM

Fri, Mar 29

vladislavbelov created D1804: Fixes black water glitches for certain wind angles.
Fri, Mar 29, 10:50 PM

Wed, Mar 27

vladislavbelov added a comment to D1753: Script to auto update year for all modified files.

@Itms any thoughts?

Wed, Mar 27, 2:11 PM
vladislavbelov added inline comments to D1789: Handle unknown APIC IDs in the ACPI SRAT.
Wed, Mar 27, 11:48 AM
vladislavbelov added inline comments to D1584: Seed random sounds.
Wed, Mar 27, 11:32 AM

Tue, Mar 26

vladislavbelov added a comment to D1571: Refactor and cleanup of CGameView.
In D1571#73534, @elexis wrote:

If you ask if WFGs policy allows for unreviewed commits, then I wonder why you ask, after you saw me committing hundreds of unreviewed patches and always arguing for that freedom, other people committing unreviewed patches this release, and last but not least the lengthy forum discussions to reinsure this freedom, last one at https://wildfiregames.com/forum/index.php?/topic/25169-post-a23-commit-frenzy/. One of my arguments is that granting a developer access to commit patches of people who can't be trusted (external contributors) implies trusting the developer to decide over the quality of a contribution singlehandedly. Another argument is that there is a big difference in quality between reviews and peer reviews. If the author knows the code in question much better than anyone else, the reviews won't be very effective nor efficient. On the other hand reviews cost time for the reviewer - if the reviewer wants to do a good job, it costs similarly much time as compared to writing the patch.
So it depends on the specific patch, on the active members and their knowledge of the affected code whether and how much a review benefits, and it depends on good taste and luck to see which patches would be better proposed first and which ones are simple and solid enough to go in sooner than later.

Yeah, I understand your point. My point is that everyone mistakes, and waiting for more review sometimes decreases a mistake chance. But sometimes it takes too much time.

Tue, Mar 26, 4:21 PM
vladislavbelov added a comment to D1571: Refactor and cleanup of CGameView.
In D1571#73526, @elexis wrote:

If you want to commit this patch to continue working on greater features that depend on this, and if you have done your best to ensure the correctness, I would suggest to take that decision to commit into your hands.

Edit: You can add "Comments By:" if you can't post "Reviewed By:"

Tue, Mar 26, 2:30 PM
vladislavbelov added inline comments to D1571: Refactor and cleanup of CGameView.
Tue, Mar 26, 2:28 PM
vladislavbelov added inline comments to D1571: Refactor and cleanup of CGameView.
Tue, Mar 26, 2:02 AM
vladislavbelov added a comment to rP22137: Remove and Update some outdated tips and refactor tip displaying.

Reviewed By has the use case that one can grep it, but I was more refering to Reviewed By: <comitter>, where <comitter> is the person that committed it.

Oh, I missed that part, sorry. I understood it incorrectly.

Tue, Mar 26, 12:40 AM

Mon, Mar 25

vladislavbelov committed rP22143: Refactor CBoundingSphere and add tests.
Refactor CBoundingSphere and add tests
Mon, Mar 25, 10:19 PM
vladislavbelov closed D1576: Refactor CBoundingSphere and add tests.
Mon, Mar 25, 10:19 PM
vladislavbelov added a comment to rP22137: Remove and Update some outdated tips and refactor tip displaying.

(Reviewed by: <committer> always seemed redundant to me.

I think a possible use-case of the Reviewed By is when someone made a review remotely from phabricator, like via IRC/voice chat/live (for example on conference).

Mon, Mar 25, 9:49 PM
vladislavbelov updated the diff for D1571: Refactor and cleanup of CGameView.

@wraitii @elexis Removed m_Smoothness getter until we have something finished with config.

Mon, Mar 25, 9:39 PM
vladislavbelov added inline comments to D1763: Removes duplication of Clamp function.
Mon, Mar 25, 9:25 PM
vladislavbelov updated the diff for D1763: Removes duplication of Clamp function.

Fixes Stan's notes.

Mon, Mar 25, 9:25 PM
vladislavbelov accepted D1622: [CSlider] On click move the slider-button to the mouse position.

The patch looks good to me.

Mon, Mar 25, 8:17 PM

Mar 8 2019

vladislavbelov added inline comments to D1783: Add particle support to actor editor.
Mar 8 2019, 3:37 PM · Windows Developers
vladislavbelov added inline comments to D1784: Fixed assert fails in Actor Editor.
Mar 8 2019, 3:36 PM · Windows Developers

Feb 25 2019

vladislavbelov added a comment to D1753: Script to auto update year for all modified files.
In D1753#72433, @Itms wrote:

It's a nice script, but is it useful now that the linter detects those wrong license dates? What would be the use case?

Feb 25 2019, 12:49 PM

Feb 17 2019

vladislavbelov added a comment to D1698: Various compilation fixes for different compilers.
In D1698#72244, @Stan wrote:

It's still using the 2017 toolset so yes.

Feb 17 2019, 9:16 PM
vladislavbelov added a comment to D1745: Allow loading Icons at runtime.
In D1745#72226, @elexis wrote:

So you're asking for AddIcons instead of AddIcon.

Actually no, though AddIcons is better than AddIcon. I think these functions are dangerous currently.

Feb 17 2019, 9:13 PM
vladislavbelov added a comment to D1698: Various compilation fixes for different compilers.
In D1698#72240, @Stan wrote:

the goal is to drop support eventually and move on to 2015 2017

It's true, but we didn't drop it yet.

Feb 17 2019, 3:36 PM
vladislavbelov added a comment to D1698: Various compilation fixes for different compilers.
In D1698#72235, @Stan wrote:

Errors for debug build are here https://trac.wildfiregames.com/ticket/4460

Ok, it should be linked then (I added).

Feb 17 2019, 1:29 PM
vladislavbelov updated the Trac tickets for D1698: Various compilation fixes for different compilers.
Feb 17 2019, 1:28 PM
vladislavbelov added a comment to D1698: Various compilation fixes for different compilers.
In D1698#72233, @Stan wrote:

Updating Fcollada is not that important. Nevertheless though our debug build is broken on windows because of it and the game doesn't work with Fcollada compiled with vs2015 instant default.

So I thought we might as well take all the fixes from the other forks over the internet.

Feb 17 2019, 12:00 PM
vladislavbelov added a comment to D1698: Various compilation fixes for different compilers.

Do we have to update our fcollada? Especially if it has useful changes.

Feb 17 2019, 11:37 AM

Feb 16 2019

vladislavbelov added a comment to D1745: Allow loading Icons at runtime.
In D1745#72176, @elexis wrote:

So the numbers show us that displaying 250 new textures means that 250 more textures are processed, but that's not surprising, is it?

Of course.

Feb 16 2019, 10:52 PM
vladislavbelov added inline comments to D1752: Add GUI events for middle mouse click.
Feb 16 2019, 6:27 PM
vladislavbelov requested changes to D1751: [WIP] Map ping.

Currently few of my comments should be fixed anyway, so I add a "Request changes". But also I want to discuss about a method to pass the ping event to the C++.

Feb 16 2019, 6:21 PM
vladislavbelov added a comment to D1756: #loadingordermatters.

What's about wraitii suggestion:

If not, I would recommend passing an enum VFS::SORTED or something instead of true or false since C++ doesn't have named arguments

It makes sense to use a name. It'd be easier to read such code.

Feb 16 2019, 6:11 PM
vladislavbelov added inline comments to D1622: [CSlider] On click move the slider-button to the mouse position.
Feb 16 2019, 5:53 PM
vladislavbelov added a comment to D1586: Allow mod packagers to not bundle XML files.

As we discussed XML is a pretty specific case and it may have some problems. But I can suggest to add a more common parameter, like an ignore mask. Example:

... --ignore-mask="*test.js|*.xmb"

But it also requires a motivation.

Feb 16 2019, 5:38 PM