Page MenuHomeWildfire Games

vladislavbelov (Vladislav Belov)
User

User Details

User Since
Feb 3 2017, 10:51 PM (222 w, 6 d)

Recent Activity

Tue, May 11

vladislavbelov added inline comments to D3933: Make CMatrix3D::operator*= behave as expected..
Tue, May 11, 4:59 PM

Mon, May 10

vladislavbelov updated the diff for D3905: Fixes the original cause of the red water.
Mon, May 10, 9:05 PM

Wed, May 5

vladislavbelov added a comment to D3927: Fix bounding boxes after rP25306.

Please fix comments from rP25306.

Wed, May 5, 4:06 PM

Tue, May 4

vladislavbelov added inline comments to D3848: Implement a threadpool.
Tue, May 4, 9:41 PM
vladislavbelov added inline comments to D3848: Implement a threadpool.
Tue, May 4, 9:40 PM

Sat, May 1

vladislavbelov added a comment to D3916: Fix some warnings..

virtual is not needed when there is override.

Sat, May 1, 8:22 PM
vladislavbelov committed rP25355: Moves terrain independent code for viewport bounds calculations to camera..
Moves terrain independent code for viewport bounds calculations to camera.
Sat, May 1, 7:00 PM
vladislavbelov added a comment to D3552: Split the rendering WaterManager in a graphics/ and a renderer/ part..

I don't see a point in the separation as a Manager. Your implementation contains data needed only for rendering (it doesn't manage something and doing such calculations on CPU in case someone wants changeable terrain is very expensive in comparison to GPU) and a small state that might be stored in CmpWaterManager. I'd suggest to use CmpWaterManager (I'm not even sure that we need the Manager suffix for Cmp as well) for the core state, Water (without Manager) for visual properties and WaterRenderer for rendering (like for Terrain).

Sat, May 1, 6:08 PM
vladislavbelov added inline comments to rP25354: Replace ScriptInterface::Call* with new ScriptFunction functions.
Sat, May 1, 4:37 PM
vladislavbelov added inline comments to rP25354: Replace ScriptInterface::Call* with new ScriptFunction functions.
Sat, May 1, 4:35 PM
vladislavbelov added inline comments to rP25354: Replace ScriptInterface::Call* with new ScriptFunction functions.
Sat, May 1, 4:31 PM
vladislavbelov added inline comments to rP25354: Replace ScriptInterface::Call* with new ScriptFunction functions.
Sat, May 1, 4:28 PM
vladislavbelov committed rP25352: Fixes unused CCamera argument in debug rendering in SilhouetteRenderer..
Fixes unused CCamera argument in debug rendering in SilhouetteRenderer.
Sat, May 1, 2:14 PM
vladislavbelov added a comment to D3905: Fixes the original cause of the red water.

Forgot to add out of view points. Will do after adding tests and refactoring: viewport bounds don't depend on terrain.

Sat, May 1, 12:40 PM
vladislavbelov added a comment to D3848: Implement a threadpool.

Will take a look tomorrow.

Sat, May 1, 1:56 AM

Thu, Apr 29

vladislavbelov added inline comments to D3905: Fixes the original cause of the red water.
Thu, Apr 29, 10:00 AM
vladislavbelov accepted D3900: Fix massive slowdown with GLSL shadows (on my computer anyways)..
Thu, Apr 29, 9:18 AM

Wed, Apr 28

vladislavbelov updated the diff for D3905: Fixes the original cause of the red water.
Wed, Apr 28, 10:10 PM
vladislavbelov requested review of D3905: Fixes the original cause of the red water.
Wed, Apr 28, 9:37 PM
vladislavbelov added a comment to D3900: Fix massive slowdown with GLSL shadows (on my computer anyways)..

Since we don't use FFP anymore, we can remove it. ARB shaders set it in ShaderProgram.

Wed, Apr 28, 9:15 PM
vladislavbelov added inline comments to D3893: Remove the ability to add specific tooltips to in-text icons..
Wed, Apr 28, 8:51 AM

Tue, Apr 27

vladislavbelov committed rP25330: Removes glColor* calls from scene rendering, colors are set explicitly by….
Removes glColor* calls from scene rendering, colors are set explicitly by…
Tue, Apr 27, 9:36 PM
vladislavbelov committed rP25329: Removes ShaderProgramPtr argument from DebugRenderer methods..
Removes ShaderProgramPtr argument from DebugRenderer methods.
Tue, Apr 27, 9:23 PM
vladislavbelov committed rP25328: Removes GL matrix stack usages from scene rendering..
Removes GL matrix stack usages from scene rendering.
Tue, Apr 27, 8:44 PM
vladislavbelov closed D3894: Removes GL matrix stack usages from scene rendering.
Tue, Apr 27, 8:44 PM
vladislavbelov added inline comments to D3895: Generalize icon-specific tooltips to a tag, streamline code..
Tue, Apr 27, 2:56 PM
vladislavbelov added inline comments to D3893: Remove the ability to add specific tooltips to in-text icons..
Tue, Apr 27, 9:27 AM

Mon, Apr 26

vladislavbelov requested review of D3894: Removes GL matrix stack usages from scene rendering.
Mon, Apr 26, 11:32 PM
vladislavbelov committed rP25324: Fixes missing DrawCameraFrustum argument after rP25323..
Fixes missing DrawCameraFrustum argument after rP25323.
Mon, Apr 26, 11:22 PM
vladislavbelov committed rP25323: Removes glBegin from scene rendering, removes GL matrix stack dependency from….
Removes glBegin from scene rendering, removes GL matrix stack dependency from…
Mon, Apr 26, 11:12 PM

Sun, Apr 25

vladislavbelov committed rP25315: Adds circle drawing to DebugRenderer..
Adds circle drawing to DebugRenderer.
Sun, Apr 25, 11:55 PM
vladislavbelov committed rP25314: Adds line drawing to DebugRenderer..
Adds line drawing to DebugRenderer.
Sun, Apr 25, 10:48 PM

Sat, Apr 24

vladislavbelov added a comment to D3866: De-singletonify CConfigDB, make hooks RAII.

Edit -> Let me know if this is a blocker for you.

If it isn't fixed now then highly likely it won't be fixed ever.

Sat, Apr 24, 4:48 PM

Fri, Apr 23

vladislavbelov added inline comments to rP25306: Cache the model-animation bounds more efficiently..
Fri, Apr 23, 5:32 PM
vladislavbelov added a comment to D1751: [WIP] Map flares.
In D1751#167714, @Stan wrote:

Better?

I think yes.

Fri, Apr 23, 9:26 AM
vladislavbelov committed rP25303: Draws scrollbar above list to have a correct order for Z sorting after rP25231..
Draws scrollbar above list to have a correct order for Z sorting after rP25231.
Fri, Apr 23, 8:56 AM
vladislavbelov closed D3881: Draws scrollbar above list.
Fri, Apr 23, 8:56 AM

Thu, Apr 22

vladislavbelov added a comment to D1751: [WIP] Map flares.

I don't think the flare marker should have the same shape as the target marker.

Shape != style. I suggest to use the texture.

Thu, Apr 22, 5:46 PM
vladislavbelov added a comment to D1751: [WIP] Map flares.
In D1751#167675, @Stan wrote:

Well the ping is unrelated to both.

EDIT: Feel free to suggest something better.

You could try to use target_marker_red_and_gold but with player colors instead of the red one.

Thu, Apr 22, 4:53 PM
vladislavbelov added a comment to D1751: [WIP] Map flares.
In D1751#167663, @Stan wrote:

Two mods with the other binary files as well. Committers deciders.

Thu, Apr 22, 4:37 PM
vladislavbelov requested review of D3881: Draws scrollbar above list.
Thu, Apr 22, 10:03 AM
vladislavbelov added a comment to D3835: Disables depth test for GUI.

@vladislavbelov
This commit makes scrolling in the Settings -> Language menu invisible

Thanks for the catch! Here is the fix: D3881.

Thu, Apr 22, 9:28 AM
vladislavbelov committed rP25300: Reduces number of allocations during error message formatting..
Reduces number of allocations during error message formatting.
Thu, Apr 22, 8:53 AM
vladislavbelov closed D3871: Reduces allocations during error message formatting.
Thu, Apr 22, 8:53 AM

Tue, Apr 20

vladislavbelov added a comment to D3866: De-singletonify CConfigDB, make hooks RAII.

While I agree that we ideally shouldn't have unpredictable lifetimes, this is simply not the case while we have the current 'restart' logic for mods, and so I would rather make things safe to use than unsafe as a default, so I'm keeping the validity token business

Tue, Apr 20, 2:06 PM

Mon, Apr 19

vladislavbelov added a comment to D3875: Fix some translation.

translate for short words should be with context. There is (if it wasn't fixed yet) an issue in A24b that a dropdown text (like "Medium") in options is translated incorrectly.

Mon, Apr 19, 4:35 PM
vladislavbelov added a comment to D3848: Implement a threadpool.

Thanks for giving this a look :)

You're always welcome!

Mon, Apr 19, 4:33 PM
vladislavbelov added inline comments to D3866: De-singletonify CConfigDB, make hooks RAII.
Mon, Apr 19, 4:23 PM
vladislavbelov requested review of D3871: Reduces allocations during error message formatting.
Mon, Apr 19, 12:16 AM

Sun, Apr 18

vladislavbelov committed rP25289: Moves cinematic overlay to GUI..
Moves cinematic overlay to GUI.
Sun, Apr 18, 6:24 PM
vladislavbelov closed D3869: Moves cinematics overlays to GUI.
Sun, Apr 18, 6:23 PM
vladislavbelov added inline comments to D3866: De-singletonify CConfigDB, make hooks RAII.
Sun, Apr 18, 5:35 PM
vladislavbelov added inline comments to D3866: De-singletonify CConfigDB, make hooks RAII.
Sun, Apr 18, 4:46 PM
vladislavbelov added a comment to D3848: Implement a threadpool.

I think the implementation is more complicated than I'd like to have. My points:

Sun, Apr 18, 4:40 PM
wraitii awarded D3869: Moves cinematics overlays to GUI a Like token.
Sun, Apr 18, 3:40 PM
vladislavbelov added inline comments to D3866: De-singletonify CConfigDB, make hooks RAII.
Sun, Apr 18, 3:25 PM
vladislavbelov committed rP25285: Removes old ARB state.matrix usages..
Removes old ARB state.matrix usages.
Sun, Apr 18, 1:09 AM
vladislavbelov committed rP25284: Removes unused debug render from ShadowMap..
Removes unused debug render from ShadowMap.
Sun, Apr 18, 12:16 AM
vladislavbelov committed rP25283: Removes fixed shader technique from effects..
Removes fixed shader technique from effects.
Sun, Apr 18, 12:08 AM

Sat, Apr 17

vladislavbelov requested review of D3869: Moves cinematics overlays to GUI.
Sat, Apr 17, 11:26 PM

Fri, Apr 16

vladislavbelov added inline comments to D3851: Set a stack quota for JS scripts to prevent crashes from infinite loops..
Fri, Apr 16, 6:16 PM
vladislavbelov committed rP25271: Adds line drawing to DebugRenderer..
Adds line drawing to DebugRenderer.
Fri, Apr 16, 12:51 AM

Thu, Apr 15

vladislavbelov committed rP25269: Removes low-level GL calls from graphics and geometrics primitives and adds….
Removes low-level GL calls from graphics and geometrics primitives and adds…
Thu, Apr 15, 8:10 PM
vladislavbelov closed D3857: Removes low-level GL calls from graphics and geometrics primitives and adds DebugRenderer.
Thu, Apr 15, 8:08 PM
vladislavbelov added a comment to rP25266: Use type_identity to simplify Clamp usage..

Yes, my point is that
Clamp<int>(some_double, some_float, some_size_t) is just as explicit as Clamp(static_cast<int>(some_double), ...) and much more readable.

That means added type_identity is useless, since Clamp<Type> works without it (you might grep occurrences before the commit).

Thu, Apr 15, 3:33 PM
vladislavbelov added a comment to rP25266: Use type_identity to simplify Clamp usage..

Specifying T explicitly (Clamp<int>, Clamp<float>) seems a better solution to me when that's needed

Thu, Apr 15, 3:20 PM
vladislavbelov added a comment to rP25266: Use type_identity to simplify Clamp usage..

That's a workaround. It makes all casts implicit, which isn't good. The STL clamp doesn't use std::type_identity.

Thu, Apr 15, 3:10 PM
vladislavbelov added a comment to D3857: Removes low-level GL calls from graphics and geometrics primitives and adds DebugRenderer.

You could make it a namespace & declare classes friend to the original type if that's more convenient, not sure. Not sure it's that useful to make the class a member variable when it's all static methods, but maybe you have some notion that state will be useful in the future

It might have a VertexBuffer in future for some kind of primitives.

Thu, Apr 15, 8:49 AM
vladislavbelov requested review of D3857: Removes low-level GL calls from graphics and geometrics primitives and adds DebugRenderer.
Thu, Apr 15, 1:26 AM
vladislavbelov committed rP25262: Removes unused header dependencies from CTimeManager..
Removes unused header dependencies from CTimeManager.
Thu, Apr 15, 12:14 AM

Wed, Apr 14

vladislavbelov committed rP25261: Removes unused shadow settings forgotten in rP13877, removes direct SkipSubmit….
Removes unused shadow settings forgotten in rP13877, removes direct SkipSubmit…
Wed, Apr 14, 10:25 PM

Apr 14 2021

vladislavbelov added inline comments to D3851: Set a stack quota for JS scripts to prevent crashes from infinite loops..
Apr 14 2021, 9:46 AM
vladislavbelov committed rP25254: Fixes warnings after minimap changes in rP25241..
Fixes warnings after minimap changes in rP25241.
Apr 14 2021, 1:17 AM

Apr 13 2021

vladislavbelov added inline comments to rP25253: Fix --without-pch build. Phab:rP25225 was missing an include..
Apr 13 2021, 8:17 PM

Apr 12 2021

vladislavbelov added a comment to rP25229: Draws GUI elements by Z order..

I have noticed some difficulties with the minimap buttons.

Please, try a newer revision, at least rP25241.

Apr 12 2021, 5:37 PM
vladislavbelov added a comment to rP25241: Crops minimap view bounds to map size..
CMiniMap.cpp
../../../source/gui/ObjectTypes/CMiniMap.cpp: In function ‘void {anonymous}::CropPointsByCircle(const std::array<CVector3D, 4>&, const CVector3D&, float, std::vector<CVector3D>*)’:
../../../source/gui/ObjectTypes/CMiniMap.cpp:78:14: warning: unused variable ‘radiusSquared’ [-Wunused-variable]
  const float radiusSquared = radius * radius;
              ^~~~~~~~~~~~~

I'll fix it, thx.

Apr 12 2021, 3:05 PM
vladislavbelov committed rP25241: Crops minimap view bounds to map size..
Crops minimap view bounds to map size.
Apr 12 2021, 2:39 PM
vladislavbelov closed D3837: Crops minimap view bounds to map size.
Apr 12 2021, 2:39 PM
vladislavbelov added inline comments to D3775: Make dropdown keys change only the highlighted element - select on enter/click..
Apr 12 2021, 2:13 PM
vladislavbelov requested review of D3837: Crops minimap view bounds to map size.
Apr 12 2021, 1:25 AM

Apr 11 2021

vladislavbelov committed rP25231: Disables depth test for GUI rendering..
Disables depth test for GUI rendering.
Apr 11 2021, 9:37 PM
vladislavbelov closed D3835: Disables depth test for GUI.
Apr 11 2021, 9:36 PM
vladislavbelov requested review of D3835: Disables depth test for GUI.
Apr 11 2021, 3:16 PM
vladislavbelov committed rP25229: Draws GUI elements by Z order..
Draws GUI elements by Z order.
Apr 11 2021, 1:28 PM
vladislavbelov closed D3780: Draws GUI elements by Z order.
Apr 11 2021, 1:28 PM
vladislavbelov added a comment to rP25225: Simplify GUI Proxy implementation & customisation..

That broke --without-pch.

Apr 11 2021, 1:12 PM

Apr 9 2021

vladislavbelov added inline comments to D3814: Allow GUI elements to define custom mouse event mask shapes..
Apr 9 2021, 8:22 AM
vladislavbelov raised a concern with rP25210: Implement quality levels for actors & corresponding setting..

actor.rnc shouldn’t be deleted.

Apr 9 2021, 8:14 AM
vladislavbelov added inline comments to D3216: Speed up GetAvailableMods for archives..
Apr 9 2021, 8:01 AM
vladislavbelov added inline comments to D3819: Allow empty actor files..
Apr 9 2021, 7:51 AM

Apr 7 2021

vladislavbelov added inline comments to D3814: Allow GUI elements to define custom mouse event mask shapes..
Apr 7 2021, 8:12 PM

Apr 3 2021

vladislavbelov added a comment to D3787: Implement an actor quality setting, with option..

Are you referring to the actor format? the code?

The code.

Apr 3 2021, 10:21 PM
vladislavbelov added inline comments to D2938: GL_ARB instancing to reduce draw calls.
Apr 3 2021, 10:20 PM
vladislavbelov added a comment to D3787: Implement an actor quality setting, with option..

It seems or model infrastructure is overcomplicated and too coupled.

Apr 3 2021, 8:37 PM
vladislavbelov added inline comments to D2938: GL_ARB instancing to reduce draw calls.
Apr 3 2021, 6:46 PM

Apr 2 2021

vladislavbelov updated the diff for D3780: Draws GUI elements by Z order.

Fixes order for siblings.

Apr 2 2021, 11:36 PM
vladislavbelov added a comment to D3787: Implement an actor quality setting, with option..

Maybe combine the lowest setting with bb change about reducing variations (using the same seed)? It'd be more clear for players.

Apr 2 2021, 11:54 AM
vladislavbelov added inline comments to D3787: Implement an actor quality setting, with option..
Apr 2 2021, 9:30 AM
vladislavbelov added inline comments to D3787: Implement an actor quality setting, with option..
Apr 2 2021, 8:43 AM

Apr 1 2021

vladislavbelov added inline comments to D3787: Implement an actor quality setting, with option..
Apr 1 2021, 9:34 PM