- User Since
- Feb 3 2017, 10:51 PM (222 w, 6 d)
Tue, May 11
Mon, May 10
Wed, May 5
Please fix comments from rP25306.
Tue, May 4
Sat, May 1
virtual is not needed when there is override.
I don't see a point in the separation as a Manager. Your implementation contains data needed only for rendering (it doesn't manage something and doing such calculations on CPU in case someone wants changeable terrain is very expensive in comparison to GPU) and a small state that might be stored in CmpWaterManager. I'd suggest to use CmpWaterManager (I'm not even sure that we need the Manager suffix for Cmp as well) for the core state, Water (without Manager) for visual properties and WaterRenderer for rendering (like for Terrain).
Forgot to add out of view points. Will do after adding tests and refactoring: viewport bounds don't depend on terrain.
Will take a look tomorrow.
Thu, Apr 29
Wed, Apr 28
Since we don't use FFP anymore, we can remove it. ARB shaders set it in ShaderProgram.
Tue, Apr 27
Mon, Apr 26
Sun, Apr 25
Sat, Apr 24
If it isn't fixed now then highly likely it won't be fixed ever.
Fri, Apr 23
Thu, Apr 22
Shape != style. I suggest to use the texture.
You could try to use target_marker_red_and_gold but with player colors instead of the red one.
Thanks for the catch! Here is the fix: D3881.
Tue, Apr 20
Mon, Apr 19
translate for short words should be with context. There is (if it wasn't fixed yet) an issue in A24b that a dropdown text (like "Medium") in options is translated incorrectly.
You're always welcome!
Sun, Apr 18
I think the implementation is more complicated than I'd like to have. My points:
Sat, Apr 17
Fri, Apr 16
Thu, Apr 15
That means added type_identity is useless, since Clamp<Type> works without it (you might grep occurrences before the commit).
That's a workaround. It makes all casts implicit, which isn't good. The STL clamp doesn't use std::type_identity.
It might have a VertexBuffer in future for some kind of primitives.
Wed, Apr 14
Apr 14 2021
Apr 13 2021
Apr 12 2021
Please, try a newer revision, at least rP25241.
I'll fix it, thx.
Apr 11 2021
That broke --without-pch.
Apr 9 2021
actor.rnc shouldn’t be deleted.
Apr 7 2021
Apr 3 2021
It seems or model infrastructure is overcomplicated and too coupled.
Apr 2 2021
Fixes order for siblings.
Maybe combine the lowest setting with bb change about reducing variations (using the same seed)? It'd be more clear for players.