Page MenuHomeWildfire Games

vladislavbelov (Vladislav Belov)
User

User Details

User Since
Feb 3 2017, 10:51 PM (155 w, 1 d)

Recent Activity

Today

vladislavbelov created D2598: Simple cleanup of ModelRenderer.
Sun, Jan 26, 3:09 AM

Tue, Jan 21

vladislavbelov added a comment to D2531: Analysis of unique_range assertion failure on MacOS.
In D2531#108430, @Stan wrote:

I've reproduced that assertion locally on macOS 10.14.6 in debug-mode. I've figured out the reason: it seems that OSAtomicAdd64 doesn't work as expected in debug mode, maybe address was misaligned.

Can it be fixed?

Tue, Jan 21, 11:17 AM · Contributors
vladislavbelov added a comment to D2531: Analysis of unique_range assertion failure on MacOS.

I've reproduced that assertion locally on macOS 10.14.6 in debug-mode. I've figured out the reason: it seems that OSAtomicAdd64 doesn't work as expected in debug mode, maybe address was misaligned.

Tue, Jan 21, 9:25 AM · Contributors

Mon, Jan 20

vladislavbelov added a comment to rP23426: Removes unused gfx::GetMonitorSize function.

Refs D2476.

Mon, Jan 20, 10:56 PM
vladislavbelov committed rP23426: Removes unused gfx::GetMonitorSize function.
Removes unused gfx::GetMonitorSize function
Mon, Jan 20, 10:54 PM
vladislavbelov added a comment to rP23425: Removes unused MemorySizeMiB. Refs D2476..

MemorySizeMiB and its usage was added in rP9546, was removed in rP13892.

Mon, Jan 20, 10:43 PM
vladislavbelov committed rP23425: Removes unused MemorySizeMiB. Refs D2476..
Removes unused MemorySizeMiB. Refs D2476.
Mon, Jan 20, 10:24 PM
vladislavbelov committed rP23424: Saves sidebar/bottombar width/height between Atlas sessions.
Saves sidebar/bottombar width/height between Atlas sessions
Mon, Jan 20, 9:58 PM
vladislavbelov closed D2583: Saves sidebar/bottombar width/height between Atlas sessions.
Mon, Jan 20, 9:58 PM
vladislavbelov added a comment to rP23423: Adds non-strict search to the Atlas entity list.

This is a great improvement, many thanks!

Mon, Jan 20, 9:58 PM
vladislavbelov committed rP23423: Adds non-strict search to the Atlas entity list.
Adds non-strict search to the Atlas entity list
Mon, Jan 20, 9:43 PM
vladislavbelov closed D2542: Adds smart search to the Atlas entity list.
Mon, Jan 20, 9:43 PM
vladislavbelov closed D2567: Splits debug display of frustums.
In D2567#108291, @Stan wrote:

Accepting so you can close.

Mon, Jan 20, 11:35 AM

Sun, Jan 19

vladislavbelov updated the test plan for D2583: Saves sidebar/bottombar width/height between Atlas sessions.
Sun, Jan 19, 10:46 PM
Alexandermb awarded D2583: Saves sidebar/bottombar width/height between Atlas sessions a Love token.
Sun, Jan 19, 10:15 PM
vladislavbelov updated the diff for D2583: Saves sidebar/bottombar width/height between Atlas sessions.
Sun, Jan 19, 9:47 PM
vladislavbelov updated the diff for D2583: Saves sidebar/bottombar width/height between Atlas sessions.

Fixes @Stan notes.

Sun, Jan 19, 9:38 PM
Stan awarded D2583: Saves sidebar/bottombar width/height between Atlas sessions a Love token.
Sun, Jan 19, 9:24 PM
vladislavbelov created D2583: Saves sidebar/bottombar width/height between Atlas sessions.
Sun, Jan 19, 9:20 PM

Sat, Jan 18

vladislavbelov accepted D2576: Options page to display per-value tooltips.

Looks ok for me.

Sat, Jan 18, 9:16 PM
vladislavbelov committed rP23412: Reports SDL builtin and runtime versions and video backend in hwdetect report..
Reports SDL builtin and runtime versions and video backend in hwdetect report.
Sat, Jan 18, 5:46 PM
vladislavbelov closed D2485: Report SDL2 version and video backend in hwdetect.
Sat, Jan 18, 5:46 PM
vladislavbelov accepted D2485: Report SDL2 version and video backend in hwdetect.

I've tested the patch on Windows VS2015, it works and looks good for me.

Sat, Jan 18, 5:45 PM
vladislavbelov added inline comments to D2485: Report SDL2 version and video backend in hwdetect.
Sat, Jan 18, 4:13 PM
vladislavbelov added inline comments to D2479: Add thread names on Linux.
Sat, Jan 18, 12:38 AM

Fri, Jan 17

vladislavbelov committed rP23410: Fixes GLES mode builds on Mesa and running on Intel Iris drivers..
Fixes GLES mode builds on Mesa and running on Intel Iris drivers.
Fri, Jan 17, 10:15 PM
vladislavbelov closed D2448: Make GLES mode work on Mesa.
Fri, Jan 17, 10:14 PM
vladislavbelov accepted D2448: Make GLES mode work on Mesa.

I've reviewed and tested the patch. It looks ok for me. I'm going to commit it soon (fixed years and GL types by myself).

Fri, Jan 17, 9:55 PM

Thu, Jan 16

vladislavbelov added a comment to D2545: Building snapping loading screen tip.
In D2545#107432, @bb wrote:

D2546 would require to change this

Thu, Jan 16, 9:04 PM
vladislavbelov added a comment to D2448: Make GLES mode work on Mesa.

The rest of the patch looks good for me.

Thu, Jan 16, 7:34 PM
vladislavbelov committed rP23405: Refactors Preprocessor testing and adds more tests.
Refactors Preprocessor testing and adds more tests
Thu, Jan 16, 1:02 AM
vladislavbelov closed D2574: Refactors Preprocessor testing and adds more tests.
Thu, Jan 16, 1:02 AM
vladislavbelov updated the diff for D2574: Refactors Preprocessor testing and adds more tests.
Thu, Jan 16, 12:45 AM
vladislavbelov updated the diff for D2574: Refactors Preprocessor testing and adds more tests.

Used CStr8 instead of std::string.

Thu, Jan 16, 12:38 AM
vladislavbelov updated the diff for D2574: Refactors Preprocessor testing and adds more tests.

Adds division by zero test.

Thu, Jan 16, 12:13 AM
vladislavbelov added a comment to D2574: Refactors Preprocessor testing and adds more tests.
In D2574#107740, @Stan wrote:

Maybe add a test for division by 0 and #elif?

Thu, Jan 16, 12:08 AM

Wed, Jan 15

vladislavbelov created D2574: Refactors Preprocessor testing and adds more tests.
Wed, Jan 15, 10:21 PM
vladislavbelov accepted D2456: Update GLSL preprocessor..
Wed, Jan 15, 6:24 PM
vladislavbelov added a comment to D2456: Update GLSL preprocessor..

Did you use master version of release version (https://github.com/OGRECave/ogre/releases/tag/v1.12.4)?

Wed, Jan 15, 5:35 PM
vladislavbelov added a comment to D825: Atlas: Allow map to recenter during resize.

Years. Also it's important to have a test for the new terrain functionality. But I suggest to split the patch and change the CTerrain and tests in a separate patch.

Wed, Jan 15, 4:13 PM
vladislavbelov added a comment to rP23395: Splits debug display of frustums for an easier debugging of a culling and….

Refs D2567.

Wed, Jan 15, 12:53 AM
vladislavbelov committed rP23395: Splits debug display of frustums for an easier debugging of a culling and….
Splits debug display of frustums for an easier debugging of a culling and…
Wed, Jan 15, 12:51 AM
vladislavbelov updated the diff for D2542: Adds smart search to the Atlas entity list.
Wed, Jan 15, 12:36 AM
vladislavbelov added a comment to D2542: Adds smart search to the Atlas entity list.
In D2542#107484, @Stan wrote:
Wed, Jan 15, 12:27 AM

Tue, Jan 14

vladislavbelov added a comment to rP23387: Move the credits button on main menu.

Thanks!
Any ideas on how to remove the unnecessary empty space between the logo and the “Learn To Play” button (red)?

Tue, Jan 14, 5:12 PM

Mon, Jan 13

vladislavbelov created D2567: Splits debug display of frustums.
Mon, Jan 13, 7:47 PM
vladislavbelov added inline comments to D2566: Fixes debug build on macOS.
Mon, Jan 13, 7:21 PM
vladislavbelov added inline comments to rP22627: Upgrade SpiderMonkey to version 45.0.2, refs #4893..
Mon, Jan 13, 7:20 PM
vladislavbelov created D2566: Fixes debug build on macOS.
Mon, Jan 13, 7:20 PM

Sun, Jan 12

vladislavbelov added a comment to D2542: Adds smart search to the Atlas entity list.

@Nescio I've tweaked the algorithm. Now it's a bit closer to your understanding. Now words separated by any non-letter characters should present in a name.

Sun, Jan 12, 11:56 PM
vladislavbelov updated the diff for D2542: Adds smart search to the Atlas entity list.

Tweaks the algorithm and adds an immediate reaction to the checkbox.

Sun, Jan 12, 11:54 PM

Sat, Jan 11

vladislavbelov committed rP23370: Reorder rendering passes to decrease a possible driver synchronization.
Reorder rendering passes to decrease a possible driver synchronization
Sat, Jan 11, 4:25 PM
vladislavbelov closed D2541: Reorder rendering passes to decrease possible driver sync.
Sat, Jan 11, 4:25 PM
vladislavbelov updated the diff for D2541: Reorder rendering passes to decrease possible driver sync.
Sat, Jan 11, 1:04 AM
vladislavbelov added a comment to rP23364: Removes obsolete sys_cursor. Refs D2557..

Wrong ref, right ref is D2476.

Sat, Jan 11, 12:49 AM
vladislavbelov committed rP23364: Removes obsolete sys_cursor. Refs D2557..
Removes obsolete sys_cursor. Refs D2557.
Sat, Jan 11, 12:45 AM

Fri, Jan 10

vladislavbelov committed rP23363: Removes possible copying of CStr in CTerrainTextureEntry and adds const where….
Removes possible copying of CStr in CTerrainTextureEntry and adds const where…
Fri, Jan 10, 11:36 PM
vladislavbelov committed rP23362: Adds const to PathfinderPassability where possible..
Adds const to PathfinderPassability where possible.
Fri, Jan 10, 9:38 PM
vladislavbelov committed rP23361: Improves performance of Atlas terrain elevation by updating the only changed….
Improves performance of Atlas terrain elevation by updating the only changed…
Fri, Jan 10, 8:54 PM
vladislavbelov closed D2557: Significantly improves Atlas terrain elevation performance.
Fri, Jan 10, 8:54 PM
vladislavbelov updated the diff for D2557: Significantly improves Atlas terrain elevation performance.

Fixes notes.

Fri, Jan 10, 7:18 PM
vladislavbelov added inline comments to D2557: Significantly improves Atlas terrain elevation performance.
Fri, Jan 10, 4:47 PM
vladislavbelov added inline comments to D2557: Significantly improves Atlas terrain elevation performance.
Fri, Jan 10, 4:38 PM
vladislavbelov added inline comments to D2557: Significantly improves Atlas terrain elevation performance.
Fri, Jan 10, 4:15 PM
vladislavbelov added a comment to D2416: Simplify conditions in SetAnimation.
In D2416#106689, @Angen wrote:

Do you know why that would be usefull?

Nope, just wondering.

Fri, Jan 10, 1:36 PM
vladislavbelov added a comment to D2476: Remove obsolete clipboard and GetVideoMode platform-specifics.

I'm going to commit removing of the system cursor soon.

Fri, Jan 10, 1:30 PM
vladislavbelov added a comment to D2557: Significantly improves Atlas terrain elevation performance.
In D2557#106791, @Itms wrote:

That's true. I don't think we have other occurrences of in-game terrain changes though (especially since, before this patch, they would be quite expensive).

Fri, Jan 10, 1:20 PM
vladislavbelov added inline comments to D2528: Performance improvements to VertexBuffer.
Fri, Jan 10, 1:18 PM
vladislavbelov added a comment to D2557: Significantly improves Atlas terrain elevation performance.
In D2557#106783, @Itms wrote:

An extra test (which I didn't run but would be needed) is a serialization test on a map where the terrain changes during the game: typically Extinct Volcano.

Fri, Jan 10, 12:35 PM
vladislavbelov updated the test plan for D2557: Significantly improves Atlas terrain elevation performance.
Fri, Jan 10, 10:16 AM
vladislavbelov created D2557: Significantly improves Atlas terrain elevation performance.
Fri, Jan 10, 10:14 AM

Thu, Jan 9

vladislavbelov added a comment to D2416: Simplify conditions in SetAnimation.

What was in case !m_BoneMatrices && !anim->m_AnimDef before the patch? It seems it returns true.

Thu, Jan 9, 5:44 PM
vladislavbelov added a comment to D2537: Adds anti-aliasing option.
In D2537#106528, @nani wrote:

Adding a extra optional sharpening pass in fxaa.xml should improve the output image.
I propose this simple box sharpening one that I use in my mod that improves the image quality.

I think it'd be useful to attach a side-by-side comparison image.

Thu, Jan 9, 12:39 AM

Wed, Jan 8

vladislavbelov created D2546: Adds an option to enable/disable building snapping.
Wed, Jan 8, 6:46 PM
vladislavbelov added a comment to D2542: Adds smart search to the Atlas entity list.

A bit unrelated to the patch, but I see the problem with the quarter of screen. Could you provide the system information (system_info.txt might be good)? Also do you have a system scale?

Wed, Jan 8, 2:32 PM

Tue, Jan 7

vladislavbelov added a comment to D2542: Adds smart search to the Atlas entity list.

The old function returns too little (no matches) for my taste and the new one too much.

I can reorder it and have more useful items first.

Tue, Jan 7, 8:50 PM
vladislavbelov added a comment to D2542: Adds smart search to the Atlas entity list.

healer_ returns healer_b, healer_a, healer_e times 13 civs in the old function, i.e. 39 units; in the new function the first item is units/kush_support_healer_a, but units/athen_infantry_slinger_b is number seven and skirmish/structures/default_sentry_tower is listed above units/athen_support_healer_a; the item listed last is units/viking_longship.
With sublime I assume you mean some specific software I don't know.
What's intuitive varies from person to person. What I'd prefer is a search function that's somewhere between the old exact single string match and the new single character match.

Tue, Jan 7, 8:08 PM
vladislavbelov added a comment to D2542: Adds smart search to the Atlas entity list.
In D2542#106375, @Stan wrote:

Would be nice to have regexp support?

Tue, Jan 7, 7:51 PM
vladislavbelov added a comment to D2542: Adds smart search to the Atlas entity list.

That's a bit unexpected.

That might happen.

Tue, Jan 7, 7:41 PM
vladislavbelov added a comment to D2542: Adds smart search to the Atlas entity list.

So it will give an ordered list of everything that has at least a single matching character?

Tue, Jan 7, 7:27 PM
vladislavbelov added a comment to D2542: Adds smart search to the Atlas entity list.

So how does the new search work then?

Tue, Jan 7, 7:20 PM
vladislavbelov added a comment to D2542: Adds smart search to the Atlas entity list.

But then I don't understand why you gave units ptol hlr a and not unitsptolhlra or ahillnoprsttu. Besides, there are no entities or actors with a space in their file name.

Tue, Jan 7, 7:09 PM
vladislavbelov added a comment to D2542: Adds smart search to the Atlas entity list.

Isn't the space a separator that functions as AND? To me hlr means hlr but h l r means h and l and r. At least that's how search works in programs such as Gnome Nautilus/Files:


Tue, Jan 7, 6:50 PM
vladislavbelov added a comment to D2542: Adds smart search to the Atlas entity list.

Then perhaps make it the default and have an “exact name” checkbox?

Tue, Jan 7, 6:32 PM
vladislavbelov added a comment to D2542: Adds smart search to the Atlas entity list.

Toggle the checkbox "Advanced search". Maybe it has misleading name.

Thanks. Toggling the checkbox and then entering the string works. Entering the string first and then clicking the checkbox does not.
Why is there a checkbox anyway? Why not make it the default?

Tue, Jan 7, 5:47 PM
vladislavbelov added a comment to D2542: Adds smart search to the Atlas entity list.

It seems Atlas fails to find anything when a space is entered in the search field, as was already the case without this patch. Any ideas what I did wrong?

Toggle the checkbox "Advanced search". Maybe it has misleading name.

Tue, Jan 7, 5:25 PM
vladislavbelov updated the diff for D2542: Adds smart search to the Atlas entity list.
Tue, Jan 7, 12:59 PM
vladislavbelov created D2542: Adds smart search to the Atlas entity list.
Tue, Jan 7, 2:29 AM
vladislavbelov added inline comments to D2541: Reorder rendering passes to decrease possible driver sync.
Tue, Jan 7, 1:31 AM
vladislavbelov created D2541: Reorder rendering passes to decrease possible driver sync.
Tue, Jan 7, 1:29 AM

Sun, Jan 5

vladislavbelov committed rP23333: Adds optional fixed shadows without swimming effect.
Adds optional fixed shadows without swimming effect
Sun, Jan 5, 11:44 PM
vladislavbelov closed D2465: Adds optional fixed shadows without swimming effect.
Sun, Jan 5, 11:44 PM
vladislavbelov updated the diff for D2537: Adds anti-aliasing option.
Sun, Jan 5, 11:30 PM
nani awarded D2537: Adds anti-aliasing option a Orange Medal token.
Sun, Jan 5, 7:20 PM
vladislavbelov retitled D2537: Adds anti-aliasing option from Adds Anti-Aliasing to Adds anti-aliasing option.
Sun, Jan 5, 6:13 PM
vladislavbelov created D2537: Adds anti-aliasing option.
Sun, Jan 5, 6:12 PM
Alexandermb awarded rP23330: Adds snapping to edges for buildings a Love token.
Sun, Jan 5, 5:22 AM
vladislavbelov committed rP23330: Adds snapping to edges for buildings.
Adds snapping to edges for buildings
Sun, Jan 5, 2:09 AM
vladislavbelov closed D2079: Adds snapping to edges for buildings.
Sun, Jan 5, 2:08 AM
vladislavbelov updated the diff for D2079: Adds snapping to edges for buildings.
Sun, Jan 5, 1:13 AM