- User Since
- Feb 3 2017, 10:51 PM (115 w, 4 h)
Mon, Apr 15
Which version of boost starts support it?
Wed, Apr 10
Tue, Apr 9
I suppose we won't loose distribution here, at least we won't notice it.
The WELL512 usage was introduces in rP10446 along a bug fixing. So the only question is: would be enough to have the mt19937 to prevent the bug.
mt19937 seems ok for me, but I'm worrying about performance. Could you test how many calls of the UploadPropertiesAndPlay function we have on the biggest map with biggest number of units per second?
Actually we run all tests on our server for each diff, so it does matters if it significantly slower.
What's about performance?
Mon, Apr 8
Sun, Apr 7
@Angen thank you for the patch!
I tested the patch and it works. Since the problem is reported by cppcheck (probably by some compiler too) I don't see a reason to refactor the whole file, because it's a bit other problem.
Sat, Apr 6
Could you attach the source?
Fri, Apr 5
But! mt19937 could be a bit slower of faster than the previous solution for many sounds, could you test it?
I tested the patch, it works well. We already use mt19937 but from boost. I don't see any strong reason to use the boost one. Maybe someone wants to replace them by the std:: version in future. By https://trac.wildfiregames.com/wiki/CppSupport all supported compilers support <random>.
Clamp is a template function, so a compiler deduce a type from its arguments.
Thu, Apr 4
The model works now without any error, but the berries looks too polygonized. Did you smooth normals?
Wed, Apr 3
As you want, I just wanted you check the text :)
The C++ part is clear for me.
But CC helps to make less mistakes.
Then add it to CC.
About what? It's too common thing and it's related to many places in the code. So I'd prefer to add comments to our CC.
I got an error on the African Plains map:
ERROR: Could not load mesh 'art/meshes/gaia/berry_bush_02.dae' ERROR: CObjectEntry::BuildVariation(): Model art/meshes/gaia/berry_bush_02.dae failed to load
Tue, Apr 2
I suppose you plan changes here.
Did you test it? There is a chance that some values on edges may lead to a strange behaviour.
Could you create a patch with context: https://trac.wildfiregames.com/wiki/SubmittingPatches#Makingsomechanges? It helps a lot when you're reviewing, thank you. Currently it's harder to me to review a logic without context.
Mon, Apr 1
I plan to add it later. I have a big queue. But there is no logic change.
Sat, Mar 30
It's true, our water shader has a lot of things to improve.
Fri, Mar 29
Wed, Mar 27
@Itms any thoughts?
Tue, Mar 26
Yeah, I understand your point. My point is that everyone mistakes, and waiting for more review sometimes decreases a mistake chance. But sometimes it takes too much time.
Oh, I missed that part, sorry. I understood it incorrectly.
Mon, Mar 25
I think a possible use-case of the Reviewed By is when someone made a review remotely from phabricator, like via IRC/voice chat/live (for example on conference).
Fixes Stan's notes.
The patch looks good to me.
Mar 8 2019
Feb 25 2019
Feb 17 2019
Actually no, though AddIcons is better than AddIcon. I think these functions are dangerous currently.
It's true, but we didn't drop it yet.
Ok, it should be linked then (I added).
Do we have to update our fcollada? Especially if it has useful changes.
Feb 16 2019
Currently few of my comments should be fixed anyway, so I add a "Request changes". But also I want to discuss about a method to pass the ping event to the C++.
What's about wraitii suggestion:
If not, I would recommend passing an enum VFS::SORTED or something instead of true or false since C++ doesn't have named arguments
It makes sense to use a name. It'd be easier to read such code.
As we discussed XML is a pretty specific case and it may have some problems. But I can suggest to add a more common parameter, like an ignore mask. Example:
But it also requires a motivation.