- User Since
- Feb 3 2017, 10:51 PM (124 w, 3 d)
Sun, Jun 23
Sat, Jun 22
Did you reproduce @Itms steps before the patch?
Fri, Jun 21
I would certainly hope none otherwise MacOS has been behaving wrong for years.
The only place I can think of that parses strings to number is GUI sizes, which would previously parse things like "3b" as "0" instead of the 'correct' "3". I don't think there's mods or 0 A.D. code that relied on that - and I'm not sure we want that code to live.
Do we really need that behaviour for wrong strings?
How many lines of our code depend on this behaviour (that wrong strings are still parsed)?
I tested, now the reflection works as after my commit.
Sat, Jun 15
It depends, because color correction may present on each side: os, gpu driver, monitor.
I think the patch should be tested on multi-monitor environment and with a custom color space.
Wed, Jun 12
Tue, Jun 11
Sun, Jun 9
Sat, Jun 8
Adds usage of setChangePerspective.
Fri, Jun 7
@wraitii could you check that?
Why pthread_t was replaced only for the main thread and not for workers?
Thu, Jun 6
Yeah, that's what I'm talking about. It's just a little improvement. Though all these flat refraction maps are workarounds.
Wed, Jun 5
Fixes @elexis's notes.
Fixes missing file and notes.
Move the g_DeveloperOverlay creation to the session.js.
WAT, why I commandered?
I agree that it's harder to read the code without indents for some people. Only objection that I'm thinking about, if you remove #if with leaving the code you need to fix the indents again that also means you rewrite the blame again.
Mostly because of scissoring #2692, but also we have inaccurate refraction projection (inaccurate in relation to the real refraction angles). We may calculate it more carefully.
Tue, Jun 4
Mon, Jun 3
Thank you for the patch!
Fri, May 31
Do we have places where the removed code might be useful? Why it was added?
Thu, May 30
Fixes @elexis notes.
Created a fix in D1937.
Nope, I was wrong, I thought std::fasbf already presents in C++11. But it doesn't. The include can be added too (though it already presents in the include tree).