Page MenuHomeWildfire Games

vladislavbelov (Vladislav Belov)
User

User Details

User Since
Feb 3 2017, 10:51 PM (241 w, 6 d)

Recent Activity

Yesterday

vladislavbelov added inline comments to D4279: Improve minimap viewpoint-polygon placement.
Thu, Sep 23, 9:47 AM
vladislavbelov added a comment to D4279: Improve minimap viewpoint-polygon placement.

I believe Vlad's point is that you could actually just query 4 height map points and draw a more accurate polygon.

Not really, the problem with the patch's approach is that it uses a single point. And it might differ significantly in neighborhood.

Thu, Sep 23, 9:45 AM

Wed, Sep 22

vladislavbelov added a comment to D4279: Improve minimap viewpoint-polygon placement.

I might be wrong, but from what I can tell, the problem with that approach is that it seems to ignore the water plane.

Sure, and you can easily do max(waterHeight, mipmapHeight).

Wed, Sep 22, 10:06 PM
vladislavbelov added a comment to D4279: Improve minimap viewpoint-polygon placement.

Maybe you could get average height from HeightMipmap?

Wed, Sep 22, 5:59 PM
vladislavbelov committed rP25936: Moves cursor to VideoMode to draw it via SDL..
Moves cursor to VideoMode to draw it via SDL.
Wed, Sep 22, 12:45 AM
vladislavbelov closed D4278: Moves cursor to VideoMode.
Wed, Sep 22, 12:45 AM

Tue, Sep 21

vladislavbelov updated the diff for D4278: Moves cursor to VideoMode.

Fixes "system".

Tue, Sep 21, 8:22 PM

Mon, Sep 20

vladislavbelov added inline comments to D4278: Moves cursor to VideoMode.
Mon, Sep 20, 9:25 PM
vladislavbelov requested review of D4278: Moves cursor to VideoMode.
Mon, Sep 20, 9:23 PM
vladislavbelov committed rP25932: Removes ogl_tex_find function, which duplicates cache-like logic in….
Removes ogl_tex_find function, which duplicates cache-like logic in…
Mon, Sep 20, 6:39 PM
vladislavbelov committed rP25931: Removes duplication of terrain alpha map creation in Renderer..
Removes duplication of terrain alpha map creation in Renderer.
Mon, Sep 20, 2:56 PM
vladislavbelov closed D4269: Removes duplication of terrain alpha map creation.
Mon, Sep 20, 2:56 PM

Tue, Sep 14

vladislavbelov added inline comments to D3037: Add gui scale to options.
Tue, Sep 14, 2:01 PM
vladislavbelov added a comment to D3037: Add gui scale to options.
In D3037#181783, @Angen wrote:

Do you mean setguiscale to take string and parse number from it?

Tue, Sep 14, 1:41 PM
vladislavbelov added inline comments to D3037: Add gui scale to options.
Tue, Sep 14, 11:22 AM
vladislavbelov added inline comments to D3037: Add gui scale to options.
Tue, Sep 14, 10:41 AM
vladislavbelov added a comment to D3037: Add gui scale to options.

I noticed some thin black lines, and the numbers in the selection list appear a bit smudged.

Tue, Sep 14, 10:39 AM
vladislavbelov added inline comments to D3037: Add gui scale to options.
Tue, Sep 14, 10:37 AM

Fri, Sep 10

vladislavbelov updated the diff for D4108: Adds FreeType support to the engine.
Fri, Sep 10, 10:11 AM
vladislavbelov added a comment to D4108: Adds FreeType support to the engine.
In D4108#181466, @Stan wrote:

Forgot the build-osx-libs.sh file :)

Thanks!

Fri, Sep 10, 10:06 AM
vladislavbelov requested review of D4269: Removes duplication of terrain alpha map creation.
Fri, Sep 10, 9:45 AM
vladislavbelov updated the diff for D4108: Adds FreeType support to the engine.

Uses @s0600204 and @wraitii patches.

Fri, Sep 10, 9:24 AM

Thu, Sep 9

vladislavbelov closed D4265: Adds header for forward declarations of CStr.

Committed in rP25905.

Thu, Sep 9, 7:45 PM
vladislavbelov committed rP25905: Adds header for forward declarations of CStr..
Adds header for forward declarations of CStr.
Thu, Sep 9, 7:39 PM
vladislavbelov added inline comments to D2623: [gui] increase label space in chat.
Thu, Sep 9, 3:52 PM
vladislavbelov added inline comments to D4265: Adds header for forward declarations of CStr.
Thu, Sep 9, 1:48 PM
vladislavbelov added a comment to D4265: Adds header for forward declarations of CStr.
In D4265#181272, @Stan wrote:

What's the benefit of having an extra file to load for fowarding?

Thu, Sep 9, 11:30 AM
vladislavbelov requested review of D4265: Adds header for forward declarations of CStr.
Thu, Sep 9, 10:41 AM

Wed, Sep 8

vladislavbelov committed rP25903: Removes unused forward declarations of class and struct..
Removes unused forward declarations of class and struct.
Wed, Sep 8, 9:44 PM
vladislavbelov added a comment to D4256: Adjusting the placeholder text for inputs.

Is intended to always center the placeholder? One might want to have it on top.

Wed, Sep 8, 11:58 AM

Tue, Sep 7

Stan awarded rP25900: Moves macro-defined methods of CStr to templates. a Love token.
Tue, Sep 7, 11:20 PM
vladislavbelov committed rP25900: Moves macro-defined methods of CStr to templates..
Moves macro-defined methods of CStr to templates.
Tue, Sep 7, 11:01 PM
vladislavbelov closed D4251: Replaces CStr macro by templates.
Tue, Sep 7, 11:01 PM
vladislavbelov updated the diff for D4251: Replaces CStr macro by templates.
Tue, Sep 7, 11:14 AM
vladislavbelov updated the diff for D4251: Replaces CStr macro by templates.
Tue, Sep 7, 10:50 AM
vladislavbelov updated the diff for D4251: Replaces CStr macro by templates.
Tue, Sep 7, 10:20 AM
vladislavbelov updated the diff for D4251: Replaces CStr macro by templates.

An easy try to fix the unused constant.

Tue, Sep 7, 9:53 AM

Mon, Sep 6

vladislavbelov updated the diff for D4251: Replaces CStr macro by templates.
Mon, Sep 6, 6:27 PM
vladislavbelov added a comment to D4251: Replaces CStr macro by templates.
In D4251#180887, @Stan wrote:

Does that mean mac and Linux can no longer deserialize CStr?

Mon, Sep 6, 12:05 PM
vladislavbelov updated the diff for D4251: Replaces CStr macro by templates.

Fixes compilation.

Mon, Sep 6, 11:50 AM

Sat, Sep 4

vladislavbelov added a comment to D4251: Replaces CStr macro by templates.
In D4251#180770, @Stan wrote:

What's the advantage of templates here? Is it faster, safer, better C++ (vs C style code) ?

Type safer. Also allows to remove unidoubler in future.

Sat, Sep 4, 4:20 PM
vladislavbelov updated the diff for D4251: Replaces CStr macro by templates.
Sat, Sep 4, 1:49 PM
vladislavbelov requested review of D4251: Replaces CStr macro by templates.
Sat, Sep 4, 12:08 AM

Fri, Sep 3

vladislavbelov committed rP25891: Removes unused macro from CStr, reduces macro dependency..
Removes unused macro from CStr, reduces macro dependency.
Fri, Sep 3, 11:06 PM
vladislavbelov closed D4245: First iteration of CStr cleanup.
Fri, Sep 3, 11:06 PM
vladislavbelov committed rP25890: Reduces the number of possible allocations for models with multiple UV sets….
Reduces the number of possible allocations for models with multiple UV sets…
Fri, Sep 3, 10:12 PM
vladislavbelov closed D4247: A little optimization for model loading.
Fri, Sep 3, 10:12 PM
vladislavbelov added inline comments to D4247: A little optimization for model loading.
Fri, Sep 3, 1:48 PM

Wed, Sep 1

vladislavbelov requested review of D4247: A little optimization for model loading.
Wed, Sep 1, 10:58 PM
Stan awarded rP25885: Removes unused g_GameRestarted forgotten in rP25628. a Love token.
Wed, Sep 1, 10:23 PM
vladislavbelov committed rP25885: Removes unused g_GameRestarted forgotten in rP25628..
Removes unused g_GameRestarted forgotten in rP25628.
Wed, Sep 1, 9:48 PM
vladislavbelov committed rP25884: Moves tex tests to the related folder, was forgotten to move in rP5518..
Moves tex tests to the related folder, was forgotten to move in rP5518.
Wed, Sep 1, 9:27 PM
vladislavbelov added inline comments to rP25882: Display the number of idle workers in that respective button..
Wed, Sep 1, 8:22 PM
vladislavbelov added a comment to D4245: First iteration of CStr cleanup.
In D4245#180502, @Stan wrote:

Ok. We should find a way to test this patch with the _UNICODE defined like on OpenSuse.

Wed, Sep 1, 3:11 PM
vladislavbelov added a comment to D4245: First iteration of CStr cleanup.
In D4245#180492, @Stan wrote:

Would be nice to commit D4223 first if it's correct, because this patch might make rebasing complicated.

Wed, Sep 1, 2:48 PM
vladislavbelov requested review of D4245: First iteration of CStr cleanup.
Wed, Sep 1, 12:18 PM

Tue, Aug 31

vladislavbelov updated the diff for D4244: Forbids using more than 64 bones for GPU skinning.

Moves the assert above.

Tue, Aug 31, 6:46 PM
vladislavbelov added a comment to D4244: Forbids using more than 64 bones for GPU skinning.
In D4244#180458, @Stan wrote:

For OGL 3.3 deprecation it needs to work on macOS first. :)

Tue, Aug 31, 6:29 PM
vladislavbelov added a comment to D4244: Forbids using more than 64 bones for GPU skinning.
In D4244#180451, @Angen wrote:

Strange unrelated calltack from running vs, not happening without the diff:
1 vcruntime140.dll!memcpy() + 78 bytes
2 vcruntime140.dll![Frames below may be incorrect and/or missing, no symbols loaded for vcruntime140.dll]
3 [External Code]
4 nvtt.dll!nvtt::Surface::Private::Private(const nvtt::Surface::Private & p)
5 nvtt.dll!nvtt::Surface::detach()
6 nvtt.dll!nvtt::Surface::toGamma(float gamma)
7 nvtt.dll!nvtt::Compressor::Private::compress(const nvtt::InputOptions::Private & inputOptions, const nvtt::CompressionOptions::Private & compressionOptions, const nvtt::OutputOptions::Private & outputOptions)
8 nvtt.dll!nvtt::Compressor::process(const nvtt::InputOptions & inputOptions, const nvtt::CompressionOptions & compressionOptions, const nvtt::OutputOptions & outputOptions)
9 pyrogenesis.exe!CTextureConverter::RunThread(CTextureConverter * textureConverter)
10 pyrogenesis.exe!Threading::HandleExceptionsBase<&CTextureConverter::RunThread,void (__cdecl*)(CTextureConverter *)>::Wrapper(CTextureConverter * <args_0>)
11 [External Code]

Tue, Aug 31, 5:52 PM
vladislavbelov added a comment to D4244: Forbids using more than 64 bones for GPU skinning.
In D4244#180446, @Angen wrote:

It crashes on unit demo without writing/displaying any error, crashdump is 0kb

Tue, Aug 31, 5:36 PM
vladislavbelov updated the diff for D4244: Forbids using more than 64 bones for GPU skinning.

Adds @Angen suggestion.

Tue, Aug 31, 5:21 PM
vladislavbelov added a comment to D4244: Forbids using more than 64 bones for GPU skinning.
In D4244#180438, @Stan wrote:

My point is that there is no way we can lower the number of bones of some of the models armatures in the current state if there is no way to keep attachpoints :)

I don't remember.

Tue, Aug 31, 4:47 PM
vladislavbelov added a comment to D4244: Forbids using more than 64 bones for GPU skinning.
In D4244#180436, @Stan wrote:

Well it matters a lot for artists since we basically have to duplicate bones to have objects like swords helmets etc.

GPU doesn't care about artists. It just have a limited amount of memory for uniforms.

Tue, Aug 31, 4:29 PM
vladislavbelov added a comment to D4244: Forbids using more than 64 bones for GPU skinning.
In D4244#180434, @Stan wrote:

Does that count prop bones ?

Tue, Aug 31, 3:57 PM
vladislavbelov requested review of D4244: Forbids using more than 64 bones for GPU skinning.
Tue, Aug 31, 3:17 PM

Aug 23 2021

vladislavbelov added inline comments to rP25854: Fix updating existing mods.
Aug 23 2021, 9:19 AM

Aug 4 2021

vladislavbelov added inline comments to D3037: Add gui scale to options.
Aug 4 2021, 9:20 AM

Aug 2 2021

vladislavbelov added a comment to rP25843: Fix loading grayscale heightmaps for RM maps..

I would argue against it, as the transformation is less efficient. For that matter, I'm not entirely sure we actually need to transform much here.

Aug 2 2021, 3:41 PM
vladislavbelov added a comment to rP25843: Fix loading grayscale heightmaps for RM maps..

The commit can be reverted after fixing the bug in the tex.cpp. Reported the original bug in #5022.

Aug 2 2021, 9:40 AM

Jul 31 2021

vladislavbelov added inline comments to rP25844: Fix units changing appearance when switching animation..
Jul 31 2021, 8:01 PM
vladislavbelov added inline comments to D4203: Fix loading grayscale heightmaps for RM maps..
Jul 31 2021, 7:44 PM
vladislavbelov added inline comments to D4203: Fix loading grayscale heightmaps for RM maps..
Jul 31 2021, 6:51 PM
vladislavbelov added inline comments to D4203: Fix loading grayscale heightmaps for RM maps..
Jul 31 2021, 6:23 PM

Jun 21 2021

vladislavbelov resigned from rP25308: Hotloading fix after rP25210.
Jun 21 2021, 1:57 PM

Jun 20 2021

vladislavbelov requested verification of rP25711: Implements configurable cascade shadows..

Fixed in rP25794.

Jun 20 2021, 10:59 PM

Jun 16 2021

vladislavbelov raised a concern with rP25308: Hotloading fix after rP25210.
Jun 16 2021, 3:12 PM

Jun 13 2021

vladislavbelov committed rP25794: Fixes big screenshots, implements CCamera::GetViewQuad properly for custom….
Fixes big screenshots, implements CCamera::GetViewQuad properly for custom…
Jun 13 2021, 7:42 PM
vladislavbelov closed D4165: Fixes big screenshots.
Jun 13 2021, 7:42 PM

Jun 12 2021

vladislavbelov requested review of D4165: Fixes big screenshots.
Jun 12 2021, 10:23 PM
vladislavbelov added a comment to D4159: Update map previews..

Oh, I was mostly thinking about actual disk space, not GPU memory.

Nah, our disk space waste is much bigger than just UI previews. But previews add own wasted space as well.

Jun 12 2021, 4:45 PM
vladislavbelov added a comment to D4159: Update map previews..

Also some of our previews have alpha channel which is useless.

Jun 12 2021, 4:34 PM
vladislavbelov added a comment to D4159: Update map previews..

Mh, would it really matter? The individual PNGs are about 160Kb each. At best we'd gain 1-2 MB total maybe?

Sure, in total we leak 40MB of GPU memory. So we can save 20MB.

Jun 12 2021, 4:27 PM
vladislavbelov added a comment to D4159: Update map previews..

I think our previews are bad in terms of wasting space. They can be easily reduced to 512x256 without quality loss.

Jun 12 2021, 4:10 PM

Jun 11 2021

gameboy awarded D3905: Fixes the original cause of the red water a Heartbreak token.
Jun 11 2021, 9:11 AM

Jun 10 2021

vladislavbelov added a comment to D3933: Make CMatrix3D::operator*= behave as expected..

Related thing: https://wildfiregames.com/forum/topic/13163-cmatrix3d-multiplication

Jun 10 2021, 1:21 PM

Jun 9 2021

vladislavbelov added a comment to D3646: Debundle Valgrind and make it optional.

According to the Valgrind website, they don't - and probably never will - support Windows systems[1], so I've also made it non-Windows option.

Jun 9 2021, 11:04 PM

Jun 8 2021

vladislavbelov added inline comments to D4138: Fix game hanging when NVTT is disabled.
Jun 8 2021, 10:44 PM
vladislavbelov committed rP25749: Draws all characters for a very long text of the same style..
Draws all characters for a very long text of the same style.
Jun 8 2021, 8:17 PM
vladislavbelov closed D4120: Draw all chars for a very long text of the same style.
Jun 8 2021, 8:17 PM
vladislavbelov added a comment to D4114: Prevent OOM crash in Reference Tree on error.

Agree with C++ changes.

Jun 8 2021, 11:03 AM
vladislavbelov added a comment to D4107: new loading tips.

The images from Barracks, Stable, Elephant stable and Heroes look a bit too dark. For the Stable and the Elephant Stable, the rank symbols are not as clearly visible as in the Barracks image.

Agree, too dark and rank images have low resolutions.

Jun 8 2021, 10:08 AM
vladislavbelov requested review of D4120: Draw all chars for a very long text of the same style.
Jun 8 2021, 12:28 AM

Jun 7 2021

vladislavbelov committed rP25735: Fixes an old bug with missed handle appeared in rP25709..
Fixes an old bug with missed handle appeared in rP25709.
Jun 7 2021, 8:45 PM
vladislavbelov closed D4115: Fixes missed handle appeared in rP25709.
Jun 7 2021, 8:45 PM
vladislavbelov added inline comments to D3933: Make CMatrix3D::operator*= behave as expected..
Jun 7 2021, 8:24 PM
vladislavbelov requested review of D4115: Fixes missed handle appeared in rP25709.
Jun 7 2021, 7:01 PM
nani awarded D4108: Adds FreeType support to the engine a Love token.
Jun 7 2021, 6:52 PM
nani awarded D4108: Adds FreeType support to the engine a Love token.
Jun 7 2021, 6:52 PM
vladislavbelov requested verification of rP25709: Removes windows enumeration on Windows to retrieve HWND taking it from SDL and….

Actually the same bug can be achieved and before the patch, but it requires additional step.

Jun 7 2021, 6:46 PM
vladislavbelov added inline comments to D3933: Make CMatrix3D::operator*= behave as expected..
Jun 7 2021, 3:41 PM