Page MenuHomeWildfire Games

vladislavbelov (Vladislav Belov)
User

User Details

User Since
Feb 3 2017, 10:51 PM (199 w, 3 d)

Recent Activity

Yesterday

vladislavbelov added inline comments to D3162: Added initial support of MCST Elbrus 2000 (e2k) CPU architecture.
Mon, Nov 30, 11:26 PM

Sat, Nov 28

vladislavbelov added a member for Contributors: r-a-sattarov.
Sat, Nov 28, 10:41 PM
vladislavbelov added a comment to D3162: Added initial support of MCST Elbrus 2000 (e2k) CPU architecture.

Does it work smoothly on Elbrus?

Sat, Nov 28, 10:40 PM
vladislavbelov added inline comments to D3161: Improve bundle-creation script to include Windows installer.
Sat, Nov 28, 8:56 PM
vladislavbelov requested review of D3160: Using same value for unit and terrain ambient colors #3: scenarios maps..
Sat, Nov 28, 6:12 PM
vladislavbelov added inline comments to D3141: Approach build animation.
Sat, Nov 28, 5:30 PM

Fri, Nov 27

vladislavbelov added inline comments to D3156: Fix copy pasting in console..
Fri, Nov 27, 5:50 PM
vladislavbelov added inline comments to D2757: i18n scripts - switch from pology to Babel for .POT generation and update to python3.
Fri, Nov 27, 2:53 PM
vladislavbelov added a comment to rP24261: Silence warnings about unused result..

Would you maybe be OK with something like this (not necessarily that name or operator)

[[nodiscard]] int toto()
{
    return 5;
}

struct with_unused_result {};
template <typename T>
void operator>>(with_unused_result, const T& ref) {}

int main()
{
    with_unused_result{} >> toto();
    return 0;
}

I'd rather not have to wrap the whole function, but I do take your point that it could be vaguely ambiguous (with admittedly weird code).

Looks ok but still doesn't work for some cases, like with_unused_result{} >> func1() && func2_if_func1_succeeded.

Fri, Nov 27, 2:04 PM
vladislavbelov added a comment to rP24261: Silence warnings about unused result..

I'd disagree. UNUSED2 is necessary for unused local variables and such. In this instance, (void) ought to be enough, and we were already using it, so there was already a duplication of usage.

In the current implementation - yes, they're slightly different. But in fact we use the UNUSED2 macro for 2 reasons: 1) unused function result 2) hiding unused argument. 1) is solved by UNUSED_RESULT 2) is more a design problem - because it's adds implicit dependency with additional code changes, hence should be avoided.

Fri, Nov 27, 1:37 PM
vladislavbelov raised a concern with rP24261: Silence warnings about unused result..

I raise a concern to not forget to fix it before release. It's not a real concern, but pretty important for a code health.

Fri, Nov 27, 1:04 PM
vladislavbelov added a comment to rP24261: Silence warnings about unused result..

The idea is good but the implementation is controversial. We already have a macro called UNUSED2 for that cases, so the change introduces a code duplication. I think the name DISCARD is too broad, because it's not clear what to discard: the whole call or the only result. In my opinion the good implementation and naming is in chromium. Also the usage might be unsafe because it requires space and hence all related to macros issues.

Fri, Nov 27, 1:02 PM

Wed, Nov 25

vladislavbelov added a comment to D3142: Using same value for unit and terrain ambient colors #2: skirmishes maps..
In D3142#138536, @Stan wrote:

punjab 2p
bdeska bog
barcania
corsica
median oasis
nearestearn badlands
nile river
The list above are the maps where I think unit color is better. For the rest terrain ambient is IMHO.

Agree, + caspian_sea_2pv2p.

Wed, Nov 25, 9:45 PM
vladislavbelov added inline comments to rP24238: Fix OS detection on Windows 10..
Wed, Nov 25, 7:50 PM
vladislavbelov added a comment to rP24250: Add vs2017 to svnignore folders..

Seems incorrect, you add svn:global-ignore for vs2017, but vs2015 has just svn:ignore. They should have similar types, and I suppose it's svn:ignore, because of immediate children.

Wed, Nov 25, 3:22 PM
vladislavbelov requested review of D3142: Using same value for unit and terrain ambient colors #2: skirmishes maps..
Wed, Nov 25, 12:43 AM

Tue, Nov 24

vladislavbelov requested changes to D3138: Fix AA / Sharpness not being correctly enabled at the start..

That breaks/not fixes MSAA.

Tue, Nov 24, 8:16 PM

Mon, Nov 23

vladislavbelov raised a concern with rP22649: pthread -> std::thread (3/7) - Replace pthread in other engine files.

That commit breaks crash/exception handling on Windows. So any error happened in the std::thread aren't handled and reported. That must be fixed.

Mon, Nov 23, 7:55 PM

Sun, Nov 22

vladislavbelov added a comment to D2420: Fix OS hardware detection on windows..

The function doesn't work for compatibility mode, it hides the real system. It's ok for the features detecting, but bad for statistics.

Sun, Nov 22, 7:03 PM
vladislavbelov added inline comments to rP24233: Fix rendering options failures following rP24228.
Sun, Nov 22, 12:18 PM
vladislavbelov added a comment to D3075: Identify host session via being on the same process..

This is essentially what this diff does though. Except there's no "passing" since the server can 'peek' via being in the same process. Doesn't work for dedicated servers but I don't think it's a huge concern.

That sounds a bit unsafe. Since two parallel object creations depend on the global state. When you create NetClient and NetServer you know that they're on the same machine/in the same process. Why do you need to hide it and delay it?

Sun, Nov 22, 1:10 AM
vladislavbelov added inline comments to rP24228: Allow registering hooks that trigger on config changes..
Sun, Nov 22, 1:04 AM
vladislavbelov added inline comments to D3131: Fix assertion failure in rP24228 caused by a race condition..
Sun, Nov 22, 1:02 AM

Sat, Nov 21

vladislavbelov added inline comments to rP24228: Allow registering hooks that trigger on config changes..
Sat, Nov 21, 5:38 PM
vladislavbelov added a comment to D3075: Identify host session via being on the same process..

So it does auth correctly on if ps_generate_guid() will be the same for client and server? So it might mean that someone can relatively easily generate it? Why to not generate a GUID with some randomness before and pass it to both?

Sat, Nov 21, 5:03 PM
vladislavbelov added a comment to rP18140: Network cleanup, fixes #3953..
Sat, Nov 21, 5:03 PM

Tue, Nov 17

vladislavbelov added inline comments to D2420: Fix OS hardware detection on windows..
Tue, Nov 17, 11:50 PM
vladislavbelov added inline comments to D3106: Add a hashing function for CStr8 & CStrW.
Tue, Nov 17, 11:20 AM

Mon, Nov 16

vladislavbelov committed rP24194: Using same value for unit and terrain ambient colors for random maps..
Using same value for unit and terrain ambient colors for random maps.
Mon, Nov 16, 9:41 PM
vladislavbelov closed D3079: Using same value for unit and terrain ambient colors #1: random maps..
Mon, Nov 16, 9:40 PM
vladislavbelov added inline comments to D3107: Update random_shuffle usage for C++17.
Mon, Nov 16, 8:02 PM
vladislavbelov added inline comments to D3107: Update random_shuffle usage for C++17.
Mon, Nov 16, 7:39 PM
vladislavbelov added inline comments to D3103: Fix rP24185.
Mon, Nov 16, 7:24 PM

Sun, Nov 15

vladislavbelov committed rP24188: Adds MSAA to anti-aliasing techniques..
Adds MSAA to anti-aliasing techniques.
Sun, Nov 15, 9:09 PM
vladislavbelov closed D2812: Adds MSAA to anti-aliasing techniques.
Sun, Nov 15, 9:08 PM
vladislavbelov added a comment to D3093: Improve JS Exception handling..

Further, SM52 removes the ErrorReporter (it comes back in future versions, I believe).

Have you checked it?

Sun, Nov 15, 4:47 PM
vladislavbelov added inline comments to D3103: Fix rP24185.
Sun, Nov 15, 11:34 AM
vladislavbelov added a comment to D3104: Deactivate RTTI in all C++ projects except AtlasUI on all platforms.

Does it add a compilation error on dynamic_cast usage?

Sun, Nov 15, 11:27 AM
vladislavbelov added inline comments to D3103: Fix rP24185.
Sun, Nov 15, 11:17 AM
vladislavbelov added inline comments to D14: [RC] Thread the pathfinder computations.
Sun, Nov 15, 2:08 AM
vladislavbelov added inline comments to rP24185: Optimize the GUI event broadcast.
Sun, Nov 15, 12:36 AM

Sat, Nov 14

vladislavbelov added a comment to D14: [RC] Thread the pathfinder computations.
In D14#136177, @Kuba386 wrote:

Aren't we already using a thread pool?
We create a few threads during initialization of pathfinder component and they stay running until component is destroyed.
Isn't that what thread pool is?

Kind of, but my point isn't about the local thread pool, but a single thread pool for the whole application.

Sat, Nov 14, 11:44 PM
vladislavbelov added inline comments to rP24185: Optimize the GUI event broadcast.
Sat, Nov 14, 11:40 PM
vladislavbelov added inline comments to rP24185: Optimize the GUI event broadcast.
Sat, Nov 14, 11:14 PM
vladislavbelov added inline comments to rP24185: Optimize the GUI event broadcast.
Sat, Nov 14, 11:12 PM

Fri, Nov 13

vladislavbelov added inline comments to D3096: Fix notes in rP24161..
Fri, Nov 13, 3:22 PM
vladislavbelov added inline comments to rP24167: Use Symbols to store JS object references when serialising and delete….
Fri, Nov 13, 3:21 PM
vladislavbelov added inline comments to rP24171: Encapsulate runtime creation..
Fri, Nov 13, 3:15 PM
vladislavbelov added a comment to D14: [RC] Thread the pathfinder computations.

I think the current design of threading isn't that we should target on. It allocates the amount of path finder threads around to the number of cores. That means that if we want to use threads extensively for other parts (and we already somehow use for some parts) then we might have performance penalties because of context switches and memory consumption.

Fri, Nov 13, 10:53 AM

Wed, Nov 11

vladislavbelov added inline comments to rP24161: Store turret positions in map files..
Wed, Nov 11, 8:54 PM
vladislavbelov updated the diff for D2812: Adds MSAA to anti-aliasing techniques.

Fixes transparent objects and macOS.

Wed, Nov 11, 8:42 PM
vladislavbelov committed rP24160: Removes additional depth texture copying and reusing existing refraction depth..
Removes additional depth texture copying and reusing existing refraction depth.
Wed, Nov 11, 7:47 PM
vladislavbelov closed D3084: Removes additional depth texture copying and reusing existing refraction depth.
Wed, Nov 11, 7:47 PM
vladislavbelov added a comment to D3084: Removes additional depth texture copying and reusing existing refraction depth.

I think at this point you might consider removing the "real depth" setting entirely, it's pretty much free with refraction and it looks _so_ much better that it's not funny.

I agree, maybe in next patches.

Wed, Nov 11, 7:12 PM
vladislavbelov added a comment to D2812: Adds MSAA to anti-aliasing techniques.

Quick somewhat related question: how difficult would it be to implement rendering on an arbitrary multiple of the game's resolution?

In terms of rendering - not hard.

Wed, Nov 11, 10:57 AM

Tue, Nov 10

vladislavbelov set the repository for D3084: Removes additional depth texture copying and reusing existing refraction depth to rP 0 A.D. Public Repository.
Tue, Nov 10, 11:39 PM
vladislavbelov requested review of D3084: Removes additional depth texture copying and reusing existing refraction depth.
Tue, Nov 10, 11:38 PM
vladislavbelov added a comment to D3079: Using same value for unit and terrain ambient colors #1: random maps..

I think I prefer lighter only for polar sea.

Tue, Nov 10, 7:19 PM

Mon, Nov 9

vladislavbelov requested review of D3079: Using same value for unit and terrain ambient colors #1: random maps..
Mon, Nov 9, 9:51 PM
vladislavbelov committed rP24154: Fixes terrain overlays by removing fixed pipeline dependency..
Fixes terrain overlays by removing fixed pipeline dependency.
Mon, Nov 9, 7:51 PM
vladislavbelov closed D3074: Fixes terrain overlays by removing fixed pipeline dependency.
Mon, Nov 9, 7:51 PM
vladislavbelov added inline comments to rP17746: Correct handling of replays with no turns or only turn 0..
Mon, Nov 9, 4:29 PM
vladislavbelov added inline comments to rP17746: Correct handling of replays with no turns or only turn 0..
Mon, Nov 9, 2:58 PM
vladislavbelov requested review of D3074: Fixes terrain overlays by removing fixed pipeline dependency.
Mon, Nov 9, 1:15 AM

Sun, Nov 8

vladislavbelov committed rP24145: Moves foam calculation into a separate function and fixes its lighting..
Moves foam calculation into a separate function and fixes its lighting.
Sun, Nov 8, 11:19 PM
vladislavbelov closed D3071: Moves foam calculation into a separate function and fixes its lighting.
Sun, Nov 8, 11:18 PM
vladislavbelov added inline comments to D2848: NetClient Threading.
Sun, Nov 8, 9:14 PM
vladislavbelov committed rP24144: Refactors coordinates of SOverlayTexturedLine, replaces array of floats by….
Refactors coordinates of SOverlayTexturedLine, replaces array of floats by…
Sun, Nov 8, 3:48 PM
vladislavbelov closed D3072: Refactors coordinates of SOverlayTexturedLine.
Sun, Nov 8, 3:48 PM
vladislavbelov committed rP24143: Adds wireframe mode to overlays and replace the private m_TerrainRenderMode….
Adds wireframe mode to overlays and replace the private m_TerrainRenderMode…
Sun, Nov 8, 12:33 PM
vladislavbelov committed rP24141: Adds a LOS mask to Minimap..
Adds a LOS mask to Minimap.
Sun, Nov 8, 9:53 AM
vladislavbelov closed D2216: Adds a LOS mask to Minimap.
Sun, Nov 8, 9:52 AM
vladislavbelov added inline comments to rP24120: Add num pad hotkey equivalents..
Sun, Nov 8, 8:36 AM

Sat, Nov 7

vladislavbelov committed rP24140: Calculates LOS texture coordinates in shaders for overlay lines only if needed..
Calculates LOS texture coordinates in shaders for overlay lines only if needed.
Sat, Nov 7, 10:35 PM
vladislavbelov added inline comments to rP24120: Add num pad hotkey equivalents..
Sat, Nov 7, 10:37 AM
vladislavbelov added inline comments to D3029: add num pad hotkey equivalents.
Sat, Nov 7, 10:36 AM

Fri, Nov 6

vladislavbelov added a comment to D3053: Fix gamesetup error when persisted-match-settings are broken..

You're right, you actually have to autostart it, too. Which isn't easy to trigger without D11.

Fri, Nov 6, 9:11 PM
vladislavbelov added inline comments to D3051: Let GUI elements change the cursor when hovered.
Fri, Nov 6, 7:52 PM
vladislavbelov added inline comments to D3057: Do not use g_FrequencyFilter to calculate the real frame time..
Fri, Nov 6, 7:45 PM
vladislavbelov added inline comments to D2293: Allow code to register hooks which get called whenever a function value changes, use this to clean rendering options further..
Fri, Nov 6, 7:41 PM
vladislavbelov added inline comments to D2726: AMD Ryzen fix.
Fri, Nov 6, 7:26 PM
vladislavbelov added inline comments to D2726: AMD Ryzen fix.
Fri, Nov 6, 7:25 PM
vladislavbelov added a comment to D3064: Update the pathfinder grid before computing paths 'in-between' turns..

How it behaves in atlas?

Fri, Nov 6, 7:23 PM

Thu, Nov 5

vladislavbelov added inline comments to D3061: Avoid overflow in UnitMotion.
Thu, Nov 5, 9:32 PM
vladislavbelov added inline comments to D2726: AMD Ryzen fix.
Thu, Nov 5, 8:35 PM
vladislavbelov committed rP24134: Refactors water shader and move normal and specular calculations into separate….
Refactors water shader and move normal and specular calculations into separate…
Thu, Nov 5, 6:47 PM
vladislavbelov closed D3040: Refactors water shader and move normal and specular calculations into separate functions.
Thu, Nov 5, 6:47 PM

Wed, Nov 4

vladislavbelov committed rP24130: Replacing losMap usages by existed and more consistent losTex..
Replacing losMap usages by existed and more consistent losTex.
Wed, Nov 4, 11:55 PM
vladislavbelov committed rP24129: Moves simple water from fixed pipeline to shader pipelines (ARB/GLSL)..
Moves simple water from fixed pipeline to shader pipelines (ARB/GLSL).
Wed, Nov 4, 11:25 PM
vladislavbelov closed D3059: Moves fixed water to shaders ARB/GLSL.
Wed, Nov 4, 11:25 PM
vladislavbelov added inline comments to D3059: Moves fixed water to shaders ARB/GLSL.
Wed, Nov 4, 11:04 PM
vladislavbelov resigned from rP19432: Fix the aiming code when performing an attack. Reviewed by wraitii..
Wed, Nov 4, 10:26 PM
vladislavbelov added inline comments to D2940: Move some position-related functions to PositionHelper..
Wed, Nov 4, 10:25 PM
vladislavbelov requested review of D3059: Moves fixed water to shaders ARB/GLSL.
Wed, Nov 4, 9:23 PM
vladislavbelov added inline comments to D2940: Move some position-related functions to PositionHelper..
Wed, Nov 4, 9:21 PM
vladislavbelov added inline comments to D2940: Move some position-related functions to PositionHelper..
Wed, Nov 4, 8:07 PM
vladislavbelov raised a concern with rP19432: Fix the aiming code when performing an attack. Reviewed by wraitii..
Wed, Nov 4, 7:38 PM
vladislavbelov added inline comments to D2940: Move some position-related functions to PositionHelper..
Wed, Nov 4, 7:09 PM
vladislavbelov added inline comments to D2940: Move some position-related functions to PositionHelper..
Wed, Nov 4, 7:03 PM
vladislavbelov committed rP24126: Little cleanup of PatchRData by reordering includes and correctly formats some….
Little cleanup of PatchRData by reordering includes and correctly formats some…
Wed, Nov 4, 4:53 PM