Page MenuHomeWildfire Games

vladislavbelov (Vladislav Belov)
User

User Details

User Since
Feb 3 2017, 10:51 PM (124 w, 3 d)

Recent Activity

Sun, Jun 23

vladislavbelov committed rP22395: Makes rendering helpers (culling camera, frustums) be available through the….
Makes rendering helpers (culling camera, frustums) be available through the…
Sun, Jun 23, 10:18 PM
vladislavbelov closed D1972: Makes some rendering helpers be available through the developer overlay..
Sun, Jun 23, 10:18 PM
vladislavbelov raised a concern with rP22351: Prevent UnitMotion from stopping on its own, and rename "MoveCompleted" to….
Sun, Jun 23, 2:49 AM

Sat, Jun 22

vladislavbelov added inline comments to D1991: simulation2: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions.
Sat, Jun 22, 12:24 PM
vladislavbelov updated subscribers of D1991: simulation2: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions.

Did you reproduce @Itms steps before the patch?

Sat, Jun 22, 2:34 AM

Fri, Jun 21

vladislavbelov added a comment to D1988: Workaround differences between libc and libstd string stream parsing of float/doubles.

I would certainly hope none otherwise MacOS has been behaving wrong for years.
The only place I can think of that parses strings to number is GUI sizes, which would previously parse things like "3b" as "0" instead of the 'correct' "3". I don't think there's mods or 0 A.D. code that relied on that - and I'm not sure we want that code to live.

Do we really need that behaviour for wrong strings?

Fri, Jun 21, 10:24 PM
vladislavbelov requested changes to D1988: Workaround differences between libc and libstd string stream parsing of float/doubles.

How many lines of our code depend on this behaviour (that wrong strings are still parsed)?

Fri, Jun 21, 9:11 PM
vladislavbelov accepted D1985: Skybox calculation - fix regression of rP22039 introduced in rP22297.

I tested, now the reflection works as after my commit.

Fri, Jun 21, 6:00 PM
vladislavbelov added inline comments to rP22297: Water GLSL shader improvements around reflections and whitespace fixes..
Fri, Jun 21, 5:50 PM

Sat, Jun 15

vladislavbelov added a reviewer for D1985: Skybox calculation - fix regression of rP22039 introduced in rP22297: vladislavbelov.
Sat, Jun 15, 10:06 PM
vladislavbelov raised a concern with rP22297: Water GLSL shader improvements around reflections and whitespace fixes..
Sat, Jun 15, 9:49 PM
vladislavbelov added inline comments to D1978: tests: Fix cppformat failures on osx (locale-related).
Sat, Jun 15, 8:09 PM
vladislavbelov added inline comments to D1978: tests: Fix cppformat failures on osx (locale-related).
Sat, Jun 15, 7:48 PM
vladislavbelov added a comment to D1976: Remove gamma ramp setting..
In D1976#82463, @Stan wrote:

custom color space might be weird, since the following code would be messing it up :P

It depends, because color correction may present on each side: os, gpu driver, monitor.

Sat, Jun 15, 4:49 PM
vladislavbelov added a comment to D1976: Remove gamma ramp setting..

I think the patch should be tested on multi-monitor environment and with a custom color space.

Sat, Jun 15, 4:45 PM

Wed, Jun 12

Stan awarded D1972: Makes some rendering helpers be available through the developer overlay. a Love token.
Wed, Jun 12, 10:41 PM
vladislavbelov created D1972: Makes some rendering helpers be available through the developer overlay..
Wed, Jun 12, 10:39 PM
vladislavbelov committed rP22372: Cleanups BoundingBoxAxisAligned and fixes coding styles a bit..
Cleanups BoundingBoxAxisAligned and fixes coding styles a bit.
Wed, Jun 12, 10:23 PM
vladislavbelov closed D1951: Cleanups BoundingBoxAxisAligned before refactoring.
Wed, Jun 12, 10:23 PM
vladislavbelov committed rP22371: Fixes includes and forward declarations in CPatchRData..
Fixes includes and forward declarations in CPatchRData.
Wed, Jun 12, 10:03 PM
vladislavbelov closed D1952: Fixes includes and forward declarations in CPatchRData.
Wed, Jun 12, 10:03 PM
vladislavbelov committed rP22370: Refactors Developer Overlay using an object instead of global functions..
Refactors Developer Overlay using an object instead of global functions.
Wed, Jun 12, 9:22 PM
vladislavbelov closed D1928: Refactors Developer Overlay.
Wed, Jun 12, 9:22 PM
vladislavbelov added inline comments to D1928: Refactors Developer Overlay.
Wed, Jun 12, 2:53 PM
vladislavbelov added inline comments to D1928: Refactors Developer Overlay.
Wed, Jun 12, 12:28 PM
vladislavbelov added inline comments to D1928: Refactors Developer Overlay.
Wed, Jun 12, 1:01 AM

Tue, Jun 11

nani awarded D1928: Refactors Developer Overlay a Dat Boi token.
Tue, Jun 11, 11:25 PM
vladislavbelov updated the diff for D1928: Refactors Developer Overlay.

Fixes "check".

Tue, Jun 11, 10:46 PM
vladislavbelov added inline comments to D1928: Refactors Developer Overlay.
Tue, Jun 11, 10:01 PM
vladislavbelov added a comment to D1928: Refactors Developer Overlay.

@wraitii @elexis I'm going to commit it if you don't have other objections.

Tue, Jun 11, 8:52 PM
vladislavbelov added inline comments to D1955: Support for phenotype-tag in VisualActor..
Tue, Jun 11, 8:51 PM

Sun, Jun 9

vladislavbelov added inline comments to D1928: Refactors Developer Overlay.
Sun, Jun 9, 1:28 AM
vladislavbelov updated the diff for D1928: Refactors Developer Overlay.

Fixes notes.

Sun, Jun 9, 1:28 AM

Sat, Jun 8

vladislavbelov added inline comments to D1955: Support for phenotype-tag in VisualActor..
Sat, Jun 8, 6:03 PM
vladislavbelov updated the diff for D1928: Refactors Developer Overlay.

Adds usage of setChangePerspective.

Sat, Jun 8, 5:46 PM
elexis awarded D1928: Refactors Developer Overlay a Like token.
Sat, Jun 8, 3:55 PM
vladislavbelov added inline comments to D1928: Refactors Developer Overlay.
Sat, Jun 8, 2:52 PM
vladislavbelov added inline comments to D1928: Refactors Developer Overlay.
Sat, Jun 8, 2:03 PM
vladislavbelov added inline comments to D1928: Refactors Developer Overlay.
Sat, Jun 8, 1:49 AM

Fri, Jun 7

vladislavbelov added inline comments to D1928: Refactors Developer Overlay.
Fri, Jun 7, 11:01 PM
vladislavbelov added inline comments to D1928: Refactors Developer Overlay.
Fri, Jun 7, 9:46 PM
vladislavbelov added inline comments to D1955: Support for phenotype-tag in VisualActor..
Fri, Jun 7, 9:34 PM
vladislavbelov added inline comments to D1781: Fix chat performance issue..
Fri, Jun 7, 8:43 PM
vladislavbelov added a comment to rP22344: Clean up ThreadUtil, use standard C++11 constructs instead of custom ones..

@wraitii could you check that?

Fri, Jun 7, 8:14 PM
vladislavbelov added a comment to rP22344: Clean up ThreadUtil, use standard C++11 constructs instead of custom ones..
In rP22344#33832, @Stan wrote:

I probably should have asked that before, but wasn't std::thread broken/missing features on windows ? https://stackoverflow.com/questions/13134186/c11-stdthreads-vs-posix-threads

Fri, Jun 7, 6:11 PM
vladislavbelov added a comment to rP22344: Clean up ThreadUtil, use standard C++11 constructs instead of custom ones..

I don't understand the question, sorry?

Fri, Jun 7, 3:53 PM
vladislavbelov added a comment to rP22344: Clean up ThreadUtil, use standard C++11 constructs instead of custom ones..

Why pthread_t was replaced only for the main thread and not for workers?

Fri, Jun 7, 3:38 PM
vladislavbelov added a comment to D1928: Refactors Developer Overlay.

This is kind of blurring the sort of MVC pattern we had before. Now the part updating the GUI and the part holding the state are in the same component. It's not necessarily an issue (particularly here since this component isn't intended to be re-usable elsewhere) but we should perhaps think of a more general solution.

Fri, Jun 7, 1:47 PM

Thu, Jun 6

vladislavbelov updated the diff for D1928: Refactors Developer Overlay.

Removes g_DevSettings.

Thu, Jun 6, 10:44 PM
vladislavbelov added inline comments to D1952: Fixes includes and forward declarations in CPatchRData.
Thu, Jun 6, 10:08 PM
vladislavbelov added a comment to rP22310: Fix red squares on some maps when using HQ water effects.

There really isn't a better way of doing that. Any given approximation of refraction isn't going to be much different from what we've got.

Yeah, that's what I'm talking about. It's just a little improvement. Though all these flat refraction maps are workarounds.

Thu, Jun 6, 10:04 PM
vladislavbelov added inline comments to D1952: Fixes includes and forward declarations in CPatchRData.
Thu, Jun 6, 9:57 PM

Wed, Jun 5

vladislavbelov updated the diff for D1928: Refactors Developer Overlay.
Wed, Jun 5, 11:49 PM
vladislavbelov updated the diff for D1928: Refactors Developer Overlay.

Fixes @elexis's notes.

Wed, Jun 5, 11:33 PM
vladislavbelov added inline comments to D1928: Refactors Developer Overlay.
Wed, Jun 5, 11:30 PM
vladislavbelov added inline comments to D1928: Refactors Developer Overlay.
Wed, Jun 5, 11:18 PM
vladislavbelov updated the diff for D1928: Refactors Developer Overlay.

Fixes missing file and notes.

Wed, Jun 5, 10:52 PM
vladislavbelov updated the diff for D1928: Refactors Developer Overlay.

Move the g_DeveloperOverlay creation to the session.js.

Wed, Jun 5, 10:27 PM
vladislavbelov committed rP22341: Fixes black water glitches for certain wind angles with the approximate….
Fixes black water glitches for certain wind angles with the approximate…
Wed, Jun 5, 10:13 PM
vladislavbelov closed D1804: Fixes black water glitches for certain wind angles.
Wed, Jun 5, 10:13 PM
vladislavbelov committed rP22340: Adds Camera test for ortho projection..
Adds Camera test for ortho projection.
Wed, Jun 5, 9:56 PM
vladislavbelov closed D1948: Adds Camera test for ortho projection.
Wed, Jun 5, 9:55 PM
vladislavbelov updated the diff for D1952: Fixes includes and forward declarations in CPatchRData.

Fixes compilation.

Wed, Jun 5, 9:50 PM
vladislavbelov added inline comments to D1952: Fixes includes and forward declarations in CPatchRData.
Wed, Jun 5, 9:40 PM
vladislavbelov added inline comments to D1948: Adds Camera test for ortho projection.
Wed, Jun 5, 8:39 PM
vladislavbelov added inline comments to D1951: Cleanups BoundingBoxAxisAligned before refactoring.
Wed, Jun 5, 8:36 PM
vladislavbelov added a comment to D1954: Do not send Reflection and Refraction matrices to shader when not needed.

WAT, why I commandered?

Wed, Jun 5, 4:24 PM
vladislavbelov commandeered D1954: Do not send Reflection and Refraction matrices to shader when not needed.

I agree that it's harder to read the code without indents for some people. Only objection that I'm thinking about, if you remove #if with leaving the code you need to fix the indents again that also means you rewrite the blame again.

Wed, Jun 5, 4:24 PM
vladislavbelov added a comment to D1928: Refactors Developer Overlay.

Just create an object literal.

var g_DeveloperOverlay = {};
g_DeveloperOverlay.init = function() {}

or

var g_DeveloperOverlay = {
   init = function () {}
};
Wed, Jun 5, 2:59 PM
vladislavbelov added a comment to rP22310: Fix red squares on some maps when using HQ water effects.

Well, red water problems are a longstanding issue. It occurs when it tries to draw areas outside of the water during refraction, and appears at certain angles for reasons that aren't easy to explain but probably have to do with the hack used to produce refraction.

Mostly because of scissoring #2692, but also we have inaccurate refraction projection (inaccurate in relation to the real refraction angles). We may calculate it more carefully.

Wed, Jun 5, 2:20 PM

Tue, Jun 4

vladislavbelov updated the diff for D1928: Refactors Developer Overlay.
Tue, Jun 4, 8:50 PM
vladislavbelov added inline comments to D1928: Refactors Developer Overlay.
Tue, Jun 4, 7:56 PM
vladislavbelov updated the diff for D1928: Refactors Developer Overlay.
Tue, Jun 4, 7:54 PM
vladislavbelov added inline comments to D1928: Refactors Developer Overlay.
Tue, Jun 4, 7:53 PM
vladislavbelov updated the diff for D1928: Refactors Developer Overlay.

Fixes notes.

Tue, Jun 4, 7:52 PM

Mon, Jun 3

vladislavbelov created D1952: Fixes includes and forward declarations in CPatchRData.
Mon, Jun 3, 10:30 PM
vladislavbelov requested verification of rP21612: A little cleanup of the PatchRData.cpp..
Mon, Jun 3, 10:27 PM
vladislavbelov committed rP22334: Fixes a typo introduced in rP21612 in shore calculations, found by Angen and….
Fixes a typo introduced in rP21612 in shore calculations, found by Angen and…
Mon, Jun 3, 10:19 PM
vladislavbelov closed D1949: Fixes mistypes introduced in rP21612.
Mon, Jun 3, 10:19 PM
vladislavbelov added a comment to D1812: Remove unused variable from ModelRenderer.

Thank you for the patch!

Mon, Jun 3, 10:07 PM
vladislavbelov committed rP22333: Removes unused variable from ModelRenderer introduced in rP11423. Found by….
Removes unused variable from ModelRenderer introduced in rP11423. Found by…
Mon, Jun 3, 10:07 PM
vladislavbelov closed D1812: Remove unused variable from ModelRenderer.
Mon, Jun 3, 10:07 PM
vladislavbelov created D1951: Cleanups BoundingBoxAxisAligned before refactoring.
Mon, Jun 3, 9:58 PM
vladislavbelov updated the summary of D1949: Fixes mistypes introduced in rP21612.
Mon, Jun 3, 9:21 PM
vladislavbelov created D1949: Fixes mistypes introduced in rP21612.
Mon, Jun 3, 9:21 PM
vladislavbelov created D1948: Adds Camera test for ortho projection.
Mon, Jun 3, 9:14 PM
vladislavbelov added inline comments to D1928: Refactors Developer Overlay.
Mon, Jun 3, 7:45 PM
vladislavbelov added a comment to D1928: Refactors Developer Overlay.

@elexis @wraitii Any thoughts about new (OOP) version of the overlay?

Mon, Jun 3, 7:20 PM

Fri, May 31

vladislavbelov added inline comments to D1939: redo rP21036, Create a ConfigDB_CreateAndWriteValueToFile function to absorb some duplication in the gui.
Fri, May 31, 7:54 PM
vladislavbelov added inline comments to D1781: Fix chat performance issue..
Fri, May 31, 11:22 AM
vladislavbelov added a comment to D1933: Don't pretend we implement a JS constructor for GUIObject..

Do we have places where the removed code might be useful? Why it was added?

Fri, May 31, 10:54 AM

Thu, May 30

vladislavbelov updated the diff for D1928: Refactors Developer Overlay.

Fixes @elexis notes.

Thu, May 30, 9:24 PM
vladislavbelov requested verification of rP22319: Adds Camera test for frustum..
Thu, May 30, 7:29 PM
vladislavbelov committed rP22321: Fixes tests compilation after rP22319. Found by Angen..
Fixes tests compilation after rP22319. Found by Angen.
Thu, May 30, 7:28 PM
vladislavbelov closed D1937: Fixes tests compilation after rP22319.
Thu, May 30, 7:28 PM
vladislavbelov added a comment to rP22319: Adds Camera test for frustum..

Created a fix in D1937.

Thu, May 30, 6:22 PM
vladislavbelov created D1937: Fixes tests compilation after rP22319.
Thu, May 30, 6:22 PM
vladislavbelov accepted D1934: Further cleanup for MikkTspace..
Thu, May 30, 6:15 PM
vladislavbelov added a comment to rP22319: Adds Camera test for frustum..
In rP22319#33628, @Stan wrote:

Nope, I was wrong, I thought std::fasbf already presents in C++11. But it doesn't. The include can be added too (though it already presents in the include tree).

Thu, May 30, 12:03 PM

Wed, May 29

vladislavbelov added inline comments to D1395: Handle UTF-8 multibyte characters in Atlas when loading from JSON.
Wed, May 29, 10:38 PM