- User Since
- Feb 3 2017, 10:51 PM (155 w, 1 d)
Tue, Jan 21
I've reproduced that assertion locally on macOS 10.14.6 in debug-mode. I've figured out the reason: it seems that OSAtomicAdd64 doesn't work as expected in debug mode, maybe address was misaligned.
Mon, Jan 20
Sun, Jan 19
Fixes @Stan notes.
Sat, Jan 18
Looks ok for me.
I've tested the patch on Windows VS2015, it works and looks good for me.
Fri, Jan 17
I've reviewed and tested the patch. It looks ok for me. I'm going to commit it soon (fixed years and GL types by myself).
Thu, Jan 16
The rest of the patch looks good for me.
Used CStr8 instead of std::string.
Adds division by zero test.
Wed, Jan 15
Did you use master version of release version (https://github.com/OGRECave/ogre/releases/tag/v1.12.4)?
Years. Also it's important to have a test for the new terrain functionality. But I suggest to split the patch and change the CTerrain and tests in a separate patch.
Tue, Jan 14
Mon, Jan 13
Sun, Jan 12
@Nescio I've tweaked the algorithm. Now it's a bit closer to your understanding. Now words separated by any non-letter characters should present in a name.
Tweaks the algorithm and adds an immediate reaction to the checkbox.
Sat, Jan 11
Wrong ref, right ref is D2476.
Fri, Jan 10
Nope, just wondering.
I'm going to commit removing of the system cursor soon.
Thu, Jan 9
What was in case !m_BoneMatrices && !anim->m_AnimDef before the patch? It seems it returns true.
I think it'd be useful to attach a side-by-side comparison image.
Wed, Jan 8
A bit unrelated to the patch, but I see the problem with the quarter of screen. Could you provide the system information (system_info.txt might be good)? Also do you have a system scale?
Tue, Jan 7
I can reorder it and have more useful items first.
That might happen.
Toggle the checkbox "Advanced search". Maybe it has misleading name.