Page MenuHomeWildfire Games

vladislavbelov (Vladislav Belov)
User

User Details

User Since
Feb 3 2017, 10:51 PM (288 w, 6 d)

Recent Activity

Yesterday

vladislavbelov updated the diff for D4768: Fixes TaskManager number of worker calculation.
Thu, Aug 18, 8:14 PM
vladislavbelov added a comment to D4768: Fixes TaskManager number of worker calculation.

And how well does your task manager work with zero threads?

Works fine as said above.

Thu, Aug 18, 5:14 PM
vladislavbelov added a comment to D4768: Fixes TaskManager number of worker calculation.
static_assert(MIN_THREADS > 0 && MIN_THREADS <= MAX_THREADS);
numberOfWorkers = Clamp(std::thread::hardware_concurrency(), MIN_THREADS, MAX_THREADS) - 1;

As pointed by Stan it's wrong.

Thu, Aug 18, 4:04 PM
vladislavbelov added a comment to D4768: Fixes TaskManager number of worker calculation.

That's not different with your patch.

That's not about my patch. That's about your sentence:

MIN_THREADS is always not zero: starting an application with zero threads has no sense.

Which is wrong for our case.

Thu, Aug 18, 3:05 PM
vladislavbelov added a comment to D4768: Fixes TaskManager number of worker calculation.

MIN_THREADS is always not zero: starting an application with zero threads has no sense.

Unfortunately because of implicitness it doesn't work how you imagine it. You can set both MIN_THREADS and MAX_THREADS to zero and it will work perfectly fine.

Thu, Aug 18, 2:09 PM
vladislavbelov added a comment to D4768: Fixes TaskManager number of worker calculation.

Why do we need an extra function GetDefaultNumberOfWorkers?

Explicit relation between hardware_concurrency and number of workers, might be clamped though.

Thu, Aug 18, 1:25 PM
vladislavbelov requested review of D4768: Fixes TaskManager number of worker calculation.
Thu, Aug 18, 12:13 PM

Wed, Aug 17

vladislavbelov updated the summary of D4756: Minor fixes for NSIS - Windows distribution script.
Wed, Aug 17, 1:04 PM
vladislavbelov updated the diff for D4756: Minor fixes for NSIS - Windows distribution script.

Reverts PDB.

Wed, Aug 17, 1:03 PM

Tue, Aug 16

vladislavbelov added a comment to D4764: vector of locale in L10n.

icu::Locale is about 200 bytes, if there is no too much vector resizing then changes make sense.

Tue, Aug 16, 5:07 PM
vladislavbelov added a comment to D4766: [WIP] PS::Execution.

I don't think to add a proposal interface is a good idea. We already have a plenty of code (not the best quality) to support. Also I prefer to have as simple interface as possible.

Tue, Aug 16, 4:49 PM
vladislavbelov added inline comments to D4705: Remove sys_generate_random_bytes.
Tue, Aug 16, 4:46 PM
vladislavbelov accepted D4765: Fix Mod.json issues..
Tue, Aug 16, 4:44 PM

Sun, Aug 14

vladislavbelov added a comment to D4761: remove cassert.

it does compile on all os. Ther might be some in architecture specivic code but a grep yields nothing.

Sun, Aug 14, 10:21 PM
vladislavbelov added a comment to D4761: remove cassert.

Have you checked MSVC output in case of an error?

Sun, Aug 14, 3:58 PM

Sat, Aug 13

vladislavbelov committed rP27049: Adds explicit z value for main menu buttons to workaround low resolutions to be….
Adds explicit z value for main menu buttons to workaround low resolutions to be…
Sat, Aug 13, 1:22 PM
vladislavbelov closed D4757: Workaround main menu buttons to be able to exit for low resolutions.
Sat, Aug 13, 1:22 PM

Thu, Aug 11

vladislavbelov requested review of D4757: Workaround main menu buttons to be able to exit for low resolutions.
Thu, Aug 11, 7:44 PM

Wed, Aug 10

vladislavbelov committed rP27041: Fixes crash in Atlas when switching from the Actor viewer. Fixes #6524.
Fixes crash in Atlas when switching from the Actor viewer. Fixes #6524
Wed, Aug 10, 7:22 PM
vladislavbelov closed D4732: Fix crash in Atlas when switching from the Actor viewer.
Wed, Aug 10, 7:21 PM

Thu, Aug 4

vladislavbelov updated the summary of D4732: Fix crash in Atlas when switching from the Actor viewer.
Thu, Aug 4, 10:36 PM
vladislavbelov updated the diff for D4732: Fix crash in Atlas when switching from the Actor viewer.
Thu, Aug 4, 10:34 PM
vladislavbelov commandeered D4732: Fix crash in Atlas when switching from the Actor viewer.
Thu, Aug 4, 10:34 PM
vladislavbelov added inline comments to D4705: Remove sys_generate_random_bytes.
Thu, Aug 4, 5:59 PM
vladislavbelov accepted D4677: span and string_view for CmdLineArgs.

LGTM.

Thu, Aug 4, 5:54 PM
vladislavbelov accepted D4741: Fix writing mod.json with non latin chars in path..
Thu, Aug 4, 5:30 PM

Mon, Jul 25

vladislavbelov added inline comments to D4743: Ignore broken symlinks.
Mon, Jul 25, 9:33 AM

Fri, Jul 22

vladislavbelov added inline comments to D4705: Remove sys_generate_random_bytes.
Fri, Jul 22, 1:03 PM

Thu, Jul 21

vladislavbelov added inline comments to D4705: Remove sys_generate_random_bytes.
Thu, Jul 21, 4:30 PM
vladislavbelov added inline comments to D4705: Remove sys_generate_random_bytes.
Thu, Jul 21, 12:54 PM

Jul 18 2022

vladislavbelov added inline comments to D4677: span and string_view for CmdLineArgs.
Jul 18 2022, 8:52 AM

Jul 17 2022

vladislavbelov added inline comments to D4677: span and string_view for CmdLineArgs.
Jul 17 2022, 5:03 PM
vladislavbelov added inline comments to D4677: span and string_view for CmdLineArgs.
Jul 17 2022, 12:43 PM
vladislavbelov accepted D4689: Cleanup CShaderParams::SItems comparisons.
Jul 17 2022, 12:25 PM
vladislavbelov added a comment to D4570: Use return values instead of out-parameters in source/graphics/Camera.cpp.

Might make sense to enable LTO before committing, because I'm not sure that returning Quad by value won't have copies with MSVC.

Jul 17 2022, 12:21 PM
vladislavbelov added a comment to D4705: Remove sys_generate_random_bytes.

Don't we have regression here?

Jul 17 2022, 12:19 PM

Jul 15 2022

vladislavbelov added a comment to D4734: Change feedback button color when enabled/disabled.

I agree that a red button looks like people shouldn't interact with it, or interact only in emergency.

Jul 15 2022, 1:11 PM · Contributors

Jun 23 2022

vladislavbelov accepted D4723: Performance fix for very high shadows on very large screens..

I can’t say it’s a performance fix, because the very high setting is for high-end hardware, where it works fine. It’s more like a logic fix.

Jun 23 2022, 2:39 PM

Jun 22 2022

vladislavbelov added inline comments to D4718: Allocator and generator for component data..
Jun 22 2022, 7:54 AM

Jun 21 2022

vladislavbelov added a comment to D4718: Allocator and generator for component data..

Single test replays isn’t enough for such kind of changes.

Jun 21 2022, 8:22 PM

Jun 20 2022

vladislavbelov added inline comments to D4706: [graphics] Adjust default config to give a better first impression.
Jun 20 2022, 12:36 AM

Jun 17 2022

vladislavbelov committed rP26950: Fixes same sequenced frames for LOS smooth textures. Fixes #6569.
Fixes same sequenced frames for LOS smooth textures. Fixes #6569
Jun 17 2022, 9:43 PM
vladislavbelov closed D4700: Fixes same frames for LOS smooth textures.
Jun 17 2022, 9:43 PM
vladislavbelov committed rP26949: Groups close minimap icons by path and color to decrease their visible count..
Groups close minimap icons by path and color to decrease their visible count.
Jun 17 2022, 9:41 PM
vladislavbelov closed D4702: Groups close minimap icons to decrease their visible count.
Jun 17 2022, 9:41 PM
vladislavbelov added inline comments to D4677: span and string_view for CmdLineArgs.
Jun 17 2022, 5:26 PM
vladislavbelov added inline comments to D4677: span and string_view for CmdLineArgs.
Jun 17 2022, 5:25 PM
vladislavbelov added inline comments to D4677: span and string_view for CmdLineArgs.
Jun 17 2022, 9:32 AM
vladislavbelov added a comment to D4689: Cleanup CShaderParams::SItems comparisons.

Please add a context to the patch. The patch looks ok.

Jun 17 2022, 8:15 AM

Jun 16 2022

vladislavbelov updated the diff for D4702: Groups close minimap icons to decrease their visible count.
Jun 16 2022, 5:27 PM
vladislavbelov added inline comments to D4702: Groups close minimap icons to decrease their visible count.
Jun 16 2022, 1:28 PM
vladislavbelov added inline comments to D4702: Groups close minimap icons to decrease their visible count.
Jun 16 2022, 9:29 AM
vladislavbelov updated the diff for D4702: Groups close minimap icons to decrease their visible count.
Jun 16 2022, 8:52 AM
vladislavbelov added inline comments to D4702: Groups close minimap icons to decrease their visible count.
Jun 16 2022, 8:51 AM

Jun 15 2022

vladislavbelov requested review of D4702: Groups close minimap icons to decrease their visible count.
Jun 15 2022, 8:49 PM

Jun 14 2022

vladislavbelov requested review of D4700: Fixes same frames for LOS smooth textures.
Jun 14 2022, 1:54 AM

Jun 12 2022

vladislavbelov added a comment to D4682: Profiler2 lives in main().

Is there generaly a need to remove ps/Singleton? should i also work on that?

By removing that you semantically won't remove singletons from the code, only safety checks.

Jun 12 2022, 6:35 PM
vladislavbelov added inline comments to D4667: Add JS bindings for in game camera attributes.
Jun 12 2022, 11:10 AM

Jun 9 2022

vladislavbelov committed rP26929: Adds EGL support for Wayland..
Adds EGL support for Wayland.
Jun 9 2022, 11:10 PM
vladislavbelov closed D4642: Add EGL support for Wayland.
Jun 9 2022, 11:09 PM

Jun 8 2022

vladislavbelov added inline comments to D4677: span and string_view for CmdLineArgs.
Jun 8 2022, 2:42 PM

Jun 7 2022

vladislavbelov updated the diff for D4642: Add EGL support for Wayland.
Jun 7 2022, 12:04 AM

Jun 6 2022

vladislavbelov committed rP26923: Fixes crash in LOSTexture because of incorrect nullptr check introduced in….
Fixes crash in LOSTexture because of incorrect nullptr check introduced in…
Jun 6 2022, 11:22 PM
vladislavbelov added inline comments to D4642: Add EGL support for Wayland.
Jun 6 2022, 11:05 PM
vladislavbelov requested verification of rP26906: Fixes A8 framebuffer format used for LOS interpolation and enables smooth LOS….

Fixed in rP26922.

Jun 6 2022, 10:59 PM
vladislavbelov committed rP26922: Fixes LOS flickering because of float precision. Fixes #6546.
Fixes LOS flickering because of float precision. Fixes #6546
Jun 6 2022, 10:48 PM
vladislavbelov closed D4684: Fixes LOS flickering because of float precision.
Jun 6 2022, 10:48 PM
vladislavbelov accepted D4688: Use CVector2D instead of float arrays.
Jun 6 2022, 9:35 PM
vladislavbelov committed rP26920: Removes GL types from regular renderer code after rP26850..
Removes GL types from regular renderer code after rP26850.
Jun 6 2022, 9:32 AM
vladislavbelov committed rP26919: Moves anisotropic filtering support check from GL texture to TextureManager to….
Moves anisotropic filtering support check from GL texture to TextureManager to…
Jun 6 2022, 9:08 AM
vladislavbelov updated the diff for D4684: Fixes LOS flickering because of float precision.

Added the same hack as for GLSL.

Jun 6 2022, 8:49 AM

Jun 3 2022

vladislavbelov requested review of D4684: Fixes LOS flickering because of float precision.
Jun 3 2022, 7:58 PM
vladislavbelov added inline comments to rP26915: Fix text alignment handling of spaces around wrapping..
Jun 3 2022, 6:31 PM
vladislavbelov added a comment to D4681: Fix shadow artifacts without shadow filtering in some A25 biomes/maps.

Isn't the ticket a bit of a 'wont fix' though? Seems to me under the current shadow technique & without filtering you can't really prevent such artefacts entirely, can you?

Yep, there are few possible ways.

Jun 3 2022, 6:27 PM
vladislavbelov added inline comments to rP26915: Fix text alignment handling of spaces around wrapping..
Jun 3 2022, 6:27 PM
vladislavbelov added a comment to D4681: Fix shadow artifacts without shadow filtering in some A25 biomes/maps.

It doesn't fix the ticket, so the ticket must not be closed. But the fix might be committed as soon as accepted until we have a proper solution.

Jun 3 2022, 10:24 AM

Jun 1 2022

vladislavbelov accepted D4675: [TaskManager] Minor cleanup in Future + TaskManager.

LGTM.

Jun 1 2022, 9:12 AM

May 30 2022

vladislavbelov added a comment to D4662: Fix text alignment handling of spaces around wrapping.

What happens if there multiple spaces in the end? It needs at least tests.

May 30 2022, 7:46 PM

May 27 2022

Langbart awarded D4654: Fixes A8 framebuffer format a Like token.
May 27 2022, 5:53 AM

May 26 2022

vladislavbelov added a comment to D4669: Use _SC_NPROCESSORS_ONLN to get available CPUs.
In D4669#198598, @Stan wrote:

This will affect the userreporter, do we care @vladislavbelov

May 26 2022, 9:08 PM
vladislavbelov committed rP26906: Fixes A8 framebuffer format used for LOS interpolation and enables smooth LOS….
Fixes A8 framebuffer format used for LOS interpolation and enables smooth LOS…
May 26 2022, 6:38 PM
vladislavbelov closed D4654: Fixes A8 framebuffer format.
May 26 2022, 6:38 PM

May 25 2022

vladislavbelov committed rP26904: Fixes double shader program reloading after rP26869..
Fixes double shader program reloading after rP26869.
May 25 2022, 7:34 PM
vladislavbelov added inline comments to D4667: Add JS bindings for in game camera attributes.
May 25 2022, 1:45 PM
vladislavbelov added inline comments to D4667: Add JS bindings for in game camera attributes.
May 25 2022, 1:40 PM

May 24 2022

vladislavbelov committed rP26902: Fixes rendering reflections and refractions in case of empty scissors..
Fixes rendering reflections and refractions in case of empty scissors.
May 24 2022, 9:15 PM
vladislavbelov updated the diff for D4654: Fixes A8 framebuffer format.
May 24 2022, 7:41 PM
vladislavbelov updated the diff for D4654: Fixes A8 framebuffer format.

Rebase.

May 24 2022, 6:48 PM
vladislavbelov committed rP26901: Adds instancing support to backend and enables it for minimap..
Adds instancing support to backend and enables it for minimap.
May 24 2022, 9:12 AM
vladislavbelov closed D4650: Adds instancing support to backend and enables it for minimap.
May 24 2022, 9:12 AM

May 23 2022

vladislavbelov added inline comments to D4614: Test for CFont.
May 23 2022, 9:57 PM
vladislavbelov added inline comments to D4614: Test for CFont.
May 23 2022, 9:33 PM
vladislavbelov added a comment to D4614: Test for CFont.

I moastly agree with you but I think a friend declaration is worse since it is not testable.

I'm not happy about both of them, but okay.

May 23 2022, 8:12 PM
vladislavbelov updated the diff for D4650: Adds instancing support to backend and enables it for minimap.

Fixes @Langbart note.

May 23 2022, 7:39 PM

May 19 2022

vladislavbelov added a comment to D4614: Test for CFont.

Ideally I'd prefer to not have back relation CFont > CFontManager (via callback). I don't think CFontManager being friend of CFont is worse than that, because it makes CFont a pure data holder without much logic.

May 19 2022, 11:49 AM
vladislavbelov added a comment to D4654: Fixes A8 framebuffer format.
  1. Apply the patch and compile the game -> OK
  2. Check that minimap looks like before with GL and GL ARB backends -> OK
  3. Check that map revealing looks like before -> OK

Thank you for testing!

May 19 2022, 11:48 AM

May 18 2022

vladislavbelov updated the diff for D4654: Fixes A8 framebuffer format.
May 18 2022, 7:58 PM
vladislavbelov updated the diff for D4654: Fixes A8 framebuffer format.
May 18 2022, 7:55 PM
vladislavbelov added a comment to D4654: Fixes A8 framebuffer format.

@vladislavbelov I wonder what this patch has changed? Please!

May 18 2022, 6:41 PM
vladislavbelov updated the diff for D4654: Fixes A8 framebuffer format.
May 18 2022, 6:40 PM