Page MenuHomeWildfire Games

vladislavbelov (Vladislav Belov)
User

User Details

User Since
Feb 3 2017, 10:51 PM (132 w, 1 d)

Recent Activity

Mon, Aug 12

vladislavbelov added inline comments to D2168: Move CGUI::GenerateText to CGUIText ctor and split into helper functions.
Mon, Aug 12, 1:35 AM

Sat, Aug 10

vladislavbelov accepted D2167: Split GUItext.h and CGUIString.h.
Sat, Aug 10, 9:09 PM
vladislavbelov added a comment to D2167: Split GUItext.h and CGUIString.h.

Why CGUIString, but _GUItext? Maybe rename that too?

Sat, Aug 10, 8:45 PM

Tue, Jul 30

vladislavbelov added inline comments to D2127: ScriptInterface CreateObject performance improvement.
Tue, Jul 30, 6:30 PM
vladislavbelov added inline comments to D2127: ScriptInterface CreateObject performance improvement.
Tue, Jul 30, 6:16 PM

Mon, Jul 29

vladislavbelov added inline comments to rP22573: Add missing CPos FromJSVal, ToJSVal following rP1540..
Mon, Jul 29, 2:35 PM
vladislavbelov added a comment to D2088: Fix uncaught nullptr exception in TextureManager.

Could you add a context to the patch?

Mon, Jul 29, 2:25 PM
vladislavbelov added inline comments to D2101: Re-D2013 - Fix incorrect use of setlocale() in cppformat CStr tests.
Mon, Jul 29, 2:24 PM
vladislavbelov added inline comments to rP22573: Add missing CPos FromJSVal, ToJSVal following rP1540..
Mon, Jul 29, 2:12 PM
vladislavbelov added inline comments to D2116: Avoid copying CChart m_Points following rP19027.
Mon, Jul 29, 2:07 PM
vladislavbelov added a comment to D2125: VS2013 Grid.h memset fallback.

Why not to use std::fill? Does it produce the warning?

Mon, Jul 29, 1:58 PM
vladislavbelov added inline comments to D2127: ScriptInterface CreateObject performance improvement.
Mon, Jul 29, 1:54 PM
vladislavbelov added inline comments to rP22528: Provide ScriptInterface CreateObject and CreateArray functions to replace Eval….
Mon, Jul 29, 1:48 PM

Thu, Jul 25

vladislavbelov committed rP22548: Fixes compiler warning about unused variable introduced in rP22445..
Fixes compiler warning about unused variable introduced in rP22445.
Thu, Jul 25, 1:25 AM
vladislavbelov committed rP22547: Refactors Camera aspect ratio and calculation of plane points..
Refactors Camera aspect ratio and calculation of plane points.
Thu, Jul 25, 1:08 AM
vladislavbelov closed D2020: Refactors Camera aspect ratio and calculation of plane points.
Thu, Jul 25, 1:08 AM

Jul 17 2019

vladislavbelov added inline comments to rP22487: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions..
Jul 17 2019, 12:04 AM

Jul 16 2019

vladislavbelov added inline comments to D2084: Remove CMapGeneratorWorker struct AutoFree.
Jul 16 2019, 11:59 PM
vladislavbelov added a comment to D2079: Adds snapping to edges for buildings.

Why put this behind a hotkey?

Jul 16 2019, 5:18 PM
vladislavbelov added inline comments to D2030: Update wxWidgets readme [VS2013 -> VS2015].
Jul 16 2019, 11:56 AM
vladislavbelov updated subscribers of D2076: Make wxWidgets 3.0 build requirement more explicit.

What's about Ubuntu 14.04? We still have such audience (judging by feedback statistics).

Jul 16 2019, 2:00 AM

Jul 15 2019

asterix awarded D2079: Adds snapping to edges for buildings a Party Time token.
Jul 15 2019, 9:49 PM
nani awarded D2079: Adds snapping to edges for buildings a Party Time token.
Jul 15 2019, 12:59 AM
elexis awarded D2079: Adds snapping to edges for buildings a Orange Medal token.
Jul 15 2019, 12:53 AM
vladislavbelov created D2079: Adds snapping to edges for buildings.
Jul 15 2019, 12:20 AM

Jul 13 2019

vladislavbelov updated the diff for D2020: Refactors Camera aspect ratio and calculation of plane points.

Fixes @elexis's notes from IRC (2019-07-03#0ad-dev):

Jul 13 2019, 9:54 PM

Jul 12 2019

vladislavbelov added inline comments to D2058: FixedVector2D CompareLengthSquared.
Jul 12 2019, 12:34 PM

Jul 9 2019

vladislavbelov committed rP22445: Adds an tool to pick water high by terrain click in Atlas..
Adds an tool to pick water high by terrain click in Atlas.
Jul 9 2019, 8:17 PM
vladislavbelov closed D2037: [ATLAS] Adds a tool to pick water high by terrain click.
Jul 9 2019, 8:17 PM
vladislavbelov added inline comments to D2055: Fix 4500 gcc 8, gcc 9 compile warnings.
Jul 9 2019, 1:44 AM
vladislavbelov accepted D2055: Fix 4500 gcc 8, gcc 9 compile warnings.
Jul 9 2019, 1:33 AM
vladislavbelov added inline comments to D2055: Fix 4500 gcc 8, gcc 9 compile warnings.
Jul 9 2019, 1:26 AM
vladislavbelov added inline comments to D2055: Fix 4500 gcc 8, gcc 9 compile warnings.
Jul 9 2019, 12:54 AM

Jul 8 2019

vladislavbelov added inline comments to D2055: Fix 4500 gcc 8, gcc 9 compile warnings.
Jul 8 2019, 11:59 PM

Jul 7 2019

vladislavbelov added a comment to D2043: Fix build without precompiled headers following Atlas UTF8 fix rP22335 and ThreadUtil fix rP22344.

Reviewed on IRC (from few days).

Jul 7 2019, 11:45 PM
vladislavbelov accepted D2043: Fix build without precompiled headers following Atlas UTF8 fix rP22335 and ThreadUtil fix rP22344.
Jul 7 2019, 11:45 PM

Jul 6 2019

vladislavbelov added a comment to D2019: [ATLASUI] Main Thread Checker: UI API called on a background thread: -[NSView initWithFrame:].

Did someone test it with an old platform?

Jul 6 2019, 2:30 AM

Jul 5 2019

vladislavbelov added a comment to D2043: Fix build without precompiled headers following Atlas UTF8 fix rP22335 and ThreadUtil fix rP22344.

Why you didn't change implementation too?

Jul 5 2019, 7:55 PM
vladislavbelov added a comment to D2040: Improve performance Object List Filter Atlas.

What's the minimal wxWidgets version that supports wxListView?

Jul 5 2019, 12:37 PM

Jul 4 2019

elexis awarded D2037: [ATLAS] Adds a tool to pick water high by terrain click a Like token.
Jul 4 2019, 9:29 AM
vladislavbelov added a comment to D2029: Alt+tab fix for rP22314 - call IdleTask in Atlas and swap buffers only once.

needs some investigation.

Have you some results? Did you reproduce Stan's issue?

Jul 4 2019, 2:51 AM
vladislavbelov retitled D2037: [ATLAS] Adds a tool to pick water high by terrain click from Adds a tool to pick water high by terrain click to [ATLAS] Adds a tool to pick water high by terrain click.
Jul 4 2019, 2:32 AM
vladislavbelov created D2037: [ATLAS] Adds a tool to pick water high by terrain click.
Jul 4 2019, 2:31 AM
vladislavbelov planned changes to D2020: Refactors Camera aspect ratio and calculation of plane points.
Jul 4 2019, 12:05 AM

Jul 3 2019

vladislavbelov updated the diff for D2020: Refactors Camera aspect ratio and calculation of plane points.
Jul 3 2019, 11:53 PM
vladislavbelov updated the diff for D2020: Refactors Camera aspect ratio and calculation of plane points.

Adds CCamera::Quad.

Jul 3 2019, 11:51 PM
vladislavbelov committed rP22432: Adds a possibility to disable saving of replay in autostart mode..
Adds a possibility to disable saving of replay in autostart mode.
Jul 3 2019, 11:37 PM
vladislavbelov closed D2017: Allows replays in autostart-nonvisual mode.
Jul 3 2019, 11:36 PM

Jul 2 2019

vladislavbelov accepted rP12300: ao/parallax/normal/specular/emissive mapping; windy trees; time manager; render….
Jul 2 2019, 3:45 PM

Jun 29 2019

vladislavbelov added a comment to D2019: [ATLASUI] Main Thread Checker: UI API called on a background thread: -[NSView initWithFrame:].

So, I think we may have only a workaround solution here. Because we have 2 independent libraries each of them thinks that it process all events alone and calls OS API directly.

Jun 29 2019, 8:06 PM
vladislavbelov added inline comments to D2024: Avoid VertexPathfinder pointer in rP22253.
Jun 29 2019, 8:01 PM
vladislavbelov added a comment to D2020: Refactors Camera aspect ratio and calculation of plane points.

Suggestion: wouldn't it be better to rename "Get[Near/Far]Plane" to "Get[Near/Far]PlaneDistance"

I don't mind, only note that the distance in the camera space.

Jun 29 2019, 7:54 PM
elexis awarded rP22401: Fix missing slash in common-api of entity. The mistype was introduced in… a Like token.
Jun 29 2019, 12:15 AM

Jun 28 2019

vladislavbelov updated the diff for D2020: Refactors Camera aspect ratio and calculation of plane points.

Fixes styles.

Jun 28 2019, 8:59 PM
vladislavbelov updated the diff for D2020: Refactors Camera aspect ratio and calculation of plane points.
Jun 28 2019, 1:43 AM
vladislavbelov created D2020: Refactors Camera aspect ratio and calculation of plane points.
Jun 28 2019, 1:42 AM

Jun 27 2019

vladislavbelov updated the diff for D2017: Allows replays in autostart-nonvisual mode.

Renames to autostart-disable-replay by @elexis suggestion.

Jun 27 2019, 10:48 PM
vladislavbelov added inline comments to D1988: Workaround differences between libc and libstd string stream parsing of float/doubles.
Jun 27 2019, 9:53 AM
elexis awarded D2017: Allows replays in autostart-nonvisual mode a Like token.
Jun 27 2019, 2:01 AM
vladislavbelov committed rP22404: Refactors camera projections - makes projection functions of camera more clear..
Refactors camera projections - makes projection functions of camera more clear.
Jun 27 2019, 12:54 AM
vladislavbelov closed D2012: Refactors Camera projections.
Jun 27 2019, 12:54 AM
vladislavbelov committed rP22403: Removes unused and obsolete LightingModel..
Removes unused and obsolete LightingModel.
Jun 27 2019, 12:30 AM
vladislavbelov closed D2011: Removes unused LightingModel.
Jun 27 2019, 12:30 AM
vladislavbelov created D2017: Allows replays in autostart-nonvisual mode.
Jun 27 2019, 12:13 AM

Jun 26 2019

vladislavbelov added a comment to rP22401: Fix missing slash in common-api of entity. The mistype was introduced in….

Also there are occurrences in rP14865 and rP15153.

Jun 26 2019, 11:11 PM
vladislavbelov added inline comments to D1988: Workaround differences between libc and libstd string stream parsing of float/doubles.
Jun 26 2019, 11:04 PM
vladislavbelov added a comment to D1396: Remove not needed checks and code for VS2015 [VS2013 -> VS2015].
In D1396#83410, @Angen wrote:

as we are now compiling game with vs15, this is not needed

Jun 26 2019, 9:32 PM
vladislavbelov committed rP22402: Update the minimap, range overlay renderer, and status bars when a player's….
Update the minimap, range overlay renderer, and status bars when a player's…
Jun 26 2019, 9:17 PM
vladislavbelov closed D1261: Update the minimap, range overlay renderer, and status bars when a player's color is changed in Atlas.
Jun 26 2019, 9:17 PM
vladislavbelov accepted D1261: Update the minimap, range overlay renderer, and status bars when a player's color is changed in Atlas.

I tested the patch, it works well. I checked the linked commit and made a search over our repo, and it seems that the patch covers all missed color updates.

Jun 26 2019, 9:16 PM
vladislavbelov committed rP22401: Fix missing slash in common-api of entity. The mistype was introduced in….
Fix missing slash in common-api of entity. The mistype was introduced in…
Jun 26 2019, 8:05 PM
vladislavbelov closed D1994: Fix missing slash in common-api.
Jun 26 2019, 8:05 PM
vladislavbelov accepted D1994: Fix missing slash in common-api.
In D1994#84008, @Angen wrote:

@vladislavbelov no steps to reproduce needed it is look and see situation

I figured out. It's not used at all. It was added in rP12343, and its usage was removed in rP13687.

Jun 26 2019, 7:57 PM
vladislavbelov added a comment to D2013: Fix incorrect use of setlocale() in cppformat CStr tests.

I don't think we have a use for it right now, no. So it could be seen as being too much future-proofing.

Jun 26 2019, 7:40 PM
vladislavbelov added inline comments to D2012: Refactors Camera projections.
Jun 26 2019, 7:15 PM
vladislavbelov updated the diff for D2012: Refactors Camera projections.

Renames SetPerspective to SetPerspectiveProjection.

Jun 26 2019, 7:14 PM
vladislavbelov added a comment to D2013: Fix incorrect use of setlocale() in cppformat CStr tests.

Indeed, which is why I would lock this behind a global mutex, so it goes

  1. locale=default
  2. T1::ScopedLocale::ctor(L1), locale=L1
  3. T2::ScopedLocale::ctor(L2) - blocked
  4. T1::ScopedLocale::dtor(), locale=default
  5. resuming of T2::ScopedLocale::ctor(L2) - locale=L2
  6. T2::ScopedLocale::dtor(), locale=default

Yeah. By the way where it can be useful? Do we have such cases?

Jun 26 2019, 12:33 PM
vladislavbelov added a comment to D2013: Fix incorrect use of setlocale() in cppformat CStr tests.

Agreed, I think we should also protect these calls behind a global mutex, so that it actually becomes threadsafe.

If you'd use the current implementation of ScopedLocale in multiple threads, then it highly likely wouldn't work. For ex (T1 - thread N1, T2 - thread N2, L1 - locale N1, L2 - locale N2):

Jun 26 2019, 10:39 AM
vladislavbelov added a comment to D2013: Fix incorrect use of setlocale() in cppformat CStr tests.

I think the following helper could be helpful, at least it may prevent such bugs in reusing:

class ScopedLocale
{
public:
    ScopedLocale(int category, char* newLocale)
        : m_Category(category), m_OldLocale(setlocale(category, NULL))
    {
        TS_ASSERT(setlocale(m_Category, newLocale) != nullptr);
    }
    ~ScopedLocale()
    {
        setlocale(m_Category, m_OldLocale);
    }
private:
    int m_Category;
    char* m_OldLocale;
};
Jun 26 2019, 9:30 AM
vladislavbelov added inline comments to D2012: Refactors Camera projections.
Jun 26 2019, 1:08 AM
vladislavbelov created D2012: Refactors Camera projections.
Jun 26 2019, 1:04 AM
elexis awarded rP22395: Makes rendering helpers (culling camera, frustums) be available through the… a Like token.
Jun 26 2019, 12:57 AM

Jun 25 2019

vladislavbelov added a comment to D1994: Fix missing slash in common-api.

Could you attach steps to reproduce the bug?

Jun 25 2019, 11:55 PM
vladislavbelov added inline comments to D2011: Removes unused LightingModel.
Jun 25 2019, 11:36 PM
vladislavbelov created D2011: Removes unused LightingModel.
Jun 25 2019, 10:40 PM
vladislavbelov added a comment to D1492: Abort instead of throwing an error when dealing with empty areas..
In D1492#83849, @smiley wrote:

(most of those posts were removed)

I'm not aware of it, could you post some links to the topics where it happened, if you don't mind.

Jun 25 2019, 10:30 PM
vladislavbelov accepted rP22297: Water GLSL shader improvements around reflections and whitespace fixes..

It would be much cleaner with: Reflections: None, Sky, Everything.

That'd be cool!

Jun 25 2019, 9:40 PM
vladislavbelov added a comment to D1492: Abort instead of throwing an error when dealing with empty areas..
In D1492#83837, @smiley wrote:
  1. Look at the date on which this was uploaded
  2. Look at what was changed
  3. Try to come up with a reason
Jun 25 2019, 9:38 PM
vladislavbelov added a comment to D1492: Abort instead of throwing an error when dealing with empty areas..
In D1492#83822, @smiley wrote:

Nobody cares about tiny maps anyway.

Jun 25 2019, 8:35 PM

Jun 23 2019

vladislavbelov committed rP22395: Makes rendering helpers (culling camera, frustums) be available through the….
Makes rendering helpers (culling camera, frustums) be available through the…
Jun 23 2019, 10:18 PM
vladislavbelov closed D1972: Makes some rendering helpers be available through the developer overlay..
Jun 23 2019, 10:18 PM
vladislavbelov raised a concern with rP22351: Prevent UnitMotion from stopping on its own, and rename "MoveCompleted" to….
Jun 23 2019, 2:49 AM

Jun 22 2019

vladislavbelov added inline comments to D1991: simulation2: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions.
Jun 22 2019, 12:24 PM
vladislavbelov updated subscribers of D1991: simulation2: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions.

Did you reproduce @Itms steps before the patch?

Jun 22 2019, 2:34 AM

Jun 21 2019

vladislavbelov added a comment to D1988: Workaround differences between libc and libstd string stream parsing of float/doubles.

I would certainly hope none otherwise MacOS has been behaving wrong for years.
The only place I can think of that parses strings to number is GUI sizes, which would previously parse things like "3b" as "0" instead of the 'correct' "3". I don't think there's mods or 0 A.D. code that relied on that - and I'm not sure we want that code to live.

Do we really need that behaviour for wrong strings?

Jun 21 2019, 10:24 PM
vladislavbelov requested changes to D1988: Workaround differences between libc and libstd string stream parsing of float/doubles.

How many lines of our code depend on this behaviour (that wrong strings are still parsed)?

Jun 21 2019, 9:11 PM
vladislavbelov accepted D1985: Skybox calculation - fix regression of rP22039 introduced in rP22297.

I tested, now the reflection works as after my commit.

Jun 21 2019, 6:00 PM
vladislavbelov added inline comments to rP22297: Water GLSL shader improvements around reflections and whitespace fixes..
Jun 21 2019, 5:50 PM

Jun 15 2019

vladislavbelov added a reviewer for D1985: Skybox calculation - fix regression of rP22039 introduced in rP22297: vladislavbelov.
Jun 15 2019, 10:06 PM
vladislavbelov raised a concern with rP22297: Water GLSL shader improvements around reflections and whitespace fixes..
Jun 15 2019, 9:49 PM