Page MenuHomeWildfire Games

vladislavbelov (Vladislav Belov)
User

User Details

User Since
Feb 3 2017, 10:51 PM (190 w, 19 h)

Recent Activity

Wed, Sep 16

vladislavbelov committed rP24047: Render waves for fancy water effects only if we have water on screen..
Render waves for fancy water effects only if we have water on screen.
Wed, Sep 16, 8:44 PM
vladislavbelov committed rP24046: Reduces memory usage for fancy water by merging two textures..
Reduces memory usage for fancy water by merging two textures.
Wed, Sep 16, 8:04 PM
vladislavbelov closed D2983: Reduces memory usage for fancy water.
Wed, Sep 16, 8:04 PM

Sat, Sep 12

vladislavbelov added inline comments to D2947: Address concerns in rP23917.
Sat, Sep 12, 10:03 PM
vladislavbelov added inline comments to D2460: Implement placeholder text for input fields and get rid of hack with mod filter.
Sat, Sep 12, 2:05 PM
vladislavbelov updated subscribers of D2998: Do not hardcode attacktypes in the engine/Atlas.

The patch looks good to me, but I haven't tested it.

Sat, Sep 12, 12:58 PM
vladislavbelov added inline comments to D2947: Address concerns in rP23917.
Sat, Sep 12, 12:55 PM

Fri, Sep 11

vladislavbelov updated the diff for D2983: Reduces memory usage for fancy water.

Replaces gl_FragData by gl_FragColor and removing additional draw buffer.

Fri, Sep 11, 4:42 PM
vladislavbelov added a comment to D2983: Reduces memory usage for fancy water.

Before:

After:

Fri, Sep 11, 4:04 PM

Sun, Sep 6

vladislavbelov added inline comments to D2947: Address concerns in rP23917.
Sun, Sep 6, 12:41 PM
vladislavbelov added inline comments to D2998: Do not hardcode attacktypes in the engine/Atlas.
Sun, Sep 6, 12:39 PM
vladislavbelov added inline comments to D2947: Address concerns in rP23917.
Sun, Sep 6, 12:30 PM
vladislavbelov added inline comments to D2998: Do not hardcode attacktypes in the engine/Atlas.
Sun, Sep 6, 12:16 AM

Sat, Sep 5

vladislavbelov added inline comments to D2998: Do not hardcode attacktypes in the engine/Atlas.
Sat, Sep 5, 11:21 PM
vladislavbelov added inline comments to D2723: Add support for hotloading of sound-related files.
Sat, Sep 5, 6:29 PM

Fri, Sep 4

vladislavbelov added inline comments to D2967: Cache the model-animation maximum bounds..
Fri, Sep 4, 9:08 PM

Thu, Sep 3

vladislavbelov added inline comments to D2967: Cache the model-animation maximum bounds..
Thu, Sep 3, 9:06 PM

Wed, Sep 2

vladislavbelov requested review of D2983: Reduces memory usage for fancy water.
Wed, Sep 2, 11:48 PM

Sun, Aug 30

vladislavbelov added a comment to rP23987: New Kush and Maur portraits, arakamani by @Sundiata, background changes by….

Some sizes of the images are not power of two.

Sun, Aug 30, 8:21 PM

Fri, Aug 28

vladislavbelov added a comment to D1437: Disable shadows if we can't create a shadow map.

I already wrote a thing that does that as part of my giant graphics upgrade. I just haven't been able to work on that and got way too many complaints about every freaking thing.

Unfortunately it's really hard to review big patches. Because the reviewing time grows exponentially with the size of patches. I'd suggest to split all big patches on as small as possible patches.

Fri, Aug 28, 9:17 PM

Aug 22 2020

vladislavbelov added a comment to D2812: Adds MSAA to anti-aliasing techniques.

@Stan Then why did he ignore the trees? It's strange? Is this a flight from something?

Aug 22 2020, 10:45 AM

Aug 21 2020

vladislavbelov updated the diff for D2812: Adds MSAA to anti-aliasing techniques.

Proper rebase.

Aug 21 2020, 8:29 PM
vladislavbelov updated the diff for D2812: Adds MSAA to anti-aliasing techniques.

Rebase

Aug 21 2020, 8:19 PM

Aug 20 2020

vladislavbelov updated the diff for D2812: Adds MSAA to anti-aliasing techniques.

Fixes too late resolving.

Aug 20 2020, 9:46 PM

Aug 17 2020

vladislavbelov committed rP23968: Removes unused mapSize uniform and changes too short names of variables in wide….
Removes unused mapSize uniform and changes too short names of variables in wide…
Aug 17 2020, 11:20 PM
vladislavbelov committed rP23967: Implements correct distance to edges for the building snapping feature..
Implements correct distance to edges for the building snapping feature.
Aug 17 2020, 10:14 PM
vladislavbelov closed D2945: Implements correct distance to edge for building snapping.
Aug 17 2020, 10:14 PM
vladislavbelov added inline comments to D2947: Address concerns in rP23917.
Aug 17 2020, 12:05 AM

Aug 16 2020

vladislavbelov added a comment to D2957: us → µs.

I'd prefer to have less non-ASCII characters in the code or in the console output. Since we still support old consoles/compilers that might have problems with non-ASCII characters.

Aug 16 2020, 9:39 PM

Aug 15 2020

vladislavbelov raised a concern with rP8130: # Add -archivebuild mode to generate .zip files for releases, with automatic….
Aug 15 2020, 2:33 PM

Aug 13 2020

vladislavbelov updated the diff for D2945: Implements correct distance to edge for building snapping.
Aug 13 2020, 9:12 PM
vladislavbelov updated the diff for D2945: Implements correct distance to edge for building snapping.

Fixes notes.

Aug 13 2020, 9:11 PM

Aug 11 2020

vladislavbelov added a comment to D2945: Implements correct distance to edge for building snapping.

I do have trouble with e.g. the theatre, but that was present before.

Aug 11 2020, 9:58 PM
vladislavbelov added inline comments to D2945: Implements correct distance to edge for building snapping.
Aug 11 2020, 9:57 PM

Aug 10 2020

vladislavbelov requested review of D2945: Implements correct distance to edge for building snapping.
Aug 10 2020, 1:10 AM

Aug 9 2020

vladislavbelov raised a concern with rP9141: Optimise some matrix operations, based on patch from ortalo..
Aug 9 2020, 10:41 PM
vladislavbelov committed rP23954: Completely separates fixed and shader paths in sky rendering..
Completely separates fixed and shader paths in sky rendering.
Aug 9 2020, 5:21 PM
vladislavbelov closed D2944: Completely separates fixed and shader paths in sky rendering.
Aug 9 2020, 5:21 PM
vladislavbelov requested review of D2944: Completely separates fixed and shader paths in sky rendering.
Aug 9 2020, 4:02 PM
vladislavbelov committed rP23953: Moves GL calls of fixed pipeline under the same condition..
Moves GL calls of fixed pipeline under the same condition.
Aug 9 2020, 3:02 PM
vladislavbelov committed rP23952: Removes old matrices from sky rendering in shader path..
Removes old matrices from sky rendering in shader path.
Aug 9 2020, 1:26 PM
vladislavbelov closed D2943: Removes old matrices from sky rendering.
Aug 9 2020, 1:25 PM
vladislavbelov raised a concern with rP23769: RangeManager: Grid for 2D array, enum cleanups..
Aug 9 2020, 11:35 AM
vladislavbelov added inline comments to rP23917: Add an interface for Reinforcement Learning..
Aug 9 2020, 2:23 AM
vladislavbelov requested review of D2943: Removes old matrices from sky rendering.
Aug 9 2020, 2:10 AM

Aug 8 2020

vladislavbelov committed rP23947: Adds contrast-adaptiv-sharpening filter, also helps to partly remove FXAA….
Adds contrast-adaptiv-sharpening filter, also helps to partly remove FXAA…
Aug 8 2020, 12:17 AM
vladislavbelov closed D2642: Contrast-Adaptiv-Sharpening pass.
Aug 8 2020, 12:17 AM
vladislavbelov accepted D2642: Contrast-Adaptiv-Sharpening pass.
Aug 8 2020, 12:16 AM

Aug 7 2020

vladislavbelov added inline comments to D2642: Contrast-Adaptiv-Sharpening pass.
Aug 7 2020, 9:55 PM
vladislavbelov added inline comments to D2936: Allow limiting the max number of corpses simultaneously visible in the game.
Aug 7 2020, 9:08 PM
vladislavbelov raised a concern with rP23917: Add an interface for Reinforcement Learning..

Too many issues.

Aug 7 2020, 7:57 PM
vladislavbelov committed rP23945: Adds ARB shaders for GUI materials to replace fixed ones..
Adds ARB shaders for GUI materials to replace fixed ones.
Aug 7 2020, 10:33 AM
vladislavbelov closed D2921: Adds ARB shaders for GUI materials to replace fixed ones.
Aug 7 2020, 10:32 AM

Aug 6 2020

vladislavbelov added a comment to D2942: Implement unordered_map C++ <-> JS conversion..

I don't see any strong reason to use std::unordered_map on the C++ side. It costs memory, some performance. The patch seems overhead, you might pass turrets through a list.

I use the map for D2814 too. That being said, you might argue that a vector of something is better for performance... Might be correct.

Aug 6 2020, 9:54 PM
vladislavbelov added inline comments to D2614: Also store turret position in map file..
Aug 6 2020, 9:30 PM
vladislavbelov added a comment to D2942: Implement unordered_map C++ <-> JS conversion..

I don't see any strong reason to use std::unordered_map on the C++ side. It costs memory, some performance. The patch seems overhead, you might pass turrets through a list.

Aug 6 2020, 9:24 PM

Aug 5 2020

vladislavbelov added a comment to D2932: Fix ODR violation for ShaderModelRendererInternals.

Indeed, there is the violation of ODR. The patch seems legit.

Aug 5 2020, 10:20 PM

Aug 3 2020

vladislavbelov added inline comments to rP23926: Fix issues relating to SDL and wxWidgets interaction in Atlas..
Aug 3 2020, 11:07 PM

Jul 31 2020

vladislavbelov updated the diff for D2908: Deny to run the game with Fixed rendering pipeline.
Jul 31 2020, 4:05 PM
vladislavbelov added a comment to D2921: Adds ARB shaders for GUI materials to replace fixed ones.
In D2921#126612, @Stan wrote:

Not sure why you changed the last file.

I removed the unused variable for more clear comparison of ARB and GLSL shaders.

Jul 31 2020, 3:10 PM
vladislavbelov retitled D2921: Adds ARB shaders for GUI materials to replace fixed ones from Adds ARB shaders for GUI materials to replace fixed once to Adds ARB shaders for GUI materials to replace fixed ones.
Jul 31 2020, 5:31 AM
vladislavbelov resigned from rP23906: Fixes the broken animation of the persian champion_cavalry_archer.
Jul 31 2020, 5:31 AM

Jul 30 2020

vladislavbelov created D2921: Adds ARB shaders for GUI materials to replace fixed ones.
Jul 30 2020, 10:49 PM
vladislavbelov raised a concern with rP23906: Fixes the broken animation of the persian champion_cavalry_archer.

Any change should be tested whenever possible.

Jul 30 2020, 3:59 AM

Jul 25 2020

vladislavbelov added a comment to D2908: Deny to run the game with Fixed rendering pipeline.

I think this is nice change and since above people also agree, I agree too but maybe more noble would be to in warning write that they need drivers with some version of graphics library and other supported shader pipelines. I cannot comment on code though.

Jul 25 2020, 6:54 PM
vladislavbelov added a comment to D2908: Deny to run the game with Fixed rendering pipeline.

It might be better to exit from the GUI, and make the GUI message "more red" to inform the player better. Not sure, your call imo.

We can't do something in GUI, because we can't render our GUI without "fixed" pipeline for users who does support only "fixed" pipeline.

Jul 25 2020, 6:32 PM
vladislavbelov added inline comments to D2908: Deny to run the game with Fixed rendering pipeline.
Jul 25 2020, 5:22 PM
vladislavbelov created D2908: Deny to run the game with Fixed rendering pipeline.
Jul 25 2020, 5:07 PM
vladislavbelov accepted rP23847: Use victory conditions json's in Atlas.
Jul 25 2020, 1:58 AM

Jul 24 2020

vladislavbelov committed rP23882: Fixes actor seed for deleted entities in Atlas..
Fixes actor seed for deleted entities in Atlas.
Jul 24 2020, 9:13 PM
vladislavbelov committed rP23880: Makes FXAA working only for GLSL and disabled for ARB..
Makes FXAA working only for GLSL and disabled for ARB.
Jul 24 2020, 8:48 PM
vladislavbelov closed D2780: Bugfix: GLSL query for FXAA .
Jul 24 2020, 8:48 PM
vladislavbelov accepted D2898: Fix Atlas crash introduced by rP23847.

I've tested the patch on Windows 10, it works for me for any map settings editing. The patch looks ok, a bit wordy but ok for atlas.

Jul 24 2020, 4:56 PM

Jul 22 2020

vladislavbelov added inline comments to D2642: Contrast-Adaptiv-Sharpening pass.
Jul 22 2020, 11:27 PM
vladislavbelov added a comment to D2642: Contrast-Adaptiv-Sharpening pass.

The patch looks good for me. Yes, it has duplications. But at the moment we can't make it more clear that really makes sense without a lot of code.

Jul 22 2020, 7:03 PM

Jul 21 2020

vladislavbelov added inline comments to D2898: Fix Atlas crash introduced by rP23847.
Jul 21 2020, 8:37 PM
vladislavbelov added inline comments to D2898: Fix Atlas crash introduced by rP23847.
Jul 21 2020, 8:16 PM
vladislavbelov added a comment to rP23859: Allow map to recenter during resize in Atlas. Fixes #1109..
Jul 21 2020, 7:31 PM
vladislavbelov added a comment to D825: Atlas: Allow map to recenter during resize.

@Clockwork-Muse, sorry for the long review and thank you for the patch.

Jul 21 2020, 4:11 AM
vladislavbelov committed rP23859: Allow map to recenter during resize in Atlas. Fixes #1109..
Allow map to recenter during resize in Atlas. Fixes #1109.
Jul 21 2020, 4:09 AM
vladislavbelov closed D825: Atlas: Allow map to recenter during resize.
Jul 21 2020, 4:09 AM
vladislavbelov raised a concern with rP23847: Use victory conditions json's in Atlas.

The change has broken map settings editing.

Jul 21 2020, 3:22 AM

Jul 7 2020

vladislavbelov committed rP23807: Fixes terrain index type (causing a warning) introduced in rP23639..
Fixes terrain index type (causing a warning) introduced in rP23639.
Jul 7 2020, 6:52 PM

Jun 14 2020

vladislavbelov added inline comments to D2812: Adds MSAA to anti-aliasing techniques.
Jun 14 2020, 12:29 PM

Jun 13 2020

vladislavbelov added a comment to D2789: SSE Vector3D.

Using intrinsic functions highly depends on a context. I'd like to see a comparison test for each method of CVector3D (without the game, one might just use tests).

Jun 13 2020, 1:23 PM

Jun 12 2020

vladislavbelov added a comment to D2812: Adds MSAA to anti-aliasing techniques.

Looks really sharp.

Thx.

Jun 12 2020, 11:07 PM
vladislavbelov added inline comments to D2809: Don't detect audio card when audio is disabled.
Jun 12 2020, 11:01 PM
vladislavbelov added a comment to D2811: Remove duplicated call in void TerrainOverlay::RenderTile.

@vinhig Thank you for the patch!

Jun 12 2020, 10:55 PM
vladislavbelov committed rP23767: Remove duplicated call in tile rendering for TerrainOverlay..
Remove duplicated call in tile rendering for TerrainOverlay.
Jun 12 2020, 10:52 PM
vladislavbelov closed D2811: Remove duplicated call in void TerrainOverlay::RenderTile.
Jun 12 2020, 10:52 PM
vladislavbelov committed rP23766: Moves calculations of bounds for fixed shadows to a separate function..
Moves calculations of bounds for fixed shadows to a separate function.
Jun 12 2020, 10:09 PM
vladislavbelov updated the diff for D2812: Adds MSAA to anti-aliasing techniques.
Jun 12 2020, 7:01 PM
vladislavbelov created D2812: Adds MSAA to anti-aliasing techniques.
Jun 12 2020, 6:58 PM
vladislavbelov added a comment to D2642: Contrast-Adaptiv-Sharpening pass.

Shouldn't the CAS license be mentioned in LICENSE.txt?

Jun 12 2020, 6:58 PM
vladislavbelov committed rP23765: Adds GLSL shaders of overlay lines..
Adds GLSL shaders of overlay lines.
Jun 12 2020, 5:40 PM
vladislavbelov closed D2621: Adds GLSL shaders of overlay lines.
Jun 12 2020, 5:39 PM
vladislavbelov added inline comments to D2811: Remove duplicated call in void TerrainOverlay::RenderTile.
Jun 12 2020, 4:56 PM

Jun 9 2020

vladislavbelov committed rP23755: Fixes missing deletion of files in rP23754..
Fixes missing deletion of files in rP23754.
Jun 9 2020, 12:36 AM
vladislavbelov added inline comments to D2488: Use GL_KHR_debug.
Jun 9 2020, 12:16 AM

Jun 8 2020

vladislavbelov requested changes to D2780: Bugfix: GLSL query for FXAA .

Could you please create the patch with context? (https://trac.wildfiregames.com/wiki/SubmittingPatches#Makingsomechanges)

Jun 8 2020, 8:11 PM