Page MenuHomeWildfire Games

vladislavbelov (Vladislav Belov)
UserAdministrator

User Details

User Since
Feb 3 2017, 10:51 PM (357 w, 2 d)
Roles
Administrator

Recent Activity

Yesterday

vladislavbelov added a comment to D5218: Adds compute shaders support and scaling with FSR.
In D5218#221743, @sera wrote:

Could repro again and the change fixes it

Great, thank you!

Sun, Dec 10, 10:18 PM
vladislavbelov updated the summary of D5218: Adds compute shaders support and scaling with FSR.
Sun, Dec 10, 9:56 PM
vladislavbelov added a comment to D5218: Adds compute shaders support and scaling with FSR.
In D5218#221718, @sera wrote:
ERROR: Failed to compile shader 'shaders/glsl/compute_downscale.cs':
0:27(31): error: no function with name 'texture2D'
0:27(2): error: no matching function for call to `imageStore(image2D, ivec2, error)'; candidates are:

Should be fixed with the last update. To reproduce (I wasn't able locally) you need to choose OpenGL backend (restart after that), enable post processing, set scale to 200%.

Sun, Dec 10, 9:41 PM
vladislavbelov updated the diff for D5218: Adds compute shaders support and scaling with FSR.

Fixes compute_downscale.cs compilation

Sun, Dec 10, 9:40 PM
vladislavbelov added a comment to D5218: Adds compute shaders support and scaling with FSR.
In D5218#221730, @sera wrote:

But might have been using opengl, maybe related to enabling preprocessing or some part thereof.

Scaling requires post processing be enabled indeed.

Sun, Dec 10, 9:20 PM
vladislavbelov added a comment to D5219: Fix build with libxml2 v2.12.1.

libxml2 v1.12.1 includes less header implicitly.

You mean v2.12.1?

Sun, Dec 10, 9:19 PM
vladislavbelov added a comment to D5218: Adds compute shaders support and scaling with FSR.
In D5218#221718, @sera wrote:

After fiddling a while with this new feature and checking the console after I saw the above, but can't figure out how to reproduce it :)

Generally seems to work.

Could you post your userreport_hwdetect.txt?

Sun, Dec 10, 8:44 PM
vladislavbelov updated the Trac tickets for D5218: Adds compute shaders support and scaling with FSR.
Sun, Dec 10, 3:15 PM
vladislavbelov added a comment to D5218: Adds compute shaders support and scaling with FSR.

I suggest you post on forums like you did with testing Vulkan implementation.

Yeah, I will do after committing.

Sun, Dec 10, 3:12 PM
asterix awarded D5218: Adds compute shaders support and scaling with FSR a Party Time token.
Sun, Dec 10, 7:30 AM

Sat, Dec 9

vladislavbelov requested review of D5218: Adds compute shaders support and scaling with FSR.
Sat, Dec 9, 11:49 PM

Fri, Dec 8

vladislavbelov added inline comments to rP27962: Split Receiver from SharedState.
Fri, Dec 8, 11:24 AM

Sun, Dec 3

vladislavbelov committed rP27965: Revert non-ASCII characters from source and configuration files introduced in….
Revert non-ASCII characters from source and configuration files introduced in…
Sun, Dec 3, 1:30 AM
vladislavbelov closed D5185: Revert non-ASCII characters from source and configuration files introduced in rP27786.
Sun, Dec 3, 1:30 AM
vladislavbelov added a comment to D4425: Use the threadpool for texture conversion.

So the queue limit was about memory-consumption? I thought it was about lag.

It was and still is about lag, but I'm also worrying that the queue capacity isn't limited anymore.

Sun, Dec 3, 12:06 AM

Sat, Dec 2

vladislavbelov added inline comments to D5139: [Map] Extend Flood.
Sat, Dec 2, 11:59 PM
vladislavbelov added inline comments to rP27941: Move placement options from rmgen2 to rmgen-common.
Sat, Dec 2, 11:58 PM
vladislavbelov added inline comments to rP27928: Fix serialization test following rP27673 - Fix CalculateTerritories after….
Sat, Dec 2, 11:55 PM
vladislavbelov added a comment to D5189: Turn the FLOODFILL macro in to a function.

Have you measured performance for those changes?

Sat, Dec 2, 11:52 PM
vladislavbelov added inline comments to rP27962: Split Receiver from SharedState.
Sat, Dec 2, 11:29 PM

Thu, Nov 30

vladislavbelov added inline comments to D4425: Use the threadpool for texture conversion.
Thu, Nov 30, 11:55 PM

Mon, Nov 20

vladislavbelov added inline comments to rP27944: Put the CMapGeneratorWorker completely inside the task.
Mon, Nov 20, 7:51 PM

Nov 10 2023

vladislavbelov added a comment to D5167: Introduce CLogger::ScopedReplacement and FileLogger.

@vladislavbelov do you have a outstanding input?

Nov 10 2023, 8:38 PM

Nov 9 2023

vladislavbelov committed rP27925: Adds test for loading actor and model having proper flags..
Adds test for loading actor and model having proper flags.
Nov 9 2023, 12:23 AM
vladislavbelov closed D5172: Adds test for loading actor and model having proper flags.
Nov 9 2023, 12:23 AM
vladislavbelov committed rP27924: Reduces code duplication of specular calculation in shaders..
Reduces code duplication of specular calculation in shaders.
Nov 9 2023, 12:08 AM
vladislavbelov closed D5178: Reduces code duplication of specular calculation.
Nov 9 2023, 12:08 AM

Nov 8 2023

vladislavbelov updated the diff for D5172: Adds test for loading actor and model having proper flags.
Nov 8 2023, 11:28 PM
vladislavbelov added a comment to D5181: Fix serialization test following rP27673 - Fix CalculateTerritories after deserialization.

I believe this also affected blinking territory, but I'm slightly less sure there - unlikely it would show up in game since it can only affect the center of a group of territory tiles, and unless I'm wrong we don't show borders when the borders are very small?

You mean like #1229?

Nov 8 2023, 6:28 PM

Nov 7 2023

vladislavbelov updated the diff for D5185: Revert non-ASCII characters from source and configuration files introduced in rP27786.
Nov 7 2023, 10:53 PM
vladislavbelov added a comment to D5185: Revert non-ASCII characters from source and configuration files introduced in rP27786.

You probably should fix the linter as well.

Yeah, thanks!

Nov 7 2023, 10:53 PM
vladislavbelov committed rP27921: Moves single descriptor set binding management for Vulkan to a separate class..
Moves single descriptor set binding management for Vulkan to a separate class.
Nov 7 2023, 10:44 PM
vladislavbelov closed D5163: Moves single descriptor set binding management for Vulkan to a separate class.
Nov 7 2023, 10:44 PM
vladislavbelov committed rP27920: Fixes incorrect case of GLX extensions. Fixes #6547.
Fixes incorrect case of GLX extensions. Fixes #6547
Nov 7 2023, 10:29 PM
vladislavbelov closed D5160: GLX_EXTENSIONS has incorrect case.
Nov 7 2023, 10:29 PM

Nov 6 2023

vladislavbelov requested review of D5185: Revert non-ASCII characters from source and configuration files introduced in rP27786.
Nov 6 2023, 7:43 PM

Nov 5 2023

vladislavbelov added a comment to D5181: Fix serialization test following rP27673 - Fix CalculateTerritories after deserialization.

Could you make a test for that?

Nov 5 2023, 1:48 AM
vladislavbelov added inline comments to D4770: Multiplayer saved games.
Nov 5 2023, 1:48 AM
vladislavbelov accepted D5176: Fix compile error introduced in rP27908.

Not perfect but I can live with it.

Nov 5 2023, 1:11 AM

Nov 2 2023

vladislavbelov added inline comments to D5176: Fix compile error introduced in rP27908.
Nov 2 2023, 6:47 PM

Nov 1 2023

vladislavbelov changed the visibility for P298 rP27673 serialization failure.
Nov 1 2023, 7:19 PM
wowgetoffyourcellphone awarded D5178: Reduces code duplication of specular calculation a Dat Boi token.
Nov 1 2023, 3:59 AM

Oct 31 2023

vladislavbelov requested review of D5178: Reduces code duplication of specular calculation.
Oct 31 2023, 11:43 PM
vladislavbelov raised a concern with rP27673: Don't poll territory in Position component.

This commit introduced serialization test failure (I've bisected it between 27104 and 27894):

Oct 31 2023, 10:12 PM
vladislavbelov created P298 rP27673 serialization failure.
Oct 31 2023, 10:11 PM

Oct 30 2023

vladislavbelov added inline comments to D5176: Fix compile error introduced in rP27908.
Oct 30 2023, 7:46 PM
vladislavbelov added inline comments to D5176: Fix compile error introduced in rP27908.
Oct 30 2023, 7:07 PM
vladislavbelov raised a concern with rP27910: [Art][Gameplay] A slightly larger chicken model to improve gameplay.

Animation became noticeably out of sync with movement speed (reported by @abian):

Oct 30 2023, 5:52 PM
vladislavbelov added inline comments to D5176: Fix compile error introduced in rP27908.
Oct 30 2023, 11:41 AM
vladislavbelov added a comment to rP27908: Make the RLInterface local.

How did you get the log? I didn't found anything on jenkins.

I believe it requires to login.

Oct 30 2023, 11:13 AM
vladislavbelov added inline comments to D5163: Moves single descriptor set binding management for Vulkan to a separate class.
Oct 30 2023, 11:12 AM
vladislavbelov added a comment to D5177: [Art] affecting [Gameplay] A 20% larger Chicken model.

It'd be good to attach comparison images to such changes.

Oct 30 2023, 10:59 AM

Oct 29 2023

vladislavbelov raised a concern with rP27908: Make the RLInterface local.

autobuild is broken (logs from Jenkins):

Oct 29 2023, 5:01 PM
vladislavbelov added inline comments to rP27908: Make the RLInterface local.
Oct 29 2023, 1:18 PM

Oct 28 2023

vladislavbelov added a comment to D5163: Moves single descriptor set binding management for Vulkan to a separate class.

I wrote it because of things like using StaticVector instead of std::optional. There are/where more but I don't remember.

Oct 28 2023, 11:22 PM
vladislavbelov added inline comments to rP27908: Make the RLInterface local.
Oct 28 2023, 11:21 PM
vladislavbelov committed rP27907: Moves CVertexBufferManager from global scope to CRenderer..
Moves CVertexBufferManager from global scope to CRenderer.
Oct 28 2023, 11:01 PM
vladislavbelov closed D5171: Moves CVertexBufferManager from global scope to CRenderer.
Oct 28 2023, 11:01 PM
vladislavbelov added inline comments to rP27906: Combine visual and nonvisual path so that there is only one gameloop.
Oct 28 2023, 10:59 PM

Oct 27 2023

vladislavbelov accepted D5173: Use std::unique_ptr in CUnitManager and remove unused member functions..
Oct 27 2023, 1:20 PM

Oct 26 2023

vladislavbelov added inline comments to D5167: Introduce CLogger::ScopedReplacement and FileLogger.
Oct 26 2023, 7:35 PM
vladislavbelov added inline comments to D5173: Use std::unique_ptr in CUnitManager and remove unused member functions..
Oct 26 2023, 3:43 PM
vladislavbelov accepted D5173: Use std::unique_ptr in CUnitManager and remove unused member functions..
Oct 26 2023, 1:19 PM

Oct 25 2023

vladislavbelov added inline comments to D5173: Use std::unique_ptr in CUnitManager and remove unused member functions..
Oct 25 2023, 8:42 PM
vladislavbelov updated the diff for D5171: Moves CVertexBufferManager from global scope to CRenderer.
Oct 25 2023, 8:26 PM
vladislavbelov updated the diff for D5172: Adds test for loading actor and model having proper flags.
Oct 25 2023, 8:21 PM
vladislavbelov added inline comments to D5172: Adds test for loading actor and model having proper flags.
Oct 25 2023, 8:21 PM
phosit awarded D5171: Moves CVertexBufferManager from global scope to CRenderer a Like token.
Oct 25 2023, 1:34 PM
vladislavbelov accepted D5160: GLX_EXTENSIONS has incorrect case.

LGTM.

Oct 25 2023, 11:27 AM
vladislavbelov updated the diff for D5172: Adds test for loading actor and model having proper flags.
Oct 25 2023, 11:12 AM
vladislavbelov added a member for Contributors: jpshack.
Oct 25 2023, 1:57 AM
vladislavbelov requested review of D5172: Adds test for loading actor and model having proper flags.
Oct 25 2023, 12:06 AM

Oct 24 2023

vladislavbelov requested review of D5171: Moves CVertexBufferManager from global scope to CRenderer.
Oct 24 2023, 10:39 PM

Oct 23 2023

vladislavbelov updated the diff for D5163: Moves single descriptor set binding management for Vulkan to a separate class.
Oct 23 2023, 9:39 PM
vladislavbelov updated the diff for D5163: Moves single descriptor set binding management for Vulkan to a separate class.
Oct 23 2023, 9:17 PM
vladislavbelov updated the diff for D5163: Moves single descriptor set binding management for Vulkan to a separate class.
Oct 23 2023, 7:47 PM
vladislavbelov added a comment to D5167: Introduce CLogger::ScopedReplacement and FileLogger.

I mean if we have a plan to restrict the CLogger scope by some class later then the change is unnecessary, if we don't have a plan then it's kind of ok (it's not perfect and in your terms a new dev might be "scared" because it looks like a workaround).

Oct 23 2023, 7:40 PM

Oct 20 2023

vladislavbelov resigned from rP27695: Don't send PositionChanged messages in TurnTo when not actually turning.

Fixed in rP27893.

Oct 20 2023, 11:45 PM
vladislavbelov added a reverting change for D5005: Don't send PositionChanged messages in TurnTo when not actually turning: rP27893: Reverts rP27695 as it breaks LOS update. Fixes #6844.
Oct 20 2023, 11:45 PM
vladislavbelov committed rP27893: Reverts rP27695 as it breaks LOS update. Fixes #6844.
Reverts rP27695 as it breaks LOS update. Fixes #6844
Oct 20 2023, 11:45 PM
vladislavbelov added a reverting change for rP27695: Don't send PositionChanged messages in TurnTo when not actually turning: rP27893: Reverts rP27695 as it breaks LOS update. Fixes #6844.
Oct 20 2023, 11:45 PM
vladislavbelov closed D5162: Reverts rP27695 as it breaks LOS update.
Oct 20 2023, 11:45 PM

Oct 19 2023

vladislavbelov added a comment to D5167: Introduce CLogger::ScopedReplacement and FileLogger.

A question: if there was a proper CApplication class (which controls lifetime of CLogger), would the LifetimeGuard be necessary?

Oct 19 2023, 7:30 PM

Oct 18 2023

People empowered vladislavbelov as an administrator.
Oct 18 2023, 8:35 PM

Oct 17 2023

vladislavbelov added a comment to D5166: center view on the selected entity by left-clicking on its portrait.

Shouldn't it behave like the follow hotkey (F by default)?

Oct 17 2023, 11:43 PM
vladislavbelov added a comment to D5163: Moves single descriptor set binding management for Vulkan to a separate class.

There are many things which "might be used in future". I don't like that.

I don't think that the word "might" is applicable here. The diff uses the code that was added.

Oct 17 2023, 1:38 PM

Oct 14 2023

wowgetoffyourcellphone awarded D5162: Reverts rP27695 as it breaks LOS update a Dat Boi token.
Oct 14 2023, 12:50 AM

Oct 13 2023

vladislavbelov requested review of D5163: Moves single descriptor set binding management for Vulkan to a separate class.
Oct 13 2023, 9:49 PM
vladislavbelov committed rP27887: Fixes result of VkDescriptorSet creation forgotten in rP27879..
Fixes result of VkDescriptorSet creation forgotten in rP27879.
Oct 13 2023, 8:32 PM

Oct 12 2023

vladislavbelov requested review of D5162: Reverts rP27695 as it breaks LOS update.
Oct 12 2023, 11:01 PM
vladislavbelov added a reverting change for D5005: Don't send PositionChanged messages in TurnTo when not actually turning: D5162: Reverts rP27695 as it breaks LOS update.
Oct 12 2023, 10:43 PM
vladislavbelov added a reverting change for rP27695: Don't send PositionChanged messages in TurnTo when not actually turning: D5162: Reverts rP27695 as it breaks LOS update.
Oct 12 2023, 10:43 PM
vladislavbelov added a comment to D5158: Remove the CStrIntern constructor for const char*.

Currently it's better to fix the behavior rather than making it always allocating. It was broken in rP23191. We construct CStrIntern with the same const char* many times per frame.

Oct 12 2023, 9:43 PM
vladislavbelov added a comment to rP27883: Remove Engine.IsGameStarted completely.

It should be mentioned in the changelog because there might be mods which use this function.

Oct 12 2023, 9:32 PM
vladislavbelov added a comment to D5127: Fix riscv64 build with GCC 13.
In D5127#219402, @Stan wrote:

From the ticket on Twitter, I'm not sure but I think the hangs are caused by the GC (Similar issue on RPI4):

Is there a more powerful combination with riscv64?

Oct 12 2023, 8:53 PM
vladislavbelov added a comment to D5154: Implement OnScopeExit and use in in main.cpp.

Adding a class doesn't help much: we will still have to refactor code to be able to remove globals.

The main idea is to not make everything clean at once, but move towards by small steps. All polishing refactorings might be done afterwards. You might take a look my GL -> abstract API refactoring history. It took me more than a year (and it's still far from perfect). But it allowed me to add Vulkan support and make players life more comfortable in some cases (especially on macOS).

Oct 12 2023, 7:51 PM
vladislavbelov added a comment to D5115: fix vertical misalignment of text "Victory:" on save game screen.
In D5115#217276, @abian wrote:

Thanks! Tested with "Segervillkor:", all okay.

Could you attach screenshots for long translations?

Oct 12 2023, 4:29 PM
vladislavbelov added a comment to D5127: Fix riscv64 build with GCC 13.
In D5127#218003, @xctan wrote:

Yes, for riscv64 support.

Oct 12 2023, 4:27 PM
vladislavbelov added a comment to D5154: Implement OnScopeExit and use in in main.cpp.
Oct 12 2023, 4:22 PM
vladislavbelov published D5160: GLX_EXTENSIONS has incorrect case for review.

Could you adjust your patch to have a context? You can find how to do that here: https://trac.wildfiregames.com/wiki/SubmittingPatches#Makingsomechanges

Oct 12 2023, 12:11 PM