The current implementation counted as better equal frames, and also counted frames where the currently selected profile category did not trigger, which made little sense.
Details
Details
- Reviewers
- None
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths)
Review.
To test this:
- Start a game
- Enable profiler2 and the HTTP server.
- Open 0AD/source/tools/profiler2/profiler2.html
- Click on the top-most button "save report to file".
- Click on "Choose File" below the title, and select [log folder path]/profile.json
- Marvel as you have two profile reports open.
- In the analysis section, on the Choices tab (which should now list various stuff such as "MakeGoalReachable"), click on one.
- In the very bottom, you should see "Report Comparison". It should make sense. Before it didn't make sense.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- temp
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 6065 Build 10103: Vulcan Build Jenkins Build 10102: arc lint + arc unit
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/493/display/redirect