Page MenuHomeWildfire Games

Make the pathfinder state tiles grid a unique_ptr for safety.
Needs ReviewPublic

Authored by wraitii on Wed, Jul 24, 1:47 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

This changes state.tiles to a unique_ptr, as we are transferring ownership to m_DebugGrid and this seems quite dangerous and likely to leak someday - deleting the debug code would actually leak.

Test Plan

Review code, compile, test that things still work.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
temp
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8575
Build 14038: Vulcan BuildJenkins
Build 14037: arc lint + arc unit

Event Timeline

wraitii created this revision.Wed, Jul 24, 1:47 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/220/display/redirect