Page MenuHomeWildfire Games
Differential D2433

Remove messy projectile from siege operator animations
ClosedPublic
Actions

Authored by Silier on Nov 20 2019, 10:41 AM.

Details

Reviewers
Stan
Commits
rP23168: Fix Carthaginian polybolos not shooting fire projectiles. Also fix another…
Summary

Issue reported on forum https://wildfiregames.com/forum/index.php?/topic/27254-no-fire-particles-for-carthaginian-ballista-if-stone-is-flying-or-after-landing/

Reproduced by me on svn, but looks like hard to reproduce because @Stan was not able to.

Cartaginian ballista ought to have flaming projectile flying, but because that projectile definition in ballista crew, visual sometimes mess things up.
Also it has nothing to do there.

Removing also similar problem from unused operator file.

Introduced in rP20483

Test Plan

Confirm carthagian ballista has flaming shots when fires.
If you were not able to reproduce this issue, confirm nothing changed.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Silier created this revision.Nov 20 2019, 10:41 AM
Owners added a subscriber: Restricted Owners Package.Nov 20 2019, 10:41 AM
Silier added a reviewer: Stan.Nov 20 2019, 10:42 AM
Silier edited the summary of this revision. (Show Details)Nov 20 2019, 10:49 AM
Vulcan added a comment.Nov 20 2019, 10:51 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1122/display/redirect

Vulcan added a comment.Nov 20 2019, 10:54 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/606/display/redirect

Harbormaster completed remote builds in B10062: Diff 10361.Nov 20 2019, 10:55 AM
Silier updated this revision to Diff 10362.Nov 20 2019, 11:06 AM
Silier retitled this revision from Remove messy projectile from kart ballista infantry to Remove messy projectile from siege operator animations.
Silier edited the summary of this revision. (Show Details)
Vulcan added a comment.Nov 20 2019, 11:07 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/607/display/redirect

Vulcan added a comment.Nov 20 2019, 11:13 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1123/display/redirect

Harbormaster completed remote builds in B10063: Diff 10362.Nov 20 2019, 11:13 AM
Stan accepted this revision.Nov 20 2019, 2:18 PM
This revision is now accepted and ready to land.Nov 20 2019, 2:18 PM
Closed by commit rP23168: Fix Carthaginian polybolos not shooting fire projectiles. Also fix another… (authored by Stan). · Explain WhyNov 20 2019, 2:21 PM
This revision was automatically updated to reflect the committed changes.
Stan added a commit: rP23168: Fix Carthaginian polybolos not shooting fire projectiles. Also fix another….

Revision Contents
Changeset List

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
art/
variants/
biped/
1 line
1 line

Diff 10363

View Options

ps/trunk/binaries/data/mods/public/art/variants/biped/attack_ranged_kart_ballista_fire_b.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/art/variants/biped/attack_ranged_polybolos_fire_b.xml

Loading...
Wildfire Games · Phabricator