Page MenuHomeWildfire Games

Stan (Stanislas Daniel Claude Dolcini)
User

User Details

User Since
Jan 6 2017, 3:41 PM (119 w, 11 h)

Recent Activity

Today

Stan added inline comments to rP22196: Correctly handle receiving 0 damage as not receiving any damage..
Sat, Apr 20, 12:06 AM

Yesterday

Stan added a comment to D665: Make ship pickup nicer.

@wraitii This year maybe ? ;)

Fri, Apr 19, 6:14 PM
Stan added a comment to D1764: Dynamically sizes the dataCounter overlay.

Binary files should be removed from the diff :)

Fri, Apr 19, 6:07 PM
Stan edited reviewers for D1670: Remove references to globals, added: Restricted Owners Package; removed: causative.
Fri, Apr 19, 6:03 PM
Stan requested changes to D1670: Remove references to globals.

Needs to be rebased.

Fri, Apr 19, 6:02 PM
Stan added inline comments to D1491: Const-Correct the long range pathfinder.
Fri, Apr 19, 2:54 PM
Stan added a comment to D359: Water shader improvements: fix some of the redness, fix edge-of-map showing up, improve entity-under-water, slight improvement to reflection edges..

Might want to commit the whitespace changes separately :)

Fri, Apr 19, 1:23 PM

Thu, Apr 18

Stan committed rP22193: Remove useless files that contained placeholder objects (boxes).
Remove useless files that contained placeholder objects (boxes)
Thu, Apr 18, 6:05 PM
Stan updated the diff for D1584: Seed random sounds.
  • Initialize private member before using it.
Thu, Apr 18, 2:05 PM

Wed, Apr 17

Stan added inline comments to D1763: Removes duplication of Clamp function.
Wed, Apr 17, 6:50 PM
Stan added a comment to D1584: Seed random sounds.

@vladislavbelov Can you recheck that everything is fine so I can commit it ?

Wed, Apr 17, 6:47 PM
Stan updated the diff for D1584: Seed random sounds.
  • Fix incorrect function call
  • Remove deleted whitespace
Wed, Apr 17, 6:41 PM
Stan updated the diff for D1584: Seed random sounds.
  • Use the fast random function
  • Make function and variables members of the SoundGroup.cpp class.
  • Make them non static as it doesn't matter as they are constantly overridden.
Wed, Apr 17, 6:36 PM
Stan added a comment to D1584: Seed random sounds.
cl.exe file.cpp /fp:precise
file.cpp
Microsoft (R) Incremental Linker Version 14.00.24245.0
Copyright (C) Microsoft Corporation.  All rights reserved.
Wed, Apr 17, 6:13 PM
Stan added a comment to D1769: Do not mark unit as injured when receives 0 damage.

That works however I'm not sure what are the bounds of the generated number. I tried to divide it by std::limits<int>::max() but I only get 10^-6 numbers.

Wed, Apr 17, 10:29 AM
Stan added a comment to D1584: Seed random sounds.

@wraitii Any idea on what could be faster than a MT19973 ? srand() would have been perfect but we cannot use it.

Wed, Apr 17, 9:40 AM
Stan added a comment to D1769: Do not mark unit as injured when receives 0 damage.

Can you fix the JSDOC comment ? :)

Wed, Apr 17, 9:39 AM

Tue, Apr 16

Angen awarded rP22192: Add missing parenthesis in the Petra diplomacyManager. Else the requested… a Like token.
Tue, Apr 16, 7:41 PM
Stan committed rP22192: Add missing parenthesis in the Petra diplomacyManager. Else the requested….
Add missing parenthesis in the Petra diplomacyManager. Else the requested…
Tue, Apr 16, 6:40 PM
Stan closed D1826: Fix missing parenthesis in the AI.
Tue, Apr 16, 6:40 PM
Stan added inline comments to rP22023: Always leave/reenter the top-most FSM state when SetNextState is called with….
Tue, Apr 16, 6:36 PM
Stan created D1826: Fix missing parenthesis in the AI.
Tue, Apr 16, 5:52 PM
Stan added a comment to D1736: Early-exit when destroying invalid entities (INVALID_ENTITY, already destroyed…).

@Itms @vladislavbelov Any other comments ?

Tue, Apr 16, 3:46 PM
Stan added a reviewer for D1803: Communicate field diminishing returns to the player: Gallaecio.
In D1803#74329, @bb wrote:

changing vegetables to grain wouldn't work since f.e. the Chinese mod has rise fields instead. One could consider "crops" though.

The string but at reduced efficiency doesn't specify when the efficiency is reduced, so it doesn't help explaining what is going on. Maybe Harvest crops for food. Up to 5 units can gather, but each subsequent gatherer reduces the efficiency per worker.

Tue, Apr 16, 10:26 AM
Stan added a comment to D1739: Replace EntityMap, std::map, std::unordered_map and boost::unordered_map with an upgraded container.

This really needs to be used for components before I decide if it's worth merging, but as it changes hashes it's kind of annoying. I'll probably have to do some fancy tests at some point.

Tue, Apr 16, 10:23 AM
Stan added a comment to D1739: Replace EntityMap, std::map, std::unordered_map and boost::unordered_map with an upgraded container.

Any news on this ?

Tue, Apr 16, 9:17 AM

Mon, Apr 15

Stan added inline comments to D1769: Do not mark unit as injured when receives 0 damage.
Mon, Apr 15, 11:05 PM
Stan added a comment to D1769: Do not mark unit as injured when receives 0 damage.

@wraitii usually the reviewer commits the patch. @Angen doesn't have commit access.

Mon, Apr 15, 8:38 PM
Stan added inline comments to D1769: Do not mark unit as injured when receives 0 damage.
Mon, Apr 15, 3:39 PM
Stan added inline comments to D1769: Do not mark unit as injured when receives 0 damage.
Mon, Apr 15, 2:24 PM
Stan added inline comments to D1769: Do not mark unit as injured when receives 0 damage.
Mon, Apr 15, 2:23 PM
Stan added inline comments to D1769: Do not mark unit as injured when receives 0 damage.
Mon, Apr 15, 2:21 PM
Stan added a comment to D1772: Fix TLS Segfault on various mac versions.

Yeah, it would be nice to have it for A24 but that's all.

Mon, Apr 15, 2:18 PM
Stan updated the diff for D1772: Fix TLS Segfault on various mac versions.
Mon, Apr 15, 7:58 AM
Stan updated the diff for D1776: Cleanup Timer.js and update documentation.
Mon, Apr 15, 7:56 AM
Stan added a comment to D1823: Replace includes uniform_foo with uniform_foo_distribution.

boost::random::uniform_int_distribution & boost::random::uniform_real_distribution<float> → 1.47 https://www.boost.org/doc/libs/1_47_0/doc/html/boost/random/uniform_int_distribution.html Before it's not documented.

Mon, Apr 15, 7:53 AM

Sat, Apr 13

Stan added inline comments to D438: Change Run Speed into a Run multiplier.
Sat, Apr 13, 4:15 PM
Stan added a comment to D1772: Fix TLS Segfault on various mac versions.

Well good thing that option doesn't exist because this means only enable-fat is needed.
I'm not sure that's an issue upstream more us supporting too many platforms with one build.

Sat, Apr 13, 4:12 PM
Stan added inline comments to rP22184: Move more things in the projectile part of the Attack/Ranged component.
Sat, Apr 13, 11:37 AM

Fri, Apr 12

Stan added inline comments to D1769: Do not mark unit as injured when receives 0 damage.
Fri, Apr 12, 6:39 PM
Stan added a comment to D1822: Handle hotkey to order only one unit on minimap.

That you could already do. However what you couldn't do is have the same behavior clicking on the minimap

Fri, Apr 12, 8:46 AM · Contributors
Stan updated subscribers of D1822: Handle hotkey to order only one unit on minimap.
Fri, Apr 12, 8:13 AM · Contributors

Thu, Apr 11

Stan added inline comments to D1584: Seed random sounds.
Thu, Apr 11, 7:18 AM
Stan added inline comments to D1822: Handle hotkey to order only one unit on minimap.
Thu, Apr 11, 7:13 AM · Contributors

Wed, Apr 10

Stan added a comment to D1822: Handle hotkey to order only one unit on minimap.

When creating your patch please add context using git diff -U5000 or svn diff -x -U5000, so that we can see the lines above and below :)

Wed, Apr 10, 10:47 PM · Contributors
Stan updated the diff for D1823: Replace includes uniform_foo with uniform_foo_distribution.

Fix years.

Wed, Apr 10, 8:30 PM
Stan created D1823: Replace includes uniform_foo with uniform_foo_distribution.
Wed, Apr 10, 8:17 PM
Stan updated the diff for D1584: Seed random sounds.
  • Use srand(seed) instead. According to my tests it works way faster.
Wed, Apr 10, 4:34 PM
Stan added a comment to D1584: Seed random sounds.

Wed, Apr 10, 1:56 PM
Stan added a comment to D1584: Seed random sounds.

Here is a graph of a 4x4 match PopCap Unlimited, difficulty medium{F891459} Most calls 162
Diff to test

Wed, Apr 10, 12:09 PM
Stan requested verification of rP22175: Remove useless class, test class and use boost instead of it in….
Wed, Apr 10, 8:40 AM
Stan committed rP22178: Fix rP22175. Refs #5428.
Fix rP22175. Refs #5428
Wed, Apr 10, 8:05 AM
Stan added a comment to rP22175: Remove useless class, test class and use boost instead of it in….

Will fix it asap for some reason the commit did not add all my changes... Thanks for the report.

Wed, Apr 10, 7:45 AM
Stan added a comment to D1584: Seed random sounds.

@vladislavbelov Three questions

Wed, Apr 10, 12:32 AM
Stan updated the diff for D1584: Seed random sounds.
Wed, Apr 10, 12:30 AM

Tue, Apr 9

Stan added a comment to rP22175: Remove useless class, test class and use boost instead of it in….

Closed the wrong differential.

Tue, Apr 9, 11:56 PM
Stan closed D1821: Remove useless Random class.

Fixed by rP22175

Tue, Apr 9, 11:54 PM
Stan committed rP22175: Remove useless class, test class and use boost instead of it in….
Remove useless class, test class and use boost instead of it in…
Tue, Apr 9, 11:50 PM
Stan closed D1584: Seed random sounds.
Tue, Apr 9, 11:50 PM
Stan added a comment to D1821: Remove useless Random class.

Thanks for the review guys !

Tue, Apr 9, 9:55 PM
Stan added a comment to D1821: Remove useless Random class.

Well if distribution did matter we would use it everywhere no ?

Tue, Apr 9, 9:26 PM
Stan added a comment to D1821: Remove useless Random class.

That's a test so it doesn't matter much.

Tue, Apr 9, 9:12 PM
Stan added a reviewer for D1822: Handle hotkey to order only one unit on minimap: Restricted Owners Package.
Tue, Apr 9, 9:08 PM · Contributors
Stan added members for Contributors: Freagarach, luiko.
Tue, Apr 9, 8:02 PM
Stan added inline comments to rP22151: New berry bushes by BigTiger.
Tue, Apr 9, 5:52 PM
Stan added a comment to D1584: Seed random sounds.

Thanks for the tip, I was able to make a new test (I had some troubles with static variables XD)

Tue, Apr 9, 3:47 PM
Stan added a comment to D1584: Seed random sounds.

Maybe we should use boost after all https://stackoverflow.com/questions/20998470/random-numbers-c11-vs-boost

Tue, Apr 9, 9:34 AM

Mon, Apr 8

Stan added a comment to D1571: Refactor and cleanup of CGameView.

Here are some comments.

Mon, Apr 8, 9:50 PM
Stan updated the diff for D1821: Remove useless Random class.

Fix include order.

Mon, Apr 8, 8:44 PM
Stan created D1821: Remove useless Random class.
Mon, Apr 8, 8:42 PM
Stan updated the diff for D1584: Seed random sounds.

Fix diff that should not have been able to build.

Mon, Apr 8, 8:33 PM
Stan added a comment to D1765: Gaia templates' <Selectable> clean-up.

*Takes the artistic cap*

Mon, Apr 8, 4:44 PM

Sun, Apr 7

Stan added a comment to D359: Water shader improvements: fix some of the redness, fix edge-of-map showing up, improve entity-under-water, slight improvement to reflection edges..

Maybe he can request changes :)

Sun, Apr 7, 8:07 PM
Stan added inline comments to D1819: Make capture attack work with units with BuildingAI..
Sun, Apr 7, 4:33 PM
Stan added inline comments to rP22165: Update the wonder victory timer in case the wonder renames..
Sun, Apr 7, 1:07 PM
Stan added inline comments to D1819: Make capture attack work with units with BuildingAI..
Sun, Apr 7, 1:03 PM
Stan updated the diff for D1584: Seed random sounds.
  • Make rng static to cut the compute time by half
  • Use a custom seed only when cmpVisual is set
Sun, Apr 7, 12:59 PM
Stan added a comment to D1584: Seed random sounds.

Static rng;

Sun, Apr 7, 12:38 PM
Stan added inline comments to D1819: Make capture attack work with units with BuildingAI..
Sun, Apr 7, 12:32 PM
Stan added inline comments to D1819: Make capture attack work with units with BuildingAI..
Sun, Apr 7, 12:31 PM

Sat, Apr 6

Stan added a comment to D1584: Seed random sounds.

Does setting the seed reset the rng ?

Sat, Apr 6, 5:40 PM
Stan added a comment to D1584: Seed random sounds.

Can't really make it static since we always want to generate the same number for a given Actor seed.

Sat, Apr 6, 4:23 PM
Stan added inline comments to D1622: [CSlider] On click move the slider-button to the mouse position.
Sat, Apr 6, 4:01 PM
Stan added a comment to D1584: Seed random sounds.

https://pastebin.com/mFhKWCAu

Sat, Apr 6, 4:00 PM
Stan added inline comments to D1622: [CSlider] On click move the slider-button to the mouse position.
Sat, Apr 6, 3:31 PM
Stan added a comment to D1584: Seed random sounds.

1000000 Samples

Sat, Apr 6, 3:29 PM

Fri, Apr 5

Stan added a comment to D1584: Seed random sounds.

Will try as long as I don't have to link boost should be fine :)

Fri, Apr 5, 8:39 PM
Stan added a comment to D1584: Seed random sounds.

How should I test it ? I'm not really confident with profiling :)

Fri, Apr 5, 8:36 PM
Stan added inline comments to D1637: BoolArray array wrapper..
Fri, Apr 5, 2:56 PM
Stan committed rP22161: Fixes.
Fixes
Fri, Apr 5, 2:37 PM
Stan closed D1741: Fix some warning for vs2015 in Atlas.
Fri, Apr 5, 2:37 PM
Stan committed rP22160: Fix berry bushes smoothing groups,.
Fix berry bushes smoothing groups,
Fri, Apr 5, 2:11 PM
Stan added inline comments to D1637: BoolArray array wrapper..
Fri, Apr 5, 1:49 PM
Stan added a comment to D1816: Remove wrong assignment introduced in rP21113.

In CPP casting to a smaller type will remove the leading byte.
https://stackoverflow.com/questions/6752567/casting-a-large-number-type-to-a-smaller-type

Fri, Apr 5, 11:12 AM

Thu, Apr 4

Stan added a comment to D1806: standardized structure aura descriptions.

I don't think there is any benefit. Unless JavaScript does some weird cast when it's not there ?

Thu, Apr 4, 8:52 AM

Wed, Apr 3

Stan added reviewers for D1812: Remove unused variable from ModelRenderer: Restricted Owners Package, vladislavbelov.
Wed, Apr 3, 7:38 PM
Stan updated the diff for D1584: Seed random sounds.

Put header back on top

Wed, Apr 3, 7:30 PM
Stan added inline comments to D1584: Seed random sounds.
Wed, Apr 3, 6:47 PM
Stan updated the diff for D1584: Seed random sounds.
  • Fix include order.
Wed, Apr 3, 6:46 PM
Stan updated the diff for D1584: Seed random sounds.
  • Remove useless cast.
Wed, Apr 3, 6:44 PM