Page MenuHomeWildfire Games

Stan (Stanislas Daniel Claude Dolcini)
User

User Details

User Since
Jan 6 2017, 3:41 PM (145 w, 1 d)

Recent Activity

Yesterday

Stan added a comment to D2382: [WIP] - Building Sockets..

The Settlement.js class should be updated/deleted/renamed :)

Sat, Oct 19, 1:19 AM

Fri, Oct 18

Stan added inline comments to D2379: Give the GarrisonHolder component the power to set garrisoned on an entity with UnitAI, instead of leaving it to UnitAI..
Fri, Oct 18, 7:45 PM
Stan added inline comments to D2367: Move "GarrisonVisibly" to a seperate function and create its counterpart..
Fri, Oct 18, 7:43 PM

Thu, Oct 17

Stan added inline comments to D2376: Store the garrisonHolder in cmpGarrisonable instead of iterating orders..
Thu, Oct 17, 11:41 PM
Stan added inline comments to D2379: Give the GarrisonHolder component the power to set garrisoned on an entity with UnitAI, instead of leaving it to UnitAI..
Thu, Oct 17, 5:47 PM
Stan added a comment to D1511: Patch to solve ticket #5165 (Zip files with comments trip assertion on game startup).

Segfault in tests for the record

Thu, Oct 17, 9:33 AM

Tue, Oct 15

Stan added a comment to D2372: [WIP] - Support for mining..

I guess unit carrying resources or on a resource should obey orders and leave the wall or maybe a flag in the garrison holder that says unit are able to 'dismount' and should ignore orders

Tue, Oct 15, 6:32 PM
Stan added a comment to D2372: [WIP] - Support for mining..

Tue, Oct 15, 6:23 PM
Stan updated subscribers of D2377: Fix text input max_length attribute..
In D2377#99209, @smiley wrote:

Since apparently I had commented on this before, I have a feeling this would not quite work the way it should in certain cases.
Then again, its just a feeling. Consider that before wasting hours on potentially nothing.

Tue, Oct 15, 4:58 PM
Stan updated subscribers of D2377: Fix text input max_length attribute..
Tue, Oct 15, 3:18 PM
Stan updated subscribers of D2377: Fix text input max_length attribute..
Tue, Oct 15, 3:18 PM
Stan added a comment to D2377: Fix text input max_length attribute..

Original patch was made by Amplikon, but has been mostly rewritten.

Tue, Oct 15, 3:17 PM
Stan created D2377: Fix text input max_length attribute..
Tue, Oct 15, 3:11 PM
Stan added a comment to D2362: Use seeding animation.

That inline got me wondering, wouldn't a saner implementation be to specify the build animation and fallback in the cmpIdentity ?

Tue, Oct 15, 3:06 PM
Stan added inline comments to D2376: Store the garrisonHolder in cmpGarrisonable instead of iterating orders..
Tue, Oct 15, 9:53 AM
Stan added a comment to rP22772: pthread -> std::thread (5/7) - Replace sdl semaphore with condition variable.

Can confirm it also affects windows + 10% CPU

Tue, Oct 15, 8:25 AM

Mon, Oct 14

Stan added a comment to rP23070: Fix the last remaining warnings introduced by rP23049.

I checked only checkrefs.pl warnings. Death and Sitting should be reexported

Mon, Oct 14, 1:27 PM
Stan awarded D2372: [WIP] - Support for mining. a Love token.
Mon, Oct 14, 8:51 AM

Sun, Oct 13

Stan committed rP23073: Add new rubble for the gaul civic_center..
Add new rubble for the gaul civic_center.
Sun, Oct 13, 7:17 PM
Stan created D2371: Allow to play upgrade animations .
Sun, Oct 13, 1:38 PM

Sat, Oct 12

Stan added inline comments to D1398: Fix shiftlag and implement HotkeyDown event, change HotkeyPress event to be non-repeating.
Sat, Oct 12, 11:25 PM
Stan updated the diff for D1190: Allow restoring lost wall turrets.

Remove more duplication.

Sat, Oct 12, 11:15 PM
Stan updated the diff for D1190: Allow restoring lost wall turrets.

Fix some comments

Sat, Oct 12, 10:59 PM
Stan added a comment to D1190: Allow restoring lost wall turrets.
In D1190#98997, @Imarok wrote:

Quickly tested the patch. Looks like a really nice behaviour. ๐Ÿ‘
But here are some things I noticed:

  • I think elexis mentioned it already: There is no way to get rid of the ghosts of dead towers.
Sat, Oct 12, 10:58 PM
Stan updated the diff for D1190: Allow restoring lost wall turrets.

Remove warning,
Make green turrets disappear when cancelling build

Sat, Oct 12, 8:23 PM
Stan committed rP23070: Fix the last remaining warnings introduced by rP23049.
Fix the last remaining warnings introduced by rP23049
Sat, Oct 12, 6:24 PM
Stan added inline comments to D2368: Move some logic from UnitAI's "Garrisoned"-state to "Garrison:Approaching"..
Sat, Oct 12, 12:27 PM

Fri, Oct 11

Stan updated the diff for D1190: Allow restoring lost wall turrets.

Rebase. Fix a few comments.

Fri, Oct 11, 4:21 PM
Stan commandeered D1190: Allow restoring lost wall turrets.
Fri, Oct 11, 4:21 PM

Thu, Oct 10

Stan added a comment to D2364: Add an option to display ranges when pressing the showstatusbars hotkey.

See IRC today, where the current configuration already allows for options, as one can press ALT+C or ALT+V to disable some overlays when in TAB mode.

Thu, Oct 10, 12:13 PM
Stan added a comment to D2353: L3 Ryzen 3000 Bugfix.

Thanks a lot for working on this :)

Thu, Oct 10, 10:31 AM
Stan added a comment to D2353: L3 Ryzen 3000 Bugfix.

@OptimusShepard will you update the patch ? :)

Thu, Oct 10, 10:03 AM
Stan added inline comments to D2364: Add an option to display ranges when pressing the showstatusbars hotkey.
Thu, Oct 10, 8:34 AM

Wed, Oct 9

Stan updated the Trac tickets for D2364: Add an option to display ranges when pressing the showstatusbars hotkey.
Wed, Oct 9, 6:01 PM
Stan created D2364: Add an option to display ranges when pressing the showstatusbars hotkey.
Wed, Oct 9, 5:49 PM
Stan added inline comments to D2079: Adds snapping to edges for buildings.
Wed, Oct 9, 4:05 PM

Tue, Oct 8

Stan updated the diff for D2338: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original name. Also restore the Wrapper name to reflect what it's wrapping and move it to renderer.

Fix ifndef now that the file got back its name.

Tue, Oct 8, 2:05 PM
Stan updated the diff for D2338: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original name. Also restore the Wrapper name to reflect what it's wrapping and move it to renderer.

Include fix.

Tue, Oct 8, 1:56 PM
Stan updated the diff for D2338: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original name. Also restore the Wrapper name to reflect what it's wrapping and move it to renderer.

Rename Wrapper to fit the classes in that folder.

Tue, Oct 8, 1:48 PM
Stan updated the diff for D2338: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original name. Also restore the Wrapper name to reflect what it's wrapping and move it to renderer.

Move declaration to constructor

Tue, Oct 8, 12:28 PM
Stan updated the diff for D2338: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original name. Also restore the Wrapper name to reflect what it's wrapping and move it to renderer.
  • Add setup function
  • use std::string and c_str()
Tue, Oct 8, 12:20 PM
Stan updated the diff for D2338: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original name. Also restore the Wrapper name to reflect what it's wrapping and move it to renderer.

Try to fix tests

Tue, Oct 8, 12:10 PM
Stan added a comment to D2338: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original name. Also restore the Wrapper name to reflect what it's wrapping and move it to renderer.

Diff with original version

Tue, Oct 8, 11:47 AM
Stan updated the diff for D2338: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original name. Also restore the Wrapper name to reflect what it's wrapping and move it to renderer.
  • Replace std::string by CStr8 (We need the length because the code casts Token to const char)
  • Move * pointer to the left
  • Move everything to graphics
  • Move tests next to the new code
Tue, Oct 8, 11:43 AM
Stan added inline comments to D1958: Turrets and/or sub-units..
Tue, Oct 8, 10:33 AM
Stan added a comment to D1958: Turrets and/or sub-units..

A few bugs, changing ownership in atlas (numpad keys) kills the turret instead of changing its ownership (Might be were the problem comes from)
Garrisoning a new unit doesn't put in a visible spot.
You edited the brit champion chariot but forgot to add a unit on top :)

Tue, Oct 8, 10:21 AM

Mon, Oct 7

Stan added inline comments to D2362: Use seeding animation.
Mon, Oct 7, 4:39 PM

Sun, Oct 6

Stan added inline comments to D2357: Adds ScreenshotWriter to minimise code duplication.
Sun, Oct 6, 7:49 PM

Sat, Oct 5

Stan added inline comments to D2360: Fix entities not retaining repair order after target transforms..
Sat, Oct 5, 11:43 PM
Stan added a comment to D1511: Patch to solve ticket #5165 (Zip files with comments trip assertion on game startup).

Regarding static_cast<off_t>(expr): I admit I never got around with the various kinds of casts offered by C++ (when I design SW on my own, I try and avoid casting alltogether). When updating the patch, I can still put it in.

Sat, Oct 5, 10:26 PM
Stan added inline comments to D2355: Rewrite session chat to use class syntax / object-oriented programming.
Sat, Oct 5, 7:21 PM
Stan added inline comments to D2357: Adds ScreenshotWriter to minimise code duplication.
Sat, Oct 5, 6:47 PM
Stan added inline comments to D2356: Adds BMPBlockWriter to prevent huge memory allocation.
Sat, Oct 5, 4:42 PM
Stan added inline comments to D2356: Adds BMPBlockWriter to prevent huge memory allocation.
Sat, Oct 5, 4:33 PM
Stan added inline comments to D2356: Adds BMPBlockWriter to prevent huge memory allocation.
Sat, Oct 5, 4:10 PM
Stan committed rP23055: Add missing garrisoned flag on the cart temple missing since rP18939.
Add missing garrisoned flag on the cart temple missing since rP18939
Sat, Oct 5, 2:27 PM
Stan added inline comments to D2355: Rewrite session chat to use class syntax / object-oriented programming.
Sat, Oct 5, 12:23 PM

Fri, Oct 4

Stan added a comment to D1958: Turrets and/or sub-units..

On the usage of std::set

Fri, Oct 4, 6:00 PM

Thu, Oct 3

Stan awarded D2353: L3 Ryzen 3000 Bugfix a Hungry Hippo token.
Thu, Oct 3, 10:12 PM
Stan awarded D2352: Adds containers serialization tests, std::set serialization and movement semantics a Like token.
Thu, Oct 3, 7:17 PM
Stan added a comment to rP23029: Cleanup CCmpRallyPointRenderer.

It doesn't like your testing code, only works properly on mingw32 https://code.wildfiregames.com/P185

Thu, Oct 3, 3:21 PM
Stan added a comment to rP23029: Cleanup CCmpRallyPointRenderer.

Most of the time everything is reset, because you change the flag position completely. The only case where you don't reset the vector is when you shift click IIRC.

Thu, Oct 3, 9:57 AM
Stan added inline comments to D2350: Cleanup Camera related code..
Thu, Oct 3, 9:54 AM

Wed, Oct 2

Stan added a comment to D2347: Splits Camera control from CGameView to separate file.

Just tested in Atlas and Combat Huge Demo without seeing any issues. Also run the tests successfully.

Wed, Oct 2, 10:16 PM
Stan added a comment to rP23029: Cleanup CCmpRallyPointRenderer.
In D1682#72623, @Stan wrote:

If you want more specific output https://pastebin.com/myEAnKEj
9000000 samples
cl.exe fine.cpp /EHsc
STD: Vector 'push_back' time:1.62
STD: Deque 'push_back' time: 2.193
STD: Vector 'emplace_back' time: 1.551
STD: Deque 'emplace_back' time: 2.222
STD: Vector 'erase' time: 1.236
STD: Deque 'erase' time: 10.948
cl.exe fine.cpp /EHsc /O1
STD: Vector 'push_back' time:0.428
STD: Deque 'push_back' time: 0.771
STD: Vector 'emplace_back' time: 0.468
STD: Deque 'emplace_back' time: 0.689
STD: Vector 'erase' time: 0.074
STD: Deque 'erase' time: 1.025
cl.exe fine.cpp /EHsc /O2
STD: Vector 'push_back' time:0.297
STD: Deque 'push_back' time: 0.647
STD: Vector 'emplace_back' time: 0.341
STD: Deque 'emplace_back' time: 0.64
STD: Vector 'erase' time: 0.029
STD: Deque 'erase' time: 0.62
cl.exe fine.cpp /EHsc /OX
STD: Vector 'push_back' time:0.299
STD: Deque 'push_back' time: 0.669
STD: Vector 'emplace_back' time: 0.345
STD: Deque 'emplace_back' time: 0.641
STD: Vector 'erase' time: 0.027
STD: Deque 'erase' time: 0.628

Wed, Oct 2, 8:03 PM
Stan committed rP23029: Cleanup CCmpRallyPointRenderer.
Cleanup CCmpRallyPointRenderer
Wed, Oct 2, 5:02 PM
Stan closed D1682: Cleanup RallyPointRenderer.
Wed, Oct 2, 5:01 PM
Stan added inline comments to D2347: Splits Camera control from CGameView to separate file.
Wed, Oct 2, 2:21 PM
Stan added a comment to D2348: Civ specific AI name numbers, don't hardcode roman numbers in the gamesetup.

It sounds weird to do that considering some of the names in the civ files already contains numbers ?

Wed, Oct 2, 2:17 PM
Stan added a comment to D2345: Sort GUI files into ObjectTypes ObjectBases SettingTypes subdirectories.

I had the same issue for D2338. Unfortunately the only solution I found was to clone the git repo, and do it there.

Wed, Oct 2, 11:38 AM
Stan added inline comments to D2347: Splits Camera control from CGameView to separate file.
Wed, Oct 2, 11:17 AM
Stan updated the diff for D2338: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original name. Also restore the Wrapper name to reflect what it's wrapping and move it to renderer.

Update copyright. @vladislavbelov I think the license bear does strange things.

Wed, Oct 2, 11:14 AM
Stan updated the diff for D2338: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original name. Also restore the Wrapper name to reflect what it's wrapping and move it to renderer.
Wed, Oct 2, 10:51 AM

Tue, Oct 1

Stan added inline comments to D2344: Don't leak GUI Object on name ambiguity, delete PS_ERROR_GUI codes, CGUI::UpdateObjects() and IGUIObject::AddToPointersMap.
Tue, Oct 1, 7:10 PM
Stan updated the diff for D2338: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original name. Also restore the Wrapper name to reflect what it's wrapping and move it to renderer.
Tue, Oct 1, 4:56 PM
Stan updated the diff for D2338: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original name. Also restore the Wrapper name to reflect what it's wrapping and move it to renderer.
  • ogre3d โ†’ ogre3d_preprocessor.
  • Try to fix build.
Tue, Oct 1, 4:44 PM
Stan added inline comments to D2338: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original name. Also restore the Wrapper name to reflect what it's wrapping and move it to renderer.
Tue, Oct 1, 4:25 PM
Stan updated the diff for D2338: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original name. Also restore the Wrapper name to reflect what it's wrapping and move it to renderer.

We must note that the error callback was removed in https://github.com/OGRECave/ogre/commit/856c276ebd4cb7100f4b133b0e5b29cbc8558653

Tue, Oct 1, 4:24 PM

Mon, Sep 30

Stan added a comment to D2284: Actually dont compile lobby code if building --without-lobby.

Could restart the build, was broken because of checkrefs.pl.

Mon, Sep 30, 5:13 PM
Stan added a comment to D2212: Show system_info.txt path in terminal when it's written.

Indeed debug_printf doesn't work on windows but that's because we use OutputDebugStringW which redirects to a special debug output instead https://stackoverflow.com/questions/55432747/showing-outputdebugstring-messages-with-window-application

Mon, Sep 30, 5:10 PM
Stan updated subscribers of rP23018: Rename JSInterface_GUITypes to JSInterface_GUISize, refs rP22531, rP22534..

I guess @Itms could add it to his script when he has some time :)

Mon, Sep 30, 4:21 PM
Stan updated the diff for D2338: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original name. Also restore the Wrapper name to reflect what it's wrapping and move it to renderer.

Update headers.

Mon, Sep 30, 3:36 PM
Stan updated the diff for D2338: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original name. Also restore the Wrapper name to reflect what it's wrapping and move it to renderer.

Now in git format from a git repo ladies and gentlemen.

Mon, Sep 30, 3:23 PM
Stan abandoned D1989: Allow accessing prop points in the simulation..
Mon, Sep 30, 2:21 PM
Stan updated the diff for D1989: Allow accessing prop points in the simulation..
  • Adds rotation to the mix, showing that no information is there about the negative Z
  • Hopefully fix the FromJsval() I'm not really confident with those things.
Mon, Sep 30, 2:21 PM
Stan added a comment to D2325: Remove virtual inheritance.

Maybe this could be of interest https://stackoverflow.com/questions/4899657/performance-impact-of-virtual-inheritance

Mon, Sep 30, 12:12 PM
Stan added a comment to D1989: Allow accessing prop points in the simulation..

Also I'm not sure we can Use sproppoint as it does not contain the correct prop location and will always need to be modified anyway

Mon, Sep 30, 12:09 PM
Stan updated the test plan for D1989: Allow accessing prop points in the simulation..
Mon, Sep 30, 12:02 PM
Stan added a comment to D1989: Allow accessing prop points in the simulation..

I assume this sentence is written because Phabricator refuses empty test fields.

Actually no, I guess I could improve it a bit. Else I would just have written a blank space.

Mon, Sep 30, 11:58 AM
Stan updated the diff for D2308: Extend the visible garrisoning schema to allow specific units on specific turrets..
  • Rename VisibleGarrisonAllowedClasses to AllowedClasses
  • Fix some linters warnings
Mon, Sep 30, 11:17 AM
Stan awarded rP23019: Resolve Loader memory leak from rP2232. a Pterodactyl token.
Mon, Sep 30, 10:50 AM
Stan added inline comments to D2308: Extend the visible garrisoning schema to allow specific units on specific turrets..
Mon, Sep 30, 10:24 AM

Sun, Sep 29

Stan added a comment to D1989: Allow accessing prop points in the simulation..

No I did not I'll see if that bring back the minus. Still lies the issue of non visual...

Sun, Sep 29, 10:47 PM
Stan updated the diff for D2338: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original name. Also restore the Wrapper name to reflect what it's wrapping and move it to renderer.

Remove all changes and just run svn diff -x -U5000 > file.diff

Sun, Sep 29, 7:41 PM
Stan updated the diff for D2338: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original name. Also restore the Wrapper name to reflect what it's wrapping and move it to renderer.

Try to fix the diff

Sun, Sep 29, 7:10 PM
Stan created D2338: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original name. Also restore the Wrapper name to reflect what it's wrapping and move it to renderer.
Sun, Sep 29, 7:00 PM
Stan accepted rP22964: Update the fast-actions cheat and AI bonuses to use the modifiers manager.

Fixed by rP23016

Sun, Sep 29, 4:33 PM
Stan added inline comments to D1191: Tributes break in diplomacy dialog if more than one resource is clicked while holding shift..
Sun, Sep 29, 4:33 PM
Stan added a comment to D2327: Add missing round when calculating trader gain, removed in "fast-actions cheat using modifiers manager"/rP22964.

Cause I tested it and that was the bug reported ?

Sun, Sep 29, 4:08 PM
Stan added a comment to D2327: Add missing round when calculating trader gain, removed in "fast-actions cheat using modifiers manager"/rP22964.

Yeah was a trade cart.

Sun, Sep 29, 3:59 PM