Mmh my apologies it seems my change wasn't totally correct.

Maybe then

There are some type mismatches, which could or could not introduce bugs.

I agree with the change IMHO it's just sexist and poorly put women still retain their other bonuses also, it's a tiny perf improvement as auras can be costly, the change is complete (the translation files will be updated by the script automatically)

https://pastebin.com/bbv0xkxx

Is it still extremely non trivial to use CTEXT instead, it's a bit weird to use "list" in the GUI when one means text?

It doesn't take ResourceTrickle into account though, not sure that's intended.

Rebase. I've made some header fixes so that it doesn't affect Windows and other non BSD oses.
There is a flaw with the implementation however, as it doesn't handle NAN QNAN FLOAT_MAX/INFINITY and FLOAT_MIN (It will segfault) it seems however that

1.2.1 There is no 1.2.1.1 yet https://github.com/kcat/openal-soft/releases

Headers.

Platform Changes looks alright but I'm not sure about the SSE ones we need to check it's not breaking stuff. Ideally we'd remove SSE and let the compilers decide. I asked someone else to look at it . He might have more insights.

Here are my conclusions

Test plan seems to work for me.

I'd like @vladislavbelov to have a look at the pure template code. This patch seems too big not to have undiscovered issues. Also you might want to rebase it so the CI can run on it.

While at it can you remove the useless const in the h files for SetInitEntities refs D3126

Fix notes and more warnings

Add missing then, sorry

Fix previous update, fmt has only delayload on windows

Fix Delayload warnings on windows and missing debug symbols linking warning This should be good to go now. Don't forget to manually replace the .lib files and the .pdb file else it will break because they will be 0kb

D2293 and the subsequent fixes.

I'm launching another build to check if the VM updates fixed it. You might want to rebase this.

Sicilia nomad starting camera position was broken by this commit. Raising a concern so it's somewhere.

punjab 2p
bdeska bog
barcania
corsica
median oasis
nearestearn badlands
nile river

Thanks!

I guess it's good to go then; I tried to break it but it seems to work fine. It's a bit weird for me to accept my own patch though.

Note that there are still a lot of references to

<TreatWarningAsError>true</TreatWarningAsError>

Well it's completely broken anyway. Might be nice to print the offending file though

Overall looks good to me

Interestingly he never answered https://github.com/rdb/fcollada/issues/1

Not really. We will have the most patched version once the other patches I made about it will be merged. I checked all the public forks.

Alternate fix based on feeback of wraitii and smiley

@s0602004 feel free to commandeer / update. Weird I didn't get your message on IRC