Did you forget the test file?

More auras less performance by the way.

Have you seen https://trac.wildfiregames.com/ticket/3362 ? It also talks about memory pools :)
Also worth mentioning it could maybe used for the Pathfinder https://trac.wildfiregames.com/ticket/3588#comment:4

@Freagarach I think this is superseeded by your patch.

@Freagarach

https://godbolt.org/z/v8jEfMx9W

Fair enough. Did you test multiplayer? Rejoining a match ? This shouldn't affect the simulation but it would be bad if it broke serialization or something.

Yes. I'd like people to accept it. It's a “big” change.

Fix @Langbart's notes, mark autoresearched techs as root, and reference paired techs. add deps for identity techs.

Thanks for testing. Wonder why it does not find the others I will investigate.

Seems there is no more leak anymore. :)
Did you test on combat demo huge ?

Feel free to make some improvements as well. :)

Profiler2 also allows you to load jsonp files from other runs to do the comparison :)

Hey @borg-
Thanks for the patch.

Does it make that code slower?

Can you fix all the while( to while ( and for( to for (?

Can we mitigate this? Now that we have a new RB we gained more time to fix things better.

Thanks for the patch.

LGTM, I was afraid it would mean a too small shadowmap (and thus low quality) on high end settings, but if @vladislavbelov says it's okay then it's fine by me.

Refs D4610 rP26815

I'm a bit torn between ugly buttons and overlapping text ^^ At least people are used to overlapping text?

AIEND seems not to support the removal of units, though.

Might wanna test units demo

We were talking about https://m.youtube.com/watch?v=qH6sSOr-yk8&feature=youtu.be might be of some interest to you too

I think you introduced a memory leak on Windows. This shows up in the test output failing them.

Can you show some screenshots and fix the lint warnings? :)

Might ask @AIEND specifically.

Fine by me.

@borg- feel free to accept if you like it. The sooner the balancing patches get merged the sooner RC2 comes and maybe becomes A26.

@real_tabasco_sauce No, it's not wrong to accept, in fact, we are more inclined to committing patches that have been formally accepted, since it's hard to get a consensus, it can give us a sense of majority.

Thanks for the update. No need to add the po files an automatic script takes cares of them :)

Well we agree. We were talking about it with Vladislav. The issue is that as of right now we don't have a way to restrict options per platform (e.g. the option menu doesn't know about the hardware and there is currently no coded way to make it aware of it) this is something we hope to have for A27

Sad, but okay. Might be nice to clean the template and remove the bonuses while at it.

Fixed?

Refs D3047

Good for me then.

Patch is complete, see P277.
You can commit it or I will.

Sure more options are always nice. I don't mind this being committed if @Freagarach agrees :)

Does it make sense to have two randoms? E.g. Random culture and Random ? I agree this should be the default.

@Langbart

Any change needed in BuildingAI?

Is it threads or threats?

@lyv @marder should the wall builder code be in some kind of globalscript and shared by the sim and the random maps?

In D4695#199629, @jprahman wrote:

Curious as well what sort of tooling 0AD has for template scanning/validation? I saw the templateanalyzer under source/tools, but that appears to be about balance analysis, rather than validation.

I don't see why we would ever need two profiler instances? Running multiple matches?

Looks like a bugfix that could go in for me but your call :)