Page MenuHomeWildfire Games

Stan (Stanislas Daniel Claude Dolcini)
User

User Details

User Since
Jan 6 2017, 3:41 PM (128 w, 3 d)

Recent Activity

Today

Stan updated subscribers of rP22397: #5445.

Usually one can write Fixes #5445 to automatically close tickets.
@Itms, we now need a AtlasUI autobuild for windows, not sure that's automatic yet.

Tue, Jun 25, 8:56 AM
Stan added a comment to rP22314: Fix a crash on some system when Alt-tabbing during game setup..

Sorry, should have been more specific.

Tue, Jun 25, 8:52 AM
Stan added a comment to rP22386: 3 New temperate maps by BigTiger..

Yeah I was waiting for something like D2009 which I would have done myself if someone hadn't come to the rescue. Will add the keyword soon.

Tue, Jun 25, 8:50 AM
Stan added a comment to rP22323: Further cleanup of MikkTSpace.

Pass pointers instead of arrays

How are arrays passed?

Tue, Jun 25, 8:49 AM

Yesterday

Stan added a comment to D1971: Support attack-ground for ranged units..

If you have some time, maybe it would be nice to have a small video on youtube demonstrating the feature. Nothing fancy.

Mon, Jun 24, 8:57 PM
Stan added a comment to D1337: Formation animation refactor.

Rebased - needs some cleaning, like the anti-cavalry formation no longer has a walk animation which is annoying - I guess I should group the animations better. The limit of one variant per file is quite annoying because it means one must change a lot of files every time -_-
Still would work with D1901

Mon, Jun 24, 8:00 PM
Stan added inline comments to D1969: Support infinite max range checks again in IsInXRange // Adapt unitMotion to edge-edge distance checks.
Mon, Jun 24, 6:28 PM
Stan added inline comments to D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..
Mon, Jun 24, 5:56 PM
Stan added a comment to D1971: Support attack-ground for ranged units..

Well it's up to wraitii to review those, so I guess up to him then.

Mon, Jun 24, 5:39 PM
Stan added a comment to rP22295: Target build version explicitly for Xcode.

Reviewed By: Wraitii

Reviewed By is reserved for people other than the author.
Comments By: Itms can be added when people influenced the patch without having accepting it.

Mon, Jun 24, 4:33 PM
Stan added a comment to rP22266: moves territory_pull.xml from other/ to special/ and updates the only file in….

No notes.
That these templates shall not appear in the list of placeable templates may be true, but there are also the generic templates that should not appear in that list.
Also that a template shall not appear to be placeable doesn't mean that it is impossible to place it if it would appear in the list.
Hence unplaceable/ would also be imperfect.
Another possibility would be hidden/, but that also is ambiguous. Everything is ambiguous.
Perhaps unplaceable/ and a README.txt defining unplaceable/ as not appearing in the Atlas list of entities would be the solution that satisfies all problems (including the clarification that a template that may technically be placed may be contained in that folder).

Mon, Jun 24, 4:30 PM

Sun, Jun 23

Stan added a comment to rP22266: moves territory_pull.xml from other/ to special/ and updates the only file in….

@elexis did you get the notes ? :)

Sun, Jun 23, 9:27 PM
Stan added inline comments to D1971: Support attack-ground for ranged units..
Sun, Jun 23, 8:31 PM
Stan updated the diff for D825: Atlas: Allow map to recenter during resize.

Try to fix the build on Linux

Sun, Jun 23, 6:01 PM
Stan added inline comments to D1971: Support attack-ground for ranged units..
Sun, Jun 23, 5:31 PM
Stan added inline comments to rP22241: Add a map to be able to test which foundation fits best an actor..
Sun, Jun 23, 2:44 PM
Stan added a comment to rP22151: New berry bushes by BigTiger.

Maybe ?

Sun, Jun 23, 12:46 PM
Stan added a comment to rP22151: New berry bushes by BigTiger.

The hue is slightly different.

Sun, Jun 23, 10:48 AM

Sat, Jun 22

Stan requested verification of rP22151: New berry bushes by BigTiger.
Sat, Jun 22, 11:26 PM
Stan committed rP22394: Remove two duplicate textures and models. They were incorrectly added in….
Remove two duplicate textures and models. They were incorrectly added in…
Sat, Jun 22, 10:54 PM
Stan updated the diff for D825: Atlas: Allow map to recenter during resize.
  • Whitespace
  • Static_cast
  • spaces to tabs
  • rebase
Sat, Jun 22, 2:40 PM
Stan commandeered D825: Atlas: Allow map to recenter during resize.

Commandeering to rebase @Clockwork-Muse feel free to commandeer back if you want to continue working on it.

Sat, Jun 22, 2:40 PM
Stan added inline comments to D1971: Support attack-ground for ranged units..
Sat, Jun 22, 12:06 PM

Fri, Jun 21

Stan added a comment to D1971: Support attack-ground for ranged units..

That sounds good and maybe actually better than being that precise though the shape should differ depending on the type of attacker. However I beleive that the spread parameter is made for that. One could use that to compute the circle.

Fri, Jun 21, 6:49 PM
elexis awarded rP21965: New Persian Farsi voices by dMZeroCold & dMAthena. a Like token.
Fri, Jun 21, 1:39 PM

Thu, Jun 20

Stan added a comment to D1971: Support attack-ground for ranged units..
Thu, Jun 20, 10:32 PM
Stan added inline comments to D1971: Support attack-ground for ranged units..
Thu, Jun 20, 9:12 PM
Stan added inline comments to D1971: Support attack-ground for ranged units..
Thu, Jun 20, 5:59 PM
Stan added a comment to D1954: Do not send Reflection and Refraction matrices to shader when not needed.

@wraitii Thoughts on this ?

Thu, Jun 20, 3:45 PM
Stan added a reviewer for D1943: UnitAI fix return value on "enter" according to FSM logic: wraitii.
Thu, Jun 20, 3:44 PM
Stan added a reviewer for D1396: Silence C4351: vladislavbelov.
Thu, Jun 20, 3:43 PM
D1670: Remove references to globals now requires review to proceed.

I think it would be nice to have this.

Thu, Jun 20, 3:42 PM
Stan added a reviewer for D1604: Make capturing optional: Restricted Owners Package.

@wraitii @Freagarach.

Thu, Jun 20, 3:40 PM
Stan added a comment to D1483: Use Homebrew to fetch OSX libraries instead of compiling them all.

Well maybe you guys could try to use my conan patch ? You will need to change the copy to osx instead of win32 and likely edit premake libs.

Thu, Jun 20, 8:55 AM
Stan abandoned D1691: Remove boost "system" from Mac OS build system..

I'm abandoning this :) It probably can be reopened when we actually remove these references.

Thu, Jun 20, 8:52 AM
Stan raised a concern with rP22352: Unit Motion - wrap target state into a struct.

Raising concern for a warning reported by @Krinkle. No biggie but the entity parameter isn't used anymore.

Thu, Jun 20, 8:50 AM
Stan added a comment to D1691: Remove boost "system" from Mac OS build system..

Yeah I don't think that will work ever. I'm not sure where @fabio saw that it could be removed.

Thu, Jun 20, 8:28 AM
Stan added a comment to D1993: petra: Fix all ESLint and JSHint warnings.

Maybe you can fix the last two warning (trailing dots)

Thu, Jun 20, 12:06 AM

Wed, Jun 19

Stan added a comment to D1993: petra: Fix all ESLint and JSHint warnings.

The auto fix failed I guess.

Wed, Jun 19, 11:18 PM
Stan added inline comments to D1971: Support attack-ground for ranged units..
Wed, Jun 19, 9:44 PM
Stan updated subscribers of D1993: petra: Fix all ESLint and JSHint warnings.
In D1993#83293, @Stan wrote:

Before this get committed you might as well want to fix the warnings that appeared in the Vulkan console.

The only remaining one should be for curly. Due to there being almost 50/50 adherence to that, I wasn't sure whether it is a style we still want to follow consistently or whether it might be something we want to disable and allow developer to choose on case-by-case basis whether curly braces are useful.

Wed, Jun 19, 9:38 PM
Stan added a comment to D1993: petra: Fix all ESLint and JSHint warnings.

Hoping to see this land relatively soon to avoid merge conflicts, after that I'll move on to the next area to lint :)

Wed, Jun 19, 6:20 PM
Stan added inline comments to D1971: Support attack-ground for ranged units..
Wed, Jun 19, 5:31 PM
Stan added a comment to D1950: Create "Damage"-container for damage types in templates..
In D1950#83214, @Nescio wrote:

Ideally different projectiles would also be able to have different damage, therefore what is eventually desirable is support for multiple ranged attacks, e.g. a fortress able to fire both arrows (long range, low damage) and javelins (shorter range, higher damage).

Wed, Jun 19, 11:34 AM
Stan added inline comments to D1971: Support attack-ground for ranged units..
Wed, Jun 19, 10:21 AM
Stan added a comment to D2000: standardize aura format.

Most of the time Anything between {} is part of an object. anything between [] is part of an array

Wed, Jun 19, 12:23 AM

Tue, Jun 18

Stan added inline comments to D2001: [AI] Small cleanup in defenseManager.
Tue, Jun 18, 10:03 PM
Stan added inline comments to D1938: Easier introduction of new damage types..
Tue, Jun 18, 10:00 PM
Stan added a comment to D1938: Easier introduction of new damage types..

Well if you can fix the ai that's nice.

Tue, Jun 18, 7:14 PM
Stan added inline comments to D1938: Easier introduction of new damage types..
Tue, Jun 18, 6:35 PM
Stan added inline comments to D1938: Easier introduction of new damage types..
Tue, Jun 18, 3:14 PM
Stan added inline comments to D2000: standardize aura format.
Tue, Jun 18, 3:12 PM
Stan committed rP22389: Fix a little glitch on the Athenian storehouse..
Fix a little glitch on the Athenian storehouse.
Tue, Jun 18, 2:15 PM
Stan committed rP22388: Remove three unused capes..
Remove three unused capes.
Tue, Jun 18, 11:35 AM
Stan added inline comments to D1999: correct Roman specific names.
Tue, Jun 18, 8:40 AM
Stan committed rP22387: Improve starting position camera for Oceanside (2).
Improve starting position camera for Oceanside (2)
Tue, Jun 18, 12:34 AM
Stan raised a concern with rP22348: Delete old redistributables for VS 2010, and add new ones for VS 2015. Refs….

broke debug build. instant segfault

Tue, Jun 18, 12:29 AM

Mon, Jun 17

Stan added a comment to D1995: Fix missing "Damage"-node in examples..

Can you fix the capitals I reported as well in this diff ?

Mon, Jun 17, 8:28 PM
Stan committed rP22386: 3 New temperate maps by BigTiger..
3 New temperate maps by BigTiger.
Mon, Jun 17, 8:24 PM
Stan committed rP22385: New particle actors by BigTiger..
New particle actors by BigTiger.
Mon, Jun 17, 8:23 PM
Stan committed rP22384: New terrain textures by BigTiger for the temperate biome..
New terrain textures by BigTiger for the temperate biome.
Mon, Jun 17, 8:23 PM
Stan committed rP22383: New bushes, trees (Oaks, firs, Birch) by Big Tiger, as well as new cliffs, and….
New bushes, trees (Oaks, firs, Birch) by Big Tiger, as well as new cliffs, and…
Mon, Jun 17, 8:22 PM
Stan added a comment to rP22379: Wrap damage types in a Damage element in XML templates to prepare for….

Yeah new diff. Not good combining fixes with other stuff.

Mon, Jun 17, 5:58 PM
Stan awarded D1994: Fix missing slash in common-api a Like token.
Mon, Jun 17, 3:37 PM
Stan added inline comments to rP22314: Fix a crash on some system when Alt-tabbing during game setup..
Mon, Jun 17, 11:05 AM
Stan added inline comments to rP22314: Fix a crash on some system when Alt-tabbing during game setup..
Mon, Jun 17, 10:42 AM
Stan added inline comments to rP22379: Wrap damage types in a Damage element in XML templates to prepare for….
Mon, Jun 17, 8:14 AM

Sun, Jun 16

Stan raised a concern with rP22314: Fix a crash on some system when Alt-tabbing during game setup..

This breaks sounds for me. I believe that maybe g_SoundManager->IdleTask(); gets called too often ?

Sun, Jun 16, 11:54 PM
Stan added a comment to D1945: DamageTypes lowercase..

I'm not really for this. If anything resource should start with a capital instead.

Sun, Jun 16, 10:26 PM
Stan added inline comments to D1986: simulation tests: eslint fixes for no-use-before-define.
Sun, Jun 16, 10:25 PM
Stan updated the diff for D1718: Decay/regenerate option for resources when not being gathered from.
  • Add aura tests.
Sun, Jun 16, 8:45 PM
Stan added inline comments to D1986: simulation tests: eslint fixes for no-use-before-define.
Sun, Jun 16, 5:14 PM
Stan added inline comments to D1971: Support attack-ground for ranged units..
Sun, Jun 16, 1:39 PM
Stan added a comment to D1950: Create "Damage"-container for damage types in templates..
In D1950#82751, @Stan wrote:

I guess you broke the tests :)

Yeah, by removing those spaces?

Sun, Jun 16, 12:59 PM
Stan added inline comments to D1989: Allow accessing prop points in the simulation..
Sun, Jun 16, 12:59 PM
Stan created D1989: Allow accessing prop points in the simulation..
Sun, Jun 16, 12:58 PM
Stan added a comment to D1950: Create "Damage"-container for damage types in templates..

I guess you broke the tests :)

Sun, Jun 16, 12:53 PM
Stan added a comment to D1971: Support attack-ground for ranged units..

Just for reference the vector issue might be http://trac.wildfiregames.com/ticket/5376

Sun, Jun 16, 9:52 AM

Sat, Jun 15

Stan added a reviewer for D1986: simulation tests: eslint fixes for no-use-before-define: Restricted Owners Package.
Sat, Jun 15, 11:55 PM
Stan awarded D1986: simulation tests: eslint fixes for no-use-before-define a Like token.
Sat, Jun 15, 11:54 PM
Stan added inline comments to D1984: Combine Goal computation logic from MoveToPoint and MoveToTarget.
Sat, Jun 15, 11:52 PM
Stan added inline comments to D1982: UnitMotion - make ComputeTargetPosition return a position for point goals.
Sat, Jun 15, 11:49 PM
Stan added inline comments to D1974: Tests for D1879 - Fix limit restriction for training units in ProductionQueue.
Sat, Jun 15, 11:44 PM
Stan added a comment to D1925: High-DPI screen support.

The bars are somewhat brighter also.

Sat, Jun 15, 11:43 PM
Stan added a member for Contributors: Krinkle.
Sat, Jun 15, 11:37 PM
Stan added a comment to D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..
In D1846#82413, @Stan wrote:

I wonder if we shouln't have
GetTributableCodes, GetBarterableCodes, GetTradableCodes, to avoid hardcoding magic strings all over the place.

That's how it was before... I didn't like that because it means you have to add a whole new function for any new property. I don't think there's much difference between hardcoding strings and hardcoding function names.

Sat, Jun 15, 5:17 PM
Stan added a comment to D1976: Remove gamma ramp setting..

I think the patch should be tested on multi-monitor environment and with a custom color space.

Sat, Jun 15, 4:47 PM
Stan added inline comments to D1971: Support attack-ground for ranged units..
Sat, Jun 15, 4:15 PM
Stan added inline comments to D1971: Support attack-ground for ranged units..
Sat, Jun 15, 4:08 PM
Stan added inline comments to D1661: lobby bots systemd service.
Sat, Jun 15, 4:03 PM
Stan added a comment to D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..

I wonder if we shouln't have

Sat, Jun 15, 3:55 PM
Stan updated the diff for D1718: Decay/regenerate option for resources when not being gathered from.
  • Do not break the test in the process
Sat, Jun 15, 3:39 PM
Stan updated the diff for D1718: Decay/regenerate option for resources when not being gathered from.

Fix warnings

Sat, Jun 15, 3:36 PM
Stan updated the diff for D1718: Decay/regenerate option for resources when not being gathered from.
  • Use function for the tests to remove duplication.
Sat, Jun 15, 12:55 PM
Stan added a comment to D1718: Decay/regenerate option for resources when not being gathered from.

It seems to me like your tests could be abstracted in a function to remove a lot of redundancy.

Easier to deal with auras and whatnot.

OK, so I guess your position is that you want to enable having a "faster fattening" aura/tech that changes ResourceSupply/Fattening/Value, instead of having a tech that changes ResourceSupply/Alive/Value and only affects items with Identity classes Organic, Domestic for example. That's internally coherent, and I do agree that on the surface it seems more craftier - both systems actually allow the same thing but using identity classes might force one to add arbitrary identity classes to templates, which seems undesirable.
However this doesn't seem obvious from reading the code, nor the tests. I think you should be able to add an Aura in the tests that only affects Fattening, not say Growth, to highlight that.

Didn't we have that discussion already that it was particularly tricky to add auras during the tests ?

I'm not sure where this would be best to document, perhaps in the schema as a a:help or as a comment?

Sat, Jun 15, 12:17 PM
Stan added inline comments to D1971: Support attack-ground for ranged units..
Sat, Jun 15, 12:10 PM
Stan added a comment to D1973: Enable support for friendly fire for normal ranged attacks..

On (2), I don't think this should be added to the Ranged attack root. Rather, it should be added to the projectile - because friendly fire for non-ranged attacks makes no sense, and "ranged" attacks only real difference is the presence of a projectile. See rP20676 and rP22184. If you add it to the projectile, the splash damage definition can keep its FriendlyFire attribute, since Melee attacks dealing splash damage with or without friendly fire makes sense. In fact, the splash from ranged attack should probably be moved under projectile but that's out of scope.

Sat, Jun 15, 12:00 PM
Stan added inline comments to D281: Transform "Upgrade.js" into an "Abilities.js" that is much more generic..
Sat, Jun 15, 11:57 AM
Stan added a comment to D1858: Add a MultiKeyMap helper and tests (+ allow tests in /helpers) - D274 prereq.

Haven't checked performance, but maybe that would be better to do data structures in C++ ? I'm sure boost or the stl have already such containers ?

Sat, Jun 15, 11:39 AM
Stan added a comment to D274: Handle modifications of technologies and auras in a system component.

Some more comments, maybe it would be nice to add one test or two in attack.js to show how to use it for test purposes.

Sat, Jun 15, 11:38 AM