Page MenuHomeWildfire Games

Stan (Stanislas Daniel Claude Dolcini)
Butler

User Details

User Since
Jan 6 2017, 3:41 PM (286 w, 2 d)

Recent Activity

Today

Stan added a comment to D4718: Allocator and generator for component data..

Did you forget the test file?

Mon, Jul 4, 12:12 AM

Sat, Jul 2

Stan added inline comments to D4718: Allocator and generator for component data..
Sat, Jul 2, 2:19 PM
Stan added inline comments to D4682: Profiler2 lives in main().
Sat, Jul 2, 2:15 PM

Thu, Jun 30

Stan added a comment to D4722: Balance Fanatic.

More auras less performance by the way.

Thu, Jun 30, 5:24 PM
Stan committed rP26994: Fix flickering tooltip for user report button.
Fix flickering tooltip for user report button
Thu, Jun 30, 3:35 PM
Stan published D4722: Balance Fanatic for review.
Thu, Jun 30, 3:18 PM
Stan added inline comments to D4718: Allocator and generator for component data..
Thu, Jun 30, 7:04 AM
Stan added a comment to D4718: Allocator and generator for component data..

Have you seen https://trac.wildfiregames.com/ticket/3362 ? It also talks about memory pools :)
Also worth mentioning it could maybe used for the Pathfinder https://trac.wildfiregames.com/ticket/3588#comment:4

Thu, Jun 30, 6:58 AM

Wed, Jun 29

Herald added a reviewer for D1731: Allow to use multiple technologies as requirements for unit training and construction: Restricted Owners Package.

@Freagarach I think this is superseeded by your patch.

Wed, Jun 29, 6:36 PM
Stan updated subscribers of D1595: Ranged units attacks melee when target in minimum ranged attack range.

@Freagarach

Wed, Jun 29, 6:35 PM
Stan added a comment to D4718: Allocator and generator for component data..

https://godbolt.org/z/v8jEfMx9W

Wed, Jun 29, 1:12 PM
Stan added inline comments to D4718: Allocator and generator for component data..
Wed, Jun 29, 12:43 PM

Tue, Jun 28

Stan committed rP26992: Remove unused han_hero_wei_qing_3.json aura. .
Remove unused han_hero_wei_qing_3.json aura.
Tue, Jun 28, 3:48 PM
Stan added a comment to D4718: Allocator and generator for component data..

Fair enough. Did you test multiplayer? Rejoining a match ? This shouldn't affect the simulation but it would be bad if it broke serialization or something.

Tue, Jun 28, 12:06 AM

Mon, Jun 27

Stan added a comment to D4724: [Gameplay] Differentiating Persian.

Yes. I'd like people to accept it. It's a “big” change.

Mon, Jun 27, 5:20 PM
Stan committed rP26991: Add techs and auras to the list of possibly missing files..
Add techs and auras to the list of possibly missing files.
Mon, Jun 27, 4:31 PM
Stan closed D4725: Add techs and auras to the list of possibly missing files .
Mon, Jun 27, 4:31 PM
Stan updated the diff for D4725: Add techs and auras to the list of possibly missing files .

Fix @Langbart's notes, mark autoresearched techs as root, and reference paired techs. add deps for identity techs.

Mon, Jun 27, 3:16 PM
Stan added a comment to D4725: Add techs and auras to the list of possibly missing files .

Thanks for testing. Wonder why it does not find the others I will investigate.

Mon, Jun 27, 9:27 AM
Stan added a comment to D4718: Allocator and generator for component data..

Seems there is no more leak anymore. :)
Did you test on combat demo huge ?

Mon, Jun 27, 8:45 AM
Stan added a comment to D4719: graph2.html and graph2.js.

Feel free to make some improvements as well. :)

Mon, Jun 27, 8:42 AM
Stan added a comment to D4719: graph2.html and graph2.js.

Profiler2 also allows you to load jsonp files from other runs to do the comparison :)

Mon, Jun 27, 12:32 AM

Sun, Jun 26

Stan resigned from rP26986: [GUI] increase msgbox button size to fix text overlap.
Sun, Jun 26, 6:08 PM
Stan added a comment to D4698: Fix entvalidate.py.
#!/usr/bin/env python3
# -*- mode: python-mode; python-indent-offset: 4; -*-
# SPDX-License-Identifier: GPL-2.0-or-later
# SPDX-FileCopyrightText: © 2022 Wildfire Games
Sun, Jun 26, 6:06 PM
Stan updated subscribers of D4725: Add techs and auras to the list of possibly missing files .
Sun, Jun 26, 5:48 PM
Stan added a comment to D4724: [Gameplay] Differentiating Persian.

Hey @borg-
Thanks for the patch.

Sun, Jun 26, 3:26 PM

Sat, Jun 25

Stan added reviewers for D4728: No recursive calls in FunctionWrapper.h: wraitii, vladislavbelov.
Sat, Jun 25, 12:10 PM
Stan added a comment to D4728: No recursive calls in FunctionWrapper.h.

Does it make that code slower?

Sat, Jun 25, 12:09 PM
Stan added reviewers for D4719: graph2.html and graph2.js: Restricted Owners Package, vladislavbelov, wraitii.
Sat, Jun 25, 11:28 AM
Stan added a comment to D4718: Allocator and generator for component data..

Can you fix all the while( to while ( and for( to for (?

Sat, Jun 25, 10:35 AM

Fri, Jun 24

Stan requested review of D4725: Add techs and auras to the list of possibly missing files .
Fri, Jun 24, 8:32 PM
Stan raised a concern with rP26986: [GUI] increase msgbox button size to fix text overlap.

Can we mitigate this? Now that we have a new RB we gained more time to fix things better.

Fri, Jun 24, 5:36 PM

Thu, Jun 23

Stan committed rP26983: Logic fix for very high shadows on very large screens. .
Logic fix for very high shadows on very large screens.
Thu, Jun 23, 7:06 PM
Stan closed D4723: Performance fix for very high shadows on very large screens..
Thu, Jun 23, 7:06 PM
Stan added a comment to D4723: Performance fix for very high shadows on very large screens..

Thanks for the patch.

Thu, Jun 23, 7:04 PM
Stan added a member for Contributors: karmux.
Thu, Jun 23, 6:01 PM
Stan accepted D4723: Performance fix for very high shadows on very large screens..

LGTM, I was afraid it would mean a too small shadowmap (and thus low quality) on high end settings, but if @vladislavbelov says it's okay then it's fine by me.

Thu, Jun 23, 2:54 PM

Wed, Jun 22

Stan added a comment to P279 Find missing macro/symbol headers.

Refs D4610 rP26815

Wed, Jun 22, 3:11 PM
Stan added a comment to P279 Find missing macro/symbol headers.
$ python ./find-missing-config2-includes.py -m "CONFIG2_"  -v
INFO - Parsing C:\Dev\Perso\0ad-svn\source
INFO - Found 709 source files to parse.
INFO - Found 795 header files to parse.
INFO - Found 14 files with missing headers for CONFIG2_.
ERROR - C:\Dev\Perso\0ad-svn\source\graphics\TextureConverter.cpp
ERROR - C:\Dev\Perso\0ad-svn\source\lobby\scripting\JSInterface_Lobby.cpp
ERROR - C:\Dev\Perso\0ad-svn\source\renderer\backend\gl\ShaderProgram.cpp
ERROR - C:\Dev\Perso\0ad-svn\source\renderer\backend\gl\DeviceCommandContext.cpp
ERROR - C:\Dev\Perso\0ad-svn\source\ps\Profiler2GPU.cpp
ERROR - C:\Dev\Perso\0ad-svn\source\graphics\TextureConverter.h
ERROR - C:\Dev\Perso\0ad-svn\source\renderer\ShadowMap.cpp
ERROR - C:\Dev\Perso\0ad-svn\source\ps\Profiler2GPU.h
ERROR - C:\Dev\Perso\0ad-svn\source\ps\GameSetup\HWDetect.cpp
ERROR - C:\Dev\Perso\0ad-svn\source\renderer\backend\gl\Device.cpp
ERROR - C:\Dev\Perso\0ad-svn\source\renderer\SceneRenderer.cpp
ERROR - C:\Dev\Perso\0ad-svn\source\lib\posix\posix_aio.h
ERROR - C:\Dev\Perso\0ad-svn\source\ps\Util.cpp
ERROR - C:\Dev\Perso\0ad-svn\source\ps\scripting\JSInterface_Game.cpp
Wed, Jun 22, 3:09 PM
Stan created P279 Find missing macro/symbol headers.
Wed, Jun 22, 3:08 PM
Stan added a comment to D4707: [GUI] increase msgbox button size to fix text overlap.

I'm a bit torn between ugly buttons and overlapping text ^^ At least people are used to overlapping text?

Wed, Jun 22, 3:07 PM
Stan added a comment to D4713: [balance] Han unit roster restructure.

AIEND seems not to support the removal of units, though.

Wed, Jun 22, 2:43 PM
Stan added inline comments to D4718: Allocator and generator for component data..
Wed, Jun 22, 1:27 AM

Tue, Jun 21

Stan added a comment to D4718: Allocator and generator for component data..

Might wanna test units demo

Tue, Jun 21, 10:30 PM
Stan added a comment to D4718: Allocator and generator for component data..

We were talking about https://m.youtube.com/watch?v=qH6sSOr-yk8&feature=youtu.be might be of some interest to you too

Tue, Jun 21, 10:30 PM
Stan added inline comments to D4718: Allocator and generator for component data..
Tue, Jun 21, 9:57 PM
Stan added inline comments to D4718: Allocator and generator for component data..
Tue, Jun 21, 3:32 PM
Stan added a comment to D4718: Allocator and generator for component data..

I think you introduced a memory leak on Windows. This shows up in the test output failing them.

Tue, Jun 21, 3:22 PM
Stan committed rP26978: Add missing frequency for the idle variant..
Add missing frequency for the idle variant.
Tue, Jun 21, 7:39 AM
Stan added a comment to D4719: graph2.html and graph2.js.

Can you show some screenshots and fix the lint warnings? :)

Tue, Jun 21, 7:22 AM

Mon, Jun 20

Stan added a comment to D4713: [balance] Han unit roster restructure.

Might ask @AIEND specifically.

Mon, Jun 20, 11:09 PM
Stan retitled D4713: [balance] Han unit roster restructure from [balance] Han unit rooster restructure to [balance] Han unit roster restructure.
Mon, Jun 20, 11:07 PM
Stan accepted D4706: [graphics] Adjust default config to give a better first impression.

Fine by me.

Mon, Jun 20, 9:22 PM
Stan added a comment to D4704: [balancing] allow kushite axe champions in p2.

@borg- feel free to accept if you like it. The sooner the balancing patches get merged the sooner RC2 comes and maybe becomes A26.

Mon, Jun 20, 6:10 PM · Balancing
Stan added a comment to D4711: [balance] Move ptol heroes to the fortress.

@real_tabasco_sauce No, it's not wrong to accept, in fact, we are more inclined to committing patches that have been formally accepted, since it's hard to get a consensus, it can give us a sense of majority.

Mon, Jun 20, 5:58 PM
Stan added inline comments to D4709: [balancing] Han - Hero adjustments .
Mon, Jun 20, 5:50 PM
Stan committed rP26971: Fix some capes not having approaching animations..
Fix some capes not having approaching animations.
Mon, Jun 20, 3:48 PM
Stan added a comment to D4623: Fix quicksave not appearing in the menu.

Thanks for the update. No need to add the po files an automatic script takes cares of them :)

Mon, Jun 20, 2:58 PM
Stan committed rP26969: Bump the max amount of instanced icons to 256 to account for Egypt 3v3 as….
Bump the max amount of instanced icons to 256 to account for Egypt 3v3 as…
Mon, Jun 20, 9:14 AM
Stan added a comment to D4706: [graphics] Adjust default config to give a better first impression.

Well we agree. We were talking about it with Vladislav. The issue is that as of right now we don't have a way to restrict options per platform (e.g. the option menu doesn't know about the hardware and there is currently no coded way to make it aware of it) this is something we hope to have for A27

Mon, Jun 20, 8:39 AM

Sun, Jun 19

Stan committed rP26966: Add a new type of flower for decoration.
Add a new type of flower for decoration
Sun, Jun 19, 10:22 PM
Stan committed rP26965: Add missing file in Phab:rP26961.
Add missing file in Phab:rP26961
Sun, Jun 19, 10:22 PM
Stan created P278 Script to find merged gathering and carry units..
Sun, Jun 19, 10:15 PM
Stan committed rP26964: Fix missing animations for grain gathering for spearmen. This workarounds a bug….
Fix missing animations for grain gathering for spearmen. This workarounds a bug…
Sun, Jun 19, 10:06 PM
Stan committed rP26963: Fix missing animations for grain gathering for swordsmen. This workarounds a….
Fix missing animations for grain gathering for swordsmen. This workarounds a…
Sun, Jun 19, 9:53 PM
Stan committed rP26962: Fix missing animations for grain gathering for pikemen. is workarounds a bug in….
Fix missing animations for grain gathering for pikemen. is workarounds a bug in…
Sun, Jun 19, 9:46 PM
Stan committed rP26961: Fix missing animations for grain gathering for han units. This workarounds a….
Fix missing animations for grain gathering for han units. This workarounds a…
Sun, Jun 19, 9:28 PM
Stan committed rP26960: Fix UVMap on tool_hoe2.dae..
Fix UVMap on tool_hoe2.dae.
Sun, Jun 19, 7:29 PM
Stan committed rP26959: Properly clear back props when gathering. EOL native..
Properly clear back props when gathering. EOL native.
Sun, Jun 19, 7:29 PM
Stan accepted D4708: [balancing] Han - remove Laozi Gate.
Sun, Jun 19, 4:00 PM
Stan added a comment to D4708: [balancing] Han - remove Laozi Gate.

Sad, but okay. Might be nice to clean the template and remove the bonuses while at it.

Sun, Jun 19, 4:00 PM
Stan added inline comments to D4709: [balancing] Han - Hero adjustments .
Sun, Jun 19, 3:57 PM
Stan added inline comments to D4706: [graphics] Adjust default config to give a better first impression.
Sun, Jun 19, 3:46 PM
Stan added inline comments to D4706: [graphics] Adjust default config to give a better first impression.
Sun, Jun 19, 1:01 PM
Stan added a comment to rP26922: Fixes LOS flickering because of float precision. Fixes #6546.

Fixed?

Sun, Jun 19, 1:07 AM
Stan requested verification of rP26801: Allow setting the passability class dynamically. This is needed to improve….
Sun, Jun 19, 12:43 AM

Sat, Jun 18

Stan added a reviewer for D4705: Remove sys_generate_random_bytes: Restricted Owners Package.

Refs D3047

Sat, Jun 18, 4:56 PM
Stan committed rP26953: Update the mod.io key so I and other team members can sign mods..
Update the mod.io key so I and other team members can sign mods.
Sat, Jun 18, 11:50 AM
Stan accepted D4703: Choose civ randomly in gamesetup.

Good for me then.

Sat, Jun 18, 10:38 AM

Fri, Jun 17

Stan accepted D4695: Fix Naval Shipyard..

Patch is complete, see P277.
You can commit it or I will.

Fri, Jun 17, 10:58 PM
Stan created P277 Production Queue Validator.
Fri, Jun 17, 10:58 PM
Stan committed rP26951: Add `garrisoned` and `projectile` prop points to the han farmstead and….
Add `garrisoned` and `projectile` prop points to the han farmstead and…
Fri, Jun 17, 10:00 PM
Stan added inline comments to D4677: span and string_view for CmdLineArgs.
Fri, Jun 17, 2:21 PM
Stan abandoned D4527: Don't segfault on autostart nonVisual games after rP26584.
Fri, Jun 17, 12:05 PM

Thu, Jun 16

Stan updated subscribers of D4703: Choose civ randomly in gamesetup.

Sure more options are always nice. I don't mind this being committed if @Freagarach agrees :)

Thu, Jun 16, 10:57 AM
Stan added a comment to D4703: Choose civ randomly in gamesetup.

Does it make sense to have two randoms? E.g. Random culture and Random ? I agree this should be the default.

Thu, Jun 16, 10:23 AM
Stan added inline comments to D4702: Groups close minimap icons to decrease their visible count.
Thu, Jun 16, 10:21 AM
Stan added inline comments to D4702: Groups close minimap icons to decrease their visible count.
Thu, Jun 16, 8:59 AM

Wed, Jun 15

Stan added inline comments to D4702: Groups close minimap icons to decrease their visible count.
Wed, Jun 15, 9:52 PM

Tue, Jun 14

Stan added inline comments to D4697: [Gameplay] Switch default behavior from capture to attack.
Tue, Jun 14, 4:48 PM
Stan updated subscribers of D4700: Fixes same frames for LOS smooth textures.

@Langbart

Tue, Jun 14, 1:59 AM

Mon, Jun 13

Stan added inline comments to D4699: [maps] Fix caledonia_meadow.js and wild_lake.js entities (and relics) placed outside of map.
Mon, Jun 13, 5:44 PM
Stan added inline comments to D4699: [maps] Fix caledonia_meadow.js and wild_lake.js entities (and relics) placed outside of map.
Mon, Jun 13, 1:16 PM
Stan added a comment to D4697: [Gameplay] Switch default behavior from capture to attack.

Any change needed in BuildingAI?

Mon, Jun 13, 10:43 AM
Stan added a comment to D4666: Make formations respond as one to threats..

Is it threads or threats?

Mon, Jun 13, 10:25 AM
Stan added a comment to D4696: [maps] adjustments to Fortress.js.

@lyv @marder should the wall builder code be in some kind of globalscript and shared by the sim and the random maps?

Mon, Jun 13, 10:24 AM
Stan added inline comments to D4698: Fix entvalidate.py.
Mon, Jun 13, 10:22 AM
Stan added a comment to D4695: Fix Naval Shipyard..

Curious as well what sort of tooling 0AD has for template scanning/validation? I saw the templateanalyzer under source/tools, but that appears to be about balance analysis, rather than validation.

Mon, Jun 13, 10:19 AM

Sun, Jun 12

Stan added a comment to D4682: Profiler2 lives in main().

I don't see why we would ever need two profiler instances? Running multiple matches?

Sun, Jun 12, 10:47 AM
Stan added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

Looks like a bugfix that could go in for me but your call :)

Sun, Jun 12, 10:46 AM