Page MenuHomeWildfire Games

Stan (Stanislas Daniel Claude Dolcini)
Butler

User Details

User Since
Jan 6 2017, 3:41 PM (216 w, 6 d)

Recent Activity

Today

Stan added a comment to D3632: Fix Previews in the lobby game list..

Might be a stupid question since I don't understand XMB very well, but isn't that why we usually don't specify extensions, so the game can figure out whether to load the XML or the XMB?

Thu, Mar 4, 6:35 PM
Stan added a comment to D3631: Fix compilation with --without-audio.

Fair enough, looks good to me.

Thu, Mar 4, 6:29 PM
Stan added a comment to D3631: Fix compilation with --without-audio.

One could also wrap the constants in a macro?

Thu, Mar 4, 2:02 PM
Stan added inline comments to D3632: Fix Previews in the lobby game list..
Thu, Mar 4, 2:00 PM
Stan added inline comments to D1323: Add Upkeep component..
Thu, Mar 4, 10:26 AM

Yesterday

Stan updated the diff for D2936: Allow limiting the max number of corpses simultaneously visible in the game.

fix tests.

Wed, Mar 3, 8:33 PM
Stan updated the diff for D2936: Allow limiting the max number of corpses simultaneously visible in the game.

Readd jschanges tests are still broken

Wed, Mar 3, 7:52 PM
Stan updated the diff for D2936: Allow limiting the max number of corpses simultaneously visible in the game.

Simpler and faster version

Wed, Mar 3, 7:28 PM
Stan updated the diff for D2936: Allow limiting the max number of corpses simultaneously visible in the game.

Remove the potential bottleneck, move to graphics

Wed, Mar 3, 7:01 PM
Stan retitled D3049: Make CLogger more flexible. from Allow disabling error messages to Make CLogger more flexible..
Wed, Mar 3, 4:23 PM
Stan committed rP24996: Add missing file in previous commit..
Add missing file in previous commit.
Wed, Mar 3, 4:19 PM
Stan committed rP24995: Enable support for powerpc64 systems. New problems with NVTT will be addressed….
Enable support for powerpc64 systems. New problems with NVTT will be addressed…
Wed, Mar 3, 4:14 PM
Stan closed D1619: Enable support for powerpc64 systems.
Wed, Mar 3, 4:13 PM
Stan accepted D1619: Enable support for powerpc64 systems.
Wed, Mar 3, 4:11 PM
Stan added a member for Contributors: tpearson-raptor.
Wed, Mar 3, 11:36 AM
Stan updated the diff for D1619: Enable support for powerpc64 systems.

years

Wed, Mar 3, 11:31 AM
Stan accepted D3468: Don't initialise null values in cmpGarrisonHolder..

LGTM.

Wed, Mar 3, 11:27 AM
Stan edited reviewers for D1619: Enable support for powerpc64 systems, added: Stan; removed: Itms, s0600204.
Wed, Mar 3, 11:26 AM
Stan updated the diff for D1619: Enable support for powerpc64 systems.

Rebase. @tpearson-raptor can you test again now?

Wed, Mar 3, 11:25 AM
Stan edited reviewers for D1619: Enable support for powerpc64 systems, added: Stan; removed: Itms, s0600204.
Wed, Mar 3, 11:25 AM
Stan added inline comments to D3275: Increase COMMAND_DELAY, decrease MP turn length..
Wed, Mar 3, 11:04 AM

Tue, Mar 2

Stan edited P239 Phab commit list to text scrapper.
Tue, Mar 2, 5:28 PM
Stan added a comment to D3623: Fix MSVC unknown pragma warning.

Well I'm wondering whether it's spurious because it makes no sense, or whether it's spurious because it's annoying to fix :)

Tue, Mar 2, 4:00 PM
Stan updated subscribers of D3622: Removes useless framebuffer clears.

Seems to work fine on Intel 630 and my Nvidia card I asked @OptimusShepard to test on AMD

Tue, Mar 2, 3:50 PM
Stan accepted D3620: Moves glGetError under config.

Works as expected (aka no 501 error).
I'm wondering about the gl. prefix since we do that nowhere else (e.g the novbo is not called gl.novbo)

Tue, Mar 2, 3:36 PM
Stan accepted D3623: Fix MSVC unknown pragma warning.

Seems to fix the warnings for me. I suppose that GCC7 bug is not documented?

Tue, Mar 2, 3:31 PM
Stan added a comment to D3280: Let entities garrison using cmpGarrisonable..

Weird case but what if you garrison a skirmish entity? (Those that get replaced on map load) so you have a map which has garrison points in XML

Tue, Mar 2, 1:35 PM
Stan added a comment to D2772: Prevent Upgrading units from moving.

Should I abandon this?

Tue, Mar 2, 1:07 AM
Stan added a comment to D3113: [WIP] Allow impact sounds depending on classes.

I'm not sure I follow, can you give me a pointer?

Tue, Mar 2, 1:05 AM
Stan committed rP24971: Make forge smoke only visible when the forge is researching..
Make forge smoke only visible when the forge is researching.
Tue, Mar 2, 1:01 AM
Stan added a comment to rP24969: Introduce C++ templates replacements for DEFINE_INTERFACE_X and….

Can you fix all those warnings? I fixed everything for A24 ^^"

Tue, Mar 2, 12:43 AM
Stan committed rP24970: Fix compilation of Atlas on UNICODE BUILDS.
Fix compilation of Atlas on UNICODE BUILDS
Tue, Mar 2, 12:32 AM
Stan closed D1593: Patches required to work with latest clang on FreeBSD.
Tue, Mar 2, 12:32 AM
Stan abandoned D1202: Fix Atlas compilation error in wxWidget 3.0.X.
Tue, Mar 2, 12:30 AM
Stan added a comment to D3622: Removes useless framebuffer clears.

Changes in Renderer.cpp seems unrelated and can go in separately;

Tue, Mar 2, 12:10 AM

Mon, Mar 1

Stan accepted D1593: Patches required to work with latest clang on FreeBSD.

Sweet. Will fix headers and commit now that I know its use.

Mon, Mar 1, 9:50 PM
Stan added a comment to D2818: Replace DEFINE_INTERFACE_XX and RegisterFunction macros with pure templated code.

Is there any perf hit/improvement of doing this?

Mon, Mar 1, 8:04 PM
Stan added a comment to D1202: Fix Atlas compilation error in wxWidget 3.0.X.

Can you check D1593 again?

Mon, Mar 1, 8:03 PM
Stan updated the diff for D2488: Use GL_KHR_debug.

MOAR DEFINES

Mon, Mar 1, 5:54 PM
Stan updated the diff for D2488: Use GL_KHR_debug.

And another attempt

Mon, Mar 1, 4:48 PM
Stan added a comment to D2818: Replace DEFINE_INTERFACE_XX and RegisterFunction macros with pure templated code.

Definitely test this without pch.

Mon, Mar 1, 4:47 PM
Stan updated the diff for D2488: Use GL_KHR_debug.

Try GLDEBUGPROCKHR

Mon, Mar 1, 4:13 PM
Stan updated the diff for D2488: Use GL_KHR_debug.

Fix missing param, and don't be a dummy

Mon, Mar 1, 4:06 PM
Stan updated the diff for D2488: Use GL_KHR_debug.

Fix GL_APIENTRY on Windows fix some notes and format specifier

Mon, Mar 1, 4:00 PM
Stan updated the diff for D2488: Use GL_KHR_debug.

Define GL_DEBUG_SOURCE_APPLICATION for macOS

Mon, Mar 1, 1:46 PM
Stan updated the diff for D2488: Use GL_KHR_debug.

Rebase, need the CI for macOS errors

Mon, Mar 1, 1:29 PM

Sun, Feb 28

Stan added a comment to D3614: Check for missing auras in GUI Interface.

Should be in checkrefs too.

Sun, Feb 28, 11:15 PM
Stan added a comment to D1751: [WIP] Map flares.

I will try to provide something yeah but maybe I'll do it after this patch is committed :) I'm supposed to get some rest. Failing completely for now :/

Sun, Feb 28, 11:14 PM
Stan added a comment to D1751: [WIP] Map flares.

Oh right you should definitely hear them. One question about abuse. Is there a way we can limit spam!

Sun, Feb 28, 11:01 PM
Stan added a comment to D3613: Improve handling of filenames containing UTF-8 encoded characters.

If it's not too much trouble can you provide a little mods with the steps? so it's easy to test? E.g with broken templates maps and whatnot

Sun, Feb 28, 5:43 PM
Stan added a comment to D1751: [WIP] Map flares.
Sun, Feb 28, 3:22 PM
Stan added inline comments to D3609: Guarantees no memset for allocation of DynamicArena::Block.
Sun, Feb 28, 3:19 PM
Stan added inline comments to D3280: Let entities garrison using cmpGarrisonable..
Sun, Feb 28, 10:40 AM

Sat, Feb 27

Stan added a comment to D1593: Patches required to work with latest clang on FreeBSD.

@nwtour can you confirm it works for you?

Sat, Feb 27, 5:11 PM
Stan added a comment to D3608: Remove unneeded check in JSInterface_GameView.cpp.

I'm fine with either, just thought it was worth mentioning :)

Sat, Feb 27, 4:51 PM
Stan added inline comments to D3608: Remove unneeded check in JSInterface_GameView.cpp.
Sat, Feb 27, 4:39 PM
Stan added a comment to D3608: Remove unneeded check in JSInterface_GameView.cpp.

Why is it unneeded ?

Sat, Feb 27, 1:03 PM
Stan added a comment to D1611: Use pkg-config instead of hard-coding or library-specific programs.

We have a user with both libpng12 and libpng16 installed and I wonder why it doesn't use pkgconfig?

Sat, Feb 27, 12:21 PM
Stan committed rP24939: Bump version to alpha 25..
Bump version to alpha 25.
Sat, Feb 27, 10:13 AM
Stan closed D3571: Bump version to A25.
Sat, Feb 27, 10:13 AM

Fri, Feb 26

Stan updated the diff for D2936: Allow limiting the max number of corpses simultaneously visible in the game.

Restore to the previous version + rebase

Fri, Feb 26, 7:08 PM
Stan added a comment to D1202: Fix Atlas compilation error in wxWidget 3.0.X.

I didn't commit it cause I could not reproduce the bug D1593 looks simple enough for me to commit it. One thing you can do is close this one (abandon) and commandeer the other one so we can finish it.

Fri, Feb 26, 3:37 PM
Stan added a comment to D3303: Split treasures from ResourceSupply..

I really wish we would have gone for alphabetical schema ordering, it's soooo easy to autofix. I did it for hyrule and it's pretty cool.

Fri, Feb 26, 10:24 AM
Stan added inline comments to D1718: Decay/regenerate option for resources..
Fri, Feb 26, 8:29 AM
Stan added a comment to D1202: Fix Atlas compilation error in wxWidget 3.0.X.

Did you see D1593? It has a different approach not sure which is better

Fri, Feb 26, 7:36 AM

Wed, Feb 24

Stan updated subscribers of D3592: Do not allow to start pyrogenesis with incompatible mods.

Also won't this break @nani's autociv workaround for undetectable mods?

Wed, Feb 24, 5:00 PM
Stan updated subscribers of D3592: Do not allow to start pyrogenesis with incompatible mods.
Wed, Feb 24, 12:25 PM

Mon, Feb 22

Stan updated subscribers of rP22905: standardized hero aura descriptions.
Mon, Feb 22, 11:23 AM
Stan added a comment to D3585: Fix *nix tarballs to extract in a subfolder..

Looks alright, shouldn't you ignore the test.cpp files too? I remember someone mentioning it.

Mon, Feb 22, 10:30 AM

Sun, Feb 21

Stan edited P241 Stan's build script on linux.
Sun, Feb 21, 11:48 PM
Stan added inline comments to D3592: Do not allow to start pyrogenesis with incompatible mods.
Sun, Feb 21, 7:22 PM
Stan accepted D3591: Add Bellaz89 to the programming credits.
Sun, Feb 21, 4:07 PM

Sat, Feb 20

Stan added a comment to D3582: Garbage in menu Language.

Those languages are not present in the release. Check A23b :)

Sat, Feb 20, 3:01 AM
Stan added a comment to D3582: Garbage in menu Language.

The reason we do not add those characters is that it makes the fonts too big. Instead CJK are provided as mods of around 100MB each.

Sat, Feb 20, 2:01 AM

Fri, Feb 19

Stan updated the diff for D3571: Bump version to A25.

Copy paste FTL

Fri, Feb 19, 11:41 AM
Stan added inline comments to D3571: Bump version to A25.
Fri, Feb 19, 11:40 AM
Stan updated the diff for D3571: Bump version to A25.

Use em dash instead. In case I'm not here, and someone can't wait, they have the permission to commit this.

Fri, Feb 19, 11:39 AM
Stan removed 1 auditor(s) for rP24286: Drop support for compiling with Visual Studio 2015: Itms.
Fri, Feb 19, 10:43 AM
Stan resigned from rP22037: Add an error message for crashes without required UV sets..
Fri, Feb 19, 10:40 AM
Stan added inline comments to D3303: Split treasures from ResourceSupply..
Fri, Feb 19, 10:00 AM

Thu, Feb 18

Stan added inline comments to D3575: Fix assert in topology.cpp.
Thu, Feb 18, 2:40 AM
Stan added a reviewer for D3579: Fix hotkey cannot be unset: wraitii.

Looks like I made a mistake in my hotfix in rP24856

Thu, Feb 18, 2:38 AM
Stan accepted D3578: Do not generate render data in case Decal calculated wrong coordinates.

I tested this patch and it seems to fix the issue. I found another way to reproduce. (It works both in packaged an non packaged and triggers a stack overflow)

Thu, Feb 18, 2:34 AM

Wed, Feb 17

Stan added a comment to D3555: (1) AO factors = 1.0 for all materials, (2) skyward bias for ambient light in shaders; (3) temporary fix for excessively bright colors in terrain textures..

Okay so here comes the frustrating and tough part :/ So bear with me cause we're in for a ride. Just know that it's not against you :)

Wed, Feb 17, 11:44 PM · Contributors
Stan updated the Trac tickets for D3578: Do not generate render data in case Decal calculated wrong coordinates.
Wed, Feb 17, 11:34 PM
Stan added a reviewer for D3578: Do not generate render data in case Decal calculated wrong coordinates: wraitii.
Wed, Feb 17, 11:34 PM
Stan added a comment to D3575: Fix assert in topology.cpp.

I see now still you could use our define cause it has more things

Wed, Feb 17, 6:59 PM
Stan edited P209 Stan's clang build script on linux.
Wed, Feb 17, 6:56 PM
Stan added a comment to D3575: Fix assert in topology.cpp.

Well your patch does it anyway :)
And not for all only for x86_x64::Family() == 6 if IA32 is detected

Wed, Feb 17, 6:15 PM
Stan added inline comments to D3575: Fix assert in topology.cpp.
Wed, Feb 17, 1:30 PM
Stan added inline comments to D3551: Fix water wind speed computation.
Wed, Feb 17, 10:09 AM

Tue, Feb 16

Stan added a comment to D3575: Fix assert in topology.cpp.

Hey thanks for the patch ! You might want to move that into the check for IsHyperThreading capable.

Tue, Feb 16, 9:49 PM
Stan added a comment to D3574: Prevent using privileged ports on *nix from the GUI.

Can you add yourself to the credits? :)

Tue, Feb 16, 5:02 PM
Stan added a comment to D3475: General improvements to 0ad.desktop.

For me it's A25 material. I will ask maintainers about it but so far the people I asked were really mitigated about it.

Tue, Feb 16, 1:11 PM
Stan added a comment to D3572: Fix variant loading order.

Sure. :)

Tue, Feb 16, 12:56 PM
Stan committed rP24929: Fix variant loading order.
Fix variant loading order
Tue, Feb 16, 11:52 AM
Stan closed D3572: Fix variant loading order.
Tue, Feb 16, 11:51 AM
Stan added a comment to D3573: [A24] i18n issues: Spanish manual & gamesetup tips text..

D3520 says it's complete

Tue, Feb 16, 11:27 AM
Stan requested review of D3572: Fix variant loading order.
Tue, Feb 16, 9:57 AM
Stan added a comment to D1338: Add a RC file for pyrogenesis.

Sorry, what do you call the manifest file?
Defining it in premake might be a good idea. I could set those define there yes I suppose.

Tue, Feb 16, 8:42 AM