First attempt at using arc

Try with ps/trunk/ prefix

Add missing file.

Switch includes, fix premake.

thread

thread

Sounds like something @Gallaecio could review.

Yeah which is why it should be committed if that's the right fix ;)

@Angen thoughts on this patch? All it does is move code to third party.
@linkmauve in case you want to look at the GLSL preprocessor code
For the record I chatted on the Ogre Gitter, and they are still making some fixes to it + the ones we currently have because we are a lot versions behind...

@StanleySweet then you might be interested in this: https://github.com/OGRECave/ogre/issues/614

Fix styling issues, and read the data in the json file to know what to disable enable depending on what's on.

Just for the record, only debian seems to provide a man command.

This person also runs out of memory #5645 without the fix, maybe it's the same reason.

Thanks for the fix. Note that it doesn't following the naming conventions though. As horse shouldn't be in the name if it's in a folder called "horse". That should be fixed sometime.

In rP23195#39836, @Alexandermb wrote:

In rP23195#39832, @minohaka wrote:

Was playing and got these errors:
ERROR: Mismatch between model's skeleton and animation's skeleton (46 model bones != 49 animation keys)
ERROR: CCacheLoader failed to find archived or source file for: "art/variants/quadraped/base_horse_trader.xml"
ERROR: Could not open path quadraped/base_horse_trader.xml
ERROR: CCacheLoader failed to find archived or source file for: "art/actors/props/units/helmets/hele_thracian_cart_hero_01.xml"
ERROR: CObjectManager::FindObjectBase(): Cannot find object 'props/units/helmets/hele_thracian_cart_hero_01.xml'
ERROR: Failed to build prop model "props/units/helmets/hele_thracian_cart_hero_01.xml" on actor "hero_elephantry_hannibal_d"

Fixed most of them but i can't recognize the mismatch model. Do you know where the model mismatch happens?

In D2353#102192, @OptimusShepard wrote:

I currently have no time to write the patch, sorry. If someone else writes this patch I would test it.
Here are the required information which Imarok got from the AMD forum.
https://community.amd.com/thread/244207

Some coding convention notes to keep you wair

Fix verb

static_cast

Use ints remove the changes.

@nani maybe a good occasion to use the new class syntax? VSCode can auto convert it.
Also missing newline at end of file and semicolons :)

Still broken @Angen?

This patch also fixes a Profiler2 crash when the userreporter is enabled.

Was missing Profiler2::SaveToFile() that's writing a file as well.

Okay so I tried the script in the WSL (Windows Subsystem for Linux) As I expected it totally failed because Windows disks are not case sensitive.

Yeah binary files and moving never works.

I tested on my raspberry pi, and it fixes a segfault for me too.

Thanks for the patch and the detailed answer. I just wanted to make sure we were not doing something wrong by replacing those.

Lods should be in the template visual actor. Else actors will become a great mess. Also there will be warnings everywhere or missing props.

I guess pack could have a visual animation at some point too.

Any performance difference in using one of the other? I'm all for removing dependencies though.

Thanks for the patch.

In rP23179#39753, @elexis wrote:

The tower seems very overpowered?
It's has the same firepower as a civic center or fortress, while the minimum distance is shorter (60m vs 80m).
The iberian tower once shot 10 and was nerfed to 8 arrows because it was too strong.
That was a nerf by 20%, this is 250% the firepower the iberian tower currently has.
It's unique that only archers can garrison here when everywhere else all infantry can garrison. But I guess it makes sense as there are visible garrison spots.
On the other hand perhaps the tower is not so devastating at all, since the archers can easily be killed by other archers, contrary to the other towers where the archers are hidden?
Though the archers have the elevation advantage, 72 meter + 16 meters vs other archers having 72 meters, so opponent archers can't get in range to attack those visibly garrisoned archers.
Why are there 20 garrison slots and 16 visible garrison slots?
It also means that the player cannot chose which units are visibly garrisoned, which units are hidden garrisoned, which of the unit types will be ungarrisoned when performing the ungarrison action, which was considered a defect when the visible garrison code was proposed.

Fix the rome_tower and use the default scaf for the carth tower.

Fix ptol and rome towers. Remove scaffolds from rome siege wall. Fix missing props when upgrading. Upgrading → upgrading.

In D2371#101720, @Angen wrote:

Notes:
ptolemies/defense_tower: pls add <prop actor="props/structures/decals/spart_1x1.xml" attachpoint="root"/>
romans/scout_tower pls add <prop actor="props/structures/romans/rome_tower_wood.xml" attachpoint="root"/>
actually roman siege wall is about the size of palisade in height, maybe scaf should go off there too, I think it is a bit off by height and width

Spoiler alert it didn't, I forgot to change the capitalization.

In D2436#101642, @elexis wrote:

Thanks.

This should fix the remaining issues. let me know if it doesn't.

Add scaffolds for the two missing towers, fix wall. tweak the tower so roof doesn't get overriden.

https://wildfiregames.com/forum/index.php?/topic/13602-please-welcome-our-new-open-source-development-manager/&tab=comments#comment-211618

Any reason why you didn't create a separate file ?

Remove jsdoc.

Fix tests. Apply @Polakrity's suggestion.

Fix check. Add variants and template changes.

Optimize stuff a bit.

Remove useless parameter.

Reset the upgrade animation when the upgrade is cancelled.

Fixed in rP23172 If someone is on windows or a non case sensitive OS, he needs to be wary that this commit should never be checked out.

This commit introduces two files with different cases which is only supported on case sensitive filesystems. ie not windows.

I get this after rebuild

Open questions:

I guess we should use cape variants everywhere. So that if capes are changed in the future from this armature to the next we only have a handful of stuff. Sorry if that's what you meant earlier...