Already the case. Those were approved...

Can't turret use this? Or do they have another special property?

No difference whatsoever for me on a very large deep forest map.

I assume you can't use a fixed?

Just confirmed that the crash in debug mode of apitrace is not linked to this patch. So only thing to fix is Mac Os.

Fair enough :)

I assume there is no class for special buildings? (SB1 & SB2)

Unstretched look indeed better. One can also notice that we used two different sprites for the same thing 0ad_logo and watermarkCompany

Fix windows build. Apitrace doesn't work for me though, it segfaults directly

I like the example in the description though I think it could a bigger top padding.

Some notes. Can you add yourself to the credits? Keep up the great work!

That sounds nice.

I guess committing this means adding a PR to delenda est :D

In D2584#108479, @elexis wrote:

I don't know what you refer to when you speak about MP savegame features, because so far there is only one MP savegame feature on the table, which is picking a savegame, starting a host, and then running that match.

Maybe those textures should be moved to the old public folder in https://trac.wildfiregames.com/browser/art_source/trunk/old_public

In D2531#108428, @vladislavbelov wrote:

I've reproduced that assertion locally on macOS 10.14.6 in debug-mode. I've figured out the reason: it seems that OSAtomicAdd64 doesn't work as expected in debug mode, maybe address was misaligned.

Given it was committed in rP6904 I assume checkrefs.pl --check-unused reports it?

If changing ao files, strip the _AO suffix, as they already are in an ao folder (I only do it on a case to case basis)
Any reason for those collada edits? I know Linux needs EOF to be on a newline, but stuff handling DAE seems not to care at all...

Looks good to me :) Thanks for the patch.

In D2586#108360, @Nescio wrote:

Keep in mind many ship, siege, and support units currently share a single icon for templates of different civs.

In D2586#108352, @Nescio wrote:

For the ones using an incorrect civ, wouldn't it make more sense to duplicate the icon to have both brit and celt, mace and athen etc?

Maybe, though that would mean having two exactly identical images. Wasn't it your intention to try reducing the download size?

For the ones using an incorrect civ, wouldn't it make more sense to duplicate the icon to have both brit and celt, mace and athen etc?

Patch works as expected, though it triggers a compilation warning see inline. (Missing WxUnused)

I think it would be nicer to have the MP savegame features, but if it isn't gonna happen soon, I believe this is the next best thing.

Feature is good, code looks good to me, and it works as expected.

Accepting so you can close.

Works for me on RPI4 with the mesa lib.

In MP though I believe it's one of the most OP civs.

I think the idea was more to add a cost for those ptol houses.

int → ssize_t

Try to fix build

Fix notes

After giving it some thought I guess you can keep the changes in mongoose.

In D1997#107781, @Angen wrote:

Personally I think fauna shouldn't be visible in fog-of-war

agree

Needs to be rebased.

I'm not sure about the change in Mongoose, there are quite a few warnings in that file. I think it will be better to update it.

Just for the record

You could also assert there is no logger output?

Patch looks good test are sane and a nice addition and autobuild doesn't complain.

Oh yes, my bad.

Maybe add a test for division by 0 and #elif?

The other looked nice, so I wanted to make sure we could not use them instead of deleting them.

Order includes, remove todo, put { on the line

assert → ensure

2019 → 2020

Should I replace assert ( by ENSURE?

Fix notes.

In D2551#107655, @Nescio wrote:

Don't ask me why, but somehow dnf remove perl (and not re-installing it) solved the errors, so now the script works for me.

IIRC for perl you can also install something called CPAN

apt-get install libjson-perl ? :) At least it's not the same error. Attached at P194 is a list of the current unused file. Ideally there would be close to none.

In D2551#107626, @Nescio wrote:

For your information, these six structure icons appear to be unused, at least in the public simulation folder:

colony.png
gardens.png
ishtar_gate.png
lamassu.png
monument.png
shipyard.png

In D2551#107601, @Nescio wrote:

Except that they actually belong to the cart civ.

wooden tower were originally wooden before @LordGood made them pretty. I assume they should have been renamed then. You can still find the original wooden actor.
embassy_italic like strings are always a bit problematic because technically it could be rome_embassy, iber_embassy, gaul/brit_embassy
I think hanging_gardens should be deleted if it is unused. The icon looks ugly.

The rest look fine, but I'm not sure about the tower changes. They are indeed small medium big wall artillery. Is there something wrong with wood scout sentry defense wall?

V is a git concept. Move in SVN is A & D (Add and delete)

Strange it doesn't show property as modified. See for example D2553 where it says MM. I assume it's a Phabricator bug.

You didn't set EOL to native?

See the macos warnings https://jenkins.wildfiregames.com/blue/organizations/jenkins/macos-differential/detail/macos-differential/117/pipeline

Update for luck.

On a side note 720 < 768 minimum resolution.

False alert. after running make clean clean workspaces, and rebuilding everything overnight, then cleaning the cache, it works now. There are only the compilation warning but I can live with those.

@vladislavbelov might be of interest to you