User Details
- User Since
- Jan 6 2017, 3:41 PM (375 w, 3 d)
- Roles
- Administrator
Yesterday
Thu, Mar 7
Did the API break?
Wed, Mar 6
@phosit is there a convention for floats : 1.0f, 1.f, 1f ?
Fri, Feb 23
Wed, Feb 21
Tue, Feb 20
So what happens here exactly when it cannot find the shader file?
Mon, Feb 19
A better solution indeed would be to profile :)
Feb 17 2024
The issue is that so far we don't have a reliable way to detect Vulkan support, as the detection itself can crash the game on some AMD GPUs. :)
That's my point. We don't have graceful stuff here and as long as it's not 60% stable we can't force users to use it :)
Maybe. Although errors do that, CTDs not really. The last five times I ran SVN it crashed because of Vulkan + Mod combo so I eventually gave up and went back to GL. Also worth noting Atlas doesn't support Vulkan and I guess @trompetin17 will not finish his patch to get rid of Atlas any time soon.
@sera if you do that you can't run the dev build without building shaders first... Which is really a pain
Feb 15 2024
If you haven't already, I would read this wiki page https://trac.wildfiregames.com/wiki/Coding_Conventions This will save some time for the review by @vladislavbelov Unfortunately we don't have Clang format or an equivalent, so we have to enforce the coding style manually. Obvious things I see from a quick glance are braces that aren't on new lines, nested ifs instead of early returns etc.
Kib probably needs an include.
Feb 13 2024
Feb 12 2024
Feb 11 2024
Feb 10 2024
How about using ProjectionType from source/graphics
/Camera.h ?
Feb 9 2024
Feb 8 2024
Jan 21 2024
Other than having proper tests for it and the notes don't think so.
Jan 19 2024
That's fair. :)
Jan 18 2024
Do you need it to be rectangular ?
Jan 17 2024
Would be funny to shoot all targets, but with a ratio of arrows depending on preference. Probably needs some good UI.
Jan 16 2024
Oh right my bad. So it's picking a list of like 20 targets, shoots as many arrows as possible on the favourite one until it goes missing (could be dead or out of range) then moves on to the next one.
Jan 13 2024
I suppose the left part could go away, and the right be used since it's the same flipped and longer. Maybe we can cram other things in that texture?
Jan 12 2024
If this is accepted, don't forget to delete the other files on the way out :)
Jan 11 2024
Also I don't like pushing elements in a loop. In your case i'd do something like this:
Jan 9 2024
Jan 8 2024
Cleaned workspaces so macos build can run. It was broken after spidermonkey patch.
They are not matching naming conventions though should be _0X
Jan 7 2024
Just to clarify @Lopess made the statue :) If it needs to be optimized that's another issue. I just made the pedestals for the CC and added the prop points.
Jan 6 2024
Jan 5 2024
Dec 31 2023
Concerns there are fixed, new concerns are on the fix ^^
Concern fixed by reverting the commit.
Fixed as well.
Should be fixed now :)
You forgot to change https://trac.wildfiregames.com/browser/ps/trunk/libraries/source/fcollada/build.sh
Dec 26 2023
Dec 18 2023
Dec 17 2023
Dec 8 2023
Dec 7 2023
The problem is that buildings don't have animations.
Dec 6 2023
Hey, don't forget to upload patches with context and to set the repository, else the autobuild will never be triggered.
Nov 28 2023
In case that helps recipient is also a word you can use.
Nov 26 2023
In C# those would be 'sinks' there would be two file logger sinks with different levels of filter TRACE DEBUG INFO WARN ERROR FATAL and each sink would be responsible for how and what they should print.
Nov 22 2023
Related D4979
Nov 12 2023
Should test exceptions in Atlas (which are already buggy) possibly some flags like -dumpSchema and archiveBuilder to make sure everything is still logged.
Oct 30 2023
I just created an account for them. For most pipelines, clicking the jenkins link that appears when the build fails or succeeds gives you access the pipeline.
Oct 13 2023
There are some options https://milkv.io/ but I don't know which one was used.
Oct 12 2023
From the ticket on Twitter, I'm not sure but I think the hangs are caused by the GC (Similar issue on RPI4):
Oct 4 2023
Maybe that's a C# thing to have an enum like so:
How about using an enum class ?
Sep 24 2023
Aug 28 2023
The onager (British /ˈɒnədʒə/, /ˈɒnəɡə/, U.S. /ˈɑnədʒər/)[1] was a Roman torsion powered siege engine. It is commonly depicted as a catapult with a bowl, bucket, or sling at the end of its throwing arm. The onager was first mentioned in 353 AD by Ammianus Marcellinus, who described onagers as the same as a scorpion.
Aug 18 2023
You can now close this revision, which was committed in rP27806 partially.
Aug 17 2023
Aug 11 2023
I think the Fcollada fix is okay, we could ask the guy maintaining the rdb fork what he thinks about it.
If @vladislavbelov thinks it's okay too I have no objections.
Aug 7 2023
Jul 31 2023
Jul 17 2023
Jul 3 2023
This seems to have broken the Windows CI.
Jun 29 2023
Jun 28 2023
Jun 23 2023
Jun 21 2023
Would it make sense to use the Status enum ? e.g INFO::OK, INFO:SKIPPED ERR:* ?
Jun 17 2023
<insert the macro for x86 detection> that would be incorrect. Some other arches support it. I don't remember but I think one of power pc xx or elbrus e2k support it.
Jun 16 2023
It feels weird for it to be an option as it makes no sense to even be able to enable it on aarch64, arm64 or arm.
ma
https://github.com/0ad/0ad/blob/master/source/lib/sysdep/compiler.h#L106 makes me wonder what happens when building with clang. The CI doesn't print warnings about using the slow codepath (unlike arm)