Let's do it in one go, move + rename.

All good now.

Ah my bad it's referenced in Egypt (3V3)

Changes make sense, no mods seems to be using it. Naming conventions are respected.

Feel free to commandeer @Angen

Fix some inlines

fix inlines

Fix inlines.

I believe I can fix the donkey trader offset, if it is worth it as apparently it is technically incorrect for Celt civs to rely on those. One has to be careful when changing the position dae, as a lot of models currently use the merchant's object.

Add early return

I guess you can also update _default.xml map to use 9 players.

Might be worth checking if there are any tips referencing that as well.

Itms said this was not the correct way to do, it I'll let him explain why.

I'll fix the S when committing, thanks for the patch.

In rP23484#41600, @OptimusShepard wrote:

FXAA doesn't work on my linux system. On dual boot Windows it's working.
Manjaro 64Bit, Radeon RX 570

interestinglog.html6 KBDownload

Thanks for coming to the party, it is very much appreciated :)

I agree with moving persians to the persian folders, I guess if they were indeed using more horse archers than chariots then they should use that, I agree about the icon change, the specific name change, and the chariot currently cannot be trained, and will be up to the balancers to include or not.

Strings in tests?

Technically isn't a siege tower a "structure"?

In D2530#112328, @Nescio wrote:

@Stan?
(pers_chariot.xml is untrainable, hence this patch does not affect gameplay balance. Horse archer actors are moved to the persians folder, similar to D2636.)

Forgot accept message again (wink @Freagarach) Patch is good, and I agree that iberian units belong to the iberian folder. There is no gameplay change, rather it's an organisational one, therefore it has little impact. Might ping @wowgetoffyourcellphone so he can update his mod accordingly.

Nice! Might be good to check one can also promote a unit using that. Mayb unify the test dunno.
Maybe TestExperienceTrickle?

In D2669#112281, @ValihrAnt wrote:

Looking at it from a balancing POV the value of 20% seems to be pretty good. The average blacksmith researches include infantry armor and ranged infantry attack and this teambonus would save 600W, 200F, 100S, 210M and 24 seconds. So overall I think it would be a very useful teambonus, but also not overwhelming.

Change name from waypoint_flag_{civ} to {civ}_waypoint_flag

Fix comments

Fix last ©

Fix copyright © year. Remove empty newline, add dots and caps to comments I added

Fix tests, thanks to @Freagarach. Correct some little mistakes

D1400 ?

Requesting changes for palisades so it's not forgotten.

You can also request changes :D

I agree with the change as well, and I think this will be an improvement.

@Stockfish0ad can you elaborate on which one you'd like to change?

I can probably center on the compound.

See #5695

Might be line endings. Depending on your OS, it might or might not strip the special chars

In D2630#111755, @user1 wrote:

Per elexis' suggestion, this patch doesn't rename or move things anymore.
It should happen that a follow-up revision to this will restructure the directory tree and rename everything as they need to be.
Tests still pass.

@Nescio is it still something we might want? If so can you commandeer and add it to the list of your patches?

In D2640#110676, @Nescio wrote:

Notice that donkey traders are centred on the human, not the donkey (@Stan).

I guess you can abandon this. We generally avoid this kind of patches as it makes SVN blame harder.

History checks out, so removing the obelisk makes sense. Thanks for the patch.