Upload the correct patch.

For the textures.xml i'm not sure whether it's not better to have it in the public mod and not in the mod mod. Sounds sane that xml validation be part of the engine, but textures.xml are directly relevant to the textures files one put in his mod. So I don't think it should be part of the engine.

I package without it all the time :)

One has to be careful to add a dependency to modmod when packaging the mods. Otherwise you will get bad textures if you remove textures.xml. Those files decide what compression will be used on a png file.

Disable all TLS stuff.

Ah autocorrect try Itms fix ;) I meant to write--without-brotli.
It would be nice to disable all other librairies if possible.

Can you pass --without-ssl ?

It doesn't crash on any of those platforms if I build the game.

Ah right.

If I compile on 10.9.5 I can access the lobby with tls without issues.

Macos 10.8 was released in 2012. Considering how aggressive Mac is when it comes to upgrade and the fact people don't really know our game works on Mac I do not find it so hard to believe.

In rP21943#31678, @smiley wrote:

Not to mention ~1GB for an upgrade which literally added nothing visible. Not really an issue for most though.

To me people should upgrade. If we were commercial software, it would be different. But here you literally have no reason not to upgrade.

Fix path

Use the correct option, check if it is set before using it.

I assumed we should use premake variable because options might be undefined.

Sounds fair then. Thanks for taking time to elaborate :)

Getting this right doesn't seem like it would hurt the A23 re release was it to be included, right @Itms ?

I see. Won't be hard to keep track of all the patches we apply ? For now we only have one but we might have more in the future, no ?

Might I suggest to save this as a patch and apply it on premake when updating update workspaces on OsX ?

I understand your point. My concern was mainly about people who don't report bugs because it's not a common thing to do :)

A better idea.

We could add some text under the TLS encryption saying its broken, on WinXP + OsX < 10.12 + Fedora ?

I tried it by stretching the window to give it an 21/9 ratio.

The screen height is dependent on the window size.

It's only used to compute the offset of the background. it's passed as an argument to the background to offset it.

Basically this number is multiplied to whatever the height is. So in case it's 1080 you get 1920 if it's 1050 you get 1866 instead of 1680 (Because it's supposed to be a 16:10 ratio) if you give it 768 (for 1024x768 which is the minimun resolution we support) you get 1366. That is not a 4:3 ratio.

Try to fix the build. Fix warnings.

Cause that file is huge. Also I think it's good practise to do so.

@bb Got a stacktrace for the lobby crash ? To see if it has anything in common with Mac ?

Can't fix those warnings, because they have no reasons to be.

You can't remove braces see the comment I added : "scoping braces are important to indicate where an element ends. If you don't put them the tag won't be closed until the object's destructor is called, usually when it goes out of scope."

I will see if I can fix those warnings in terrain.h

We really need this feature for the GUI.Scale options. I think there is already a differential but if Not I can submit a patch

Nice work !

I guess you forgot to package the public mod.

Metal was introduced in El Capitan (OSX 10.11)
https://en.m.wikipedia.org/wiki/Metal_(API)
I'd like trompetin17 to try to play with us and Vladislav to make sure everything is fine.

Thanks for commandeering

Would be nice to use cacheloader to load PNG as well

Looks good. I was wondering about those Eval as well when I was doing the line color patch.

@wraitii @vladislavbelov any review on this ?

Sure I'm not saying this is is useless :)
You could cache the results of the bitwise operator in an array maybe. Array access will be faster than any computation.

Your bitwise operations might be more costly than the potential gain.

This patch would be fun with a Max pop of like 25 XD

Maybe it would be nice to have a separate repository ? So you can pull to keep it in sync automatically.

@Itms any update on this ?
Do you need someone to test ?

My stomach feeling and the ability to look further into the past.

Three years sound reasonable. What if the user ask us to delete the account do we keep it still for three years ?

What changes between two or three years ?

Wrong place? 😛 This is unrelated to mods, but if the bundle version cannot have letters, it should still be 23, not 24.

I'm pretty sure we can't have letters in mod versions.

For the record. D1617 does this :)

Thanks for the extensive research.

I can ask him again but it's unlikely he remembers more than this.

Michael says this comes from the NASA. Don't have a link but I don't think their license is compatible.

If you feel like redoing the map that's great but maybe it's a bit Overkill ? :)

@wowgetoffyourcellphone Do you remember where it came from ?

I'll move it to the art repository for A24

Did you try to grep for references to these files ?
Could also run checkref.pl :)

If the log is too spammy in the game remember you can still see the whole output in interestinglog.html. see wiki:GameDataPaths

Well you shouldn't be able

Thanks, just making sure, so we don't get into trouble later.

What about that code's license ?

Well you can't build storehouses along shores... And you could disable it for docks but... Yeah