Reuse class syntax as it works now, not sure what happened.

Fix OnValueModification event.
Reset back to non class syntax as events do not work.

Usually it's <variant>variantname</variant>

Thanks for keeping up with it. Don't forget to update the copyrights. Pinging @linkmauve in casee he wants to help with XMPP stuff
I'm not sure where it is currently versioned but the path look wrong

Also shouldn't this patch delete other textures?

I just tried. I think there is something wrong with the scorpio, maybe it needs a specific size. I used the unit_demo maps I haven't checked all the footprints yet.

Add files.

I looked into moving StartTimer() CancelTimer() and Autobuild() to the Autobuildcomponent but it can't work, because the builder needs to be added to the preview Entity

Subscribe to OnValueModification messages.

Fair enough.

Walls, towers, while not completely historically accurate, the models aren't bad per se.

We have the problem with a lot of decals, don't we?

They reference dae files, those files will start to show up in checkrefs.pl.

Do you have an example where it looks bad?

I don't know if this is a good idea. Some of the removed models in this patch are good. Maybe they even deserve to get their own actors. Applying this patch will result in a lot more of unused art.

Why not add them to the others instead?

Fix typo reported by @Nescio.

Remove template changes.

var → let

Shouldn't it be done in UnitMotionFlying as well?

Fix typo.

Can't we have an explicit message about message being too big?

Use square distance instead.

That's sad the correct symbol does not exist in the game's font though... I assume there isn't much we can do about that...

I don't know, do you think it makes more sense? That means having to check for cmpFoundation and reversing the whole patch...

Remove useless template change.

Fix !!check

Adapt test.

Rebase, move buildable to autobuildable.

I'm open to suggestions on how to make it work with foundations.

In D2492#109957, @Angen wrote:

If Defines whether the entity can be built is true, that needs to be in code, if it is not in the code, that description is false so needs to be removed.

Just noticed a great use for this with sockets. One could allow buildings to place autobuilsing foundations on their sockets to create extensions.

Nice then. Have you checked for completeness?

Have the checks always been missing and executing deadcode?

I assume one has to play in FFP to test?

Ignore the failed build it randomly segfaults for some reason...

Can you reupload the patch so it can go through CI? It didn't go because you weren't added to the Contributors group.

"Available starting with Windows 2000." Or am I misunderstanding something?

Also the random in identity only changes the visual actor and or the sounds which is not serialized :)

Patch looks good adding tests is good it compiles and works on all three platforms.

Already the case. Those were approved...

Can't turret use this? Or do they have another special property?

No difference whatsoever for me on a very large deep forest map.

I assume you can't use a fixed?

Just confirmed that the crash in debug mode of apitrace is not linked to this patch. So only thing to fix is Mac Os.

Fair enough :)

I assume there is no class for special buildings? (SB1 & SB2)

Unstretched look indeed better. One can also notice that we used two different sprites for the same thing 0ad_logo and watermarkCompany

Fix windows build. Apitrace doesn't work for me though, it segfaults directly

I like the example in the description though I think it could a bigger top padding.

Some notes. Can you add yourself to the credits? Keep up the great work!

That sounds nice.

I guess committing this means adding a PR to delenda est :D

In D2584#108479, @elexis wrote:

I don't know what you refer to when you speak about MP savegame features, because so far there is only one MP savegame feature on the table, which is picking a savegame, starting a host, and then running that match.

Maybe those textures should be moved to the old public folder in https://trac.wildfiregames.com/browser/art_source/trunk/old_public

In D2531#108428, @vladislavbelov wrote:

I've reproduced that assertion locally on macOS 10.14.6 in debug-mode. I've figured out the reason: it seems that OSAtomicAdd64 doesn't work as expected in debug mode, maybe address was misaligned.

Given it was committed in rP6904 I assume checkrefs.pl --check-unused reports it?

If changing ao files, strip the _AO suffix, as they already are in an ao folder (I only do it on a case to case basis)
Any reason for those collada edits? I know Linux needs EOF to be on a newline, but stuff handling DAE seems not to care at all...

Looks good to me :) Thanks for the patch.

In D2586#108360, @Nescio wrote:

Keep in mind many ship, siege, and support units currently share a single icon for templates of different civs.

In D2586#108352, @Nescio wrote:

For the ones using an incorrect civ, wouldn't it make more sense to duplicate the icon to have both brit and celt, mace and athen etc?

Maybe, though that would mean having two exactly identical images. Wasn't it your intention to try reducing the download size?