Page MenuHomeWildfire Games

Stan (Stanislas Daniel Claude Dolcini)
ButlerAdministrator

User Details

User Since
Jan 6 2017, 3:41 PM (349 w, 5 d)
Roles
Administrator

Recent Activity

Mon, Aug 28

Stan added a comment to D5114: [Gameplay] Add Onager for romans.
The onager (British /ˈɒnədʒə/, /ˈɒnəɡə/, U.S. /ˈɑnədʒər/)[1] was a Roman torsion powered siege engine. It is commonly depicted as a catapult with a bowl, bucket, or sling at the end of its throwing arm. The onager was first mentioned in 353 AD by Ammianus Marcellinus, who described onagers as the same as a scorpion.
Mon, Aug 28, 5:49 PM

Aug 18 2023

Stan added a comment to D5102: improve color of repair icon.

You can now close this revision, which was committed in rP27806 partially.

Aug 18 2023, 10:03 AM
Stan accepted D5102: improve color of repair icon.
Aug 18 2023, 10:02 AM

Aug 17 2023

Stan awarded rP27805: Fix missing space in TaC of the userreporter. a Love token.
Aug 17 2023, 6:11 PM

Aug 11 2023

Stan added a comment to D5092: Fix for Trac #6797 - OSX Build Errors w/ SDL and FCollada.

I think the Fcollada fix is okay, we could ask the guy maintaining the rdb fork what he thinks about it.
If @vladislavbelov thinks it's okay too I have no objections.

Aug 11 2023, 11:41 AM

Aug 7 2023

Stan added reviewers for D5093: Suppress implicit function declaration error in zip-lib for MacOS: Itms, s0600204, wraitii.
Aug 7 2023, 9:48 AM

Jul 31 2023

Stan added inline comments to D5088: Move the CCmpTemplateManager inside the ComponentManager.
Jul 31 2023, 8:54 AM

Jul 17 2023

Stan added a comment to D5077: fix incorect random selection in gamesetup.

D4085

Jul 17 2023, 9:08 AM

Jul 3 2023

Stan added a comment to rP27733: Removes manual unload of delay-loaded DLLs on Windows..

This seems to have broken the Windows CI.

Jul 3 2023, 4:47 PM

Jun 29 2023

Stan added inline comments to rP27742: Add a test for the FSM.
Jun 29 2023, 3:20 PM

Jun 28 2023

Stan empowered wraitii as an administrator.
Jun 28 2023, 10:38 AM

Jun 23 2023

Stan added a comment to D4646: Parse autostart arguments in Javascript.

D2432 D4283

Jun 23 2023, 11:57 AM

Jun 21 2023

Stan added a comment to D5001: Put the CMapGeneratorWorker completely inside the task.

Would it make sense to use the Status enum ? e.g INFO::OK, INFO:SKIPPED ERR:* ?

Jun 21 2023, 2:33 PM

Jun 17 2023

Stan added inline comments to D4728: No recursive calls in FunctionWrapper.h.
Jun 17 2023, 7:24 PM
Stan added inline comments to D5051: Removes scissor backend setup from GUI.
Jun 17 2023, 7:15 PM
Stan added inline comments to D4728: No recursive calls in FunctionWrapper.h.
Jun 17 2023, 2:55 PM
Stan added a comment to D4882: Remove runtime-check for sse.

<insert the macro for x86 detection> that would be incorrect. Some other arches support it. I don't remember but I think one of power pc xx or elbrus e2k support it.

Jun 17 2023, 2:52 PM

Jun 16 2023

Stan added a comment to D4882: Remove runtime-check for sse.

It feels weird for it to be an option as it makes no sense to even be able to enable it on aarch64, arm64 or arm.
ma
https://github.com/0ad/0ad/blob/master/source/lib/sysdep/compiler.h#L106 makes me wonder what happens when building with clang. The CI doesn't print warnings about using the slow codepath (unlike arm)

Jun 16 2023, 5:40 PM
Stan added a comment to D4882: Remove runtime-check for sse.
In D4882#214666, @sera wrote:

COMPILER_HAS_SSE is a pretty bad name given it's description, we don't care at all if the compiler supports SSE. What we care about is if the target we compile for has SSE. With target I don't mean specific hardware but if -msse2 or -mno-sse2 is specified when supported respectively their equivalents for various compilers.

For provided binaries, Mac and Windows, offering only SSE enabled ones is fine, so runtime check can be removed in my eyes.

I'd use #ifdef SSEn and add those desired defines to premake for Windows, or at least move it to config.h, compiler.h feels wrong in any case.

Jun 16 2023, 4:27 PM
Stan added a comment to D4882: Remove runtime-check for sse.
In D4882#214661, @Stan wrote:

The plan was to switch on runtime depending on the machine.

Doesn't SM require to use SSE?

Jun 16 2023, 3:21 PM
Stan added a comment to D4882: Remove runtime-check for sse.

Btw I'm not sure the description is accurate. We do not require it on the client side, but on the building side. The plan was to switch on runtime depending on the machine.

Jun 16 2023, 2:24 PM
Stan updated subscribers of D4770: Multiplayer saved games.

cc @Freagarach @wraitii

Jun 16 2023, 12:11 PM

Jun 15 2023

Stan added inline comments to D5050: Moves WriteSystemInfo to HWDetect.
Jun 15 2023, 8:34 PM
Stan updated subscribers of D4882: Remove runtime-check for sse.
Jun 15 2023, 8:32 PM
Stan added a comment to D4981: Don't assign to need_update.

In both cases should be in the wiki. Also I believe some occurences have already been committed without that extra space.
EDIT: Another question is can it be enforced by say, clang format

Jun 15 2023, 9:14 AM
Stan added a comment to D4981: Don't assign to need_update.

Brace or space ?

Jun 15 2023, 8:49 AM
Stan added a comment to D5039: Allow changing lobby password inside 0 A.D..

You can undo the translation change if you need to.

Jun 15 2023, 8:48 AM

Jun 14 2023

Stan added inline comments to D3676: Removes explicit synchronizations from MapGenerator.
Jun 14 2023, 5:13 PM
Stan added a comment to D4673: [NetClient] Clean up g_xmppClient checking.

Up.

Jun 14 2023, 11:12 AM
Stan added inline comments to D5044: Don't convert actions to void*.
Jun 14 2023, 11:04 AM
Stan added inline comments to D5034: Optimisations to vertex pathfinder - relax optimality, sort unaligned edges.
Jun 14 2023, 9:53 AM

Jun 12 2023

Stan added a comment to D5042: Fix performance drop and memory leak on network games with AI.

I fiddle around but there was no way to stop the map from uncovering

Jun 12 2023, 1:54 PM

Jun 10 2023

Stan added a reviewer for D5031: Fix batch training time tech description: Balancing.
Jun 10 2023, 2:25 PM

Jun 9 2023

Stan updated subscribers of D5042: Fix performance drop and memory leak on network games with AI.

@phosit could it be what you noticed in D4786?

Jun 9 2023, 11:43 AM

Jun 8 2023

Stan added a comment to D4999: Update the rules for new lobby usernames.

@Dunedan you need to close this since you forgot to add Differential Revision: https://code.wildfiregames.com/D4999 to the commit message.

Jun 8 2023, 6:24 PM
Stan added a comment to D5041: Increase maximum number of units that can be selected at once.

Maybe it should be a game option instead? 300 is likely to be more problematic than 200 on a lot of hardware

Jun 8 2023, 1:05 PM

Jun 7 2023

Stan added inline comments to D5039: Allow changing lobby password inside 0 A.D..
Jun 7 2023, 2:21 PM

Jun 5 2023

Stan added inline comments to D5025: Restores minimap entity size to A25.
Jun 5 2023, 10:50 PM

Jun 4 2023

Stan added a comment to D5031: Fix batch training time tech description.

One thing to keep in mind is translators have a hard time translating everything that is not straightforward.

Jun 4 2023, 11:58 AM

Jun 3 2023

Stan added a comment to D5034: Optimisations to vertex pathfinder - relax optimality, sort unaligned edges.

For my knowledge what's the advantage of a struct rather than a lambda ?

Jun 3 2023, 6:32 PM
Stan added a comment to D5032: Tweaks to default Profiler2 usage..

Can you add one in the soundmanager too?

Jun 3 2023, 5:19 PM
Stan added a comment to D5031: Fix batch training time tech description.

I'm not sure it's very readable most people don't even know wha a^b is. Also it's divided not devided.

Jun 3 2023, 2:02 PM

Jun 2 2023

Stan added a comment to D5024: Fixes Vulkan hazards reported by validation layers.

Seems to fix the main menu errors.

Jun 2 2023, 2:30 PM
Stan added a comment to D5024: Fixes Vulkan hazards reported by validation layers.

On a clean SVN after applying this patch I can no longer launch the game through the vulkan SDK. This does not happen without the patch. Running it without works, but no warnings...

Jun 2 2023, 11:46 AM

Jun 1 2023

Stan added a comment to D5018: Fix game crash when communicating with the lobby on macOS 13.

Yeah they have a commit that says "indent stuff"

Jun 1 2023, 5:44 PM
Stan added a reviewer for D5017: Slaughter PrepareTime: Balancing.
Jun 1 2023, 9:31 AM

May 31 2023

Stan committed rP27657: Fix the removal of implicit conversions in libfmt 10 by using explicit casts..
Fix the removal of implicit conversions in libfmt 10 by using explicit casts.
May 31 2023, 2:03 PM
Stan closed D4998: Convert enums to their underlying type before pasing them to fmt::format..
May 31 2023, 2:03 PM
Stan updated subscribers of D5023: Stop running shrinking gcs - simplify logic..
May 31 2023, 12:47 PM
Stan updated subscribers of D5023: Stop running shrinking gcs - simplify logic..

cc @Mercury @jprahman

May 31 2023, 12:47 PM

May 30 2023

Stan committed rP27655: Fix building bundled sm-91 with clang-16..
Fix building bundled sm-91 with clang-16.
May 30 2023, 10:53 AM
Stan closed D5011: Fix building bundled sm-91 with clang-16.
May 30 2023, 10:53 AM
Stan accepted D5011: Fix building bundled sm-91 with clang-16.
May 30 2023, 10:50 AM

May 29 2023

Stan added a member for Contributors: froissant.
May 29 2023, 9:49 PM

May 28 2023

Stan retitled D5004: Rewrite handling of JS component wrappers - No PersistentRooted, more caching. from [WIP] ache JS wrappers of C++ objects to [WIP] Cache JS wrappers of C++ objects.
May 28 2023, 8:46 PM
Stan added a comment to D5011: Fix building bundled sm-91 with clang-16.

Can you update the version of build.sh so it actually builds it on the CI ?

May 28 2023, 4:09 PM
Stan added a comment to D5012: Optimisations to ApplyModifiers.

What happens if the value is NaN/null?

May 28 2023, 4:02 PM

May 25 2023

Stan added inline comments to D4839: WIP: Editor in Pyrogenesis C++ Code.
May 25 2023, 12:16 PM
Stan added a comment to D4987: Access Control Lists (ACLs) for hosted games.

You can mark this diff as planned changes in this case.

May 25 2023, 8:56 AM

May 24 2023

Stan committed rP27651: Remove unused and now broken mesh..
Remove unused and now broken mesh.
May 24 2023, 11:42 AM

May 23 2023

Stan added inline comments to D5006: Speed up ValueModification by handling it specially..
May 23 2023, 9:30 PM
Stan added inline comments to D5003: Disables framebuffer invalidating by default for GL as some drivers perform it incorrectly.
May 23 2023, 4:05 PM
Stan added inline comments to D5003: Disables framebuffer invalidating by default for GL as some drivers perform it incorrectly.
May 23 2023, 2:59 PM
Stan added a reviewer for D4987: Access Control Lists (ACLs) for hosted games: Itms.
May 23 2023, 10:50 AM
Stan added a reviewer for D4993: #5288 N7_N8 - changing %c to %lc for wchar arg.: Itms.
May 23 2023, 10:49 AM
Stan added a comment to D4987: Access Control Lists (ACLs) for hosted games.

Just a thought I had, what happens if you use Direct Connection instead of going through the lobby, with a fake username.
Maybe it would be better to use the actual jid?

May 23 2023, 10:48 AM
Stan added a comment to D3938: Increase type safety & code clarity in RangeManager.

Wonder if PLAYER_GAIA should have a constant.

May 23 2023, 10:37 AM
Stan added inline comments to D5003: Disables framebuffer invalidating by default for GL as some drivers perform it incorrectly.
May 23 2023, 10:22 AM

May 22 2023

Stan added inline comments to D3938: Increase type safety & code clarity in RangeManager.
May 22 2023, 5:33 PM
Stan added inline comments to D3938: Increase type safety & code clarity in RangeManager.
May 22 2023, 4:49 PM
Stan added a comment to D3938: Increase type safety & code clarity in RangeManager.

Ah nevermind, finally got what you meant. I tested, could not break it, tried AIs, 8 players + 1 observer, moving units around, changing perspective. Also atlas

May 22 2023, 4:42 PM
Stan added a comment to D3938: Increase type safety & code clarity in RangeManager.

Doesn't pass the debug build on Windows...

May 22 2023, 3:44 PM
Stan added a comment to D3938: Increase type safety & code clarity in RangeManager.

Just in case you don't connect to IRC: This does not compile so I'm pretty sure I can't test it much :P

May 22 2023, 3:28 PM
Stan added a comment to D5002: [WIP] Upgrade to ESR SM102.

You're missing one change in premake5.lua See: https://code.wildfiregames.com/rP27440

May 22 2023, 3:27 PM
Stan accepted D4999: Update the rules for new lobby usernames.

No objection on my end.

May 22 2023, 3:22 PM

May 19 2023

Stan added inline comments to D4998: Convert enums to their underlying type before pasing them to fmt::format..
May 19 2023, 4:32 PM

May 17 2023

Stan added a comment to D4996: Disable all logging of network messages in release mode.

Ticket about commands: #6804

May 17 2023, 11:52 AM
Stan updated the Trac tickets for D4996: Disable all logging of network messages in release mode.
May 17 2023, 11:44 AM
Stan abandoned D4996: Disable all logging of network messages in release mode.

Alright then. Let's hope for the best. D4775 is something similar although it only prevents sending useless stuff to one of the clients.

May 17 2023, 11:43 AM
Stan added a reviewer for D4775: Prevent echoing simulation commands back to their source client.: Itms.
May 17 2023, 11:30 AM

May 16 2023

Stan added a comment to D4996: Disable all logging of network messages in release mode.

Well so far I haven't seen any player compile the game, install custom mods though, more often.

May 16 2023, 2:20 PM
Stan added a comment to D4994: N9_N10_N11 - asserting for nullptr argument..

@animus It would be nice for the other two to be consistent as well (would get rid of those linter warnings), can you update the patch?

May 16 2023, 2:17 PM
Stan added a comment to D4996: Disable all logging of network messages in release mode.

Notice this diff also removes the chat leak (as in you can no longer read your opponents chat messages using the mainlog.html) it's not just about removing IPs.

May 16 2023, 10:52 AM

May 13 2023

Stan updated the diff for D4996: Disable all logging of network messages in release mode.

Fix macro

May 13 2023, 10:32 PM
Stan updated the diff for D4996: Disable all logging of network messages in release mode.

Less suppression. There is almost nothing in the logs anymore anyway since logging messages leaks chat.
But this is a patch I'm forced to make rather than I want to make. So if anyone feels like taking over please do so.

May 13 2023, 10:24 PM
Stan added a comment to D4996: Disable all logging of network messages in release mode.

Actually we're not logging for a reason :D The only logs that I know are useful are the ones we're hiding. I doubt anyone ever uses the turn numbers for anything other than debugging, which is what a debug build is for :P

May 13 2023, 6:15 PM
Stan updated subscribers of D4996: Disable all logging of network messages in release mode.

@Itms any opinion on this?

May 13 2023, 2:12 PM
Stan committed rP27644: Fix compilation with GCC 13..
Fix compilation with GCC 13.
May 13 2023, 2:10 PM
Stan closed D4997: gcc-13 & include fix.
May 13 2023, 2:10 PM

May 11 2023

Stan added inline comments to D4996: Disable all logging of network messages in release mode.
May 11 2023, 11:11 PM
Stan committed rP27642: Mark ModifiersManager as a system component..
Mark ModifiersManager as a system component.
May 11 2023, 10:52 PM
Stan updated the diff for D4996: Disable all logging of network messages in release mode.

Try to fix compilation, reduce duplication.

May 11 2023, 10:26 PM
Stan added a comment to D4996: Disable all logging of network messages in release mode.

@Silier, Ideally I wouldn't have to disable anything... Are they useful for developpers or useful for players?

May 11 2023, 2:02 PM
Stan requested review of D4996: Disable all logging of network messages in release mode.
May 11 2023, 12:20 PM
Stan committed rP27641: Fix a bug with the AI after Phab:rP27636.
Fix a bug with the AI after Phab:rP27636
May 11 2023, 11:24 AM

May 10 2023

Stan added a comment to D4623: Fix quicksave not appearing in the menu.

Yeah not this alpha

May 10 2023, 10:29 PM
Stan requested review of D4995: Fix compilation on newer macos.
May 10 2023, 7:11 PM
Stan committed rP27639: Fix two oversights..
Fix two oversights.
May 10 2023, 6:03 PM
Stan committed rP27638: Fix issues with the component documentation..
Fix issues with the component documentation.
May 10 2023, 5:56 PM
Stan closed D4985: Fix Entity docs issues.
May 10 2023, 5:56 PM