Page MenuHomeWildfire Games

Stan (Stanislas Daniel Claude Dolcini)
Butler

User Details

User Since
Jan 6 2017, 3:41 PM (203 w, 3 d)

Recent Activity

Yesterday

Stan requested review of D3173: Make update workspaces faster in case of already build.
Mon, Nov 30, 11:01 PM
Stan added a comment to D3162: Added initial support of MCST Elbrus 2000 (e2k) CPU architecture.

Mmh my apologies it seems my change wasn't totally correct.

Mon, Nov 30, 8:54 PM
Stan added a comment to D2399: [BSD] Replace ecvt() in FCollada with something else.

Maybe then

Mon, Nov 30, 7:35 PM
Stan committed rP24304: Remove Xcursor dependency following Phab:rP23364.
Remove Xcursor dependency following Phab:rP23364
Mon, Nov 30, 7:11 PM
Stan added a comment to D3076: Decouple LOS resolution from terrain resolution.

There are some type mismatches, which could or could not introduce bugs.

Mon, Nov 30, 6:51 PM
Stan added inline comments to D2399: [BSD] Replace ecvt() in FCollada with something else.
Mon, Nov 30, 5:53 PM
Stan committed rP24303: [gameplay] remove female inspiration aura.
[gameplay] remove female inspiration aura
Mon, Nov 30, 5:03 PM
Stan closed D3172: [gameplay] remove female inspiration aura.
Mon, Nov 30, 4:57 PM
Stan accepted D3172: [gameplay] remove female inspiration aura.

I agree with the change IMHO it's just sexist and poorly put women still retain their other bonuses also, it's a tiny perf improvement as auras can be costly, the change is complete (the translation files will be updated by the script automatically)

Mon, Nov 30, 4:55 PM
Stan added a comment to D2399: [BSD] Replace ecvt() in FCollada with something else.

https://pastebin.com/bbv0xkxx

Mon, Nov 30, 4:33 PM
Stan added a comment to D1781: Fix lobby chat performance issue..

Is it still extremely non trivial to use CTEXT instead, it's a bit weird to use "list" in the GUI when one means text?

Mon, Nov 30, 4:04 PM
Stan added inline comments to D14: [RC] Thread the pathfinder computations.
Mon, Nov 30, 3:30 PM
Stan committed rP24300: Use a more common locale, en_US.UTF-8 is not always present..
Use a more common locale, en_US.UTF-8 is not always present.
Mon, Nov 30, 3:01 PM
Stan committed rP24299: Fix debug_printf warning .
Fix debug_printf warning
Mon, Nov 30, 2:54 PM
Stan added a comment to D3155: Rebased Show Gatherers patch.

It doesn't take ResourceTrickle into account though, not sure that's intended.

Mon, Nov 30, 1:39 PM
Stan removed a reviewer for D2399: [BSD] Replace ecvt() in FCollada with something else: Itms.
Mon, Nov 30, 1:31 PM
Stan retitled D2399: [BSD] Replace ecvt() in FCollada with something else from #1325 Replace ecvt() in FCollada with something else to [BSD] Replace ecvt() in FCollada with something else.
Mon, Nov 30, 1:31 PM
Stan updated the diff for D2399: [BSD] Replace ecvt() in FCollada with something else.

Rebase. I've made some header fixes so that it doesn't affect Windows and other non BSD oses.
There is a flaw with the implementation however, as it doesn't handle NAN QNAN FLOAT_MAX/INFINITY and FLOAT_MIN (It will segfault) it seems however that

Mon, Nov 30, 1:22 PM
Stan added inline comments to D3161: Improve bundle-creation script to include Windows installer.
Mon, Nov 30, 12:46 PM
Stan added a comment to rP24293: Update OpenAL from 1.17 to 1.21 use v141_xp cause it needs C++14.

1.2.1 There is no 1.2.1.1 yet https://github.com/kcat/openal-soft/releases

Mon, Nov 30, 10:30 AM
Stan added a comment to D3164: [C++17] Drop binary_function.

Headers.

Mon, Nov 30, 7:56 AM

Sun, Nov 29

Stan added inline comments to D3165: Remove cache detection.
Sun, Nov 29, 8:14 PM
Stan added inline comments to D3162: Added initial support of MCST Elbrus 2000 (e2k) CPU architecture.
Sun, Nov 29, 8:12 PM
Stan committed rP24293: Update OpenAL from 1.17 to 1.21 use v141_xp cause it needs C++14.
Update OpenAL from 1.17 to 1.21 use v141_xp cause it needs C++14
Sun, Nov 29, 7:02 PM
Stan committed rP24292: Fix graphics issue with old AMD cards..
Fix graphics issue with old AMD cards.
Sun, Nov 29, 5:27 PM
Stan added inline comments to D3162: Added initial support of MCST Elbrus 2000 (e2k) CPU architecture.
Sun, Nov 29, 3:36 PM
Stan added inline comments to D3161: Improve bundle-creation script to include Windows installer.
Sun, Nov 29, 1:38 PM
Stan added inline comments to D3162: Added initial support of MCST Elbrus 2000 (e2k) CPU architecture.
Sun, Nov 29, 12:11 PM
Stan added inline comments to D3162: Added initial support of MCST Elbrus 2000 (e2k) CPU architecture.
Sun, Nov 29, 11:49 AM
Stan added inline comments to rP24290: Add globalscript helper function for Auras.
Sun, Nov 29, 11:21 AM
Stan added inline comments to D759: Adapt civinfo page to load relevant info from templates..
Sun, Nov 29, 11:19 AM
Stan added inline comments to D3162: Added initial support of MCST Elbrus 2000 (e2k) CPU architecture.
Sun, Nov 29, 11:16 AM

Sat, Nov 28

Stan added a comment to D3162: Added initial support of MCST Elbrus 2000 (e2k) CPU architecture.

Platform Changes looks alright but I'm not sure about the SSE ones we need to check it's not breaking stuff. Ideally we'd remove SSE and let the compilers decide. I asked someone else to look at it . He might have more insights.

Sat, Nov 28, 10:33 PM
Stan added inline comments to D3161: Improve bundle-creation script to include Windows installer.
Sat, Nov 28, 8:40 PM
Stan added a comment to D3160: Using same value for unit and terrain ambient colors #3: scenarios maps..

Here are my conclusions

Sat, Nov 28, 7:42 PM
Stan committed rP24288: Update libcurl from 7.59 to 7.73 use the v140_xp toolset and WINTLS (SSPI).
Update libcurl from 7.59 to 7.73 use the v140_xp toolset and WINTLS (SSPI)
Sat, Nov 28, 7:31 PM
Stan committed rP24287: Update MiniUNPNP to 2.2.0 with the 140_xp toolset..
Update MiniUNPNP to 2.2.0 with the 140_xp toolset.
Sat, Nov 28, 6:34 PM
Stan closed D3152: Update MiniUpnp to 2.2.0 and v140_xp toolset.
Sat, Nov 28, 6:34 PM
Stan committed rP24285: Update Gloox to version 1.0.24.0. Use WINTLS and v140_xp toolset. Fixes….
Update Gloox to version 1.0.24.0. Use WINTLS and v140_xp toolset. Fixes…
Sat, Nov 28, 5:41 PM

Fri, Nov 27

Stan committed rP24276: Fix incorrect index in Phab:rP24268.
Fix incorrect index in Phab:rP24268
Fri, Nov 27, 9:03 PM
Stan added inline comments to D3157: Fix MacOs bundle for Python3.
Fri, Nov 27, 8:37 PM
Stan requested review of D3156: Fix copy pasting in console..
Fri, Nov 27, 5:32 PM
Stan added a comment to D3154: Fix Hotkey/input handling in input boxes.

Test plan seems to work for me.

Fri, Nov 27, 5:18 PM
Stan raised a concern with rP24215: Let players remap hotkeys in-game, fix default hotkeys being qwerty-specific..
Fri, Nov 27, 1:16 PM
Stan requested review of D3152: Update MiniUpnp to 2.2.0 and v140_xp toolset.
Fri, Nov 27, 11:27 AM
Stan committed rP24273: Add missing file in Phab:D3126 / Phab:rP24268.
Add missing file in Phab:D3126 / Phab:rP24268
Fri, Nov 27, 10:41 AM
Stan added inline comments to D1781: Fix lobby chat performance issue..
Fri, Nov 27, 9:33 AM
Stan added inline comments to D1781: Fix lobby chat performance issue..
Fri, Nov 27, 9:23 AM
Stan updated subscribers of D2818: Replace DEFINE_INTERFACE_XX and RegisterFunction macros with pure templated code.

I'd like @vladislavbelov to have a look at the pure template code. This patch seems too big not to have undiscovered issues. Also you might want to rebase it so the CI can run on it.

Fri, Nov 27, 9:07 AM

Thu, Nov 26

Stan closed D3126: Fix MSVC 2015 Warnings for C++14.
Thu, Nov 26, 11:44 PM
Stan added inline comments to D1781: Fix lobby chat performance issue..
Thu, Nov 26, 11:37 PM
Stan committed rP24269: Follow up of D3126. Refactor L10.cpp following wraitii's advice..
Follow up of D3126. Refactor L10.cpp following wraitii's advice.
Thu, Nov 26, 11:29 PM
Stan committed rP24268: Fix most of the new vs2017 induced warnings. .
Fix most of the new vs2017 induced warnings.
Thu, Nov 26, 11:29 PM
Stan added a comment to D3096: Fix notes in rP24161..

While at it can you remove the useless const in the h files for SetInitEntities refs D3126

Thu, Nov 26, 7:36 PM
Stan updated the diff for D3126: Fix MSVC 2015 Warnings for C++14.

Fix notes and more warnings

Thu, Nov 26, 5:25 PM
Stan removed 1 auditor(s) for rP24262: Fix FCollada tests on windows for debug and release configuration. This will…: Itms.
Thu, Nov 26, 3:06 PM
Stan committed rP24262: Fix FCollada tests on windows for debug and release configuration. This will….
Fix FCollada tests on windows for debug and release configuration. This will…
Thu, Nov 26, 3:05 PM
Stan closed D1697: FCollada: Add missing includes in the test suite.
Thu, Nov 26, 3:05 PM
Stan removed 1 auditor(s) for rP24259: Fix EOL in FCollada tests: Itms.
Thu, Nov 26, 1:11 PM
Stan updated the diff for D2689: Update fmt to the most recent release.

Add missing then, sorry

Thu, Nov 26, 9:52 AM
Stan committed rP24259: Fix EOL in FCollada tests.
Fix EOL in FCollada tests
Thu, Nov 26, 9:38 AM
Stan updated the diff for D2689: Update fmt to the most recent release.

Fix previous update, fmt has only delayload on windows

Thu, Nov 26, 9:28 AM
Stan updated the diff for D2689: Update fmt to the most recent release.

Fix Delayload warnings on windows and missing debug symbols linking warning This should be good to go now. Don't forget to manually replace the .lib files and the .pdb file else it will break because they will be 0kb

Thu, Nov 26, 9:15 AM
Stan added a comment to D2689: Update fmt to the most recent release.

Thu, Nov 26, 9:14 AM
Stan abandoned D1573: Adds callbacks to the CConfigDB.

D2293 and the subsequent fixes.

Thu, Nov 26, 8:44 AM

Wed, Nov 25

Stan added a comment to D2689: Update fmt to the most recent release.

I'm launching another build to check if the VM updates fixed it. You might want to rebase this.

Wed, Nov 25, 11:17 PM
Stan committed rP24255: Fix horse breed animations. Fix naming conventions while at it..
Fix horse breed animations. Fix naming conventions while at it.
Wed, Nov 25, 11:09 PM
Stan raised a concern with rP23279: Clean Skirmish maps of default and invalid gamesetting values..

Sicilia nomad starting camera position was broken by this commit. Raising a concern so it's somewhere.

Wed, Nov 25, 10:50 PM
Stan added a comment to D3142: Using same value for unit and terrain ambient colors #2: skirmishes maps..

punjab 2p
bdeska bog
barcania
corsica
median oasis
nearestearn badlands
nile river

Wed, Nov 25, 9:06 PM
Stan added inline comments to rP24238: Fix OS detection on Windows 10..
Wed, Nov 25, 8:05 PM
Stan added a comment to rP24250: Add vs2017 to svnignore folders..

Thanks!

Wed, Nov 25, 3:32 PM
Stan committed rP24254: Make the ignore not global..
Make the ignore not global.
Wed, Nov 25, 3:30 PM
Stan removed 1 auditor(s) for rP24253: Update FCollada.dll to use the v140_xp toolset, iconv 1.16 and libxml 2.9.10: Itms.
Wed, Nov 25, 3:16 PM
Stan removed 1 auditor(s) for rP24247: Fix EOL in FCollada FDocument: Itms.
Wed, Nov 25, 3:16 PM
Stan removed 1 auditor(s) for rP24248: Fix EOL in FCollada FDocument: Itms.
Wed, Nov 25, 3:16 PM
Stan removed 1 auditor(s) for rP24249: Update the FCollada projects to use v140_xp, use multiprocessor compilation to…: Itms.
Wed, Nov 25, 3:16 PM
Stan committed rP24253: Update FCollada.dll to use the v140_xp toolset, iconv 1.16 and libxml 2.9.10.
Update FCollada.dll to use the v140_xp toolset, iconv 1.16 and libxml 2.9.10
Wed, Nov 25, 3:16 PM
Stan closed D3139: Update FCollada libraries to ones built with v141_xp.
Wed, Nov 25, 3:16 PM
Stan committed rP24252: Update libxml from 2.9.4 to 2.9.10 with vc140_xp.
Update libxml from 2.9.4 to 2.9.10 with vc140_xp
Wed, Nov 25, 3:14 PM
Stan committed rP24251: Update iconv from 1.14 to 1.16 with a .rc file so it can be show by clicking….
Update iconv from 1.14 to 1.16 with a .rc file so it can be show by clicking…
Wed, Nov 25, 3:06 PM
Stan committed rP24250: Add vs2017 to svnignore folders..
Add vs2017 to svnignore folders.
Wed, Nov 25, 3:01 PM
Stan committed rP24249: Update the FCollada projects to use v140_xp, use multiprocessor compilation to….
Update the FCollada projects to use v140_xp, use multiprocessor compilation to…
Wed, Nov 25, 2:53 PM
Stan closed D1696: FCollada: Add gitignore and Update solution files.
Wed, Nov 25, 2:53 PM
Stan committed rP24248: Fix EOL in FCollada FDocument.
Fix EOL in FCollada FDocument
Wed, Nov 25, 2:34 PM
Stan committed rP24247: Fix EOL in FCollada FDocument.
Fix EOL in FCollada FDocument
Wed, Nov 25, 2:26 PM
Stan commandeered D3139: Update FCollada libraries to ones built with v141_xp.
Wed, Nov 25, 2:22 PM

Tue, Nov 24

Stan committed rP24245: Fix recent macOS builds..
Fix recent macOS builds.
Tue, Nov 24, 8:36 PM
Stan closed D2563: NVTT build fixes.
Tue, Nov 24, 8:36 PM
Stan added a comment to D3109: Fix tab buttons not playing sounds.

I guess it's good to go then; I tried to break it but it seems to work fine. It's a bit weird for me to accept my own patch though.

Tue, Nov 24, 5:51 PM
Stan added a comment to D3139: Update FCollada libraries to ones built with v141_xp.

Note that there are still a lot of references to

<TreatWarningAsError>true</TreatWarningAsError>
Tue, Nov 24, 5:32 PM
Stan added a comment to D3109: Fix tab buttons not playing sounds.

Well it's completely broken anyway. Might be nice to print the offending file though

Tue, Nov 24, 5:05 PM
Stan added a comment to D3109: Fix tab buttons not playing sounds.

Overall looks good to me

Tue, Nov 24, 3:34 PM
Stan added a comment to rP24241: Fix segfault in FCollada with Visual Studio > 2013. Bump the version of….

Interestingly he never answered https://github.com/rdb/fcollada/issues/1

Tue, Nov 24, 3:01 PM
Stan added inline comments to D3109: Fix tab buttons not playing sounds.
Tue, Nov 24, 2:55 PM
Stan added a comment to rP24241: Fix segfault in FCollada with Visual Studio > 2013. Bump the version of….

Not really. We will have the most patched version once the other patches I made about it will be merged. I checked all the public forks.

Tue, Nov 24, 2:42 PM
Stan removed 1 auditor(s) for rP24241: Fix segfault in FCollada with Visual Studio > 2013. Bump the version of…: Itms.
Tue, Nov 24, 2:18 PM
Stan committed rP24241: Fix segfault in FCollada with Visual Studio > 2013. Bump the version of….
Fix segfault in FCollada with Visual Studio > 2013. Bump the version of…
Tue, Nov 24, 12:07 PM
Stan closed D2474: Fix Collada build on VS2015.
Tue, Nov 24, 12:07 PM
Stan updated the diff for D2474: Fix Collada build on VS2015.

Alternate fix based on feeback of wraitii and smiley

Tue, Nov 24, 10:59 AM
Stan added a comment to D3109: Fix tab buttons not playing sounds.

@s0602004 feel free to commandeer / update. Weird I didn't get your message on IRC

Tue, Nov 24, 8:30 AM