Page MenuHomeWildfire Games

Stan (Stanislas Daniel Claude Dolcini)
User

User Details

User Since
Jan 6 2017, 3:41 PM (110 w, 5 d)

Recent Activity

Yesterday

Stan added inline comments to D1718: Decay/regenerate option for resources when not being gathered from.
Tue, Feb 19, 5:04 PM
Stan updated the diff for D1718: Decay/regenerate option for resources when not being gathered from.
Tue, Feb 19, 5:04 PM
Stan updated the diff for D1718: Decay/regenerate option for resources when not being gathered from.
  • Fix space after xml tag
  • Add limit
  • Fix missing changes after cleanup
  • Make delay not optional
  • Exclude 0 from interval
  • Use changeKey instead of key.
Tue, Feb 19, 11:38 AM

Mon, Feb 18

Stan added a comment to D1718: Decay/regenerate option for resources when not being gathered from.

Not your fault. I just wanted that feature really bad for the players and I did not expect having to spend more than 100 hours on it :/

Mon, Feb 18, 10:21 AM
Stan added a comment to D1718: Decay/regenerate option for resources when not being gathered from.

Okay I'll add both then and make this a monster patch with 6 features in one. I'll also need to rewrite every single resource supply in the game. Sounds great. Gonna take some time though. Good thing we have inheritance.

Mon, Feb 18, 10:04 AM
Stan added a comment to D1718: Decay/regenerate option for resources when not being gathered from.

Is it okay if it's threshold for both ? Can be a threshold below and above right ?

Mon, Feb 18, 9:32 AM

Sun, Feb 17

Stan committed rP22092: Fix a missed file in the previous commit..
Fix a missed file in the previous commit.
Sun, Feb 17, 9:48 PM
Stan committed rP22089: Fix a typo revealed by checkrefs.pl.
Fix a typo revealed by checkrefs.pl
Sun, Feb 17, 5:03 PM
Stan added a comment to D1718: Decay/regenerate option for resources when not being gathered from.
In D1718#72241, @elexis wrote:

can't differentiate Growth from Fattening from spawning

The question is whether we want the possibility to have multiple resourcesupply effects simultaneously or whether one effect at a time covers all use cases realistically imagineable.

Sun, Feb 17, 3:58 PM
Stan added a comment to D1698: Various compilation fixes for different compilers.

It's still using the 2017 toolset so yes.

Sun, Feb 17, 3:37 PM
Stan added a comment to D1698: Various compilation fixes for different compilers.

I can't test on VS2013 but the goal is to drop support eventually and move on to 2015 2017 and maybe 2019

Sun, Feb 17, 1:55 PM
Stan added a comment to D1698: Various compilation fixes for different compilers.

Errors for debug build are here https://trac.wildfiregames.com/ticket/4460
To reproduce just start a game in debug mode.

Sun, Feb 17, 1:25 PM
Stan added a comment to D1698: Various compilation fixes for different compilers.

Updating Fcollada is not that important. Nevertheless though our debug build is broken on windows because of it and the game doesn't work with Fcollada compiled with vs2015 instant default.

Sun, Feb 17, 11:49 AM

Sat, Feb 16

Stan added inline comments to D1584: Seed random sounds.
Sat, Feb 16, 5:23 PM

Fri, Feb 8

Stan added a comment to D1718: Decay/regenerate option for resources when not being gathered from.

You need to add more classes. And you can't mix stuff. Dunno if it's good

Fri, Feb 8, 8:21 PM
Stan added a comment to D1775: Delete unused technologies.

I guess that's somehow meaning that we should check design documents before deleting stuff.

Fri, Feb 8, 8:07 PM
Stan added a comment to D1718: Decay/regenerate option for resources when not being gathered from.

So first of all it's currently

Fri, Feb 8, 7:55 PM
Stan added inline comments to D1718: Decay/regenerate option for resources when not being gathered from.
Fri, Feb 8, 4:50 PM
Stan updated the diff for D1718: Decay/regenerate option for resources when not being gathered from.
  • Update description
  • Add infinite check
  • rename functions
  • Simplify timer call to only pass the key.
Fri, Feb 8, 4:50 PM
Stan added a comment to D1724: Cleanup ExtractFormations in Commands.js.

@elexis Anything preventing you to commit this ?

Fri, Feb 8, 3:15 PM
Stan added inline comments to D1776: Cleanup Timer.js and update documentation.
Fri, Feb 8, 2:47 PM
Stan added inline comments to D1776: Cleanup Timer.js and update documentation.
Fri, Feb 8, 2:37 PM
Stan updated the diff for D1776: Cleanup Timer.js and update documentation.
  • Fix Vulkan warning
  • @returns -> @return
Fri, Feb 8, 11:55 AM
Stan created D1776: Cleanup Timer.js and update documentation.
Fri, Feb 8, 11:31 AM
Stan added a comment to D1396: Silence C4351.

For future reference.

Fri, Feb 8, 9:44 AM

Thu, Feb 7

Stan committed rP22084: Fix two comments by @elexis on rP22075.
Fix two comments by @elexis on rP22075
Thu, Feb 7, 4:51 PM
Stan committed rP22083: Group civ bonuses into a single folder.
Group civ bonuses into a single folder
Thu, Feb 7, 4:38 PM
Stan closed D1472: Grouped civ bonuses into a single folder.
Thu, Feb 7, 4:38 PM
Stan added a comment to D1758: Smooth new Kushite background.

@nani Feel free to suggest values.

Thu, Feb 7, 3:51 PM · Contributors
Stan updated the diff for D1718: Decay/regenerate option for resources when not being gathered from.
  • Make the message filter a bit smarter
Thu, Feb 7, 2:48 PM
Stan updated the diff for D1718: Decay/regenerate option for resources when not being gathered from.

Fix lint

Thu, Feb 7, 1:35 PM
Stan added a comment to D1718: Decay/regenerate option for resources when not being gathered from.

Perhaps Constraint -> HealthConstraint or HealthCondition.

Thu, Feb 7, 1:32 PM
Stan updated the diff for D1718: Decay/regenerate option for resources when not being gathered from.
  • Add option to change the interval and restart the timers
  • Fix the incorrect description
  • Remove parameter from AddRegenTimer function.
Thu, Feb 7, 1:29 PM
Stan updated the diff for D1718: Decay/regenerate option for resources when not being gathered from.
  • Remove whitespace.
Thu, Feb 7, 12:56 PM
Stan updated the diff for D1718: Decay/regenerate option for resources when not being gathered from.

@elexis Okay no problem remove the files.

Thu, Feb 7, 12:53 PM
Stan added a comment to D1718: Decay/regenerate option for resources when not being gathered from.
In D1718#71776, @Nescio wrote:

How is ResourceSupply/Fattening/Value different ?

Fattening is wrapped inside Change, right, so shouldn't it be ResourceSupply/Change/Fattening/Value then?

Sure could add a change

MaxAmount is the max amount of resource an entity can carry.

So MaxAmount is always larger than Amount? And what happens if MaxAmount is not specified?

Should be. In that case Max Amount is set to current amount.

Rate is not changeable by tech/aura. Any reason to change it over the Value ?

Actually I think both ought to be possible. E.g. heal_rate.json technology decreases Heal/Rate, not Heal/HP; for growth having smaller steps could make sense.

Okay but that will need way more code. Because you have to cancel timers for the rate to change I believe.

Thu, Feb 7, 7:43 AM

Wed, Feb 6

Stan added inline comments to rP22081: Rome Testudo & Anti-Cavalry formations animations:.
Wed, Feb 6, 7:49 PM
Stan added a comment to D1718: Decay/regenerate option for resources when not being gathered from.

How is ResourceSupply/Fattening/Value different ?

Wed, Feb 6, 7:46 PM
Stan added a comment to D1472: Grouped civ bonuses into a single folder.

Still sounds like a nice change.

Wed, Feb 6, 3:13 PM
Stan added inline comments to D1718: Decay/regenerate option for resources when not being gathered from.
Wed, Feb 6, 2:31 PM
Stan updated the diff for D1718: Decay/regenerate option for resources when not being gathered from.
  • RegenBonus -> Change
  • Amount -> Value
  • Add Slash in aura name
  • Add fish to the list of regenerating templates
  • Fix duplication
  • Use Growth Spawning and Fattening as tag names for consistency.
Wed, Feb 6, 2:30 PM
Stan added inline comments to D1718: Decay/regenerate option for resources when not being gathered from.
Wed, Feb 6, 1:28 PM
Stan added inline comments to D1718: Decay/regenerate option for resources when not being gathered from.
Wed, Feb 6, 11:12 AM
Stan updated the diff for D1718: Decay/regenerate option for resources when not being gathered from.
  • Add more examples and an aura for the corral
  • 60 is too much though.
  • 1 per 2 seconds for bushes and trees make them infinite for level 3 units.
  • @bb Can you tell me if that aura also affects gaia units or just mine ?
Wed, Feb 6, 11:09 AM

Tue, Feb 5

Stan added a comment to D1718: Decay/regenerate option for resources when not being gathered from.
In D1718#71724, @Nescio wrote:

Regeneration, growth, decay, and rot are loaded terms; “growth when dead” is a bit of a contradictio in terminis and decay implies a decrease; I don't think I'll be the only one who'll be confused by how everything works exactly. Having neutral terminology is probably imperative.

Tue, Feb 5, 10:17 PM
Stan added a comment to D1718: Decay/regenerate option for resources when not being gathered from.
In D1718#71707, @elexis wrote:

(Wondering if it would be nice to make a civbonus or teambonus for that.)

Tue, Feb 5, 6:59 PM
Stan updated the diff for D1718: Decay/regenerate option for resources when not being gathered from.

use this.infinite and not the function.

Tue, Feb 5, 6:58 PM
Stan added inline comments to D1718: Decay/regenerate option for resources when not being gathered from.
Tue, Feb 5, 12:05 PM
Stan updated the diff for D1718: Decay/regenerate option for resources when not being gathered from.
  • Remove useless code. (Now that timers are not removed, no need to add them back).
Tue, Feb 5, 11:51 AM

Mon, Feb 4

Stan added a comment to D1773: Move unit stances to a separate file.

About serialisation one could just override the serialise function and only serialise specific attributes. It's done like that in other components.

Mon, Feb 4, 10:21 PM
Stan updated the diff for D1773: Move unit stances to a separate file.
Mon, Feb 4, 6:03 PM
Stan added a reviewer for D1741: Fix some warning for vs2015 in Atlas: Restricted Owners Package.
Mon, Feb 4, 5:55 PM
Stan added inline comments to D1718: Decay/regenerate option for resources when not being gathered from.
Mon, Feb 4, 5:49 PM
Stan updated the diff for D1718: Decay/regenerate option for resources when not being gathered from.
  • Use this.amount instead of a function call
  • rename corpse to entCorpse
  • rename cmpCorpseResourceSupply to cmpResourceSupplyCorpse
  • Fix typo copy pasta buildingai
  • Simplify condition on destructor.
  • Fix coma space typo.
  • Add 4 spaces to the conditions.
  • Remove tree dead from the list of changed files.
Mon, Feb 4, 5:49 PM

Sun, Feb 3

Stan updated the diff for D1718: Decay/regenerate option for resources when not being gathered from.
  • Remove whitespaces
  • Add a destructor function to clean the timers.
Sun, Feb 3, 10:02 PM
Stan added a comment to D1718: Decay/regenerate option for resources when not being gathered from.

@elexis, Ah Indeed, do we have a destructor function ?

Sun, Feb 3, 9:40 PM
Stan created D1773: Move unit stances to a separate file.
Sun, Feb 3, 9:38 PM
Stan added a comment to D1718: Decay/regenerate option for resources when not being gathered from.

Can rename RegenBonus to Change without issues. Not sure it's the best term for the job but it reads good enough.

Sun, Feb 3, 9:34 PM
Stan added inline comments to D1718: Decay/regenerate option for resources when not being gathered from.
Sun, Feb 3, 8:54 PM
Stan added a comment to D1718: Decay/regenerate option for resources when not being gathered from.
In D1718#71612, @Nescio wrote:

One line if and only if the resource changes at exactly the same rate both when dead and alive. Theoretically possible, but I can't think of any examples.

Sun, Feb 3, 8:53 PM
Stan updated the diff for D1718: Decay/regenerate option for resources when not being gathered from.
  • fix condition indent
  • remove unneeded parenthesis
  • move health disable higher.
  • remove complex key name.
Sun, Feb 3, 8:37 PM
Stan updated the diff for D1718: Decay/regenerate option for resources when not being gathered from.
  • remove the cancellation of the timers.
  • move the timers to their own object not initialized if it's not needed.
  • add a configurable delay before an object starts decaying or growing.
  • rename rate to amount
  • remove the subscription to messages as it would not be used anyway.
Sun, Feb 3, 6:59 PM
Stan added a comment to D1718: Decay/regenerate option for resources when not being gathered from.

However it seems hard to have auras/techs affect specific ResourceSupply bonuses. So that might be one reason to go with different names i.e

Sun, Feb 3, 5:06 PM

Sat, Feb 2

Stan updated the diff for D1718: Decay/regenerate option for resources when not being gathered from.
Sat, Feb 2, 9:29 PM
Stan added inline comments to D1718: Decay/regenerate option for resources when not being gathered from.
Sat, Feb 2, 8:57 PM
Stan added a comment to D1718: Decay/regenerate option for resources when not being gathered from.

Cool ! I'll try to add a set.

Sat, Feb 2, 8:24 PM
Stan created D1772: Fix TLS Segfault on various mac versions.
Sat, Feb 2, 7:36 PM
Stan updated the diff for D1718: Decay/regenerate option for resources when not being gathered from.
Sat, Feb 2, 7:28 PM
Stan added inline comments to D1718: Decay/regenerate option for resources when not being gathered from.
Sat, Feb 2, 7:27 PM
Stan added inline comments to D1718: Decay/regenerate option for resources when not being gathered from.
Sat, Feb 2, 7:16 PM
Stan updated the diff for D1718: Decay/regenerate option for resources when not being gathered from.
Sat, Feb 2, 7:05 PM
Stan added inline comments to D1718: Decay/regenerate option for resources when not being gathered from.
Sat, Feb 2, 7:01 PM
Stan updated subscribers of D1718: Decay/regenerate option for resources when not being gathered from.
Sat, Feb 2, 5:33 PM
Stan added a comment to D1718: Decay/regenerate option for resources when not being gathered from.

If you have one that is both you lose a few lines :)
@elexis I will definitely try to save some memory for trees and only create the array if there is a Regen bonus.

Sat, Feb 2, 5:31 PM
Stan updated the diff for D1718: Decay/regenerate option for resources when not being gathered from.
  • Fix indent.
Sat, Feb 2, 3:58 AM
Stan updated the diff for D1718: Decay/regenerate option for resources when not being gathered from.
  • Remove duplication and made code more generic although, way more complex.
  • Rebase.
Sat, Feb 2, 3:56 AM
Stan planned changes to D1718: Decay/regenerate option for resources when not being gathered from.

I unified it all locally but that makes the code very complex and ugly. Will upload a new version when I figure that one or more bullshirt.

Sat, Feb 2, 12:13 AM

Fri, Feb 1

Stan added a comment to D1718: Decay/regenerate option for resources when not being gathered from.

Yeah duplication annoys me too. The thing is I really need to be able to have too cumulative auras for Regen and Decay and I can't do that with a block with a generic name...

Fri, Feb 1, 12:30 PM
Stan updated the diff for D1771: Cleanup Resource Supply.

Try to fix Vulkan's comments.

Fri, Feb 1, 1:19 AM

Thu, Jan 31

Stan created D1771: Cleanup Resource Supply.
Thu, Jan 31, 3:57 PM
Stan added a comment to D932: Acoustic notification when people join hosted game.

Can you upload the binary ? Phab will not allow one to download them from a diff. In the comment toolbar use the little cloud with an arrow.

Thu, Jan 31, 3:52 PM · Contributors
Stan added a comment to D1769: Do not mark unit as injured when receives 0 damage.

Needs a rebase after D1770

Thu, Jan 31, 3:49 PM
Stan committed rP22075: Health.js cleanup. Fixes Vulkan complaints.
Health.js cleanup. Fixes Vulkan complaints
Thu, Jan 31, 2:36 PM
Stan closed D1770: Fix Vulkan warnings in Health.js.
Thu, Jan 31, 2:36 PM
Stan added inline comments to D1718: Decay/regenerate option for resources when not being gathered from.
Thu, Jan 31, 1:49 PM

Wed, Jan 30

Stan added inline comments to D1718: Decay/regenerate option for resources when not being gathered from.
Wed, Jan 30, 10:11 PM
Stan updated the diff for D1718: Decay/regenerate option for resources when not being gathered from.

Remove duplication fix some comments. Thanks @elexis for putting up with me as I am high maintenace, I'm really doing my best to get this right.

Wed, Jan 30, 10:09 PM
Stan committed rP22074: Add pig animation source files..
Add pig animation source files.
Wed, Jan 30, 8:44 AM

Tue, Jan 29

Stan added a comment to D1472: Grouped civ bonuses into a single folder.

So basically does

Tue, Jan 29, 8:40 PM
Stan added a comment to D1769: Do not mark unit as injured when receives 0 damage.
In D1769#71392, @Angen wrote:

If unit is marked as injured, healers get it as unit to heal. So if unit with maxed health would be marked as as injured, healers would waist their time for unit that does not need it. I think, can someone think that this is not good change and disagree ?

Tue, Jan 29, 8:37 PM
ffffffff awarded D1718: Decay/regenerate option for resources when not being gathered from a Yellow Medal token.
Tue, Jan 29, 7:18 PM
Stan added a comment to D1769: Do not mark unit as injured when receives 0 damage.

I guess it's there not to keep marking the unit as injured every time you get through this. Dunno what's the performance impact, but maybe it's negligible. One could also check for the RangeManager entity flag each time, but that's more lines.

Tue, Jan 29, 4:36 PM
Stan updated subscribers of D1770: Fix Vulkan warnings in Health.js.
Tue, Jan 29, 4:34 PM
Stan updated the diff for D1770: Fix Vulkan warnings in Health.js.

Change var to let.

Tue, Jan 29, 4:32 PM
Stan updated the diff for D1718: Decay/regenerate option for resources when not being gathered from.
  • Do not serialize GrowsWhenAliveOnly, DecaysWhenDeadOnly.
  • Use the function isInfinite() instead of using the field.
Tue, Jan 29, 4:16 PM
Stan added inline comments to D1718: Decay/regenerate option for resources when not being gathered from.
Tue, Jan 29, 4:10 PM
Stan updated the diff for D1718: Decay/regenerate option for resources when not being gathered from.
Tue, Jan 29, 3:38 PM
Stan updated the diff for D1718: Decay/regenerate option for resources when not being gathered from.
  • Fix Typo
  • Remove the .0 from the diminishing return function.
Tue, Jan 29, 3:36 PM
Stan updated the diff for D1718: Decay/regenerate option for resources when not being gathered from.
  • Allow techs/auras to change the rate of decaying growing of the units.
    • Could be used for instance to boost the animal growing rate near corrals.
    • Could be used to reduce the decay of said animals if there are units nearby, or if the area is snowy and has a specific template that does so.
  • if( → if ( (This is usually done by VisualStudio, but not me...)
  • Do not initialize variables directly, only if Growth and Decay exists Maybe that will help with serialization
  • Call UpdateSupplyStatus() from set amount directly
  • Fix regenerateTimer variable that shouldn't exist.
Tue, Jan 29, 3:34 PM
Imarok awarded D1770: Fix Vulkan warnings in Health.js a Love token.
Tue, Jan 29, 2:52 PM