Page MenuHomeWildfire Games

Stan (Stanislas Daniel Claude Dolcini)
User

User Details

User Since
Jan 6 2017, 3:41 PM (159 w, 4 d)

Recent Activity

Yesterday

Stan added a comment to D1674: Check translations for sprintf errors.

Already the case. Those were approved...

Tue, Jan 28, 5:33 PM
Stan added inline comments to D2595: separate elephant archer from cavalry templates.
Tue, Jan 28, 4:14 PM

Mon, Jan 27

Stan committed rP23451: Fix a typo and a duplicated prop noticed by @elexis and checkrefs.pl. Remove a….
Fix a typo and a duplicated prop noticed by @elexis and checkrefs.pl. Remove a…
Mon, Jan 27, 11:51 PM
Stan added a comment to D1960: Move the controllability of an entity to a component..

Can't turret use this? Or do they have another special property?

Mon, Jan 27, 12:42 PM
Stan added inline comments to D2199: Add RPC interface for Reinforcement Learning.
Mon, Jan 27, 8:13 AM

Sun, Jan 26

Stan committed rP23444: Remove transparency from horses bodies..
Remove transparency from horses bodies.
Sun, Jan 26, 6:02 PM
Stan committed rP23443: Update the siege engines to not use transparency where not necessary..
Update the siege engines to not use transparency where not necessary.
Sun, Jan 26, 6:01 PM
Stan committed rP23442: Update roman civic center to use less transparency..
Update roman civic center to use less transparency.
Sun, Jan 26, 5:59 PM
Stan committed rP23441: Remove some transparency from helmets..
Remove some transparency from helmets.
Sun, Jan 26, 5:58 PM
Stan committed rP23440: Update persian merchant ship mesh to reduce the amount of transparency..
Update persian merchant ship mesh to reduce the amount of transparency.
Sun, Jan 26, 5:56 PM
Stan committed rP23439: Remove basic_trans from greaves to improve performance..
Remove basic_trans from greaves to improve performance.
Sun, Jan 26, 5:53 PM
Stan added a comment to D2598: Simple cleanup of ModelRenderer.

No difference whatsoever for me on a very large deep forest map.

Sun, Jan 26, 1:14 PM

Sat, Jan 25

Stan added a comment to D406: Add a steps param to sliders.

I assume you can't use a fixed?

Sat, Jan 25, 4:46 PM

Fri, Jan 24

Stan added a comment to D2488: Use GL_KHR_debug.

Just confirmed that the crash in debug mode of apitrace is not linked to this patch. So only thing to fix is Mac Os.

Fri, Jan 24, 10:51 AM
Stan added a comment to D2222: {civ}.json style corrections.

Fair enough :)

Fri, Jan 24, 10:30 AM
Stan added a comment to D2222: {civ}.json style corrections.

I assume there is no class for special buildings? (SB1 & SB2)

Fri, Jan 24, 9:50 AM

Thu, Jan 23

Stan added a comment to D2589: correct watermark aspect ratio.

Unstretched look indeed better. One can also notice that we used two different sprites for the same thing 0ad_logo and watermarkCompany

Thu, Jan 23, 4:15 PM
Stan updated the diff for D2488: Use GL_KHR_debug.

Fix windows build. Apitrace doesn't work for me though, it segfaults directly

Thu, Jan 23, 11:54 AM

Wed, Jan 22

Stan added a comment to D2571: Gamesetup support for sliders, use it for Ceasefire, RelicCount, RelicDuration, WonderDuration.

I like the example in the description though I think it could a bigger top padding.

Wed, Jan 22, 10:10 PM
Stan added a comment to D2528: Performance improvements to VertexBuffer.

Some notes. Can you add yourself to the credits? Keep up the great work!

Wed, Jan 22, 8:09 AM

Tue, Jan 21

Stan added a comment to D2590: delete some unused textures.

That sounds nice.

Tue, Jan 21, 2:39 PM
Stan added a comment to D2590: delete some unused textures.

I guess committing this means adding a PR to delenda est :D

Tue, Jan 21, 2:17 PM
Stan added a comment to D2584: Disable QuickLoad during multiplayer.

I don't know what you refer to when you speak about MP savegame features, because so far there is only one MP savegame feature on the table, which is picking a savegame, starting a host, and then running that match.

Tue, Jan 21, 2:16 PM
Stan added a comment to D2590: delete some unused textures.

Maybe those textures should be moved to the old public folder in https://trac.wildfiregames.com/browser/art_source/trunk/old_public

Tue, Jan 21, 1:58 PM
Stan added a comment to D2531: Analysis of unique_range assertion failure on MacOS.

I've reproduced that assertion locally on macOS 10.14.6 in debug-mode. I've figured out the reason: it seems that OSAtomicAdd64 doesn't work as expected in debug mode, maybe address was misaligned.

Tue, Jan 21, 10:02 AM · Contributors
Stan requested verification of rP23422: Delete duplicate and deprecated unit icons..
Tue, Jan 21, 8:13 AM

Mon, Jan 20

Stan committed rP23428: Fix two incorrect icons..
Fix two incorrect icons.
Mon, Jan 20, 11:58 PM
Stan committed rP23427: Use a non transparent material to improve performance..
Use a non transparent material to improve performance.
Mon, Jan 20, 11:13 PM
Stan added a comment to D2554: wall_med → wall_medium.

Given it was committed in rP6904 I assume checkrefs.pl --check-unused reports it?

Mon, Jan 20, 9:18 PM
Stan added a comment to D2554: wall_med → wall_medium.

If changing ao files, strip the _AO suffix, as they already are in an ao folder (I only do it on a case to case basis)
Any reason for those collada edits? I know Linux needs EOF to be on a newline, but stuff handling DAE seems not to care at all...

Mon, Jan 20, 8:36 PM
Stan accepted D2588: delete unused duplicate elephant icon.
Mon, Jan 20, 8:02 PM
Stan committed rP23422: Delete duplicate and deprecated unit icons..
Delete duplicate and deprecated unit icons.
Mon, Jan 20, 7:37 PM
Stan closed D2586: delete duplicate and deprecated unit icons.
Mon, Jan 20, 7:37 PM
Stan accepted D2586: delete duplicate and deprecated unit icons.

Looks good to me :) Thanks for the patch.

Mon, Jan 20, 6:22 PM
Stan added a comment to D2586: delete duplicate and deprecated unit icons.

Keep in mind many ship, siege, and support units currently share a single icon for templates of different civs.

Mon, Jan 20, 5:27 PM
Stan added a comment to D2586: delete duplicate and deprecated unit icons.

For the ones using an incorrect civ, wouldn't it make more sense to duplicate the icon to have both brit and celt, mace and athen etc?

Maybe, though that would mean having two exactly identical images. Wasn't it your intention to try reducing the download size?

Mon, Jan 20, 5:21 PM
Stan added a comment to D2586: delete duplicate and deprecated unit icons.

For the ones using an incorrect civ, wouldn't it make more sense to duplicate the icon to have both brit and celt, mace and athen etc?

Mon, Jan 20, 5:09 PM
Stan added a comment to D2583: Saves sidebar/bottombar width/height between Atlas sessions.

Patch works as expected, though it triggers a compilation warning see inline. (Missing WxUnused)

Mon, Jan 20, 4:15 PM
Stan committed rP23421: Update hero icons and names.
Update hero icons and names
Mon, Jan 20, 3:02 PM
Stan closed D2582: update hero icons and names.
Mon, Jan 20, 3:02 PM
Stan added a comment to D2584: Disable QuickLoad during multiplayer.

I think it would be nicer to have the MP savegame features, but if it isn't gonna happen soon, I believe this is the next best thing.

Mon, Jan 20, 1:49 PM
Stan added a comment to D2567: Splits debug display of frustums.

Feature is good, code looks good to me, and it works as expected.

Mon, Jan 20, 12:05 PM
Stan accepted D2567: Splits debug display of frustums.

Accepting so you can close.

Mon, Jan 20, 11:25 AM

Sun, Jan 19

Stan added inline comments to D2583: Saves sidebar/bottombar width/height between Atlas sessions.
Sun, Jan 19, 9:24 PM
Stan awarded D2583: Saves sidebar/bottombar width/height between Atlas sessions a Love token.
Sun, Jan 19, 9:24 PM
Stan added inline comments to D2328: Unify GetRange calls in UnitAI..
Sun, Jan 19, 2:34 PM
Stan accepted D2582: update hero icons and names.
Sun, Jan 19, 2:29 PM
Stan added inline comments to D2582: update hero icons and names.
Sun, Jan 19, 1:16 PM

Thu, Jan 16

Stan added inline comments to D2360: Fix entities not retaining repair order after target transforms..
Thu, Jan 16, 10:16 PM
Stan accepted D2448: Make GLES mode work on Mesa.

Works for me on RPI4 with the mesa lib.

Thu, Jan 16, 7:16 PM
Stan added a comment to D2510: [gameplay] change phase requirements.

In MP though I believe it's one of the most OP civs.

Thu, Jan 16, 3:43 PM
Stan added a comment to D2510: [gameplay] change phase requirements.

I think the idea was more to add a cost for those ptol houses.

Thu, Jan 16, 2:44 PM
Stan added inline comments to D825: Atlas: Allow map to recenter during resize.
Thu, Jan 16, 2:37 PM
Stan updated the diff for D825: Atlas: Allow map to recenter during resize.

int → ssize_t

Thu, Jan 16, 2:37 PM
Stan added inline comments to D2453: Allow Flying objects to be stationnary.
Thu, Jan 16, 2:28 PM
Stan updated the diff for D825: Atlas: Allow map to recenter during resize.

Try to fix build

Thu, Jan 16, 2:26 PM
Stan updated the diff for D825: Atlas: Allow map to recenter during resize.

Fix notes

Thu, Jan 16, 1:01 PM
Stan added a comment to D1396: Remove not needed checks and code for VS2015 [VS2013 -> VS2015].

After giving it some thought I guess you can keep the changes in mongoose.

Thu, Jan 16, 10:47 AM
Stan added a comment to D1997: Make resource entities keep their visibility when converted to resources..
In D1997#107781, @Angen wrote:

Personally I think fauna shouldn't be visible in fog-of-war

agree

Thu, Jan 16, 10:44 AM
Stan added a comment to D406: Add a steps param to sliders.

Needs to be rebased.

Thu, Jan 16, 10:43 AM
Stan added a comment to D1396: Remove not needed checks and code for VS2015 [VS2013 -> VS2015].

I'm not sure about the change in Mongoose, there are quite a few warnings in that file. I think it will be better to update it.

Thu, Jan 16, 10:05 AM
Stan added a comment to D1396: Remove not needed checks and code for VS2015 [VS2013 -> VS2015].

Just for the record

Thu, Jan 16, 9:58 AM
Stan accepted D2574: Refactors Preprocessor testing and adds more tests.
Thu, Jan 16, 12:54 AM
Stan added a comment to D2574: Refactors Preprocessor testing and adds more tests.

You could also assert there is no logger output?

Thu, Jan 16, 12:46 AM
Stan accepted D2574: Refactors Preprocessor testing and adds more tests.

Patch looks good test are sane and a nice addition and autobuild doesn't complain.

Thu, Jan 16, 12:35 AM
Stan added a comment to D2574: Refactors Preprocessor testing and adds more tests.

Oh yes, my bad.

Thu, Jan 16, 12:09 AM

Wed, Jan 15

Stan added a comment to D2574: Refactors Preprocessor testing and adds more tests.

Maybe add a test for division by 0 and #elif?

Wed, Jan 15, 11:59 PM
Stan added a comment to rP23402: Delete two unused old icons..

The other looked nice, so I wanted to make sure we could not use them instead of deleting them.

Wed, Jan 15, 7:29 PM
Stan committed rP23404: Upgrade the Ogre GLSL Preprocessor.
Upgrade the Ogre GLSL Preprocessor
Wed, Jan 15, 7:20 PM
Stan closed D2456: Update GLSL preprocessor..
Wed, Jan 15, 7:20 PM
Stan updated the diff for D2456: Update GLSL preprocessor..

Order includes, remove todo, put { on the line

Wed, Jan 15, 6:16 PM
Stan updated the summary of D2456: Update GLSL preprocessor..
Wed, Jan 15, 6:06 PM
Stan updated the diff for D2456: Update GLSL preprocessor..

assert → ensure

Wed, Jan 15, 6:05 PM
Stan updated the diff for D2456: Update GLSL preprocessor..

2019 → 2020

Wed, Jan 15, 5:50 PM
Stan added a comment to D2456: Update GLSL preprocessor..

Should I replace assert ( by ENSURE?

Wed, Jan 15, 5:48 PM
Stan added inline comments to D2456: Update GLSL preprocessor..
Wed, Jan 15, 5:47 PM
Stan updated the diff for D2456: Update GLSL preprocessor..

Fix notes.

Wed, Jan 15, 5:46 PM
Stan added a comment to D2551: rename some structure icons.

Don't ask me why, but somehow dnf remove perl (and not re-installing it) solved the errors, so now the script works for me.

Wed, Jan 15, 5:31 PM
Stan added a comment to D2551: rename some structure icons.

IIRC for perl you can also install something called CPAN

Wed, Jan 15, 5:11 PM
Stan added a comment to D2551: rename some structure icons.

apt-get install libjson-perl ? :) At least it's not the same error. Attached at P194 is a list of the current unused file. Ideally there would be close to none.

Wed, Jan 15, 4:52 PM
Stan committed rP23402: Delete two unused old icons..
Delete two unused old icons.
Wed, Jan 15, 4:47 PM
Stan added a comment to D2551: rename some structure icons.

For your information, these six structure icons appear to be unused, at least in the public simulation folder:

colony.png
gardens.png
ishtar_gate.png
lamassu.png
monument.png
shipyard.png
Wed, Jan 15, 4:30 PM
Stan added inline comments to D825: Atlas: Allow map to recenter during resize.
Wed, Jan 15, 4:23 PM
Stan added a comment to D2551: rename some structure icons.

Except that they actually belong to the cart civ.

Wed, Jan 15, 3:59 PM
Stan updated subscribers of D2551: rename some structure icons.

wooden tower were originally wooden before @LordGood made them pretty. I assume they should have been renamed then. You can still find the original wooden actor.
embassy_italic like strings are always a bit problematic because technically it could be rome_embassy, iber_embassy, gaul/brit_embassy
I think hanging_gardens should be deleted if it is unused. The icon looks ugly.

Wed, Jan 15, 3:51 PM
Stan added a comment to D2551: rename some structure icons.

The rest look fine, but I'm not sure about the tower changes. They are indeed small medium big wall artillery. Is there something wrong with wood scout sentry defense wall?

Wed, Jan 15, 3:05 PM
Stan added a comment to rP23400: Fix lineendings..

V is a git concept. Move in SVN is A & D (Add and delete)

Wed, Jan 15, 2:53 PM
Stan added a comment to rP23400: Fix lineendings..

Strange it doesn't show property as modified. See for example D2553 where it says MM. I assume it's a Phabricator bug.

Wed, Jan 15, 2:39 PM
Stan added a comment to rP23400: Fix lineendings..

You didn't set EOL to native?

Wed, Jan 15, 2:31 PM

Tue, Jan 14

Stan committed rP23394: Optimize resource trickle by not running timers when not necessary..
Optimize resource trickle by not running timers when not necessary.
Tue, Jan 14, 10:48 PM
Stan closed D2400: Optimize Resource Trickle by not running timers when not necessary.
Tue, Jan 14, 10:48 PM
Stan added a comment to D2542: Adds smart search to the Atlas entity list.

See the macos warnings https://jenkins.wildfiregames.com/blue/organizations/jenkins/macos-differential/detail/macos-differential/117/pipeline

Tue, Jan 14, 10:43 PM
Stan updated the diff for D2400: Optimize Resource Trickle by not running timers when not necessary.

Update for luck.

Tue, Jan 14, 10:38 PM
Stan added a comment to rP23387: Move the credits button on main menu.

On a side note 720 < 768 minimum resolution.

Tue, Jan 14, 5:54 PM
Stan accepted D2563: NVTT build fixes.

False alert. after running make clean clean workspaces, and rebuilding everything overnight, then cleaning the cache, it works now. There are only the compilation warning but I can live with those.

Tue, Jan 14, 8:23 AM
Stan added a comment to D1217: Pause renderer option for unfocused window.

@vladislavbelov might be of interest to you

Tue, Jan 14, 7:35 AM
Stan committed rP23390: Optimize some props by not using transparency..
Optimize some props by not using transparency.
Tue, Jan 14, 12:27 AM
Stan committed rP23389: Optimize some helmets by not using transparency when not necessary. EOL.
Optimize some helmets by not using transparency when not necessary. EOL
Tue, Jan 14, 12:26 AM
Stan committed rP23388: Optimize some structures, by not using transparency when not necessary. EOL.
Optimize some structures, by not using transparency when not necessary. EOL
Tue, Jan 14, 12:25 AM

Mon, Jan 13

Stan added a comment to D2563: NVTT build fixes.

Mon, Jan 13, 11:42 PM