Page MenuHomeWildfire Games

Stan (Stanislas Daniel Claude Dolcini)
Butler

User Details

User Since
Jan 6 2017, 3:41 PM (298 w, 3 d)

Recent Activity

Yesterday

Stan added reviewers for D4790: Use atomic as buffer index in CProfiler2::ThreadStorage: Restricted Owners Package, vladislavbelov.
Mon, Sep 26, 11:17 AM

Sun, Sep 25

Stan added inline comments to D4790: Use atomic as buffer index in CProfiler2::ThreadStorage.
Sun, Sep 25, 7:47 PM
Stan requested review of D4789: Bump version to A27.
Sun, Sep 25, 9:13 AM

Tue, Sep 20

Stan added a comment to D4669: Use _SC_NPROCESSORS_ONLN to get available CPUs.

Arch is using it

Tue, Sep 20, 10:46 AM

Mon, Sep 19

Stan abandoned D2877: [WIP] Libepoxy GL loader.

We merged the other GL loader.

Mon, Sep 19, 8:45 AM

Fri, Sep 16

Stan resigned from D4758: Rearrange GC scheduling for reduced lag.
Fri, Sep 16, 10:33 AM
Stan removed a reviewer for D4758: Rearrange GC scheduling for reduced lag: Stan.

@vladislavbelov asked me to clarify more things before committing this, because it might lead to a 6 months Feature Freeze or a painful revert.
We need to make sure it doesn't cause more spikes in other cases.

Fri, Sep 16, 10:33 AM
Stan added a comment to D4758: Rearrange GC scheduling for reduced lag.
In D4758#203957, @Stan wrote:

I the meantime can you keep testing it with different loads and replays to make sure there isn't something unstable ? :)

EG. The custom combat huge demo or a 4v4 with ais on big maps etc.

Fri, Sep 16, 7:40 AM
Stan added a comment to D4758: Rearrange GC scheduling for reduced lag.

I the meantime can you keep testing it with different loads and replays to make sure there isn't something unstable ? :)

Fri, Sep 16, 7:38 AM

Thu, Sep 15

Stan accepted D4758: Rearrange GC scheduling for reduced lag.

Nah, this looks alright, will see about committing it after the release comes out.

Thu, Sep 15, 10:22 PM

Wed, Sep 14

Stan added a comment to D4758: Rearrange GC scheduling for reduced lag.

Sorry about that, ZFS keeps failing these days, and the VM gets stuck.

Wed, Sep 14, 9:22 AM

Tue, Sep 13

Stan removed a reviewer for D4698: Fix entvalidate.py: wraitii.
Tue, Sep 13, 10:40 PM
Stan accepted D4698: Fix entvalidate.py.

Looks good to go. Wonder if they should have a copyright header. According to https://trac.wildfiregames.com/browser/ps/trunk/source/tools/LICENSE.txt it's MIT.

Tue, Sep 13, 10:40 PM
Stan added a comment to D4698: Fix entvalidate.py.

Just realised I'm an idiot and you need a way to specify the location because you don't want to put the rng in the mod folder (since you're probably gonna zip it afterwards) and it won't be there on the CI either.
Sorry, that's what happens when I do too much things at once.

Tue, Sep 13, 1:43 PM
Stan added inline comments to D4698: Fix entvalidate.py.
Tue, Sep 13, 1:29 PM
Stan added a comment to D4698: Fix entvalidate.py.

Sadly I'm not sure I can set you as author. There seem to be a way but I dunno if trac and phab support it https://stackoverflow.com/questions/2107719/how-to-set-author-for-svn#2107898

Tue, Sep 13, 8:28 AM

Mon, Sep 12

Stan committed rP27101: Update translators credit file..
Update translators credit file.
Mon, Sep 12, 10:08 PM
Stan committed rP27100: Fix translations script pipeline..
Fix translations script pipeline.
Mon, Sep 12, 1:35 PM
Stan committed rP27097: Update dockerfiles images to match jenkins.
Update dockerfiles images to match jenkins
Mon, Sep 12, 9:39 AM

Sun, Sep 11

Stan committed rP27096: Update jenkinsfiles to match upstream..
Update jenkinsfiles to match upstream.
Sun, Sep 11, 7:28 PM
Stan accepted D4787: Fixes out of bounds on each match start in Profiler2.

Fix year and LGTM.

Sun, Sep 11, 1:14 PM
Stan added inline comments to D4782: Add UpgradePlan to Petra and use it to upgrade sentry towers.
Sun, Sep 11, 11:34 AM
Stan added inline comments to D4787: Fixes out of bounds on each match start in Profiler2.
Sun, Sep 11, 11:32 AM

Sat, Sep 10

Stan committed rP27091: Fix the check translation script failing..
Fix the check translation script failing.
Sat, Sep 10, 7:19 PM
Stan added inline comments to D4782: Add UpgradePlan to Petra and use it to upgrade sentry towers.
Sat, Sep 10, 7:08 PM

Fri, Sep 9

Stan added a comment to D4786: A bit faster "state hash check".

Maybe try this flag https://github.com/7wells/0ad/blob/master/binaries/system/readme.txt#L75

Fri, Sep 9, 2:31 PM

Thu, Sep 8

Stan added inline comments to D4782: Add UpgradePlan to Petra and use it to upgrade sentry towers.
Thu, Sep 8, 10:32 AM

Wed, Sep 7

Stan added a comment to D4425: Use the threadpool for texture conversion.

Can't you make it the responsibility of the receiver to destroy objects instead of adding the extra overhead of a unique ptr?

Wed, Sep 7, 9:43 PM
Stan added a comment to D4425: Use the threadpool for texture conversion.

Windows failed because you broke the debug tests. Possibly a memory leak.

Wed, Sep 7, 2:56 PM

Tue, Sep 6

Stan added inline comments to D4425: Use the threadpool for texture conversion.
Tue, Sep 6, 11:54 PM
Stan updated the summary of D3507: Trailer hacks [not for commit].
Tue, Sep 6, 10:40 AM
Stan updated the diff for D3507: Trailer hacks [not for commit].

Updated version for A26.

Tue, Sep 6, 10:36 AM
Stan commandeered D3507: Trailer hacks [not for commit].
Tue, Sep 6, 10:27 AM

Sun, Sep 4

Stan committed rP27088: Fix ministers being trainable by all civs..
Fix ministers being trainable by all civs.
Sun, Sep 4, 12:48 PM

Sat, Sep 3

Stan added a comment to D4783: Amend ToU to disallow account sharing.

Ok then go ahead the sooner the better.

Sat, Sep 3, 7:12 AM

Fri, Sep 2

Stan updated subscribers of D4783: Amend ToU to disallow account sharing.
Fri, Sep 2, 9:01 AM
Stan accepted D4783: Amend ToU to disallow account sharing.

I am in a bit of a pickle. Should this be committed regardless of string freeze? @Freagarach, @lyv, @wraitii, @bb

Fri, Sep 2, 9:00 AM

Thu, Sep 1

Stan committed rP27084: Don't mix locally installed python libs when building.
Don't mix locally installed python libs when building
Thu, Sep 1, 10:50 PM
Stan closed D4776: Don't mix locally installed python libs when building.
Thu, Sep 1, 10:50 PM · Contributors, Restricted Project
Stan committed rP27083: Fix glad not building on BSD.
Fix glad not building on BSD
Thu, Sep 1, 10:45 PM
Stan closed D4781: Fix glad not building on BSD.
Thu, Sep 1, 10:45 PM
Stan committed rP27082: Don't try to build Atlas when wxconfig is missing.
Don't try to build Atlas when wxconfig is missing
Thu, Sep 1, 10:43 PM
Stan closed D4777: Fail when wxconfig is missing.
Thu, Sep 1, 10:43 PM
Stan committed rP27081: Revert Phab:rP26888 as it prevents building on FreeBSD..
Revert Phab:rP26888 as it prevents building on FreeBSD.
Thu, Sep 1, 10:39 PM
Stan added a comment to D4777: Fail when wxconfig is missing.

Ah nvm the last inline then ^^

Thu, Sep 1, 8:22 PM
Stan added inline comments to D4777: Fail when wxconfig is missing.
Thu, Sep 1, 8:21 PM
Stan added a comment to D4777: Fail when wxconfig is missing.

@Stan Well... who gives a shit what the ticket was about... if there's a better way to implement the ultimate goal of the ticket.

Thu, Sep 1, 6:54 PM
Stan updated the diff for D4777: Fail when wxconfig is missing.
Thu, Sep 1, 6:54 PM
Stan added a comment to D4777: Fail when wxconfig is missing.

I was thinking something like

wx-config --libs
if [ $? = 0 ]; then
  echo message
  exit 1
fi
Thu, Sep 1, 6:11 PM
Stan added a comment to D4777: Fail when wxconfig is missing.

@andy5995 It's not possible, premake does not build FCOLLADA. FCOLLADA, SPIDERMONKEY, and NVTT are built first then you build PREMAKE, then you run the script above, and then you run MAKE. You don't need wx-config for those.

Thu, Sep 1, 5:23 PM
Stan requested review of D4781: Fix glad not building on BSD.
Thu, Sep 1, 1:06 PM
Stan updated the diff for D4777: Fail when wxconfig is missing.

Update. Example output:

Thu, Sep 1, 11:59 AM

Wed, Aug 31

Stan accepted D4780: Fix Hoplite and Pikeman actors for Phalanx and Syntagma animations.

Thanks. Looks okay.

Wed, Aug 31, 10:36 PM

Tue, Aug 30

Stan accepted rP26915: Fix text alignment handling of spaces around wrapping..
Tue, Aug 30, 7:49 PM

Mon, Aug 29

Stan requested review of D4777: Fail when wxconfig is missing.
Mon, Aug 29, 2:47 PM

Aug 28 2022

Stan added inline comments to D4774: Fixes space correction after rP26915.
Aug 28 2022, 1:10 PM
Stan added a comment to D4770: Multiplayer saved games.

Make sure to fix the lint inlines too

Aug 28 2022, 12:24 AM
Stan added inline comments to D4770: Multiplayer saved games.
Aug 28 2022, 12:23 AM

Aug 27 2022

Stan committed rP27075: Switch names between ministry and civil_centre.xml reported by @AIEND..
Switch names between ministry and civil_centre.xml reported by @AIEND.
Aug 27 2022, 1:57 PM
Stan added a comment to D4774: Fixes space correction after rP26915.

Does it by any chance fixes the bug reported here https://wildfiregames.com/forum/topic/85888-german-article-about-0-ad/?do=findComment&comment=508304 by Gurken Khan?

Aug 27 2022, 1:02 PM
Stan updated subscribers of D4774: Fixes space correction after rP26915.

cc @Langbart @Mercury @jprahman this should hopefully be the last c++ patch for A26

Aug 27 2022, 2:39 AM
Stan added a comment to D4775: Prevent echoing simulation commands back to their source client..

There are some disabled network tests. They are disabled because they are broken but maybe they could be fixed. Easiest way to test is running multiple instances of the game on Linux, or on separate machines.

Aug 27 2022, 2:38 AM

Aug 26 2022

Stan added inline comments to D4773: Normalize names for ClientId in /network.
Aug 26 2022, 11:57 AM

Aug 24 2022

Stan added a comment to D4751: Fix the specialness of `FindTemplatesUnrestricted`..

Ah indeed data() works, I tested so many things and forgot that one ^^

Aug 24 2022, 5:27 PM
Stan added inline comments to D4602: Avoids assertions in case of corrupted game saves.
Aug 24 2022, 3:24 PM
Stan accepted D4756: Minor fixes for NSIS - Windows distribution script.

Changes look sane and were tested as part of the latest RC.

Aug 24 2022, 3:19 PM
Stan committed rP27071: Fix perioikoi hoplites not assuming the idle phalanx stance as the champions….
Fix perioikoi hoplites not assuming the idle phalanx stance as the champions…
Aug 24 2022, 2:29 PM
Stan committed rP27070: Fix incorrect civilization being set in the spartan sandbox. Introduced in Phab….
Fix incorrect civilization being set in the spartan sandbox. Introduced in Phab…
Aug 24 2022, 2:22 PM
Stan committed rP27069: Don't wait for observers by default and let them lag as much as needed..
Don't wait for observers by default and let them lag as much as needed.
Aug 24 2022, 2:11 PM
Stan added a comment to D4751: Fix the specialness of `FindTemplatesUnrestricted`..

@phosit it seems one cannot cast from const_iterator aka _Array_const_iterator to T* any clue?

Aug 24 2022, 12:16 PM

Aug 22 2022

Stan raised a concern with rP26915: Fix text alignment handling of spaces around wrapping..

Before the patch


After the patch

Aug 22 2022, 2:32 PM

Aug 21 2022

Stan added inline comments to D4772: Remove some unnecesary string copy. related to substr.
Aug 21 2022, 3:04 PM
Stan added inline comments to D4769: [WIP] unsync attacking / make attacking look more natural.
Aug 21 2022, 12:22 PM

Aug 20 2022

Stan added a comment to D4772: Remove some unnecesary string copy. related to substr.

Don't forget #include <string_view>. :)

Aug 20 2022, 7:20 PM
Stan committed rP27063: Fix warning reported by the NOPCH automatic CI..
Fix warning reported by the NOPCH automatic CI.
Aug 20 2022, 2:27 PM
Stan added inline comments to D4753: Fix VS2022 build.
Aug 20 2022, 2:26 PM
Stan added reviewers for D4771: [WIP] Tree falling: Freagarach, Grapjas.

Maybe it would make more sense to do it in the ResourceSupply component, like the damage levels used for the Carthaginian buildings.

Aug 20 2022, 1:55 PM
Stan added inline comments to D4770: Multiplayer saved games.
Aug 20 2022, 1:52 PM
Stan updated subscribers of D4768: Fixes TaskManager number of worker calculation.
Aug 20 2022, 12:26 PM
Stan added a comment to D4770: Multiplayer saved games.

Congrats on uploading your first patch! I have added you to the Contributors group so the next time you upload your patch, the continuous integration will run. Please provide context for your patch by adding the -U5000 command line argument to your git diff command.

Aug 20 2022, 12:09 PM
Stan added a reviewer for D4770: Multiplayer saved games: Restricted Owners Package.
Aug 20 2022, 11:54 AM
Stan added a member for Contributors: mbusy.
Aug 20 2022, 11:50 AM

Aug 18 2022

Stan added a comment to D4769: [WIP] unsync attacking / make attacking look more natural.

Mmmh won't that break all the balancing by changing DPS?
Also gotta be pretty confident to do random in the core of the sim should be tested in MP

Aug 18 2022, 8:49 PM
Stan added a comment to D4768: Fixes TaskManager number of worker calculation.

numberOfWorkers < MIN_THREADS is perfectly fine.

Aug 18 2022, 4:25 PM
Stan added a comment to D4768: Fixes TaskManager number of worker calculation.

Should be:

Aug 18 2022, 3:52 PM
Stan added a comment to D4758: Rearrange GC scheduling for reduced lag.

I think I've found all that a normal analysis can find now.

Aug 18 2022, 10:41 AM

Aug 17 2022

Stan added a comment to D4667: Add JS bindings for in game camera attributes.

Could you answer @vladislavbelov inline @edoput? Also could you provide a test mod that uses that feature?

Aug 17 2022, 5:13 PM
Stan committed rP27060: Add small flower borders to the han civic center to make its footprint more….
Add small flower borders to the han civic center to make its footprint more…
Aug 17 2022, 11:40 AM
Stan added a comment to D4754: [Gameplay] - Small nerf to CS crossbows.

@Emperior said he found those strong too.

Aug 17 2022, 8:48 AM

Aug 16 2022

Stan added inline comments to D4764: vector of locale in L10n.
Aug 16 2022, 6:51 PM
Stan committed rP27058: Fix Phab:rP27056.
Fix Phab:rP27056
Aug 16 2022, 4:58 PM
Stan closed D4765: Fix Mod.json issues..
Aug 16 2022, 4:58 PM
Stan added a comment to D4765: Fix Mod.json issues..

Perfect, thank you guys, sorry for the waste of time :)

Aug 16 2022, 4:54 PM
Stan added inline comments to D4705: Remove sys_generate_random_bytes.
Aug 16 2022, 4:53 PM
Stan added reviewers for D4766: [WIP] PS::Execution: Restricted Owners Package, vladislavbelov, wraitii.

Gotta have to check those includes, lots are missing. Can we do without boost? We're trying to reduce the dependency on it where possible.

Aug 16 2022, 4:51 PM
Stan requested review of D4765: Fix Mod.json issues..
Aug 16 2022, 2:10 PM
Stan added a comment to D4758: Rearrange GC scheduling for reduced lag.

Some unsigned / signed mismatches. There might be more. Sorry for all the nitpicks.

Aug 16 2022, 10:03 AM

Aug 15 2022

Stan abandoned D2019: [ATLASUI] Main Thread Checker: UI API called on a background thread: -[NSView initWithFrame:].
Aug 15 2022, 6:00 PM
Stan added a comment to D4758: Rearrange GC scheduling for reduced lag.
<Vladislav Belov>  might be worth mentioning that we don't have a dedicated thread for simulation. And we call update on the same thread as rendering.
<Stan> But do we have turns where we don't call simulation, only rendering? Those patches are a bit hard for me since I don't have enough knowledge about how things work...
<Vladislav Belov> I don't remember, anyway spikes inside simulation might cause visual lagging.
<wraitii> we run the sim every 200ms. if that takes 200ms, then we don't have turns that only render. otherwise we do. I think unless you get heavy lag, you'll see turns take like 20ms/20ms/60ms/20ms/20ms
<Vladislav Belov> Frames?
<wraitii> yeah. I mean ideally it'd be 16ms for a graphics frame
<Vladislav Belov> Decoupling would be cool.
<wraitii> yeah would be nice to run the sim in a thread the problem is that in late MP games sim can take > 100ms so we start getting really choppy frames.
[...]
<wraitii>:But rendering must be on the main thread because of macOS
Aug 15 2022, 5:09 PM
Stan added inline comments to D4705: Remove sys_generate_random_bytes.
Aug 15 2022, 2:56 PM