Page MenuHomeWildfire Games

Stan (Stanislas Daniel Claude Dolcini)
Butler

User Details

User Since
Jan 6 2017, 3:41 PM (262 w, 2 d)

Recent Activity

Today

Stan added a comment to D4439: Pushing improvements.

Well it's a win win for me. More people can compile and more people can give feedback :)

Sun, Jan 16, 2:10 PM
Stan added a comment to D4439: Pushing improvements.

@alre I can make an executable for you to test but I think it would be more worthwile to understand why SVN doesn't compile for you.

Sun, Jan 16, 12:30 PM

Fri, Jan 14

Stan added a comment to D4435: Draws slider button only inside its element.

Seems to work for me

Fri, Jan 14, 1:06 AM

Thu, Jan 13

Stan updated subscribers of D1730: Scroll through loading screen tips.

Maybe @Grapjas or @Langbart want to take it on?

Thu, Jan 13, 10:49 PM
Stan added a comment to D2401: [WIP] Ambient emitters.

I sadly haven't made much progress no.
Atlas is still broken AFAIR.

Thu, Jan 13, 10:49 PM
Stan added a comment to D3769: 'Unthread' the AI -> allow accessing the Sim realm from the AI realm..

Just ran a 4v4 MP match with AI and it seemed to work and to offer better performance. Unfortunately the replay is too big to be parsed by the profiler2. Patch doesn't apply because of ScriptInterface.cpp.
Changes the hash too.

Thu, Jan 13, 5:46 PM
Stan committed rP26210: Fix a change from Phab:rP11902 to a wrong alpha material..
Fix a change from Phab:rP11902 to a wrong alpha material.
Thu, Jan 13, 4:32 PM
Stan committed rP26209: Add an ARB equivalent for los_interp..
Add an ARB equivalent for los_interp.
Thu, Jan 13, 4:12 PM
Stan closed D4420: Write an ARB equivalent for los_interp.
Thu, Jan 13, 4:12 PM
Stan updated subscribers of rP26207: Allow to cap FPS up to the current max refresh rates of gaming screens: 360Hz.

Patch by: @OptimusShepard

Thu, Jan 13, 3:31 PM
Stan committed rP26207: Allow to cap FPS up to the current max refresh rates of gaming screens: 360Hz.
Allow to cap FPS up to the current max refresh rates of gaming screens: 360Hz
Thu, Jan 13, 3:31 PM
Stan closed D4366: Increase the frame limiter maximum up to 360fps.
Thu, Jan 13, 3:31 PM

Wed, Jan 12

Stan added a comment to D4428: SM91 upgrade.

Readme update https://pastebin.com/bE7bbkeP

Wed, Jan 12, 6:27 PM
Stan committed rP26204: Convert 16-bit grayscale textures to 8 bit textures. It makes little difference….
Convert 16-bit grayscale textures to 8 bit textures. It makes little difference…
Wed, Jan 12, 4:22 PM
Stan committed rP26203: Convert 16-bit 16-bit/color RGB(A) textures to 8 bit textures. It makes little….
Convert 16-bit 16-bit/color RGB(A) textures to 8 bit textures. It makes little…
Wed, Jan 12, 3:52 PM
Stan updated the diff for D3769: 'Unthread' the AI -> allow accessing the Sim realm from the AI realm..

Line endings...

Wed, Jan 12, 12:55 PM
Stan updated the diff for D3769: 'Unthread' the AI -> allow accessing the Sim realm from the AI realm..

Rebase.

Wed, Jan 12, 12:50 PM

Tue, Jan 11

Stan added a comment to D3769: 'Unthread' the AI -> allow accessing the Sim realm from the AI realm..

Rebased.

Tue, Jan 11, 5:49 PM
Stan added a comment to D4428: SM91 upgrade.

Tue, Jan 11, 2:22 PM

Mon, Jan 10

Stan added a comment to D4431: Removes direct shader binding, uses BeginPass always following rP26020.

Apply the patch and compile the game

Mon, Jan 10, 11:14 PM
Stan updated the diff for D4420: Write an ARB equivalent for los_interp.

Fix notes

Mon, Jan 10, 10:14 PM
Stan added a comment to D4428: SM91 upgrade.

Some files are missing from the tarball, see https://bugzilla.mozilla.org/show_bug.cgi?id=1749306

Mon, Jan 10, 4:41 PM
Stan published D4428: SM91 upgrade for review.

Windows CI choked.

Mon, Jan 10, 12:56 AM

Sun, Jan 9

Stan added a comment to D4430: Uses CVertexBufferManager handle instead of raw VBChunk pointer management.

Seems to work on Windows/Nvidia with no issue.

Sun, Jan 9, 11:11 PM
Stan added a comment to D4430: Uses CVertexBufferManager handle instead of raw VBChunk pointer management.
Sun, Jan 9, 10:59 PM
Stan added a comment to D4340: Display rank action in tooltip.

I think it's good.

Sun, Jan 9, 6:12 PM
Stan added a comment to D4429: Fix #6145.

For another patch we might want to make it an option. E.g. for campaigns.

Sun, Jan 9, 6:08 PM
Stan requested review of D4426: Use the threadpool for the user reporter.
Sun, Jan 9, 9:37 AM
Stan added a comment to D4425: Use the threadpool for texture conversion.

Mmmh yours might be better and more complete.

Sun, Jan 9, 9:25 AM
Stan requested review of D4425: Use the threadpool for texture conversion.
Sun, Jan 9, 8:42 AM
Stan added a comment to D4423: A try to replace glDrawRangeElements by glDrawElements.

The function seems to be called "fallback" (_mesa_draw_gallium_fallback ) so maybe you just don't support it?

Sun, Jan 9, 8:37 AM
Stan added a comment to D4423: A try to replace glDrawRangeElements by glDrawElements.

Red unpatched

Sun, Jan 9, 1:29 AM
Stan added a comment to D4422: Removes asking current bind framebuffer to avoid syncs.

Doesn't seem to make any visible difference.

Sun, Jan 9, 1:25 AM

Sat, Jan 8

Stan updated subscribers of D4424: Fix compilation on Apple Silicon.

@minohaka

Sat, Jan 8, 8:39 PM
Stan added a comment to D4423: A try to replace glDrawRangeElements by glDrawElements.

Seems slightly slower, but nothing too big.

Sat, Jan 8, 6:13 PM

Fri, Jan 7

Stan requested review of D4420: Write an ARB equivalent for los_interp.
Fri, Jan 7, 4:46 PM
Stan added a comment to D4419: Separates terrain alphamap combining and uploading.

Compiles with NOPCH on Linux https://jenkins.wildfiregames.com/job/docker-differential-custom/24/
Compiles on Windows.
I couldn't see any difference with alpha maps

Fri, Jan 7, 2:28 PM
Stan added a comment to D4413: Fix crash on big mods in x32 systems.

On Windows there seem to be a different codepath for some reason.
But we do use lseek64 instead of lseek.

Fri, Jan 7, 9:16 AM
Stan added inline comments to D4419: Separates terrain alphamap combining and uploading.
Fri, Jan 7, 8:38 AM
Stan added inline comments to rP26181: Removes ogl_tex usage from CRenderer..
Fri, Jan 7, 12:55 AM

Thu, Jan 6

Stan added a comment to D4418: Optimizes FBO usages for LOSTexture and water shore foam.

Compiles on linux with GLES and nopch.
Works on windows both debug and release, couldn't find anything obvious, doesn't mean there isn't.

Thu, Jan 6, 11:22 PM
Stan committed rP26179: Bump version of the desktop file to 1.4 the latest stable version according to….
Bump version of the desktop file to 1.4 the latest stable version according to…
Thu, Jan 6, 9:29 PM
Stan added inline comments to rP26178: Fix two typos noticed by @Nescio, and use the performance GPU on Linux too..
Thu, Jan 6, 9:25 PM
Stan committed rP26178: Fix two typos noticed by @Nescio, and use the performance GPU on Linux too..
Fix two typos noticed by @Nescio, and use the performance GPU on Linux too.
Thu, Jan 6, 8:40 PM
Stan closed D3475: General improvements to 0ad.desktop.
Thu, Jan 6, 8:40 PM
Stan removed reviewers for D3475: General improvements to 0ad.desktop: Restricted Owners Package, bb, DynamoFox.
Thu, Jan 6, 8:35 PM
Stan accepted D3475: General improvements to 0ad.desktop.
Thu, Jan 6, 8:34 PM
Stan committed rP26177: Modify 0ad.desktop to accept a file as an argument to allow installing mods by….
Modify 0ad.desktop to accept a file as an argument to allow installing mods by…
Thu, Jan 6, 8:34 PM
Stan closed D4410: Modify 0ad.desktop to accept a file as an argument.
Thu, Jan 6, 8:34 PM
Stan added a comment to D4413: Fix crash on big mods in x32 systems.

refs: #6410

Thu, Jan 6, 6:55 PM

Wed, Jan 5

Stan added a comment to D4416: Use core GL functions for GLSL.

Worked for me for both gles, arb, and glsl

Wed, Jan 5, 11:11 PM
Stan added a comment to D4417: Disables redundant mipmap generation for postprocessing.

Can barely see the difference on my intel machine.

Wed, Jan 5, 11:10 PM
Stan updated subscribers of D4416: Use core GL functions for GLSL.

@nwtour can you test this?

Wed, Jan 5, 6:23 PM
Stan accepted D4415: Performs texture uploads via DeviceCommandContext interface.
Wed, Jan 5, 3:30 PM
Stan requested changes to D4415: Performs texture uploads via DeviceCommandContext interface.

Seems to be still to be broken for GLES
https://jenkins.wildfiregames.com/job/docker-differential-custom/22/

In file included from ../../../source/lib/precompiled.h:68,
                 from ../../../source/pch/graphics/precompiled.h:18,
                 from ../../../source/renderer/backend/gl/Texture.cpp:18:
../../../source/renderer/backend/gl/Texture.cpp: In static member function 'static std::unique_ptr<Renderer::Backend::GL::CTexture> Renderer::Backend::GL::CTexture::Create(Renderer::Backend::GL::CTexture::Type, Renderer::Backend::Format, uint32_t, uint32_t, const Renderer::Backend::Sampler::Desc&, uint32_t, uint32_t)':
../../../source/lib/code_annotation.h:406:23: error: expected identifier before '[' token
 # define FALLTHROUGH [[fallthrough]]
                       ^
../../../source/renderer/backend/gl/Texture.cpp:185:21: note: in expansion of macro 'FALLTHROUGH'
   case Format::D32: FALLTHROUGH
                     ^~~~~~~~~~~
../../../source/renderer/backend/gl/Texture.cpp: In lambda function:
../../../source/renderer/backend/gl/Texture.cpp:186:4: error: expected '{' before 'internalFormat'
    internalFormat = GL_DEPTH_COMPONENT;
    ^~~~~~~~~~~~~~
../../../source/renderer/backend/gl/Texture.cpp: In static member function 'static std::unique_ptr<Renderer::Backend::GL::CTexture> Renderer::Backend::GL::CTexture::Create(Renderer::Backend::GL::CTexture::Type, Renderer::Backend::Format, uint32_t, uint32_t, const Renderer::Backend::Sampler::Desc&, uint32_t, uint32_t)':
../../../source/renderer/backend/gl/Texture.cpp:186:4: error: expected ';' before 'internalFormat'
make[1]: *** [graphics.make:481: obj/graphics_Debug/Texture.o] Error 1
make: *** [Makefile:117: graphics] Error 2
make: *** Waiting for unfinished jobs....
../../../source/lib/res/h_mgr.cpp: In function 'void h_free_hd(HDATA*)':
../../../source/lib/res/h_mgr.cpp:560:27: warning: 'void* memset(void*, int, size_t)' clearing an object of type 'struct HDATA' with no trivial copy-assignment; use assignment or value-initialization instead [-Wclass-memaccess]
  memset(hd, 0, sizeof(*hd));
                           ^
../../../source/lib/res/h_mgr.cpp:132:8: note: 'struct HDATA' declared here
 struct HDATA
        ^~~~~
Wed, Jan 5, 1:13 PM
Stan requested changes to D4415: Performs texture uploads via DeviceCommandContext interface.

From docker-build-custom #20

../../../source/renderer/backend/gl/Texture.cpp: In static member function 'static std::unique_ptr<Renderer::Backend::GL::CTexture> Renderer::Backend::GL::CTexture::Create(Renderer::Backend::GL::CTexture::Type, Renderer::Backend::Format, uint32_t, uint32_t, const Renderer::Backend::Sampler::Desc&, uint32_t, uint32_t)':
../../../source/renderer/backend/gl/Texture.cpp:181:21: error: 'GL_DEPTH_COMPONENT24' was not declared in this scope
    internalFormat = GL_DEPTH_COMPONENT24;
                     ^~~~~~~~~~~~~~~~~~~~
../../../source/renderer/backend/gl/Texture.cpp:181:21: note: suggested alternative: 'GL_DEPTH_COMPONENT'
    internalFormat = GL_DEPTH_COMPONENT24;
                     ^~~~~~~~~~~~~~~~~~~~
                     GL_DEPTH_COMPONENT
../../../source/renderer/backend/gl/Texture.cpp:192:21: error: 'GL_DEPTH24_STENCIL8_EXT' was not declared in this scope
    internalFormat = GL_DEPTH24_STENCIL8_EXT;
                     ^~~~~~~~~~~~~~~~~~~~~~~
../../../source/renderer/backend/gl/Texture.cpp:192:21: note: suggested alternative: 'GL_DEPTH_ATTACHMENT'
    internalFormat = GL_DEPTH24_STENCIL8_EXT;
                     ^~~~~~~~~~~~~~~~~~~~~~~
                     GL_DEPTH_ATTACHMENT
../../../source/renderer/backend/gl/Texture.cpp:193:18: error: 'GL_DEPTH_STENCIL_EXT' was not declared in this scope
    pixelFormat = GL_DEPTH_STENCIL_EXT;
                  ^~~~~~~~~~~~~~~~~~~~
../../../source/renderer/backend/gl/Texture.cpp:193:18: note: suggested alternative: 'GL_DEPTH_ATTACHMENT'
    pixelFormat = GL_DEPTH_STENCIL_EXT;
                  ^~~~~~~~~~~~~~~~~~~~
                  GL_DEPTH_ATTACHMENT
../../../source/renderer/backend/gl/Texture.cpp:194:16: error: 'GL_UNSIGNED_INT_24_8_EXT' was not declared in this scope
    pixelType = GL_UNSIGNED_INT_24_8_EXT;
                ^~~~~~~~~~~~~~~~~~~~~~~~
../../../source/renderer/backend/gl/Texture.cpp:194:16: note: suggested alternative: 'GL_UNSIGNED_INT'
    pixelType = GL_UNSIGNED_INT_24_8_EXT;
                ^~~~~~~~~~~~~~~~~~~~~~~~
                GL_UNSIGNED_INT
Wed, Jan 5, 9:19 AM

Tue, Jan 4

Stan committed rP26168: Write a GLSL equivalent for overlay_solid..
Write a GLSL equivalent for overlay_solid.
Tue, Jan 4, 10:14 PM
Stan closed D4406: Write a GLSL equivalent for overlay_solid.
Tue, Jan 4, 10:14 PM
Stan committed rP26167: Fix OpenGL ES 2.0 Warnings..
Fix OpenGL ES 2.0 Warnings.
Tue, Jan 4, 9:54 PM
Stan added a comment to D4412: Splits CRenderer to CSceneRenderer.

Works for me on Windows (Nvidia) and Linux (Intel). Screenshots work.

Tue, Jan 4, 1:27 AM
Stan committed rP26163: Fix OpenGL ES build after Phab:rP26141..
Fix OpenGL ES build after Phab:rP26141.
Tue, Jan 4, 1:21 AM

Mon, Jan 3

Stan edited reviewers for D2212: Show system_info.txt path in terminal when it's written, added: Restricted Owners Package; removed: elexis.
Mon, Jan 3, 6:22 PM
Stan updated the diff for D2212: Show system_info.txt path in terminal when it's written.

Unify logs a bit. Still WIP
We currently have three ways to write files (and that's not good)
IVFS::CreateFile()
std::ofstream
sys_OpenFile

Mon, Jan 3, 6:22 PM
Stan commandeered D2212: Show system_info.txt path in terminal when it's written.
Mon, Jan 3, 6:11 PM
Stan committed rP26157: Remove topology.cpp. The data isn't useful to us, and it prevents some players….
Remove topology.cpp. The data isn't useful to us, and it prevents some players…
Mon, Jan 3, 11:29 AM
Stan closed D4402: Remove Topology.cpp.
Mon, Jan 3, 11:29 AM

Fri, Dec 31

Stan accepted D4411: Removes cinema path recording from atlas.

Works and LGTM.

Fri, Dec 31, 1:30 AM

Thu, Dec 30

Stan added a comment to D4407: Removes GLuint textures from public ShaderProgram.

Seemed to work for me. I had an unrelated crash, probably ran out of memory (no logs) but couldn't reproduce after that.

Thu, Dec 30, 5:38 PM
Stan committed rP26141: Add support for GL_KHR_debug in Debug Mode..
Add support for GL_KHR_debug in Debug Mode.
Thu, Dec 30, 4:07 PM
Stan closed D2488: Use GL_KHR_debug.
Thu, Dec 30, 4:07 PM
Stan updated the diff for D2488: Use GL_KHR_debug.

Fix note. Don't create structs for nothing.

Thu, Dec 30, 3:41 PM
Stan committed rP26140: Use the high performance GPU on Windows by default..
Use the high performance GPU on Windows by default.
Thu, Dec 30, 2:58 PM
Stan closed D4401: Use the performance GPU on Windows by default.
Thu, Dec 30, 2:58 PM
Stan updated the diff for D2488: Use GL_KHR_debug.

Fix notes.

Thu, Dec 30, 2:45 PM
Stan added a comment to D3475: General improvements to 0ad.desktop.

My main concern was the GPU thing, but it's harmless enough and STK does it;

Thu, Dec 30, 2:07 PM
Stan updated the diff for D2488: Use GL_KHR_debug.
Thu, Dec 30, 2:05 PM
Stan updated subscribers of D3475: General improvements to 0ad.desktop.

@nwtour: feel like commandeering this?

Thu, Dec 30, 11:01 AM

Wed, Dec 29

Stan updated the diff for D4401: Use the performance GPU on Windows by default.

newline, add more descriptive comment

Wed, Dec 29, 7:55 PM
Stan added a comment to D4405: Speedup Atlas terrain painting tab loading.

Works fine on Windows :) @Angen you need to rebuild AtlasUI.

Wed, Dec 29, 7:46 PM
Stan added a comment to D4405: Speedup Atlas terrain painting tab loading.

Works fine on GLES. Also fixed previews which is nice.

Wed, Dec 29, 7:24 PM
Stan added a member for Contributors: z0rg.
Wed, Dec 29, 4:57 PM
asterix awarded D4402: Remove Topology.cpp a Love token.
Wed, Dec 29, 2:57 PM
Stan added inline comments to D4401: Use the performance GPU on Windows by default.
Wed, Dec 29, 11:35 AM
Stan added inline comments to D4402: Remove Topology.cpp.
Wed, Dec 29, 11:28 AM
Stan added a comment to D4403: Removes Handle from ShaderProgram to use more high-level objects.

Seems to work for me with no visible impact.

Wed, Dec 29, 1:12 AM

Tue, Dec 28

Stan added a comment to D3249: Move parabolic range computation to rangemanager.

You can add this to test_RangeManager.h (Feel free to add more test cases) The fact it returns range if the offset is zero seems odd.

Tue, Dec 28, 11:43 PM
nwtour awarded D4402: Remove Topology.cpp a Like token.
Tue, Dec 28, 11:27 PM
Stan requested review of D4402: Remove Topology.cpp.
Tue, Dec 28, 11:07 PM
Stan requested review of D4401: Use the performance GPU on Windows by default.
Tue, Dec 28, 10:03 PM
Stan added a reviewer for D4400: Remove hardcoded shadows in Atlas UI: Stan.
Tue, Dec 28, 1:11 AM
Stan added a comment to D4400: Remove hardcoded shadows in Atlas UI.

Thanks for the patch! Question, does changing the option in the actor viewer enable the shadows permanently?

Tue, Dec 28, 1:10 AM

Mon, Dec 27

Stan added a comment to D4399: Removes redundant ogl usage to process data on CPU.

Seems to work for me on Windows.

Mon, Dec 27, 11:37 PM
Stan added inline comments to D4398: Moves PostProcManager and SkyManager to GL texture class continuing rP26107..
Mon, Dec 27, 8:39 PM
Stan committed rP26125: Fix Haiku detection introduced in Phab:rP24366.
Fix Haiku detection introduced in Phab:rP24366
Mon, Dec 27, 7:59 PM
Stan closed D4396: Eliminate compiler warning. Fixes potential bug..
Mon, Dec 27, 7:59 PM
Stan accepted D4396: Eliminate compiler warning. Fixes potential bug..
Mon, Dec 27, 7:59 PM
Stan accepted D4396: Eliminate compiler warning. Fixes potential bug..
Mon, Dec 27, 5:23 PM
Stan updated subscribers of D4396: Eliminate compiler warning. Fixes potential bug..

Right thanks it has been reported once to me and I forgot about it. I'm still waiting for @nephele's haiku patch. Will commit it when you add yourself to the credits :)

Mon, Dec 27, 5:23 PM
Stan added a comment to D4397: Some minor improvements for the localization scripts.

This looks pretty nice.

Mon, Dec 27, 5:21 PM
Stan added inline comments to D4394: Moves water textures and terrain alpha composite map to GL texture class following rP26107.
Mon, Dec 27, 12:13 AM