Notice that most your examples except the last one are structure related. And those are different in the sense you won't see 1200 buildings stuck against one another. For traders their size is a bit irrelevant since they do not fight.

Use message instead of loop, add soundmanager function to play sound for a specific player

I think we might have overlooked something https://wildfiregames.com/forum/index.php?/topic/28491-archery-tradition-for-all-factions/&tab=comments#comment-400664
I looked at the code, but couldn't find where the issue lies

I like your approach better but interestingly it's done slightly differently in https://github.com/0ad/0ad/blob/d3e68a99e7f715ad7921a81e959f8ac51dfa1248/source/graphics/Color.cpp

Fix inlines

From my discussions with Optimus Shepard, the fact that it is using FMA3 is problematic, because it literraly prevents anyone with less an Intel IX-4000 era CPU and FX6000 to play the game. We don't gather stats about those, so we do not actually know how many of our users have such CPUs.
From the 7th percent improvement reported by Optimus Shepard 30% of that is due to the usage of FMA3.

Add comment inline cmpTimer, apparently JavaScript allows this, and EsLint does not complain

More tests

Remove variable

Don't set interval depending on resource

Try again

Forgot to register the global again

Fix tests, add test

Inlines.

Can you add upgrade as well?

Rebase following rP23807

Will give it another look tomorrow and commit it after that.

When running the script on SVN I get

Sure. But if I can't trust the people doing the reviews i can't merge the balancing patches :)

Yeah, I'm just being more careful this time, as I blindly trusted the previous patch, which I shouldn't have done.

Patch makes it work as expected (as in not breaking templates and keeping the default values) works no matter the civ (even gaia). My last concern is that if it might influence people into using more decimals which will lead to issues with rounding in the looting component (using mul_round doesn't have this issue)

In D2864#122827, @Nescio wrote:

If it were noticeable we wouldn't have technologies. Or civ bonuses. Or ranks.

They are however applied everytime something changes, (eg, if you change some stats of any units) While I believe template changes are not, but it's likely irrelevant yes.

mul_round should work too.

Looks like I need mul_round instead of mul

Thanks for the report!

Play a different sound depending on whether you were defeated, an ally was or an enemy was.

Fair enough

Ah nice! Didn't see your comment until now. Should I abandon this?

Can you close this, I forgot to reference the commit :/

Rebase.

@Nescio shouldn't this affect heroes somehow too? Same question for the worker elephant

Please accept the patch then :)

This is a bit heart breaking as it was my first animated model, but history seems to have spoken.

Does this need a rebase?

Changes look good and are harmless.

@nani can you update the patch? and/or plan changes?

@s0600204 thoughts on this?

I think you can change this patch to request review or something

@borg- thoughts?

For map ping alarmally_1.ogg could be used as placeholder

@Feldfeld care to accept again if it's good?

Might help https://stackoverflow.com/questions/6121792/how-to-check-if-a-cpu-supports-the-sse3-instruction-set

In D2848#122198, @Imarok wrote:

You might want to add some description to this diff like:
What is its state? (TODOs, Bugs, etc)
Did this originate from the diff andy9595 (I think that's the wrong number ;) wrote or was it written by you?

Maybe the visual studio file there?

Then why can't you select a building if the template height is set to 0 ?

Highlighted versions.

I can offer this

Another use case of that patch was suggested today on https://linuxfr.org/news/sortie-de-0-a-d-alpha-23-ken-wood-annonce-tardive#comment-1815788 Basically the idea is to create a tech that would remove the field token on polar maps, forcing the users to use corrals.

What would be such reasons?

@ValihrAnt @Feldfeld

I agree it doesn't bring anything. Too bad for the translators who had to translate it...

Some style comments, you might want to wait for @Itms or @wraitii before adressing those.

I guess another use case is this https://wildfiregames.com/forum/index.php?/topic/28385-hero-choices-dialogue-need-help/&tab=comments#comment-399437

I think they were purged because some of them were hugely wrong @Itms might know more.

@Hannibal_Barca can you check your forum PMs when you have some time?

Don't forget the final new lines in some of the files;