- User Since
- Jan 6 2017, 3:41 PM (119 w, 11 h)
@wraitii This year maybe ? ;)
Binary files should be removed from the diff :)
Needs to be rebased.
Might want to commit the whitespace changes separately :)
Thu, Apr 18
- Initialize private member before using it.
Wed, Apr 17
@vladislavbelov Can you recheck that everything is fine so I can commit it ?
- Fix incorrect function call
- Remove deleted whitespace
- Use the fast random function
- Make function and variables members of the SoundGroup.cpp class.
- Make them non static as it doesn't matter as they are constantly overridden.
cl.exe file.cpp /fp:precise file.cpp Microsoft (R) Incremental Linker Version 14.00.24245.0 Copyright (C) Microsoft Corporation. All rights reserved.
That works however I'm not sure what are the bounds of the generated number. I tried to divide it by std::limits<int>::max() but I only get 10^-6 numbers.
@wraitii Any idea on what could be faster than a MT19973 ? srand() would have been perfect but we cannot use it.
Can you fix the JSDOC comment ? :)
Tue, Apr 16
Any news on this ?
Mon, Apr 15
Yeah, it would be nice to have it for A24 but that's all.
boost::random::uniform_int_distribution & boost::random::uniform_real_distribution<float> → 1.47 https://www.boost.org/doc/libs/1_47_0/doc/html/boost/random/uniform_int_distribution.html Before it's not documented.
Sat, Apr 13
Well good thing that option doesn't exist because this means only enable-fat is needed.
I'm not sure that's an issue upstream more us supporting too many platforms with one build.
Fri, Apr 12
That you could already do. However what you couldn't do is have the same behavior clicking on the minimap
Thu, Apr 11
Wed, Apr 10
When creating your patch please add context using git diff -U5000 or svn diff -x -U5000, so that we can see the lines above and below :)
- Use srand(seed) instead. According to my tests it works way faster.
Diff to test
Will fix it asap for some reason the commit did not add all my changes... Thanks for the report.
@vladislavbelov Three questions
Tue, Apr 9
Closed the wrong differential.
Thanks for the review guys !
Well if distribution did matter we would use it everywhere no ?
That's a test so it doesn't matter much.
Thanks for the tip, I was able to make a new test (I had some troubles with static variables XD)
Maybe we should use boost after all https://stackoverflow.com/questions/20998470/random-numbers-c11-vs-boost
Mon, Apr 8
Here are some comments.
Fix diff that should not have been able to build.
*Takes the artistic cap*
Sun, Apr 7
Maybe he can request changes :)
- Make rng static to cut the compute time by half
- Use a custom seed only when cmpVisual is set
Sat, Apr 6
Does setting the seed reset the rng ?
Can't really make it static since we always want to generate the same number for a given Actor seed.
Fri, Apr 5
Will try as long as I don't have to link boost should be fine :)
How should I test it ? I'm not really confident with profiling :)
In CPP casting to a smaller type will remove the leading byte.
Thu, Apr 4