Differential D2443

Removes hard-coded clip planes from water shader
ClosedPublic
Actions

Authored by vladislavbelov on Nov 25 2019, 9:15 PM.

Details

Reviewers

None

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP23228: Removes hard-coded clip planes from water shader.

Summary

Subj.

Test Plan

Apply the patch and compile the game
Run the game and check that real water depth looks the same.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vladislavbelov created this revision.Nov 25 2019, 9:15 PM

Silier awarded a token.Nov 25 2019, 9:16 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/650/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1166/display/redirect

Harbormaster completed remote builds in B10133: Diff 10423.Nov 25 2019, 9:24 PM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 10 2019, 10:40 PM

Closed by commit rP23228: Removes hard-coded clip planes from water shader. (authored by vladislavbelov). · Explain Why

This revision was automatically updated to reflect the committed changes.

vladislavbelov added a commit: rP23228: Removes hard-coded clip planes from water shader..

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

shaders/

glsl/

water_high.fs

6 lines

source/

renderer/

TerrainRenderer.cpp

10 lines

Diff 10559

View Options

ps/trunk/binaries/data/mods/public/shaders/glsl/water_high.fs