Page MenuHomeWildfire Games

Fix missing phalanx animation for carthaginian spearmen
ClosedPublic

Authored by Silier on Dec 27 2019, 2:20 PM.

Details

Summary

They can form phalanx, but do not have animation for it.

Test Plan

:)

Event Timeline

Silier created this revision.Dec 27 2019, 2:20 PM
Owners added a subscriber: Restricted Owners Package.Dec 27 2019, 2:20 PM
Silier retitled this revision from Fix missing phalanx animation for carthaginian spearmans to Fix missing phalanx animation for carthaginian spearmen.Dec 27 2019, 2:20 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/896/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1412/display/redirect

Silier updated this revision to Diff 10800.Dec 27 2019, 2:47 PM

do not remove groups

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/897/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1413/display/redirect

Silier added a reviewer: Stan.Dec 27 2019, 3:08 PM
Stan accepted this revision.Dec 27 2019, 3:40 PM

All those spearmen files inherit from template_unit_infantry_melee_spearman_hoplite so it makes sense for them to have phalanx animation. Carthage has that formation type so that's fine. Units in formation do not show carried resource, but that's fine as I expect player wanting to see them in formation. They switch back to carry idle variant when disbanded. Also confirm animation fall back to default without this patch.

This revision is now accepted and ready to land.Dec 27 2019, 3:40 PM