Fix missing template instantiation in hierarchical pathfinder tests
AbandonedPublic
Actions

Authored by wraitii on May 18 2020, 9:03 PM.

Details

Reviewers: None
Trac Tickets: #5756

Summary

GCC 10 and clang 10 both appear stricter with regards to template instantiation, and tests fail to compile.
Move definition to header to let the compiler generate the template.
Fixes #5756.
Reported by elexis.

Test Plan

Compile tests using GCC10 and clang10

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

temp

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 11722
Build 21696: Vulcan Build	Jenkins
Build 21695: Vulcan Build (macOS)	Jenkins
Build 21694: Vulcan Build (Windows)	Jenkins
Build 21693: arc lint + arc unit

Event Timeline

wraitii created this revision.May 18 2020, 9:03 PM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/simulation2/helpers/HierarchicalPathfinder.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/helpers/HierarchicalPathfinder.h
|  34| ·*·is·defined·as·a·region.
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'template<...' is invalid C code. Use --std or --language to configure the language.

source/simulation2/helpers/HierarchicalPathfinder.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2159/display/redirect

Harbormaster completed remote builds in B11722: Diff 11920.May 18 2020, 9:21 PM