Page MenuHomeWildfire Games

Fix computation of clusters and var->let in the process
ClosedPublic

Authored by Angen on Fri, May 22, 9:37 PM.

Details

Reviewers
None
Commits
rP23693: Fix computation of clusters and var->let
Trac Tickets
#5761
Summary

When computing distances between clusters, || is used. But 0 || undefined produces undefined

WARNING: undefined ? [20][0] = 0 [0][20] = undefined

Therefore further searching for clusters fails at some point. Returning more clusters as needed results to refusing create new formation.
Introduced in rP14483.

Test Plan

Test behaviour reported in ticket is not reproducable.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Angen created this revision.Fri, May 22, 9:37 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2206/display/redirect

This revision was not accepted when it landed; it landed in state Needs Review.Sat, May 23, 2:53 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.