Differential D3024

Do not reset compatibilty filter when deleting replays
ClosedPublic
Actions

Authored by Silier on Sep 30 2020, 8:07 PM.

Details

Reviewers

Freagarach

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP24077: Do not reset compatibilty filter when deleting replays

Trac Tickets

#5824

Summary

It is annoying.
Also rest of filters do not reset.

Test Plan

Untick compatibility filter.
Delete replay.
Compatibilty filter is unchecked.
Delete replay.
Compatibility filter is unchecked.
Check compatibility filter.
Delete replay.
Compatibility filter is checked.
Uncheck filter.
Close window.
Open replay window.
Compatibility filter is checked.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Silier created this revision.Sep 30 2020, 8:07 PM

Owners added a subscriber: Restricted Owners Package.Sep 30 2020, 8:07 PM

Silier published this revision for review.Sep 30 2020, 8:07 PM

Silier added a reviewer: Restricted Owners Package.

Successful build - Chance fights ever on the side of the prudent.

builderr-release-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics.a(precompiled.o) has no symbols

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/1617/display/redirect

Harbormaster completed remote builds in B13286: Diff 13585.Sep 30 2020, 8:12 PM