Page MenuHomeWildfire Games

Freagarach
User

Projects

User Details

User Since
Apr 5 2019, 7:29 PM (23 w, 1 d)

Recent Activity

Today

Freagarach updated the summary of D2281: [WIP] - Status Effects v2 - Allow modifiers..
Sun, Sep 15, 1:07 PM
Freagarach updated the diff for D2281: [WIP] - Status Effects v2 - Allow modifiers..

Rebased.

Sun, Sep 15, 1:07 PM
Freagarach added inline comments to rP22901: GUI support for Status Effects and extend their functionality to all attack….
Sun, Sep 15, 12:17 PM
Freagarach added inline comments to D2151: Use "setStringTags"-function more often..
Sun, Sep 15, 12:06 PM
Freagarach updated the diff for D2151: Use "setStringTags"-function more often..
Sun, Sep 15, 12:05 PM
Freagarach added inline comments to D2151: Use "setStringTags"-function more often..
Sun, Sep 15, 7:50 AM
Freagarach added inline comments to D2218: Status Effects v1 - GUI support and fix following rP22754.
Sun, Sep 15, 7:30 AM

Yesterday

Freagarach updated the diff for D2281: [WIP] - Status Effects v2 - Allow modifiers..
Sat, Sep 14, 8:55 AM
Freagarach added inline comments to D2281: [WIP] - Status Effects v2 - Allow modifiers..
Sat, Sep 14, 8:53 AM
Freagarach updated the diff for D2281: [WIP] - Status Effects v2 - Allow modifiers..

Some more fiddling.
Not yet the proper way of defining what effects can occur.

Sat, Sep 14, 8:48 AM

Fri, Sep 13

Freagarach added inline comments to D2151: Use "setStringTags"-function more often..
Fri, Sep 13, 8:52 PM
Freagarach updated the diff for D2151: Use "setStringTags"-function more often..
Fri, Sep 13, 8:50 PM
Freagarach added inline comments to D2286: Notify renamed entities about value modifications when created.
Fri, Sep 13, 5:02 PM
Freagarach updated the diff for D1960: Move the controllability of an entity from "UnitAI.js" to "Commands.js" and untie it from whether the entity is an animal..
Fri, Sep 13, 9:28 AM
Freagarach updated the diff for D1960: Move the controllability of an entity from "UnitAI.js" to "Commands.js" and untie it from whether the entity is an animal..
  • Operator precedence.
  • Turrets can't move -> Turrets can't walk.
Fri, Sep 13, 9:16 AM

Thu, Sep 12

Freagarach added a comment to D2162: Do not stack fleeing orders..

The bug fixed here was already present at A23b.

Thu, Sep 12, 9:36 PM
Freagarach added a comment to D1618: Improve performance of GetEntityState by caching ApplyValueModificationsToEntity..

In particular, I'm wary of entity creation. It already takes a fair few µs per entity, and components that cache on unit creation are a big part of that.

I thought about that as well, thats why I first asked on IRC (should have tagged you).

Thu, Sep 12, 4:53 PM
Freagarach updated the diff for D1618: Improve performance of GetEntityState by caching ApplyValueModificationsToEntity..

Rebased, extended.

Thu, Sep 12, 9:46 AM
Freagarach added inline comments to D2285: Inform player that second market is too close to setup trade route.
Thu, Sep 12, 7:54 AM
Freagarach added inline comments to D2285: Inform player that second market is too close to setup trade route.
Thu, Sep 12, 7:48 AM

Wed, Sep 11

Freagarach updated the diff for D1960: Move the controllability of an entity from "UnitAI.js" to "Commands.js" and untie it from whether the entity is an animal..
  • recieve -> receive.
  • JSDOC.
Wed, Sep 11, 5:13 PM
Freagarach added inline comments to D2015: Add formation CheckTarget-/MoveToTargetRange-functions..
Wed, Sep 11, 9:11 AM
Freagarach updated the diff for D2015: Add formation CheckTarget-/MoveToTargetRange-functions..
Wed, Sep 11, 9:11 AM
Freagarach updated the diff for D1973: Support friendly fire for projectile attacks..

!= false => == true.

Wed, Sep 11, 8:56 AM
Freagarach added inline comments to D2162: Do not stack fleeing orders..
Wed, Sep 11, 8:42 AM
Freagarach updated the summary of D2162: Do not stack fleeing orders..
Wed, Sep 11, 8:42 AM
Freagarach added a comment to rP22839: Fix the issue with the formations and groups in actors And some corrections to….

Build issue solved :)
Thanks both!

Fixes #5579.

Wed, Sep 11, 8:06 AM

Tue, Sep 10

Freagarach added inline comments to D2218: Status Effects v1 - GUI support and fix following rP22754.
Tue, Sep 10, 9:54 PM
Freagarach added inline comments to D2281: [WIP] - Status Effects v2 - Allow modifiers..
Tue, Sep 10, 8:41 PM
Freagarach added a comment to D2188: Allow Promotion to add arbitrary modifiers when a unit reaches the next rank instead of changing entities.

It could indeed be a permanent status effect.

Tue, Sep 10, 4:30 PM
Freagarach added a comment to D2281: [WIP] - Status Effects v2 - Allow modifiers..

Something like this:

"<element name='Modifiers' a:help='Modifiers caused by the status.'>" +
	"<interleave>" +
		"<element name='Affects' a:help='An array of classes to affect.'>" +
			"<attribute name='datatype'>" +
				"<value>tokens</value>" +
			"</attribute>" +
			"<text/>" +
		"</element>" +
		"<oneOrMore>" +
			"<element>" +
				"<anyName />" +
				"<interleave>" +
					"<element name='Path' a:help='Path to modify.'><text/></element>" +
					"<element name='Operation' a:help='What operation to perform.'><text/></element>" +
					"<element name='Value' a:help='The value of the operation to perform.'><data type='decimal'/></element>" +
				"</interleave>" +
			"</element>" +
		"</oneOrMore>" +
	"</interleave>" +
"</element>" +

?

Tue, Sep 10, 4:29 PM
Freagarach added inline comments to D2281: [WIP] - Status Effects v2 - Allow modifiers..
Tue, Sep 10, 3:58 PM
Freagarach created D2281: [WIP] - Status Effects v2 - Allow modifiers..
Tue, Sep 10, 3:57 PM
Freagarach added inline comments to D2218: Status Effects v1 - GUI support and fix following rP22754.
Tue, Sep 10, 2:27 PM
Freagarach accepted D2275: Fix units sometimes turning around when fleeing (introduced by D1987/rP22431).

Works like a charm! Thanks @wraitii ;D
I've tried to break this in several occasions but failed to do so, however, code-wise I've little knowledge about this part.

Tue, Sep 10, 1:24 PM
Freagarach added a comment to rP22878: Fix issues with MakeGoalReachable when the goal wasn't reachable following….

I think @wraitii found this by himself?

Tue, Sep 10, 11:55 AM
Freagarach added a comment to rP22878: Fix issues with MakeGoalReachable when the goal wasn't reachable following….
ERROR: JavaScript error: simulation/ai/common-api/map-module.js line 44
TypeError: p is undefined

at turn 1092 in replay (SVN 22882).
Not sure but it might be introduced here?

Tue, Sep 10, 10:56 AM
Freagarach updated the diff for D2175: [WIP] - Basic battalionish support..

@Angen's inlines.

Tue, Sep 10, 10:34 AM

Mon, Sep 9

Freagarach added a comment to D2270: Allow area damages to have a minimum range..
In D2270#94478, @Stan wrote:
In D2270#94462, @Stan wrote:

Maybe this should be affectable by tech, (ie researching close combat weapon or whatever) ? Just an idea it would also work having #252

This patch enables a splash to have a minimum range: e.g. when the projectile lands and it has a minRange of 5 m, the first 5 m would not be damaged, only in the range between the minRange and the maxRange damage is dealt.

Yeah I meant be able to change that during the game :)

Oh, I thought focus on the second part ;)
But I thought about adding that (upgradable) here also, but I don't want to spam diffs too much, there's a lot to do already and me creating more diffs is not good for review-morale (although I have a list of diffs I want to create ;) ) and it is out of scope for this one.

Mon, Sep 9, 4:52 PM
Freagarach added inline comments to D2229: Elaborate Armour..
Mon, Sep 9, 4:39 PM
Freagarach added inline comments to D2175: [WIP] - Basic battalionish support..
Mon, Sep 9, 4:35 PM
Freagarach updated the diff for D2162: Do not stack fleeing orders..

Allow only one fleeing order.

Mon, Sep 9, 4:23 PM
Freagarach added a comment to D1496: Combat Variant.
In D1496#94455, @Stan wrote:

Patch probably needs rebase now.
But actually this seems to only set the units to use combat variant when in formation.

Yeah, the rest of the code is already there :) At least in SVN now.

Mon, Sep 9, 4:20 PM
Freagarach added a comment to D2270: Allow area damages to have a minimum range..
In D2270#94462, @Stan wrote:

Maybe this should be affectable by tech, (ie researching close combat weapon or whatever) ? Just an idea it would also work having #252

This patch enables a splash to have a minimum range: e.g. when the projectile lands and it has a minRange of 5 m, the first 5 m would not be damaged, only in the range between the minRange and the maxRange damage is dealt.

Mon, Sep 9, 4:19 PM
Freagarach added a comment to D1496: Combat Variant.
In D1496#94055, @Stan wrote:

Yeah though instead of being relative to a range check it's relative to the state.

We'd probably want it to be related to the range right? For it is strange for a unit to be in the combat mood when tasked from the one end of a map to the other?

Mon, Sep 9, 2:02 PM
Freagarach updated the diff for D2229: Elaborate Armour..

Forgot to revert previous patch,,,

Mon, Sep 9, 1:49 PM
Freagarach updated the diff for D2229: Elaborate Armour..

Rebased and some minor correction.

Mon, Sep 9, 1:38 PM
Freagarach added inline comments to rP22754: Generalise Attack effects. All attacks, including death damage and splash, can….
Mon, Sep 9, 1:36 PM
Freagarach created D2270: Allow area damages to have a minimum range..
Mon, Sep 9, 12:44 PM
Freagarach added inline comments to rP22754: Generalise Attack effects. All attacks, including death damage and splash, can….
Mon, Sep 9, 12:05 PM
Freagarach added inline comments to rP22754: Generalise Attack effects. All attacks, including death damage and splash, can….
Mon, Sep 9, 11:58 AM
Freagarach added inline comments to D2218: Status Effects v1 - GUI support and fix following rP22754.
Mon, Sep 9, 10:45 AM
Freagarach abandoned D2160: Make sure entities do not damage entities out of range..

Refs: rP14449, #1537.

Mon, Sep 9, 10:00 AM
Freagarach added a comment to D781: Elevation attack bonus for ranged units.
In D781#93951, @wraitii wrote:

The 'AttackerData' change should be put in a different diff I think, if there's not one already.

D2269.

Mon, Sep 9, 9:47 AM
Freagarach updated the diff for D2269: Combine attacker data in "attackerData" in attack-related code..

Always not nice when your test passes, you apply a last-minute-change and forget to test that...

Mon, Sep 9, 9:43 AM
Freagarach added a comment to D2218: Status Effects v1 - GUI support and fix following rP22754.
In D2218#94255, @Angen wrote:

yes icons should have own folder

Refs: D1745.

Mon, Sep 9, 9:36 AM
Freagarach added a comment to D294: Add catafalque to Structure Tree.
In D294#29869, @elexis wrote:

Might want to ask the art department on the public and/or staff forums.

Has there been any progress on this? For I definitively like the sepereate catafalque page :D

Mon, Sep 9, 9:23 AM
Freagarach added a comment to D2221: use bullets in civ history window.

Thanks for the in-depth explanation @elexis!
One more question: what is the difference between:
// Translate: context.
and the function translateWithContext("context", text)?

Mon, Sep 9, 8:55 AM

Sun, Sep 8

Freagarach created D2269: Combine attacker data in "attackerData" in attack-related code..
Sun, Sep 8, 2:56 PM
Freagarach added inline comments to D2221: use bullets in civ history window.
Sun, Sep 8, 1:59 PM
Freagarach added inline comments to D2221: use bullets in civ history window.
Sun, Sep 8, 1:38 PM
Freagarach added inline comments to D2221: use bullets in civ history window.
Sun, Sep 8, 1:26 PM
Freagarach updated the diff for D1707: Generalise hard-counter tooltips..

Rebased after D2138/rP22866.

Sun, Sep 8, 1:03 PM
Freagarach added a comment to D2221: use bullets in civ history window.
In D2221#94243, @Nescio wrote:

What do we do against the duplication?

var item = sprintf(translate('• '));? I don't know for sure, just a guess.

One may think of a global itemize-function, like in LaTeX? Store every seperate caption as part of an array and use the itemize-function to combine?

Sun, Sep 8, 12:40 PM
Freagarach added a comment to D2138: Generalised Attack effects tooltips after D2092/rP22754..

Thanks for the patch.

Thanks for committing this!

Sun, Sep 8, 8:55 AM
Freagarach added a comment to D2064: Move "PlayersToDamage" from calling functions to "CauseDamageOverArea" and replace it with FF..

Thanks @wraitii for committing this!

Sun, Sep 8, 8:54 AM

Thu, Sep 5

Freagarach added a comment to D1496: Combat Variant.

Related albeit not the same? #2503

Thu, Sep 5, 6:39 PM
Stan awarded D2262: Use new damage bonus functionality (from rP22769). a Hungry Hippo token.
Thu, Sep 5, 6:14 PM
Freagarach created D2262: Use new damage bonus functionality (from rP22769)..
Thu, Sep 5, 5:30 PM
Freagarach added a comment to D781: Elevation attack bonus for ranged units.
Thu, Sep 5, 11:42 AM
Freagarach updated the diff for D781: Elevation attack bonus for ranged units.

Fix test.

Thu, Sep 5, 11:20 AM
Freagarach updated the diff for D781: Elevation attack bonus for ranged units.
  • Rebased.
  • Adressed inlines.
  • Included melee.
Thu, Sep 5, 10:56 AM
Freagarach raised a concern with rP22754: Generalise Attack effects. All attacks, including death damage and splash, can….
Thu, Sep 5, 10:34 AM
Freagarach added inline comments to rP22754: Generalise Attack effects. All attacks, including death damage and splash, can….
Thu, Sep 5, 10:26 AM
Freagarach commandeered D1707: Generalise hard-counter tooltips..
Thu, Sep 5, 9:24 AM
Freagarach updated the diff for D1707: Generalise hard-counter tooltips..

Ugly-coded prove of concept for Melee Attack: X hack, Rate: Y second(s) (Zx vs Classes):


Code will be improved after D2138.

Thu, Sep 5, 9:23 AM
Freagarach accepted rP22839: Fix the issue with the formations and groups in actors And some corrections to….

My concerns were fixed in rP22849, thanks @Alexandermb!

Thu, Sep 5, 7:43 AM

Wed, Sep 4

Freagarach added a comment to rP22839: Fix the issue with the formations and groups in actors And some corrections to….

Can you check if this was fixed with the latest changes? my internet have been worst this days.

This was at rP22844, the issues I raised a concern about are fixed :)
No worries, take your time!

Wed, Sep 4, 11:26 PM
Freagarach updated the diff for D2015: Add formation CheckTarget-/MoveToTargetRange-functions..

Removed redundant cmpFormation.

Wed, Sep 4, 7:37 PM
Freagarach added a comment to rP22839: Fix the issue with the formations and groups in actors And some corrections to….

units/pers_champion_infantry...
ERROR: Could not load animation 'art/animation/biped/infantry/spearman/run_ready_shield_shieldsmall.dae'
ERROR: CSkeletonAnimManager::GetAnimation(art/animation/biped/infantry/spearman/run_ready_shield_shieldsmall.dae): Failed loading, marked file as bad

Wed, Sep 4, 4:59 PM
Freagarach added inline comments to D1960: Move the controllability of an entity from "UnitAI.js" to "Commands.js" and untie it from whether the entity is an animal..
Wed, Sep 4, 9:27 AM

Tue, Sep 3

Freagarach added inline comments to D1960: Move the controllability of an entity from "UnitAI.js" to "Commands.js" and untie it from whether the entity is an animal..
Tue, Sep 3, 10:17 PM
Freagarach planned changes to D2160: Make sure entities do not damage entities out of range..

(Currently) unwanted.

Tue, Sep 3, 9:57 PM
Freagarach updated the diff for D1960: Move the controllability of an entity from "UnitAI.js" to "Commands.js" and untie it from whether the entity is an animal..

"Make a unit look uncontrollable." by removing buttons when uncontrollable. The unit looks exactly like an enemy unit whilst selected now.

Tue, Sep 3, 9:50 PM
Freagarach raised a concern with rP22839: Fix the issue with the formations and groups in actors And some corrections to….

ERROR: Could not load animation 'art/animation/biped/infantry/swordsman/idle_relax_shieldsmall.dae'
ERROR: CSkeletonAnimManager::GetAnimation(art/animation/biped/infantry/swordsman/idle_relax_shieldsmall.dae): Failed loading, marked file as bad

Tue, Sep 3, 8:54 PM
Freagarach updated the diff for D2151: Use "setStringTags"-function more often..
  • Full obseletion of coloredText.
  • colorPlayerName in lobby.js is not called continously so not performance critical.
Tue, Sep 3, 5:46 PM
Freagarach added a comment to rP22839: Fix the issue with the formations and groups in actors And some corrections to….
In rP22839#37331, @Stan wrote:

@elexis can you confirm this fix both the corinthian helmet issue and @Freagarach build issue ?

Build issue solved :)
Thanks both!

Tue, Sep 3, 5:37 PM
Freagarach added a comment to D2251: AI: replace Cavalry with new Mounted class.

the AI can (and will) now train (Briton) war dogs and (Mauryan) elephant archers

Did you try this? Because I just observed two (not significant, I know) PetraAI vs PetraAI-matches and they did not produce a war dog (nor a Kennel, but even when I intervened and built a Kennel no wardogs were trained).

Tue, Sep 3, 5:13 PM
Freagarach added inline comments to D2253: standardize gather technology tooltips.
Tue, Sep 3, 4:57 PM
Freagarach updated the diff for D2151: Use "setStringTags"-function more often..

More changes. Basically, the coloredText is obselete now.
One thing I'm not sure about: the names in the lobby, I'll look into that this afternoon.

Tue, Sep 3, 9:40 AM

Mon, Sep 2

Freagarach updated the diff for D2064: Move "PlayersToDamage" from calling functions to "CauseDamageOverArea" and replace it with FF..

Test.

Mon, Sep 2, 6:56 PM
Freagarach updated the diff for D2138: Generalised Attack effects tooltips after D2092/rP22754..

When multiple projectiles: Rate instead of Interval.

Mon, Sep 2, 5:43 PM

Sun, Sep 1

Freagarach added inline comments to D2064: Move "PlayersToDamage" from calling functions to "CauseDamageOverArea" and replace it with FF..
Sun, Sep 1, 8:15 PM
Freagarach added a comment to D1808: standardized hero aura descriptions.
In D1808#93495, @Nescio wrote:

No, of course not, please be critical!

Yeah, but I do not know how the message gets conveyed ;)

Sun, Sep 1, 8:13 PM
Freagarach added inline comments to D2064: Move "PlayersToDamage" from calling functions to "CauseDamageOverArea" and replace it with FF..
Sun, Sep 1, 8:00 PM
Freagarach added a comment to D2138: Generalised Attack effects tooltips after D2092/rP22754..
In D2138#93461, @Nescio wrote:

So there *is* objection and I will revert to the desired behaviour.

It doesn't really matter how you call it internally in the code, as long as it is done consistently. However, for user-facing text strings it's best to be precise. (I actually only noticed 0 A.D. does it wrong today, because of your patch; thank you.)

I removed the whole differentiation between them and used Interval for both ^^.

Sun, Sep 1, 7:44 PM
Freagarach updated the diff for D1960: Move the controllability of an entity from "UnitAI.js" to "Commands.js" and untie it from whether the entity is an animal..
  • cmpIdentity -> cmpUnitAI.

ToDo:

  • "Make a unit look uncontrollable."
Sun, Sep 1, 7:37 PM
Freagarach added a comment to D1808: standardized hero aura descriptions.
In D1808#93493, @Nescio wrote:

Reason for my hesitance: the diff title only talks about aura descriptions, while there is actually a modif-change (yes also one class change). This *could* make it hard to track down possibly.

Well, I only included it here because of your earlier remark, but I could exclude it again, if you think that's better. I don't mind either way, it could be done in a minute.

For me you don't have to do it :) As said, I agree, but I'm usually trying to play the devil's advocate to create a full picture. I hope you don't mind...

Sun, Sep 1, 7:33 PM
Freagarach accepted D1808: standardized hero aura descriptions.

Changes look good. No errors in game. binaries/data/mods/public/simulation/data/auras/units/heroes/sele_hero_seleucus_victor.json: { "value": "Attack/Melee/Damage/Pierce", "multiply": 1.2 }, debatable but it does standardise the description so I agree.
Reason for my hesitance: the diff title only talks about aura descriptions, while there is actually a modif-change (yes also one class change). This *could* make it hard to track down possibly.

Sun, Sep 1, 7:17 PM
Freagarach added a comment to D2246: -ise → -ize.
In D2246#93462, @Nescio wrote:

Is there something wrong with Vulcan today? Why does it simultaneously succeed and fail?

Sun, Sep 1, 7:11 PM