Page MenuHomeWildfire Games

Freagarach
User

Projects

User Details

User Since
Apr 5 2019, 7:29 PM (65 w, 21 h)

Recent Activity

Fri, Jun 26

Freagarach added a comment to D2697: Do not let every entity with UnitAI listen to "OnGlobalConstructionFinished"..

With ~400 entities timings go from ~1600 μs for the postMessage to ~500 μs for the postMessage including builders query.

Fri, Jun 26, 4:48 PM
Freagarach updated the diff for D2755: Do not pass owner when trying to add gatherer..

Remove duplicate call.

Fri, Jun 26, 3:51 PM
Freagarach updated the diff for D2426: Allow world population..

Use let by scoping.

Fri, Jun 26, 8:56 AM
Freagarach updated the diff for D2426: Allow world population..

Fix population cheat. This adds 500 to the limit instead of replacing since that seems kind of weird when playing with high population capacities.

Fri, Jun 26, 8:51 AM
Freagarach added a comment to D2426: Allow world population..
In D2426#121613, @Angen wrote:

If one plays with hacked popcap (gift from the gods e.g.) and any player is defeated/resigned cheat influence on pop cap is removed.

This would actually be an issue with how the cheat is applied.

Fri, Jun 26, 8:28 AM
Freagarach added a comment to D2824: Split vision range from going-to-attack range in UnitAI..

This should actually be more performant (in the short run at least) since entities like sheep (non skittish, non attacking) do not have a query anymore, and healers have one (unused) query less now.

Fri, Jun 26, 8:24 AM

Thu, Jun 25

Freagarach updated the diff for D2654: Allow free Upgrades and/or Technologies..

Let sele-tech benefit.

Thu, Jun 25, 4:45 PM
Freagarach updated the diff for D2824: Split vision range from going-to-attack range in UnitAI..

Some var -> let in the vicinity.

Thu, Jun 25, 4:19 PM
Freagarach added inline comments to D2824: Split vision range from going-to-attack range in UnitAI..
Thu, Jun 25, 4:03 PM
Freagarach accepted D2834: alphabetize entity limits and statistics classes.
Thu, Jun 25, 11:05 AM
Freagarach updated subscribers of D1269: Session: Show more command buttons.

It's a bit of a pain to quickly click on them now, perhaps show five at a time and increase the size of the arrows?

Thu, Jun 25, 9:43 AM
Freagarach added inline comments to D1877: Show summary graphs for teams.
Thu, Jun 25, 9:33 AM
Freagarach added a comment to D2836: When opening the summary as Gaia don't show warnings.

Can't we show GAIA kills and such?

Thu, Jun 25, 9:06 AM
Freagarach added a comment to D2833: Add where and how to contribute to README.txt.

The rest of the file is not consistent in its use of periods. Or it is: use one after each sentence but not when the sentence ends with a link or command of some kind.

Thu, Jun 25, 9:00 AM
Freagarach added inline comments to D2834: alphabetize entity limits and statistics classes.
Thu, Jun 25, 8:27 AM
Freagarach added inline comments to D2834: alphabetize entity limits and statistics classes.
Thu, Jun 25, 8:22 AM

Wed, Jun 24

Freagarach updated the diff for D2824: Split vision range from going-to-attack range in UnitAI..

Remove this.IsHealer() from UpdateRangeQueries.

Wed, Jun 24, 7:06 PM
Freagarach added inline comments to D2824: Split vision range from going-to-attack range in UnitAI..
Wed, Jun 24, 7:00 PM
Freagarach updated the diff for D2824: Split vision range from going-to-attack range in UnitAI..

Inlines.

Wed, Jun 24, 7:00 PM
Freagarach added a comment to D2764: Allow enabling default formation / no-formation stances on a command basis.

Formation behaviour ought to be in UnitAI, one can disband formation temporarily when close to gathering point, perhaps?

Wed, Jun 24, 5:57 PM
Freagarach added a comment to D2833: Add where and how to contribute to README.txt.

It's not really consistent in the rest of the file ;)

Wed, Jun 24, 5:45 PM
Freagarach added inline comments to D2834: alphabetize entity limits and statistics classes.
Wed, Jun 24, 5:41 PM
Freagarach added inline comments to D1977: Cheer after no enemies in range left.
Wed, Jun 24, 5:34 PM

Tue, Jun 23

Freagarach planned changes to D2824: Split vision range from going-to-attack range in UnitAI..
Tue, Jun 23, 9:53 PM
Freagarach added inline comments to D2824: Split vision range from going-to-attack range in UnitAI..
Tue, Jun 23, 9:53 PM
Freagarach added inline comments to D2834: alphabetize entity limits and statistics classes.
Tue, Jun 23, 9:42 PM
Freagarach added inline comments to D2833: Add where and how to contribute to README.txt.
Tue, Jun 23, 9:31 PM
Freagarach planned changes to D2229: Elaborate Armour..

The schema proposed by @bb seems indeed more extensible.

Tue, Jun 23, 6:35 PM
Freagarach added a comment to D2831: Remove redundant bonus schema from DeathDamage.js..

Thanks for the review and commit @bb :)

Tue, Jun 23, 5:21 PM

Mon, Jun 22

Freagarach added inline comments to D2229: Elaborate Armour..
Mon, Jun 22, 9:36 PM
Freagarach updated the diff for D2229: Elaborate Armour..
  • Reenable capture resistance.
  • Changed tooltips (they're really bad).
Mon, Jun 22, 9:33 PM
Lionkanzen awarded D2808: Allow resistance to StatusEffects. a Love token.
Mon, Jun 22, 9:21 PM
Freagarach created D2831: Remove redundant bonus schema from DeathDamage.js..
Mon, Jun 22, 7:25 PM
Freagarach added inline comments to D2229: Elaborate Armour..
Mon, Jun 22, 6:56 PM
Freagarach added inline comments to D1977: Cheer after no enemies in range left.
Mon, Jun 22, 6:32 PM
Freagarach added a comment to D1977: Cheer after no enemies in range left.

Ah, yes, such an sanity check would indeed be good. Too bad they would need to be in sync then (the presence of an animation and the check in UnitAI).

Mon, Jun 22, 5:44 PM
Freagarach added a comment to D1977: Cheer after no enemies in range left.

If we want anything not to cheer then we can disable/remove the animation, right? Monkeys celebrate, probably other animals do as well.

Mon, Jun 22, 4:40 PM
Freagarach updated the diff for D2229: Elaborate Armour..
  • Rebased.
  • Removed Capture resistance (unused).
  • Removed SE-resistance (D2808).
Mon, Jun 22, 11:12 AM

Sun, Jun 21

Freagarach added inline comments to D2824: Split vision range from going-to-attack range in UnitAI..
Sun, Jun 21, 8:44 PM
Freagarach updated the diff for D2824: Split vision range from going-to-attack range in UnitAI..
  • Check for msg && msg.data && msg.data.added.
  • Some styling.
  • Setup LOS query only when needed.
Sun, Jun 21, 8:43 PM
Freagarach raised a concern with rP22754: Generalise Attack effects. All attacks, including death damage and splash, can….
Sun, Jun 21, 8:39 PM
Freagarach added a comment to D2368: Move some logic from UnitAI's "Garrisoned"-state to "Garrison:Approaching"..

Well, the idea is: don't switch states when we're not supposed to.

Sun, Jun 21, 7:37 PM
Freagarach added inline comments to D2826: Cleanup of Capturable.
Sun, Jun 21, 7:16 PM
Freagarach added inline comments to D2826: Cleanup of Capturable.
Sun, Jun 21, 11:15 AM

Sat, Jun 20

Lionkanzen awarded D2382: [WIP] - Building Sockets. a Manufacturing Defect? token.
Sat, Jun 20, 9:32 PM
Freagarach updated the diff for D2810: Don't process commands sent by observers..

Possibly fix the underlying cause.

Sat, Jun 20, 1:13 PM
Freagarach retitled D2697: Do not let every entity with UnitAI listen to "OnGlobalConstructionFinished". from Do not let every entity with UnitAI listen to "OnGlobalConstructionFinished", while it is perhaps not needed anymore. to Do not let every entity with UnitAI listen to "OnGlobalConstructionFinished"..
Sat, Jun 20, 8:48 AM
Freagarach updated the diff for D2697: Do not let every entity with UnitAI listen to "OnGlobalConstructionFinished"..

Query UnitAI directly.

Sat, Jun 20, 8:44 AM
Freagarach added inline comments to rP23771: Rework ScriptInterface EnumeratePropertyNames to support non-enumerable….
Sat, Jun 20, 8:22 AM

Fri, Jun 19

Freagarach added inline comments to D2824: Split vision range from going-to-attack range in UnitAI..
Fri, Jun 19, 6:46 PM
Freagarach added inline comments to D2824: Split vision range from going-to-attack range in UnitAI..
Fri, Jun 19, 1:55 PM
Freagarach added a comment to D1400: [gameplay] Hero aura revision.

The ticket states they were removed to save a lot of ad hoc work for translators prior to A20.

Fri, Jun 19, 1:45 PM
Freagarach added a comment to D1400: [gameplay] Hero aura revision.

The reasoning behind changes belongs in the differential discussions (i.e. here), which people can always retrieve via the svn revision history, therefore all information is preserved.

I think the point was not the loss of context to developers, but to the user. One of the goals of the game is to make people interested in history/"teach" them about it.
While I, to some extend, agree with tooltips being concise, I think the point of learning more about the past whilst playing is not to be ignored.

In D1400#120898, @Stan wrote:

It would nice to have the equivalent of history tags in identity in the details pane of auras, techs and whatever.

That would be ideal indeed. Casual players could take their time to read them while competitive players can quickly see what an aura does.

Fri, Jun 19, 12:49 PM
Freagarach updated the diff for D2824: Split vision range from going-to-attack range in UnitAI..

Small cleanup of comments.

Fri, Jun 19, 12:32 PM
Freagarach updated the summary of D2824: Split vision range from going-to-attack range in UnitAI..
Fri, Jun 19, 11:10 AM
Freagarach updated the summary of D2646: Remove special Animal state..
Fri, Jun 19, 11:05 AM
Freagarach updated the summary of D2824: Split vision range from going-to-attack range in UnitAI..
Fri, Jun 19, 11:01 AM
Freagarach added inline comments to D2646: Remove special Animal state..
Fri, Jun 19, 10:39 AM
Freagarach added inline comments to D2824: Split vision range from going-to-attack range in UnitAI..
Fri, Jun 19, 9:51 AM
Freagarach created D2824: Split vision range from going-to-attack range in UnitAI..
Fri, Jun 19, 9:44 AM

Thu, Jun 18

Freagarach planned changes to D2646: Remove special Animal state..
Thu, Jun 18, 4:18 PM
Freagarach updated the diff for D2646: Remove special Animal state..
  • Some comments.
  • Also change filter in BuildingAI.
Thu, Jun 18, 4:18 PM
Freagarach added inline comments to D2343: Combine "EntityCommand" and "AllyEntityCommand"..
Thu, Jun 18, 1:35 PM
Freagarach updated the diff for D2343: Combine "EntityCommand" and "AllyEntityCommand"..

Altered some comments.

Thu, Jun 18, 1:35 PM
Freagarach updated the diff for D2343: Combine "EntityCommand" and "AllyEntityCommand"..

And the xml.
(I should do more things in one update.)

Thu, Jun 18, 1:11 PM
Freagarach updated the diff for D2343: Combine "EntityCommand" and "AllyEntityCommand"..

Actally remove the deprecated AllyEntityCommand.

Thu, Jun 18, 1:08 PM
Freagarach updated the diff for D2343: Combine "EntityCommand" and "AllyEntityCommand"..

validPlayers.some(,,,)

Thu, Jun 18, 12:53 PM
Freagarach planned changes to D2646: Remove special Animal state..
  • Fix defensive animals (perhaps an extra stance?).
  • A tad more cleanup.
Thu, Jun 18, 9:40 AM
Freagarach added inline comments to D2646: Remove special Animal state..
Thu, Jun 18, 9:07 AM
Freagarach updated the diff for D2646: Remove special Animal state..

More elaborate.

  • Combined natural behaviour.
  • Deprecated IsAnimal() and IsDomestic().
Thu, Jun 18, 8:56 AM

Wed, Jun 17

Freagarach added inline comments to D2646: Remove special Animal state..
Wed, Jun 17, 5:44 PM

Tue, Jun 16

Freagarach planned changes to D2808: Allow resistance to StatusEffects..

Resistance in cmpResistance.

Tue, Jun 16, 7:22 PM
Freagarach planned changes to D2810: Don't process commands sent by observers..

Underlying problem ought to be fixed.

Tue, Jun 16, 7:19 PM
Freagarach added a comment to D2801: [gameplay] enable stable for all civilizations.

Top right: Edit Related Revisions...

Tue, Jun 16, 6:56 PM
Freagarach updated the diff for D1960: Move the controllability of an entity to cmpIdentity..

Check for controll all in GUI.

Tue, Jun 16, 6:04 PM
Freagarach updated the diff for D2367: Move the ability to hold a turret to a separate file..
  • Typo.
  • Remove unnecessary TurretHolder-queries in GarrisonHolder.js.
Tue, Jun 16, 5:11 PM

Mon, Jun 15

Freagarach added inline comments to D2367: Move the ability to hold a turret to a separate file..
Mon, Jun 15, 8:02 PM
Freagarach added a comment to D2367: Move the ability to hold a turret to a separate file..

Notice that renaming an turreted entity to an entity which is not allowed to garrison at all is broken, before and after this patch.

Mon, Jun 15, 7:51 PM
Freagarach updated the diff for D2367: Move the ability to hold a turret to a separate file..

Send message when turrets change and react upon that in BuildingAI.

Mon, Jun 15, 7:46 PM
Freagarach added inline comments to D1960: Move the controllability of an entity to cmpIdentity..
Mon, Jun 15, 5:11 PM
Freagarach added inline comments to D2426: Allow world population..
Mon, Jun 15, 1:16 PM
Freagarach updated the diff for D2426: Allow world population..

Early returns.

Mon, Jun 15, 1:16 PM
Freagarach planned changes to D1960: Move the controllability of an entity to cmpIdentity..
Mon, Jun 15, 8:50 AM
Freagarach updated the diff for D1960: Move the controllability of an entity to cmpIdentity..
  • Plural translation.
  • Also buildings may be uncontrollable.
  • Remove debug uncontrollability female citizens.
  • bool -> controllability.
Mon, Jun 15, 8:46 AM
Freagarach updated subscribers of D2814: Allow remapping hotkeys from inside the game / fix QWERTY hotkeys.

I know @elexis had a working version?

Mon, Jun 15, 8:15 AM
Freagarach added a comment to D2806: [gui] add extra row to right selection panel.

I recall Freagarach has a diff for tabs somewhere.

I don't think I managed to get further than a ticket (#5613) actually.

Mon, Jun 15, 8:06 AM
Freagarach added a comment to D2507: [gameplay] allow building palisades in neutral territory.

A quick and dirty method for health decay is easy. The hard part is probably implementing it the correct and most extensible way ^^ (I've been playing around with upkeep and when unable to pay that (Gaia doesn't pay): health decay.)

Mon, Jun 15, 8:02 AM

Fri, Jun 12

Freagarach added inline comments to D2810: Don't process commands sent by observers..
Fri, Jun 12, 12:42 PM
Freagarach added a comment to D2808: Allow resistance to StatusEffects..

Initially there was only Health, rP1302 seems to have introduced Armour.

Fri, Jun 12, 12:21 PM
Freagarach updated the summary of D1960: Move the controllability of an entity to cmpIdentity..
Fri, Jun 12, 11:26 AM
Freagarach added a comment to D1960: Move the controllability of an entity to cmpIdentity..

There are two types of not being able to respond to a particular command:

  • The *entity* can't "physically" do that, e.g. a champion gathering, which is checked in the g_UnitActions.
  • The *player* is not allowed to issue the order to that entity. In case of an observer, nothing happens, which is to be expected. In case of an uncontrollable entity the player may still think the entity is under their control so that is not expected.
Fri, Jun 12, 10:54 AM
Freagarach added a comment to D1960: Move the controllability of an entity to cmpIdentity..

No, since that is filtered ^^

Fri, Jun 12, 10:44 AM
Freagarach planned changes to D1960: Move the controllability of an entity to cmpIdentity..

Also the control all cheat doesn't work anymore.

Fri, Jun 12, 10:28 AM
Freagarach added a comment to D1960: Move the controllability of an entity to cmpIdentity..

But if you have a bunch of units of which one is not controllable, you won't see the cursor anyways?

Fri, Jun 12, 10:23 AM
Freagarach added inline comments to D1960: Move the controllability of an entity to cmpIdentity..
Fri, Jun 12, 10:18 AM
Freagarach updated the diff for D1960: Move the controllability of an entity to cmpIdentity..

Verify whether selection exists, while at at.

Fri, Jun 12, 10:18 AM
Freagarach updated the diff for D1960: Move the controllability of an entity to cmpIdentity..

Check only at necessary places to avoid double looping.

Fri, Jun 12, 9:52 AM
Freagarach added inline comments to rP23718: Fix Gaul trader offset. Refs Phab:D2640.
Fri, Jun 12, 9:14 AM
Freagarach created D2810: Don't process commands sent by observers..
Fri, Jun 12, 8:54 AM
Freagarach added inline comments to D1960: Move the controllability of an entity to cmpIdentity..
Fri, Jun 12, 8:47 AM