Page MenuHomeWildfire Games

Freagarach
User

Projects

User Details

User Since
Apr 5 2019, 7:29 PM (163 w, 5 d)

Recent Activity

Mon, May 23

Freagarach added a comment to D4661: Don't reset wonder victory timer on ally defeat. Do reseat when changing diplomacy..

To sum up how the rules would be intuitive for me:

Once you build a wonder the timer starts.
The timer counts/ is the same for every ally / everybody on the team.
The timer *only* gets reset if you (or you teammates) loose the (last) wonder due to it being destroyed or captured.
Whoever is on a team in the moment the timer is zero wins - everybody else looses

(/me agrees.)

Mon, May 23, 6:56 AM
Freagarach removed 1 auditor(s) for rP26898: [Gameplay] Let the mauryan worker elephant build again: chrstgtr.

@marder, please address D4249#198325. :) (Doesn't need a patch, merely a commit.)

Mon, May 23, 6:33 AM

Sun, May 22

Freagarach accepted D4249: [Gameplay] Let the mauryan working elephant build again.

Reads correct.
Works as intended.
Nice "feature".

Sun, May 22, 7:53 AM

Fri, May 20

Freagarach added a comment to D4645: Implement emergency mode [1/n].

This looks good, I will test later.

Fri, May 20, 6:54 PM
Freagarach committed rP26896: Fix aura tooltips on panel entities..
Fix aura tooltips on panel entities.
Fri, May 20, 12:00 PM
Freagarach closed D4648: Fix aura tooltips on panel entities..
Fri, May 20, 12:00 PM
Freagarach accepted D4659: rename Han Chinese -> Han.

Reads and greps correct.
Not renaming is the safest here.

Fri, May 20, 6:40 AM

Thu, May 19

Freagarach added a comment to D4657: [Gameplay] - Remove min distance from siege towers.

I guess they wanted to accept. :)
@marder can commandeer back?

Thu, May 19, 7:58 AM
Freagarach accepted D4658: Fix a comment and rename the formation angle function.

Reads correct.
Change is good.

Thu, May 19, 7:27 AM
Freagarach retitled D4657: [Gameplay] - Remove min distance from siege towers from remove min distance from siege towers to [Gameplay] - Remove min distance from siege towers.
Thu, May 19, 7:23 AM

Mon, May 16

Freagarach committed rP26885: Fix description of water weeding..
Fix description of water weeding.
Mon, May 16, 4:46 PM
Freagarach added inline comments to D4648: Fix aura tooltips on panel entities..
Mon, May 16, 7:27 AM
Freagarach requested review of D4648: Fix aura tooltips on panel entities..
Mon, May 16, 7:25 AM

Sun, May 15

Freagarach committed rP26878: Fix double 'to' in weeding technology..
Fix double 'to' in weeding technology.
Sun, May 15, 7:28 AM
Freagarach committed rP26877: Some fixes for the Han stone thrower..
Some fixes for the Han stone thrower.
Sun, May 15, 7:18 AM
Freagarach closed D4608: Han Chinese stone thrower.
Sun, May 15, 7:18 AM

Sat, May 14

Freagarach abandoned D3847: [WIP] - Implement conical-shaped area damage..
Sat, May 14, 10:13 AM
Freagarach abandoned D3879: [PetraAI] - Allow to get a current list of buildable structures..

Not useful for PetraAI.

Sat, May 14, 9:56 AM
Freagarach added inline comments to D4608: Han Chinese stone thrower.
Sat, May 14, 9:30 AM
Freagarach accepted D4608: Han Chinese stone thrower.

Reads correct.

Sat, May 14, 7:46 AM

Fri, May 13

Freagarach added a reviewer for D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill: Freagarach.
Fri, May 13, 7:49 AM
Freagarach added inline comments to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.
Fri, May 13, 6:59 AM

Thu, May 12

Freagarach added inline comments to D4645: Implement emergency mode [1/n].
Thu, May 12, 6:55 PM
Freagarach edited reviewers for D4645: Implement emergency mode [1/n], added: Freagarach; removed: Silier.

One thing, I think this lacks is recovering, we stay in the emergency state forever, even if we'd win.
Something like if we're back to ~75% of the previous population the emergency is lifted?

Thu, May 12, 2:08 PM
Freagarach added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

Maybe?

Thu, May 12, 7:48 AM
Freagarach added inline comments to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.
Thu, May 12, 6:44 AM

Wed, May 11

Freagarach added a comment to rP26867: Fix map errors from GetTemplate not being available in the sim.
[16:38:28] <elexis> try this
[16:38:28] <elexis> 1. revert 26867
[16:38:28] <elexis> 2. add an argument GetTemplate to loadCivFiles and replace Engine.GetTemplate by GetTemplate
[16:38:28] <elexis> 3. pass Engine.GetTemplate in all calls, except the one call in the simulation scripts (survival of the fittest triggers)
[16:38:33] <elexis> minus the question
[16:39:10] <elexis> 4. in survival of the fittest you pass Engine.QueryInterface(SYSTEM_ENTITY, IID_TemplateManager).GetTemplate
[16:40:09] <elexis> alternatively you could also delete the entire TemplateManager component
[16:41:05] <elexis> also notice that still means nonvisual autostart needs a TemplateLoader, so the better approach is actually using if (Engine.GetTemplate) around that const template = Engine.GetTemplate("special/players/" + data.Code);  block
[16:41:06] <Freagarach> Well, it validates templates.
[16:41:30] <elexis> Engine.GetTemplate doesnt?
[16:41:38] <Freagarach> Nay.
[16:42:01] <elexis> Gamesettings code doesnt use the civ data you inserted at all
[16:42:11] <elexis> from what I see survival of the fittest doesnt either
[16:42:26] <elexis> so these functions could just skip that Engine.GetTemplate call if Engine.GetTemplate isnt defined
[16:42:44] <elexis> also it seems that this data should not used by simulation or gamesettings (nonvisual) in any case
[16:43:20] <elexis> so thats a oneline JS fix instead of making a second template loader hidden inside a static local
[16:43:51] <elexis> and he is going to introduce another local static template loader for the nonvisual autostart patch that is not needed
[16:44:44] <elexis> so those are quick fixes, I dont know if its good to have that JS function combine the data of two files, or if it wouldnt be better to have it separated into nonvisual and visual data in two files.
[16:45:04] <elexis> (and loaded by two different calls)
[16:45:47] <elexis> (also dont know if it wouldnt be reasonable to just drop JSON at all instead of having XML here then sprinkling some JSON over there and switch back and forth all the time)
Wed, May 11, 4:52 PM
Freagarach committed rP26873: Allow setting the passability class depending on formation members..
Allow setting the passability class depending on formation members.
Wed, May 11, 4:48 PM
Freagarach closed D4605: Allow setting the passability class depending on formation members..
Wed, May 11, 4:47 PM
Freagarach accepted D4626: add parentheses overlooked in rP26520.

Reads correct.
Tests can be expanded (by testing _something_ between 0 and Math.PI) but are okay for now.

Wed, May 11, 4:32 PM
Freagarach added a comment to D4642: Add EGL support for Wayland.

X11 functions, including screenshots. :)

Wed, May 11, 9:23 AM
Freagarach committed rP26872: Fix maps after r26298 / rP26298..
Fix maps after r26298 / rP26298.
Wed, May 11, 8:04 AM
Freagarach closed D4486: Fix maps after rP26298..
Wed, May 11, 8:04 AM
Freagarach added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

@Stan Have any instructions for Linux?

git diff --no-prefix -U9999 according to The Internet.
Also, please set the repository correctly when manually uploading the patch. That way our linter can tell you part of our coding conventions. :)

Wed, May 11, 7:56 AM

Tue, May 10

Freagarach added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

First of all, thanks for working on this. :)

Tue, May 10, 8:19 AM
Freagarach added a member for Contributors: Mercury.
Tue, May 10, 7:48 AM
Freagarach updated the diff for D4626: add parentheses overlooked in rP26520.

(Sorry for spamming the diff. It was less work than expected.)

Tue, May 10, 7:18 AM
Freagarach added a comment to D4626: add parentheses overlooked in rP26520.

I'll try and rewrite the tests.

Tue, May 10, 7:13 AM
Freagarach updated the diff for D4626: add parentheses overlooked in rP26520.

Fix tests.

Tue, May 10, 7:06 AM
Freagarach updated the diff for D4486: Fix maps after rP26298..

JS only.

Tue, May 10, 6:35 AM
Freagarach updated the summary of D4486: Fix maps after rP26298..
Tue, May 10, 6:32 AM

Mon, May 9

Freagarach accepted D4629: Fix rP26801 - Only allwo changing passability of formation controllers..

With the inline and D4605, I get no OOS with the rejointest.
The patch reads correct from a functional view.

Mon, May 9, 7:25 AM
Freagarach added a comment to D4629: Fix rP26801 - Only allwo changing passability of formation controllers..

The pass class name _was_ serialised? And the reason it worked was probably because the pass class name didn't change ove the course of a match. ^^

Mon, May 9, 7:01 AM
Freagarach added a comment to D4486: Fix maps after rP26298..

The specific approach taken here doesn't strike me as bad, but I think C++ wise I'd prefer what I've done in D4630 with the component manager. It's less code & more maintainable IMO.

If you could fix/merge the convenience function please, then I can move that from this diff and go back to JS. ^^

Mon, May 9, 6:53 AM

Sun, May 8

Freagarach added inline comments to rP24953: Unify UnitAI and AnimalAI..
Sun, May 8, 8:45 AM
Freagarach added a comment to D4486: Fix maps after rP26298..
In D4486#197129, @Stan wrote:

Was the message used by the AI?

Nope. Do notice the message was already not sent anymore. I only remove the declaration and the listener in cmpTrainer.

Sun, May 8, 7:20 AM

Sat, May 7

Freagarach updated the diff for D4486: Fix maps after rP26298..

Purge obsolete message.

Sat, May 7, 9:12 AM
Freagarach added inline comments to rP25691: Map flares.
Sat, May 7, 7:58 AM
Freagarach planned changes to D4584: [WIP] - Technologies to templates..

See discussion on IRC yesterday.
https://irclogs.wildfiregames.com/%230ad-dev/2022-05-06-QuakeNet-%230ad-dev.log

Sat, May 7, 7:00 AM
Freagarach committed rP26855: Fix slow formation movement on spamclick by increasing instant turn angle to….
Fix slow formation movement on spamclick by increasing instant turn angle to…
Sat, May 7, 6:48 AM
Freagarach closed D4593: Fix slow formation movement on spamclick; increase instant turn angle.
Sat, May 7, 6:48 AM

Fri, May 6

Freagarach added inline comments to D4629: Fix rP26801 - Only allwo changing passability of formation controllers..
Fri, May 6, 4:55 PM
Freagarach accepted D4593: Fix slow formation movement on spamclick; increase instant turn angle.

Looks good (in more ways than one :) ).

Fri, May 6, 8:46 AM
Freagarach added inline comments to D4629: Fix rP26801 - Only allwo changing passability of formation controllers..
Fri, May 6, 7:46 AM
Freagarach added a comment to D4629: Fix rP26801 - Only allwo changing passability of formation controllers..

You'll need to update cmpUnitMotionFlying to also update the clearance in cmpObstruction.

Fri, May 6, 7:43 AM
Freagarach added a comment to D4593: Fix slow formation movement on spamclick; increase instant turn angle.

I would like to see the ITA of a unit as a first fix. Than we can later discuss/establish whether the value is necessary at all.

Fri, May 6, 7:34 AM
Freagarach abandoned D4595: Fix slow formation movement on spam-click..

No clue why, and D4593 seem okay.

Fri, May 6, 7:33 AM
Freagarach added a comment to D4626: add parentheses overlooked in rP26520.

This is your error:

ERROR: JavaScript error: simulation/components/Formation.js line 158
Engine.QueryInterface(...) is null
  Formation.prototype.Init@simulation/components/Formation.js:158:9
  global.ConstructComponent@simulation/components/tests/setup.js:112:6
  @simulation/components/tests/test_Formation.js:22:40
Fri, May 6, 7:30 AM

Mon, May 2

Freagarach added a comment to D4632: Revert rP26298, put civ historical data back in the JSON file..

#1 -> This leads to weird code, because:

  • Maps don't care about non-JSON data

I'm not sure what you mean here, but grep -irn maps/ -e 'gettemplate' results in quite some hits. ^^

  • GUI cares about JSON data and the 'Identity' part of the XML data, but only that part.

Also civ/team bonuses, available templates etc.?

  • Sim mostly doesn't care about JSON data.

Working to ensure that. ;P

Mon, May 2, 8:48 AM
Freagarach updated the diff for D4486: Fix maps after rP26298..

Back to non-generic solution.

Mon, May 2, 8:03 AM
Freagarach added a comment to D4626: add parentheses overlooked in rP26520.

But even without seeing the bug, I would say we should be able to conceptually agree that the function should have parenthesis as we want to get the modulo for a circle and not the modulo 2 times pi :)

Yeah, just curious to what the symptoms were. ^^

Mon, May 2, 6:31 AM

Sun, May 1

wowgetoffyourcellphone awarded D3811: [Gameplay] - Use subunits for the Ptol supersized ship. a Dat Boi token.
Sun, May 1, 7:54 AM
Freagarach added a comment to D4630: Fix map errors from GetTemplate not being available in the sim.

Basically back to https://code.wildfiregames.com/D4486?id=19699. ^^

Sun, May 1, 7:44 AM
Freagarach added inline comments to D4627: Fix crash in non-visual mode from not loading terrain textures.
Sun, May 1, 7:30 AM
Freagarach added a comment to D4626: add parentheses overlooked in rP26520.

What are the symptoms of this mistake?

Sun, May 1, 7:05 AM

Sat, Apr 30

Freagarach added inline comments to D4624: Add Mouse drag to options.
Sat, Apr 30, 8:06 AM
Freagarach added a comment to D4616: Remove user.cfg from javascript.
[07:41:45] <elexis> does that patch impact mods writing to custom config files? I dont know if that is currently well supported
Sat, Apr 30, 7:58 AM
Freagarach retitled D4625: [Gameplay] - buff for spear cavalry (attempt2) from buff for spear cavalry (attempt2) [balancing] to [Gameplay] - buff for spear cavalry (attempt2).
Sat, Apr 30, 7:25 AM · Balancing

Fri, Apr 29

Freagarach committed rP26840: Fix `-` in previous commit..
Fix `-` in previous commit.
Fri, Apr 29, 7:40 AM
Freagarach committed rP26839: Make scythes aura only affect humans (instead of units)..
Make scythes aura only affect humans (instead of units).
Fri, Apr 29, 7:39 AM
Freagarach closed D4619: [Gameplay] Scythes aura affecting unit.
Fri, Apr 29, 7:39 AM
Freagarach committed rP26838: Reduce fog on cisalpine winter map and artic biome..
Reduce fog on cisalpine winter map and artic biome.
Fri, Apr 29, 7:23 AM
Freagarach closed D4596: [maps] reduce fog on cisalpine winter map and artic biome.
Fri, Apr 29, 7:23 AM
Freagarach accepted D4616: Remove user.cfg from javascript.

Change is good.
Reads correct (apart from the inlines).
I haven't tested it.

Fri, Apr 29, 7:00 AM
Freagarach added a comment to D4621: Fix chat window.

Both, I guess?

Fri, Apr 29, 6:23 AM

Thu, Apr 28

Freagarach added a comment to D4620: Position of the ministry in the construction panel.

I guess a general order ought to be established?

Thu, Apr 28, 8:23 AM
Freagarach added a comment to D4615: Shift group hotkeys to map 1 - 10 instead 0 - 9.

Edit: To be clear, I'm not assigning malice to you, it could be a language difference or a cultural difference or just wanting to type something fast so you can start work on something else. But sometimes it is worth taking the extra time to make sure that the only "attack" is against oneself (you know for sure how you will react, you can never know how someone else will). Especially in open source, everyone is here by choice, not because it's their paycheck.

You probably don't even need to really change the way you communicate, people like me can just come in every now and then and clarify that no-one is acting with malice, we all love each-other.

<3

Thu, Apr 28, 7:41 AM

Apr 26 2022

Freagarach accepted D4619: [Gameplay] Scythes aura affecting unit.

^

Apr 26 2022, 6:31 AM
Freagarach added a comment to D4619: [Gameplay] Scythes aura affecting unit.

Good fix.

Apr 26 2022, 6:20 AM

Apr 25 2022

Freagarach added a comment to rP26382: Display defeated/won before victory..

Fixes #4949.

Apr 25 2022, 8:15 AM
Freagarach added a comment to D4615: Shift group hotkeys to map 1 - 10 instead 0 - 9.

But 0 != 10?
I know there are keyboards out there with more than 10 numbers, to be used specifically for control groups, how to handle one with a 10?

Apr 25 2022, 8:09 AM

Apr 24 2022

wowgetoffyourcellphone awarded D2372: [WIP] - Support for mining. a Dat Boi token.
Apr 24 2022, 9:22 PM

Apr 21 2022

Freagarach abandoned D4486: Fix maps after rP26298..

D4613

Apr 21 2022, 4:32 PM

Apr 20 2022

Freagarach added a comment to D4514: Add Requirements helper..
Wed Apr 13 2022
[17:00:53] <elexis> RequirementsHelper.prototype.ChoicesSchema -1 tab whitespace
[17:01:10] <elexis> "" could be string.Empty or so
[17:01:27] <elexis> also +1tab there
[17:01:34] <elexis> return "" + could be return \ I think
[17:02:33] <elexis> Object.keys(template).length object construction, would be good to avoid
[17:02:51] <Freagarach> There was something about string literals in schema, IIRC?
[17:03:31] <elexis> not that I know of, youre constructing a string there not more not less
[17:03:35] <elexis>   if (requirementType === "All" && !this.AllRequirementsMet(requirement, cmpTechManager))
[17:03:35] <elexis>    return false;
[17:03:35] <elexis>   if (requirementType === "Any" && !this.AnyRequirementsMet(requirement, cmpTechManager))
[17:03:35] <elexis>    return false;
[17:03:40] <elexis> can be combined using ||
[17:04:27] <elexis> (same performance as || and && use shortcircuiting)
[17:04:28] <Freagarach> I meant using ` for schema strings.
[17:04:36] <elexis> ah those, never used that
[17:05:20] <Freagarach> https://trac.wildfiregames.com/ticket/3825
Apr 20 2022, 6:17 PM
Freagarach added a comment to D4486: Fix maps after rP26298..
[17:56:35] <elexis> compartment mismatch is not a hard problem                                
[17:57:01] <elexis> it means that in C++ a JS object is allocated in one script context, but then used by another script context without having it cloned                                
[17:57:25] <elexis> so it might be possible to locate it by reading and some circumstancial evidence                                
[17:57:42] <elexis> you probably find someone who can build in debug mode                                
[17:58:20] <elexis> https://trac.wildfiregames.com/changeset/24116                                
[17:58:54] <elexis> https://trac.wildfiregames.com/changeset/15589                                
[17:59:13] <elexis> https://trac.wildfiregames.com/changeset/15561                                
[18:05:47] <elexis> also RegisterScriptFunctions_GUI, RegisterScriptFunctions_Simulation, RegisterScriptFunctions_Maps are identical, so can be deduplicated
Apr 20 2022, 6:13 PM
Freagarach added a comment to D4608: Han Chinese stone thrower.

@Freagarach Do I understand correctly that UnitMotion shall be removed ?

Nope, it should be kept, else one can't order a single mangonel to move, IIRC.

Apr 20 2022, 5:23 PM

Apr 19 2022

Freagarach added a comment to D4608: Han Chinese stone thrower.
The unpacked siege units still have UnitMotion, but a very small almost-zero speed, and UnitAI doesn't allow them to move without packing anyway.

Do note this is wrong. I've noticed a long time ago that when you attack siege set to passive, interesting things happen to see by those who wait.

Apr 19 2022, 7:31 AM
Freagarach added inline comments to D4605: Allow setting the passability class depending on formation members..
Apr 19 2022, 7:07 AM

Apr 17 2022

Freagarach requested review of D4605: Allow setting the passability class depending on formation members..
Apr 17 2022, 9:03 AM
Freagarach added a comment to D4604: Differentiate Trading Team Bonuses.

Is this the forum thread you meant? https://wildfiregames.com/forum/topic/75691-trader-bonuses-international-vs-landsea-traders/

Apr 17 2022, 8:55 AM
Freagarach accepted D4599: Allow setting the passability class dynamically..

Tested, functions.

Apr 17 2022, 8:42 AM
Freagarach updated the diff for D4584: [WIP] - Technologies to templates..

Saving some progress.

Apr 17 2022, 7:18 AM
Freagarach edited P267 Fix D4584..
Apr 17 2022, 7:16 AM

Apr 14 2022

Freagarach added a comment to D4603: LIB_URL zlib change.

I think this patch is bad because next time nobody will notice a upgrade of the library.

You mean because they won't get a 404? IIRC that is the case with most of our libs. Also, being able to specify the zlib version is right now kind of useless, as there is really merely one option (latest) with the current URL. The patch allows easy changing.

Apr 14 2022, 6:37 AM

Apr 12 2022

Freagarach added inline comments to D4486: Fix maps after rP26298..
Apr 12 2022, 7:59 AM

Apr 11 2022

Freagarach added inline comments to D4599: Allow setting the passability class dynamically..
Apr 11 2022, 7:22 AM
Freagarach added a comment to D4598: [WIP] [GUI] fancy endgame message.

Good that you also have the observer see this. We need to think about:

  • Teams obtaining victory/getting defeated.
  • Translations.
Apr 11 2022, 7:04 AM
Freagarach added a comment to D4486: Fix maps after rP26298..

I guess a review? Since this patch touches C++ and I am bad at that. ^^

Apr 11 2022, 6:19 AM

Apr 9 2022

Freagarach edited P267 Fix D4584..
Apr 9 2022, 9:35 AM
Freagarach committed rP26769: Fix progress slider on formerly autoqueued items..
Fix progress slider on formerly autoqueued items.
Apr 9 2022, 7:35 AM