Page MenuHomeWildfire Games

Freagarach
User

Projects

User Details

User Since
Apr 5 2019, 7:29 PM (168 w, 4 d)

Recent Activity

Yesterday

Freagarach updated the summary of D2374: Add support for allowing to garrison non-allied buildings..
Tue, Jun 28, 7:48 PM
Freagarach updated the diff for D2374: Add support for allowing to garrison non-allied buildings..

Rebased.

Tue, Jun 28, 7:48 PM
Freagarach updated the diff for D2270: Allow area damages to have a minimum range..

Rebased, fix linter.

Tue, Jun 28, 6:59 PM
Freagarach updated subscribers of rP23806: Fix formations reshaping incorrectly & related issues..
Tue, Jun 28, 5:44 PM
Freagarach added inline comments to D4727: Fix formation merging issue..
Tue, Jun 28, 8:12 AM
Freagarach updated the diff for D4727: Fix formation merging issue..

A more involved and correct fix.

Tue, Jun 28, 8:08 AM

Mon, Jun 27

Freagarach added a comment to D4727: Fix formation merging issue..

We're still in the twinFormations of other formations. The last part might need to be disband where we remove ourselves from the twinFormations of our twins.

Mon, Jun 27, 10:07 PM
Freagarach updated the diff for D4727: Fix formation merging issue..

Fix the symptom of adding members to a non-existing formation.
I'll need to investigate further what triggered this.

Mon, Jun 27, 10:02 PM

Sat, Jun 25

Freagarach added inline comments to D4727: Fix formation merging issue..
Sat, Jun 25, 7:48 AM
Freagarach requested review of D4727: Fix formation merging issue..
Sat, Jun 25, 7:28 AM

Thu, Jun 23

Freagarach updated the diff for D4679: [Gameplay] - Only have capturing entities contribute to the capture regenrate..

Linter.

Thu, Jun 23, 4:35 PM
Freagarach abandoned D2676: Move common functionality of Foundation and Repairable to Buildable..
Thu, Jun 23, 4:13 PM
Freagarach requested changes to D3740: delete several useless fauna templates.

^

Thu, Jun 23, 4:09 PM
Freagarach added a comment to rP26956: Make formations respond as one to threats..

Yeah, that was already the case before this patch.

Thu, Jun 23, 7:28 AM

Tue, Jun 21

Freagarach added inline comments to D4715: [balance] Han civil technologies adjustments.
Tue, Jun 21, 8:19 AM
Freagarach added a comment to D4714: [balance] Adjustments to Han art of war technology.

If someone else approves as well, I'll go ahead and accept it.

That is not how it works. xD If you agree with the patch, you may just accept it. :)

Tue, Jun 21, 8:17 AM

Sun, Jun 19

Freagarach committed rP26958: Fix Carths Naval Shipyard..
Fix Carths Naval Shipyard.
Sun, Jun 19, 8:39 AM
Freagarach closed D4695: Fix Naval Shipyard..
Sun, Jun 19, 8:39 AM
Freagarach committed rP26957: Fix phasing by cheat with Athens..
Fix phasing by cheat with Athens.
Sun, Jun 19, 8:35 AM
Freagarach closed D4694: Fix phasing by cheat with Athens..
Sun, Jun 19, 8:35 AM
Freagarach committed rP26956: Make formations respond as one to threats..
Make formations respond as one to threats.
Sun, Jun 19, 8:29 AM
Freagarach closed D4666: Make formations respond as one to threats..
Sun, Jun 19, 8:29 AM

Fri, Jun 17

Freagarach retitled D4666: Make formations respond as one to threats. from Make formations respond as one to threads. to Make formations respond as one to threats..
Fri, Jun 17, 7:19 PM
Freagarach updated subscribers of D4697: [Gameplay] Switch default behavior from capture to attack.

I think there is some usefulness in looking at @bb's D368.
It looks fine from a glance.

Fri, Jun 17, 7:17 PM

Mon, Jun 13

Freagarach added a comment to D4380: [Gameplay] - Garrison Domestic Animals into the Corral to get a <ResourceTrickle> of Food.

Also there is another problem with garrison space: When you go to the next phase, the GarrisonRegenRate increases and is no longer 0.

I guess we'll need D4679. ;P

Mon, Jun 13, 9:33 PM
Freagarach added a comment to D4666: Make formations respond as one to threats..
In D4666#199638, @Stan wrote:

Is it threads or threats?

Aye.

Mon, Jun 13, 9:25 PM

Sun, Jun 12

Freagarach commandeered D4666: Make formations respond as one to threats..
Sun, Jun 12, 4:10 PM
Freagarach updated the diff for D4666: Make formations respond as one to threats..

Shorted code. Removed stances part.

Sun, Jun 12, 4:08 PM
Freagarach added a comment to D4666: Make formations respond as one to threats..

The stances part seems a bit wonky, but the responding sounds like a good idea. @lyv, do you mind if I take over? (I can obviously state what I would like to see changed, but if you don't care about UnitAI, I figure you might not want to keep updating this.)

Sun, Jun 12, 2:36 PM
Freagarach accepted D4645: Implement emergency mode [1/n].

I've tested this a bit, PetraAI goes into emergency mode correctly and also resumes from it. Nomad is also functioning properly.
The code reads correct and this is a nice first step.
I'll commit it after FF has thawed.

Sun, Jun 12, 2:00 PM
Freagarach abandoned D2969: Fix gates reclosing upon garrison..
Sun, Jun 12, 1:08 PM
Freagarach abandoned D2704: Create function to distribute a message to several entities..
Sun, Jun 12, 1:07 PM
Freagarach added a comment to D4380: [Gameplay] - Garrison Domestic Animals into the Corral to get a <ResourceTrickle> of Food.

Looks like this has broad appeal. Anyone wish to Accept Revision?

@balancing?

Sun, Jun 12, 1:03 PM
Freagarach added a comment to D4679: [Gameplay] - Only have capturing entities contribute to the capture regenrate..

s/might/will
;)
We can experiment with this in the next alpha.

Sun, Jun 12, 12:40 PM
Freagarach requested review of D4695: Fix Naval Shipyard..
Sun, Jun 12, 8:54 AM
Freagarach requested review of D4694: Fix phasing by cheat with Athens..
Sun, Jun 12, 8:29 AM
Freagarach added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

I'll need to properly test, but will not commit it while we're in FF.

Sun, Jun 12, 7:00 AM
Freagarach committed rP26938: Revert r26931 / rP26931 after r26937 / rP26937..
Revert r26931 / rP26931 after r26937 / rP26937.
Sun, Jun 12, 6:54 AM

Fri, Jun 10

Freagarach added inline comments to rP26815: Moves vertex attribute binding to CDeviceCommandContext..
Fri, Jun 10, 7:26 AM
Freagarach added a comment to rP26931: Count rice as veggie..

Refs. https://trac.wildfiregames.com/ticket/6559

Fri, Jun 10, 7:01 AM
Freagarach committed rP26931: Count rice as veggie..
Count rice as veggie.
Fri, Jun 10, 6:53 AM
Freagarach added a reviewer for D4689: Cleanup CShaderParams::SItems comparisons: vladislavbelov.
Fri, Jun 10, 6:35 AM

Thu, Jun 9

Freagarach committed rP26928: Fix some text errors..
Fix some text errors.
Thu, Jun 9, 4:17 PM
Freagarach added a comment to D4690: [GUI] rename minimap idle worker -> idle citizens.

Or it should find idle workers instead of citizens?

Thu, Jun 9, 7:25 AM

Tue, Jun 7

Freagarach added inline comments to D4682: Profiler2 lives in main().
Tue, Jun 7, 4:07 PM

Sun, Jun 5

Freagarach added members for Contributors: Salesome, real_tabasco_sauce.
Sun, Jun 5, 7:42 AM
Freagarach edited reviewers for D4686: Capitalize place names, added: Nescio, Gallaecio; removed: Stan.

(I'll take a look myself later.)

Sun, Jun 5, 7:41 AM
Freagarach added a comment to D4679: [Gameplay] - Only have capturing entities contribute to the capture regenrate..

Yes. More concerning to me would be late game when roaming cav could slip into a base and capture a CC fairly quickly before a player could return his army to the CC. Perhaps the values could be adjusted to make it work but that seems tricky and subject to error where we accidentally set it too high or too low

That sounds like good play then? And reckless play from the defender? There are walls to fend off these kind of raids?

Sun, Jun 5, 7:21 AM

Fri, Jun 3

Freagarach added inline comments to D4681: Fix shadow artifacts without shadow filtering in some A25 biomes/maps.
Fri, Jun 3, 11:06 AM
Freagarach updated the diff for D4679: [Gameplay] - Only have capturing entities contribute to the capture regenrate..

Fix test, checked data folder.

Fri, Jun 3, 7:47 AM

Thu, Jun 2

Freagarach requested review of D4679: [Gameplay] - Only have capturing entities contribute to the capture regenrate..
Thu, Jun 2, 7:17 PM
Freagarach added a comment to D4674: [Gameplay A26] - Make Hyrcanian cavalry useful.

If you don't do promotion anymore, you could also just ditch the basic and advanced variants?

Thu, Jun 2, 6:50 AM · Balancing

Wed, Jun 1

Freagarach added inline comments to D4674: [Gameplay A26] - Make Hyrcanian cavalry useful.
Wed, Jun 1, 6:24 PM · Balancing

Tue, May 31

Freagarach added a comment to D4674: [Gameplay A26] - Make Hyrcanian cavalry useful.

You can try -cavalry_axeman_b?

Tue, May 31, 7:21 PM · Balancing
Freagarach added a comment to D4672: Make the 'reset wonder timer on diplomacy change' thing a setting..

IIRC Empire Earth 2 has an "advanced" settings checkbox.

Tue, May 31, 6:44 PM
Freagarach accepted D4661: Don't reset wonder victory timer on ally defeat..

Good for now.

Tue, May 31, 6:42 PM
Freagarach added inline comments to D4670: Move rmgen2's getTeamsArray function to rmgen1.
Tue, May 31, 6:40 PM
nwtour awarded rP26913: Fix maps with conquest CC victory conditions. a Like token.
Tue, May 31, 4:27 PM
Freagarach committed rP26913: Fix maps with conquest CC victory conditions..
Fix maps with conquest CC victory conditions.
Tue, May 31, 12:03 PM

Mon, May 30

Freagarach added inline comments to D4670: Move rmgen2's getTeamsArray function to rmgen1.
Mon, May 30, 6:04 PM
Freagarach added a comment to D4303: Copy TeamPlacement options from Frontier.

Instead of creating multiple arc's one could just create one circle with 16 points, then calculate how many points are not assigned to a player, divide that by the number of gaps and then just assign the slots to the different teams and always keeping the calculated distance of slots in between them.

Be aware that we want to support more players than eight in the future. :)

Mon, May 30, 4:36 PM

May 30 2022

Freagarach added a reviewer for D4666: Make formations respond as one to threats.: Freagarach.
May 30 2022, 9:08 AM
Freagarach added a member for Contributors: thehiggsfield.
May 30 2022, 9:08 AM

May 23 2022

Freagarach added a comment to D4661: Don't reset wonder victory timer on ally defeat..

To sum up how the rules would be intuitive for me:

Once you build a wonder the timer starts.
The timer counts/ is the same for every ally / everybody on the team.
The timer *only* gets reset if you (or you teammates) loose the (last) wonder due to it being destroyed or captured.
Whoever is on a team in the moment the timer is zero wins - everybody else looses

(/me agrees.)

May 23 2022, 6:56 AM
Freagarach removed 1 auditor(s) for rP26898: [Gameplay] Let the mauryan worker elephant build again: chrstgtr.

@marder, please address D4249#198325. :) (Doesn't need a patch, merely a commit.)

May 23 2022, 6:33 AM

May 22 2022

Freagarach accepted D4249: [Gameplay] Let the mauryan working elephant build again.

Reads correct.
Works as intended.
Nice "feature".

May 22 2022, 7:53 AM

May 20 2022

Freagarach added a comment to D4645: Implement emergency mode [1/n].

This looks good, I will test later.

May 20 2022, 6:54 PM
Freagarach committed rP26896: Fix aura tooltips on panel entities..
Fix aura tooltips on panel entities.
May 20 2022, 12:00 PM
Freagarach closed D4648: Fix aura tooltips on panel entities..
May 20 2022, 12:00 PM
Freagarach accepted D4659: rename Han Chinese -> Han.

Reads and greps correct.
Not renaming is the safest here.

May 20 2022, 6:40 AM

May 19 2022

Freagarach added a comment to D4657: [Gameplay] - Remove min distance from siege towers.

I guess they wanted to accept. :)
@marder can commandeer back?

May 19 2022, 7:58 AM
Freagarach accepted D4658: Fix a comment and rename the formation angle function.

Reads correct.
Change is good.

May 19 2022, 7:27 AM
Freagarach retitled D4657: [Gameplay] - Remove min distance from siege towers from remove min distance from siege towers to [Gameplay] - Remove min distance from siege towers.
May 19 2022, 7:23 AM

May 16 2022

Freagarach committed rP26885: Fix description of water weeding..
Fix description of water weeding.
May 16 2022, 4:46 PM
Freagarach added inline comments to D4648: Fix aura tooltips on panel entities..
May 16 2022, 7:27 AM
Freagarach requested review of D4648: Fix aura tooltips on panel entities..
May 16 2022, 7:25 AM

May 15 2022

Freagarach committed rP26878: Fix double 'to' in weeding technology..
Fix double 'to' in weeding technology.
May 15 2022, 7:28 AM
Freagarach committed rP26877: Some fixes for the Han stone thrower..
Some fixes for the Han stone thrower.
May 15 2022, 7:18 AM
Freagarach closed D4608: Han Chinese stone thrower.
May 15 2022, 7:18 AM

May 14 2022

Freagarach abandoned D3847: [WIP] - Implement conical-shaped area damage..
May 14 2022, 10:13 AM
Freagarach abandoned D3879: [PetraAI] - Allow to get a current list of buildable structures..

Not useful for PetraAI.

May 14 2022, 9:56 AM
Freagarach added inline comments to D4608: Han Chinese stone thrower.
May 14 2022, 9:30 AM
Freagarach accepted D4608: Han Chinese stone thrower.

Reads correct.

May 14 2022, 7:46 AM

May 13 2022

Freagarach added a reviewer for D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill: Freagarach.
May 13 2022, 7:49 AM
Freagarach added inline comments to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.
May 13 2022, 6:59 AM

May 12 2022

Freagarach added inline comments to D4645: Implement emergency mode [1/n].
May 12 2022, 6:55 PM
Freagarach edited reviewers for D4645: Implement emergency mode [1/n], added: Freagarach; removed: Silier.

One thing, I think this lacks is recovering, we stay in the emergency state forever, even if we'd win.
Something like if we're back to ~75% of the previous population the emergency is lifted?

May 12 2022, 2:08 PM
Freagarach added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

Maybe?

May 12 2022, 7:48 AM
Freagarach added inline comments to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.
May 12 2022, 6:44 AM

May 11 2022

Freagarach added a comment to rP26867: Fix map errors from GetTemplate not being available in the sim.
[16:38:28] <elexis> try this
[16:38:28] <elexis> 1. revert 26867
[16:38:28] <elexis> 2. add an argument GetTemplate to loadCivFiles and replace Engine.GetTemplate by GetTemplate
[16:38:28] <elexis> 3. pass Engine.GetTemplate in all calls, except the one call in the simulation scripts (survival of the fittest triggers)
[16:38:33] <elexis> minus the question
[16:39:10] <elexis> 4. in survival of the fittest you pass Engine.QueryInterface(SYSTEM_ENTITY, IID_TemplateManager).GetTemplate
[16:40:09] <elexis> alternatively you could also delete the entire TemplateManager component
[16:41:05] <elexis> also notice that still means nonvisual autostart needs a TemplateLoader, so the better approach is actually using if (Engine.GetTemplate) around that const template = Engine.GetTemplate("special/players/" + data.Code);  block
[16:41:06] <Freagarach> Well, it validates templates.
[16:41:30] <elexis> Engine.GetTemplate doesnt?
[16:41:38] <Freagarach> Nay.
[16:42:01] <elexis> Gamesettings code doesnt use the civ data you inserted at all
[16:42:11] <elexis> from what I see survival of the fittest doesnt either
[16:42:26] <elexis> so these functions could just skip that Engine.GetTemplate call if Engine.GetTemplate isnt defined
[16:42:44] <elexis> also it seems that this data should not used by simulation or gamesettings (nonvisual) in any case
[16:43:20] <elexis> so thats a oneline JS fix instead of making a second template loader hidden inside a static local
[16:43:51] <elexis> and he is going to introduce another local static template loader for the nonvisual autostart patch that is not needed
[16:44:44] <elexis> so those are quick fixes, I dont know if its good to have that JS function combine the data of two files, or if it wouldnt be better to have it separated into nonvisual and visual data in two files.
[16:45:04] <elexis> (and loaded by two different calls)
[16:45:47] <elexis> (also dont know if it wouldnt be reasonable to just drop JSON at all instead of having XML here then sprinkling some JSON over there and switch back and forth all the time)
May 11 2022, 4:52 PM
Freagarach committed rP26873: Allow setting the passability class depending on formation members..
Allow setting the passability class depending on formation members.
May 11 2022, 4:48 PM
Freagarach closed D4605: Allow setting the passability class depending on formation members..
May 11 2022, 4:47 PM
Freagarach accepted D4626: add parentheses overlooked in rP26520.

Reads correct.
Tests can be expanded (by testing _something_ between 0 and Math.PI) but are okay for now.

May 11 2022, 4:32 PM
Freagarach added a comment to D4642: Add EGL support for Wayland.

X11 functions, including screenshots. :)

May 11 2022, 9:23 AM
Freagarach committed rP26872: Fix maps after r26298 / rP26298..
Fix maps after r26298 / rP26298.
May 11 2022, 8:04 AM
Freagarach closed D4486: Fix maps after rP26298..
May 11 2022, 8:04 AM
Freagarach added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

@Stan Have any instructions for Linux?

git diff --no-prefix -U9999 according to The Internet.
Also, please set the repository correctly when manually uploading the patch. That way our linter can tell you part of our coding conventions. :)

May 11 2022, 7:56 AM

May 10 2022

Freagarach added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

First of all, thanks for working on this. :)

May 10 2022, 8:19 AM
Freagarach added a member for Contributors: Mercury.
May 10 2022, 7:48 AM
Freagarach updated the diff for D4626: add parentheses overlooked in rP26520.

(Sorry for spamming the diff. It was less work than expected.)

May 10 2022, 7:18 AM