Page MenuHomeWildfire Games

Freagarach
User

Projects

User Details

User Since
Apr 5 2019, 7:29 PM (51 w, 1 d)

Recent Activity

Today

Freagarach commandeered D880: Ballistics..
Sat, Mar 28, 5:28 PM
Freagarach updated the diff for D880: Ballistics..

Different approach.

Sat, Mar 28, 5:28 PM
Freagarach added a comment to D2676: Move common functionality of Foundation and Repairable to Buildable..

(I still think constructing a building should not necessarily be tied to Health.)

Sat, Mar 28, 4:03 PM
Freagarach added inline comments to rP18467: Allow entities to upgrade into other entities..
Sat, Mar 28, 8:13 AM

Yesterday

Freagarach added a comment to D2679: Remove unnecessary argument of Pack-timer..

Thanks for the commit @Angen :)

Fri, Mar 27, 9:02 PM
Freagarach added inline comments to D2680: Heal using Heal.js instead of UnitAI..
Fri, Mar 27, 5:29 PM
Freagarach updated the diff for D2680: Heal using Heal.js instead of UnitAI..

Also include range-check in cmpHeal.

Fri, Mar 27, 5:27 PM
Freagarach added a comment to D2682: [gameplay] unify hero health.

Ideally heroes ought to be roughly equivalent.

I disagree here, heroes should be different, a "man-of-glass" hero which boosts some non-combat stuff should have way different stats than a tanky Leo, for example.
The player should have to carefully choose what hero fits their strategy, not just pick one randomly because it won't matter much anyway.

Fri, Mar 27, 3:47 PM
Freagarach accepted D2677: selection groups for support units.

Great! I guess the rank changes can be split from this, although they are also compleat and correct.

Fri, Mar 27, 3:39 PM
Freagarach added a comment to D2660: [gameplay] standardize wonder healing.

Isn't the idea of a wonder that it heals extremely quick (as the former tooltips describe)? Thus a rate of 8 would seem more appropriate?

Fri, Mar 27, 2:57 PM
Freagarach added a comment to D2511: [gameplay] give worker elephants an aura instead.

@Feldfeld if you agree, you may accept the patch :)

Fri, Mar 27, 2:50 PM
Freagarach removed a reviewer for D2496: tweak citizen cavalry and elephant footprints: Restricted Owners Package.

True that.

Fri, Mar 27, 2:41 PM
Freagarach added a comment to D2496: tweak citizen cavalry and elephant footprints.

It will do, albeit only slightly.

Fri, Mar 27, 2:35 PM
Freagarach added a comment to D2685: simplify mercenary cost.

Ah yes, I see it corrects for it ^^ (Templates.js globalscript L148.)

Fri, Mar 27, 2:33 PM
Freagarach added a reviewer for D2496: tweak citizen cavalry and elephant footprints: Restricted Owners Package.
Fri, Mar 27, 2:23 PM
Freagarach added a comment to D2685: simplify mercenary cost.

Is that in-game or at the structure tree from the main menu?

Fri, Mar 27, 2:22 PM
Freagarach added a reviewer for D2628: [gameplay] tweak champion infantry javelinist walk speed: Restricted Owners Package.
Fri, Mar 27, 2:19 PM
Freagarach added inline comments to D2684: [gameplay] make rams less effective vs units.
Fri, Mar 27, 2:18 PM
Freagarach added a comment to D2532: [gameplay] train champion cavalry at stable.

@ValihrAnt please accept if you (still) agree and have verified this patch :)

Fri, Mar 27, 1:41 PM
Freagarach updated the test plan for D2662: Gather using ResourceGatherer instead of UnitAI..
Fri, Mar 27, 9:42 AM
Freagarach updated the diff for D2662: Gather using ResourceGatherer instead of UnitAI..

Send the stopped message only after invalidating the target.

Fri, Mar 27, 9:32 AM
Freagarach updated the summary of D2679: Remove unnecessary argument of Pack-timer..
Fri, Mar 27, 8:20 AM
Freagarach updated the diff for D2680: Heal using Heal.js instead of UnitAI..
  • Add test for stopping.
  • Use proper prepare time when starting to heal.
Fri, Mar 27, 7:59 AM

Thu, Mar 26

Freagarach updated the diff for D2679: Remove unnecessary argument of Pack-timer..

Also remove duplicate/depraced "pack" in SetAnimation.
Missed in rP21359.

Thu, Mar 26, 10:36 PM
Freagarach updated the summary of D2680: Heal using Heal.js instead of UnitAI..
Thu, Mar 26, 10:35 PM
Freagarach created D2680: Heal using Heal.js instead of UnitAI..
Thu, Mar 26, 10:28 PM
Freagarach updated the summary of D2679: Remove unnecessary argument of Pack-timer..
Thu, Mar 26, 8:27 PM
Freagarach created D2679: Remove unnecessary argument of Pack-timer..
Thu, Mar 26, 8:09 PM
Freagarach added a comment to D2676: Move common functionality of Foundation and Repairable to Buildable..

I'm not sure how (and if) this inheritance is properly used in the test.
Help is appreciated!

Thu, Mar 26, 6:55 PM
Freagarach created D2676: Move common functionality of Foundation and Repairable to Buildable..
Thu, Mar 26, 6:01 PM
Freagarach updated the diff for D2662: Gather using ResourceGatherer instead of UnitAI..
  • Linter issues.
  • Handle message in default.
  • Store target as INVALID_ENTITY when unused.
Thu, Mar 26, 12:12 PM
Freagarach updated the diff for D2670: Add simple test for XP trickle (rP23541)..

Please linter.

Thu, Mar 26, 9:08 AM
Freagarach updated the diff for D2670: Add simple test for XP trickle (rP23541)..

Also test promotion itself.

Thu, Mar 26, 8:37 AM

Wed, Mar 25

Freagarach created D2670: Add simple test for XP trickle (rP23541)..
Wed, Mar 25, 8:35 PM
Freagarach updated the diff for D2188: Allow Promotion to add arbitrary modifiers when a unit reaches the next rank instead of changing entities..

Fix test.

Wed, Mar 25, 2:39 PM
Freagarach added a comment to rP21630: Fix UnitAI behaviour inconsistent with its stance for packed units and set….

Refs rP23298. But not enough fixed for a resign, I guess?

Wed, Mar 25, 8:39 AM
Freagarach added a comment to rP20393: Move out of world promoted, packed and upgraded entity as they are not….

For the record, not only fleeing is affected, every movement update which bails on msg.likelyFailure.

Wed, Mar 25, 8:29 AM
Freagarach accepted rP13541: Display current/max gatherers or builders when a resource or foundation is….

A tad late, but my concern was fixed by rP23449.

Wed, Mar 25, 8:01 AM
Freagarach awarded D2667: Upgrade engine to handle up to 30 players a Yellow Medal token.
Wed, Mar 25, 7:15 AM

Tue, Mar 24

Freagarach added inline comments to D2666: Allow to update repeat time of running timer..
Tue, Mar 24, 9:12 PM
Freagarach updated the diff for D2666: Allow to update repeat time of running timer..

Check for timer existence.

Tue, Mar 24, 8:29 PM
Freagarach created D2666: Allow to update repeat time of running timer..
Tue, Mar 24, 8:24 PM
Freagarach updated the summary of D2662: Gather using ResourceGatherer instead of UnitAI..
Tue, Mar 24, 8:23 PM
Freagarach added a reviewer for D1639: Rmgen new type constraint DensityConstraint: Restricted Owners Package.
Tue, Mar 24, 7:15 PM
Freagarach added a reviewer for D1624: Smoothing Wild Lake: Restricted Owners Package.
Tue, Mar 24, 7:00 PM
Freagarach abandoned D1606: Escape the backslash within the in-game manual.

Fixed in rP22904.

Tue, Mar 24, 6:54 PM
Freagarach updated the diff for D2270: Allow area damages to have a minimum range..
  • Rebased.
  • Remove unnecessary spaces in JSDoc in Attacking.js.
Tue, Mar 24, 4:49 PM
Freagarach added inline comments to D1958: Turrets and/or sub-units..
Tue, Mar 24, 4:14 PM
Freagarach updated the diff for D1958: Turrets and/or sub-units..
  • CanAnySubUnitPerform.
  • Added @param.
  • Check for order length.
  • Reset speed when have been chasing.
Tue, Mar 24, 4:14 PM
Freagarach updated the diff for D2426: Allow world population..

Update possible values.

Tue, Mar 24, 3:49 PM
Freagarach updated the diff for D1718: Decay/regenerate option for resources..
  • Strings in test.
  • int -> number.
  • Use indexOf directly instead of splitting first.
Tue, Mar 24, 3:15 PM
Freagarach updated the diff for D2661: Get attack effects from JSON..

Use strings in test.

Tue, Mar 24, 2:46 PM
Freagarach created D2665: Explicitly return "undefined" when requesting Splash data in Attack.js..
Tue, Mar 24, 2:41 PM
Freagarach added a comment to D2664: Commit resources at a target rather than per type..

A test can be added (after D2662).

Tue, Mar 24, 10:55 AM
Freagarach created D2664: Commit resources at a target rather than per type..
Tue, Mar 24, 10:55 AM
Freagarach added inline comments to D2308: Extend the visible garrisoning schema to allow specific units on specific turrets..
Tue, Mar 24, 9:12 AM
Freagarach updated subscribers of D2540: Make rallypoints moddable..

Regarding boost: https://code.wildfiregames.com/D1955?id=9184#inline-42118.
But I've got no clue about the reasoning ;) @elexis?

Tue, Mar 24, 8:54 AM
Freagarach updated the diff for D2662: Gather using ResourceGatherer instead of UnitAI..

Remove redundant variables in UnitAI.

Tue, Mar 24, 8:22 AM

Mon, Mar 23

Freagarach added inline comments to D2517: React to target death properly when chasing.
Mon, Mar 23, 5:57 PM
Freagarach added inline comments to D2015: Add formation CheckTarget-/MoveToTargetRange-functions..
Mon, Mar 23, 4:53 PM
Freagarach updated the diff for D2015: Add formation CheckTarget-/MoveToTargetRange-functions..

Removed unnecessary timer.

Mon, Mar 23, 4:50 PM
Freagarach added inline comments to D2662: Gather using ResourceGatherer instead of UnitAI..
Mon, Mar 23, 2:47 PM
Freagarach created D2662: Gather using ResourceGatherer instead of UnitAI..
Mon, Mar 23, 2:19 PM
Freagarach added inline comments to D2464: Create a C++ interface for cmpAttack.
Mon, Mar 23, 7:04 AM

Sun, Mar 22

Freagarach updated the Trac tickets for D2464: Create a C++ interface for cmpAttack.
Sun, Mar 22, 7:54 PM
Freagarach added a comment to D1776: Cleanup Timer.js and update documentation.
  • Reusing the function is good.
  • Polishing documentation is nice.
  • No further improvements possible, AFAICS.
Sun, Mar 22, 7:13 PM
Freagarach added inline comments to D1776: Cleanup Timer.js and update documentation.
Sun, Mar 22, 5:23 PM
Freagarach added a comment to D2661: Get attack effects from JSON..

Too bad one still needs to modify Attacking.js in two places to be able to use a new effect,,,

Sun, Mar 22, 2:03 PM
Freagarach created D2661: Get attack effects from JSON..
Sun, Mar 22, 1:41 PM

Sat, Mar 21

Freagarach added a comment to D2104: Unify usage of mouse buttons for preselected action and hotkey modifications.

This is indeed more consistent, but *I* would rather use LEFT for the modified actione. What button is used I do not care though, since it is user preference.
Perhaps it could be set as a user preference?

Sat, Mar 21, 6:44 PM
Freagarach created D2658: Allow entities to autoproduce..
Sat, Mar 21, 5:50 PM
Freagarach accepted D2517: React to target death properly when chasing.
In D2517#111843, @Angen wrote:

If you mean a32b (or before this diff), the goal here is to mimic combat.approach not leaking information behaviour. So if player says unit to attack target, attacker will end roughly at the spot of the target even target dies.

Okay :)

Sat, Mar 21, 5:25 PM
Freagarach added inline comments to D2657: Allow modders to let buildings spawn buildings..
Sat, Mar 21, 5:02 PM
Freagarach created D2657: Allow modders to let buildings spawn buildings..
Sat, Mar 21, 4:34 PM

Fri, Mar 20

Freagarach added a comment to D2652: Do not allow upgrading when entity is producing and vice versa..

Should we disable the button when it cannot be used?

Fri, Mar 20, 4:00 PM
Freagarach added inline comments to D1718: Decay/regenerate option for resources..
Fri, Mar 20, 3:10 PM
Freagarach updated the diff for D1718: Decay/regenerate option for resources..
  • Remove warns.
  • Fix linter.
Fri, Mar 20, 2:16 PM
Freagarach updated the diff for D1718: Decay/regenerate option for resources..

Fix test, thanks @Stan!

Fri, Mar 20, 1:37 PM
Freagarach added inline comments to D1718: Decay/regenerate option for resources..
Fri, Mar 20, 11:55 AM
Freagarach updated the diff for D1718: Decay/regenerate option for resources..

Added corral aura.

Fri, Mar 20, 9:39 AM
Freagarach commandeered D1718: Decay/regenerate option for resources..

Thanks for the hard work already done @Stan :D

Fri, Mar 20, 9:10 AM
Freagarach updated the diff for D1718: Decay/regenerate option for resources..

Some different approach.
Test fails for now for some unknown reason. Perhaps @elexis can shed their light on that? (Hence the warnings still in place.)

Fri, Mar 20, 9:09 AM

Wed, Mar 18

Freagarach abandoned D2562: Fix maps with Garrisoned entities (Sicilia Nomad) following rP22991/D2197 and rP16270.

Clone is done in rP23529.

Wed, Mar 18, 12:26 PM
Freagarach updated the diff for D2656: Cleanup of create corpse in Health.js..

Fix test.

Wed, Mar 18, 9:58 AM
Freagarach created D2656: Cleanup of create corpse in Health.js..
Wed, Mar 18, 9:51 AM

Tue, Mar 17

Freagarach added inline comments to rP22081: Rome Testudo & Anti-Cavalry formations animations:.
Tue, Mar 17, 9:29 PM
Freagarach updated the diff for D1971: Support attack-ground for ranged units..
  • Rebased.
  • Some inlines.
Tue, Mar 17, 8:23 PM
Freagarach added inline comments to D2654: Allow free Upgrades and/or Technologies..
Tue, Mar 17, 7:21 PM
Freagarach updated the diff for D2654: Allow free Upgrades and/or Technologies..

Also include techs.

Tue, Mar 17, 7:14 PM
Freagarach added inline comments to D2337: Internationalise Damage Types and Status Effects using (optional) JSON files..
Tue, Mar 17, 3:34 PM
Freagarach planned changes to D2654: Allow free Upgrades and/or Technologies..

Meh,,,
Needs to be elaborated.

Tue, Mar 17, 2:59 PM
Freagarach created D2654: Allow free Upgrades and/or Technologies..
Tue, Mar 17, 2:51 PM
Freagarach commandeered D2337: Internationalise Damage Types and Status Effects using (optional) JSON files..
Tue, Mar 17, 2:45 PM
Freagarach updated the diff for D2337: Internationalise Damage Types and Status Effects using (optional) JSON files..
  • Rebased.
  • Some other changes.
Tue, Mar 17, 2:44 PM
Freagarach updated the diff for D1958: Turrets and/or sub-units..
  • Bump CCmpPos.-year.
  • Correct comment in MapReader.cpp.
  • return false in FOLLOWING.enter.
Tue, Mar 17, 11:18 AM
Freagarach added inline comments to D1958: Turrets and/or sub-units..
Tue, Mar 17, 10:40 AM
Freagarach added inline comments to D1958: Turrets and/or sub-units..
Tue, Mar 17, 10:24 AM
Freagarach updated the diff for D1958: Turrets and/or sub-units..
  • Rebased.
  • Fix the crash on initGarriosn.
Tue, Mar 17, 10:18 AM
Freagarach added a comment to D1957: Basic implementation of extended restricted bartering support..

Sorry for removing them then.
IMHO An entry on a review list is like a question: "Would you like to review this, please?" But since that is not the case here I reckoned it is not fair to add them. My mistake then.

Tue, Mar 17, 9:26 AM
Freagarach added a comment to D2517: React to target death properly when chasing.

Looking good :)

  • Tasking a unit to chase a unit which later dies lets the former keep running to the last known position.
  • Otherwise no strange/different behaviour is observed.

Just one notion, perhaps/probably out of scope for this patch. When a unit chases another on its own and the target dies the former will stop in its tracks.

Tue, Mar 17, 8:27 AM