- User Since
- Apr 5 2019, 7:29 PM (181 w, 3 d)
Thu, Sep 8
@Mister if you have still time for this patch there are a few things left:
- We'd like a unit test (like the one I edited) for the new behaviour. (Basically a copy-pasta from one of the tests, but ensure that the entity to repair/construct is not in the cmpBuilder.Entities list.)
- Our GUI needs some change, you probably need to take a look at unit_actions.js (https://code.wildfiregames.com/source/0ad/browse/ps/trunk/binaries/data/mods/public/gui/session/unit_actions.js) and especially in the function around L437 (https://code.wildfiregames.com/source/0ad/browse/ps/trunk/binaries/data/mods/public/gui/session/unit_actions.js$437-448).
Fix tests (from Diff 20734).
One could consider making Petra a bit more chatty in debug mode. I.e. add some debug chat about trying to upgrade.
Fri, Sep 2
I guess I'll wait then. ^^
Aug 27 2022
Please also check playing coop, i.e. two machines controlling one player. :) By reading it looks like it'll work fine.
Aug 24 2022
Aug 21 2022
I fully agree. :)
A random thought: Does this mean trees lose health when hit by stray arrows?
We might first want to design what we want it to look like?
For experienced players this isn't useful, but I wonder about new players, altough I cannot remember using this ever.
Aug 11 2022
Aug 10 2022
Aug 8 2022
I'd say yes.
Aug 5 2022
@wowgetoffyourcellphone do you have the time to commit this?
Aug 4 2022
Fix the indent, add it only to structures doing actual research (fixes the checkrefs) and ship it, I'd say. A globalscript fix would be much more correct, but also way more work with added chances of breakage.
The problem would be PetraAI, I guess. She will slaughter the animals before fattening, which would make her significantly worse.
A bit more explanation seems in place.
You use now the template of the foundation (foundation|<sometemplatename>). However, Foundation.js has a property called finalTemplateName, which is the truth about what the foundation will become when finished. E.g. foundation|<sometemplatename> may become foundation|<someothertemplatename> when finished.
As such, when cmpFoundation is present, it ought to be used. Else one can use the current template name (no need for the includes then).
I thought of this just yesterday. ^^' I guess I'm too busy to think clearly.
Thanks for the patch!
Aug 2 2022
I guess an aura is (currently) suboptimal, as the animals may wander outside of the aura.
Jul 30 2022
Jul 29 2022
Jul 26 2022
This is how we say a patch is WIP. :) (By prefixing the title.)
Regarding the "cannot repair structures not known", it means that once captured a barracks of the enemy, we cannot repair it. Be aware of that. :) (One can check around that, using the hint provided inline.)
It is nice that we have some larger steps at the end.
Well, the one committing this needs to be absolutely sure this is an inteded side effect:
Notice formations will (...) not [reform] after their members starts to do orders by themselves.
Don't hold something back on my account, I'm merely saying something that seems logical to me. :) I haven't actually tried any order so am not qualified to speak over what I like more. ;)
I'll write you some tests when I have some more time on my hands. Feel free to do it yourself though.
Jul 21 2022
Jul 20 2022
Instead of comments, one could also try using whitespace to make the distinction clearer. I'm not a great fan of splitting per phase, because e.g. Mauryans can construct the elephant stable in phase 2, but the rest only in phase 3.
I guess one could/should check whether the comments are kept when running the template reorganiser.
Jul 15 2022
I didn't want to touch this file unless I had time for a more thorough cleaning, but meh.
I'll check mirages and (de)serialisation.
Jul 14 2022
Jul 6 2022
Jul 4 2022
Please abandon, as https://code.wildfiregames.com/rP26998 has already landed.
Jul 3 2022
Jul 2 2022
Can you attach a replay, please? :)
Jul 1 2022
However, I consider this a very low prio at the moment. ^^
I agree on the current patch not adding much, but one can put constraints on upgrading (e.g. tech required) and not on promoting. So this can be changed a bit to check for that.
(For the committer, which may be me depending on time.)
Jun 30 2022
It would give them almost the same aura as the carnyx. Maybe give the latter a positive friendly bonus?
Jun 28 2022
Rebased, fix linter.
A more involved and correct fix.
Jun 27 2022
We're still in the twinFormations of other formations. The last part might need to be disband where we remove ourselves from the twinFormations of our twins.
Fix the symptom of adding members to a non-existing formation.
I'll need to investigate further what triggered this.
Jun 25 2022
Jun 23 2022
Yeah, that was already the case before this patch.
Jun 21 2022
That is not how it works. xD If you agree with the patch, you may just accept it. :)