Two questions:

• Can anyone help me how to make a function of the sorting (in Resources.js)? (And in test_Player.js.)
• Which of the two functions I introduced in Resources.js would be most efficient? Currently GetTributableCodes/GetBarterableCodes/GetTradableCodes is used, which is just an array of the respective codes. Should I just remove the other functions since they are not used?

(Hopefully) fixed serialising. (Load/Save works fine.)

• Moved position remembering to the order.
• Walking state after finishing.

• Movement animation.
• Return to beginposition after finishing scouting.
• Removed redundant function (entities near position in UnitAI)
• Shrunk targetPos

In D1851#78736, @Angen wrote:

1. you need to select movement animation for unit
2. I do not think automatic scouting should avoid to scout enemy territory
3. when they do not find position to explore they could go into home territory or back to some cc
4. you can start timer and check if position of unit have changed and if not then is probably moving on place trying to reach something what cannot else I think it would need to implement reagon map as AI has. (see terrain-analysis.js in ai/common-api)

I do not think Pathfinder or unitmotion has something like this. ( @wraitii ?)

• Let the method use positions rather than GAIA-entities
• Changed C-function name
• Changed years in C-files

I have a question on how to proceed. I have basically three options now:

1. Use the point at which the scout command is given as a reference point and scout in ever increasing circles. (Note that this will not use the hard-fought new function.)
2. Use the entity's current location and move (semi-)randomly to the nearest unexplored territory.
3. Just randomly pick unexplored locations in the map and try to move to it, even if the first point is very far away.

There may be other options, which I would love to hear ;) I currently am trying to implement the second method.

In D1851#78605, @Angen wrote:

Maybe now you will not send position which is out of world but the function itself should return correct answer with any parameters given.
To have name Ispositionexplored and return true if out of world while positions out of world are not explored is not correct.
Canplayerexploreposition is basicly saying if it is allowed for player to explore it so maybe this.
My point is this is going to be called from js so name should state clearly what is the result. It should have not hidden behaviour.
Another side of this approach picking position based on gaia entities.
What if it picks wolf or lion and goes there and dies stupidly because there will be group of them waiting?

In D1851#78567, @Angen wrote:

On the second thought you should probably change it to ShouldPlayerExplorePosition and return true if tile is not explored and is in the world. Use funtions IsLosOfWorld else entity will try to reach unreachable area out of world.

Thanks @Angen it works now! It is indeed strange that the vector did not work, maybe I'll find out some day.
Just a question: should it not be "entity_pos_t z" instead of "entity_pos_t y"? For I thought that "y" is the height?

Add const at ccmps.

Added C-changes proposed by @Angen , because I need help getting it buildable.

Removed duplicate type in cmpDamage.CauseProximityDamage at CauseDamage.

Ensured that a sea-creature is not targetted, but this is not the way it should be ;)

Added a button to activate the scouting. Now going to try to use the code provided by @Angen (link).

Awesome :D
Lubuntu, NVIDIA 512 MB graphics card: no error, warning or anything alike.
It would be nice if an entity could see further if it were standing higher, so one could overlook a field when standing on a nearby hill, but I don't know whether that is in the scope of this patch ;)

Sorry for the removed subscription, I don't know what happened,,,

This button should be moved from the selection panel to next to the minimap and iterate over all entities, I guess?

• Converted to call-to-arms button (so lots of changes).

• Removed some rudementary braces
• Edited Siege-tower template to comply with new template method

In D1868#77244, @Stan wrote:

Usually one should refer to the tickets :)

In D1868#77241, @Stan wrote:

Oh yeah, I misread the ticket. That's just a side effect of calling units to arms.

In D1868#77236, @Stan wrote:

About the patch itself, I'm not sure it is a wanted a feature.

• Added test
• Replaced the timer-check at init with one at Ownership-change to prevent entities with OnlyWhenMoving == true to do damage upon creation.
• Use range query instead of EntitiesNearPoint as suggested by Angen
• Typo (bonusses)
• Fixed error with FriendlyFire
• Updated JSDoc

In D1851#76653, @Stan wrote:

Apparently it was a planned feature. https://trac.wildfiregames.com/wiki/XML.Entity.Actions.Scout
What I'd like to see as well is when some units go idle their vision range slightly increase to an extent like in AOM

The start of this and #3634? Which I would think is awesome!

In D1838#76640, @Angen wrote:

Quick question:
Would not be better to use range query to get entities around instead calling this.EntitiesNearPoint ?

In D1851#76627, @Imarok wrote:

Sure, no criticism intended.
I just didn't want you to invest precious time in the believe it will get straight into the main game. ;)

In D1851#76566, @Imarok wrote:

Yeah, that doesn't always have a meaning ;)

In D1851#76552, @Imarok wrote:

Picking hidden gaia entities really sounds like cheating. ;)
Also do we really need scouting? With a few shift+clicks on the minimap a unit can be ordered to scout the whole map.

In D1718#76526, @Stan wrote:

One could add a timer to know what was the last time TakeResources() was called, and only start decaying, or regrowing when it's been a certain amount of time. But I think that will add a lot of complexity for no benefit...

In D1718#76477, @Stan wrote:

That would actually be a decay when not gathered, and grow when gathered, so two new options.

If I read this correctly, the constraint whether an entity is worked is removed because it is unrealistic that a dead animal decays slower when attended. But shouldn't the option at least be given? For it could be quite useful when considering farms: attended by workers means it grows (quickly), essentially making it an infinite supply, but when no workers are working it it decays. (This would make prolonged raiding a real pain.) This would probably require the generically named "constraint" to be renamed to something a bit more specific, e.g. "livingStatus".

Some minor fixes.

Better way for checking unit motion. Some more fixes.

Implemented some suggestions.

It's okay ;)

Sorry, didn't wait for reaction about the currency, I implemented it during lunch.

Okay, from what I see it is almost done?
Things to discuss:

• resourceTradable/resourceBarterable/resourceTributable Objects are not used by me and can be removed I guess? Unless someone sees any useful application for it?
• Connected: If the above is done, the question about the caching is not relevant anymore, right?
• Duplication in the Resources.js and in the test_Player.js can be reduced. (I'm sorry, but I do not consider myself up to that task.)
• Should I add a currency parameter in this patch so that @wowgetoffyourcellphone and @Nescio are happy? ;) (see this thread)
• Are there any other things that ought to be done?

And a question, there are no reviewers, should I invite them or do they pick differentials themselve?

Fixed confusing names, AI tribute requests and removed unnecessary test in code.

Some minor fixes.

@Nescio This:

Fixed tests.

Some fixes and Petra-AI should now follow the constraints, which is difficult to test fully.

I'm already checking out the code there, it is quite similar but has a few things I didn't think of.

Yes, it would indeed be better, but if it is like this one can just add a new resource exactly the same way as before. I don't mind to copy extra code when making a new resource, but I reckoned this is less prone to error?
The screenshots I cannot add, but the icon is just not shown in the trade/diplomacy window. Except the small barter window when selecting the market, I couldn't find what to change to make sure that is not shown there.
I haven't changed the AI, so that will still ask for the resources and barter them also I guess, I didn't check actually. I can try and look for the code in Petra to fix it, but that will take some time.

I certainly would like to be complete, but the unit tests seem a little too complicated for me now :)
Is the JSDoc somewhat better now?

Some documentation mainly.

I understand :)

Applied Stan's inline suggestions.

In D1838#75619, @Stan wrote:

Well it's on #995

Perhaps my summary is a bit ambiguous, this allows a unit to have trample damage, so it can charge 'through' a formation of units whilst dealing damage. Useful for e.g. chariots, elephants, macadonian fire-raiser et alii.

Changed some var to let in the vicinity, reduced indirection at line 1897.

Applied feedback (check for cmpAttack, revert test arrow for SiegeTower)