Page MenuHomeWildfire Games

Freagarach
User

Projects

User Details

User Since
Apr 5 2019, 7:29 PM (76 w, 3 d)

Recent Activity

Today

Freagarach requested changes to D1010: introduce subfolders for geology templates.

Your script needs some fixes.
E.g.

-e 's,geology_metal_alpine,alpine_small,g' \
-e 's,geology_metal_alpine_slabs,alpine_large,g' \

means that first geology_metal_alpine_slabs is replaced with alpine_small_slabs.
Also the gaia-folder is missing in the replacement strings.

Mon, Sep 21, 12:09 PM
Freagarach added a comment to D2993: [gameplay] add visible garrison points to rome siege wall tower.

I guess we need only some opinions from the balancing department.
Unless this:

In D2993#131488, @Stan wrote:

The top of the tower looks very crowded though.

is sufficient reason to hold this off?

Mon, Sep 21, 11:54 AM
Freagarach added a comment to D2382: [WIP] - Building Sockets..

@gameboy No sir, this patch is not ready. In the title it says [WIP] -- meaning that it is a work in progress. Moreover the status of the patch is Changes Planned meaning there is stuff that needs to be done but time (and motivation) to be found.

Mon, Sep 21, 7:33 AM

Yesterday

Freagarach edited reviewers for D1010: introduce subfolders for geology templates, added: Freagarach; removed: Restricted Owners Package.
Sun, Sep 20, 7:55 AM

Fri, Sep 18

Freagarach added inline comments to rP23890: Enable Macedonian gastraphetēs (crossbowmen) at the siege workshop..
Fri, Sep 18, 10:07 PM
Freagarach accepted D2973: Add safeguards for all queryOwnerInterface calls.
Fri, Sep 18, 3:02 PM
Freagarach added a comment to D2973: Add safeguards for all queryOwnerInterface calls.

This is complete and correct.

Fri, Sep 18, 2:48 PM
Freagarach commandeered D1323: Add Upkeep component..

Forgot,,,

Fri, Sep 18, 1:36 PM
Herald added a reviewer for D2917: [gameplay] allow upgrading cart_house to cart_apartment: Balancing.

One could use a technology to swap the house with the apartment in the build list? Meaning the player would have houses and can build apartments thereafter.
E.g. the player builds one house, researches the technology and can only build apartments next.

Fri, Sep 18, 12:22 PM
Freagarach updated the diff for D1323: Add Upkeep component..

Component.

Fri, Sep 18, 10:58 AM
Freagarach added a comment to D2953: move various values to specific fauna files.

To me this adds merely a lot of duplication actually. While I am not opposed to moving values to specific templates, without the number of template_unit_fauna_* files can be greatly reduced, keeping only those that are meaningful (e.g. elephant, whale). this patch makes little sense IMHO.
E.g. there are three bears, nicely inheriting from a *bear template, which now all three have the exact same values added. I know that in reality those three bears are vastly different and should have different stats, but until they do I do no think it is necessary to duplicate those values.

Fri, Sep 18, 9:00 AM

Thu, Sep 17

Freagarach added a comment to D1009: introduce subfolders for flora templates.

I'm hoping someone knows a clever way to move and rename all of them at once with a single command while preserving their svn file history.

I would be interested in that as well. In the meantime one could write a bash script like used for the civ-moving. (Notice the first part of each sentence in my itemisation was a command one could use :) )

Thu, Sep 17, 6:48 PM
Freagarach edited reviewers for D1009: introduce subfolders for flora templates, added: Freagarach; removed: Restricted Owners Package.
Thu, Sep 17, 6:25 PM
Freagarach added a comment to D1009: introduce subfolders for flora templates.

My knowledge is limited, but I would do something along the lines of:

  • find files with name matching flora_tree_*
  • cut that part from the name
  • svn mv the matching files to tree/ with their new name

(svn rename is just an alias to svn mv according to its help function, whereas the rename program can do more.)

Thu, Sep 17, 6:21 PM
Freagarach added a comment to D2985: [gui] omit resource trickle and loot from attack & resistance tooltip.

Agreed, but then there is the question what is ,,only the most important and relevant information'' ;)

Thu, Sep 17, 12:38 PM
Freagarach requested changes to D2913: Stop dodging arrows by patrol: Wait a few seconds between patrol waypoints..

See IRC on acceptance-day.

Thu, Sep 17, 12:28 PM
Freagarach added inline comments to D2940: Move some position-related functions to PositionHelper..
Thu, Sep 17, 12:25 PM
Freagarach added a comment to D2985: [gui] omit resource trickle and loot from attack & resistance tooltip.

in the one that opens when right-clicking on an entity icon.

Hmm, maybe that is indeed enough,,,

Thu, Sep 17, 12:08 PM
Freagarach added a comment to D2985: [gui] omit resource trickle and loot from attack & resistance tooltip.

Perhaps this should be moved to the tooltip of the entity icon?

Thu, Sep 17, 11:20 AM
Freagarach added a comment to D2551: rename some structure icons.

@Stan did the discussion help you any further?

Thu, Sep 17, 11:18 AM
Freagarach added a comment to D2477: [gameplay] garrison units on short wall segments.

It isn't pretty, but it works.

Since a key of 0 A.D. is prettiness, I don't think this should be committed.

Thu, Sep 17, 11:11 AM
Freagarach updated subscribers of D2802: [gameplay] make fireships ignore anything but ships.
In D2802#119810, @borg- wrote:

As far as I know about them, they were Greek and not Iberian ships, but I must be mistaken. It would be interesting to have a historical expert here.

@genava55

Thu, Sep 17, 11:01 AM
Freagarach added a comment to D2507: [gameplay] allow building palisades in neutral territory.

This would be ideal, unfortunately I don't have the skills to be able to figure out if this is a meta changing patch with a few games.

(Better not commit this too late in the dev-cycle then.)

Thu, Sep 17, 10:56 AM
Freagarach updated the diff for D2940: Move some position-related functions to PositionHelper..

Changed some JSDOC.

Thu, Sep 17, 10:44 AM
Freagarach planned changes to D2161: Also account for elevation for melee units..
In D2161#131391, @Angen wrote:

Spreading this issue to melee units is not happy solution. Also I am not sure if this is actually needed for melee. Or target is 2 meters from me and I can reach in any direction, does not matter if target stays a bit higher than me or below or I cant reach it because my weapon is too short.

Notice melee units don't use parabolic range, so the only described case that would be true is that the range query would return entities which are actually out of range.

Thu, Sep 17, 10:17 AM
Freagarach added a comment to D2993: [gameplay] add visible garrison points to rome siege wall tower.

it's consistent to remove them.

True that.

Thu, Sep 17, 10:04 AM
Freagarach added inline comments to D2652: Do not allow upgrading when entity is producing and vice versa..
Thu, Sep 17, 8:38 AM
Freagarach added a comment to D2995: Properly internationalize attack names/Generlize to arbitrary names in the GUI.

The main reason for this differentiation above just Melee and Ranged is secondary attacks (which _will_ come and thus should be counted with). Then one can have a longer ranged melee attack, e.g. using a sarissa and one for close combat, e.g. a sword and Melee wouldn't suffice anymore.
We may just use AttackName and use the weapon there when possible (i.e. the above mentioned case) and revert to Melee and Ranged when it is either not possible (e.g. animals) or undesirable (e.g. structures).

Thu, Sep 17, 8:18 AM
Freagarach added a comment to D2652: Do not allow upgrading when entity is producing and vice versa..

Works as advertised.

Thu, Sep 17, 7:47 AM

Wed, Sep 16

Freagarach added a comment to D3008: Correctize cost tooltip for upgrades.

@elexis provided the hint why the line is changed: if (template.wallSet) will always be false and thus it is not necessary to go through that?

Wed, Sep 16, 6:26 PM
Freagarach accepted D3008: Correctize cost tooltip for upgrades.

Wonder why rP20046 changed this like this

Good question.

Wed, Sep 16, 6:21 PM
Freagarach updated the diff for D2654: Allow free Upgrades and/or Technologies..

Rebased.

Wed, Sep 16, 6:04 PM
Freagarach added a comment to D2980: Get dropsite resources from simulation..

Thanks for the review @Angen :)

Wed, Sep 16, 6:00 PM
Freagarach resigned from D3005: Range safe buildingAI.
Wed, Sep 16, 5:57 PM
Freagarach committed rP24045: Get dropsites' accepting resources from simulation instead of hardcoding them….
Get dropsites' accepting resources from simulation instead of hardcoding them…
Wed, Sep 16, 5:29 PM
Freagarach closed D2980: Get dropsite resources from simulation..
Wed, Sep 16, 5:28 PM
Freagarach added inline comments to D2654: Allow free Upgrades and/or Technologies..
Wed, Sep 16, 5:23 PM
Freagarach committed rP24044: Split "template_gaia_geo"..
Split "template_gaia_geo".
Wed, Sep 16, 5:19 PM
Freagarach closed D2991: split template_gaia_geo*.
Wed, Sep 16, 5:19 PM
Freagarach committed rP24043: Split "template_gaia_flora*"..
Split "template_gaia_flora*".
Wed, Sep 16, 5:15 PM
Freagarach closed D2990: split template_gaia_flora*.
Wed, Sep 16, 5:15 PM

Tue, Sep 15

Freagarach added inline comments to rP23553: Move Persian cavalry to the persian folder..
Tue, Sep 15, 5:54 PM

Fri, Sep 11

Freagarach added a comment to D2983: Reduces memory usage for fancy water.

Noted issue is gone now :)
(Although I cannot reproduce it even with the former patch.)

Fri, Sep 11, 5:31 PM
Freagarach planned changes to D2808: Allow resistance to StatusEffects..

Properly internationalise tooltips. (The rest accepts review.)

Fri, Sep 11, 4:15 PM
Freagarach added a comment to D2983: Reduces memory usage for fancy water.

Have you compiled the game?

Yes :)

Fri, Sep 11, 4:07 PM
Freagarach added inline comments to D2376: Store the garrisonHolder in cmpGarrisonable instead of iterating orders..
Fri, Sep 11, 2:07 PM
Freagarach updated the diff for D2376: Store the garrisonHolder in cmpGarrisonable instead of iterating orders..

Changed some comments.

Fri, Sep 11, 2:06 PM
Freagarach planned changes to D2368: Move movement logic from UnitAI's "Garrisoned"-state to approaching..

Okay, forgot to mention it in the update message, but I've moved the immobility and garrisoned setting now to the "correct" locations. However, they are not correct here for turrets, since those change states, trigger leave and thus break the whole idea. (See D2379.)

Fri, Sep 11, 1:31 PM
Freagarach added inline comments to D2368: Move movement logic from UnitAI's "Garrisoned"-state to approaching..
Fri, Sep 11, 1:29 PM
Freagarach updated the diff for D2368: Move movement logic from UnitAI's "Garrisoned"-state to approaching..
Fri, Sep 11, 1:28 PM
Freagarach added a comment to D2755: Don't store the gatherers per player..

Thanks for the review @bb!

Fri, Sep 11, 12:20 PM
Freagarach committed rP24036: Don't store the gatherers per player..
Don't store the gatherers per player.
Fri, Sep 11, 12:19 PM
Freagarach closed D2755: Don't store the gatherers per player..
Fri, Sep 11, 12:19 PM
Freagarach resigned from D2791: Do not attempt to gather when full on that resource.

I can't review since I wrote part of the code myself.

Fri, Sep 11, 11:30 AM
Freagarach updated the diff for D2791: Do not attempt to gather when full on that resource.

Revert the move in gather.

Fri, Sep 11, 11:29 AM
Freagarach added inline comments to D2913: Stop dodging arrows by patrol: Wait a few seconds between patrol waypoints..
Fri, Sep 11, 9:44 AM
Freagarach accepted D2913: Stop dodging arrows by patrol: Wait a few seconds between patrol waypoints..

I'm not particularly fond of the the integer wait time, but I failed to device a better way without major changes (i.e. using a range query and just setting a single timer to go to the next waypoint).

Fri, Sep 11, 9:43 AM
Freagarach added a comment to D2913: Stop dodging arrows by patrol: Wait a few seconds between patrol waypoints..

Possibly final cleanup.

Did you try this in-game?

Fri, Sep 11, 9:24 AM
Freagarach added a comment to D2913: Stop dodging arrows by patrol: Wait a few seconds between patrol waypoints..

It looks much better with only one second waiting time :)

Fri, Sep 11, 9:06 AM

Thu, Sep 10

Freagarach accepted D3005: Range safe buildingAI.

Idea and code is correct, adds ~50-150 microseconds per arrow.

Thu, Sep 10, 8:45 PM
Freagarach requested changes to D2652: Do not allow upgrading when entity is producing and vice versa..
  • Build two sentry towers.
  • Upgrade the first to a defence tower.
  • Select both towers.
  • Try to research sentries.
  • Notice the message that we can't start production.
Thu, Sep 10, 7:55 PM
Freagarach accepted D2990: split template_gaia_flora*.
  • Forest plant: Indeed unused, can be added later if deemed a necessity.
  • Effectively nothing has changed. Complete.
  • Change is nice, it clears it up nicely.
Thu, Sep 10, 7:30 PM
Freagarach accepted D2982: Read correctly 0/false values from map files in gamesetup.

It is good read map data correctly. Stupid mapmakers should get stupid results.
Complete.

Thu, Sep 10, 6:44 PM
Freagarach added inline comments to D2982: Read correctly 0/false values from map files in gamesetup.
Thu, Sep 10, 6:40 PM
Freagarach added a comment to D2997: Remove visibleclasses from guiinterface.

Or make it useful by using sim-information in the tooltip? Although I guess PetraAI would break if one changes classes in-game.

Thu, Sep 10, 5:40 PM
Freagarach requested changes to D2982: Read correctly 0/false values from map files in gamesetup.

gui/gamesetup/Pages/GameSetupPage/GameSettings/Single/Dropdowns

  • MapSize.js
  • WorldPopulationCap.js
Thu, Sep 10, 5:32 PM
Freagarach added a comment to D2161: Also account for elevation for melee units..

If you wield a sarissa it does matter whether your target is at exactly six meters away horizontally or six meters horizontally and two meters up (e.g. on top of an elephant).

Thu, Sep 10, 5:19 PM
Freagarach added inline comments to D2995: Properly internationalize attack names/Generlize to arbitrary names in the GUI.
Thu, Sep 10, 5:10 PM
Freagarach added inline comments to D2661: Get attack effects from JSON..
Thu, Sep 10, 3:20 PM
Freagarach added a comment to D2661: Get attack effects from JSON..

These are attack effects, the effects an attack can have (attack types are melee and ranged etc. currently).

Thu, Sep 10, 2:40 PM
Freagarach added inline comments to D2661: Get attack effects from JSON..
Thu, Sep 10, 2:30 PM
Freagarach added inline comments to D2661: Get attack effects from JSON..
Thu, Sep 10, 2:28 PM
Freagarach updated the diff for D2661: Get attack effects from JSON..
  • Ditch temporary array
  • Don't hardcode attack sound.
  • Return {} in tests.
Thu, Sep 10, 2:28 PM
Freagarach added a comment to D2983: Reduces memory usage for fancy water.

Before:

Thu, Sep 10, 1:33 PM
Freagarach updated subscribers of D2993: [gameplay] add visible garrison points to rome siege wall tower.

@Stan opinion on the flag removal? (I like the flags, but I'm no artist.)

Thu, Sep 10, 11:41 AM
Freagarach edited reviewers for D2990: split template_gaia_flora*, added: Freagarach; removed: Restricted Owners Package.
Thu, Sep 10, 11:39 AM
Freagarach accepted D2991: split template_gaia_geo*.
Thu, Sep 10, 11:18 AM
Freagarach added a comment to D2991: split template_gaia_geo*.
  • Checkrefs says it is complete.
  • Playtesting reveals no errors.
  • UnitsDemo loads fine.
  • Change is for the better.
Thu, Sep 10, 11:18 AM
Freagarach added a comment to D2989: Reuse "APPROACHING"-state in formation combat..

Thanks for the review @Angen and @bb :)

Thu, Sep 10, 10:54 AM
Freagarach added a comment to D2732: Allow to guard a guard..

Thanks for the review @Angen (and @bb) :)

Thu, Sep 10, 10:54 AM
wraitii awarded rP24032: Reuse "APPROACHING"-state in formation combat. a Love token.
Thu, Sep 10, 10:43 AM
Freagarach added inline comments to D2980: Get dropsite resources from simulation..
Thu, Sep 10, 10:41 AM
Freagarach updated the diff for D2980: Get dropsite resources from simulation..
  • Remove redundant typeIcon in tooltip.
  • Remove tooltip from attackAndResistanceStats.
  • Show before health in reference page.
Thu, Sep 10, 10:41 AM
Freagarach planned changes to D2368: Move movement logic from UnitAI's "Garrisoned"-state to approaching..

Point autogarrisoning to GARRISONING-state.

Thu, Sep 10, 10:31 AM
Freagarach closed D2774: gaia/fauna_fish* → gaia/fish/*.
Thu, Sep 10, 10:21 AM
Freagarach updated the diff for D2755: Don't store the gatherers per player..

@Angen, I'm keeping JSDOC anyway ;)

Thu, Sep 10, 10:16 AM
Freagarach committed rP24033: Allow guards to guard a guarding guard..
Allow guards to guard a guarding guard.
Thu, Sep 10, 10:01 AM
Freagarach closed D2732: Allow to guard a guard..
Thu, Sep 10, 10:01 AM
Freagarach committed rP24032: Reuse "APPROACHING"-state in formation combat..
Reuse "APPROACHING"-state in formation combat.
Thu, Sep 10, 9:52 AM
Freagarach closed D2989: Reuse "APPROACHING"-state in formation combat..
Thu, Sep 10, 9:51 AM
Freagarach committed rP24031: Move "fauna_fish* -> "fish/*"..
Move "fauna_fish* -> "fish/*".
Thu, Sep 10, 9:41 AM
Freagarach accepted D1977: Cheer after no enemy entities left in range.
  • Code looks good.
  • PetraAI vs PetraAI matches give no oddities.
  • Dangerous animals don't error out.
  • Entities cheer when won a fight instead of after promoting, which is a big improvement!
Thu, Sep 10, 9:08 AM

Wed, Sep 9

Freagarach added a comment to D2999: [gameplay] make unlock_shared_dropsites independent from unlock_shared_los.

Could you elaborate on why this ought to be an improvement? To me sharing dropsites follows naturally from sharing information.

Wed, Sep 9, 6:08 PM
Freagarach added inline comments to D2993: [gameplay] add visible garrison points to rome siege wall tower.
Wed, Sep 9, 6:04 PM
Freagarach added inline comments to D2661: Get attack effects from JSON..
Wed, Sep 9, 5:58 PM
Freagarach added a comment to D2652: Do not allow upgrading when entity is producing and vice versa..

(Also maybe add a test for this behaviour?)

Wed, Sep 9, 5:55 PM
Freagarach added inline comments to D2652: Do not allow upgrading when entity is producing and vice versa..
Wed, Sep 9, 4:34 PM

Sat, Sep 5

Freagarach added inline comments to D2993: [gameplay] add visible garrison points to rome siege wall tower.
Sat, Sep 5, 9:20 AM
Freagarach added a comment to D2995: Properly internationalize attack names/Generlize to arbitrary names in the GUI.

Break your head around whether it is actually translated, or hope the best

Or verify experimentally by manually inserting an entry in a .po file ;) (Which I did, and it gets translated properly.)

Sat, Sep 5, 8:55 AM
Freagarach updated the summary of D2994: Allow entities without cmpResistance..
Sat, Sep 5, 8:14 AM