User Details
- User Since
- Apr 5 2019, 7:29 PM (120 w, 4 d)
Today
Concern that it may not be forgotten after the release.
Yesterday
Fixes the running in formation without need.
It made chasing hard again, so not really.
Sun, Jul 25
Fixes #6245.
Sat, Jul 24
Fri, Jul 23
Thu, Jul 22
As per above.
Wed, Jul 21
@ValihrAnt Is this concern fixed?
Tue, Jul 20
- More const.
- Some more rearrangements.
One could use the ?. notation to make it a one-liner.
I think it is cleaner to disable stuff using triggers.
Mon, Jul 19
Don't exclude ships explicitly ships.
Need both classes (fixes PetraAI training loads of cavalry).
Code looks good, I haven't tested this.
Sun, Jul 18
Separate baseless base.
Sat, Jul 17
I agree, that base is special, so it can also be treated special.
Can I conclude that you agree to the concept?
Fix PetraAI building Siege Towers now (which she doesn't understand how to use).
Thanks for this. It shows that I should use better naming.
Sun, Jul 11
- Address @Angen's comment.
- const
- Moved some functionality to basesManager.
Sat, Jul 10
Use build order name.
One may want to push this order to the front (to go back to gathering when finished) so I think it is worth to check whether that route can be implemented.
Some code comments. I haven't tested this yet, but thanks for the patch already!
Tue, Jul 6
Mon, Jul 5
Sat, Jul 3
Should there be a comment/ref. to ticket?
Wed, Jun 30
Keep in mind that people will be annoyed because they will lose their units sooner, since the dangerous animals will attack first.
True, true, but I'm merely saying that it was broken already, but less so than it is now. "It will work" as in hot-fix. Feel free to point me in another direction for a more proper fix.
Because we try to match a more general condition (Siege) on a more specific class (Siege+Melee).
So it was working. This condition checks string presence, so that will work.
Siege was built in the wrong queue.
D4184, but there is more, since she keeps constructing siege without using it.
Tue, Jun 29
Either causes or exposes https://wildfiregames.com/forum/topic/45178-a25-svn-version-25810-not-playable/.
I guess a concern would be in place.
Well, ideally not, I guess, but for now, yes.
Good change.
(May or may not be worth a concern.)
My concern is fixed in rP25811.
Jun 24 2021
Taking it out of the queue, but I might take this over some day (TM).
For fauna: I guess, yes. Though you can also train e.g. zebu?
Flora: Certainly, they should be owned by GAIA.
Ruins: Not sure, for those can be player owned?
Jun 22 2021
Jun 21 2021
I just had a discussion with @elexis, it would be good if we can't crash from JS (might have been a thing in the past). So it would be nice if we could reliably serialise NaN and error, or just don't serialise but do error.
I agree, but the concern seemed to be a matter of preference, so hence the way I asked the question. But I guess it is not enough, since @nani did not resign from this commit yet.
Jun 20 2021
My concern was fixed in rP25804.
@nani has the autoqueue been adapted enough to your liking?
Jun 18 2021
libsdl.cpp
../../../source/lib/external_libraries/libsdl.cpp: In function ‘const char* GetSDLSubsystem(SDL_Window*)’:
../../../source/lib/external_libraries/libsdl.cpp:89:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
89 | subsystem = "Haiku";
| ~~~~~~~~~~^~~~~~~~~
../../../source/lib/external_libraries/libsdl.cpp:92:2: note: here
92 | default:
| ^~~~~~~Jun 17 2021
Jun 16 2021
Well, it is a nice feature when it can be automated.
As stated inline.
Have you searched for the reason this string is as is? (Hint: search.)
You've based the patch wrongly. ;)
Jun 15 2021
Don't store the variable when not present.
I can only think of expensive calculations like checking LOS for enemies and filtering those to closer units.
I think you might be able to use the mixins here.
Jun 14 2021
Works for me, no clue about any other implications.