In D4661#198366, @marder wrote:

To sum up how the rules would be intuitive for me:

Once you build a wonder the timer starts.
The timer counts/ is the same for every ally / everybody on the team.
The timer *only* gets reset if you (or you teammates) loose the (last) wonder due to it being destroyed or captured.
Whoever is on a team in the moment the timer is zero wins - everybody else looses

(/me agrees.)

@marder, please address D4249#198325. :) (Doesn't need a patch, merely a commit.)

Reads correct.
Works as intended.
Nice "feature".

This looks good, I will test later.

Reads and greps correct.
Not renaming is the safest here.

I guess they wanted to accept. :)
@marder can commandeer back?

Reads correct.
Change is good.

Not useful for PetraAI.

Reads correct.

One thing, I think this lacks is recovering, we stay in the emergency state forever, even if we'd win.
Something like if we're back to ~75% of the previous population the emergency is lifted?

Maybe?

Reads correct.
Tests can be expanded (by testing _something_ between 0 and Math.PI) but are okay for now.

X11 functions, including screenshots. :)

In D4643#197417, @Mercury wrote:

@Stan Have any instructions for Linux?

git diff --no-prefix -U9999 according to The Internet.
Also, please set the repository correctly when manually uploading the patch. That way our linter can tell you part of our coding conventions. :)

First of all, thanks for working on this. :)

(Sorry for spamming the diff. It was less work than expected.)

I'll try and rewrite the tests.

Fix tests.

JS only.

With the inline and D4605, I get no OOS with the rejointest.
The patch reads correct from a functional view.

The pass class name _was_ serialised? And the reason it worked was probably because the pass class name didn't change ove the course of a match. ^^

In D4486#197134, @wraitii wrote:

The specific approach taken here doesn't strike me as bad, but I think C++ wise I'd prefer what I've done in D4630 with the component manager. It's less code & more maintainable IMO.

If you could fix/merge the convenience function please, then I can move that from this diff and go back to JS. ^^

In D4486#197129, @Stan wrote:

Was the message used by the AI?

Nope. Do notice the message was already not sent anymore. I only remove the declaration and the listener in cmpTrainer.

Purge obsolete message.

See discussion on IRC yesterday.
https://irclogs.wildfiregames.com/%230ad-dev/2022-05-06-QuakeNet-%230ad-dev.log

Looks good (in more ways than one :) ).

You'll need to update cmpUnitMotionFlying to also update the clearance in cmpObstruction.

I would like to see the ITA of a unit as a first fix. Than we can later discuss/establish whether the value is necessary at all.

No clue why, and D4593 seem okay.

This is your error:

ERROR: JavaScript error: simulation/components/Formation.js line 158
Engine.QueryInterface(...) is null
  Formation.prototype.Init@simulation/components/Formation.js:158:9
  global.ConstructComponent@simulation/components/tests/setup.js:112:6
  @simulation/components/tests/test_Formation.js:22:40

#1 -> This leads to weird code, because:

• Maps don't care about non-JSON data

I'm not sure what you mean here, but grep -irn maps/ -e 'gettemplate' results in quite some hits. ^^

• GUI cares about JSON data and the 'Identity' part of the XML data, but only that part.

Also civ/team bonuses, available templates etc.?

• Sim mostly doesn't care about JSON data.

Working to ensure that. ;P

Back to non-generic solution.

In D4626#196812, @marder wrote:

But even without seeing the bug, I would say we should be able to conceptually agree that the function should have parenthesis as we want to get the modulo for a circle and not the modulo 2 times pi :)

Yeah, just curious to what the symptoms were. ^^

Basically back to https://code.wildfiregames.com/D4486?id=19699. ^^

What are the symptoms of this mistake?

Change is good.
Reads correct (apart from the inlines).
I haven't tested it.

Both, I guess?

I guess a general order ought to be established?

In D4615#196366, @psypherium wrote:

Edit: To be clear, I'm not assigning malice to you, it could be a language difference or a cultural difference or just wanting to type something fast so you can start work on something else. But sometimes it is worth taking the extra time to make sure that the only "attack" is against oneself (you know for sure how you will react, you can never know how someone else will). Especially in open source, everyone is here by choice, not because it's their paycheck.

You probably don't even need to really change the way you communicate, people like me can just come in every now and then and clarify that no-one is acting with malice, we all love each-other.

<3

^

Good fix.

Fixes #4949.

But 0 != 10?
I know there are keyboards out there with more than 10 numbers, to be used specifically for control groups, how to handle one with a 10?

D4613

In D4608#196088, @Langbart wrote:

@Freagarach Do I understand correctly that UnitMotion shall be removed ?

Nope, it should be kept, else one can't order a single mangonel to move, IIRC.

In D4608#196034, @Langbart wrote:

The unpacked siege units still have UnitMotion, but a very small almost-zero speed, and UnitAI doesn't allow them to move without packing anyway.

Do note this is wrong. I've noticed a long time ago that when you attack siege set to passive, interesting things happen to see by those who wait.

Is this the forum thread you meant? https://wildfiregames.com/forum/topic/75691-trader-bonuses-international-vs-landsea-traders/

Tested, functions.

Saving some progress.

In D4603#195832, @phosit wrote:

I think this patch is bad because next time nobody will notice a upgrade of the library.

You mean because they won't get a 404? IIRC that is the case with most of our libs. Also, being able to specify the zlib version is right now kind of useless, as there is really merely one option (latest) with the current URL. The patch allows easy changing.

Good that you also have the observer see this. We need to think about:

• Teams obtaining victory/getting defeated.
• Translations.

I guess a review? Since this patch touches C++ and I am bad at that. ^^