Page MenuHomeWildfire Games

Freagarach
User

Projects

User Details

User Since
Apr 5 2019, 7:29 PM (86 w, 6 d)

Recent Activity

Yesterday

Freagarach added inline comments to D1268: Remove health component from relics..
Thu, Dec 3, 3:12 PM
Freagarach updated the diff for D1268: Remove health component from relics..

Comments.

Thu, Dec 3, 3:02 PM
Freagarach updated the summary of D1268: Remove health component from relics..
Thu, Dec 3, 2:13 PM
Freagarach updated the summary of D3122: Fixes after rP24216..
Thu, Dec 3, 12:06 PM
Freagarach updated the diff for D3122: Fixes after rP24216..

Off by one error.

Thu, Dec 3, 12:05 PM
Freagarach planned changes to D3122: Fixes after rP24216..

Who'd have thought that everything that is not a wall _is_treated as such,,,

Thu, Dec 3, 11:53 AM
Freagarach added a comment to rP24308: Use C++17 to compile 0 A.D..

(GCC 7 specific.)

Thu, Dec 3, 10:59 AM
Freagarach added a comment to D3122: Fixes after rP24216..

I totally missed your comments here ^^'

Thu, Dec 3, 8:32 AM
Freagarach added a comment to D2685: simplify mercenary cost.

The same could be said about civ bonuses: in principle those changes could be done in the specific templates too.

Not really, since one can capture buildings and the civ-bonuses wouldn't be applied then.

Also unit_elephant_african.json and unit_elephant_indian.json, or unit_advanced.json and unit_elite.json.

Yep, not a fan of those either :) At least the latter two are considered a hack and work is in progress to be replaced by a different system. As to the former two, I guess I missed D2864.

Thu, Dec 3, 7:56 AM
Freagarach raised a concern with rP24308: Use C++17 to compile 0 A.D..

With this replay


and as I start scrolling down (with the arrow down) the game _always_ segfaults for me as of this commit. (After reaching the water.)

Thread 1 "main" received signal SIGSEGV, Segmentation fault.
std::__uninitialized_copy_a<std::move_iterator<void**>, void**, ProxyAllocator<void*, Allocators::DynamicArena> > (
    __alloc=..., __result=<optimised out>, __last=..., __first=...)
    at /usr/include/c++/7/bits/stl_uninitialized.h:275
275		    __traits::construct(__alloc, std::__addressof(*__cur), *__first);
(gdb) bt
#0  std::__uninitialized_copy_a<std::move_iterator<void**>, void**, ProxyAllocator<void*, Allocators::DynamicArena> >
    (__alloc=..., __result=<optimised out>, __last=..., __first=...)
    at /usr/include/c++/7/bits/stl_uninitialized.h:275
#1  std::__uninitialized_move_if_noexcept_a<void**, void**, ProxyAllocator<void*, Allocators::DynamicArena> > (
    __alloc=..., __result=0x55556d1802cc, __last=0x55556d17f54c, __first=<optimised out>)
    at /usr/include/c++/7/bits/stl_uninitialized.h:312
#2  std::vector<void*, ProxyAllocator<void*, Allocators::DynamicArena> >::_M_realloc_insert<void*> (
    __position=0xffffcde000005555, this=0x55556d17e5b8) at /usr/include/c++/7/bits/vector.tcc:424
#3  std::vector<void*, ProxyAllocator<void*, Allocators::DynamicArena> >::emplace_back<void*> (
    this=this@entry=0x55556d17e5b8) at /usr/include/c++/7/bits/vector.tcc:105
#4  0x0000555555994f41 in std::vector<void*, ProxyAllocator<void*, Allocators::DynamicArena> >::push_back (
    __x=@0x7fffffffd0d0: 0x1437c, this=0x55556d17e5b8) at /usr/include/c++/7/bits/stl_vector.h:954
#5  CPatchRData::RenderBlends (patches=std::vector of length 38, capacity 64 = {...}, context=..., 
    shadow=shadow@entry=0x0, isDummyShader=isDummyShader@entry=false, 
    dummy=std::shared_ptr<CShaderProgram> (empty) = {...}) at ../../../source/renderer/PatchRData.cpp:948
#6  0x000055555591a698 in TerrainRenderer::RenderTerrainShader (this=<optimised out>, context=..., 
    cullGroup=cullGroup@entry=0, shadow=0x0) at ../../../source/renderer/TerrainRenderer.cpp:529
#7  0x00005555558f82b1 in CRenderer::RenderPatches (this=this@entry=0x5555572bb150, context=..., 
    cullGroup=cullGroup@entry=0) at ../../../source/renderer/Renderer.cpp:771
#8  0x00005555558fbe77 in CRenderer::RenderSubmissions (this=this@entry=0x5555572bb150, waterScissor=...)
    at ../../../source/renderer/Renderer.cpp:1355
#9  0x00005555558fc5fc in CRenderer::RenderScene (this=0x5555572bb150, scene=...)
    at ../../../source/renderer/Renderer.cpp:1718
#10 0x000055555587f464 in CGameView::Render (this=<optimised out>) at ../../../source/graphics/GameView.cpp:240
#11 0x00005555557b5419 in Render () at ../../../source/ps/GameSetup/GameSetup.cpp:234
#12 0x00005555555b19b8 in Frame () at ../../../source/main.cpp:424
#13 0x00005555555b49f8 in RunGameOrAtlas (argc=<optimised out>, argv=<optimised out>) at ../../../source/main.cpp:713
#14 0x000055555559e117 in main (argc=1, argv=0x7fffffffdff8) at ../../../source/main.cpp:764
Thu, Dec 3, 6:56 AM

Wed, Dec 2

Freagarach added a comment to D2948: Move PopulationBonus to new component Population.

Did you manage to set up your dev-environment?

Wed, Dec 2, 5:31 PM
Freagarach added inline comments to D759: Adapt civinfo page to load relevant info from templates..
Wed, Dec 2, 5:13 PM
Freagarach added a comment to D2685: simplify mercenary cost.

I agree that it hides template values.

Wed, Dec 2, 4:56 PM
Freagarach added a comment to D3155: [WIP] - Show Gatherers next to resource icons.

(Also would it be nice to add some unit tests, but I can try to take care of that when the patch is nigh completion.)

Wed, Dec 2, 4:52 PM
Freagarach retitled D3155: [WIP] - Show Gatherers next to resource icons from Rebased Show Gatherers patch to [WIP] - Show Gatherers next to resource icons.
Wed, Dec 2, 4:51 PM
Freagarach requested changes to D3155: [WIP] - Show Gatherers next to resource icons.

it shows total gatherers under population icon too, which could be useful.

(It confused me what that number meant, at first I thought it was the number of houses.)

Wed, Dec 2, 4:40 PM
Freagarach added a comment to D3155: [WIP] - Show Gatherers next to resource icons.

(I'll do a more extensive review later.)
The amount of traders is already shown in the trade dialog window.
To fix entities in a return cycle counting towards the gatherers one could copy (UnitAI style) the return resource state into the gather-state, adding the gatherer upon entering gather and removing it upon leave. I'm not sure how that works out with retasking, but entity death is accounted for then.

Wed, Dec 2, 6:32 AM

Tue, Dec 1

Freagarach added inline comments to D1268: Remove health component from relics..
Tue, Dec 1, 9:22 PM
Freagarach added inline comments to D1268: Remove health component from relics..
Tue, Dec 1, 7:39 PM
Freagarach accepted D3173: Make update workspaces faster in case of already build.

Looks good, works as advertised.

Tue, Dec 1, 7:38 PM
Freagarach updated the diff for D1268: Remove health component from relics..

Empty tag.

Tue, Dec 1, 7:13 PM
Freagarach added a comment to D3173: Make update workspaces faster in case of already build.

Perhaps quote some more variables? And add . to comments?
Works.

Tue, Dec 1, 5:32 PM

Thu, Nov 26

Freagarach added a comment to D3136: Clean up Obstruction: remove "Active" hack and remove "Block Construction" flag..

There seems to be some magic here that I don't understand. Need to look more into it,,,

Thu, Nov 26, 12:00 PM
Freagarach added a comment to D2822: Rewrite the civinfo page to use OOP principles.

Works as advertised :) From the main menu, from the match setup menu and from within a match.

Thu, Nov 26, 11:44 AM
Freagarach updated the diff for D2646: Remove special Animal state..

Removed unneeded change in test.

Thu, Nov 26, 11:30 AM
Freagarach added a comment to D2689: Update fmt to the most recent release.

Works fine for me! (Lubuntu 18.04; libfmt-dev 4.0.0+ds-2 amd64.)

Thu, Nov 26, 10:50 AM

Tue, Nov 24

Freagarach updated the diff for D2646: Remove special Animal state..

Try to fix UnitAI only one issue at the time.

Tue, Nov 24, 8:50 PM

Mon, Nov 23

Freagarach updated the diff for D2646: Remove special Animal state..

Don't go after the chickens.

Mon, Nov 23, 10:40 AM
Freagarach added inline comments to D2646: Remove special Animal state..
Mon, Nov 23, 10:38 AM
Freagarach added a comment to D3134: fix some typos.

I assume the rest of the ” \n -> ”\n is not done to not cause needless retranslations.

Mon, Nov 23, 9:50 AM

Sat, Nov 21

Freagarach added a comment to D2886: [gameplay] introduce crossbowman templates.

That is exactly what I meant also :) But I understand my wording was wrong.

Sat, Nov 21, 7:41 AM

Fri, Nov 20

Freagarach added a comment to D3124: Switch to C++14.

Working fine here (GCC 7.5, Lubuntu 18.04).

Fri, Nov 20, 5:42 PM
Freagarach added a comment to D2886: [gameplay] introduce crossbowman templates.

(They _are_ in the game already.)

Fri, Nov 20, 4:41 PM
Freagarach added inline comments to D3124: Switch to C++14.
Fri, Nov 20, 4:38 PM
Freagarach requested review of D3122: Fixes after rP24216..
Fri, Nov 20, 8:30 AM
Freagarach added a comment to rP24216: Move civ-specific templates to subfolders..

(Elephantine map was broken hereafter: D3122.)

Fri, Nov 20, 8:05 AM
Freagarach added inline comments to D3115: [SM60] Build system changes.
Fri, Nov 20, 7:32 AM
Freagarach added a comment to D3115: [SM60] Build system changes.

Successfully builds on my end :)

Fri, Nov 20, 7:30 AM

Thu, Nov 19

Freagarach planned changes to D2646: Remove special Animal state..
Thu, Nov 19, 7:15 PM
Freagarach updated the diff for D2646: Remove special Animal state..

Saving some work.

Thu, Nov 19, 7:15 PM
Freagarach added inline comments to D2646: Remove special Animal state..
Thu, Nov 19, 7:14 PM
Freagarach retitled D2886: [gameplay] introduce crossbowman templates from introduce crossbowman templates to [gameplay] introduce crossbowman templates.
Thu, Nov 19, 6:19 PM
Freagarach added a reviewer for D2886: [gameplay] introduce crossbowman templates: Balancing.

Sure, lets wait then ^^

Thu, Nov 19, 6:19 PM
Freagarach updated the diff for D2646: Remove special Animal state..

Can I start tinkering with template values now?

Thu, Nov 19, 5:39 PM
Freagarach added a comment to D2886: [gameplay] introduce crossbowman templates.

If you make sure the values don't change, I can commit the addition of the templates and you can make a separate diff for the values to be reviewed by the balancing department.

Thu, Nov 19, 5:27 PM
Freagarach closed D2952: Move {civ}_*.xml → {civ}/*.xml in templates..
Thu, Nov 19, 11:51 AM
Freagarach committed rP24216: Move civ-specific templates to subfolders..
Move civ-specific templates to subfolders.
Thu, Nov 19, 11:22 AM
Freagarach added a comment to D3113: [WIP] Allow impact sounds depending on classes.

You could also make the sound in Attacking.js to avoid duplication?

Thu, Nov 19, 8:47 AM
Freagarach added a comment to rP24212: Separate elephant archer from cavalry templates..

I missed rebasing after the attack name addition: rP24213.

Thu, Nov 19, 8:06 AM
Freagarach committed rP24213: Missed a rebase when committing r24212..
Missed a rebase when committing r24212.
Thu, Nov 19, 8:06 AM
Freagarach committed rP24212: Separate elephant archer from cavalry templates..
Separate elephant archer from cavalry templates.
Thu, Nov 19, 7:43 AM
Freagarach closed D2595: separate elephant archer from cavalry templates.
Thu, Nov 19, 7:42 AM

Wed, Nov 18

Freagarach updated subscribers of rP24207: Rename nuba -> noba..

Pointed out by: @Sundiata.

Wed, Nov 18, 9:14 PM
Freagarach committed rP24207: Rename nuba -> noba..
Rename nuba -> noba.
Wed, Nov 18, 9:14 PM
Freagarach closed D3018: nuba → noba.
Wed, Nov 18, 9:13 PM
Freagarach updated the diff for D3096: Fix notes in rP24161..

Move.

Wed, Nov 18, 9:00 PM
Freagarach added inline comments to rP24205: [SM52 3/2] Revert static linking change on linux - other fixes..
Wed, Nov 18, 8:22 PM
Freagarach added a comment to D3007: [gui] correct some strings.

the game is 0 A.D., and what's meant is a match.

Would be nice to get this consistent then :)

Wed, Nov 18, 5:37 PM
Freagarach added a comment to D2737: [gameplay] Add a flaming status effect to iber champion cavalry.

The filename doesn't matter :)

Wed, Nov 18, 4:48 PM
Freagarach added a comment to D2737: [gameplay] Add a flaming status effect to iber champion cavalry.
In D2737#136900, @Stan wrote:

Is it normal that if I stack three fire arrows on a unit it displays three time the icon while if it extends only the duration is updated accordingly?

Wed, Nov 18, 4:28 PM
Freagarach added a comment to D2886: [gameplay] introduce crossbowman templates.

Sorry, it was late ^^'
But, then the balancing department needs to take a look :) (rP23890)

Wed, Nov 18, 4:22 PM
Freagarach added a comment to rP24203: [SM52 2/2] Update to Spidermonkey 52 APIs..

Tested by: Stan, Freagarach

I recall not being able to actually apply let alone test the patch ;)

Wed, Nov 18, 4:18 PM
Freagarach accepted D3070: Allow affecting garrison list via tech.
Wed, Nov 18, 4:10 PM

Mon, Nov 16

Freagarach closed D3097: move structures from other/ to structures/.
Mon, Nov 16, 9:53 PM
Freagarach added a comment to D3098: outpost → lookout.

Would you mind moving to watchtower? (You can read some discussion on IRC today.)

Mon, Nov 16, 9:47 PM
Freagarach requested changes to D2886: [gameplay] introduce crossbowman templates.

Can you please make sure the values don't change?

Mon, Nov 16, 9:26 PM
Freagarach accepted D2595: separate elephant archer from cavalry templates.

Correct, split is nice.

Mon, Nov 16, 9:21 PM
Freagarach committed rP24193: Move entities from other/ to structures/..
Move entities from other/ to structures/.
Mon, Nov 16, 9:06 PM
Freagarach added inline comments to D3094: [SM52] Spidermonkey Upgrade 1/2 : build system upgrade to 52.9.1.
Mon, Nov 16, 8:28 PM
Freagarach added a comment to D3070: Allow affecting garrison list via tech.
  • Nice feature.
  • Code looks good (do need to use EjectOrKill).
  • Works as advertised.
  • Properly tested.
Mon, Nov 16, 7:31 PM
Freagarach added inline comments to D3094: [SM52] Spidermonkey Upgrade 1/2 : build system upgrade to 52.9.1.
Mon, Nov 16, 7:11 PM
Freagarach added a comment to D3070: Allow affecting garrison list via tech.

Could you add a test to check whether entities get ejected when requirements change? (Would also unearth a bug in the current code.)

Mon, Nov 16, 10:32 AM
Freagarach added inline comments to D3070: Allow affecting garrison list via tech.
Mon, Nov 16, 9:00 AM
Freagarach added inline comments to D3081: Make cheering time moddable.
Mon, Nov 16, 8:29 AM
Freagarach added inline comments to D3094: [SM52] Spidermonkey Upgrade 1/2 : build system upgrade to 52.9.1.
Mon, Nov 16, 8:20 AM

Sat, Nov 14

Freagarach added a comment to D3098: outpost → lookout.

(I would actually call the left one a lookout and the right one a watchtower ^^ )

Sat, Nov 14, 2:27 PM
Freagarach accepted D3018: nuba → noba.

Complete, I assume correctness.

Sat, Nov 14, 10:28 AM
Freagarach added a comment to D3073: Use player color for rally point lines in SOW.

Is it?

Sat, Nov 14, 10:15 AM
Freagarach updated the diff for D3099: Play sound of entity that is actually able to perform command..

Missed one.

Sat, Nov 14, 7:29 AM
Freagarach added a comment to D3099: Play sound of entity that is actually able to perform command..

Yeah, I don't like it either, but I keep telling myself this is only done on execution and thus not so often (compared to other GUI functions).

Sat, Nov 14, 7:24 AM
Freagarach added a comment to D3073: Use player color for rally point lines in SOW.

So is the dashing enough visual feedback that the path is uncertain?

Sat, Nov 14, 7:19 AM
Freagarach added a comment to D3081: Make cheering time moddable.
In D3081#136008, @bb wrote:

While at it, might want to make it modifiable

Is that worth the perf loss for something purely visual? I mean, yeah the entity is in a different state, but it will still behave like it's idle (except responding to the idle-unit button -- which is annoying).

Sat, Nov 14, 7:12 AM

Fri, Nov 13

Freagarach accepted D3097: move structures from other/ to structures/.
  • Checkrefs passes.
  • UnitsDemo loads fine.
  • Change is good (entities are structures, although one can argue the tables are not).
Fri, Nov 13, 7:46 PM
Freagarach added a comment to D3098: outpost → lookout.

Well, we also need to keep in mind the understanding of the function to players. I think adding "tower" makes it much more clear. Also, you proposed watchtower earlier (D2551).

Fri, Nov 13, 7:29 PM
Freagarach added a comment to D2595: separate elephant archer from cavalry templates.

Sorry to ask for another rebase ^^

Fri, Nov 13, 7:21 PM
Freagarach requested changes to D3070: Allow affecting garrison list via tech.
Fri, Nov 13, 7:13 PM
Freagarach added a comment to D3073: Use player color for rally point lines in SOW.

Isn't the idea that the path is uncertain and hence reddish?

Fri, Nov 13, 6:49 PM
Freagarach added a comment to D2860: Notify players with a sound when a player is defeated.

What do observers hear?

Fri, Nov 13, 6:44 PM
Freagarach added a comment to D2886: [gameplay] introduce crossbowman templates.

This needs a rebase. Also, why introduce templates which are not used? I mean a mod that needs to introduce the template probably also needs different values? And the templates can be added if units that are to use them are added, right?

Fri, Nov 13, 6:34 PM
Freagarach added a comment to D3090: Promote compartments in ScriptInterface.

(Still working here.)

Fri, Nov 13, 6:25 PM
Freagarach added a comment to D3089: Mass rename CxPrivate to CmptPrivate.

(Still working.)

Fri, Nov 13, 5:20 PM
Freagarach added inline comments to D3094: [SM52] Spidermonkey Upgrade 1/2 : build system upgrade to 52.9.1.
Fri, Nov 13, 4:37 PM
Freagarach added inline comments to D3094: [SM52] Spidermonkey Upgrade 1/2 : build system upgrade to 52.9.1.
Fri, Nov 13, 2:51 PM
Freagarach added a comment to D3094: [SM52] Spidermonkey Upgrade 1/2 : build system upgrade to 52.9.1.

General comments on the build script:

Please quote variables.

And use the same style as used in the rest, i.e. ${varname}.

Fri, Nov 13, 2:18 PM
Freagarach added a comment to D3088: Wrap JS Requests and JSContext* usage in a RAII object..

(Still working here.)

Fri, Nov 13, 2:07 PM
Freagarach added a comment to D2952: Move {civ}_*.xml → {civ}/*.xml in templates..

Indeed. Although this commit wil be _huge_ it will actually encompass one change: moving templates from folder/{civcode}_* to folder/{civcode}/*. But nothing unrelated. E.g. renaming aura's to a similar schema is unrelated and can be done in a separate commit (if ever).

Fri, Nov 13, 1:05 PM
Freagarach added a comment to D2995: Introduce translatable attack names.

the values are chosen such that it would result in an instant kill

(Annoyingly, that is quite wrong.)

Fri, Nov 13, 12:52 PM
Freagarach added a comment to D3094: [SM52] Spidermonkey Upgrade 1/2 : build system upgrade to 52.9.1.

Please quote variables, especialy paths.
Not sure how to fix this (properly):

Fri, Nov 13, 12:38 PM
Freagarach added a comment to D2994: Allow entities without cmpResistance..

Or cmpTargetable and use it also for healing (to inform the healer that we have for example) instead of listening to global ownership changes.

Fri, Nov 13, 10:53 AM
Freagarach added inline comments to D3070: Allow affecting garrison list via tech.
Fri, Nov 13, 10:53 AM