Page MenuHomeWildfire Games

Freagarach
User

Projects

User Details

User Since
Apr 5 2019, 7:29 PM (99 w, 6 d)

Recent Activity

Yesterday

Freagarach added a comment to D3635: Removes deprecated gl_*Matrix builtins from GLSL.

I haven't noticed anything weird or different.

Thu, Mar 4, 9:22 PM
Freagarach updated the diff for D3628: Ungarrison using Garrisonable..

Elaborated.

Thu, Mar 4, 8:30 PM
Freagarach added inline comments to rP14550: add more flexibility to eject units when garrisonHolder is destroyed, fixes….
Thu, Mar 4, 6:50 PM
Freagarach added a comment to D3633: Make attacker data explicitly optional in status effects..

I guess it would be nice to split the arguments and default them to INVALID_ENTITY and INVALID_PLAYER.

Thu, Mar 4, 4:44 PM
Freagarach updated the diff for D2269: Combine attacker data in "data" in attack-related code..

SE.

Thu, Mar 4, 4:42 PM
Freagarach updated subscribers of D3634: Remove JSHint, update eslint to latest..

There was a reason, IIRC @Itms discussed that with @Krinkle on IRC (quite) some time ago.

Thu, Mar 4, 3:59 PM
Freagarach added a comment to D3243: Gamesetup cleanup - separate the data from the view.

It keeps setting undefined players to their defaults.
When no victory condition is defined on game setup opening, it is also not possible to tick the other two conquests, until one changes the victory conditions.
It used to display "Endless game" when not victory conditions were ticket.

Thu, Mar 4, 2:06 PM
Freagarach planned changes to D2126: Give options to switch between specific and generic names..
Thu, Mar 4, 1:39 PM
Freagarach updated the diff for D2126: Give options to switch between specific and generic names..

Rebased.

Thu, Mar 4, 1:37 PM
Freagarach retitled D2269: Combine attacker data in "data" in attack-related code. from Combine attacker data in "attackerData" in attack-related code. to Combine attacker data in "data" in attack-related code..
Thu, Mar 4, 11:56 AM
Freagarach updated the diff for D2269: Combine attacker data in "data" in attack-related code..

Everything is an object.

Thu, Mar 4, 11:27 AM
Freagarach added a comment to D2269: Combine attacker data in "data" in attack-related code..

Ah, I get this now :)

Thu, Mar 4, 10:33 AM
Freagarach updated the diff for D1323: Add Upkeep component..

Added a consequence.

Thu, Mar 4, 9:52 AM
Freagarach added a comment to D781: [gameplay] - Elevation attack bonus for units..

So that's basically the attackerData-diff?

Thu, Mar 4, 9:29 AM

Wed, Mar 3

Freagarach committed rP25000: [Gameplay] - Search for resources near a current location before the init-pos..
[Gameplay] - Search for resources near a current location before the init-pos.
Wed, Mar 3, 7:24 PM
Freagarach closed D3607: [Gameplay] - Search for resources near a current location (mostly a dropsite) before going far away..
Wed, Mar 3, 7:24 PM
Freagarach committed rP24999: Autocontinue after gathering a treasure..
Autocontinue after gathering a treasure.
Wed, Mar 3, 7:21 PM
Freagarach closed D3580: Autocontinue after gathering treasures..
Wed, Mar 3, 7:21 PM
Freagarach updated the diff for D3607: [Gameplay] - Search for resources near a current location (mostly a dropsite) before going far away..

Rebased, comment.

Wed, Mar 3, 7:16 PM
Freagarach added inline comments to D3580: Autocontinue after gathering treasures..
Wed, Mar 3, 6:57 PM
Freagarach abandoned D3291: [POC] - Only stop moving on states that need to..

Nice POC, but unwanted, also not needed ;)

Wed, Mar 3, 6:31 PM
Freagarach added inline comments to D3580: Autocontinue after gathering treasures..
Wed, Mar 3, 6:30 PM
Freagarach requested changes to D3243: Gamesetup cleanup - separate the data from the view.
Wed, Mar 3, 5:30 PM
Freagarach added a comment to D3243: Gamesetup cleanup - separate the data from the view.

I can't reveal the map when in the game?
Conquest is enabled even if it was unticked.
Cheats disabled in-game while enabled according to the settings.
Relic settings are not used/remembered in the game.
World population idem.

Wed, Mar 3, 5:23 PM
Freagarach added a comment to D3243: Gamesetup cleanup - separate the data from the view.

Some things I found:

  • It is now possible to select a biome for a random random map.
  • Selecting the Conquest VC should disable Conquest Structures/Units.
  • I can't start the match:
ERROR: Errors executing script event "Press"
ERROR: JavaScript error: gamesettings/attributes/PlayerAI.js line 23
attribs.settings.PlayerData[i] is undefined
  LegacySerialize@gamesettings/attributes/PlayerAI.js:23:5
  LegacySerialize@gamesettings/GameSettings.js:32:16
  saveFile@gui/gamesetup/Controls/GameSettingsFile.js:48:51
  onLaunchGame@gui/gamesetup/Controls/GameSettingsControl.js:125:26
  launchGame@gui/gamesetup/Controls/StartGameControl.js:35:4
  onPress@gui/gamesetup/Pages/GameSetupPage/Panels/Buttons/StartGameButton.js:60:46
Wed, Mar 3, 5:03 PM
Freagarach requested review of D3580: Autocontinue after gathering treasures..
Wed, Mar 3, 12:58 PM
Freagarach closed D3468: Don't initialise null values in cmpGarrisonHolder..

Thanks :)

Wed, Mar 3, 11:28 AM
Freagarach committed rP24993: Do not initialise null values in cmpGarrisonHolder..
Do not initialise null values in cmpGarrisonHolder.
Wed, Mar 3, 11:19 AM
Freagarach updated the diff for D3468: Don't initialise null values in cmpGarrisonHolder..

Rebased.

Wed, Mar 3, 11:13 AM
Freagarach committed rP24992: Add resources "component test"..
Add resources "component test".
Wed, Mar 3, 9:57 AM
Freagarach closed D3339: Add resources "component test"..
Wed, Mar 3, 9:57 AM
Freagarach updated the diff for D3339: Add resources "component test"..

Rebased.

Wed, Mar 3, 9:50 AM
Freagarach committed rP24991: Let order use solely their message..
Let order use solely their message.
Wed, Mar 3, 9:21 AM
Freagarach closed D3624: Let orders use solely their message..
Wed, Mar 3, 9:21 AM
Freagarach committed rP24990: Fix tests broken between latest rebase and commit of r24989 / rP24989..
Fix tests broken between latest rebase and commit of r24989 / rP24989.
Wed, Mar 3, 9:18 AM
Freagarach committed rP24989: Split treasures from ResourceSupply..
Split treasures from ResourceSupply.
Wed, Mar 3, 8:48 AM
Freagarach closed D3303: Split treasures from ResourceSupply..
Wed, Mar 3, 8:47 AM
Freagarach updated the diff for D3624: Let orders use solely their message..

Rebased.

Wed, Mar 3, 8:10 AM
Freagarach added a comment to rP24979: Implement Single-Player campaigns - Barebones tutorial campaign included..

Hm, I would say not right now, but we probably want to consider starting the tutorial campaign instead.

Yeah, that sounds good.

Wed, Mar 3, 7:54 AM

Tue, Mar 2

Freagarach requested review of D3628: Ungarrison using Garrisonable..
Tue, Mar 2, 9:56 PM
Freagarach updated the Trac tickets for D3627: Use message to handle skirmish replacements..
Tue, Mar 2, 9:10 PM
Freagarach added a comment to D3286: Allow removing player entities when starting a match.

Other things to keep in mind:

  • This breaks victory conditions?
  • Diplomacy panel still shows the removed player.
Tue, Mar 2, 7:21 PM
Freagarach added a comment to D3286: Allow removing player entities when starting a match.

This doesn't seem to always work?
At least not on Acropolis bay ^^

Tue, Mar 2, 7:12 PM
Freagarach published D3627: Use message to handle skirmish replacements. for review.
Tue, Mar 2, 6:54 PM
Freagarach updated the diff for D3303: Split treasures from ResourceSupply..

Rebased.

Tue, Mar 2, 5:11 PM
Freagarach added inline comments to D3303: Split treasures from ResourceSupply..
Tue, Mar 2, 5:10 PM
Freagarach updated the diff for D2379: Give the GarrisonHolder component the power to set garrisoned on an entity with UnitAI, instead of leaving it to UnitAI..

Rebased.

Tue, Mar 2, 4:50 PM
Freagarach committed rP24977: Let entities garrison using cmpGarrisonable..
Let entities garrison using cmpGarrisonable.
Tue, Mar 2, 4:06 PM
Freagarach closed D3280: Let entities garrison using cmpGarrisonable..
Tue, Mar 2, 4:06 PM
Freagarach updated the diff for D3280: Let entities garrison using cmpGarrisonable..

Fix trigger maps.

Tue, Mar 2, 1:40 PM
Freagarach added a comment to D3280: Let entities garrison using cmpGarrisonable..

Those get replaced by the global entity renamed message in GarrisonHolder.

Tue, Mar 2, 1:37 PM
Freagarach updated the diff for D3280: Let entities garrison using cmpGarrisonable..

Update some comments.

Tue, Mar 2, 1:01 PM
Freagarach requested review of D3624: Let orders use solely their message..
Tue, Mar 2, 12:05 PM
Freagarach added a comment to D3584: Adding cheat codes to the manual.

@Nescio I created a ticket for it: #6083.

Tue, Mar 2, 11:32 AM
Freagarach added a comment to D3584: Adding cheat codes to the manual.

Sounds like a globalscript, the cheats (and their actions) in JSON/JS files in data. Nice, doable, but out of scope for this patch, IMHO.

Tue, Mar 2, 11:26 AM
Freagarach added inline comments to D3584: Adding cheat codes to the manual.
Tue, Mar 2, 10:43 AM
Freagarach abandoned D3284: Only clear order queue if replacing order was accepted..

Too large of an endeavour right now.

Tue, Mar 2, 10:21 AM
Freagarach updated the diff for D3284: Only clear order queue if replacing order was accepted..

More elaborate.

Tue, Mar 2, 9:51 AM
Freagarach added a comment to D3618: Replace REJECT_ORDER with FinishOrder().

Okay, so the FSM already enters the next state before finishing processing the message. That means that this.order needs to be set when the order is accepted, and it cannot be set when we know the order has been accepted, which was my plan.

Tue, Mar 2, 9:01 AM
Freagarach committed rP24973: Let domestic animals flee when attacked..
Let domestic animals flee when attacked.
Tue, Mar 2, 7:19 AM
Freagarach closed D193: Domestic animals should flee when attacked too.
Tue, Mar 2, 7:19 AM
Freagarach committed rP24972: Fix Iberian starting walls on Skirmish maps..
Fix Iberian starting walls on Skirmish maps.
Tue, Mar 2, 7:14 AM
Freagarach closed D3616: fix Iberian starting walls on skirmish maps.
Tue, Mar 2, 7:14 AM
Freagarach added a comment to D3616: fix Iberian starting walls on skirmish maps.

This patch fixes the problem and I will commit it. The more elaborate and correct solution should be done, but I regard that more as a feature.

Tue, Mar 2, 7:12 AM

Mon, Mar 1

Freagarach added a comment to D3614: Check for missing auras in GUI Interface.

(Assuming the idea is to give more information than: "Oh no, something broke in your 161-file commit.".)

Mon, Mar 1, 6:01 PM
Freagarach accepted D3614: Check for missing auras in GUI Interface.

It still errors, but now gives also a more informative error :)

Mon, Mar 1, 6:00 PM
Freagarach added a comment to D3618: Replace REJECT_ORDER with FinishOrder().

Smells like D3284?

Mon, Mar 1, 5:52 PM
Freagarach added a comment to D3607: [Gameplay] - Search for resources near a current location (mostly a dropsite) before going far away..

That is exactly what the code does now :)

Mon, Mar 1, 2:38 PM
Freagarach added a comment to D3616: fix Iberian starting walls on skirmish maps.

I guess.

Mon, Mar 1, 2:36 PM
Freagarach added a comment to D3607: [Gameplay] - Search for resources near a current location (mostly a dropsite) before going far away..

Ah, yeah, I experienced that one when testing this ;)

Mon, Mar 1, 2:21 PM
Freagarach updated the diff for D3303: Split treasures from ResourceSupply..

Fix @param on Starting to collect.

Mon, Mar 1, 1:38 PM
Freagarach updated the diff for D3607: [Gameplay] - Search for resources near a current location (mostly a dropsite) before going far away..

Comments.

Mon, Mar 1, 1:13 PM
Freagarach added a comment to D3493: improve consistency in map descriptions.

Yeah, you can purge them. It's kinda guessing which map has the walls and which map doesn't.

Mon, Mar 1, 1:04 PM
Freagarach accepted D3616: fix Iberian starting walls on skirmish maps.

Correct!
I guess I only tested walls on random maps.

Mon, Mar 1, 12:58 PM
Freagarach updated the diff for D3280: Let entities garrison using cmpGarrisonable..

Add ToDo.

Mon, Mar 1, 11:22 AM
Freagarach added inline comments to D3280: Let entities garrison using cmpGarrisonable..
Mon, Mar 1, 9:27 AM
Freagarach added inline comments to D3280: Let entities garrison using cmpGarrisonable..
Mon, Mar 1, 9:18 AM
Freagarach added a comment to D193: Domestic animals should flee when attacked too.

Also, if a domestic animal will be hit by something that cannot slaughter (e.g. splash or a champion), it will flee.

Mon, Mar 1, 9:05 AM
Freagarach updated the diff for D3280: Let entities garrison using cmpGarrisonable..

We don't need the renamed parameter in the GarrisonedUnitsChanged-message anymore.

Mon, Mar 1, 8:01 AM
Freagarach updated the diff for D3280: Let entities garrison using cmpGarrisonable..

Delete holder after renaming.

Mon, Mar 1, 7:52 AM
Freagarach updated the diff for D3303: Split treasures from ResourceSupply..

Rebased.

Mon, Mar 1, 7:46 AM
Freagarach added a comment to D3607: [Gameplay] - Search for resources near a current location (mostly a dropsite) before going far away..

It's probably better than SVN, but it's not optimal :p

Please explain?

Mon, Mar 1, 7:33 AM
Freagarach added inline comments to D3280: Let entities garrison using cmpGarrisonable..
Mon, Mar 1, 7:27 AM
Freagarach updated the diff for D3280: Let entities garrison using cmpGarrisonable..

Fixed tests and renaming turrets.

Mon, Mar 1, 7:27 AM

Sun, Feb 28

Freagarach committed rP24964: Remove corral aura which was not supposed to be committed in r24963..
Remove corral aura which was not supposed to be committed in r24963.
Sun, Feb 28, 10:00 PM
Freagarach updated the diff for D3280: Let entities garrison using cmpGarrisonable..

Rebased.

Sun, Feb 28, 9:37 PM
Freagarach committed rP24963: Decay/Regenerate option for resources..
Decay/Regenerate option for resources.
Sun, Feb 28, 9:15 PM
Freagarach closed D1718: Decay/regenerate option for resources..
Sun, Feb 28, 9:15 PM
Freagarach removed a reviewer for D193: Domestic animals should flee when attacked too: mimo.
Sun, Feb 28, 11:19 AM
Freagarach updated the diff for D193: Domestic animals should flee when attacked too.

Rebased.

Sun, Feb 28, 11:18 AM
Freagarach commandeered D193: Domestic animals should flee when attacked too.

Since D3233 now kills animals in one go when slaughtered, we can fix this.

Sun, Feb 28, 11:17 AM
Freagarach committed rP24960: Resupport more garrisoned slots per entity..
Resupport more garrisoned slots per entity.
Sun, Feb 28, 11:03 AM
Freagarach closed D2056: Resupport more garrisoned slots per entity..
Sun, Feb 28, 11:02 AM
Freagarach updated the diff for D2056: Resupport more garrisoned slots per entity..

Rebased.

Sun, Feb 28, 10:54 AM
Freagarach updated the diff for D3280: Let entities garrison using cmpGarrisonable..

Need to fix turrets switching points due to UnitAI garrisoning on its own.
And tests reveal some other bug.

Sun, Feb 28, 10:34 AM
Freagarach committed rP24958: Allow garrisoned entities to upgrade..
Allow garrisoned entities to upgrade.
Sun, Feb 28, 7:53 AM
Freagarach closed D3251: Allow garrisoned entities to upgrade..
Sun, Feb 28, 7:49 AM
Freagarach committed rP24957: Move some functionality from GarrisonHolder to Garrisonable..
Move some functionality from GarrisonHolder to Garrisonable.
Sun, Feb 28, 7:38 AM
Freagarach closed D3223: Move some functionality from GarrisonHolder to Garrisonable..
Sun, Feb 28, 7:37 AM
Freagarach committed rP24956: Properly discard orders..
Properly discard orders.
Sun, Feb 28, 7:31 AM