Page MenuHomeWildfire Games

Freagarach
User

Projects

User Details

User Since
Apr 5 2019, 7:29 PM (109 w, 14 h)

Recent Activity

Today

Freagarach updated the diff for D3876: [PetraAI] - Let find best dropsite also be able to return a template..

Don't assign undefined.

Sat, May 8, 7:21 AM

Yesterday

Freagarach committed rP25400: Fx low resource supply tricking AI..
Fx low resource supply tricking AI.
Fri, May 7, 11:07 AM
Freagarach closed D3884: Fix low resource supplies tricking AI..
Fri, May 7, 11:07 AM
Freagarach committed rP25399: Let team bonuses also apply to own player..
Let team bonuses also apply to own player.
Fri, May 7, 10:49 AM
Freagarach closed D3899: [Gameplay] - Let team bonuses also apply to themselves..
Fri, May 7, 10:49 AM
Freagarach committed rP25397: Fix returning resources by formation members..
Fix returning resources by formation members.
Fri, May 7, 9:06 AM
Freagarach closed D3931: Fix returning resources by formation members..
Fri, May 7, 9:06 AM
Freagarach committed rP25396: Some small fixes for the AutoQueue feature..
Some small fixes for the AutoQueue feature.
Fri, May 7, 9:02 AM
Freagarach closed D3932: Small fixes for AutoQueue..
Fri, May 7, 9:02 AM
Freagarach added a comment to rP24661: Combines terrain and units ambient colors into the single color..
Fri, May 7, 8:44 AM

Thu, May 6

Freagarach added inline comments to D3934: Use a set for the selection internals..
Thu, May 6, 12:54 PM
Freagarach updated the diff for D3934: Use a set for the selection internals..

So far for private properties in JS,,,

Thu, May 6, 12:53 PM
Freagarach requested review of D3934: Use a set for the selection internals..
Thu, May 6, 12:45 PM
Freagarach updated the diff for D3932: Small fixes for AutoQueue..

Smaller conditional.

Thu, May 6, 11:05 AM
Freagarach requested review of D3932: Small fixes for AutoQueue..
Thu, May 6, 9:51 AM
Freagarach requested review of D3931: Fix returning resources by formation members..
Thu, May 6, 7:27 AM
Freagarach added inline comments to rP25243: Minor fixes after Gathering refactoring..
Thu, May 6, 7:16 AM
Freagarach added inline comments to D3911: Improve the usefulness of the counters in the top panel.
Thu, May 6, 6:52 AM
Freagarach added a comment to rP24989: Split treasures from ResourceSupply..

Oops, you're right!
Well, I've mostly chosen the Collect[e|o]r for its explicit difference from resource gathering.

Thu, May 6, 6:34 AM
Freagarach updated subscribers of D3929: [Gameplay] - Disable TreasureCollecter component in siege engines..

I'm wondering whether it wouldn't be cleaner to explicitly add <TreasureCollecter> in the appropriate templates rather then enable it globally and then disable in multiple templates (siege, ship, dog, fauna etc.)

I'll ping @Nescio for this, since they're basically our "template master" ;)

Thu, May 6, 6:30 AM
Freagarach retitled D3929: [Gameplay] - Disable TreasureCollecter component in siege engines. from Disable TreasureCollecter component in siege engines. to [Gameplay] - Disable TreasureCollecter component in siege engines..
Thu, May 6, 6:27 AM

Wed, May 5

Freagarach updated the diff for D3918: Fix duplicating promoting entities in XP trickling structures..

More explicit function name and function.

Wed, May 5, 6:53 PM
Freagarach added a comment to D3901: Allow toggling repairability..

No biggies, rest looks good. I didn't test.

Wed, May 5, 5:35 PM
Freagarach planned changes to D3532: Pick map in map browser upon hitting return..

Feel free, @wraitii.

Wed, May 5, 5:17 PM
Freagarach added a comment to D3886: Resistance paradigm change: Unspecified value = invulnerable, not 0 resistance..

If you wouldn't specify the resistance, and have an aura that adds one, does that mean you are immune at first but vulnerable thereafter?

Wed, May 5, 5:13 PM
Freagarach committed rP25382: Fix mime-types on images introduced in r25381 / rP25381..
Fix mime-types on images introduced in r25381 / rP25381.
Wed, May 5, 8:21 AM
Freagarach added a comment to D3865: Auto-Queue feature.

Congratz on landing your first patch, @azayrahmad!

Wed, May 5, 8:12 AM · Contributors
Freagarach committed rP25381: Enable production entities to autoqueue..
Enable production entities to autoqueue.
Wed, May 5, 8:12 AM
Freagarach closed D3865: Auto-Queue feature.
Wed, May 5, 8:12 AM · Contributors
Freagarach added inline comments to D3906: Deduplicate add/remove entity to/from resource map..
Wed, May 5, 7:32 AM
Freagarach added inline comments to D3876: [PetraAI] - Let find best dropsite also be able to return a template..
Wed, May 5, 7:25 AM

Tue, May 4

Freagarach added a comment to D3924: GameSpeed parsing explicitedness..

Try to find how to generate a string gamespeed.

Changing it in the match setup page works for me. (As in that saves it to a string.)

Tue, May 4, 12:30 PM
Freagarach added a comment to D3924: GameSpeed parsing explicitedness..
ERROR: JavaScript error: gui/replaymenu/replay_actions.js line 60
Script value conversion check failed: v.isNumber() (got type string)
  reallyStartVisualReplay@gui/replaymenu/replay_actions.js:60:14
  startReplay@gui/replaymenu/replay_actions.js:48:26
  __eventhandler13 (MouseLeftDoubleClickItem)@replaySelection MouseLeftDoubleClickItem:1:1
Tue, May 4, 12:27 PM
Freagarach added inline comments to D3924: GameSpeed parsing explicitedness..
Tue, May 4, 12:25 PM
Freagarach added inline comments to D3901: Allow toggling repairability..
Tue, May 4, 11:35 AM
Freagarach added a comment to D3911: Improve the usefulness of the counters in the top panel.

Is there still enough room on the minimal resolution for the pop info?

Tue, May 4, 11:24 AM
Freagarach added a comment to rP25365: Throw errors instead of warnings on wrong implicit conversions..


This replay gives an error upon replaying it.

Tue, May 4, 10:59 AM
Freagarach added a comment to D3911: Improve the usefulness of the counters in the top panel.

I was wondering, @Langbart, is there any kind of reasoning behind changing the positions of the numbers?

Tue, May 4, 7:56 AM
Freagarach added a comment to D3899: [Gameplay] - Let team bonuses also apply to themselves..

If no-one voices against, I'll try to commit this this week.

Tue, May 4, 7:50 AM
Freagarach added a comment to D3868: [gameplay] fish and fruit regeneration.

@Nescio do you agree that the tip text needs a change now?

Tue, May 4, 7:48 AM
Freagarach committed rP25368: Let entity react on target death directly..
Let entity react on target death directly.
Tue, May 4, 7:18 AM
Freagarach closed D2129: Let entity react on target death directly..
Tue, May 4, 7:18 AM

Mon, May 3

Freagarach committed rP25364: Add some missing credits..
Add some missing credits.
Mon, May 3, 4:04 PM
Freagarach closed D3880: Add some missing credits..
Mon, May 3, 4:04 PM
Freagarach added a comment to D3880: Add some missing credits..

PS: If I would make a second account, I would call myself Lancelot :)

We can a.k.a. you then. :)

Mon, May 3, 4:03 PM
Freagarach committed rP25363: Allow triggers to spawn turreted entities..
Allow triggers to spawn turreted entities.
Mon, May 3, 10:55 AM
Freagarach closed D3872: Allow triggers to spawn turreted entities..
Mon, May 3, 10:55 AM
Freagarach added inline comments to D3911: Improve the usefulness of the counters in the top panel.
Mon, May 3, 10:42 AM
Freagarach added inline comments to D3911: Improve the usefulness of the counters in the top panel.
Mon, May 3, 8:50 AM
Freagarach added inline comments to D3865: Auto-Queue feature.
Mon, May 3, 8:20 AM · Contributors
Freagarach updated the diff for D3865: Auto-Queue feature.

Some slight adaptations, added a unit test.

Mon, May 3, 8:17 AM · Contributors

Sun, May 2

Freagarach resigned from D3210: Throw errors instead of warnings on wrong implicit conversions..
Sun, May 2, 2:27 PM
Freagarach added a comment to D3884: Fix low resource supplies tricking AI..

I'll commit this next week, unless someone objects.

Sun, May 2, 12:40 PM
Freagarach accepted D3865: Auto-Queue feature.

This is a nice feature.
There are some minor code-style issues, but I'll handle those when comittting.

Sun, May 2, 12:21 PM · Contributors
Freagarach requested review of D3918: Fix duplicating promoting entities in XP trickling structures..
Sun, May 2, 11:51 AM
Freagarach added a comment to D3886: Resistance paradigm change: Unspecified value = invulnerable, not 0 resistance..

So on the one hand I have the idea: If you don't know something you can still be damaged by it. On the other hand our simulation in more places assumes that if you don't know something, you can't use it. (I'm leaning to prefering the latter now.)

Sun, May 2, 8:24 AM
Freagarach updated the summary of D2129: Let entity react on target death directly..
Sun, May 2, 8:22 AM
Freagarach added a comment to D2129: Let entity react on target death directly..

I'll try to land this somewhere this week. (Notice it makes units with long repeat times (like elephants) a bit more effective.)

Sun, May 2, 8:22 AM
Freagarach added inline comments to rP25353: Generalize icon-specific tooltips to a tag, streamline code..
Sun, May 2, 8:06 AM
Freagarach added inline comments to D3901: Allow toggling repairability..
Sun, May 2, 8:01 AM

Sat, May 1

Freagarach added inline comments to D3911: Improve the usefulness of the counters in the top panel.
Sat, May 1, 6:41 AM

Fri, Apr 30

Freagarach updated the diff for D3876: [PetraAI] - Let find best dropsite also be able to return a template..

Don't error when we can't construct anything at all. (E.g. Survival of the Fittest.)

Fri, Apr 30, 11:38 AM
Freagarach requested review of D3906: Deduplicate add/remove entity to/from resource map..
Fri, Apr 30, 10:46 AM
Freagarach added inline comments to D3901: Allow toggling repairability..
Fri, Apr 30, 9:39 AM
Freagarach committed rP25345: Count resource gatherers also when returning their resources..
Count resource gatherers also when returning their resources.
Fri, Apr 30, 8:24 AM
Freagarach closed D3226: Count resource gatherers also when returning their resource..
Fri, Apr 30, 8:24 AM

Thu, Apr 29

Freagarach updated the diff for D3226: Count resource gatherers also when returning their resource..

Force reentering the GATHER state.

Thu, Apr 29, 5:33 PM
Freagarach updated the diff for D3226: Count resource gatherers also when returning their resource..

Clarified comment.

Thu, Apr 29, 5:27 PM
Freagarach added inline comments to D3226: Count resource gatherers also when returning their resource..
Thu, Apr 29, 5:16 PM
Freagarach added a comment to D3901: Allow toggling repairability..

It seems to me that we won't stop repairing if we are already repairing and the flag is switched. Have you tested that?

Thu, Apr 29, 12:25 PM

Wed, Apr 28

Freagarach updated the diff for D3876: [PetraAI] - Let find best dropsite also be able to return a template..

Exclude CCs and Docks.

Wed, Apr 28, 6:18 PM
Freagarach added a comment to D3876: [PetraAI] - Let find best dropsite also be able to return a template..

(It should, but another diff.)

Wed, Apr 28, 4:54 PM
Freagarach added a comment to D3876: [PetraAI] - Let find best dropsite also be able to return a template..

We can hardcode to exclude CC and dock? (Although a dock may be a viable choice for a dropsite.)

Wed, Apr 28, 4:44 PM
Freagarach added a comment to D3876: [PetraAI] - Let find best dropsite also be able to return a template..

Yeah, it checks which structures are buildable at that time, so it won't try to build a CC in phase 1. But in phase 2 she may try that. (Although a quick match (to city phase) did not show that.)

Wed, Apr 28, 4:31 PM
Freagarach retitled D3898: [Gameplay] - Make outposts useful again. from Make outposts useful again. to [Gameplay] - Make outposts useful again..
Wed, Apr 28, 3:15 PM
Freagarach updated the diff for D3899: [Gameplay] - Let team bonuses also apply to themselves..

Tooltips.

Wed, Apr 28, 1:50 PM
Freagarach requested review of D3899: [Gameplay] - Let team bonuses also apply to themselves..
Wed, Apr 28, 1:38 PM
Freagarach added inline comments to D3898: [Gameplay] - Make outposts useful again..
Wed, Apr 28, 1:20 PM
Freagarach added a comment to D3876: [PetraAI] - Let find best dropsite also be able to return a template..

It would indeed be good to check for some more stuff. The function findBestDropsiteLocation should take build restrictions into account.

Wed, Apr 28, 1:05 PM
Freagarach updated the diff for D3876: [PetraAI] - Let find best dropsite also be able to return a template..

Linter.

Wed, Apr 28, 12:39 PM
Freagarach added a comment to D3898: [Gameplay] - Make outposts useful again..

We could use this to put a undamageable "scout" turret on the outpost?

Wed, Apr 28, 12:28 PM
Freagarach added a comment to rP25329: Removes ShaderProgramPtr argument from DebugRenderer methods..
SilhouetteRenderer.cpp
../../../source/renderer/SilhouetteRenderer.cpp: In member function ‘void SilhouetteRenderer::RenderDebugOverlays(const CCamera&)’:
../../../source/renderer/SilhouetteRenderer.cpp:445:61: warning: unused parameter ‘camera’ [-Wunused-parameter]
 void SilhouetteRenderer::RenderDebugOverlays(const CCamera& camera)
                                                             ^~~~~~
Wed, Apr 28, 12:17 PM
Freagarach updated the diff for D3876: [PetraAI] - Let find best dropsite also be able to return a template..

Use findStructure from the buildManager.

Wed, Apr 28, 12:14 PM
Freagarach added inline comments to D3889: Fix some translation.
Wed, Apr 28, 10:48 AM
Freagarach added a comment to D3898: [Gameplay] - Make outposts useful again..

Or more increased resistance and vision for occupying units?

Wed, Apr 28, 10:48 AM
Freagarach added a comment to D3879: [PetraAI] - Allow to get a current list of buildable structures..

Hmm, might be duplication of the data in buildManager.js?

This will be the unoptimised version ^^ So this could still be in, but not used by PetraAI.

Wed, Apr 28, 8:44 AM
Freagarach added a comment to D3846: Combine area damage schema in Attacking.js-helper..

Area damage is already tested?

Wed, Apr 28, 7:26 AM

Tue, Apr 27

Freagarach updated the diff for D3884: Fix low resource supplies tricking AI..

There seems to be no reason for the floor (code introduced in rP13907), so just ditch that.

Tue, Apr 27, 9:07 PM
Freagarach planned changes to D3874: [PetraAI] - Check for droppable resources in FindBestDropsite..

Suggestions @Angen?
I think we should check that in the filter. I.e. if we pass a checkFoundations flag, we use getBuiltTemplate to also check the what the foundation becomes?

Tue, Apr 27, 9:28 AM
Freagarach added inline comments to D3876: [PetraAI] - Let find best dropsite also be able to return a template..
Tue, Apr 27, 9:00 AM

Mon, Apr 26

Freagarach set the repository for D3865: Auto-Queue feature to rP 0 A.D. Public Repository.
Mon, Apr 26, 8:56 AM · Contributors
Freagarach updated subscribers of D3865: Auto-Queue feature.

This seems to be good now. @wraitii can you confirm this is the behaviour you requested? I'm okay with it now, it means indeed a little more thought needs to go in before activating autoqueue.
@Stan can you check out the icons and give us your opinion about them?

Mon, Apr 26, 8:55 AM · Contributors
Freagarach updated the diff for D3880: Add some missing credits..

@mysticjim's preference.

Mon, Apr 26, 8:10 AM
Freagarach added a comment to D3891: Adjust animals' walking speed.

Thanks for the patch :)

  1. You can use the Atlas "Actor viewer" to check out units animations.
  2. Please upload using full context :)
  3. Please correctly set the repository when uploading patches, that allows our linters to run on your differential. (I've set it now for you.)
Mon, Apr 26, 7:54 AM
Freagarach set the repository for D3891: Adjust animals' walking speed to rP 0 A.D. Public Repository.
Mon, Apr 26, 7:50 AM
Freagarach added inline comments to D3889: Fix some translation.
Mon, Apr 26, 7:49 AM
Freagarach updated the test plan for D3889: Fix some translation.
Mon, Apr 26, 7:45 AM
Freagarach added inline comments to D3876: [PetraAI] - Let find best dropsite also be able to return a template..
Mon, Apr 26, 7:40 AM
Freagarach updated subscribers of D3886: Resistance paradigm change: Unspecified value = invulnerable, not 0 resistance..

I am not yet convinced, I may need to let this land a bit.
This also seems to directly affect D368, so I'm pinging @bb also.

Mon, Apr 26, 7:39 AM
Freagarach added a comment to rP25308: Hotloading fix after rP25210.
Unit.cpp
../../../source/graphics/Unit.cpp: In static member function ‘static CUnit* CUnit::Create(const CStrW&, uint32_t, const std::set<CStr8>&, CObjectManager&)’:
../../../source/graphics/Unit.cpp:44:22: warning: unused variable ‘success’ [-Wunused-variable]
  auto [success, actor] = objectManager.FindActorDef(actorName);
                      ^
Mon, Apr 26, 7:20 AM