Fix ranged unit chasing following rP24797
ClosedPublic
Actions

Authored by wraitii on Jan 27 2021, 10:28 PM.

Details

Reviewers: None
Commits: rP24803: Fix ranged unit chasing following rP24797
Trac Tickets: #5936

Summary

D3230 / rP24797 introduced range checking at turn start, and removed a hack that made units predict the position of their target too far ahead. This worked fine when in "straight movement" mode, unfortunately I failed to recognise that ranged units would never use that mode. This meant that ranged-unit chasing was broken.

There is a straightforward fix however, since we can simply change TryGoingStraightToTarget to do that. It fixes the issue efficiently and improves movement for ranged units in general, so it probably should have been done from the start.

Test Plan

Run the test map. Chase stuff with ranged units.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.Jan 27 2021, 10:28 PM

wraitii mentioned this in rP24797: Check for movement success/failure on turn start..Jan 27 2021, 10:29 PM

Build is green

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2_dbg.a(precompiled.o) has no symbols
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framewor

See https://jenkins.wildfiregames.com/job/macos-differential/3098/display/redirect for more details.

This revision was not accepted when it landed; it landed in state Draft.Jan 27 2021, 10:55 PM

This revision was landed with ongoing or failed builds.

Closed by commit rP24803: Fix ranged unit chasing following rP24797 (authored by wraitii). · Explain Why

This revision was automatically updated to reflect the committed changes.

wraitii added a commit: rP24803: Fix ranged unit chasing following rP24797.

Harbormaster completed remote builds in B15466: Diff 15745.Jan 27 2021, 10:57 PM